[00:00:41] TimStarling: I'm getting results now with that last tcpdump command [00:01:38] 106 packets captured; 110 packets received by filter; 0 packets dropped by kernel [00:01:49] TimStarling: Anything in particular I'm looking for? I see http requests and responses. [00:02:12] what exact command did you use? [00:02:30] tcpdump host and port 80 -s1500 -A [00:02:36] (my ip address) [00:02:43] then I opened a few tabs in the browser [00:03:11] is it necessary to open multiple tabs to reproduce it? [00:03:31] No [00:03:42] what I would like is a tcpdump trace of a single HTTP request [00:03:54] which is slow according to the client [00:04:55] Got it [00:05:37] specifically we are looking for the time between when the request is received, the time when the response is sent, and the time when the connection is closed if it is not keepalive [00:05:45] This one took 16 seconds according to the browser [00:05:52] https://gist.github.com/Krinkle/5572587 [00:06:16] url http://docs.jquery.com/ (the load.php ones are spawned naturally as well) [00:06:54] client side waterfall chart of this same request: http://cl.ly/image/1G2R0P3s3G3W [00:07:31] ok, well that is confirmed then [00:08:11] so the question now is: why can't you find that socket in lsof during the 16 seconds that it is open? [00:10:10] maybe try broadening your search criteria [00:10:15] TimStarling: I'm trying to find those timestamps, but I don't see them. [00:10:26] I see the 17:04 prefixes, I assume those are it [00:10:35] yes [00:10:43] request received at 17:04:22.102244 [00:10:53] response sent at 17:04:38.329799 [00:11:14] ah, I see them now [00:11:21] I was looking at the wrong line [00:11:49] maybe your HTTP requests are going via an ISP proxy [00:12:15] no, we know your IP address from tcpdump, never mind [00:12:27] Indeed [00:13:23] TimStarling: btw, are you getting the same in your browser? [00:13:32] Try hitting http://docs.jquery.com/ or http://stage.docs.jquery.com/ [00:13:52] i am [00:14:18] Thanks [00:14:42] In Chrome I can see the 10~16s is spent "Waiting" not "Receiving" [00:15:09] DN Lookup 1ms, Connecting 104ms, Sending 1ms, Waiting 16.36ms, Receiving 1ms [00:15:14] DNS* [00:15:33] I get 7s response times from docs.jquery.com [00:15:41] TimStarling: 304, right? [00:15:46] New patchset: MarkTraceur; "Add parsoid-specific image testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [00:15:50] yes [00:15:53] ok [00:15:56] New patchset: EBernhardson; "Notification agent whitelist and blacklist" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62624 [00:16:11] Weeeeird [00:16:15] curl -vvv -X TRACE 'http://docs.jquery.com/' takes a while to issue an HTTP 405, and that never leaves apache [00:16:46] I'm gonna try `lsof -i4 -n | grep IP` again [00:17:06] some insane regexes in mod_rewrite or something? [00:17:28] taking the incoming url, splitting it up, generating the complete works of shakespare, and recombining it? [00:17:31] ori-l: https://github.com/Krinkle/docs.jquery.com/blob/master/httpd/docs.jquery.com [00:17:41] Not that I know of [00:17:54] you can also try netstat, in theory a socket could show up in netstat and not lsof if there was something badly wrong with your kernel or something [00:19:11] FYI: This is machine is running Linux 2.6.32-028stab101.1 [00:20:07] nope, nothing in lsof [00:20:59] Krinkle: what's in public_html/.htaccess? [00:21:21] ori-l: It shouldn't exist, but I can check [00:21:35] ori-l: https://github.com/Krinkle/docs.jquery.com/blob/master/www/public_html/.htaccess [00:21:40] nothing notable [00:22:20] TimStarling: Lookin at unfiltered lsof -i4 -n I see various mentioning 'www' [00:22:36] They look all like this [00:22:39] apache2 27886 www-data 19u IPv4 1457568611 0t0 TCP 216.70.110.53:www->2.49.33.151:61588 (ESTABLISHED) [00:22:42] with different ports [00:22:49] but all between those 2 IP addresses [00:23:10] ah, i reacreated my extension. Should be faster now, but this is trixy. [00:23:15] have you got any connections from 101.174.*? [00:23:28] * mooey|finals wants a gerrit API [00:23:35] New patchset: Bsitu; "Fix notification listing query." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62851 [00:23:39] I've got curl hitting stage.docs.jquery.com in an infinite loop [00:23:46] ooh, something happened [00:23:51] it got fast [00:24:05] it reached infinity [00:24:27] TimStarling: nothing matching '101' even [00:24:36] I killed it, it's fast now [00:24:54] New patchset: EBernhardson; "Remove dead code" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63583 [00:24:59] you fixed a site by DDOSing it? [00:25:05] lol [00:25:07] TimStarling: Still slow here [00:25:10] it went from ~15s to ~9s to 2s to 0.8s [00:25:23] TimStarling: Try http://docs.jquery.com/Special:Interwiki [00:25:51] I got a few from '75.101.*' just now [00:26:19] and 101.174.* now [00:26:29] TimStarling: Yep, got a few [00:26:31] Special:Interwiki took 17s [00:27:00] ok, and / is back up to 15s [00:27:08] phew [00:27:13] * TimStarling hates heisenbugs [00:28:37] Just a break point here, feel free to step out. I've spent almost 2 hours on this now and though the wiki being awfully slow is a problem, most content on the jqwiki has been migrated away and it isn't a super hot target. It can wait a day. Don't want to keep you from doing something else [00:29:22] I have managed to get a few things done in the background [00:29:23] I've saved everything and will put it into a public report. Perhaps someone else can lay some eyes on this, else I'll revisit tomorrow. [00:29:30] TimStarling: I expect nothing less :) [00:29:31] it got fast again [00:30:19] It seems faily fast for me as well now. I wonder how long it'll last. [00:32:06] can you post the rest of the apache config? [00:32:12] not just the vhost i mean [00:32:24] ori-l: The rest should be default debian/httpd. Nothing fancy [00:32:27] Let me check [00:34:12] ori-l: TimStarling: FYI s5fs is from #jquery-infrastructure [00:34:49] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62624 [00:35:30] : apache2 27886 www-data 19u IPv4 1457568611 0t0 TCP 216.70.110.53:www->2.49.33.151:61588 (ESTABLISHED) [00:35:35] (repeating for s5fs) [00:35:43] There are a lot of those in the dump I made earlier [00:35:51] I first thought it was a proxy within Media Temple [00:36:01] then I finally found a few different ones from ourselves [00:36:04] so that rules that out [00:36:52] Perhaps that IP is DOSing the site? [00:37:01] Feels like it [00:37:09] That would explain the fact that it happened out of nowhere with no changes from our end. [00:37:36] I mean, it could be they're just indexing, but it's fairly aggressive. [00:39:19] I'm not getting any host name from the IP [00:39:25] the internet tells me it is an IP from Dubai [00:39:59] same [00:41:35] assume stupidity [00:41:48] hehe [00:42:00] yeah, sorry for not figuring this out for you [00:42:15] that user's requests are slow because of the session issue [00:42:23] New patchset: Mattflaschen; "Add server-side logging to snippets." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63601 [00:42:35] and s/he is using up all the apache child slots [00:42:45] so additional requests get held in the listen queue [00:42:57] which expands to the point where the dubai user's timeout is set [00:43:14] so if you fix the session issue, the anon issue should be fixed [00:45:27] TimStarling: Yep, makes sense. I'll see about putting sessions in memcached [00:48:21] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62758 [00:51:50] If there's anyone available for a couple of minutes, I'd love to get a quick review on my extension page? Is it clear and did I miss anything? http://www.mediawiki.org/wiki/Extension:ExtensionStatus [00:53:00] mooey|finals: that looks quite neat [00:53:40] TimStarling: Right now most things are using CACHE_ACCEL, you'd recommend placing sessions in MEMCACHED specifcally or just in object cache in general? [00:54:32] yay, thanks :) [00:54:56] I guess you could put sessions in CACHE_ACCEL [00:55:14] mooey|finals: BTW, you've got your repo now. [00:55:18] mooey|finals: If you didn't see. [00:56:02] ori-l: Hey, two quick questions about EventLogging, and a reminder re. core-ifying PostEdit; you free for a chat? [00:57:02] James_F: sure, what's up? [00:58:32] ori-l: On EventLogging, I'm (a) curious to see if there's existing code we can copy-and-paste rather than invent our own (given that Rob, who was going to do this, is now out of action for a bit), and (b) worried about scale (we're talking about logging every click of edit, attempted save, and successful save for all VE-able pages, so ~50%? of RC) - is this going to be OK? [00:58:59] ori-l: And on the PostEdit, if we're going to switch VE to use it rather than our own solution, it needs a timetable for happening. Ideally before July. :-) [00:59:05] TimStarling: ori-l: s5fs: Installed Memcached and set up wgMemCachedServers. Left caching set to CACHE_ACCEL for now and enabled wgSessionsInObjectCache. [00:59:12] on stage.docs only [00:59:19] Restarted apache as well [00:59:30] the edit rate is not so high [00:59:38] James_F: if you write a schema, it'll generate the code for you [00:59:47] James_F: go to https://meta.wikimedia.org/wiki/Schema:NavigationTiming, click the red button in the top right [01:00:05] James_F: oh! neat! I didn't see that.. where do I see it? [01:00:06] ori-l: Ah, nice. [01:00:36] All that's left is for the logging code to fill in the values; EL can't do that for you since it's dumb about the content of your records. It just knows their structure. [01:00:41] mooey|finals: https://www.mediawiki.org/w/index.php?title=Git/New_repositories/Requests/Entries&diff=689641&oldid=689624 :-) [01:00:47] mooey|finals: Just push to the place. [01:01:13] ori-l: Interesting. Will play with it and try it out. May need to talk with Dario to check I've not made a fool of myself. :-) [01:01:26] ori-l: Thank you! [01:01:32] TimStarling: Note that stage is locked. the real wiki (where the same slowness is happening) is also not very active, though today quite a bit: http://docs.jquery.com/Special:RecentChanges [01:01:38] James_F: but wait, there's more :) [01:02:03] there's https://www.mediawiki.org/wiki/Extension:EventLogging/Guide [01:02:11] which isn't as prominent as it should be [01:02:13] Rolled out the new settings on both stage and non-stage. [01:02:40] TimStarling: What made you think the sessions could be the curlput? IO access? [01:02:46] ori-l: That looks great! [01:03:03] mooey|finals: I'd change your readme so "http://yourmediawiki.com/Special:ExtensionStatus" is "http://yourmediawiki.com/wiki/Special:ExtensionStatus" - which is the more usual style [01:03:15] because your lsof/strace output showed a lock wait on /tmp/sess_* [01:03:57] TimStarling: Right, of course. [01:04:10] and re: scale: it's very hard to know. Nothing is bottle-necked at the moment -- far from it, in fact -- the machine that was allocated for EL is basically yawning. it's running some solr stuff just to look busy. it's possible that there's a very hard limit that we'll hit because i made some boneheaded architectural choice, but we won't know until we hit it, probably. [01:04:47] ori-l: Cool. :-) [01:04:48] all that I can say is that at the moment it's laughably underutilized, from the perspective of system resources. [01:05:00] ori-l: Would we need a different box if we were measuring non-enwiki stuff? [01:05:01] mooey|finals: Also, seems odd to suggest users download tarballs for your extension when the extension is in a repo ;) [01:05:06] ori-l: you're worried about like 1 request per second [01:05:18] my phone could process a stream of that rate [01:05:37] TimStarling: Sure, but it peaks. [01:05:39] TimStarling: i'm not, we get much more than that, but yes, I'm aware that i'm being over-cautious [01:06:10] mind you, my phone only has about 1MB of storage space I think, so it would fill up pretty quick ;) [01:06:19] Reedy: I was trying to be noobie friendly :P [01:06:33] mooey|finals: Put both? :) [01:06:35] mooey|finals: getLOcalChangeTime [01:06:42] but also, I realized that i'm going to move it to a Gerrit repo soon, so that section would change [01:06:46] ah true, i can do that [01:06:58] hm? typo? [01:07:03] Still, if James_F is going to be making production decisions on the assumption that a system can handle X load, it'd be dishonest of me to assure him that it could when it hasn't yet, at least not in production. But James_F, if you ask the less-scrupulous version of me, it should be fine, yes. [01:07:10] Capital O looks silly [01:07:18] * James_F gris at ori-l. [01:07:19] oh! see it. Thanks! [01:07:22] * James_F grins, too. [01:07:51] and TimStarling, 30/s :) http://ganglia.wikimedia.org/latest/graph.php?r=day&z=xlarge&title=EventLogging&vl=events+%2F+sec&x=&n=&hreg[]=vanadium.eqiad.wmnet&mreg[]=%5E%28client-generated-raw%7Cserver-generated-raw%7Cvalid-events%29%24>ype=stack&glegend=show&aggregate=1 [01:07:56] TimStarling: Looks like that fixed it, not just temporarily in the heisenbug way. [01:08:00] TimStarling: Thanks a ton! [01:08:15] Krinkle: no problem [01:08:18] https://github.com/Krinkle/docs.jquery.com/commit/46334edaa6d637be6a549b0b2843ff71af407f19 [01:08:32] though your phone could handle that too [01:08:33] TimStarling: I looked up the code in mediawiki that this toggle triggers [01:08:47] TimStarling: I'm surprised to find it does actually calls php's session_* functions still [01:09:00] I figured it would bypass those and through our abstraction layer use a different backend [01:09:11] but it looks like php supports a hook in its own abstaction layer [01:09:13] is that nwe? [01:09:14] new*( [01:09:21] Now I need to figure out how to migrate my extension over [01:09:26] to Gerrit. [01:10:00] you mean is session_set_save_handler() new? [01:10:07] if so, the answer is no [01:11:08] mooey|finals: Request a repo to be created. You can then import the history, and then move it back to a gated trunk type model... Chad might be able to do the initial import for you [01:11:38] TimStarling: Indeed. Well, in that case PHP is slightly less evil :) [01:11:52] New patchset: EBernhardson; "Remove dead code" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63583 [01:12:26] mooey|finals: Added 5 issues for you ;D [01:15:09] New review: Mwalker; "https://gerrit.wikimedia.org/r/#/c/63252/" [wikimedia/fundraising/civicrm] (master) - https://gerrit.wikimedia.org/r/53653 [01:15:25] hah yay!! [01:15:29] thanks :D [01:15:31] New patchset: Mwalker; "Initial Version of Twig L10N Filters" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63252 [01:16:12] Reedy: James_F helped me with that, and he says the repo's been created. I just need to figure out how to start working with it now. I know some git, but not quite perfect with it, it's one of the reasons I went for GitHub for the first run. [01:16:49] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ExtensionStatus.git might be of some use [01:17:12] Gives you remote URLs to use that you can add [01:17:39] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Ads] (master) - https://gerrit.wikimedia.org/r/63604 [01:17:52] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/BreadCrumbs2] (master) - https://gerrit.wikimedia.org/r/63605 [01:17:52] !! [01:17:56] that.. is really cool. [01:18:04] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Censor] (master) - https://gerrit.wikimedia.org/r/63606 [01:18:16] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/63607 [01:18:21] I know, I'm getting excited over silly things, but I have to say: having a repo in gerrit's really cool. [01:18:23] Reedy: I see you haven't given up on .svn yet :P [01:18:28] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ExtensionStatus] (master) - https://gerrit.wikimedia.org/r/63608 [01:18:36] Krinkle: It's copy pasta from another extension :D [01:18:40] I know I know [01:18:40] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/63609 [01:18:48] Excuses excuses [01:18:50] It seems there's been quite a few new repos [01:18:52] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ListTransclusions] (master) - https://gerrit.wikimedia.org/r/63610 [01:19:05] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/LoopFunctions] (master) - https://gerrit.wikimedia.org/r/63611 [01:19:16] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Moodle] (master) - https://gerrit.wikimedia.org/r/63612 [01:19:28] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/MsLinks] (master) - https://gerrit.wikimedia.org/r/63613 [01:19:40] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/MsUpload] (master) - https://gerrit.wikimedia.org/r/63614 [01:19:46] What would really cool would be a gerrit API [01:19:52] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/63615 [01:19:57] so I can check on latest commits through some json output [01:20:05] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/PurposeCentricSearch] (master) - https://gerrit.wikimedia.org/r/63616 [01:20:17] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/StoryParagraph] (master) - https://gerrit.wikimedia.org/r/63617 [01:20:23] mooey|finals: https://gerrit-review.googlesource.com/Documentation/rest-api.html [01:20:29] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/TimezoneSelector] (master) - https://gerrit.wikimedia.org/r/63618 [01:20:30] but Reedy your cache idea is awesome. I think I will use that at least for the first version. I may be able to find another solution [01:20:39] Reedy: I read that actually, but couldn't make it work on wikimedia's gerrit [01:20:41] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/UserSnoop] (master) - https://gerrit.wikimedia.org/r/63619 [01:20:51] You should be able to add an amount of caching without adding too many lines of code either [01:21:19] Hmmmm. [01:21:44] Store your data in a logical structure, push it into Memcached/similar [01:22:34] I need to read about memcached and cache in general. I've never done that before in code. [01:22:53] Ironically, I am going over CPU caches for the finals :P [01:22:58] but that's not the same... [01:23:11] curl -H "Accept: application/json; Content-Type: application/json; charset=utf-8" -X GET https://gerrit.wikimedia.org/r/projects/?d [01:23:22] ^ lots of output for you! [01:23:40] mooey|finals: also, https://gerrit-review.googlesource.com/Documentation/rest-api.html [01:23:49] ori-l: [02:20:23] mooey|finals: https://gerrit-review.googlesource.com/Documentation/rest-api.html [01:23:50] ;) [01:24:27] oops, i missed that [01:24:29] :D [01:24:38] ... Reedy ... hah! [01:24:44] ... why didn't it work for me. [01:24:56] Reedy rigged it, probably [01:25:24] hehe [01:25:34] * James_F kills bugzilla. [01:25:45] that can solve the entire thing actually. Well, that and some cache. [01:26:57] Change merged: Reedy; [mediawiki/extensions/Ads] (master) - https://gerrit.wikimedia.org/r/63604 [01:28:09] New review: Cariaso; "confirmed to work for me." [mediawiki/extensions/SemanticForms] (master) C: 1; - https://gerrit.wikimedia.org/r/61815 [01:29:36] Change merged: Reedy; [mediawiki/extensions/BreadCrumbs2] (master) - https://gerrit.wikimedia.org/r/63605 [01:30:32] Change merged: Reedy; [mediawiki/extensions/Censor] (master) - https://gerrit.wikimedia.org/r/63606 [01:30:42] Change merged: Reedy; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/63607 [01:30:45] Change merged: Reedy; [mediawiki/extensions/ExtensionStatus] (master) - https://gerrit.wikimedia.org/r/63608 [01:30:50] Change merged: Reedy; [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/63609 [01:30:53] Change merged: Reedy; [mediawiki/extensions/ListTransclusions] (master) - https://gerrit.wikimedia.org/r/63610 [01:31:20] Change merged: Reedy; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/63615 [01:31:23] Change merged: Reedy; [mediawiki/extensions/MsUpload] (master) - https://gerrit.wikimedia.org/r/63614 [01:31:27] Change merged: Reedy; [mediawiki/extensions/MsLinks] (master) - https://gerrit.wikimedia.org/r/63613 [01:31:31] Change merged: Reedy; [mediawiki/extensions/Moodle] (master) - https://gerrit.wikimedia.org/r/63612 [01:31:35] Change merged: Reedy; [mediawiki/extensions/LoopFunctions] (master) - https://gerrit.wikimedia.org/r/63611 [01:31:54] Change merged: Reedy; [mediawiki/extensions/UserSnoop] (master) - https://gerrit.wikimedia.org/r/63619 [01:31:59] Change merged: Reedy; [mediawiki/extensions/TimezoneSelector] (master) - https://gerrit.wikimedia.org/r/63618 [01:32:02] Change merged: Reedy; [mediawiki/extensions/StoryParagraph] (master) - https://gerrit.wikimedia.org/r/63617 [01:32:08] Change merged: Reedy; [mediawiki/extensions/PurposeCentricSearch] (master) - https://gerrit.wikimedia.org/r/63616 [01:32:31] New review: Adamw; "Please note my comments on the previous change-id" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63252 [01:35:14] New patchset: Mattflaschen; "DO NOT MERGE - Add afterRemoval hook." [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [01:35:26] New patchset: Mattflaschen; "DO NOT MERGE - Show toolbar after post-edit is done, if applicable." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [01:36:12] hmmmm. Can't find 'latest commits' in the gerrit rest api. [01:36:50] ok, I think the more important / urgent thing is cleaning up my code (them spaces and linebreaks are a-killin' me in windows) and setting up some cache [01:37:13] that will make it work well enough to then figure out a better way to reading the remote git infos. [01:39:55] New review: Adamw; "minor issues before we can merge." [wikimedia/fundraising/crm] (master) C: -1; - https://gerrit.wikimedia.org/r/63252 [01:42:10] New review: Mattflaschen; "This is required by https://gerrit.wikimedia.org/r/#/c/62778/" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/63105 [01:43:09] James_F: The goal for VE is still June? [01:43:40] Susan: End-June for deployment in very early July, yes. [01:43:52] Hmmm. [01:44:16] It doesn't seem very stable. [01:44:25] Susan: Bug reports appreciated. :-) [01:44:34] Susan: In any particular way? [01:44:36] The pawns. [01:45:07] Susan: Yes? Which of the 10 or so different bugs which we fixed that caused slugs to be transferred into the data model? :-) [01:45:23] So I went to mediawiki.org just now. [01:45:30] And I clicked edit, added a space, removed a space. [01:45:33] And clicked "show changes". [01:45:38] And I get this silly-looking diff. [01:46:36] Susan: "Silly-looking" isn't a bug report. :-) [01:47:44] That notice that pops up every time you click edit doesn't drive anyone else crazy? [01:47:54] Every single time. "You're using the alpha version." [01:48:22] Susan: That's going away soon. You know, when you're no longer using the alpha version. :-) [01:48:41] Dantman: Didn't you at some point report something about relative urls causing broken links? [01:48:48] I'm hitting something like that now [01:48:48] http://docs.jquery.com/mw/index.php?title=Special%3APrefixIndex&prefix=&namespace=0&hideredirects=1 [01:48:56] That itch you have on your foot? It'll be better once we chop it off. [01:48:57] a page called "/Types" [01:49:02] is linked to by MediaWIki as href="//Types" [01:49:09] James_F: I guess I'll file bugs. [01:49:14] Though I feel like it's intrusive. [01:49:16] The link is broken, naturally, as it tries to access http://Types [01:49:25] OTOH, if you want to deploy in less than two months, I guess now's the time. [01:49:29] Susan: No no, filing bugs is great. I can always WONTFIX them. :-) [01:49:43] Susan: All bug reports are hugely appreciated. Especially if they're clear what they're getting at. [01:49:51] "Broken." [01:50:04] The URL still doesn't change when you click edit. [01:50:04] Susan: And yes, some of these little niggles should probably be in bugzilla rather than config changes to be done in my head. [01:50:05] Is that filed? [01:50:14] Susan: That's a WONTFIX; it's not meant to. [01:50:26] Heh. [01:50:34] Susan: Happy to discuss on Bugzilla why so that other people can find it and see our reasoning, though. [01:50:35] It disrupts the browsers' history feature. [01:50:40] Okay. [01:50:43] Susan: /That/ is a bug, though. [01:50:44] I'll file a few bugs, fiiiiiiine. [01:51:02] Susan: Specifically, 43844. [01:51:27] Thx. [01:51:32] I thought I remembered Roan filing that. [01:51:44] I think pushState still involves changing the URL, but maybe not. [01:52:10] Susan: We could change it to #!VisualEditor. [01:52:13] * James_F shrugs. [01:53:14] Susan: James_F: What we do (or should do?) is pushState to ?ve-action=edit [01:53:34] I thought we did that alreadu [01:53:36] already* [01:53:48] Krinkle: We don't do that currently. Part of the point of the integration is to make the page "feel" as much as possible. [01:53:57] Krinkle: That bug's assigned to you, BTW. Feel free to fix. :-) [01:54:16] Ah, we use it in the other direction [01:54:24] ve-action=edit is a permalink to trigger visualeditor from a url [01:54:34] we then rewrite it to hide it once loaded [01:54:40] replaceState [01:55:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=43844 [01:55:07] Krinkle: Yeah. [01:55:13] That's the bug. [01:59:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=48427 [02:00:12] I've posted my thoughts on bug 43844 [02:04:42] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=38048 [02:05:19] New patchset: Mattflaschen; "Add server-side logging to snippets." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63601 [02:06:54] Krinkle: What do you know about section editing + VisualEditor? [02:07:01] It seems to be unsupported. [02:07:26] New patchset: Mattflaschen; "Add back filtering for length, editability, and category." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [02:09:02] Susan: Indeed, more like "redundant" imho [02:09:12] it becomes an entirely new concept [02:09:15] New review: Mattflaschen; "On toro for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [02:09:21] Editing only a part of the document is imho not what we want [02:09:30] New patchset: Daniel Friesen; "(bug 41545) Allow kbd, samp, and var to be nested." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:09:38] But triggering edit mode and jumping to the same section should be feasable [02:10:01] Krinkle: I think every VE developer should be working on a OLPC computer. [02:10:18] Susan: define context? I'm not sure what you mean [02:10:29] I mean that editing entire articles is expensive. [02:10:45] Large articles are... large. [02:11:41] James_F: Would a request to enable VE on all namespaces on mediawiki.org be a VE bug or a Wikimedia bug? [02:12:00] Limiting it to user/main is frustrating as I keep hitting Manual pages. [02:12:12] Susan: Wikimedia, though we'd have to do it. I've been thinking about doing it already. Feel free to assign to me. [02:12:37] New review: Daniel Friesen; "Updated the links to the shorter versions and fixed the trailing space." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:13:51] Filed. [02:15:48] Susan: Thanks; mind if I tweak to "all Content namespaces"? Template:, MediaWiki: and *_talk: are all out of scope anyway. [02:16:24] New patchset: Daniel Friesen; "(bug 41545) Allow kbd, samp, and var to be nested." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:16:31] James_F: Go for it. [02:16:42] New review: Daniel Friesen; "Rebased." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:16:43] MediaWiki is out of scope? [02:16:45] :-( [02:17:22] Susan: The MW namespace is mostly fragments of HTML; we can't usefully parse it. [02:17:43] Susan: It does mean that CentralNotice et al. should reconsider where they put their content, of course. [02:17:56] Death to CentralNotice. [02:18:03] Well, that would be nice. :-) [02:18:20] In addition to every VE developer using an OLPC computer, they should also be forced to use Monobook. [02:18:36] Thanks, but no. [02:18:42] Monobook is ghastly. [02:19:00] It's adored. [02:19:09] So are pagan gods. [02:20:53] O.O [02:22:11] Does that green striped area have a name? [02:22:31] Susan: It's a Phantom. [02:22:48] Susan: We also have Shields (which are different), as well as Pawns / Slugs. [02:22:52] I called it a MediaWiki cockblock. [02:22:55] Susan: Fun times in VE-land. :-) [02:22:57] But that's rather crass. [02:22:57] ;) I can't decide if MonoBook is #2 or #3 on the list for annihilation! [02:23:09] Susan: We're working to have as few as possible of them. [02:23:26] Susan: Thanks to me, they no longer appear for
elements (as of this morning). You're welcome. :-) [02:23:36] You're my hero. [02:23:46] * James_F bows. [02:24:03] Susan: I take all the credit, but it's others' whose work I built on. [02:24:04] I'm not calling that thing a phantom in a bug report. I'd sound ridiculous. [02:24:16] "The phantoms are out to get me." [02:24:40] Susan: But they are, Blanche, they are! [02:25:25] So is everyone else. [02:27:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:28:00] New review: Daniel Friesen; "Yay finally! Now next version game wikis can properly mark up controls." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [02:51:33] Susan: https://gerrit.wikimedia.org/r/#/c/63621/ per your request. :-) [02:53:02] Those variables are pretty horribly similar. [02:53:28] "I want the VisualEditor namespaces, not the VisualEditor namespace!" [02:53:36] Susan: Yeah, there's a bug to clean this stuff up anyway. [02:53:56] It seems the little link tool doesn't know if an article exists or not. [02:54:07] It suggested that [[wiki]] would be a red link. [02:54:11] And I was like "nahhhhh, brah." [02:54:21] Susan: Hmm. That sounds like a regression. Mind throwing up a bug? [02:54:43] Susan: 'Cos it's 20:00 and, lovely as sitting at work talking to you is, I want to go home, eat, and crash out. :-) [02:55:05] I am lovely, yes. [02:55:07] I'll file a bug. [02:55:15] * James_F bows to the lovely Susan. [02:55:18] Good night. [02:55:41] :-) [02:55:42] Night. [02:58:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=48433 [03:01:02] New patchset: Mwalker; "Make Thank You Localized!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63622 [03:03:10] New patchset: Mwalker; "Make the Templates Use the new L10n Thing" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63623 [03:03:56] New review: Mwalker; "There's nothing to review here that Chris Steipp wont get to later in his seucrity review." [wikimedia/fundraising/twig] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63587 [04:09:20] New patchset: thibaultmarin; "(extension/TimelineTable) Refactoring and cleanup" [mediawiki/extensions/TimelineTable] (master) - https://gerrit.wikimedia.org/r/38485 [05:14:39] New review: Nikerabbit; "Umm, why later and not now when it is two releases later than scheduled?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63338 [05:20:08] New review: MZMcBride; "Nike: It seems like it would be easy enough to treat this like CheckUser and require a special user ..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/63342 [06:19:55] New patchset: IAlex; "Fix fatal error when $wgValidateAllHtml is enabled and apache_request_headers() does not exists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [06:27:52] New patchset: IAlex; "Unsetting the email address for a user when the email address is invalidated." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [06:28:12] New patchset: IAlex; "Unsetting the email address for a user when the email address is invalidated." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [06:30:45] New review: IAlex; "The tests are not broken, the problem was that User::setEmail() was calling invalidateEmail() *after..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [06:32:46] New review: Mattflaschen; "I spent a while looking at it in more depth. It's mostly very solid. There are a few significant c..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [06:39:34] New patchset: IAlex; "Fix typo in RELEASE-NOTES" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63634 [07:06:48] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [07:12:53] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [07:14:17] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [07:15:26] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [07:18:20] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63583 [07:48:59] * mooeypoo shoots her router [07:55:23] New patchset: Pginer; "Put the cog icon in the middle of the section title" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63419 [07:57:39] New review: Pgehres; "Aha. Thanks for catching that. It never occurred to me to look for that -- I must have tunnel visi..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61907 [08:02:44] New review: Pgehres; "I can't speak to the code, but the scenarios are correct. One thing to double check is the setting ..." [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/63345 [08:11:55] New review: Foxtrott; "Yes. Don't know why it would lack a translation, though. These messages are not new. Anyway, I think..." [mediawiki/extensions/SemanticForms] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61815 [08:11:58] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [08:32:43] New review: Mattflaschen; "I'm also getting a huge number of errors similar to "Error in parsing MathML attribute value '-8.333..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [08:38:33] New patchset: Zfilipin; "Better implementation of Single-user login v2 tests" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63345 [08:38:46] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63427 [09:36:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63151 [09:37:13] Change merged: Tobias Gritschacher; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63161 [09:38:57] Change merged: Tobias Gritschacher; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63162 [10:26:34] New patchset: Raimond Spekking; "I18n review in preparation for adding extension to translatewiki.net" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/63642 [10:27:58] New review: Physikerwelt; "Thanks for you comments. I'll see if I can reproduce the errors." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [10:29:02] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [10:47:39] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [11:00:54] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [11:48:06] New patchset: Siebrand; "Make proofread terminology more consistent" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63465 [11:57:32] New patchset: Siebrand; "Make review terminology more consistent" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63465 [12:03:01] New review: Siebrand; "I took another look at the strings in the initial patch set, and decided I wasn't happy with "proofr..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63465 [12:50:11] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63290 [12:55:08] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63290 [13:00:15] New review: Zfilipin; "As soon as the commit is merged into master, it will run in all browsers that we support at the mome..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63345 [13:11:52] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63290 [13:13:35] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/32036 [13:14:56] New review: Siebrand; "Yep, only the comment changed. It's part of the large collection, and I guess they don't make change..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63453 [13:23:16] New patchset: Matthias Mullie; "(bug 37477) Feedback details text on "View feedback page" cut off for very long string without whitespace" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61568 [13:24:07] New patchset: Matthias Mullie; "(bug 37477) Feedback details text on "View feedback page" cut off for very long string without whitespace" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61568 [13:31:42] New patchset: Matthias Mullie; "(bug 44827) Show amount of remaining characters for moderation-note" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59387 [13:33:18] New patchset: Matthias Mullie; "(bug 44827) Show amount of remaining characters for moderation-note" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59387 [13:41:03] New review: Matthias Mullie; "Empty comments are hidden already (they're only visible in the "all feedback" filter, nowhere else)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/37229 [13:42:43] New patchset: Jeroen De Dauw; "Enable voting for Wikibase Client tests as the job is now passing" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63657 [13:43:23] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [13:44:10] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:45:06] New review: Hashar; "since https://gerrit.wikimedia.org/r/63476 :D" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/63657 [13:45:37] Change abandoned: Matthias Mullie; "Patch no longer relevant; previous code cleanup/refactor already fixed this." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/42759 [13:46:09] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63657 [13:48:45] New patchset: Amire80; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [13:49:42] New patchset: Matthias Mullie; "i18n issues reported on https://translatewiki.net/wiki/User:Mlitn" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/56877 [13:57:11] New patchset: Matthias Mullie; "Bug 43167 - list=articlefeedbackv5-view* should accept page titles as an option" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [14:00:23] New patchset: Netbrain; "Added data validation gui and logic" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/63659 [14:02:34] New patchset: Netbrain; "Added data validation gui and logic" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/63659 [14:02:41] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [14:02:53] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/63659 [14:09:47] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63634 [14:10:33] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [14:20:58] mlitn: thanks [14:23:11] New patchset: Matthias Mullie; "Substitute $.ajax for mw.Api" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [14:23:48] Change abandoned: Matthias Mullie; "https://gerrit.wikimedia.org/r/#/c/63480/ will better fix this." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/53979 [14:23:52] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [14:25:25] New review: Wikinaut; "not yet tested with protocol-relative !" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [14:35:43] New review: Matthias Mullie; "DB change done." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 2; - https://gerrit.wikimedia.org/r/33383 [14:35:50] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/33383 [14:52:35] New review: Matthias Mullie; "WIP" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -2; - https://gerrit.wikimedia.org/r/61797 [14:52:53] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [14:52:53] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [15:02:18] ^demon, gitblit looks awesome so far :D [15:03:07] <^demon> :) [15:04:11] https://mk.wikipedia.org/wiki/%D0%9C%D0%B5%D0%B4%D0%B8%D1%98%D0%B0%D0%92%D0%B8%D0%BA%D0%B8:JQuery-makeCollapsible.js [15:04:21] ^demon, the search tab says nothing's configured :( https://git.wikimedia.org/lucene/ [15:04:26] ^ That's a dupe (old version) of jquery.makeCollapsible in core [15:04:43] What's the simple way to replace it with something so MW will load the RL module? [15:04:51] ugh they localized the MediaWiki namespace? *pain* [15:05:25] It's seemingly breaking EducationProgram.. I'd like to just delete it ;) [15:05:41] Reedy, mw.load('jquery.makeCollapsible') or some such? [15:05:51] That's what I was presuming [15:05:57] I wasn't sure what the correct code was [15:06:04] yeah i'd have to check to be sure [15:06:07] but something like that ;) [15:06:31] mw.loader.using( ['jquery.ui.dialog', 'jquery.ui.datepicker'], MyTool.init ); [15:06:40] https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users) [15:06:40] guillom: ping [15:06:58] sumanah: I already told andre and rob: andre__: see note in etherpad [15:07:10] <^demon> brion: Whoops, thought that was on by default. Will look at it. [15:07:13] no prob [15:07:20] ^demon, :D [15:07:42] mw.loader.load('jquery.makeCollapsible'); [15:07:47] ^demon: congrat on lucene :-] [15:08:01] <^demon> Heh, lucene for gitblit. [15:08:04] <^demon> Not for gerrit [15:08:05] ah no lucene is not setup for giblet :-D [15:08:11] damn [15:11:34] ^demon: I have made a patch on Zuul that would make it do a bit less queries on Gerrit [15:11:47] though I guess you will barely see any change [15:12:32] New review: Anomie; "Worth a release notes entry?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/41592 [15:14:42] <^demon> hashar: Sweet, less queries make me happy :) [15:15:03] <^demon> Is there any movement on using the rest API for more and not doing so much SSH? [15:15:10] not at all [15:15:18] OpenStack still uses gerrit 2.4 [15:15:24] <^demon> Yeah I figured. [15:15:30] if you have any doc about the rest api, maybe we can work it a bit :) [15:16:02] <^demon> https://gerrit.wikimedia.org/r/Documentation/rest-api.html :) [15:16:34] :-D [15:27:04] oh noes (I have never seen that = "МедијаВики") [15:47:45] New patchset: Matthias Mullie; "Bug 32941 - The vertical feedback button doesn't appear on the right of the article page" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63671 [16:04:46] New review: CSteipp; "The text stories look good to me. I don't know enough of the code to say if the implementation is co..." [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/63345 [16:08:43] New patchset: Hashar; "*** WIP *** project templating" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [16:09:15] New review: Hashar; "https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/77/console : SUCCESS in 2s (non..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [16:19:51] Ooooh [16:19:52] https://www.facebook.com/notes/bzdeck/introducing-bzdeck/269349649857418 [16:19:58] "BzDeck is an effort to improve the usability of Bugzilla, a popular bug tracking system from Mozilla. BzDeck also demonstrates the modern Web standard technologies such as HTML5, CSS3, WAI-ARIA and ECMAScript Harmony." [16:20:02] andre__: ^^ [16:20:18] Reedy, uh yay, thanks [16:20:41] Needs FF18 [16:20:49] I'm on Chrome 26 [16:21:10] ...and needs BzAPI [16:21:23] which is Mozilla Bugzilla only so far, until there is a stable REST API [16:27:40] New patchset: Reedy; "Create maintenance script to populate archive.ar_len" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [16:29:13] New patchset: Reedy; "Add archive, externallinks PK" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51675 [16:33:38] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/63564 [16:34:40] It'd be nice to get https://gerrit.wikimedia.org/r/#/c/51675/ merged [16:34:45] Then start poking asher to add them :D [16:35:02] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/60975 [16:37:28] New review: Mwalker; "The symlink isn't going to change anything..." [wikimedia/fundraising/twig] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63586 [16:37:29] Change merged: Mwalker; [wikimedia/fundraising/twig] (master) - https://gerrit.wikimedia.org/r/63586 [16:40:19] New patchset: Siebrand; "Update formatting." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63386 [16:41:53] Change abandoned: EBernhardson; "needs a more complex implementation that takes user settings into account" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61902 [16:59:16] New patchset: Mwalker; "Adding more detail to the CLDR template" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/63681 [17:08:44] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [17:10:48] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62922 [17:12:05] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61350 [17:12:27] New patchset: EBernhardson; "Notification agent whitelist and blacklist" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62624 [17:13:41] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62851 [17:21:03] Change merged: Adamw; [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/63681 [17:21:07] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [17:22:07] New review: Adamw; "No blockers. This is great, we can address issues in another patchset." [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63252 [17:22:08] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63252 [17:22:21] New patchset: Adamw; "Make Thank You Localized!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63622 [17:24:35] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [17:24:46] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63622 [17:24:56] New patchset: Adamw; "Make the Templates Use the new L10n Thing" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63623 [17:25:46] New review: Adamw; "(1 comment)" [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63623 [17:25:47] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63623 [17:34:02] Published patchset: Wikinaut; "(bug 44849) improved icons for provider selection page patch part 2" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/63687 [17:34:24] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/63687 [17:34:57] New patchset: Krinkle; "deleteEqualMessages: Refactor to support all langcode subpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [17:38:29] New patchset: MarkTraceur; "Sandbox cURL, generally make it possible to test" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [17:38:54] New patchset: Matthias Mullie; "Substitute $.ajax for mw.Api" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [17:40:08] New patchset: Kaldari; "Adding new talk page message alert for logged in users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [17:42:11] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63636 [17:46:48] Change abandoned: Wikinaut; "I abandon this. " [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/58858 [17:47:51] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [17:48:15] I keep typing "git submodulate" :P [17:49:30] alias :D [17:50:41] heh [18:01:51] New review: Adamw; "This is a cool approach, and I think it will work." [mediawiki/extensions/DonationInterface] (master) C: -1; - https://gerrit.wikimedia.org/r/63688 [18:07:01] New review: Balloonguy; "I have addressed the comments and fixed an error:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [18:07:20] New patchset: Aaron Schulz; "Fixed LocalFile::isCacheable() to account for object type metadata." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63696 [18:08:24] reedy: more power to you (re: commonsettings cleanup) [18:11:12] has anyone been talking to google about those canonical problems / [18:11:29] What's wrong with Ubuntu now? [18:11:38] rel=canonical [18:11:52] heh [18:13:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63696 [18:14:27] apergos: Need to decide what to do with wmgPrivateWikiUploads next :/ [18:14:33] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63697 [18:14:42] errr [18:14:53] private + donatewiki + foundationwiki [18:15:25] New patchset: MaxSem; "Update Gadgets to catch https://gerrit.wikimedia.org/r/#/c/60954/" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63699 [18:16:11] sure seems like it oughta be in initialisesettings dunnit [18:16:41] Yeah, there is a $wmgPrivateWikiUploads made for it. Then the tonne of extensions allowed added in commonsettings [18:17:07] New patchset: Aaron Schulz; "Fixed LocalFile::isCacheable() to account for object type metadata." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63700 [18:19:33] $foobar = array( 'default' => array(), 'private' => array( 'foo', 'bar' ), 'donatewiki' => $foobar['private'] ) [18:19:54] I do wonder if donate actually needs them [18:20:52] $wgConf->settings['wmgFileExtensions']['private'] [18:20:54] * Reedy tries [18:21:00] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63697 [18:22:02] thedj: supposedly Erik [18:22:55] Nope, won't work [18:23:20] Oh, I've a better idea [18:27:26] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63700 [18:29:47] * apergos waits [18:31:03] apergos: https://gerrit.wikimedia.org/r/#/c/63702/ [18:31:16] already looking [18:31:53] eww but understandable [18:32:21] Mmm, I'm not quite sure on it. If I'm going to end up pasting it 3 times, it might aswell just stay where it is [18:33:27] :-D [18:34:04] I've at least removed the loose ones so far, and the smaller conditional [18:34:52] I'm sure CommonSettings.php keeps getting a load longer [18:35:04] pretty much [18:35:12] cause you know that's where people stuff random junk [18:37:11] # More modern PHP versions will send a 500 result code on fatal erorr, [18:37:12] # at least sometimes, but what we're running will send a 200. [18:37:12] if( PHP_SAPI != 'cli' ) { [18:37:12] header( "Cache-control: no-cache" ); [18:37:12] } [18:37:23] I hate these vague time/versionless comments [18:37:27] which version!? [18:38:31] git blame and find the timestamp, then compare to uh... timestamps on our php packages? :-P [18:38:36] thedj: or maybe no longer https://bugzilla.wikimedia.org/show_bug.cgi?id=26115#c9 [18:38:46] you could poke him by email [18:38:46] which aren't there now, iirc only the most recent version will be in the repo [18:40:39] New review: Mattflaschen; "Thanks. I have a couple replies here. I also wanted to note that I'm testing with Iceweasel/Firefo..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [18:41:17] New review: Mattflaschen; "A couple follow-ups. Also, please add LaTeXML to the README, as I mentioned." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [18:45:55] New patchset: Aaron Schulz; "Fixed bug in LocalFile::isCacheable()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63706 [18:45:56] Reedy: ^ [18:46:12] New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63707 [18:47:54] New patchset: Aaron Schulz; "Fixed bug in LocalFile::isCacheable()." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63708 [18:57:43] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63707 [19:04:35] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [19:09:17] brion: https://gerrit.wikimedia.org/r/#/c/63706/ [19:12:43] i got no clue what's going on in there Aaron|home :) [19:13:27] brion: that function decides whether the File object is processed cached in RepoGroup [19:13:35] too many big things and you end up with http://commons.wikimedia.org/wiki/Category:1877_books [19:13:42] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [19:14:35] Aaron|home: is that a cat full of DjVu? [19:15:06] yeah, you can try using from= to limit it down [19:15:37] I was inspecting that using eval.php and dumping the entries in cache [19:18:30] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [19:20:52] New patchset: Foxtrott; "fix bug 47806 ("minor edit" and "watch this page" checkboxes no longer work in forms)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/63114 [19:22:49] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/63114 [19:25:38] New patchset: Aaron Schulz; "Fixed LocalFile::isCacheable() to account for object type metadata." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63718 [19:28:08] New review: Wikinaut; "Hi Tyler *PING*" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [19:28:44] brion: running away? :D [19:30:20] Aaron|home: for now :D [19:30:31] I WILL RETURN [19:34:45] Reedy: hmm, I think I'll deploy https://gerrit.wikimedia.org/r/#/c/63708/1 [19:38:19] New patchset: Ori.livneh; "Update README to reflect minimum Vagrant version requirement" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63719 [19:45:52] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45294 [19:46:37] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [19:48:31] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [19:50:02] Reedy: why is WM on 2c42c99e41d73b844465d129893e1d1648e4a261-dirty ? [19:50:10] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63708 [19:52:22] Aaron|home: Where? [19:52:43] tin [19:54:17] New patchset: Aaron Schulz; "Fixed bug in LocalFile::isCacheable()." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63721 [19:55:12] New patchset: TheDJ; "OutputPage: Use If-None-Match header to determine 304 Not Modified" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [19:58:32] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63722 [19:58:57] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63722 [19:59:05] New review: Ryan Lane; "(1 comment)" [mediawiki/extensions/OpenID] (master) C: -1; - https://gerrit.wikimedia.org/r/45474 [19:59:19] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63699 [20:00:40] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63720 [20:00:43] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63718 [20:01:29] hm, guys, I just noticed the discussion on the list about Html class.. just a quick question that i'm confused with -- what's the difference between the Html class and the Xml class? both seem to build html elements...? html seems to be bigger but.. they both have buildTable and rows and buttons, etc. [20:01:31] which should I use? [20:02:34] They're both about the same number of lines ;) [20:02:51] are they? I got really confused yesterday trying out a couple of things with Xml class [20:03:17] especially since I'm creating a page that extends Special:Version and the original uses "raw" " ..." strings. [20:03:26] 973 vs 970 [20:03:29] New patchset: IAlex; "Update messages.inc and rebuild MessagesEn.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63723 [20:03:33] oh, okay. So there's no difference? [20:03:45] Which should I use in my extension? [20:04:30] There's quite a bit of difference [20:04:54] Read the class comment on the Html class [20:05:21] oh, i missed the fact there's a "read more" there. [20:05:43] heh [20:05:48] ohhhh that solves my other question too [20:05:57] RTFM! :D [20:06:29] :D [20:06:49] Wasn't this Bug #1? ;) [20:07:47] Nah [20:07:47] New patchset: Ori.livneh; "Add 'language-pack-UTF-8' to base packages" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63724 [20:07:58] That's you can't RTFM because it's [20:08:15] yeah, the docs are confusing. [20:08:51] Btw, Reedy, the original Special:Version page uses raw tags as strings.. "" verbally.. but I assume that even though I extend that page, it'd be better if I use the Html class? [20:09:00] judging from the discussion in the list, I probably should [20:09:03] New patchset: J; "Trim SVG output" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [20:09:05] It's preferred, yeah [20:09:14] * mooey|finals shall do that [20:09:25] Legacy code won't have been converted in most cases [20:09:53] I ran into a couple of problems trying to put inner tags in my cell strings in Xml, but I didn't try the Html class yet. [20:10:13] New patchset: J; "Trim SVG output" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [20:10:44] yeah, but I'm not editing all the inherited functions in that page, so some would be legacy and some would be with the Html tag. I don't think it'll be a problem ,but I hope it won't cause anything screwey to happen [20:11:02] they're all outputting strings, so it should be okay. I think. [20:11:02] Should work fine [20:11:11] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #47: FAILURE in 9 min 55 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/47/ [20:11:19] Reedy: did you see my mockup btw? [20:11:36] Change merged: jenkins-bot; [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/62540 [20:11:44] I didn't [20:11:54] http://www.mediawiki.org/wiki/Extension:ExtensionStatus <-- see "Proposed Mockup" [20:12:01] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63721 [20:12:18] That would be *after* I go over your corrections :D thanks for those btw [20:12:45] New patchset: J; "Experimental $wgScoreUseSVG mode" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [20:12:45] New patchset: J; "Trim SVG output" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [20:12:48] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63719 [20:13:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63723 [20:14:17] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57841 [20:16:05] New review: J; "so independent of getting the length from timidity or parsing the ogg file once, whats the best plac..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [20:16:43] New patchset: Ori.livneh; "Fix VirtualBox version detection for Ubuntu builds" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63726 [20:21:56] New patchset: Jforrester; "Fix VirtualBox version detection for Ubuntu builds" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63726 [20:30:20] New review: TheDJ; "Did the last change myself, so can't +2, but verified:" [mediawiki/extensions/UploadWizard] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/56371 [20:31:15] New review: Brion VIBBER; "Unfortunately for me this seems to overly aggressively trim, and crops off parts of the score:" [mediawiki/extensions/Score] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/63725 [20:31:29] New patchset: Pgehres; "Adding i18n msg for merge request email" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63731 [20:33:46] New review: TheDJ; "I don't think we should work on basis of "obsolete and hopefully will be killed and rewritten soon"...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [20:34:42] New patchset: Ori.livneh; "Add 'language-pack-UTF-8' to base packages" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63724 [20:35:24] New patchset: Ori.livneh; "Fix locale issue when forwarded from host environment" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63724 [20:35:32] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63724 [20:35:40] New patchset: Ori.livneh; "Fix VirtualBox version detection for Ubuntu builds" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63726 [20:35:52] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63726 [20:42:26] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62922 [20:45:19] New review: Matmarex; "Sadly I don't have time to grep and check each occurrence, and leaving those classes won't break any..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [20:48:19] New patchset: Bsitu; "(bug 44247) Do not write to storage if read-only mode is on" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62922 [20:50:59] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63733 [20:51:26] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63733 [20:53:50] New review: Jdlrobson; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [20:53:57] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/63601 [20:56:10] New review: J; "> Unfortunately for me this seems to overly aggressively trim, and crops off parts of the score: htt..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [20:56:36] New patchset: J; "Trim SVG output" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [21:00:20] New review: Jforrester; "Needs qqq; otherwise, good to go." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63731 [21:02:50] New review: Brion VIBBER; "It seems to be the trimming, not the rendering, that's going wrong..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [21:03:41] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50760 [21:04:10] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63736 [21:04:30] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63736 [21:05:19] New patchset: Ryan Lane; "Switch to using AbortLogin hook for tokens" [mediawiki/extensions/OATHAuth] (master) - https://gerrit.wikimedia.org/r/54888 [21:06:24] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [21:08:24] Change merged: Ryan Lane; [mediawiki/extensions/OATHAuth] (master) - https://gerrit.wikimedia.org/r/54888 [21:10:15] New patchset: Krinkle; "OutputPage: Guard jQuery.ready() against absence of jQuery" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63740 [21:12:01] New review: Ori.livneh; "Looks OK except for the trailing whitespace issue." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [21:12:19] New patchset: Krinkle; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [21:14:25] Krinkle: hi there, are you around ? :D [21:14:45] New patchset: Ryan Lane; "Up version of OATHAuth to bring in security fixes" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63741 [21:15:06] #wikidata [21:15:24] hashar: I am [21:16:35] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62922 [21:17:15] Krinkle: 'window.jQuery && jQuery.ready();' any reason you do window.jQuery and not jQuery && jQuery.ready() [21:17:22] New review: Kaldari; "I don't think the non-JS version should be styled by default. Or if it is, we should move all the st..." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/63256 [21:17:25] jdlrobson: You should know [21:17:42] jdlrobson: Why does jQuery.ready() fail in the first place? [21:18:00] Krinkle: I have applied yet another hack on Zuul this afternoon. Have you made aware of any trouble tonight? [21:18:24] jdlrobson: Undefined variables throw reference errors, they don't evaluate to false, they throw [21:18:44] jdlrobson: Properties, however, yield undefined. [21:19:20] Krinkle: sorry yeh that's obvious (shouldn't multi task :)) [21:19:49] it just looked odd but then i'm not used to writing inline scripts :) [21:20:03] Krinkle: happy for me to +2 ? [21:20:37] jdlrobson: I admit though, javascript doesn't make this obvious. In php it emits a notice instead of exception and does so for both properties and variables alike. [21:20:37] Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63741 [21:20:51] New patchset: Pgehres; "Adding i18n msg for merge request email" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63731 [21:20:54] >> foo [21:20:54] Krinkle: ReferenceError: foo is not defined [21:21:02] >> var a = {}; a.foo [21:21:02] Krinkle: undefined [21:21:17] >> !!foo [21:21:17] Krinkle: ReferenceError: foo is not defined [21:21:18] >> alert( "foo" ); [21:21:18] hashar: undefined; Console: 'foo' [21:21:29] >> var a = {}; !!a.foo [21:21:30] Krinkle: (boolean) false [21:21:31] that bot is not ecma compliant [21:21:48] hashar: It is, very much. Runs on v8 vms [21:21:52] ;-D [21:21:55] newly spawned for each command. [21:22:05] >> isNaN(' ') [21:22:05] jdlrobson: (boolean) false [21:22:10] XD [21:22:12] hashar: However alert is forwarded to console.log, yes. [21:22:13] I wonder if we could past the code of an IRC bot :D [21:22:37] New review: Jdlrobson; "Tested." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63740 [21:22:39] Change merged: Jdlrobson; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63740 [21:22:57] https://github.com/Krinkle/oftn-bot/tree/ecmabot-wm [21:23:09] jdlrobson: Thanks [21:23:45] hashar: jdlrobson: fyi, I've used this bot in ##javascript and #mediawiki-visualeditor for a while, I just added #wikimedia-dev to it [21:23:56] and it runs js, not a browser, so no window, document etc. [21:23:59] (nodejs) [21:24:04] * jdlrobson nods [21:24:10] * Krinkle nodes [21:24:27] >> throw "irc exception" [21:24:28] jdlrobson: Uncaught value: 'irc exception' [21:25:00] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63754 [21:25:03] >> Object.prototype.a = 1; var b = {}; b.a [21:25:03] Krinkle: (number) 1 [21:25:07] >> ({}).a [21:25:08] Krinkle: undefined [21:25:20] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63754 [21:27:25] New patchset: Pgehres; "Adding i18n msg for merge request email" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63731 [21:31:26] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63731 [21:33:02] New patchset: Ryan Lane; "Fix escaping issue on Special:Ask" [mediawiki/extensions/SemanticMediaWiki] (1.9.x) - https://gerrit.wikimedia.org/r/63770 [21:33:28] New patchset: Ryan Lane; "Fix escaping issue on Special:Ask" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/63774 [21:34:49] Change merged: Mwalker; [wikimedia/fundraising/twig] (master) - https://gerrit.wikimedia.org/r/63587 [21:35:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63287 [21:36:31] New patchset: Ryan Lane; "Pull in cherry-pick in SMW to fix security issue" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63777 [21:42:30] New patchset: Mwalker; "Updating twig to 1.13.0" [wikimedia/fundraising/twig] (master) - https://gerrit.wikimedia.org/r/63778 [21:42:54] New review: Mwalker; "Upgrading and deploying" [wikimedia/fundraising/twig] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63778 [21:42:54] Change merged: Mwalker; [wikimedia/fundraising/twig] (master) - https://gerrit.wikimedia.org/r/63778 [21:42:59] and I am offf to bed [21:43:50] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63780 [21:44:05] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63780 [21:44:17] ^demon: 503s from git.wikimedia.org [21:44:41] Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63777 [21:44:55] scapping [21:49:54] <^demon> ori-l: Known. This is why it's only dark launched because I'm still futzing with things :) [21:50:00] <^demon> Thanks tho. [21:55:27] New review: Krinkle; "Follows-up I1343872de7aa and Ia533aedf63b11d." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [21:55:50] Thanks for the merge siebrand. [21:56:41] ori-l: What's on git.wikimedia.org? [21:57:12] * Krinkle never heard of it before [21:57:37] Hm.. some kind of gitweb alternative? [21:57:39] Krinkle, gitblit [21:57:53] When was this set up? No documentation/announcement? [21:58:03] nice [21:58:18] Krinkle: [22:49:54] <^demon> ori-l: Known. This is why it's only dark launched because I'm still futzing with things :) [21:58:18] anybody with parser *and* messages experience? https://bugzilla.wikimedia.org/show_bug.cgi?id=32686 awaits... [21:58:39] ("Page does not exist" title cached in wrong language) [21:58:45] Fair enough. Nice work. Excited to see it launch for real. [21:58:50] Krinkle: Also, you should've had a mail about it ;) [21:59:15] Krinkle, see "[Engineering] git.wikimedia.org - dark launched" email. ^demon has responded to a few bug reports about gitweb with plans to move to gitblit [21:59:22] Though I wonder, if its separate from gerrit, what the advantage is over the mirror on github (aside from it being third-party), I mean if its only for viewing [21:59:58] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (1.9.x) - https://gerrit.wikimedia.org/r/63770 [22:00:00] spagewmf: I read Engineering but I'm behind a bit, picked up higher priority ones, will catch up later. [22:00:03] thx for the heads up [22:00:04] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/63774 [22:01:15] <^demon> Krinkle: Well, it offloads the viewing from gerrit, as well as acts as a read-only mirror. [22:01:25] <^demon> :) [22:01:53] ^demon: So it is a mirror then, not looking into gerrit's stuff like gitweb does. [22:02:05] That's nice [22:02:09] <^demon> Yep. [22:02:21] !log upgrading fundraising civi (d895730067e3325fd630d09196ee81eeba24b5ee --> head) [22:02:36] <^demon> mwalker: Wrong channel. [22:02:36] oopa [22:02:44] ^demon: Does it support anonymous git interaction? [22:02:59] ^demon: I imagine you want to advertise this for people using git anonymously (instead of https://gerrit) [22:03:03] <^demon> Yep. [22:03:09] Alrighty [22:03:10] <^demon> You can clone/fetch over https with it. [22:07:08] <^demon> ori-l: Back up. [22:12:56] New patchset: Ori.livneh; "(WIP) Make forwarded_port a Facter fact." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63783 [22:14:41] ^demon: cool, thanks [22:25:15] New patchset: Ryan Lane; "Update echo preference message labels" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63785 [22:25:43] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63785 [22:27:46] New review: Ori.livneh; "If Vagrant detects a port conflict, it may override your preferences and forward a different (free) ..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63783 [22:28:15] New patchset: Ryan Lane; "Update OpenStackManager to fix echo messages" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63786 [22:33:09] New patchset: Ori.livneh; "Add back filtering for length, editability, and category." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [22:33:29] New review: Ori.livneh; "PS2 just fixes the whitespace issue." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [22:33:49] New patchset: Mwjames; "Jenkins phpunit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [22:34:06] Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63786 [22:35:06] New patchset: EBernhardson; "Notification agent whitelist and blacklist" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62624 [22:35:17] New review: Krinkle; "Pending revision based on meeting we just had." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63584 [22:36:02] New review: Mwjames; "2:35:05 ...................................PHP Fatal error: AutoLoader::autoload(): Failed opening ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [22:36:17] New review: Krinkle; "22:35:05 ...................................PHP Fatal error: AutoLoader::autoload(): Failed opening..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [22:36:28] mwalker: So close :) [22:36:43] mwalker: btw, nice work lately on SMW extensions. Getting in shape very quickly. Awesome. [22:36:59] Krinkle: I think you have the wrong matt [22:37:04] I haven't touched SMW [22:37:18] ... unless I've been sleep coding! [22:37:19] the wrong matt w. even [22:37:22] mwalker: I think you might have the wrong Krinkle -- the one I know doesn't dish out compliments in public channels [22:37:37] ori-l: Hey, I heard that ;-) [22:37:43] :P [22:37:43] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [22:38:13] sorry for the ping in that case, mwjames not on irc? [22:41:15] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [22:44:12] New patchset: Ryan Lane; "Use label-raw for puppet groups in configure form" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63790 [22:45:00] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63790 [22:46:45] New patchset: Ryan Lane; "Update OpenStackManager for HTMLForm label change" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63791 [22:46:55] New patchset: Mwalker; "Adding some Watchdog Lines to ThankYou" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63792 [22:48:57] New review: Adamw; "Clean." [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63792 [22:48:58] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63792 [22:49:45] New review: Ori.livneh; "Going to refactor this a tiny bit so merging." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/63620 [22:49:51] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63620 [22:52:40] Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63791 [22:52:47] New patchset: Mwalker; "Moar Better Logging" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63794 [22:55:54] New review: Krinkle; "-1 for style issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60440 [23:00:15] New patchset: Mwalker; "Failmail now has a log line!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63795 [23:02:50] New patchset: Adamw; "Moar Better Logging" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63794 [23:03:35] * mooey|finals shoots peas at the documentation [23:03:56] New review: Adamw; "+2" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63794 [23:04:29] New patchset: Adamw; "Failmail now has a log line!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63795 [23:04:50] New review: Adamw; "WATCHDOG_ERROR" [wikimedia/fundraising/crm] (master) C: -1; - https://gerrit.wikimedia.org/r/63795 [23:05:24] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63794 [23:07:34] New patchset: Mwalker; "Failmail now has a log line!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63795 [23:08:20] Project browsertests-en.wikipedia.org-linux-firefox build #61: FAILURE in 2 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/61/ [23:08:37] New patchset: Mwalker; "Failmail now has a log line!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63795 [23:09:51] New review: Jeroen De Dauw; "https://gerrit.wikimedia.org/r/#/c/63796/" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [23:10:17] Project browsertests-sandbox.translatewiki.net-linux-chrome build #42: FAILURE in 2 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/42/ [23:10:20] Project browsertests-sandbox.translatewiki.net-linux-firefox build #67: FAILURE in 2 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/67/ [23:10:22] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [23:11:31] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [23:14:02] New review: Jeroen De Dauw; "Hmm, odd... I can't find the class any more in Validator, where it now ought to be. So the linked co..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [23:14:57] New review: Adamw; "whitespace but no blockers" [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63795 [23:14:57] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/63795 [23:16:32] New patchset: Ori.livneh; "Slight refactor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63798 [23:17:41] New patchset: Pgehres; "Adding the ability to confirm email address while sending users to Special:MergeAccount" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63799 [23:18:12] New patchset: Ori.livneh; "Slight refactor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63798 [23:18:32] New patchset: MaxSem; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63800 [23:19:19] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63800 [23:19:25] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [23:26:25] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [23:26:25] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [23:32:27] New patchset: Pgehres; "Adding aa_method field to track login method." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [23:39:01] New patchset: Pgehres; "Adding aa_method field to track login method." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [23:44:49] New review: Mattflaschen; "There are a couple areas where I disagree with the re-factoring." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/63798 [23:49:57] New patchset: Pgehres; "Adding aa_method field to track login method." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [23:52:37] Aaron|home: Any chance for a maybe-final review on https://gerrit.wikimedia.org/r/#/c/39171/ ? (Global user renaming; will need rebase from Chris though.) [23:53:59] this week? sure [23:58:33] Aaron|home: Thanks. :-)