[02:08:18] New patchset: Mwjames; "Add smw.dataItem.wikiPage.getText()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62536 [02:11:07] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62536 [02:12:47] New patchset: Mwjames; "srf.formats.datatables() use getNamespaceId()" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63405 [02:13:33] New review: Mwjames; "Thanks QUnit ..." [mediawiki/extensions/SemanticResultFormats] (master) C: 2; - https://gerrit.wikimedia.org/r/63405 [02:13:42] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63405 [02:41:32] New patchset: Daniel Friesen; "Whitelist a bunch of url protocols." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63406 [02:45:17] New patchset: Daniel Friesen; "Improve language handling of page titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [02:45:55] New review: Daniel Friesen; "Adding updates to hooks.txt." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [03:07:52] New review: Peachey88; "looks sane" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63406 [03:14:36] New patchset: Arrbee; "Adding more test scenarios for ULS user settings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [03:21:59] New patchset: Daniel Friesen; "Shorten our in-comment urls to the whatwg HTML spec." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63407 [03:24:24] New patchset: Daniel Friesen; "Whitelist the element." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63408 [04:34:21] mooeypoo: I just read your email. That's quite an ambitious first project [04:34:50] * bawolff hasnt read yoir code yet but is impressed [04:36:05] New review: Parent5446; "Looks good. Will give it a little while in case there are objections, and then merge." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63406 [04:38:03] hey bawolff :) [04:38:20] well to be honest, I wanted to do something "small" to help me since I'm not as well versed in git [04:38:33] ironically, this was started because i was lazy.... :D [04:39:12] but I think I might be in the right direction. It works well considering -- but it's a bit slow to run because of the multiple requests to external sites. [04:39:22] and thank you very much for the comment :) [04:39:26] Hey there are a lot of proverbs about laziness = good programmers [04:40:02] yeah, work hard on a project to save you repeated redundant work :) [04:40:57] New patchset: Rfaulk; "fix. abort method does not attempt reset to a start tag when one does not exist." [sartoris] (master) - https://gerrit.wikimedia.org/r/63409 [04:40:58] New patchset: Rfaulk; "fix. dulwich tagging." [sartoris] (master) - https://gerrit.wikimedia.org/r/63410 [04:41:41] I found a php library that enables use of git without having git installed. Might be a good way to replace it with the current screen-scraping of gerrit. [04:41:59] And there are also notes on how programmers hate many of the supposed rules of writing English you're taught. [04:42:18] Stupid english [04:42:41] Horrible language. Super ambigious [04:42:55] ^_^ Of course when you actually do some research those rules on writing are complete FUD [04:43:31] * mooeypoo has a good excuse; she's a foreigner [04:43:35] New patchset: Rfaulk; "fix. remove debugger statement + pep8." [sartoris] (master) - https://gerrit.wikimedia.org/r/63411 [04:43:36] :D [04:43:44] * bawolff does not [04:44:53] * DanielFriesen proudly puts a comma before and instead of omitting it in 3+ lists and puts his punctuation outside of a quote. [04:44:58] When I was a gsoc student in 2010, pretty much every code review I got said something about my spelling [04:45:13] as long as you don't misuse "their/they're/their", I think that makes you better than many other native english speakers. [04:45:16] s/and/'and' [04:46:16] DanielFriesen: I have "Strunk and White" and even they disagree on commas. [04:46:35] a, b, and c FTW! [04:46:56] I write stories, so I use commas for flow control, mostly. [04:47:06] ^^ see what I did, there.. [04:47:18] :p [04:49:12] Lol [04:50:06] Every language has weirdness in it, but English idioms can be really weird to non-native English speakers. [04:50:15] Even something as small and wide-spread as "Break a Twenty". [04:50:41] * DanielFriesen rips mooeypoo's bill in half. [04:50:46] First time someone asked me if I could break a twenty, I thought he was pulling my leg (which is another funny idiom, but at least graphically understandable) [04:51:02] Ah, see, even that isn't really breaking it. You'd need to freeze it first. [04:51:05] * mooeypoo thought a lot about this [04:51:10] lol [04:52:44] "To drink like a fish" is another weird idiom. I get the meaning, but if you think about it, it's really quite silly. [04:53:20] New review: Tim Starling; "Looks good to me, apart from minor issues inline." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [04:56:52] I always assumed the break a 20 thing went back to old days where people used a $20 lump of gold that could be broken in two [04:57:17] I think it does, yeah. But as a newly-minted English speaker, it was a bit weird to hear for the first time. [04:58:30] When I get tired, some of the rules get jumbled in my head. That results in some amusing English errors (usually spoken, I catch them when I type) -- like, for instance, saying "I fat into it" instead of "fit" [04:58:38] I mean really, English. Sit/Sat. Fit/Fat. [04:58:58] Drink Drank... [04:59:31] Lol [04:59:46] Also, this one I get right, but it confused me at first -- One Louse, Many Lice. One Mouse, Many Mice. One House... [05:00:17] One mouse, many mouse... [05:01:48] Another confusing inconsistency: Rough, Tough, Cough --> Dough [05:08:16] New review: Tim Starling; "Why is auto-login still needed? Why not just wait until the user actually visits another wiki?" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [05:44:27] New review: Daniel Friesen; "Good point Tim. Though when on the other wiki we'll need some way to know whether the user is logged..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [06:05:12] hm, anyone knows where I can find the mediawiki developer's styleguide? [06:05:16] is there any such thing? [06:05:37] mooeypoo: I'm sure there is... [06:05:48] yeah I thought so too, but I can't find it atm. [06:05:59] Huh, let me try (once Firefox works again) [06:06:10] oh! [06:06:13] http://www.mediawiki.org/wiki/Style_guide [06:06:22] Oh, is that it? [06:06:24] ... that was easy O.o haha [06:06:34] * Matthew_ high5s mooeypoo [06:06:36] Nice :) [06:06:45] :D hehe i was looking for it the wrong way. bah hehe [06:07:17] Heh, OK. That's quite all right, no harm done. [06:07:19] * Matthew_ reads [06:07:46] ah, spaces, spaces. I need to remember spaces. [06:23:07] If in doubt add spaces [06:23:24] yeah there's a bunch I need to change, style-wise. [06:23:46] oh! shoot, I forgot to take off the error reporting. bah. Good catch on that email. [06:24:36] I don't understand the first comment. What does it mean "Your RL module should have a remote path in addition to a local one" ? What's "RL module" ? [06:40:08] Mooeypoo: rl = resource loader [06:41:22] mooeypoo: http://www.mediawiki.org/wiki/Manual:Coding_convention is what you want [06:41:30] not Style_Guide [06:42:39] Mooeypoo: style wise your extension is pretty good [06:43:18] Mooeypoo: the only thing that stuck out to me was the scCommit class [06:45:23] Mooeypoo: since usually in mw class names start with capital letters, and are rarely abbreviated (however given its an ext and not core, people are somewhat less picky on the nitpicky things) [07:04:26] bawolff & p858snake|l_ : I looked at the styleguide http://www.mediawiki.org/wiki/Style_guide and it seems I'm not quite there... but do I go by that, or by the coding convention? [07:05:23] you want the coding convention page [07:05:28] bawolff: also, I was worried of using "Commit" as is in fear it may be already existing somewhere (I know there's a Git class used by MW) but I can change it, or I can rename it to uppercase SECommit [07:06:00] the style guide is for for the visual stuff, but don't really worry about that till you have something decent and functional [07:06:10] Ah, okay. I'll go over that, then. [07:06:13] Thanks :) [07:06:15] I would reccomend SECommit [07:06:44] Wow I didnt even know we had a ui style guide... [07:06:54] oh, wait, this: http://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP <-- is what I was looking at, it's linked from the style guide [07:07:50] bawolff: we don't, the foundation does [07:08:09] :p [07:08:14] that randomly strung up without community involvement [07:08:17] *sprung [07:08:26] ROTFL... Comment spam has been getting stranger and more unique recently but this one is the nuttiest one I've ever seen. [07:08:33] okay, hm, I'm wondering about the language comment. The Special:Version page uses $wgLang->timeanddate( $datething ) and I used the same. The comment in the email suggests I use $this->getLanguage() but then it won't be consistent. [07:08:38] Should I be inconsistent? [07:08:51] mooeypoo: ->getLanguage is consistent. [07:08:52] as in, should I do "better than" Special:Version ? [07:08:58] Anything using $wgLang is wrong. [07:09:01] DanielFriesen: hi! thanks for the comments :D [07:09:18] Die wgLang [07:09:28] oh. Okay, Special:Version used it hehe :) that's why I did too. I'm looking for the ->getLanguage that converts date in the documentation now [07:09:45] The only reason some parts of Special:Version are still using $wgLang is probably because there are a few spots that are static when they shouldn't be and hence have no context. [07:09:48] Its the same [07:10:47] $this->getLanguage () usually points to the same object as $ wgLang [07:11:02] 99% of the time [07:11:18] Or more specifically $wgLang is basically RequestContext::getMain()->getLanguage(); [07:11:27] ohh [07:11:29] It's a deprecated global. [07:11:37] I didn't see that in the documentation, thanks for that! [07:13:03] Mooeypoo: btw some other things - you should have a qqq language with documentation about messages [07:15:13] Ooh, okay. [07:15:51] Well I guess it doesnt matter if your ext is not at translatewiki [07:16:28] Any reason for using git hub instead of wikimedia's git repo [07:18:27] oh, I don't know how to open a repo on gerrit? [07:18:40] You also use {{Special:Version}} in one of the messages. You probably meant to use [[ instead of {{ [07:18:43] And I wans't sure if this was a wayward attempt at an extension or if it was worthy of work [07:19:18] Opening a repo on gerrit is an annoyingly beurocratic process [07:20:03] Basically you ask chad. There is a request page somewhere on mediawiki.org [07:20:05] yeah I figured that I'll have GitHub first, and if it's good enough I can transport it into gerrit [07:20:27] that's also why I didn't put the external link yet btw.. i figured I'll wait with making it an Extension: page in mw [07:20:36] 'till I know if it's a worthwhile extension. [07:20:45] I definitely think its worthwhile [07:21:11] :) Thanks! [07:21:37] hi, anyone knows where the HTTP_X_SUBDOMAIN value comes from? Who sets it? [07:21:43] New review: preilly; "04:53:43 + tee pep8.txt" [sartoris] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/63410 [07:21:52] grepping is not helping [07:22:42] btw, what do you think about the "fallback" of checking file modification time? I was really struggling with this decision, because it could be misleading if someone copied their folders or something like that, but I am not sure I have any other solution if git's not available. [07:23:26] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/63409 [07:25:22] Im not sure if you have to many other options [07:26:13] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/63410 [07:26:33] Yurik: i have never heard of that before - but if its a http header, probably varnish [07:26:51] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/63411 [07:28:38] bawolff, yes, but the closest i found in varnish is "set req.http.x-subdomain = ..." -- very close... experimenting... [07:29:51] I believe php turns x-foo headers into array keys like HTTP_X_FOO [07:30:20] For thinks like $_SERVER globals [07:30:27] *things [07:33:28] Mooeypoo: btw the version numbs on extension pages are usually horrible outdated [07:33:40] yea that was also my fear [07:34:08] that's why I went for the commits, I figured the version number itself is probably not reliable, but if we know how many times people pushed changes, we can guesstimate if the extension is outdated or not [07:35:01] but that means there'll be a problem with extensions that don't use git repos, or that use external git repos. I think maybe adding some option to add an external repo path in the settings could be the best solution for the moment. [07:35:05] Still looking into that, though. [07:35:14] I'm a little meh about the fact i'm basically screen-scraping gerrit. [07:35:38] gerrit web, I mean. I'm pretty sure there should be a better way to do it. [07:36:29] hm, another question, guys.. I just fixed DanielFriesen's suggestion regarding the ResourceLoader external path, but then I noticed that there's also an option for 'messages' array you can have in there too [07:36:49] It's optional [07:36:55] what's the difference with that message array and the i18n file? [07:37:19] mooeypoo: That array is entirely for RL, the system that delivers css and js. [07:37:46] I see, so if I want to have messages in my js file, that's where I put them? [07:37:53] No [07:37:59] oh :) [07:38:16] mooeypoo: Messages in RL refers to a list of keys of i18n messages. This basically tells RL to take the i18n messages for those keys and then serve them to the browser so that scripts can use them. [07:38:33] You define all the i18n in the i18n file. Only a list of keys that you intend to use go in the RL module. [07:38:40] ohh. Gotcha. [07:38:42] thanks! [07:39:09] bawolff, yes, just checked, it does this weird magic. Thx. stupid varnish [07:39:20] thx :) [07:40:14] Of course im hoping that mw isnt dependant on weird varnish magic... [07:40:55] New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63416 [07:41:35] hm, I have to say, the MW docs leave some to be desired, they tend to be confusing at times. [07:42:10] but, granted, I'm a newbie who's used to super-noobish-friendly systems like wordpress extension documentation [07:42:21] That's putting it diplomaticly [07:42:45] hehe [07:42:46] Mooeypoo: its the number 1 bug! [07:42:58] Quite literally [07:43:11] is it? well.. hm. That's encouraging actually. I though I was being an idiot. [07:43:18] !bug 1 [07:43:34] Stipid bugs [07:43:43] *bots [07:44:11] Http://bugzilla.Wikimedia.org/1 [07:44:36] (Alas it is not #1 in priority) [07:45:47] maybe you guys should add it to next year's GSoC proposals.. I don't think I saw it there this year, could be something a student can do over the summer. [07:46:14] It's a little hard to do when your contributors are employees of a non-profit focused on using the software for their own sites and volunteers who contribute for their own personal reasons. [07:46:20] I can try and recommend some changes as I encounter them, but I definitely don't feel confident enough to *actually* change them. Maybe I sould post comments in the talk pages? [07:46:27] Mooeypoo: per the standard {{sofixit}} guilt trip, if you see anything easy to fix up, feel free to edit it ;) [07:46:41] * mooeypoo beat ya to it [07:46:55] vs. A for-profit company who's employees build the software for general use. [07:47:30] Don't try to win guilt-trip over me, I have a lifetime of experience by simply being Jewish. My mom after dinners and before trips? Bootcamp in guilt trip. [07:47:47] Lol [07:48:31] Remember when wmf hired someone to write docs? [07:48:36] DanielFriesen: Well, speaking of comparisons, here's a fair one: I've dabbled in some Wordpress extensions, and drupal and joomla, and I say this with utmost seriousness here -- you guys are the most newbie-welcoming so far. [07:49:05] Not much came of that if I recall [07:49:06] Wordpress, Joomla and Drupal communities (drupal a tad less so) are a bit snobbish and curt. It never felt comfortable to go and chat and ask questions like I can here. [07:49:29] Mooeypoo: that's excellent to hear [07:49:46] there's this attitude of "oh great, a newbie, why don't you read the damn docs in that page no one else found either before oyu come and ask this stupid question" [07:50:01] New patchset: J; "(bug 48300) escape title in edit url" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/63417 [07:50:12] See, we can't fall back to that [07:50:25] Because the docs suck too mich [07:50:29] So I think newbie-welcoming and true cooperation totally beats having good docs. [07:50:45] hehe i'll try not to take it as a reason not to improve them :P [07:50:53] New patchset: J; "(bug 46650) increase memory limit for frame extraction" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/63418 [07:50:58] Ideally we would have both [07:51:05] bawolff: Should I comment on the talk pages of those documents? I don't know if I should edit any of them directly (or if I even can) [07:51:48] You should be able to edit them [07:52:18] Some might require approval before the edit goes live [07:52:41] 'be able to' perhaps. "Should" not sure.. I'm still newbie, not sure I trust myself to write proper corrections. But I can point out things that might be confusing.. [07:53:17] The 'getting started' pages are pretty good [07:53:27] Feel free to do whatever you feel most comfortable with [07:53:49] but then the drill-down documentations are lacking. I resorted to looking at the raw code in https://doc.wikimedia.org/mediawiki-core/master/php/html/index.html [07:54:33] Remember that if you say something wrong its easy to undo yoir edit [07:54:48] Hm, true, but people may be confused until the error is caught [07:54:54] unless the fixes require review like code? [07:55:24] Some but not all pages are configure to require review [07:55:57] * bawolff mutters about flagged revs being ineffective on mw.org [07:56:34] Yeah the code comments are quite helpful imo [07:56:55] They are, but then you usually have to backtrack a lot to see where something comes from [07:57:07] Although I say that as a non newbie, I imagine rtfs is a bit intimidating [07:57:15] There's something about an XML reader as part of MW core I think? I was thinking of using it at first for the DOMDocument parsing [07:57:27] then gave up completely and resorted to the built in domdocument and xparse [07:58:02] We have an xml class, but its only for generating xml [07:58:08] Or really html [07:58:11] bawolff: they're excellent when you want to understand the code in the core, but as documentation to what you should use in your own extensions, it's messy to follow. [07:58:41] The xml vs html class divide is weird [07:58:58] Yeah, that's what I saw. [07:59:55] .... omg [08:00:07] I was about to say "you know what will be awesome? gerrit REST api" [08:00:15] Lol [08:00:15] and then I found that.. [08:00:34] https://gerrit-review.googlesource.com/Documentation/rest-api.html [08:01:00] hm. Seems you still need to authenticate, though. Not helping my extension. Could've saved the screen scraping and multiple html file reads. [08:01:02] I have a script actually that does stats from it [08:02:00] So does Susan (his is much better than mine) [08:03:39] hm. The way I do it works, but it takes a bit to load because I ask for several gerrit repo pages and parse their html for details. [08:04:13] if I can work with JSON replies, that'll make everything faster. I'll check into that. As far as I can see, the gerrit people have been talking about it in the groups but it wasn't yet fully implemented. [08:05:21] I do believe that we rin somewhat of a bleeding edge version of gerrit [08:05:29] *run [08:13:51] hmm. [08:20:52] oh! someone already made an extension like mine with external repos, but git-only. Collab-time? woot. [08:23:59] Mooeypoo: btw in regards to api, all wikimedia repos are also duplicated on gerrit, so you could potentially use their api [08:24:19] *duplicated on github [08:24:31] oh.. really? [08:24:36] * bawolff curses virtual keyboards [08:24:44] regularly? [08:25:00] Near instantly afaik [08:25:13] oh that's great [08:25:15] New patchset: Amire80; "Put the cog icon in the middle of the section title" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63419 [08:25:18] the only problem is finding where's what [08:25:48] gerrit is convenient in that aspect, all extensions have the same url with the difference of name only. Might have to find a creative solution to get them off GitHub [08:26:35] https://github.com/wikimedia [08:27:03] I think there is reasonble naming conventions [08:27:08] you know, thinking about it, I should also use the summary page instead of the shortlog page when i call the repo. I call the shortlog and then use the link of each commit to call its details..It was easier to parse but it is prbably redundant. [08:31:57] hm bawolff there's another problem with using the release convention -- Cite extension for instance, wasn't updated for a while, but I submitted a (tiny) fix to it a week ago for CSS. That doesn't really warrant a separate release [08:32:30] but it *was* responsible for a bug that VE caught, and was solved after upgrading Cite. [08:32:57] People backport changes to old release branchs sometimes [08:33:00] Not sure the releases, even if they were by convention, would've helped here, especially when you don't have a single "owner" for a lot of the extensions [08:33:34] yeah, that too. I think it may be safer to stick to reading actual changes [08:34:35] For example there was recently a fix for intersection extension that I backported to REL1_19 branch [08:35:22] Generally its only safe to assume the version from the release branch of the ext works with that version of mediawiki [08:35:31] New patchset: Spage; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62542 [08:36:06] New patchset: Spage; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62542 [08:36:18] New patchset: Spage; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62542 [08:36:29] And we encourage people to downliad the version corresponding to their version of mediawiki [08:36:57] Hm, good point. [08:38:00] oi, it's 5am again. That hour keeps coming every day, despite my attempts to ignore it. [08:38:04] Otoh its rare for an extension change to get backported for most extensions [08:38:11] Lol [08:38:27] Wait, are you in my timezone? [08:38:35] and I have exams this week.. I do studying during the day, and relaxing programming by evening, then before I know it, eveing turns into morning. [08:38:52] bawolff: NYC. Otherwise known as "The Center of Everything[TM]" [08:38:52] (Atlantic canada) [08:39:44] Canada! I never been, but I hear you guys have beauuuutiful scenery. [08:39:53] 1 hour behind me I think [08:40:03] You're at 3:40 now? [08:40:15] 540 [08:40:24] actually "behind you" woudl mean you're at-- yes. [08:40:29] No, it's 4:40 here. [08:40:50] so *almost* 5am. That's better than yesterday, I noticed 5 was coming when it was already 6am. [08:41:07] Canada scenery verries where you go [08:41:36] We also have a lot of boring scenery no one mentions in the travel guide [08:41:59] I'm sure. It's like that everywhere. [08:42:27] Other than New York, if you believe The Media, of course. It's all awesome and cookies here. [08:42:29] Most of the really pretty stuff is in the west [08:42:34] And Times Square. [08:42:56] I hear america is the land of unicorns [08:43:13] oh is it? Well, the Niagara Falls are in the east [08:43:29] It is. The run rampant. [08:43:38] Well unicorns armed with machine guns depending on which news station you eatch [08:44:12] Also, everything's huge here. [08:44:29] Of course my reference is puny in comparison, I'm originally from Israel [08:45:03] first time I saw a Wallmart I thought the entire state of Israel can be housed in it. [08:45:19] Yeah there is Niagara, but a large part of tourism is banf and jasper [08:45:24] Lol [08:45:56] And yet one can never actually find what you are looking for in a wallmart [08:47:11] I hear you need a map. [08:48:59] Gps [08:49:25] And if you're there too long, they call search and rescue. [08:52:50] You're getting your spaceman back soon, bawolff [08:52:59] Did you see his *awesomely win* music video? [08:53:13] I don't think so [08:53:34] https://www.youtube.com/watch?feature=player_embedded&v=KaOC9danxNo#! [08:53:39] pure space win. [08:55:42] That's awesome [08:55:44] David Bowie tweeted him back "Hallo Spaceboy" [09:20:47] ok, I'm off to bed, finally... [09:20:56] night guys, thanks for the help! [09:25:03] Night [09:25:52] New patchset: Siebrand; "Update formatting." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63386 [09:30:56] New patchset: Spage; "Blank some new Create account messages by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [09:32:16] New review: Spage; "Review feedback." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [10:00:34] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63427 [10:08:54] New review: Peachey88; "> Though when on the other wiki we'll need some way to know whether the user is logged" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [10:13:03] New review: Daniel Friesen; "When the user visits the wiki." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [10:30:05] hi all [10:30:21] i've got a simple PHP style question [10:30:30] which isnt answered in the PHP code conventions [10:30:48] in skins/Vector.php and skins/MonoBook.php [10:30:54] there are pieces of code that go: [10:31:02] if ( $foo == $bar ) { ?> [10:31:07]

some content

[10:31:12] [10:31:15] instead of: [10:31:26] if ( $foo == $bar ): ?> [10:31:32]

some content

[10:31:38] [10:31:46] i fancy that the second way is clearer [10:31:53] is there a reason for using the first ? [10:38:35] question answered #mediawiki [10:54:44] New review: Denny Vrandecic; "We need to unstuck this. I do not follow Krinkle's argument given at https://bugzilla.wikimedia.org/..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62785 [10:58:47] New review: Aklapper; "There shouldn't be an issue: longdescs.thetext does not store linebreaks when adding a new comment, ..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62218 [11:00:17] gerrit spam! [11:00:22] New patchset: Ori.livneh; "Add Redis module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63438 [11:00:22] New patchset: Ori.livneh; "Enable uploads and InstantCommons by default" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63439 [11:00:22] New patchset: Ori.livneh; "Add mediawiki::parsoid class" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63440 [11:00:23] New patchset: Ori.livneh; "Vagrantfile shared folder config: f/dmode to 755" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63441 [11:00:23] New patchset: Ori.livneh; "Add redis::php class & 'needs_update' param for extensions" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63442 [11:00:23] New patchset: Ori.livneh; "Add roles for VisualEditor, EventLogging, MobileFrontend, Echo and GettingStarted" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63443 [11:03:11] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63438 [11:03:28] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63439 [11:03:43] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63440 [11:04:02] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63441 [11:04:16] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63443 [11:04:16] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63442 [11:04:27] ..sorry. [11:11:54] New patchset: Ori.livneh; "Add explanatory comment re: run stages" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63445 [11:12:16] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63445 [11:12:41] New patchset: Siebrand; "Remove unused local variables" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63446 [11:15:27] New patchset: Siebrand; "Use localised count" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63447 [11:26:49] New patchset: Siebrand; "Make TranslateSandboxReminderJob::newJob() static" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63448 [11:29:04] New patchset: Siebrand; "JSON standard does not allow comments." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63449 [11:40:12] New patchset: Siebrand; "Update to jQuery UI Position 1.10.3" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63453 [11:40:12] New patchset: Siebrand; "Update jQuery Autosize to master" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63454 [11:47:18] New patchset: Ori.livneh; "Add a Rakefile for running puppet-lint against repo" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63455 [12:00:14] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63455 [12:08:37] New patchset: Matthias Mullie; "Claim anon feedback after sign up" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/33383 [12:48:12] New patchset: Amire80; "Add a MediaWiki preference for enabling ULS IME" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [12:52:12] @User:Jeremyb [12:52:14] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [12:52:40] hi I want to join Lab bot project [12:52:52] would you please add my name to this project? [12:54:07] @Jeremyb [12:58:09] New patchset: Ori.livneh; "Improve in-line comments for MFE and VE roles" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63457 [12:58:26] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63457 [13:02:33] New patchset: Luis Felipe Schenone; "(Bug 5798) Prevent overflow in the footer when there are no links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63458 [13:04:19] New review: Zfilipin; "Runa, what changed in patch set 3? You have uploaded a few new feature files?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [13:05:37] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [13:05:38] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [13:19:14] New patchset: Siebrand; "Fix incorrect file name" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63459 [13:33:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63458 [13:44:00] ugh, why do people /part ? [13:47:08] hrmmm, reza registered with NickServ on August 15, the same hour as NickServ last saw them [13:50:17] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63277 [13:51:28] New review: Zfilipin; "I have merged the commit into master since Karim gave +1 to my changes." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63277 [13:56:47] New patchset: Siebrand; "Tweak error message" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63462 [13:56:47] New patchset: Siebrand; "Message tweak." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63463 [13:56:48] New patchset: Siebrand; "Remove unused message" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63464 [13:56:50] New patchset: Siebrand; "Make proofread terminology more consistent" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63465 [13:56:51] New patchset: Siebrand; "Remove key not used in resource" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63466 [14:17:46] New patchset: Matthias Mullie; "Bug 43190 - AFTv5 API results should be wrapped in a {'query':results} object (for JSON)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/39038 [14:24:04] New patchset: Reedy; "Update Wikidata related branch points" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/63470 [14:24:20] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/63470 [14:26:47] New patchset: Reedy; "Remove final commit as no changes are there" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/63471 [14:27:02] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/63471 [14:28:09] New patchset: Matthias Mullie; "Bug 43190 - AFTv5 API results should be wrapped in a {'query':results} object (for JSON)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/39038 [15:34:52] Change merged: jenkins-bot; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/32035 [15:48:39] New review: Krinkle; "Aside from whether this change needs tests, please try harder. There is no such thing as "not having..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [15:48:55] New patchset: Reedy; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63479 [15:54:42] New review: Anomie; "@Tim Starling:" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [15:56:40] hashar: Krinkle heya, this "continuous integration" meeting that is on the WMF Engineering calendar that starts in 5 minutes, is it meant to be public? [15:56:43] I just noticed it, and well, it is relavant to andre__ and I's interests :) [15:56:46] greg-g: I think it is just timo and I [15:57:11] greg-g: And it is meant to be public yes [15:57:16] greg-g: What do you mean by public exactly? [15:57:30] well, joinable by people from WMF, I suppose [15:57:36] I just didn't see an announcement about it [15:57:53] It is our bi-weekly standup [15:57:54] like many teams have [15:57:54] oh, interesting! [15:58:01] I didn't realize [15:58:05] so, sort of private (not for non-staff) [15:58:06] and that is the very first one :-] [15:58:08] andre__: ^^ [15:58:11] however since we're both remote... [15:58:15] * greg-g nods [15:58:16] we do it via hangout [15:58:39] I didn't make it private, I mean, people can walk into office standups as well. You're welcome to peek :) [15:58:45] andre__ and I were wondering if we should join, but I'll leave you to it for now ;) [15:58:51] hashar: shall we? [15:58:54] I din't realize either, but I've copied it to my calendar now [15:58:59] :) [15:59:06] It's definitely great to know that it exists, so I'll try to be around from time to time for it [15:59:15] (plus CI in Bugzilla has quite some unprioritized tickets) [15:59:18] andre__: You should be able to add yourself to it (instead of copying it, thus disconnecting from the event loop) [15:59:35] edit the engineering calendar event and invite yourself if you like [15:59:42]