[00:17:43] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57913 [00:30:45] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57913 [01:03:25] New patchset: Daniel Friesen; "Change pageviewlang to pageviewlangattributes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63356 [01:08:30] New patchset: Daniel Friesen; "(bug 41545) Allow kbd, samp, and var to be nested." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [01:09:08] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30775 [01:11:31] New patchset: Aaron Schulz; "Made copyFileBackend.php skip files that cannot be copied instead of stop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63358 [01:14:42] New patchset: Aaron Schulz; "Made copyFileBackend.php skip files that cannot be copied instead of stopping." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63358 [01:16:46] New patchset: Daniel Friesen; "Move into the title key." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63359 [01:20:32] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63264 [01:21:34] New patchset: Aaron Schulz; "Made copyFileBackend.php skip files that cannot be copied instead of stopping." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63360 [01:27:15] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63360 [01:32:52] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63358 [01:34:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [01:36:21] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63358 [01:37:25] Hello Siebrand, are you here ? [02:25:14] Btw, does test.wikipedia.org have the same resource limits as normal wikis [02:44:18] New review: Karim.rayani; "nicely simplified, mine was a bit too complex" [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/63277 [03:07:27] New review: Karim.rayani; "Yes, We need to increase the timeout, it too had set the timeout to 30 seconds in the initial versio..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63247 [03:41:18] * mooeypoo screams in self-loathing [03:42:16] code suddenly stopped working.. went over *eeeeeeeverything* nothing makes any sense.. an hour later I realize: the URL I am testing? wrong one. [03:43:10] :) [03:44:20] gosh that was so weird. The irony is that now I'm not sure if I should be relieved that it wasn't the code or give up for the night and go play some mindless game. [04:12:25] New patchset: Ori.livneh; "Clean-up: use pip provisioner, virtual resources, run stages, etc." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63270 [04:33:07] New patchset: Ori.livneh; "Clean-up: use pip provisioner, virtual resources, run stages, etc." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63270 [06:11:43] New patchset: MichaelBillington; "wikihiero: changed all glyphs to a transparent background" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/63363 [06:20:01] Change abandoned: Hashar; "Lets hold the discussion on the bug so :-]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52611 [06:31:59] New review: PleaseStand; "First line of commit message should read, "WebRequest::getRequestURL: Follow up I34c3fc9d"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56344 [07:18:57] Nico_: what do you need him for? [08:12:07] New patchset: Nikerabbit; "wikihiero: changed all glyphs to a transparent background" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/63363 [08:13:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63339 [08:13:40] New review: Nikerabbit; "Optimized the images for size. Nevertheless the sizes grow considerably, the smallest ones tripling ..." [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/63363 [08:23:59] New review: Nikerabbit; "Once the bots learn this it's useless." [mediawiki/extensions/ConfirmEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/63342 [08:35:57] New patchset: Daniel Friesen; "Drop support for old skins that don't use head element." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [09:46:43] New patchset: Mwjames; "Add smw.util.namespace" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62561 [09:49:27] New patchset: Aaron Schulz; "Added missing continue to avoid fatal error." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63265 [09:51:22] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62561 [10:25:08] New patchset: Ori.livneh; "Clean-up: use pip provisioner, virtual resources, run stages, etc." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63270 [10:25:29] New patchset: Ori.livneh; "Clean-up: use pip provisioner, virtual resources, run stages, etc." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63270 [10:26:04] New review: Ori.livneh; "I tested the bejesus out of this." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/63262 [10:26:13] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63262 [10:26:28] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63270 [10:28:38] New patchset: Ori.livneh; "phpsh etc file should require phpsh" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63369 [10:29:34] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63369 [12:09:33] oh wow [12:09:43] i have ust discovered IEContentAnalyzer [12:09:57] This class simulates Microsoft Internet Explorer's terribly broken and insecure MIME type detection algorithm. [12:10:03] This class is based on a disassembly of IE 5.0, 6.0 and 7.0. [12:10:10] just... woah. [12:18:53] if ( $chunk8 == "\x89PNG\x0d\x0a\x1a\x0a" ) { [12:18:55] New review: Amire80; "Thanks for the patch. It's probably a step in the right direction, but I see a lot of artifacts arou..." [mediawiki/extensions/wikihiero] (master) C: -1; - https://gerrit.wikimedia.org/r/63363 [12:18:59] return 'image/x-png'; // [sic] [13:19:37] New patchset: Matmarex; "Remove the $wgHandheldStyle config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [13:24:39] New patchset: Matmarex; "Remove the $wgHandheldForIPhone config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63343 [13:45:09] New patchset: Matmarex; "Remove the $wgHandheldForIPhone config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63343 [14:17:17] New patchset: Platonides; "Variable $wgRestrictionLevels unused since 1cbaa921" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63376 [14:20:31] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56762 [14:28:47] New review: Krinkle; "I'll enabling voting shortly." [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/62945 [14:28:58] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [14:34:27] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63376 [14:40:06] New patchset: Daniel Friesen; "Improve language handling of page titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [14:41:55] Change abandoned: Daniel Friesen; "This can now be taken care of with I0ff707d5f04218bef5721e6fc162c6359bb7538a instead." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63359 [14:42:22] Change abandoned: Daniel Friesen; "This can now be taken care of with I0ff707d5f04218bef5721e6fc162c6359bb7538a instead." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63356 [14:42:45] Dantman: why aren't your commits fully tested by jenkins? D: [14:43:04] New review: Daniel Friesen; "I've abandoned my other changes in favour of I0ff707d5f04218bef5721e6fc162c6359bb7538a which can als..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57913 [14:43:10] New review: Krinkle; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [14:43:13] Dunno [14:43:28] Change abandoned: Matmarex; "Superseded by I0ff707d5." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57913 [14:43:50] Dantman: there's a list of "verified committers" somewhere in the repos [14:44:37] ;) well presumably I wouldn't have access to it [14:44:54] Dantman: you can submit a change anyway [14:44:57] found it [14:45:06] https://gerrit.wikimedia.org/r/#/c/42574/ that's my own whitelisting request [14:45:22] submit one and have someone merge it [14:45:40] New patchset: Krinkle; "mwext-CentralAuth-jslint: Enable voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63379 [14:47:29] I say "Override the directionality of the title with auto until we properly fix 32403", but it's possible that I've actually fixed that bug properly ;) [14:48:40] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63379 [14:49:15] New review: Krinkle; "Enabled voting in Ic22d7c6cb811fd7e303e." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [14:49:44] Dantman: huh, the links in look funny, don't they. https://bugzilla.wikimedia.org/show_bug.cgi?id=32403#c0 [14:49:44] at least they're links, though, they used not to be per comment 1 [14:50:57] MatmaRex: Whatdoyamean? [14:51:10] MatmaRex: BZ may not have good BIDI support. [14:52:34] Dantman: it has basically no bidi support afaik :P but the [[links]] in zeroth comment used not to be clickable [14:52:38] (and i fixed it) [14:52:43] now they just display funny [14:56:35] New patchset: Matmarex; "Whitelist Daniel Friesen (Dantman, nadir-seen-fire)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63380 [14:56:41] Dantman: ^ [15:07:03] New review: Matmarex; "Thanks for the fix." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63376 [15:08:11] New patchset: Anomie; "Add frontier pattern (%f[set]) to ustring" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/63381 [15:31:35] New patchset: Nikerabbit; "Login function for JavaScript" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [15:39:36] New patchset: Liangent; "(bug 34666) Escape URLs in XML files created by generateSitemap.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63383 [16:13:08] New patchset: Anomie; "API: Fix action=parse without any page or title or text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63138 [16:43:29] New patchset: Reedy; "Make voterList output at least some text" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/62860 [16:43:48] Change merged: jenkins-bot; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/62860 [16:44:04] New patchset: Reedy; "Change default importImages comment to "Importing file"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61288 [16:44:09] New patchset: Reedy; "Change default importImages comment to "Importing file"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61288 [17:05:48] New patchset: Reedy; "Blacklist alias languages on Special:SiteMatrix" [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60329 [17:06:59] Change merged: jenkins-bot; [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60329 [17:10:41] New patchset: Reedy; "(bug 34666) Escape URLs in XML files created by generateSitemap.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63383 [17:11:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61288 [17:14:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63383 [17:58:39] New patchset: Reedy; "Added missing continue to avoid fatal error." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63265 [18:02:02] New review: Reedy; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62192 [18:03:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63265 [18:09:13] New review: Reedy; "http://sourceforge.net/p/phpwiki/code/HEAD/tree/trunk/lib/difflib.php ? ;)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [18:31:50] New patchset: Siebrand; "Update formatting." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63386 [19:03:46] New patchset: Luis Felipe Schenone; "(Bug 17099) Added "(page does not exist)" to unexistent talk pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63387 [19:04:27] New patchset: Luis Felipe Schenone; "(Bug 17099) Add "(page does not exist)" to unexistent talk pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63387 [19:07:52] New patchset: Jforrester; "Add "(page does not exist)" to non-existent talk pages' tooltip" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63387 [19:46:40] New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [19:57:25] New review: MarkAHershberger; "Yes, care does have to be taken with the page. You can see how I implemented this for my client her..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/63342 [20:10:27] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #43: FAILURE in 9 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/43/ [21:06:02] New patchset: MarkAHershberger; "Add ability to keep q&a for QuestyCaptcha on the wiki." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/63342 [21:20:27] New patchset: MarkAHershberger; "Add ability to keep q&a for QuestyCaptcha on the wiki." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/63342 [22:00:44] New patchset: Mwjames; "Add smw.util.async" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62564 [22:03:47] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62564 [22:09:32] New review: Emufarmers; "I don't like this approach. Questions and answers should be stored in a separate table in the datab..." [mediawiki/extensions/ConfirmEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/63342 [22:25:20] New patchset: J?r?mie Roquet; "Add Special:DiffLink/### as an internally-linkable redirect to index.php?diff=###." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [22:31:00] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [22:33:22] New review: Matmarex; ""changeset 1afaa075" in your commit message points to nowhere?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [22:36:06] New review: MarkAHershberger; "I don't see why they shouldn't be stored in the wiki (except permission and security issues), but if..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/63342 [22:37:47] New review: Parent5446; "Why not just add this as functionality in Special:Redirect?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63395 [22:39:12] New review: J?r?mie Roquet; "Sorry, I'm not familiar with gerrit keywords." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [22:46:00] New review: J?r?mie Roquet; "@Parent5446: people mentioned Special:PermanentLink/###, which is pretty much the same thing as Spec..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [23:01:01] New review: J?r?mie Roquet; "@Matmarex: I wonder if it's not because the changeset is very old (2010) and is not tracked by gerri..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [23:09:46] Yippie, build fixed! [23:09:47] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #44: FIXED in 8 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/44/ [23:10:12] New review: Matmarex; "Ah, yes, of course. In this case it might be a good idea to mention "r79036" in the commit message a..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [23:15:27] New patchset: J?r?mie Roquet; "Add Special:DiffLink/### as an internally-linkable redirect to index.php?diff=###." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [23:16:05] New review: J?r?mie Roquet; "@Matmarex: done, thank you for the tip :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63395 [23:58:29] New patchset: Mwjames; "Fix some JS related docs in smw-core (jsDuck)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63397