[00:02:25] New patchset: Spage; "Message changes for new login form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63093 [00:02:31] New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [00:05:24] New patchset: Aaron Schulz; "Cleaned up the UI for the redirect login." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [00:07:34] Reedy: still around? [00:07:37] mmm [00:07:49] did I set wgCentralAuthAutoMigrate in the wrong file? [00:07:57] Was about to go and venture into the rain to get the guinea pigs [00:07:57] metawiki is telling me false [00:08:06] Dunno, where/how did you set it? [00:08:14] InititaliseSettings [00:08:19] default => true [00:08:28] Oh [00:08:32] tut tut tu [00:08:32] t [00:08:44] including the extension at a later point overwrites that value [00:08:48] rename it ot wmgCentralAuthAutoMigrate [00:08:51] yeah, was just thinking that [00:09:12] then do $wgCentralAuthAutoMigrate = $wmgCentralAuthAutoMigrate; in CommonSettings.php after including CentralAuth [00:09:22] yeah, okay, thanks [00:10:28] Though, if there's no reason to change it by wiki, you could just do it explicitly in CommonSettings after including CA [00:10:50] I can do that too, I have no idea why we would change it by wiki [00:15:08] Reedy: that worked, thanks for confirming my stupidity [00:18:32] New review: Dzahn; "confirmed. this replaces url_quote with uri, wouldn't even work otherwise because BZ dropped it and ..." [wikimedia/bugzilla/modifications] (master) C: 2; - https://gerrit.wikimedia.org/r/62837 [00:18:51] New review: Dzahn; "this repo doesn't have jenkins verification (yet)" [wikimedia/bugzilla/modifications] (master); V: 2 - https://gerrit.wikimedia.org/r/62837 [00:18:51] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [00:25:29] * AaronSchulz bugs Tim-away with https://gerrit.wikimedia.org/r/#/c/63017/ [00:30:02] New patchset: Bsitu; "Add code to randomly remove idling records from email batch" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63097 [00:35:22] New patchset: Bsitu; "Add code to randomly remove idling records from email batch" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63097 [00:44:13] New patchset: Kaldari; "Increasing z-index of personal toolbar from 1 to 100" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63099 [00:44:20] ASchulz|away: consider me bugged [00:46:19] New patchset: Kaldari; "Increasing z-index of personal toolbar from 1 to 100" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63099 [00:49:55] New review: Adamw; "(1 comment)" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62135 [01:05:05] New patchset: Adamw; "WIP device filtering" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63100 [01:12:37] New patchset: Aaron Schulz; "Removed unused join array from ActiveUser conds." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63101 [01:15:04] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [01:23:06] New patchset: Dzahn; "a few more diffs between prod and gerrit repo with bugzilla modifications in bugzilla-4.2" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/63103 [01:27:36] New review: Aklapper; "Re "just checked, the files in prod already use "uri" (why is another question)": That is because w..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [01:30:42] andre__: aaaah:)) [01:31:01] mutante, yeah yeah yeah [01:31:06] mutante, all covered in https://www.mediawiki.org/wiki/User:Malyacko/Bugzilla42Upgrade [01:31:17] andre__: could you take a quick look at this: [01:31:30] https://gerrit.wikimedia.org/r/#/c/63103/ [01:31:45] not more than like 3 lines, but are they ok? [01:31:56] i am wondering about the form mostly [01:32:07] in footer.html.tmpl [01:33:12] and in the weekly-bug-summary there is no "&datasets=ASSIGNED" [01:33:13] Will this fix the sidebar line wrapping issue? [01:33:18] Because that would be wonderful to see fixed. [01:34:03] i dont think it's related to sidebar [01:34:09] I don't think so, yeah [01:34:11] it's something in the footer [01:34:22] and the weekly summary [01:34:31] Oh, sorry, I was talking about that other BZ changes I saw. [01:34:51] the other * [01:36:50] The spaces in links in the sidebar use  . That's the bug. [01:37:58] The spaces in links in the sidebar use  . That's the bug. p858snake|l: Do you have a Gerrit account? [01:39:32] Yes, but not shell rights [01:39:36] as I don't need them [01:39:52] (shell as in git commit) [01:40:25] heh, shell != gerrit account [01:40:54] mutante: labs uses the term shell iirc, take it up with them [01:41:06] you should just need labs wiki user [01:41:24] p858snake|l: they mean shell as in "login to a labs instance via ssh" [01:41:53] but you should be able to make gerrit changes without ever actually using a labs instance [01:43:15] mutante: i'm well aware, Susan was taking to me task for suggesting she patch bz [01:43:20] because I know she wont [01:46:01] I was suggesting that you do it yourself. [01:48:47] Susan: I did my one and only patch back in the svn days kthx [01:49:45] One and done? [01:51:29] something like that [01:51:53] New review: MZMcBride; "(1 comment)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/63103 [01:52:04] New review: Tim Starling; "By huge do you mean 20MB? It's hard to see how they could be much bigger than that." [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/62233 [01:53:13] New review: Aklapper; "The change to drop the %3A in weekly-bug-summary.html.tmpl looks totally correct. New review: Ori.livneh; "Seems fine. The hidden input injects 'title=Special:Search' into the search params and thus the sear..." [wikimedia/bugzilla/modifications] (master) C: 2; - https://gerrit.wikimedia.org/r/63103 [01:57:04] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/63103 [02:21:23] New patchset: coren; "CREDITS: Spell my name right" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63104 [02:23:17] New review: coren; "Yup. That's my name now." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63104 [02:24:00] New review: Brian Wolff; "Alphabetically speaking, should you be before "Marcin Cie?lak"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63104 [02:30:08] New review: MZMcBride; "Follow-up to I41db0c0946bcef79a00d6d66e34114baaebe2ddc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63104 [03:42:21] New patchset: Mattflaschen; "Pass exact close method to onClose as new parameter." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/63105 [03:46:34] New patchset: Mattflaschen; "Show 'Next' button for action next and remove end tour checkbox." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [03:47:36] New review: Mattflaschen; "The latest patch set also removes the end tour checkbox, makes some related changes, and addresses S..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [03:58:53] New patchset: Adamw; "device filtering in GlobalAllocation" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63100 [04:03:57] New review: Mattflaschen; "This is on toro for testing." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [04:14:20] New patchset: Daniel Friesen; "Drop support for XHTML 1.1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [04:26:48] New review: Parent5446; "Not an expert on this, but the code changes look logical." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63106 [04:45:30] New review: Daniel Friesen; "RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Drop_XHTML_1.1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [04:52:59] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [04:58:41] New review: Mattflaschen; "This is on toro for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [05:39:31] New patchset: Pgehres; "Making sure state is loaded before resetting the auth token" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63107 [05:45:29] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63104 [06:00:03] New patchset: Tim Starling; "(bug 47365) Fix edge cases in mw.ustring.find, mw.ustring.match" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59861 [07:14:19] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:16:47] New review: Mattflaschen; "Thanks for reviewing. The ones that asked for changes are done in patch set 23." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:27:00] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [07:43:30] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [07:47:12] New patchset: PleaseStand; "Deprecate some unused one-line global functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63108 [07:47:39] New patchset: PleaseStand; "Make wfReadOnly() a wrapper around wfReadOnlyReason()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63109 [08:32:59] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63109 [08:58:33] New patchset: Foxtrott; "fix bug 47806 ("minor edit" and "watch this page" checkboxes no longer work in forms)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/63114 [09:10:29] New review: PleaseStand; "I searched an archive of CVS commit emails, and it turns out that Tim actually had what might be a v..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63108 [09:22:42] New patchset: PleaseStand; "Deprecate a couple one-line global functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63108 [09:46:11] New patchset: Foxtrott; "Fixed bug when $options array was empty in $select DomElement at SF_AutoeditAPI.php" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53270 [09:52:38] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59861 [10:06:10] New review: Yury Katkov; "looks nicer" [mediawiki/extensions/SemanticForms] (master) C: 1; - https://gerrit.wikimedia.org/r/53270 [10:19:18] New review: Physikerwelt; "see inline comments. Feedback is highly welcome." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [10:37:11] Change abandoned: Foxtrott; "Did not need it after all." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59052 [10:38:06] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [10:38:10] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [10:41:03] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [10:45:37] New review: Zfilipin; "I disagree. I think that step files should be named after feature files. If the plan is to have so m..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/61592 [11:09:22] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63087 [11:12:27] New patchset: Siebrand; "Add alt attribute for img" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [11:12:27] New patchset: Siebrand; "Set width for img to be integer" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63116 [11:12:27] New patchset: Siebrand; "Use correct casing for OutputPage::addHTML()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63117 [11:12:28] New patchset: Siebrand; "Close unclosed element div" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63118 [11:12:45] Project _debug-MobileFrontend-template build #16: FAILURE in 3 min 12 sec: https://wmf.ci.cloudbees.com/job/_debug-MobileFrontend-template/16/ [11:15:47] New review: PleaseStand; "Follows up r24529" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58308 [11:17:32] A follow up to a change from 2007? :P [11:19:22] New patchset: Siebrand; "Update code formatting and a few other nit picks" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63119 [11:32:22] Yippie, build fixed! [11:32:23] Project _debug-MobileFrontend-template build #17: FIXED in 4 min 16 sec: https://wmf.ci.cloudbees.com/job/_debug-MobileFrontend-template/17/ [11:35:24] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62340 [11:36:01] Project _debug-MobileFrontend-template build #18: FAILURE in 1 min 23 sec: https://wmf.ci.cloudbees.com/job/_debug-MobileFrontend-template/18/ [11:46:22] New patchset: Matthias Mullie; "(bug 42722) Show Protect Feedback (action=protect) for pages in whitelisted namespaces only" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63120 [11:52:44] New patchset: Siebrand; "Change EXIF to Exif" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63121 [11:53:15] New patchset: Siebrand; "Change EXIF to Exif" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/63124 [11:55:35] New patchset: Siebrand; "Change EXIF to Exif" [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/63125 [11:56:31] hashar: do you have some time to look at this? https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-merge/3020/console [11:56:44] ERROR: Error cloning remote repo 'origin' : Could not clone /srv/ssd/zuul/git/mediawiki/extensions/MobileFrontend [11:58:11] Yippie, build fixed! [11:58:11] Project _debug-MobileFrontend-template build #19: FIXED in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/_debug-MobileFrontend-template/19/ [11:59:11] zeljkof: jenkins has some issues right now. I am working on it [11:59:21] hashar: thanks [11:59:33] * siebrand greets Hashar. [11:59:47] and I think I finally found the root cause of all the issues we had [12:01:12] zeljkof: the bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=47331 [12:01:25] zeljkof: I haven't had time to look at it though. Just retrigger the tests :/ [12:02:25] New review: Shirayuki; "Thanks." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63121 [12:02:33] siebrand: howdy ? :-] [12:03:06] hashar: don't you just hate it when great minion tools fall over :( [12:03:17] hashar: getting anywhere with trouble shooting? [12:03:45] indeed I hate [12:03:46] it [12:03:55] and hate it even more when it takes a few full days to find out the cause [12:04:06] but I think I have a good candidate now :-] [12:04:36] hashar: That sounds promising. Well, know that my thoughts are with you! [12:05:48] the one that never talk back but manage to fix stuff anyway? :D [12:06:30] who's "the one" here? [12:06:57] me :D [12:07:11] oh, I assumed that, but wanted to be sure. [12:07:45] hashar: That's not how I see you, although I think that you could broadcast more often about your tremendous accomplishments. [12:08:16] I guess I lack self confident and prefer to avoid the spotlights [12:08:42] how [12:08:53] +? ? [12:09:06] "how" .. wrong window [12:09:08] :D [12:09:10] ah [12:09:38] so yeah I could broadcast more, not sure how to do it though and I sometime feel we all already receive ton of information [12:11:16] Project _debug-MobileFrontend-template build #21: FAILURE in 6 min 43 sec: https://wmf.ci.cloudbees.com/job/_debug-MobileFrontend-template/21/ [12:13:06] hashar: yes, we produce shitloads. [12:14:33] at least we are busy :-] [12:25:20] and the "I save jenkins" command is : find . -wholename ./*/builds/*/build.xml -exec fgrep -q DownstreamBuild {} ; -print -exec sed -i-back / /d {} ; [12:25:22] lovely unix [12:55:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63121 [13:02:01] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:02:15] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:02:27] New review: IAlex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:25:35] New review: Nemo bis; "Needs rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49494 [13:28:39] anomie: on https://www.mediawiki.org/w/index.php?title=Amsterdam_Hackathon_2013/Topics&diff=687897&oldid=687851 : It should really be a working session, with as little 1 to many communication as needed. [13:29:10] anomie: The details you changed suggest otherwise now. [13:36:40] New patchset: Anomie; "Add JavaScript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [13:38:40] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [13:38:40] New patchset: Anomie; "Add Javascript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [13:39:14] New patchset: Anomie; "Add JavaScript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [13:39:22] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [13:46:07] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/62925 [13:46:21] New review: Umherirrender; "Found two places which bad formatting now, needs also rebasing" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62980 [13:51:04] New patchset: Hashar; "Make jslint for voting for MobileFrontend" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62825 [13:52:34] New patchset: Hashar; "mwext-MobileFrontend-jslint is now voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62825 [13:53:37] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62825 [13:54:29] Yippie, build fixed! [13:54:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #56: FIXED in 4 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/56/ [14:00:37] Yippie, build fixed! [14:00:38] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #42: FIXED in 4 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/42/ [14:04:21] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [14:04:35] New patchset: Hashar; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [14:04:54] New patchset: Hashar; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [14:09:49] New patchset: Hashar; "trigger js jobs only when .js files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61277 [14:16:19] Yippie, build fixed! [14:16:19] Project browsertests-en.wikipedia.org-linux-firefox build #51: FIXED in 2 min 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/51/ [14:20:04] New patchset: Hashar; "trigger pep8/pyflakes only when .py files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61366 [14:21:43] New patchset: Hashar; "trigger PHP related job only when PHP files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61367 [14:21:52] New patchset: Hashar; "integration-zuul-layoutdiff now has colorized diff!" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/63131 [14:23:06] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/63131 [14:31:33] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61277 [14:32:01] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61366 [14:32:20] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61367 [14:34:28] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:34:31] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:37:27] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:38:39] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:43:15] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:51:31] New patchset: Zfilipin; "Refactoring: renamed step files so they have the same names as feature files" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63132 [14:52:09] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [14:52:41] New patchset: Hashar; "phplint always run or Zuul skips child jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63133 [14:53:12] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63133 [14:53:17] New review: Nikerabbit; "100px is very different from 100%. Either this rule is not needed or it should be moved to css." [mediawiki/extensions/TwnMainPage] (master) C: -1; - https://gerrit.wikimedia.org/r/63116 [14:53:54] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [14:56:59] New patchset: Alex Monk; "Set initial focus on some special pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49494 [14:59:05] New patchset: Hashar; "PHPUnit for extensions now uses --testsuite" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [15:03:42] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/LabeledSectionTransclusion] (master) - https://gerrit.wikimedia.org/r/63134 [15:04:31] New patchset: Arrbee; "Adding the feature file to test the bevaiour of the ULS cog icon from the sidebar for logged-in users" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [15:05:32] New patchset: Alex Monk; "Fix token parameter documentation on a couple of API modules" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63136 [15:14:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63101 [15:38:18] New patchset: Arrbee; "Adding ULS test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [15:39:49] Change abandoned: Arrbee; "Adding the patchset into a new branch 'ulstests' instead." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [15:43:17] New patchset: Rachel99; "test for cog" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [15:49:23] New review: Jforrester; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63099 [15:54:10] Change restored: Amire80; "no need to abandon, it's OK." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [16:05:23] New patchset: Anomie; "API: Fix action=parse without any page or title or text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63138 [16:28:57] Change merged: Katie Horn; [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/59048 [16:50:56] New patchset: Arrbee; "Adding more test scenarios for ULS user settings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [16:53:56] New review: Cmcmahon; "refactor for name clarity" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63132 [16:53:56] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63132 [17:06:55] New review: Siebrand; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [17:11:25] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [17:13:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63099 [17:13:06] hashar: ^ [17:13:17] one more thing [17:13:23] arghg [17:13:28] New review: Rachel99; "looks fine." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63132 [17:13:29] I swear :) [17:14:30] so did hashar, no? [17:14:56] AaronSchulz: that will be for monday :D [17:14:59] must leave the coworking place [17:15:05] and tonight I polish up jenkins :-D [17:15:09] hashar: I'll just fix it then [17:15:24] if you are willing to , that will be nice :-] [17:16:54] New patchset: Aaron Schulz; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [17:19:28] AaronSchulz: thanks Aaron :-] [17:19:35] if tests pass , I guess you can merge [17:19:42] I am off, host waiting for me. [17:19:43] *wave* [17:21:34] New patchset: Nemo bis; "Punctuation and consistency for log-description-thanks" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/63142 [17:21:47] csteipp: I guess you will have to look at https://gerrit.wikimedia.org/r/#/c/62925/ [17:22:54] AaronSchulz: I will do that. [17:23:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [17:23:53] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63007 [17:27:08] jenkins still appears to be busted, at least for MobileFrontend changes :( [17:27:23] and the jenkins folk appear to all be MIA [17:36:23] New patchset: Pgehres; "Slight refactoring of migrateAccount for better stats. Adding resetting of authToken." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63145 [17:51:17] New review: Jeroen De Dauw; "This might be of interest: https://wiki.php.net/rfc/splclassloader" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [17:55:09] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53946 [17:58:01] New patchset: CSteipp; "Global user renaming" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [18:07:33] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63007 [18:12:23] csteipp, a security bug over turning on a blocking system? wat [18:13:11] Krenair: Yeah, it has IP's in it, so he was cautious. [18:14:36] csteipp, I can see the bug creation and it definitely doesn't contain IPs [18:14:52] If someone moved it to security because they wanted to add private info I can understand why it's there but it's still not okay [18:21:23] New patchset: CSteipp; "Add value to add() call when locking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63150 [18:27:37] so I am going to spam it here: Jenkins should be working now after much cleanup. Will hopefully post an explanation on wikitech-l tonight. Please spread the word and if anything goes wrong let me know by mail / bug whatever :-] [18:27:46] all: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [18:29:29] hashar: Is there a short version you can share? :) [18:29:38] marktraceur: after dinner :-D [18:29:43] basically : out of memory [18:29:52] hashar: That's an excellent idea, have good food [18:29:58] <-- indeed [18:29:59] :-:] [18:31:42] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63116 [18:32:19] New patchset: Siebrand; "Use correct casing for OutputPage::addHTML()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63117 [18:32:25] hasharFood: Thanks for all your work! [18:33:08] New patchset: Cmcmahon; "refactor: make separate feature/steps/page files for each preferences tab tested" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [18:35:04] New patchset: Jeroen De Dauw; "Got rid of autoload registration since we can auto resolve the paths" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63151 [18:36:33] New patchset: Jeroen De Dauw; "Got rid of autoload registration since we can auto resolve the paths" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63151 [18:39:45] New patchset: Mwalker; "Adding a global Context Class" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63154 [18:42:07] New patchset: Mwalker; "Adding Disk Based Store" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63157 [18:42:28] New patchset: Mwalker; "Adding Disk Based Store" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63157 [18:43:13] New patchset: Mwalker; "Cleanup Adyen" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63158 [18:44:38] New review: Jeroen De Dauw; "Ask now has loading purely based on NS and PSR-0 compliance: https://gerrit.wikimedia.org/r/#/c/63151/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [18:45:04] New patchset: Mwalker; "Adding a global Context Class" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63154 [18:45:09] New patchset: Mwalker; "Adding Disk Based Store" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63157 [18:45:13] New patchset: Mwalker; "Cleanup Adyen" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63158 [18:45:47] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [18:46:00] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [18:47:38] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [18:48:05] New patchset: Jeroen De Dauw; "Make use of @covers tag to increase test coverage report accuracy" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63161 [18:50:25] New patchset: Jeroen De Dauw; "Moved phpunit.php runner into Tests directory since it is not a PHPUnit test itself" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/63162 [18:52:18] New patchset: Adamw; "Amazon IPN listener" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [18:57:56] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/33383 [19:10:34] is hackathon hangout on? [19:16:16] marktraceur: the basic summary is on wikitech at http://lists.wikimedia.org/pipermail/wikitech-l/2013-May/069303.html :-] [19:16:21] James_F: thanks for your kind words! [19:26:06] New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [19:37:06] New patchset: Aaron Schulz; "Reduced memory usage a bit for copyFileBackend.php with --missingonly." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63166 [19:37:06] New patchset: Aaron Schulz; "[FileBackend] Added "adviseStat" option for the "listing followed by stat" case." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63167 [19:39:37] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/60189 [19:39:55] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [19:42:29] New patchset: CSteipp; "Add value to add() call when locking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63150 [19:46:10] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [19:46:54] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63166 [19:49:39] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63167 [19:50:22] it's good to know that there are no barriers between pedestrians and falling into canals in Amsterdam. I would not have guessed that [19:50:45] I think there sometimes are barriers, but sometimes there arent' [19:50:55] Especially in places where there's parking adjacent to the water [19:50:56] New patchset: Aaron Schulz; "Cleaned up the UI for the redirect login." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [19:50:57] On bridges they're more common too [19:51:08] So parked cars will form the barrier, unless the parking spaces happen to be empty [19:51:18] New review: Aaron Schulz; "Lowered timeout and shorten message (so it takes less time to read)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [19:51:24] (This sucks as a driver BTW, you freak out about driving your car into the water) [19:51:30] And yeah bridges have barriers for sure [19:52:13] New review: Aaron Schulz; "Nice catch" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63150 [19:52:15] RoanKattouw: you might remember from Portland that I can get kind of scared of walking over bridges over water [19:52:20] Yes [19:52:30] so I am morbidly curious about whether I will also be phobic about walking near canals [19:52:31] prediction: yes [19:52:39] ^demon: https://gerrit.wikimedia.org/r/#/c/63017/ sorry :) [19:52:42] Amsterdam has lots of little bridges, very few large ones [19:52:59] RoanKattouw: Park your car here: https://maps.google.co.uk/maps?q=York&hl=en&ll=53.956616,-1.083912&spn=0.003605,0.010568&sll=53.800651,-4.064941&sspn=7.361165,21.643066&hnear=York,+United+Kingdom&t=m&z=17&layer=c&cbll=53.956616,-1.083912&panoid=H_FsBF3o2YhH310_E7SFDw&cbp=12,352.94,,0,9.14 [19:53:06] :D [19:53:15] <^demon> AaronSchulz: Only cuz I love you, I'm trying to lurk today. [19:53:19] No barriers AND an incline [19:53:48] if all our key Ops people fell into the same stretch it'd be a root canal [19:53:49] People park perpendicular to the riiver [19:53:54] .. [19:54:01] * sumanah awaits being kicked [19:56:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63150 [19:56:23] sumanah: funny [19:56:26] ^demon|sick: I want that for monday [19:56:40] <^demon|sick> lgtm. [19:56:44] otherwise I'd have left you in the Cocoon of Safety [19:56:54] sumanah: James did just joke about all of our roots being in the same building getting high, except Roan because he doesn't do that kind of thing *and he's the Dutch guy* [19:56:58] * ^demon|sick sings the dependency hell song [19:57:40] <^demon|sick> hiphop on ubuntu 13.04 is awesome, only one custom package to install. [19:57:43] <^demon|sick> hiphop on osx sucks. [19:57:49] ^demon|sick: and on Windows? [19:57:53] * sumanah jests [19:58:07] <^demon|sick> I don't think it's even possible without something like cygwin. [19:58:29] sumanah: So the thing with the no barriers at the canal is, they put the sidewalk on the far side; so as a (sober) pedestrian you don't really have an excuse to be by the water http://goo.gl/maps/NE6GI [19:58:29] hiphop on windows: install a linux vm ;) [19:58:45] If you're running MW on windows anyway, you're not looking for speed [19:59:01] Oh! OK, that does help [19:59:02] you can use redis with windows [19:59:05] <^demon|sick> brion: You have OSX, help me ;-) [19:59:09] cachy cachy [19:59:24] one would need allkeys-lru of course [19:59:32] heh [19:59:46] and you need 4GB of visual studio to compile it [20:00:11] but it works alright...though you have to make the exe service yourself...meh [20:00:30] Really the canal is just the divider/median separating two halves of the same street, it just happens to be made of water instead of trees [20:02:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63017 [20:02:39] <^demon|sick> brion: OSX doesn't ship an elf.h anymore, and the libelf brew doesn't seem to contain it :\ Thus, I can't build libdwarf. [20:02:44] <^demon|sick> Fricking fantasy novel over here. [20:04:27] ^demon|sick: Tried libgandalf? [20:04:30] rofl [20:05:08] <^demon|sick> $ brew search gandalf [20:05:09] <^demon|sick> No formula found for "gandalf". Searching open pull requests... [20:05:58] the next release of Beautiful Soup is 4.2.0 and Leonard was thinking of including a pot joke in the release name or notes [20:06:55] We're getting quite a lot of Maximum execution time of 180 seconds exceeded errors atm [20:07:46] <^demon|sick> brion: nfc? [20:08:14] ^demon|sick: near field communications or normalization form C? [20:08:25] <^demon|sick> not a f'ing clue? ;-) [20:08:34] heh no i haven't tried building it on osx yet [20:08:41] that's what i got linux VMs for [20:08:49] i don't suppose it builds on 12.04? [20:09:00] <^demon|sick> It does, little more manual wrangling. [20:09:09] <^demon|sick> Have to install custom libcurl & other stuff. [20:09:22] <^demon|sick> 13.04+ has libcurl upstream + all things packaged other than custom libevent. [20:09:23] bah. not sure i'm willing to upgrade my linux laptop yet. 13.04 runs ok in a VM though [20:10:48] <^demon|sick> https://github.com/facebook/hiphop-php/wiki/Building-and-installing-HHVM-on-Ubuntu-13.04 good guide for 13.04, jemalloc and google-glog can be found in apt, no need for manual install. [20:11:56] New patchset: Ori.livneh; "Parametrize MediaWiki install path" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63215 [20:11:56] New patchset: Ori.livneh; "Add custom resource type for MediaWiki extensions" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63216 [20:16:26] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #43: FAILURE in 7 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/43/ [20:17:12] New patchset: MarkAHershberger; "MWTimestamp in ParserFunctions adds un-neccessary backwards-incompat" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/63217 [20:18:05] New review: MarkAHershberger; "came across this on a 1.19 wiki" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/63217 [20:19:48] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #39: FAILURE in 9 min 35 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/39/ [20:21:49] New review: Mwalker; "Couple dumb things but otherwise this look really good" [wikimedia/fundraising/PaymentsListeners] (master) C: -1; - https://gerrit.wikimedia.org/r/60958 [20:22:58] New review: Mwalker; "(1 comment)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [20:23:43] New review: CSteipp; "Works well with both js and noscript setups. I think it's a good improvement. Thanks!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/62925 [20:24:15] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [20:24:46] New review: Mattflaschen; "I haven't tested, but it looks right, even the leet! part." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/63216 [20:32:09] hashar: I'm glad it wasn't the Parsoid tests, I've had to abort them sometimes [20:32:28] marktraceur: :-D [20:32:58] hashar: Also, I think the #1 rule is you have to have pants on to work, I don't think working in pajamas is an issue [20:32:59] marktraceur: even if it has been the Parsoid tests, I would have invested the same energy since it would have been caused by the jenkins upgrade [20:33:12] marktraceur: ah I wasnt sure [20:33:19] I definitely had a pant pajama [20:34:21] New review: Adamw; "This is awesome!" [wikimedia/fundraising/PaymentsListeners] (master) C: -1; - https://gerrit.wikimedia.org/r/63157 [20:35:13] Yippie, build fixed! [20:35:14] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #13: FIXED in 6 min 3 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/13/ [20:37:05] Yippie, build fixed! [20:37:05] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #13: FIXED in 1 min 51 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/13/ [20:37:43] New review: Adamw; "Hmm, I don't think we should block on signature validation, but I will defer to your judgement here..." [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [20:39:51] <^demon|sick> brion: 12.04 instructions on same wiki seem to wfm, working on building it in a labs instance now. [20:41:45] spiff. i'll start testing hhvm on my linux laptop [20:41:56] i forgot the power adaptor at home so i'll set it up on the weekend :) [20:43:19] New review: Mwalker; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) C: -1; - https://gerrit.wikimedia.org/r/62516 [20:43:55] * Nemo_bis thought for a moment that hhvm could also make your laptop work without battery [20:45:36] New patchset: Aaron Schulz; "[FileBackend] Optimize the case were no operations are provided." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63221 [20:46:05] ^demon|sick: sorry, one more thing, which is super simple [20:47:36] New patchset: Hashar; "Fix global objects and singletons in NewParserTest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62228 [20:48:43] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63221 [20:49:32] New patchset: Aaron Schulz; "[FileBackend] Optimize the case were no operations are provided." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63222 [20:50:55] New review: Mattflaschen; "Generally, it looks good. It's nice to see this option." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [20:53:38] New review: Adamw; "Small typo with missing {}" [wikimedia/fundraising/PaymentsListeners] (master) C: -1; - https://gerrit.wikimedia.org/r/63158 [20:55:41] New patchset: Aaron Schulz; "[FileBackend] Moved short-circuit check from 6b1194b9 up to FileBackend." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63224 [20:56:23] New patchset: Zfilipin; "Adding ULS test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [20:56:48] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63222 [20:56:53] New review: Zfilipin; "I have asked a few inline questions." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [21:00:50] <^demon|sick> brion: Failure^H^H^H^H^H^H^H work in progress: https://github.com/facebook/hiphop-php/wiki/Building-and-installing-HHVM-on-OSX-10.8 [21:01:09] \o/ [21:06:07] New review: Spage; "All the changes seem logical, my local web site still works. " [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63106 [21:08:18] New patchset: Alex Monk; "Don't shown red box around unconfirmed email address in preferences if authentication is disabled" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63225 [21:09:44] New review: Brian Wolff; "I don't suppose just adding a comment will trigger jenkins..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59766 [21:10:50] New patchset: Brian Wolff; "Add identifying info (img_timestamp and img_sha1) to upload log." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59766 [21:12:30] I must say, the dashboard at https://integration.wikimedia.org/zuul/ is rather cool [21:18:52] anomie: Now that jenkins is back, could you re-plus 2 https://gerrit.wikimedia.org/r/#/c/59766/ ? [21:20:35] bawolff_: Done [21:21:15] thanks :) [21:24:28] Description of Parser::guessLegacySectionNameFromWikiText: "Same as guessSectionNameFromWikiText(), but produces legacy anchors instead." What are "legacy anchors"? [21:24:45] Yippie, build fixed! [21:24:46] Project _debug-browsertests-template build #130: FIXED in 4 min 45 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/130/ [21:25:07] New patchset: Pgehres; "Slight refactoring of migrateAccount for better stats. Adding resetting of authToken." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63145 [21:28:19] Kaldari: the old types of ids that didnt allow unicode due to restrictions in older versions of html spec [21:28:58] bawolff: thanks! [21:35:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59766 [21:39:00] Project _debug-browsertests-template build #131: FAILURE in 1 min 4 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/131/ [21:41:06] New patchset: Kaldari; "Mention notif has wrong anchor for header with link" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62110 [21:41:56] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62110 [21:47:59] New patchset: Zfilipin; "Adding more test scenarios for ULS user settings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [21:49:39] New patchset: Mwjames; "Add srf.settings class" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63230 [21:51:39] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63230 [22:01:16] New patchset: Mwjames; "Fix .jshintrc" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63232 [22:02:13] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63232 [22:03:30] New patchset: Mwjames; "srf.formats.gallery() fix class inheritance" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63233 [22:12:53] New review: Zfilipin; "The commit could use a few small improvements, but it is good enough for me." [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/63140 [22:14:08] New review: Zfilipin; "The commit can be merged, but I would like to get the answers to the questions (inline) first." [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/63135 [22:17:19] New review: Zfilipin; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [22:20:55] New patchset: Mwjames; "srf.formats.gallery() fix class inheritance" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63233 [22:22:56] thanks ^demon|sick! feel better [22:24:15] New patchset: Zfilipin; "refactor: make separate feature/steps/page files for each preferences tab tested" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [22:26:20] <^demon|sick> yw [22:26:22] <^demon|sick> and thanks [22:26:35] csteipp: monsieur steipp -- fundraising has turned it's evil eye back to templating; e.g. twig! any chance you might be able to get twig security reviewed sometime soonish? [22:27:05] * pgehres chuckles knowing what is on csteipp's plate [22:28:30] mwalker: Did rob put you up to this :) [22:28:38] Yeah, we were just talking about it yesterday [22:29:16] I've got a few other things that are higher priority, so it's after UMAPI, but before Limn [22:29:17] csteipp: actually no [22:29:37] adam got tired of dealing with fundraising payments forms :P [22:29:40] UMAPI! [22:29:45] OOOOOHHHHMMMMM [22:29:46] (https://www.mediawiki.org/wiki/Security_auditing_and_response) [22:30:00] * mwalker looks [22:30:18] ah User Metrics [22:30:38] with the MAPI bit in there I was thinking some sort of cool email thing I didn't know about [22:31:26] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63107 [22:31:37] New patchset: Demon; "Track branches in submodule_subscriptions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/63235 [22:31:43] kaldari: Is the footer used in the Notifications e-mails meant to be used in all MW e-mails now? Am about to change some of them, and if I'm meant to add that... [22:32:04] Change merged: Demon; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/63235 [22:32:58] csteipp, robla: so what use is twig beyond fundraising? [22:33:35] New patchset: Mwjames; "srf.formats.gallery() fix class inheritance" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63233 [22:35:48] New review: CSteipp; "One whitespace fix, but otherwise functionality looks good." [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/63145 [22:35:57] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63145 [22:37:36] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/63233 [22:39:39] New review: Zfilipin; "This patch set is significant improvement, but there are still a few minor things that should be fix..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/61592 [22:40:17] New patchset: Demon; "Add new repositories to meta repo" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/63237 [22:40:38] Change merged: Demon; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/63237 [22:40:44] New patchset: Pgehres; "Updates to CentralAuth maintenance script" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63238 [22:40:44] New review: Mwalker; "Mostly just rebase on top of the context patch and get rid of the line about generating a context id..." [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [22:41:19] greg-g: can I have a thunderless and not-so-bright lightening deploy right now? [22:41:39] to a CentralAuth maintenance script [22:42:40] New patchset: CSteipp; "Global user renaming" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [22:44:17] Change merged: Pgehres; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63238 [22:45:01] voiced [22:51:39] New patchset: Pgehres; "Whitespace fix followup to I72aba35" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63239 [22:51:44] Yippie, build fixed! [22:51:44] Project _debug-browsertests-template build #137: FIXED in 1 min 15 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/137/ [22:51:46] New review: Zfilipin; "This is a good first patch set, but a few things have to be fixed before it could be merged into mas..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/63137 [23:04:23] New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [23:07:46] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #58: FAILURE in 6 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/58/ [23:09:17] New patchset: EBernhardson; "Sample debugging configuration for MediaWiki" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [23:09:48] wmf-selenium-bot's notifications are hard to parse. Project : in [23:10:31] I'd much prefer 'build failed: ' [23:16:01] New patchset: Mwalker; "Adding Disk Based Store" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63157 [23:16:24] New patchset: Mattflaschen; "Show 'Next' button for action next and remove end tour checkbox." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [23:16:51] Yippie, build fixed! [23:16:51] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #40: FIXED in 9 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/40/ [23:19:59] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63239 [23:32:22] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [23:32:56] New patchset: Siebrand; "Update strings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63244 [23:59:20] New patchset: Cmcmahon; "Do the PDF test without cookies" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63247