[00:07:09] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [00:07:23] New review: Krinkle; "I'll write a post to wikitech-l." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [00:26:42] New review: Krinkle; "http://lists.wikimedia.org/pipermail/wikitech-l/2013-May/069218.html" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [00:59:38] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [01:02:13] New review: Mattflaschen; "This latest commit mostly updates the logging, which should completely match the new schema now (I d..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [01:06:14] New patchset: Reedy; "Fixup hardcoded usages of "User:" in CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:12:06] New patchset: Reedy; "Fixup hardcoded usages of "User:" in CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:20:56] New patchset: Reedy; "Fixup hardcoded usages of "User:" in CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:36:28] New patchset: Reedy; "Fixup function parameter documentation" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62943 [01:39:03] New review: Hoo man; "I'm not sure about the other replacements as well... (Untested)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/62941 [01:47:37] New review: Reedy; "Swapping for MWNamespace::getCanonicalName( NS_USER ) . ':' or similar barely seems any better than ..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:50:16] New review: Hoo man; "Sure... but using localized versions will surely get us into trouble." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:51:39] New review: Reedy; "It's amusing when people complain about things NOT being localized..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:56:08] New review: Hoo man; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/62943 [01:56:17] New patchset: Reedy; "Fixup hardcoded usages of "User:" in CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62941 [01:58:26] New patchset: Reedy; "Fixup function parameter documentation" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62943 [02:17:57] New patchset: Hoo man; "Add .jshintrc for CentralAuth and make it pass" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [02:18:15] New review: Spage; "I tested with ?tour=test tour, it works. Code asking itself "Did I style this a button?" is a littl..." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/62775 [02:22:40] New patchset: Hoo man; "Add .jshintrc for CentralAuth and make it pass" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [02:25:28] New review: Jforrester; "I guess we should switch jslint over to voting, then?" [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/62945 [02:26:14] New review: Hoo man; "Should be fine... yes :)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [02:30:51] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62775 [02:33:19] New patchset: Tim Starling; "[FileBackend] Added "adviseStat" option for the "listing followed by stat" case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [02:37:16] New review: Krinkle; "I'll enable voting once this is merged." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [02:50:52] New patchset: Hoo man; "Add .jshintrc for CentralAuth and make it pass" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [02:52:02] New review: Hoo man; "Addressed Krinkle's comments" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [03:46:46] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [03:51:25] New review: Mattflaschen; "Updated to make some changes, mainly keeping the navbar around after save. I was also able to elimi..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [03:56:38] New patchset: Krinkle; "phpcs: Fix WhiteSpace.LanguageConstructSpacing warnings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [03:56:45] Change abandoned: Krinkle; "Merged into I2df2f80b." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62757 [04:24:37] New review: Jforrester; "I'm imagining Peter meant to submit this too. :-)" [mediawiki/extensions/CentralAuth] (master); V: 2 - https://gerrit.wikimedia.org/r/62943 [04:24:38] Change merged: Jforrester; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62943 [04:32:31] New review: Mattflaschen; "The code for this is fine, and it better visually ties the refresh button to the image." [mediawiki/extensions/ConfirmEdit] (master) C: 2; - https://gerrit.wikimedia.org/r/62191 [04:40:15] New review: Pgehres; "I +2'd something earlier and Jenkins did +2 verify and then merge ..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62943 [05:07:06] New review: Jforrester; "Yeah, it worked for https://gerrit.wikimedia.org/r/#/c/62839/ but not here. Gah, jenkins, do you eve..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62943 [05:18:09] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [05:25:43] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [05:26:09] New review: Pastakhov; "fix for Division by zero" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [05:28:58] New review: Tim Starling; "$backend->getFileProps() will download a copy of the file from Swift, then parse the entire Vorbis b..." [mediawiki/extensions/Score] (master) C: -1; - https://gerrit.wikimedia.org/r/61181 [06:01:12] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [06:19:11] New patchset: IAlex; "Fix the target URL of HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [06:19:23] New review: IAlex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [06:19:48] New review: IAlex; "Fixes merge conflict" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [06:20:17] New review: Yurik; "I like this, but I am not too happy with the name - it implies the list of all usages of a single fi..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61817 [06:25:31] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [06:27:24] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [06:27:51] New patchset: IAlex; "Allow to set the ID of the main table in HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61347 [06:32:49] New review: Yurik; "P.S. In case you haven't seen it, have a look at the names table -- http://www.mediawiki.org/wiki/AP..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [06:45:12] New review: Umherirrender; "reply to P.S.: Yay, but list=alltransclusions does not list all templates, it list only all used tem..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [06:53:50] New review: Yurik; "I don't like the singular "file", which might be missleading. But allfilesusages is ugly :) If we do..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [07:06:05] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [07:07:27] New review: Pastakhov; "fix DebugView for array set ( $foo[$bar] = $bar; )" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [07:10:27] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [07:13:19] Change abandoned: Umherirrender; "This change has long outstanding review, no more support from my site for this patch set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37709 [07:16:15] New review: Umherirrender; "Yes, sounds right for me, so that is not a problem." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62146 [07:18:32] New patchset: Mattflaschen; "DO NOT MERGE" [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [07:19:27] New review: Mattflaschen; "Should not be merged until mw.hook is in both the release branches." [mediawiki/extensions/PostEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/62952 [07:22:00] New patchset: Mattflaschen; "Show toolbar after post-edit is done, if applicable." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [07:22:23] New patchset: Mattflaschen; "DO NOT MERGE" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [07:23:38] New patchset: Rfaulk; "merge. latest changes to testing." [sartoris] (master) - https://gerrit.wikimedia.org/r/62954 [07:24:06] New review: Mattflaschen; "Should not be merged until mw.hook *and* https://gerrit.wikimedia.org/r/#/c/62952/ (corresponding Po..." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/62953 [07:24:52] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/62954 [07:25:18] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:47:48] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [07:52:24] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62191 [07:53:20] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [07:54:47] New review: Pastakhov; "Allow double arrow in array definition ( $foo = array('foo' => 'bar'); )" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [08:01:36] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62342 [08:02:09] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [08:04:38] New review: Pastakhov; "fix double arrow in array definition" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [08:04:59] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62346 [08:19:30] New patchset: Rfaulk; "add. try finally block to ensure that teardown gets called after init_test_repo." [sartoris] (master) - https://gerrit.wikimedia.org/r/62956 [08:19:30] New patchset: Rfaulk; "fixes. rename non-test methods in test.py / ensure deploy dir exists / fix config." [sartoris] (master) - https://gerrit.wikimedia.org/r/62957 [08:19:30] New patchset: Rfaulk; "fix. Ensure args are provided in tests where required." [sartoris] (master) - https://gerrit.wikimedia.org/r/62958 [08:20:23] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/62956 [08:20:42] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/62957 [08:21:04] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/62958 [08:29:12] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [08:29:15] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [08:35:42] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/62793 [08:47:30] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62853 [08:49:44] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62854 [08:52:24] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [08:52:48] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [10:40:15] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62960 [10:41:08] New patchset: Matthias Mullie; "(bug 37427) Filtering by "helpfulness", ranking mistake" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62962 [11:20:09] New patchset: Matthias Mullie; "(bug 38460) Identify which filters triggered auto-flag actions" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62964 [11:25:17] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/52454 [11:26:03] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [11:26:12] New review: Hashar; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [11:29:26] New review: Hashar; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [11:30:17] what's the difference between http://etherpad.wmflabs.org/pad/ and http://etherpad.wikimedia.org/ ? [11:31:57] liangent: Looks like one is "Etherpad" and the other one "Etherpad Lite" [11:32:13] New patchset: Matthias Mullie; "Bug 43492 - Add AbuseFilter-feature to auto-resolve feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/48631 [11:32:39] http://en.wikipedia.org/wiki/Etherpad#Etherpad_Lite [11:33:24] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/48631 [11:34:27] multichill: so which service is preferred when I want a pad? [11:35:42] The one you like most? The etherpad.wikimedia.org is quite stable. Some pads from years ago are still on it, see for example http://etherpad.wikimedia.org/WLM [11:36:42] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62594 [11:38:33] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62595 [11:41:36] New review: Amire80; "This one is very good." [mediawiki/extensions/TwnMainPage] (master) C: 2; - https://gerrit.wikimedia.org/r/62813 [11:41:46] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62813 [11:44:14] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62597 [11:45:13] New patchset: Amire80; "Refactor header()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62592 [11:47:24] liangent: the wikimedia etherpad is the older version (which has issues with some browers), labs is a newer fork (e/pad-lite) which supports browsers better amongst other things [11:47:43] but wmflabs shouldn't ever be counted on for reliability for critical things [11:48:27] p858snake|l: I remember the .wikimedia.org one had some issues with IME [11:48:34] let me try the labs one [11:50:53] p858snake|l: nice that bug seems fixed on labs [11:51:28] New review: Zfilipin; "Can we abandon this commit?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59118 [11:51:51] New review: Zfilipin; "Can we abandon this commit?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59080 [11:51:56] New review: Zfilipin; "Can we abandon this commit?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59069 [11:53:49] zeljkof: if in doubt, abandon :-] [11:53:59] zeljkof: they can always get restored later on. [11:54:10] New patchset: Indranisen; "testscripts included for pdf/uls feature etc." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62968 [11:54:17] hashar: sounds good to me :) [11:54:34] it was a test bot moving commits from github to gerrit [11:54:52] so I guess it is not needed anymore [11:55:49] Change abandoned: Zfilipin; "Abandoning the change, as suggested by hashar at #wikimedia-dev. Restore if the change is still needed." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59118 [11:55:54] Change abandoned: Zfilipin; "Abandoning the change, as suggested by hashar at #wikimedia-dev. Restore if the change is still needed." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59080 [11:55:59] Change abandoned: Zfilipin; "Abandoning the change, as suggested by hashar at #wikimedia-dev. Restore if the change is still needed." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59069 [11:56:21] hashar: I just do not like to have trash around :) [11:56:48] :-D [12:18:41] New review: Zfilipin; "I have added a few inline comments." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/62749 [12:19:05] New patchset: Aubhav iitr; "Decoding urls before regexp matching in SpamBlacklist Extension" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/57935 [12:29:51] New review: Zfilipin; "I have added a couple of inline comments." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/62745 [12:46:46] New patchset: Jeroen De Dauw; "Remove usage of deprecated message methods from describe function" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/62970 [12:47:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/62970 [13:14:18] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62592 [13:28:33] New patchset: Amire80; "Reduce rerenderings in input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61363 [13:29:09] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61363 [13:30:56] New patchset: Siebrand; "Fix inconsistent docs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62975 [13:31:43] New review: Hoo man; "recheck" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62945 [13:33:49] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62960 [13:33:49] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62960 [13:43:21] New patchset: Amire80; "Update statsbar when changing group" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62345 [13:48:28] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62345 [13:52:54] Change abandoned: Zfilipin; "Moved to https://gerrit.wikimedia.org/r/#/c/62968/1/features/pdf_readonly.feature" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62745 [13:54:52] Change abandoned: Zfilipin; "moved to https://gerrit.wikimedia.org/r/#/c/62968" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62749 [14:04:56] New review: Zfilipin; "I have made a few comments on things that should be improved." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/62968 [14:09:37] New review: Zfilipin; "I forgot to say in the previous commit. Since the features are not implemented, they should be moved..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62968 [14:13:43] New review: Nischayn22; "This is only for licenses for cc right? others don't need that field." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53041 [14:16:22] marktraceur: Hey, https://gerrit.wikimedia.org/r/#/c/50760/ needs another look :) [14:18:22] New patchset: Matthias Mullie; "(bug 38474) Mixed directionality of AFT" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62978 [14:32:25] New patchset: Zfilipin; "accommodate slight change to behavior of Next button" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62824 [14:32:34] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62824 [14:46:44] Yippie, build fixed! [14:46:44] Project browsertests-en.wikipedia.org-linux-firefox build #49: FIXED in 2 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/49/ [14:50:13] New review: ArielGlenn; "Is 'scubVersion' supposed to be 'scrubVersion' in here?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [14:50:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62408 [14:51:46] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62980 [14:53:31] Yippie, build fixed! [14:53:31] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #54: FIXED in 4 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/54/ [14:59:34] New review: Zfilipin; "After a bit more thought, I think this commit should be abandoned. Every file should be committed se..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62968 [15:01:52] Yippie, build fixed! [15:01:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #40: FIXED in 7 min 37 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/40/ [15:02:53] New review: Siebrand; "Mostly wfm." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/59575 [15:03:36] Yippie, build fixed! [15:03:37] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #36: FIXED in 8 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/36/ [15:04:11] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [15:04:53] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:06:47] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:09:18] Yippie, build fixed! [15:09:18] Project browsertests-en.wikipedia.org-linux-chrome build #47: FIXED in 2 min 49 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/47/ [15:11:05] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:13:03] New patchset: Hoo man; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [15:13:25] New review: Hoo man; "Rebased again..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [15:16:28] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:18:53] Change abandoned: Hoo man; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42797 [15:19:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [15:21:01] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:29:31] New review: preilly; "Looks good." [sartoris] (master) - https://gerrit.wikimedia.org/r/62956 [15:30:47] New review: preilly; "Looks good. Nice work Ryan." [sartoris] (master) - https://gerrit.wikimedia.org/r/62954 [15:34:35] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62335 [15:55:58] New review: Siebrand; "We can make it an ignored message. Then rebuildLanguage.php will strip it from all translations." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [15:56:14] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/SpamBlacklist] (master) C: -1; - https://gerrit.wikimedia.org/r/57935 [15:58:11] New review: Siebrand; "Comment on PS10 not yet addressed." [mediawiki/extensions/Math] (master) C: 1; - https://gerrit.wikimedia.org/r/61987 [15:59:01] New patchset: Matthias Mullie; "(bug 37510) Clicking 'donate to Wikipedia' gives no warning message before leaving the page " [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62982 [16:00:30] Hi senindr! Sumana Harihareswara here [16:02:19] New review: Siebrand; "(1 comment)" [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/60675 [16:02:28] senindr: ping? [16:03:07] hi [16:12:13] New review: Siebrand; "(1 comment)" [mediawiki/extensions/RevisionCommentSupplement] (master) C: -1; - https://gerrit.wikimedia.org/r/62611 [16:13:07] New review: Siebrand; "(1 comment)" [mediawiki/extensions/RevisionCommentSupplement] (master) C: -1; - https://gerrit.wikimedia.org/r/62615 [16:14:53] senindr: Check this out -- https://en.wikipedia.org/wiki/Wikipedia:Teahouse [16:16:10] senindr: So, https://en.wikipedia.org/wiki/Wikipedia:Teahouse is a place you can go to get started editing Wikipedia for the first time [16:16:33] senindr: By the way: What languages do you speak? [16:17:55] New patchset: Nemo bis; "Make revcs-alert-norevision less obscure" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62615 [16:18:41] Change merged: Siebrand; [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62615 [16:18:46] sumanah: thanks for the link [16:19:16] New patchset: Siebrand; "Add JavaScript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [16:19:33] sumanah: I speak english, bengali and hindi [16:19:41] New patchset: Aaron Schulz; "[FileBackend] Added "adviseStat" option for the "listing followed by stat" case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [16:20:19] senindr: :) https://bn.wikipedia.org and http://hi.wikipedia.org/ also need editing -- arguably more than English Wikipedia does [16:20:57] New review: Nemo bis; "(1 comment)" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62611 [16:22:17] sumanah: what kind of editing? [16:23:12] New review: Siebrand; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/58924 [16:23:36] New patchset: Aaron Schulz; "Added a script to nuke deleted files from storage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [16:26:34] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [16:27:26] senindr: so, there are a variety of ways that you as a multilingual person can be really really outrageously helpful to open source and free knowledge [16:27:37] New review: Siebrand; "(1 comment)" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62611 [16:28:02] senindr: a previous OPW intern http://priyankaivy.blogspot.in/ specifically helped the people of Bengali Wikipedia get a better customization to help people cite references better [16:29:22] * Krenair just realised the '@global' in CA logs is not localised [16:29:46] senindr: but also, if you go to Hindi Wikipedia or Bengali Wikipedia and hit "random page" on the left, you'll see lots of articles with typographical errors that need fixing, "do we know if that's true?" "citation needed" marks that need resolving via research, and prose that could be improved [16:30:40] sumanah: thanks so much, will have a look [16:31:38] senindr: you should also look up Wikimedia UK https://uk.wikimedia.org/ which has lots of events to help you get started as a contributor - an editor, a photo-uploader, a tester, a coder, etc [16:31:58] New review: Siebrand; "(1 comment)" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62611 [16:41:14] New patchset: Umherirrender; "Avoid Generic accessor in Category.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62986 [16:48:08] New patchset: Siebrand; "Clarify from form/file" [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/62610 [16:49:51] New review: Aaron Schulz; "jenkins..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61728 [16:53:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [16:56:24] New patchset: Mwalker; "Use .change() instead of .click() in UI elements" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62987 [17:00:21] New patchset: Umherirrender; "echo is not a function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62988 [17:01:29] Change merged: Aaron Schulz; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62529 [17:04:17] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [17:05:32] New patchset: Yurik; "Revert "switch Zero to special branch"" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/62989 [17:10:53] New review: Nemo bis; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [17:16:31] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62987 [17:25:36] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [17:25:49] New patchset: Cmcmahon; "Next button no longer exists in this scenario, it is tested in the scenario that follows" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [17:27:32] mwalker: FYI http://ganglia.wikimedia.org/latest/graph.php?r=2hr&z=xlarge&title=MediaWiki+errors&vl=errors+%2F+sec&n=&hreg[]=vanadium.eqiad.wmnet&mreg[]=fatal%7Cexception>ype=stack&glegend=show&aggregate=1&embed=1 - in -staff the suspicion is your LD may have been involved [17:28:09] greg-g: Message delivered ^ [17:28:20] thankya sir [17:29:51] greg-g: all the exceptions are coming from wikibase [17:29:58] I had nothing to do with it! [17:30:00] * mwalker looks innocent [17:30:03] mwalker: yep, just figured out in -staff [17:30:12] mwalker: run away quickly! [17:30:15] ahhh!!!! [17:30:24] New review: Cmcmahon; "This change is similar to https://gerrit.wikimedia.org/r/#/c/62824/ . However, while the 62824 chan..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [17:37:20] New patchset: Aaron Schulz; "Defere the SiteStatsUpdate in attemptAddUser()." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62992 [17:37:30] Nemo_bis: on 24 February 2012 you created a blank Anonnotice on meta with the comment "to create registered-only sitenotice" -- do you remember why? [17:38:33] New patchset: Alex Monk; "Defer the SiteStatsUpdate in attemptAddUser()." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62992 [17:40:02] mwalker: for the reason stated in the edit summary? :) I don't understand the question [17:41:02] or if you mean why sitenotice https://meta.wikimedia.org/w/index.php?title=MediaWiki:Sitenotice&oldid=5303413 [17:41:17] ... so you just wanted to ensure the creation of the siteNotice and localNotice div? but not have anything in them? [17:43:32] I'm mostly just curious as to the motivation here --e.g. why are we injecting DOM content when it's blank? it's not causing any problems anywhere, just seemed odd [17:44:19] greg-g: can I flip a settings switch real quick before E3? [17:45:16] pgehres: yeah, there's time (whatcha doing?) [17:45:17] mwalker: so your question is on the how rather than why? [17:45:39] greg-g: setting $wgCentralAuthAutoMigrate to true [17:45:47] anonnotice is the sitenotice for anons; if you want to show sitenotice only to registered, you need to put it in sitenotice and blank anonnotice [17:45:48] which will attempt a password migration for users on login [17:45:58] pgehres: ah, cool [17:46:16] mwalker: but blanking a message means maming the custom local version ignored, so you need some content which is not whitespace [17:46:18] Nemo_bis: ah -- I get it now [17:46:31] pgehres: I assume this is planned and all that? (I don't really know the implications of that change... whether people will be pissed is my only concern with anything you're touching right now :P ) [17:46:58] unplanned, sort of, but we'd talked about do it a number of times [17:47:02] mwalker: IIRC Susan says to use

instead but most sysops are not as smart as him and just introduce some whitespace nobody notices [17:47:04] users should not notice [17:47:09] pgehres: cool :) [17:47:54] Nemo_bis: yep -- that's reflected in the history -- though it should be because

is a block element [17:49:09] New patchset: Umherirrender; "Fixed spacing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62994 [17:52:25] greg-g: … and we are going to wait. want to check something first [17:52:43] pgehres: good call :-) (I assume) [17:52:57] heh, it would only affect private wikis [17:53:08] no one cares about office wiki [17:55:03] New patchset: Mwalker; "Previews now work in all languages" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62997 [17:57:05] greg-g: and, actaully we are happy, simply answer [17:57:12] *simple answer [17:57:14] https://meta.wikimedia.org/wiki/IRC_office_hours Flow-related discussion in a few minutes in #wikimedia-office [18:00:08] greg-g: csteipp: deployed [18:01:20] cool [18:03:31] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [18:07:41] New patchset: Umherirrender; "print is not a function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62999 [18:14:38] Reedy: where would a wfDebugLog( 'CentralAuth', "Already fully migrated user '$this->mName'" ); log to? somewhere on fluorine? [18:14:54] Probably not [18:15:23] It's not setup in wgDebugLogGroups so it's not logged to file [18:15:53] ah, how much of a pain is it to add that group for a few weeks? [18:17:25] Add the line to InitialiseSettings and sync it [18:17:34] AFAIK it doesn't even need the file touching anymore to begin with [18:17:50] Okay, but no huge issue like udp2log streams? [18:21:58] Not sure [18:22:03] I'm sure someone will shout if it causes problems [18:22:27] greg-g: any problems if I add two CentralNotice patches to today's LD? [18:22:27] The Reedy Approach (tm) [18:22:41] * Reedy waits for Aaron|home to prove that adding the debug groups won't be a problem [18:22:46] AaronSchulz: I like that approach [18:23:00] https://gerrit.wikimedia.org/r/#/c/63001/ [18:23:02] :-) [18:23:07] "Will it scale? Fuck knows, just put it on enwiki" [18:23:11] haha [18:23:23] There's no test case like enwiki [18:23:31] CentralAuth is a baby since no one ever logs in [18:23:51] pgehres: just force everyone to log off -- change the auth token or something [18:23:56] Lol [18:24:05] mwalker: you think we don't already have that planned [18:24:12] New review: Ori.livneh; "The only blocker is the word 'DRAFT' in the commit title, I think :)" [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/59575 [18:24:31] mwalker: don't believe so, go for it [18:24:50] Aaron|home: there's also the E3 approach -- "I'm sure Reedy will shout if it causes problems" :) [18:25:11] ori-l: mind if I sync InitialiseSettings? [18:25:28] it isn't our window yet, is it? [18:25:29] aka, the pgehres approach of "use everyone else's windows" [18:25:37] I like that approach too [18:25:42] When's deploy time? Now! [18:25:44] ori-l: says 11-1300 [18:25:54] go for it, then. we're not deploying yet. [18:25:57] sweet [18:28:16] Reedy: wow, that log actaully is flying by [18:28:32] wait, I confused myself: ori: ya'll are planning on 1-3 or 11-1? [18:28:51] I had the slots switched on either gcal or the wikipage, one of them is right, one is wrong :/ [18:29:22] greg-g: I thought 1-3 but I'm always wrong so when pgehres said 11 - 11:30 I quickly accepted that so as to avoid looking like a flake [18:29:27] that's my usual tactic [18:29:41] "We're deploying? I mean, uh, yes -- we're deploying!" [18:29:54] !scap [18:29:54] Sync-Common-All-PHP - this is when Git changes are synchronised to the application servers. For further information, see [18:30:19] pgehres: it should logrotate automagically... [18:30:40] It is already at 9M [18:30:43] pgehres: Also, you might want to make a more specific log group. Loading from cache objects seems like useless information [18:30:48] indeed [18:31:10] but that requires a full deply of CentralAuth, so maybe during the LD window [18:31:14] ori-l: ok, yeah, 1-3 it is [18:31:28] greg-g: ok, thanks [18:31:38] pgehres: The API log is 27G, I think you're ok ;) [18:31:47] oh, huh, on the default wiki calendar E2 and E3 share the time period... I blame mwalker [18:32:09] shenanigans! [18:32:14] I blame mwalker for making the page awesomer but missing one tiny detail in a way humans tend to do [18:32:34] I blame the pixies! [18:32:35] >.> [18:32:36] <.< [18:32:43] We need etherpad for InitialiseSettings.php and CommonSettings.php [18:32:49] +1 [18:33:15] Special:Import it all and use CodeEditor [18:34:54] Reedy: yeah, I am going to make a "Verbose" key and redeploy in a couple of hours [18:35:05] New review: GWicke; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62121 [18:35:09] Change merged: jenkins-bot; [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/62610 [18:38:24] New patchset: Foxtrott; "fix menuselect: trim values" [mediawiki/extensions/SemanticFormsInputs] (master) - https://gerrit.wikimedia.org/r/63006 [18:42:01] New patchset: Bsitu; "(bug 48302) Enclose random links in plain text email with <>" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63007 [18:44:51] New patchset: Pgehres; "Adding CentralAuthVerbose wfDebugLog." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63008 [18:49:31] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [18:49:36] New patchset: Cscott; "Add attributes to the Parsoid-only tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [18:50:27] reedy@fluorine:/a/mw-log$ du --si archive [18:50:27] 327G archive [18:50:29] Whole lotta logs [18:50:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62999 [18:51:22] New review: Kaldari; "Doesn't work in gmail." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63007 [18:51:41] Anomie: any chance you could merge https://gerrit.wikimedia.org/r/#/c/59766/ [18:52:28] bawolff: +2ed. Although I expect it will turn out to need a rebase. [18:52:48] Damn release notes [18:53:05] If it does ill rebase it and ping again [18:54:05] bawolff: Yeah, it needs a rebase. [18:54:13] I always press the rebase button first [18:54:18] Can usually save a merge commit too [18:54:34] I try to remember to do that, but I tend to forget [18:57:04] * bawolff will rebase after he finishes doing his dishes [19:01:42] is Jenkins dead or just really behind? [19:06:53] New patchset: Pgehres; "Modifying CentralAuthUser->attemptAutoMigration to allow for home wiki specification." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63011 [19:20:32] New review: Spage; "Looking good, only comment and function name suggestions. Existing tours switched to Next then a fi..." [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/62778 [19:27:22] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63008 [19:28:56] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/62925 [19:35:44] Change merged: MaxSem; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/62989 [19:39:21] New patchset: Ori.livneh; "Update EventLogging to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63013 [19:43:08] New patchset: Foxtrott; "fix bug 36180 (JS modules not loaded for transcluded RunQuery forms)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/63014 [19:44:59] New patchset: Pgehres; "Modifications to migrateAccount to allow specifying the home wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [19:45:47] New patchset: Ori.livneh; "Update WikimediaMessages to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63016 [19:45:51] Change merged: Foxtrott; [mediawiki/extensions/SemanticFormsInputs] (master) - https://gerrit.wikimedia.org/r/63006 [19:48:54] New patchset: Aaron Schulz; "[FileBackend] Cleaned up resyncFiles() and added conservative resync option to FileBackendMultiWrite." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63017 [19:51:22] New patchset: Ori.livneh; "Update ConfirmEdit to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63018 [19:51:41] hashar: i had +2'd some changes in MobileFrontend a while ago and never saw them listed as jobs on https://integration.wikimedia.org/zuul/, so max wound up merging manually [19:51:46] is that a sign something is amiss? [19:52:14] awjr: it was probably waiting in the queue [19:52:26] there are a bunch of events waiting right now [19:52:36] hashar: don't queued items show up on the zuul status board? [19:52:46] New patchset: Umherirrender; "echo is not a function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62988 [19:52:53] awjr: the status page shows the jobs being processed [19:52:57] oh i see [19:53:06] queued items may be invisible [19:53:09] awjr: but Zuul has a queue of events received by Gerrit. It is show at the top of the page: Queue lengths: 68 events, 3 results. [19:53:27] awjr: so right now 68 events from gerrit need to be processed. Some of them are simple comments [19:53:33] ah yes [19:53:37] ok thanks hashar [19:53:51] awjr: and I got an issue with Zuul that does not process the queue fast enough [19:54:37] grmblbl [19:54:42] Jenkins might be stalled again [20:05:45] New patchset: Foxtrott; "Preparing release of v0.7" [mediawiki/extensions/SemanticFormsInputs] (master) - https://gerrit.wikimedia.org/r/63020 [20:07:02] Change merged: Foxtrott; [mediawiki/extensions/SemanticFormsInputs] (master) - https://gerrit.wikimedia.org/r/63020 [20:07:15] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #55: FAILURE in 6 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/55/ [20:07:35] Change merged: Rotsee; [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/59072 [20:11:17] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [20:11:55] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #41: FAILURE in 6 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/41/ [20:12:18] New review: Parent5446; "Same comments from PS1." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62549 [20:15:32] New patchset: Bsitu; "(bug 48302) Trailing dot in link is ignored in plain text email" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63007 [20:27:01] New patchset: Mattflaschen; "Bump GuidedTour for E3 deployment." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63021 [20:27:44] Project browsertests-en.wikipedia.org-linux-firefox build #50: FAILURE in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/50/ [20:28:15] New review: Parent5446; "Don't mind me. Not like my points are valid or anything." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62408 [20:29:45] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62408 [20:33:45] New review: Spage; "That's master." [mediawiki/core] (wmf/1.22wmf3) C: 2; - https://gerrit.wikimedia.org/r/63021 [20:37:58] New review: Mattflaschen; "Forcing due to Jenkins." [mediawiki/core] (wmf/1.22wmf3); V: 2 - https://gerrit.wikimedia.org/r/63021 [20:37:59] Change merged: Mattflaschen; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63021 [20:38:24] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63013 [20:39:13] New review: Spage; "Verified +2, Code-Review +2 and [Publish and Submit] to force it." [mediawiki/core] (wmf/1.22wmf3); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63018 [20:39:14] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63018 [20:41:44] New patchset: Pgehres; "Modifications to migrateAccount to allow specifying the home wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [20:42:26] New review: Pgehres; "PS2 rewords a message since apparently false can also mean partially true" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [20:45:19] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62988 [20:46:04] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63016 [20:48:30] Change merged: Raimond Spekking; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63010 [20:52:21] New review: Zfilipin; "I think we should check for _something_ on the page that opens. I will figure something out that wor..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/62990 [20:56:29] New patchset: Adamw; "(FR #908) Brazil requires extra personal infos" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/62933 [20:59:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62994 [21:01:10] New review: Cmcmahon; "the clause I removed is the "And" in " [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [21:03:19] New patchset: Pgehres; "Modifications to migrateAccount to allow specifying the home wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [21:07:15] New patchset: Brian Wolff; "Add identifying info (img_timestamp and img_sha1) to upload log." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59766 [21:07:33] Anomie:--^ [21:09:21] bawolff: ok [21:09:48] Thanks [21:10:39] New patchset: Zfilipin; "Next button no longer exists in this scenario, so we are checking for another element instead." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [21:12:11] New review: Zfilipin; "The point is that we check for _anything_ on the page." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [21:15:29] Hey ^demon, is it OK to sync WikimediaMessages master to 1.22wmf3? You made https://gerrit.wikimedia.org/r/#/c/60881/ , is it only for new 1.22wmf4 ? [21:15:58] <^demon> The message was only needed in 1.22wmf2. [21:16:03] <^demon> wmf3+ doesn't need it. [21:16:46] <^demon> So yeah, no worries from me. [21:17:19] ^demon, thanks [21:17:23] <^demon> yw [21:27:18] New patchset: Bsitu; "Make Echo talk page notification rely on enotifusertalkpages" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63070 [21:27:51] New review: Aaron Schulz; "Yes, I was considering that kind of approach after reading around on this a bit. I was familiar with..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [21:29:38] New patchset: Bsitu; "Make Echo talk page notification rely on enotifusertalkpages" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63070 [21:30:48] New review: Zfilipin; "Do not merge until the test is finished." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/50468 [21:32:00] Change abandoned: Zfilipin; "Abandoning this test commit. Restore it if it is still needed." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59058 [21:34:24] New patchset: Cmcmahon; "check for thumb since we'll click My Own Work next" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63071 [21:42:22] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [21:42:35] New review: Hashar; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [21:44:31] New review: Adamw; "(1 comment)" [mediawiki/extensions/CentralNotice] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62997 [21:44:31] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62997 [21:49:20] New review: Pgehres; "recheck" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63011 [21:52:30] New review: Zfilipin; "I have already made a similar change in https://gerrit.wikimedia.org/r/#/c/62990/" [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/63071 [21:53:37] New review: Hashar; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [21:54:40] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47848 [21:56:25] New patchset: Pgehres; "Adding a bit of logging to distinguish $wgCentralAuthAutoMigrate migrations from others." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63075 [21:57:21] New review: Matmarex; "As long as the message key is kept (because I still think changing it is a bad idea), can you please..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [21:57:23] New patchset: Cmcmahon; "Since we're going to check the My Own Work in the next scenario, check for image thumbnail here" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [21:57:49] Change abandoned: Cmcmahon; "wrong change id" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63071 [22:00:04] New review: Matmarex; "Niklas, can you recheck? :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [22:03:28] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [22:04:50] New review: Dzahn; ""The change could not be rebased due to a path conflict during merge."" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [22:06:43] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [22:07:03] New review: Jforrester; "recheck" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [22:11:39] anyone here on intimate terms with the commonswiki db? [22:12:20] New patchset: Zfilipin; "Since we're going to check the My Own Work in the next scenario, check for image thumbnail here" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [22:12:55] New review: Zfilipin; "Removed unused step definition." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [22:13:22] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62990 [22:16:11] Maryana: In what way? [22:16:41] trying to figure out which table will get me information about file usage on other wikis [22:17:21] there are three "interwiki link" looking tables in the commonswiki db, and none of them appear to contain this information :-/ [22:17:51] New patchset: Anomie; "(bug 48294) API: Fix chunk upload async mode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63079 [22:20:12] Maryana: globalusage [22:20:36] brilliant! [22:20:45] Maryana: try the globalusage table [22:20:45] It should have the relavent info for nonlocal file usage [22:20:48] thanks, reedy! [22:20:59] .. and bawolff_ :) [22:21:16] somebody needs to delete the empty interwiki table [22:21:19] is confusing. [22:21:30] Ah [22:21:36] It's because MW can use a table [22:21:39] It can use a cdb file.. [22:22:17] i truncated them all at one point as it was confusing that they were populated when we don't use them [22:22:20] one day in the glorious future, all of our tables shall be well-documented [22:22:30] and lo, peace and prosperity will reign throughout the land [22:22:36] Part of the issue here is likely that globalusage isn't a core tableS [22:22:45] So if you'd looked in tables.sql you'd be none the wiser [22:23:12] i see [22:23:28] New review: Alex Monk; "mostly trivial comments inline" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [22:23:29] i did not. i just blindly queried things that looked like they'd give me what i want [22:23:34] as i am wont to do :D [22:35:50] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [22:38:36] New review: Zfilipin; "Comments are inline." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/61592 [22:38:39] New patchset: Zfilipin; "add test for Preferences/Date and time, consolidate Preferences tests in preferences_readonly.feature, use new target tags" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [22:39:47] https://gerrit.wikimedia.org/r/#/q/project:+wikimedia/whatcanidoforwikipedia,n,z <-- ? test? [22:40:43] New review: CSteipp; "Seems sane, and needed for Ie45d6d6e464797800944157265aa37263a84b156." [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/63011 [22:40:59] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63011 [22:43:00] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [22:43:05] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/63015 [22:43:15] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63015 [22:44:10] mutante: i beleive there is a matching website [22:44:55] http://whatcanidoforwikipedia.org/ (but its not done yet, there was a post to the ML [22:45:11] http://www.whatcanidoformozilla.org/ [22:45:50] p858snake|l: ah, so probably just an initial repo that might get commits later, thanks [22:51:15] New review: Dzahn; "just checked, the files in prod already use "uri" (why is another question)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [22:56:26] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63075 [22:58:07] greg-g: can I add myself to the LD window? [22:58:28] pgehres: In a flash [22:58:58] Reedy: no worries still need to merge into wmf3 [23:01:13] pgehres: sure thing, just coordinate with mw-jenkinsbot [23:01:15] New patchset: Aubhav iitr; "Decoding urls before regexp matching in SpamBlacklist Extension" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/57935 [23:01:17] erm mwalker [23:01:24] lol [23:01:41] hehe [23:01:51] I guess it is that time [23:02:00] Well, if mw-jenkinsbot isn't playing nice, no code mergey [23:02:08] :'( [23:03:13] New patchset: Pgehres; "Updates to CentralAuth for SUL finalization" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63084 [23:03:39] mwalker: are you starting or can I push out CentralAuth if Reedy is done [23:03:51] I'm doing nothing.. [23:03:54] pgehres: go for it [23:03:56] oh [23:04:03] So I'm doing nothing wrong [23:04:46] Change merged: Pgehres; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63084 [23:05:30] New patchset: Mwalker; "Merge remote-tracking branch 'origin/master' into wmf_deploy" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63085 [23:06:02] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63085 [23:06:40] Reedy: all wikis are on 1.22wmf3, yes? [23:06:45] Yup [23:06:58] Cool. https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap#Schedule_for_the_deployments is behind :-) [23:07:00] https://noc.wikimedia.org/conf/highlight.php?file=wikiversions.dat [23:07:08] gj ?Susan [23:07:23] Susan: that requires effort to look at :-) [23:07:35] Heh, you sound like Reedy. [23:07:44] I didn't realize this file existed [23:07:45] #meh #effort #MEH [23:08:01] mwalker: How'd you think the version was controlled? :-) [23:08:11] Reedy: centralauth.log is now "crawling" relative to earlier [23:08:12] grep -v 1\.22wmf3 wikiversions.dat [23:08:15] Susan: magic [23:08:23] Yay [23:08:38] Reedy uses his wand for other nefarious purposes. [23:08:38] Susan: specifically, tiny little magic pixies [23:09:07] Reedy: I still need to kill one more chatty log line, but so much slower [23:09:43] mwalker: all yours [23:09:51] * mwalker evil laugh [23:10:01] MOIN! ALL MOIN! [23:10:54] New patchset: Pgehres; "Moving one more debug log line to the CentralAuthVerbose group" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63086 [23:11:01] Reedy: ^ if you are in the mood [23:11:10] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [23:11:52] New patchset: Bsitu; "(bug 48304) Add 'Feedback' link to the Notifications flyout" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63087 [23:12:01] * Reedy scans the source tree for anything else obvious [23:12:18] * pgehres was tail -f ing the log  [23:12:35] it is almost all that line now [23:12:41] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63086 [23:12:50] ty very much [23:13:12] jdlrobson seems to have merged a change with a prayer. [23:13:24] 28 usages of wfDebugLog( 'CentralAuth', [23:13:31] Susan: which one :) [23:13:33] > I'm working the assumption that the config change will be sorted and committed before next deployment. Code looks fine. [23:13:35] sounds about right [23:13:37] https://gerrit.wikimedia.org/r/#/c/63072/ [23:13:39] CentralAuthPlugin.php ones are fine [23:13:45] New patchset: Bsitu; "(bug 48304) Add 'Feedback' link to the Notifications flyout" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63087 [23:13:50] jdlrobson: Just be sure you're not setting a trap for the next person to scap/deploy. [23:14:07] Susan: there's a commit already - it just needs tweaking [23:14:22] worst case scenario the login page on en wiki will be a nasty gif [23:14:29] i'll make sure that's not the case don't you worry ;-) [23:14:32] :-) [23:14:51] * jdlrobson hates gifs unless they are of cats doing silly things [23:15:08] *sigh* here I am trying to do the right thing and use gerrit to manage my deploy branch and it fucks up [23:15:11] I hate gerrit [23:17:59] Gerrit is gr8. [23:18:04] New patchset: Ori.livneh; "Apply Bugzilla live hacks to Git repo" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [23:18:06] New patchset: Mwalker; "Update CentralNotice to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63089 [23:19:12] don't like to me Susan! [23:19:17] er... [23:19:19] lie [23:19:20] *lie [23:19:22] yes [23:19:45] New patchset: Pgehres; "One more minor update to CentralAuth logging" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63090 [23:19:46] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63089 [23:20:37] <^demon> jdlrobson seems to have merged a change with a prayer. [23:20:47] <^demon> Oh please don't say things like that on the day I change how everything is merged. [23:20:53] * ^demon freaked out for a moment [23:21:15] wait, there is a --prayer flag? [23:21:20] * pgehres needs that [23:21:57] <^demon> I have "alias pray=/etc/init.d/gerrit restart" in my .bashrc [23:22:06] heh [23:22:13] lol [23:22:40] alias abandonallhope=sudo reboot now [23:24:04] mwalker: lemme know when you are done [23:24:08] greg-g: I'm done with CN; but I was going to make a quick config change -- so if anyone else needs it whilst I prep the file they can have the window [23:24:13] me! [23:24:28] Change merged: Pgehres; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63090 [23:26:48] greg-g: I'm all done [23:27:08] Reedy: omg, the log is barely moving now, only like 1-5/s [23:27:27] New patchset: Cmcmahon; "fix format issues. see comment re: steps files Change-Id: Idf3db3b3ac756bcf3e0802b30474c4deacdecd51" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [23:27:42] pgehres: sweet [23:29:53] Surely abandoning all hope wouldn't be a reboot. [23:30:08] where is the Wikipedia-Wikidata database association hiding? is there any way to query Wikidata ID based on Wikipedia article name? [23:30:19] There's a sites table, I believe? [23:31:40] greg-g: ok; pushing my config change [23:32:44] New review: Cmcmahon; "This test for all of Preferences will ultimately have many steps and many pages. Steps files track t..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [23:35:21] greg-g: I'm done [23:35:39] Turkeys are done; artists are finished. [23:37:05] Susan: No, mwalker is getting a nice brownish colour from sitting next to the window all day [23:37:48] New review: Adamw; "mwalker: can you port this to fundraising-crm?" [wikimedia/fundraising/civicrm] (master) - https://gerrit.wikimedia.org/r/53653 [23:39:11] pgehres: did you break centralauth...? [23:39:17] I can't login to aa.wikibooks.org [23:39:20] did I? [23:39:27] Its closed ... [23:39:27] I get a "There is no user by the name Mwalker (WMF)" [23:39:40] Have you logged in before? [23:39:48] I did nothing that changes login behavior [23:39:48] I think so... [23:40:09] hurm... [23:40:39] mwalker: you have no account there [23:40:50] right... shouldn't it unify me? [23:40:59] you can't unify onto a locked wiki [23:41:02] ah [23:41:05] well that's annoying [23:41:11] it's my CentralNotice test wiki! :p [23:41:13] you've never logged in there before [23:45:05] anomie: I wonder which function in OutputPage to use for this css [23:45:14] (top loaded) [23:45:15] I used to have an account on tlh.wikipedia.org - and they meanly took it away from me :P [23:46:54] AaronSchulz: Same as for any other RL module. Just specify 'position' => 'top' in the module definition. [23:47:13] yeah, I see PageTriage using addInlineScript() for something like this [23:47:37] $out->addInlineStyle( '.client-nojs #mwe-pt-list-view, .client-js #mwe-pt-list-view-no-js { display: none; }' ); [23:47:56] That would probably work too