[00:03:33] Reedy: Could you approve https://gerrit.wikimedia.org/r/#/c/62760/ ? [00:04:40] New patchset: Reedy; "tests: Don't set wgStyleSheetPath in addition to wgStylePath" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62760 [00:11:03] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62760 [00:15:40] New patchset: Krinkle; "tests: Don't set wgStyleSheetPath in addition to wgStylePath" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62766 [00:17:18] New review: Krinkle; "Setting -1 to clear from review queue for now. Per your own statement it seemed like something that ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62100 [01:04:21] New patchset: Reedy; "Add Wikidata and Commons to sister projects" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62770 [01:24:21] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62766 [01:29:28] New patchset: Cscott; "Add attributes to the Parsoid-only tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [01:30:59] New review: Krinkle; "per bug" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57533 [01:57:05] New review: Mattflaschen; "Agreed, looks like this is no longer necessary. https://gerrit.wikimedia.org/r/#/c/62317/ is the co..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62126 [02:07:12] New patchset: Jqnatividad; "Changed MongoDB connect to use connect string giving flexibility to connect to remote host, specify port, etc. Also, MongoDB authenticate function has been deprecated." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62774 [02:16:25] New review: Yaron Koren; "Joel - thanks for this patch! But what does it do? :) Can you give an example of a call that uses th..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62774 [03:15:17] New review: Isarra; "This angsty wikipedian approves of this change. " [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62163 [03:16:41] The irony, of course, was that a wikipedian proposed the change, and another wikipedian implemented it. [03:25:51] Isarra: I'm going to start a coffee shop in the Mission for teenagers called Angst Y Cafe [03:26:19] * marktraceur looks at gerrit change by way of apology for the pun [03:26:27] Snrk. [03:27:15] * Isarra poins marktraceur toward bawolff's comment. [03:27:20] points [03:27:57] New patchset: Spage; "Blank some new Create account messages by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [03:28:07] *nod* that does make sense [03:28:59] New review: MZMcBride; "This seems fine to me. The associated bug discusses a desire to have larger inputs around the site, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62163 [03:29:25] Isarra: I commented. [03:29:28] I saw. [03:29:49] Well, that's two, can we get an angsty Wikipedian trifecta? [03:30:08] The one who submitted the patchset was a wikipedian. [03:30:23] Isarra: I'm just not feeling the *angst* [03:30:25] New review: Spage; "PS3 also makes "Can't see the image? _Request an account_" optional, the same idea." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [03:30:34] Angst takes effort. [03:30:59] Isarra: Not particularly, if you engineer your life really poorly it comes natural [03:31:08] Mike's a wikipedian. https://bugzilla.wikimedia.org/show_bug.cgi?id=13627 [03:31:11] * marktraceur punches the air [03:31:44] White Cat (the guy with the japanese username) is a wikipedian. [03:32:45] ToAruShiroiNeko. [03:33:19] Cool beans [03:33:38] Isarra: I meant on the patch itself, though I'm not sure I'm up to downloading/testing/merging at the moment [03:33:49] Food coma is going to soon turn into movie-and-beer coma [03:33:55] I tested it. It works. [03:34:16] Food coma prevented me from doing anything more useful so I just did that. [03:34:19] I may decide to review when back from the corner store. I ride! [03:34:31] Whoo. [03:34:53] Susan: Are you angsty? [03:35:55] At the moment, I'm a little gassy. [03:37:25] Is that related? [03:37:27] test.wikipedia.org feels painfully slow. [03:37:35] Or just alternative? [03:37:51] I'm not sure. [03:41:14] New patchset: Spage; "Blank some new Create account messages by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [03:41:24] * marktraceur puts on Brand New to make up for your lack of angst [03:41:30] Right, reviewing [03:41:52] New review: Isarra; "The collapsing/uncollapsing animation is needlessly slow. Personally I'd prefer not having an animat..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [03:56:39] New patchset: Mattflaschen; "Fix regression that made button click be treated as link click." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62775 [03:57:19] Hrm. [03:58:05] Isarra, Susan, I wonder if it would be good to give some more notice than code review for this...I mean, it's a Good Thing, but it maybe also could break gadgets if any of them rely on this element being a textarea [03:58:52] What possibly would? [03:59:00] I mean, there could be something, but... [03:59:16] Do we have to give notification for everything that might break something, no matter how unlikely? [03:59:19] I guess I could go spelunking for gadgets that change this page [03:59:22] marktraceur: Screenscraping? Don't care at all. [03:59:32] Maybe JS gadgets, yeah. [03:59:35] Maaaaaybe. [03:59:53] Yeah, that's the concern. But maaaaybe indeed. >.> [04:00:23] Not enough "a"s in "maybe" [04:00:37] A cursory search gives me nothing likely. [04:00:39] A mass move script would use the API, and that's the only sort of thing I can think of that would care about move reasons. [04:02:55] Well, [04:03:03] you could have a gadget that changes the textarea into an input. [04:03:04] Heh. [04:03:47] Susan: Wouldn't worry too much about breaking that, I guess [04:03:57] Right. [04:04:15] Right! [04:04:51] Left. [04:04:52] New review: Hydriz; "+1, though they are not language-based and may confuse some users that want to get a project in thei..." [mediawiki/extensions/WikimediaMaintenance] (master) C: 1; - https://gerrit.wikimedia.org/r/62770 [04:05:45] Hm, it looks like Brion maybe wanted to weigh in, though? [04:06:39] *shrug* naw, just added as a reviewer, never mind [04:06:57] New review: MarkTraceur; "I count Isarra and MZ as 1.5 angsty each, so I'm going to count that as "three angsty Wikipedians", ..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62163 [04:06:59] Change merged: MarkTraceur; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62163 [04:07:36] I suppose I should have said something about "this works" [04:07:38] Eh [04:08:11] Giggle. [04:08:28] Oh wow that was a lot of bugmail [04:09:11] * marktraceur is going to go hide from retribution with beer and movies now [04:09:30] It's a five-year-old bug. [04:10:20] Susan: If it's not one thing it's the other with you :P [04:10:43] Everything needs further thought!1 [04:10:50] Seriously, two fields on the page, and now that we've fixed the bug relating to the one field, you just had to open a bug about the other one [04:10:57] Heh. [04:11:14] I'm the worsgt. [04:11:14] worst [04:11:19] Susan: No, you're not! [04:11:35] The dropdown menu is cute. [04:11:36] Susan needs further thought. [04:11:41] But it does seem to trip people up. [04:11:45] Particularly new users. [04:11:47] It does. [04:12:00] Old too. It's easy to skip over and slows folks down. [04:12:02] 'm not disagreeing. [04:12:18] Would it be more better to have a separate input with some form of autocomplete? [04:12:26] Okay, so who can we blame? [04:12:33] Everyone. [04:12:35] Oh, speaking of autocomplete, Special:Log could use that. [04:12:41] * Susan goes to file another bug. [04:12:53] Susan: We can blame brion, he's not here. Or Ironholds, that's usually a solid plan. [04:15:09] * marktraceur stops talking about movies and leaves without even finishing what [04:16:09] I may need a new tracking bug. [04:16:11] * Susan thinks. [04:16:25] Yeah. [04:20:26] New review: Spage; "Re missing I9e33c21a: I made the blank createacct-imgcaptcha-help message a follow-on patch to Ie088..." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/62570 [04:21:26] New patchset: Parent5446; "Fixed behavior of Title::invalidateCache." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62406 [04:35:31] New review: Jakub Vrána; "Heck, it leaked from https://gerrit.wikimedia.org/r/62174. Thanks for catching it, I'll update." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130 [04:35:58] New patchset: Spage; "Blank some new Create account messages by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [04:35:59] New patchset: Jakub Vrána; "Prepare DatabaseMysql for mysqli" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130 [04:35:59] New patchset: Jakub Vrána; "Allow installing MySQLi" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62174 [04:35:59] New patchset: Jakub Vrána; "Add support for mysqli extension" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62173 [04:37:49] New review: Spage; "PS4 & 5 rebase -- translators made lots of changes to MessagesQqq.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [04:52:19] New review: Jqnatividad; "Hi Yaron," [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62774 [04:52:30] New patchset: Mattflaschen; "Show 'Next' button for action next, with related refactoring." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [04:52:41] New patchset: Jakub Vrána; "Prepare DatabaseMysql for mysqli" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130 [04:52:41] New patchset: Jakub Vrána; "Allow installing MySQLi" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62174 [04:52:42] New patchset: Jakub Vrána; "Add support for mysqli extension" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62173 [04:53:44] New review: Mattflaschen; "On toro for testing." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [05:01:37] Kaldari been around? [05:04:59] Here and there. [05:05:03] He usually hides in #wikimedia-ee. [05:06:44] I'll keep a lookout for him there, 'preciate it [05:07:46] suppose I might as well float the idea while I'm here [05:08:47] I was thinking on the gender categorization issue (i.e., http://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2013-04-29/In_the_media) [05:09:23] Seems to me that we could just use a little script to allow Wikidata filtering on category pages [05:12:27] New review: Demon; "Every time someone mentions Wikispecies, I have to remind myself that's still a thing." [mediawiki/extensions/WikimediaMaintenance] (master) C: 2; - https://gerrit.wikimedia.org/r/62770 [05:12:37] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62770 [05:17:13] Change merged: Demon; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/62613 [06:09:10] New patchset: Nikerabbit; "Make the main page look reasonable without JS" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62594 [06:12:35] New review: Nikerabbit; "This seems broken:" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62464 [06:14:01] New patchset: Tim Starling; "Remove support for hphpc" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/62780 [06:26:21] Published patchset: Wikinaut; "(bug 44849) improved icons for provider selection page" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/62781 [06:26:41] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/62781 [06:33:22] New patchset: Wikinaut; "Fix wording of openid-trusted-sites-delete-confirmation-page-title" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/62621 [06:34:15] New review: Wikinaut; "agreed." [mediawiki/extensions/OpenID] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62621 [06:34:15] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/62621 [06:35:47] Change abandoned: Wikinaut; "committed in https://gerrit.wikimedia.org/r/#/c/62781/ ." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/48354 [07:00:02] New patchset: FastLizard4; "Update URLs to point to the extension's proper location" [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/62783 [07:00:34] New patchset: Tim Starling; "Remove hphpc support and deprecate related functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62784 [07:08:47] New patchset: Wikinaut; "added newline character after the delete message." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [07:11:43] New review: Ori.livneh; "LGTM; haven't tested." [mediawiki/extensions/GuidedTour] (master) C: 1; - https://gerrit.wikimedia.org/r/62775 [07:15:10] New patchset: Aude; "Add option to not log autopatrol actions to logging table" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [07:22:20] New review: Demon; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [07:42:03] New review: J; "ah ok, get the same results with $wgScoreTrim = false. looks much better." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [07:47:53] New patchset: Hashar; "jobs for mw/ext/TwnMainPage" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62786 [07:49:37] New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/62786 [07:49:37] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62786 [07:49:50] New review: Hashar; "recheck" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62594 [07:51:50] New review: Hashar; "The job were not existing in Jenkins. https://gerrit.wikimedia.org/r/62786 has been used to create t..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62464 [07:56:22] New patchset: Aude; "Add option to not log autopatrol actions to logging table" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [07:57:32] New review: Aude; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [08:01:49] New patchset: Mattflaschen; "wgUserId is now in core." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62788 [08:02:44] New patchset: Hashar; "mw/ext/wikibase now has gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62666 [08:02:44] New patchset: Hashar; "mwext-Wikibase-repo-tests is now voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62789 [08:03:03] New patchset: Nikerabbit; "Add .jshintrc" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62790 [08:03:36] New review: Hashar; "I have made it non voting with https://gerrit.wikimedia.org/r/#/c/62789/" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62666 [08:04:04] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62789 [08:04:37] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62666 [08:07:42] New patchset: Nikerabbit; "Add .jshintrc and fix warnings" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62790 [08:18:25] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62790 [08:21:32] New review: Nikerabbit; "Yay for progress." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62784 [08:24:10] New review: Nikerabbit; "I would even use https" [mediawiki/extensions/TwoFactorAuthentication] (master) C: 1; - https://gerrit.wikimedia.org/r/62783 [08:26:24] Change merged: jenkins-bot; [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/62780 [08:31:15] New patchset: Ori.livneh; "Prevent defaults from clobbering event properties" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/62793 [08:35:05] New review: Fomafix; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56762 [08:51:43] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/62793 [09:04:13] New patchset: Ori.livneh; "Prevent defaults from clobbering event properties" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/62793 [09:10:12] New review: Nikerabbit; "Could you (or someone) send a short note to wikitech to raise awareness about this change? I bet man..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62753 [09:19:42] New review: Nemo bis; "Thanks, I've mentioned it in New review: Nikerabbit; "Looks good. Some minor notes to fix and think." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62149 [09:30:36] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [09:30:49] New patchset: Nikerabbit; "Make the main page look reasonable without JS" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62594 [09:32:49] hexmode, see my last email: Define what backport+ actually means, and I proposed that it means "has been backported". [09:37:07] hexmode, There's two ways: define "backport+" as "yes, permission granted to backport" keep the bug report open, and close the report as RESOLVED FIXED once the backport has been committed. Other way: Close bug report as RESOLVED FIXED once fix is committed to git master, and define "backport+" as "patch has been backported". Up to you to define the workflow, but that's why I asked for documentation about it. [09:53:46] New review: Parent5446; "Two quick questions. Otherwise it looks good." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62784 [10:13:26] New patchset: Raimond Spekking; "Add $namespaceGenderAliases for 'eo'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62795 [10:17:58] New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [10:24:30] New review: Pastakhov; "Allow assignment for array variables ( $foo[5]=5; $foo[]=5 )" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [10:30:46] New patchset: Njw; "Add subtle stripes outside the content to draw the eye to the content" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62797 [10:45:55] New patchset: FastLizard4; "Update URLs to point to the extension's proper location" [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/62783 [10:46:47] New review: FastLizard4; "Patch set 2 further updates MediaWiki Wiki URLs to use HTTPS, per Nikerabbit's suggestion." [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/62783 [11:14:51] Change merged: Parent5446; [mediawiki/extensions/TwoFactorAuthentication] (master) - https://gerrit.wikimedia.org/r/62783 [12:02:55] New review: Siebrand; "Cannot merge and there's an open L10n related question by Niklas." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [12:05:23] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62795 [12:06:04] New patchset: Nikerabbit; "Use direction of user language to fix placeholder for search" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62597 [12:06:20] New patchset: Nikerabbit; "Refactor header()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62592 [12:06:23] New patchset: Nikerabbit; "Make the logo flip on RTL" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62595 [12:11:11] New review: Yaron Koren; "Hi Joel," [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62774 [12:17:01] New review: Nikerabbit; "Regarding image pipelines: No there is nothing written down as far as I know. I encourage people to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [12:24:06] New review: Nikerabbit; "Some more tips and comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [12:26:24] New review: Nikerabbit; "Is there no correct translation available? Then the fix would be much easier, just add that as the f..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62230 [12:30:23] New review: Nikerabbit; "So which approach do we take?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62337 [12:32:07] New patchset: Matthias Mullie; "(bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62807 [12:35:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62187 [12:35:09] New review: Nikerabbit; "I am having doubts whether this is the correct layer to do this." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62227 [12:44:19] Change abandoned: Odder; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62230 [12:46:40] New patchset: Dan-nl; "initial draft addressing feedback given in gerrit https://gerrit.wikimedia.org/r/#/c/59405/1" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [12:54:03] New review: Peachey88; "A more descriptive commit summary wouldn't go astray either." [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [12:54:29] New patchset: Matthias Mullie; "(bug 35288) the message articlefeedbackv5-disable-flyover-help-location is poorly placed and not needed anyway" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62808 [13:17:03] New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62810 [13:23:00] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/62810 [13:23:19] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62810 [13:26:20] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62343 [13:30:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61404 [13:33:04] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [13:36:32] New patchset: Amire80; "Rename this.$group to this.$trigger for clarity" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62344 [13:41:35] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62344 [13:47:20] New review: Siebrand; "Merge per Raimond." [mediawiki/extensions/AccountAudit] (master); V: 2 - https://gerrit.wikimedia.org/r/61766 [13:47:20] Change merged: Siebrand; [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61766 [13:57:41] New review: Daniel Kinzler; "RecentChange::doMarkPatrolled( User $user, $auto = false )" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62785 [14:12:07] New patchset: Raimond Spekking; "Add $namespaceGenderAliases for 'eo'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62795 [14:17:52] New patchset: Nikerabbit; "Avoid homepage to become too wide on big screens" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62813 [14:19:04] New patchset: Zfilipin; "Feature: PDF, Scenario: Click on Download as PDF link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62223 [14:29:00] zeljkof: Who's Antoine's fallback for beta labs? [14:29:42] zeljkof: we identified a caching issue that we'd like to work around before an office hours in 2.5 hours. It requires some manual help. [14:30:00] siebrand: I do not think there is one :) [14:30:22] zeljkof: okay... [14:30:27] siebrand: chris might know, he should be here soon [14:51:45] <^demon> siebrand: Seen today's xkcd? [14:52:10] ^demon: Saw a link on facebook [14:52:27] <^demon> I saw unicode problems and thought of you :) [15:01:17] New patchset: Anomie; "(bug 48071) API: Fix setnotificationtimestamp with no pages given" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62229 [15:09:34] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [15:15:02] New patchset: Jqnatividad; "Incorporated Yaron's suggestion to use a separate parameter to capture MongoDB Find Query. The new parm, is appropriately named "find query". Also changed str_replace with str_ireplace for matching AND & LIKE in parsing MongoDB where." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [15:17:19] New review: Cmcmahon; "after a conversation with Željko, merging in the interest of green builds" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62633 [15:17:20] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62633 [15:24:37] Yippie, build fixed! [15:24:38] Project browsertests-en.wikipedia.org-linux-firefox build #46: FIXED in 1 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/46/ [15:35:34] Yippie, build fixed! [15:35:35] Project browsertests-sandbox.translatewiki.net-linux-chrome build #28: FIXED in 1 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/28/ [15:39:25] Change merged: Daniel Werner; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62588 [15:43:26] Change merged: Daniel Werner; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62589 [15:43:43] Change merged: Daniel Werner; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62596 [15:53:04] New patchset: Adamw; "Fix broken links to banner" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62822 [16:03:44] New review: Krinkle; "This seems wrong in principle. See bug report for details." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62785 [16:06:22] New patchset: Krinkle; "Add setting wgLogAutopatrol to toggle logging of autopatrol actions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [16:09:54] Change abandoned: Alex Monk; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62126 [16:09:58] Change abandoned: Alex Monk; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62127 [16:10:55] New patchset: Cmcmahon; "accommodate slight change to behavior of Next button" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62824 [16:18:07] New patchset: Siebrand; "Make jslint for voting for MobileFrontend" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62825 [16:19:19] Yippie, build fixed! [16:19:19] Project browsertests-sandbox.translatewiki.net-linux-firefox build #53: FIXED in 1 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/53/ [16:23:58] New patchset: IAlex; "Use Html::element() to build the links used in 'alphaindexline' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62827 [16:24:25] New review: Yaron Koren; "Looks good! I want to approve this, but I can't - I assume due to some Git issues of one kind or ano..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:25:52] New review: Demon; "The patch is fine, it just has a parent dependency that needs to be submitted first." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:28:26] New review: Yaron Koren; "So I'm being forced to approve code I don't like? :) Alright, I hope this works..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:29:06] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62774 [16:29:36] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:29:45] New review: Demon; "If the two changes are indeed separate, then they shouldn't depend on one another (and this should b..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:29:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=37969 This has got to be a dupe... [16:31:46] New patchset: Yurik; "Updating Zero to the master branch" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62830 [16:32:20] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62830 [16:32:21] New review: Yaron Koren; "No, they weren't separate - one was a patch, and the second was a patch to that patch. Anyway, they'..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [16:32:52] New patchset: Yurik; "Updating Zero to the master branch" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62831 [16:33:06] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62831 [16:33:20] yurik: MaxSem why are you bothering to update Zero in wmf2? [16:33:26] It's going to be gone from production in 90 minutes [16:33:36] Reedy, because its live [16:33:51] we will scap in like 5 minutes:) [16:34:11] And by the time scap finishes there'll be 60 minutes or so [16:36:10] Reedy, who cares if things will be broken for 1 hour? [16:36:30] twitch... [16:36:49] "broken" [16:36:58] What's going to break from not updating a MW extension? [16:38:34] <^demon> Things would be faster with less extensions ;-) [16:38:48] <^demon> Except Scribunto, that actually makes things faster. [16:39:03] I've disabled a handful on loginwiki so far [16:39:07] Numerous more I'll probably turn off [16:39:33] New review: Matmarex; "Thanks, Niklas, fixed&replied." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [16:39:37] <^demon> We need FlaggedRevs on loginwiki. [16:39:42] New patchset: Matmarex; "Kill the MediaWiki_I18N class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [16:40:05] Krinkle, Reedy: It's been three months since https://gerrit.wikimedia.org/r/#/c/47307/2 , can it go ahead now? [16:40:11] <^demon> I'm obviously speaking the crazy...lunch time. [16:40:22] Krenair: I've no idea. Did anyone announce it? [16:40:47] There's also loginwiki and wikimania2014 which should be added to the change [16:40:47] Krenair: I was thinking about that earlier today with regards to login.wikimedia.org [16:40:49] Though, a months notice would more than suffice [16:41:14] Krenair: My proposal is to amend that gerrit change so that it is just a refactor with no effective change [16:41:26] Krenair: In other words, document all the "wrong" ones and put them in there. [16:41:27] I haven't seen it (the announce) [16:41:33] Krenair: And have the default be the "right" [16:41:45] greg-g: It might actually predate you slightly [16:41:49] Krenair: For the wikis recently created we can make the right straight away [16:41:55] greg-g, it should've been sent before you joined I think... [16:41:58] Krenair: Then we can phase out the others much more easily [16:42:00] Reedy: Krenair touche [16:42:06] Still! ;) [16:42:50] Reedy: Can you (with regards to https://gerrit.wikimedia.org/r/#/c/47307) generate a list of all the ones that are different? e.g. export the variable for each wiki on master, and for each wiki after this change. Then put the diff in the array. [16:43:08] Krinkle: Yes, it makes sense to go ahead with the new wikis regardless [16:43:35] We only need to worry about the older ones which have already started getting used [16:43:47] Krenair: However, I'd like to get that done without "fixing" them for the wikis (since it is going to be forgotten again for the next wiki) and instead make that the default. [16:43:49] We're not changing the default, so the only wikis that change are the ones with entries added/changed... [16:44:26] New review: Matmarex; "Fixed CologneBlue and tested now, doesn't seem to break on any core skins. Might need release notes,..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [16:45:34] Reedy: Right now it does #$lang.$site by default for IRC, which is wrong due to everything else that that old pattern has broken (meta.wikipedia, mediawiki.wikipedia etc.). The default should be the hostname without .org. That change you proposed was already going to do that. I'd recommend making it less of a breaking change by first hardcoding the exceptions. [16:46:09] Unfortunately I can't actually find any announcement email [16:46:46] * Krenair will be back later [16:47:19] Oh, "we're not changing the default" was not a reply to me [16:52:01] You're invited! Wikimedia Office hours with the Language Engineering team in a few minutes in #wikimedia-office. [16:52:57] New review: Jqnatividad; "Sorry for the confusion. I realized after I ran git review that I should have done a fresh patch." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62819 [17:00:28] New review: Cscott; "I'm still getting some failures in html2wt in parsoid. Let me address those here before this gets m..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62121 [17:00:48] New review: Matmarex; "PS3 adds release notes. Also rebase." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [17:02:51] New patchset: Reedy; "Add EducationProgram to createExtensionTables" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62832 [17:03:15] New patchset: Matmarex; "Kill the MediaWiki_I18N class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [17:04:17] New patchset: Yaron Koren; "Some code and comment improvements for the new 'find query' MongoDB option" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62833 [17:06:15] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62833 [17:10:33] AaronSchulz: I think someone has broken mwscript "recently" [17:10:44] addwiki requires --wiki=aawiki again [17:10:55] and [17:10:55] reedy@fenari:/home/wikipedia/common$ mwscript extensions/WikimediaMaintenance/createExtensionTables.php --wiki=mediawikiwiki educationprogram [17:10:55] NULL [17:11:23] $extension = $this->getArg(); [17:11:23] var_dump( $extension ); die(); [17:11:33] mangled parameters seem mangled [17:11:56] blame Tim? I don't know :) [17:12:06] I haven't touched that code in a while [17:12:21] I should probably log a bug then [17:12:55] Noting Tim hasn't touched it in quite a while https://gerrit.wikimedia.org/r/gitweb?p=operations/mediawiki-config.git;a=history;f=multiversion;hb=HEAD [17:16:14] New review: Jdlrobson; "Hashar if you can confirm this works please merge :)" [integration/zuul-config] (master) C: 1; - https://gerrit.wikimedia.org/r/62825 [17:20:58] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [17:23:13] New patchset: Ori.livneh; "Replace 'url_quote' with 'uri'" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [17:24:41] New patchset: Cmcmahon; "this should make it possible to set a cookie in IE" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62838 [17:25:34] New review: Krinkle; "Needs release notes." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60259 [17:26:04] hi Aayush251 [17:26:10] Where is this text defined? https://login.wikimedia.org/w/index.php?title=Main_Page&oldid=1 [17:26:55] hmm, it's probably in the new-wiki-creation script somewhere in the wikimedia config [17:27:08] it's in addWiki.php, yes [17:27:22] I added Wikidata and Commons to the project list last night [17:27:28] Oh. Okay. [17:27:38] * Krenair was going to go and do that [17:28:19] Project _debug-browsertests-template build #124: FAILURE in 52 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/124/ [17:31:09] Change abandoned: Cmcmahon; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62838 [17:35:53] https://login.wikimedia.org/wiki/Special:ListUsers [17:35:58] Only 20 accounts!? [17:36:08] what is over there anyways? [17:36:31] New patchset: Umherirrender; "Add content model to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [17:36:36] It's going to be the "central wiki" for central auth replacement and oauth/openid type stuffs [17:36:59] ohh [17:37:53] do we need to actively sign up over ther eor how does it work? [17:38:13] Just sign in with your CA account [17:38:24] will autocreate and attach it [17:39:09] did [17:39:39] User ID: 22 whee [17:40:01] 20 :) [17:40:37] hm, "Your account is active on 343 project sites. Unconfirmed accounts with your name remain on 3 projects." [17:45:10] bug 48264 must be a recent regression.. [17:45:37] welcome... to centralauth [17:45:56] :D [17:46:12] Though, it would be amusing if it was broken since it's inception and its your fault ;) [17:46:49] centralauth inception.... omg [17:48:07] $userPageName = Title::makeTitleSafe( NS_USER, $this->mUserName ); [17:48:07] return Xml::element( 'a', [17:48:07] array( [17:48:07] 'href' => $userPageName->getFullUrl(), [17:48:07] 'title' => $this->msg( 'centralauth-foreign-link', [17:48:08] $this->mUserName, [17:48:10] $hostname )->text(), [17:48:12] ), [17:48:15] $hostname ); [17:48:19] Title is always local [17:49:15] why not Linker::link [17:49:48] * aude can finally recover my test2 account :D [17:50:04] long lost password and no email set [17:52:05] New review: Siebrand; "(1 comment)" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [17:52:25] New review: Siebrand; "Reviewed PS2." [mediawiki/extensions/GWToolset] (master) C: -1; - https://gerrit.wikimedia.org/r/59405 [17:54:37] New patchset: Reedy; "Site links on Special:MergeAccount all link to same domain" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62839 [17:55:09] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52337 [17:57:43] andre__: do you know who I might persuade to tackle https://bugzilla.wikimedia.org/show_bug.cgi?id=47837 ? it's not a very sexy fix, but it would be helpful to have. [17:58:46] pgehres: Didn't you fix a hard coded User: in CentralAuth? I can't see it in the git log... [17:59:10] Reedy: not sure I follow what you are asking [17:59:24] oh, Title(User ...) [17:59:31] New review: Matmarex; "Yes, I know it needs release notes, I said precisely that in the first comment here, also mentioning..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [17:59:34] I've just seen [17:59:34] $params['url'] = $wiki->getUrl( 'User:' . $user->getTitleKey() ); [17:59:43] And also 'User:' . $this->mUserName, [17:59:54] ugh, those are awful, that whole extension is awful [17:59:56] Which I just copy pasted for 62839 [18:01:23] Reedy: https://gerrit.wikimedia.org/r/#/c/52337/5/specials/SpecialMergeAccount.php,unified [18:01:37] line 466 [18:01:58] You caused the bug! :D [18:02:30] Yay! I am finally a fully fledged MW dev! [18:02:55] now I just need to bring down the cluster to get that merit badge [18:06:08] New patchset: Umherirrender; "Add content model to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [18:07:07] Reedy: wow, looking at the code it is painfully obvious what happened. [18:08:14] New review: Umherirrender; "Statement moved and release notes added" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [18:08:29] Reedy: https://gerrit.wikimedia.org/r/#/c/62736/1 microcommit [18:09:31] New patchset: Umherirrender; "Add content model to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [18:18:09] New patchset: Alex Monk; "Display "Printable version" links in toolbox on special pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62844 [18:18:19] [[Main Page]] //login.wikimedia.org/w/index.php?diff=6&oldid=5 * Reedy * (-250) lolnoincubator [18:18:22] Um, what's with the // ? [18:18:33] Aren't those supposed to be full, canonical URLs? [18:18:56] Yup [18:18:58] missing http [18:19:02] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62839 [18:19:27] Looks like it only affects loginwiki though [18:19:40] Yeah, it's a typo [18:29:47] New patchset: Cscott; "Add attributes to the Parsoid-only tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [18:33:15] New review: Cscott; "still some issues, hang on." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62121 [18:33:16] New patchset: Reedy; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62850 [18:33:49] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62850 [18:35:17] New patchset: Bsitu; "Fix notificaiton listing query." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62851 [18:40:34] New patchset: Alex Monk; "Fix notificaiton listing query." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62851 [18:41:46] New patchset: Alex Monk; "Fix notification listing query." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62851 [18:46:47] New patchset: Alex Monk; "Fix double escaping on protect-othertime message" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62853 [19:00:16] New review: Umherirrender; "This will fail, if the wiki does not have subpages in user namespace." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62146 [19:01:38] New patchset: Alex Monk; "Disable useless inputs on protection form" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62854 [19:01:54] New patchset: Alex Monk; "Fix over-escaping on protect-othertime message" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62853 [19:01:58] New patchset: Alex Monk; "Disable useless inputs on protection form" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62854 [19:10:45] New patchset: Reedy; "Add index to securepoll_options.op_election" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/62857 [19:22:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62177 [19:25:35] ^demon: https://gerrit.wikimedia.org/r/#/c/62736/ tiny commit [19:26:19] New patchset: Reedy; "Make voterList output at least some text" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/62860 [19:32:40] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62736 [19:45:19] New review: GWicke; "I have not done the browser testing to warrant a +2, so only a +1 from me. Looks sane." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60123 [19:48:07] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59991 [19:56:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/50774 [20:00:38] New review: Aaron Schulz; "Sorry, I meant "maybe non-sysops should *only*"." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57286 [20:04:01] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62822 [20:07:52] There's a discussion of Notifications (Echo) in #wikimedia-office right now [20:11:08] New review: Wizardist; ">> This will fail, if the wiki does not have subpages in user namespace." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62146 [20:11:18] * bawolff didnt even realize there was an offoce hours today [20:12:11] New patchset: Mwalker; "CentralNotice Campaign Log Pager Bugfix" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62866 [20:12:33] New review: Mwalker; "As discussed in the bug" [mediawiki/extensions/CentralNotice] (master) C: 2; - https://gerrit.wikimedia.org/r/62866 [20:12:33] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62866 [20:15:06] New patchset: Mwalker; "Update CentralNotice to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62868 [20:17:52] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #45: FAILURE in 3 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/45/ [20:18:10] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62868 [20:18:15] Project browsertests-sandbox.translatewiki.net-linux-chrome build #29: FAILURE in 3 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/29/ [20:22:39] New patchset: Hashar; "mwext-TwnMainPage-jslint is now voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62904 [20:24:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62019 [20:25:56] YuviPanda: I cannot recall -- are you involved in uncyclopedia's operations at all? [20:29:42] YuviPanda: ne'r mind! :) [20:32:00] New review: Wizardist; "Nikerabbit, should we shape the definition of a dummy language code? Or frankly speaking, will be an..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62227 [20:34:00] New patchset: Jqnatividad; "Corrected connectstring concatenation. Removed debugging message. Tweaked typo in comments." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62916 [20:36:12] New review: Ori.livneh; "This appears to work, but because improper escaping is a potential attack vector, I need to verify i..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62837 [20:47:58] ^demon or Krinkle, FYI 16 minute delay before jenkins-bot started gate-and-submit job for https://gerrit.wikimedia.org/r/#/c/61630/ . [20:48:56] spagewmf: https://integration.wikimedia.org/zuul/ [20:49:32] * ^demon knows nothing about zuul lag :( [20:49:41] spagewmf: It is just busy, nothing you cando. [20:49:52] first in first out [20:50:40] I'm working on improving things, but the way our Zuul/Jenkins is set up right now it doesn't perform very well [20:51:03] I've got various ideas for improvement that I'm going to discuss with hashar next monday. [20:51:08] New patchset: Wizardist; "(Bug 46422) convertPlural makes using 0= and 1= rules impossible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62149 [20:51:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61630 [20:52:56] New review: Yaron Koren; "Oops - sorry about throwing my debug statement in there. :)" [mediawiki/extensions/ExternalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62916 [20:52:57] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/62916 [20:53:49] Krinkle I appreciate it! That status page had a few jobs in it while nothing appeared in gerrit. Is their some "Queue length" or other indicator at which we know that jenkins-bot isn't going to respond on gerrit so we don't pester y'all? [20:55:16] spagewmf: Yes, it is on the page I linked [20:55:37] https://integration.wikimedia.org/zuul/ shows everything that Zuul has submitted to Jenkins [20:55:42] and thenn there is a number on top [20:55:45] "Queue length" [20:55:50] which are the number of events not yet processed [20:56:07] if that is 0 and it isn't on the page below, it means it isn't going to happen. [20:56:24] if it isn't on the page below but the number is non-zero, it is likely in the queue still. [20:58:59] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62904 [21:04:19] New patchset: MarkTraceur; "Update UploadWizard to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62917 [21:06:42] !log Running small maintenance script foreachwiki to gather data about odd wgRC2UDPPrefix values (bug 28276) [21:06:47] * Krinkle in operations [21:08:14] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62917 [21:14:30] New patchset: Cscott; "Add attributes to the Parsoid-only tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [21:26:37] New patchset: Bsitu; "(bug 44247) Do not write to storage if read-only mode is on" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62922 [21:29:30] Krinkle, I wasn't sure where to put your Zuul/Jenkins information, I added it to https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Troubleshooting [21:31:05] I mean https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Troubleshooting_2, "Your change isn't merged" [21:34:24] New patchset: Reedy; "Add EducationProgram to createExtensionTables" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62832 [21:34:45] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62832 [21:39:20] New patchset: Reedy; "Allow selection of MySQLi database type during installation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62174 [21:39:42] New patchset: Aaron Schulz; "Cleaned up the UI for the redirect login." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [21:40:53] New review: Aaron Schulz; "The hidden field feels a bit of a hack, but avoids DOM flicker." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62925 [21:47:51] New review: Brian Wolff; "When testing with the leaders of soviet union timeline from the extension description page, resulted..." [mediawiki/extensions/timeline] (master) C: -1; - https://gerrit.wikimedia.org/r/47336 [21:49:51] New review: Mattflaschen; "Works, comment update looks fine." [mediawiki/extensions/EventLogging] (master) C: 1; - https://gerrit.wikimedia.org/r/62793 [22:03:47] aude: *bonk* [22:04:04] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=44874 is sad for now having the change-id of the WIP patch you said you have :) [22:04:11] not having* [22:05:42] New review: Swalling; "This is in line with 54326 and the associated rationale." [mediawiki/extensions/EducationProgram] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/54323 [22:10:52] New patchset: MarkTraceur; "Fix concurrent upload preference" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/62930 [22:12:31] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/62930 [22:14:47] New patchset: MarkTraceur; "Update UploadWizard to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62931 [22:15:23] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/54323 [22:15:29] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62931 [22:16:27] New review: Spage; "At first I confused this userId with mw.user.id(), I guess we're stuck with the latter." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/62788 [22:17:50] New review: Siebrand; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/62925 [22:18:12] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62788 [22:20:54] New review: Mattflaschen; "I partially agree with Matmarex, and I think Swalling. We shouldn't create an artificial consistenc..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54326 [22:22:24] New review: Aaron Schulz; "@Krinkle: nope, I don't that was part of what is needed AFAIK. Ideally, I'd like to keep as much stu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [22:22:42] New review: Aaron Schulz; "*I don't think that" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [22:25:57] New review: Mattflaschen; "Also, that link is specifically about the "The possessive pronoun". It does not claim that You is b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54326 [22:28:50] New patchset: Tim Starling; "Remove hphpc support and deprecate related functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62784 [22:29:50] 'it doesn't seem ridiculously inefficient at first glance', heh [22:30:05] New review: Tim Starling; "PS2: release notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62784 [22:31:50] yeah, as opposed to hphpc which *was* ridiculously inefficient [22:33:09] New review: Cscott; "https://gerrit.wikimedia.org/r/62918 will be the patch to update parsoid to use this set of parserTe..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [22:43:01] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62406 [22:43:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62784 [22:48:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62421 [22:56:30] New patchset: Adamw; "(FR #908) Brazil requires extra personal infos" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/62933 [23:06:45] Project browsertests-en.wikipedia.org-linux-chrome build #46: FAILURE in 4 min 42 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/46/ [23:06:46] Project browsertests-en.wikipedia.org-linux-firefox build #48: FAILURE in 0.38 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/48/ [23:09:33] Yippie, build fixed! [23:09:34] Project browsertests-sandbox.translatewiki.net-linux-chrome build #30: FIXED in 2 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/30/ [23:17:47] New patchset: Brian Wolff; "Add $wgShowDuplicatesOnForeignFiles to control dupe section of img" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62934 [23:18:43] Change abandoned: Brian Wolff; "abandoned in favour of gerrit change 62934 which does the "alternative approach" instead" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20659