[00:03:23] New patchset: Adamw; "stopgap so allocations doesn't melt down when banner logs are missing" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62462 [00:06:57] New patchset: Adamw; "handle the empty case better" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62547 [00:07:23] New patchset: Aaron Schulz; "Added a script to nuke deleted files from storage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [00:08:40] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62462 [00:09:20] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62547 [00:10:02] New patchset: Adamw; "amazon-recurring and value change form support" [mediawiki/core] (fundraising/1.20) - https://gerrit.wikimedia.org/r/62550 [00:10:57] New patchset: GWicke; "Add test for comment-only line followed by a template transclusion" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62551 [00:16:12] New patchset: MarkTraceur; "Pare the parsoid parse tool tests" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62552 [00:16:53] Change merged: MarkTraceur; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62552 [00:17:48] New patchset: Mwalker; "Translation Message Updates for CN" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62517 [00:23:45] New review: Parent5446; "Two minor things. Otherwise looks good." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62549 [00:36:39] New patchset: Mwalker; "Make Dialog Boxes Wider for TextBox" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62553 [00:38:08] New review: Reedy; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [00:39:15] New patchset: Kaldari; "Adding check to make sure rev isn't null" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62554 [00:41:31] New review: Reedy; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [00:44:15] New review: Reedy; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [00:49:05] New patchset: Mwjames; "Extend SMW\SpecialsTest" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [00:53:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62554 [00:54:05] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/36391 [00:54:21] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496 [00:59:34] New patchset: Kaldari; "Removing exception in case rev is null" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62556 [01:06:30] New patchset: Mwjames; "SMW\Serializer display appropriate output value for formatted printout" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62557 [01:06:50] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62556 [01:08:31] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62004 [01:08:34] New patchset: Bsitu; "Adding check to make sure rev isn't null" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62558 [01:11:51] New patchset: Bsitu; "Removing exception in case rev is null" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62559 [01:12:10] New patchset: Reedy; "Update WikimediaMaintenance to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62560 [01:13:31] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62558 [01:15:24] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62559 [01:16:00] New patchset: Mwjames; "Expose smw.namespace settings (smw.namespace)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62561 [01:24:49] New patchset: Adamw; "amazon-recurring and value change form support" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/62562 [01:25:25] Change abandoned: Adamw; "now https://gerrit.wikimedia.org/r/#/c/62562" [mediawiki/core] (fundraising/1.20) - https://gerrit.wikimedia.org/r/62550 [01:26:31] New patchset: Reedy; "Update WikimediaMaintenance to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62560 [01:26:42] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62560 [01:27:06] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62517 [01:27:08] New patchset: Krinkle; "mw-install-sqlite: Import logic from ant build task" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62563 [01:27:46] New review: Adamw; "Equally sketchy, but different :)" [mediawiki/extensions/CentralNotice] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62553 [01:27:46] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62553 [01:32:26] New patchset: Reedy; "Rename core tables too" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/53919 [01:32:34] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/53919 [01:34:38] New patchset: Mwjames; "Fetch namespace settings via JS (smw.namespace)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62561 [01:34:38] New patchset: Mwjames; "Support async loading of content (smw.async)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62564 [01:36:20] New patchset: Krinkle; "qunit: Use jQuery.getScript instead of document.write" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62468 [01:39:17] New review: Krinkle; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62564 [01:41:08] New patchset: Spage; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62542 [01:45:01] New patchset: Spage; "Position the "Refresh" link over the image" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62191 [01:46:45] New review: Spage; "PS2 doesn't break the new Create account form, so I think this is safe to deploy in advance of impro..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62191 [01:50:23] mwalker|away: Did you introduce the "passes +" construction in smw tests? [01:50:27] Where did you get that from? [01:52:02] New review: Krinkle; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/62564 [01:53:15] New review: Swalling; ""Steven argues that a horizontal jump is better, and that it's worth it to more closely associate it..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62191 [01:53:35] New patchset: Krinkle; "mw-install-sqlite: Import logic from ant build task" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62563 [01:54:03] New review: Krinkle; "Tested at https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/3216/console." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/62563 [01:54:03] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62563 [01:56:10] RoanKattouw: Can you merge https://gerrit.wikimedia.org/r/#/c/62468/ ? [01:56:46] Krinkle: Done [01:57:12] Thx [02:00:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62468 [02:01:51] Reedy, did you guys figure out that wikimania2014 api issue? [02:02:03] Nope [02:02:33] Needs someone with root to be able to look at the logs [02:04:48] New patchset: Mwjames; "Add SMW\StatisticsAggregator class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [02:06:50] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [02:09:19] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [02:11:47] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [02:13:52] New patchset: Mwjames; "SMW\Subobject clean-up constructor, eliminate ContextSource dependency" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [03:11:47] New review: Krinkle; "See inline comments for code issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59373 [03:17:37] New review: Krinkle; "Pointed out a few other easy-to-fix code problems. Having it in a gerrit diff makes it easier to rev..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/62518 [03:20:15] New patchset: Krinkle; "OutputPage: Use If-None-Match header to determine 304 Not Modified" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:20:33] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:20:48] New review: Krinkle; " Fixed conditional for isETagWeakMatchAllowed for origin page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:21:02] New review: Krinkle; " Give the functions more accurate names. Check Last-Modified if" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:21:15] New review: Krinkle; " Handle Etag not modified without If-Modified-Since header" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:21:36] New review: Krinkle; "Removed patch set iteration/discussion from the commit message." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [03:23:53] New patchset: Krinkle; "SkinOffline: Add rtl/ltr classes to body" [mediawiki/extensions/DumpHTML] (master) - https://gerrit.wikimedia.org/r/60194 [03:24:08] New patchset: Krinkle; "SkinOffline: Add rtl/ltr classes to body" [mediawiki/extensions/DumpHTML] (master) - https://gerrit.wikimedia.org/r/60194 [03:25:46] New patchset: Krinkle; "api: Trim leading/trailing spaces from comments" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [03:25:56] New review: Krinkle; "Removed patch set iteration/discussion from the commit message." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [03:26:53] New patchset: Krinkle; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [03:27:03] New patchset: Krinkle; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [03:30:35] New review: Krinkle; " Fix linting and NaN problem" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [03:30:49] New patchset: Krinkle; "jquery.tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [03:31:01] New patchset: Krinkle; "jquery.tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [03:31:50] New patchset: Krinkle; "Claim anon feedback after sign up" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/33383 [03:32:22] New review: Krinkle; " bsitu's feedback & update to new AFTv5 codebase" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/33383 [03:32:38] New patchset: Krinkle; "Don't let AFT set unsupported groups" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/42537 [03:33:27] New patchset: Krinkle; "Check protection status of titles in details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/56371 [03:34:15] New review: Krinkle; "Removed revision summaries from the commit message. Also use git commits or gerrit change ids instea..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/56371 [03:37:30] New patchset: Krinkle; "licenseInput: Handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [03:37:48] New review: Krinkle; " Note: I did not test this as I don't have the templates and stuff needed on my local wiki" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [03:38:25] New review: Krinkle; "I'd recommend grouping them instead of one api query per title in an $.each loop." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50755 [04:01:52] New review: MZMcBride; "Scary." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [04:07:41] New review: Karim.rayani; "Also, if I see the http://commons.wikimedia.org/wiki/Main_Page url today, the media file on which I ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62231 [04:08:10] New review: Parent5446; "Minor style issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60440 [04:29:12] New patchset: Adamw; "(bug 44327) Anonymous users have only session ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [04:33:01] New review: Adamw; "Improve on PS 1. Please reserve final merge judgement for E3 members, thanks!" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/53195 [04:34:59] New patchset: Yaron Koren; "Fix for '_str' index going away in SMW 1.9" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/62567 [04:36:27] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [04:36:57] New review: Parent5446; "Removing -2 since the patch no longer adds more cookies." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53195 [04:37:20] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/62567 [04:41:14] New review: Adamw; "(1 comment)" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/62094 [04:44:05] New patchset: Adamw; "(bug 44327) Anonymous users have only session ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [04:57:56] New review: Adamw; "This is blocked by bug 17168, unfortunately. Not to mention there is no UI to access the feature :)" [mediawiki/extensions/Collection] (master) - https://gerrit.wikimedia.org/r/44848 [05:00:05] New review: Adamw; ";) oh, and more importantly bug 46992" [mediawiki/extensions/Collection] (master) - https://gerrit.wikimedia.org/r/44848 [05:07:07] New patchset: Liangent; "Fix I25cf5a94: It should be @since 1.21 now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62568 [05:07:47] New review: Spage; "I tried this with the new- and old-look login and create account forms and it didn't break layout ev..." [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/62439 [05:10:47] New patchset: Liangent; "Fix I25cf5a94: It should be @since 1.21 now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62568 [05:27:21] New review: Spage; "Works for SimpleCaptcha and FancyCaptcha, I didn't try it for Math and Questy. Note the createAccou..." [mediawiki/extensions/ConfirmEdit] (master) C: 2; - https://gerrit.wikimedia.org/r/62128 [05:27:32] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62128 [05:53:26] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:58:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62568 [05:59:29] New patchset: IAlex; "Add note that wgActiveUserDays affects the NUMBEROFACTIVEUSERS magic word." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61951 [06:04:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61951 [06:18:58] New patchset: IAlex; "Use __METHOD__ for default $fname params to database functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62433 [06:21:46] morning [06:23:03] I'd appreciate review on https://gerrit.wikimedia.org/r/#/c/62446/ [06:23:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62433 [06:27:13] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:28:45] New patchset: IAlex; "Update docs/skin.txt" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62201 [06:32:29] New patchset: Spage; "Move Create account messages and links here." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/62570 [06:33:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62201 [06:40:48] New patchset: Ori.livneh; "Move Create account messages and links here." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/62570 [06:41:23] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/62570 [06:44:26] New review: Mattflaschen; "I9e33c21a does not match anything. Is it a typo?" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/62570 [06:46:46] ori-l: thanks [07:01:17] New review: Amire80; "The code looks good. The Cite functionality works well by itself. Didn't test with VE yet." [mediawiki/extensions/Cite] (master) C: 1; - https://gerrit.wikimedia.org/r/62540 [07:16:47] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:21:50] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:25:23] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:30:19] New patchset: Ganeshaditya1; "Bug: 48197 removed the font weight from error box" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [07:31:23] New patchset: Ganeshaditya1; "Bug: 48197 removed the font weight from error box" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [07:33:16] New patchset: Netbrain; "added proper progressbar" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62572 [07:37:03] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/62452 [07:37:26] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62452 [07:39:15] New review: Mattflaschen; "This is up on http://toro.wmflabs.org/ for testing. It should include everything except the logging..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:40:49] New patchset: Netbrain; "Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Spreadsheet" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62573 [07:40:51] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62426 [07:41:39] Change abandoned: Netbrain; "need merge" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62572 [07:42:39] Change restored: Netbrain; "(no reason)" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62572 [07:43:50] Change abandoned: Netbrain; "(no reason)" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62573 [07:44:02] Change abandoned: Netbrain; "(no reason)" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62572 [07:47:20] New patchset: Netbrain; "added proper progressbar" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62574 [07:47:35] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/62574 [07:51:07] New review: Mattflaschen; "Don't put the bug id in the header, just in the footer." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62571 [07:58:45] New review: Ganeshaditya1; "You know what matt, that works out at two levels. I never realized that having an additional div the..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [08:00:23] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [08:04:11] New review: Mattflaschen; "Assuming Matmarex's -1 from patch set 2 still stands. Correct me if I'm wrong." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/48252 [08:10:46] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [08:12:53] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [08:15:38] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [08:18:36] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [08:46:50] New patchset: Amire80; "Force anonymous mode also in when the ULS is not shown in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62577 [08:50:59] New patchset: Amire80; "Force anonymous mode also in when the ULS is not shown in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62577 [08:57:12] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62577 [09:00:29] hashar: Good morning! [09:00:40] As promised yesterday, I'm coming back to you because of the gerrit-plugin-* Jenkins problems. [09:01:20] New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62578 [09:04:47] hashar: wtf https://gerrit.wikimedia.org/r/#/c/62578/ ? [09:05:22] ] Undefined index: wgStyleSheetPath [09:05:23] nice [09:06:03] the first commit in that branch https://gerrit.wikimedia.org/r/#/c/61410/ [09:06:12] the parser tests were broken too [09:06:15] https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-parser/6250/console [09:06:29] seems nobody bother about the tests passing on wmf branches :/ [09:06:36] Nikerabbit: so I guess go ahead and self merge. [09:06:40] hashar: ok [09:06:44] qchris: yup [09:06:59] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62578 [09:07:12] hashar: Are you busy right now, or would it work to discuss the problems now? [09:07:30] qchris: I am always busy. [09:07:34] :-) [09:07:39] so either I look at it this morning [09:07:43] or it will never get done [09:08:00] * qchris grabs hashar so he does not get to do other things :-) [09:08:14] are all gerrit-plugin-* projects broken? [09:08:21] I.E you can not save them? [09:08:34] https://integration.mediawiki.org/ci/view/Java/job/gerrit-plugin-reviewnotes/109/console [09:08:47] We can safe, but Jenkins refuses to properly build them [09:09:07] Jenkins failing with "Processing failed due to a bug in the code. Please report this to jenkinsci-users@googlegroups.com" [09:09:07] hmm [09:09:20] can't we rewrite everything in python [09:09:26] :-)) [09:10:14] And it seems Jekins forgets about what it had built [09:10:17] Parsing POMs [09:10:17] Discovered a new module com.googlesource.gerrit.plugins.reviewnotes:reviewnotes reviewnotes [09:10:18] ERROR: Processing failed due to a bug in the code. Please report this to jenkinsci-users@googlegroups.com [09:10:26] and a stack trace hmm [09:11:10] I upgraded Jenkins maybe a plugin needs an update [09:11:14] I wondered that in "Manage Jenkins" there is a warning "You have data stored in an older format and/or unreadable data." [09:11:31] ah yeah that message, I have no idea what it is [09:11:57] oh yeah [09:12:17] so there is a ton of cannot resolve class "DownstreamBuildViewAction" which was used by a plugin I had to disable [09:12:52] I guess hitting the clean out button will reparse the build history and get rid of it [09:12:58] that will in turn possibly kill jenkins :/ [09:13:31] That sounds too scary. [09:13:50] well just accessing the page [09:13:57] that make Jenkins parse the full build history [09:14:01] so Jenkins is going to die :/ [09:14:11] (I saw that the maven plugin can be upgraded from 0.9.1 -> 0.10.0) [09:14:23] yeah that might be the root cause [09:14:45] but I guess that would need a restart of Jenkins [09:14:48] which is very scary nowadays [09:14:59] :-) [09:15:08] Ok, let's rewrite it in python then. [09:17:01] * hashar digs in jenkins log [09:19:21] The release notes 0.10.0 of the maven plugin do not mention our problems. [09:21:31] there is a few more stack traces in the logs :/ [09:22:06] Me just looks at them as well [09:22:10] http://www.wikidata.org/w/api.php?action=parse&format=json&text=%5B%5BSpecial%3AUserLogin%7CLog+in%5D%5D+to+select+a+different+language+for+menus%2E [09:22:14] what the heck does this mean? [09:22:19] {"servedby":"mw1122","error":{"code":"parseerror","info":"failed to deserialize"}} [09:23:46] filing a bug report [09:25:02] New patchset: Zfilipin; "Updated parallel_tests Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62580 [09:26:46] Change abandoned: Nischayn22; "Nobody wants this" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/57931 [09:28:07] action=parse apparently broken on wikidata: https://bugzilla.wikimedia.org/48201 [09:29:06] Looks like we just found another person with the https:// access issue in #mediawiki [09:30:34] qchris: still digging the web for the stracktrace found in the console [09:31:34] hashar: Hopefully you'll have more luck than I had. [09:33:57] qchris: how is the job created ? https://integration.mediawiki.org/ci/view/Java/job/gerrit-plugin-reviewnotes/ [09:34:09] qchris: is that something Jenkins creates by itself based on the gerrit-core-wmf one ? [09:34:24] like it detects the java code source as someplugins and it creates a job per module maybe? [09:34:45] the gerrit-plugin-reviewnotes is not listed as a downstream job of https://integration.mediawiki.org/ci/view/Java/job/gerrit-core-wmf/ [09:35:10] Not sure what you mean... We readded the plugins by hand now. [09:35:35] Typically gerrit-core-wmf would run [09:35:50] and upon success trigger the plugin jobs [09:36:05] That worked fine in the past until Jenkins dropped the plugins [09:36:45] The plugin jobs were started by post-build actions. [09:37:05] (But now for testing I started them by hand) [09:41:33] I now explicitly added the gerrit-plugin-reviewnotes as dependency of gerrit-core-wmf again. The output from running the job does not change. [09:42:52] ;-( [09:44:08] As the plugins existed before, got dropped by Jenkins [09:44:19] and we recreated them under the same name ... [09:44:41] Can it be that Jenkins still has some remnants about those plugins and gets confused? [09:45:10] I now tried adding a plugin under a new previously unused name, at it definitely looks better: [09:45:15] https://integration.mediawiki.org/ci/view/Java/job/gerrit-plugin-reviewnotes-fresh/1/console [09:45:51] ohh [09:45:52] So we just have to leave the other jobs around as zombies? [09:46:00] that is crazy [09:46:12] I triggered a build of gerrit-core-wmf [09:46:27] one possibility would be to delete the existing jobs build history [09:46:29] if you don't care about it [09:46:33] that might cause some random trouble [09:46:40] and I can manually clean the existing workspaces [09:47:07] I built gerrit-core-wmf several times in the last days, but although those jobs completed, it is still marked as if it had never been run before :-( [09:48:15] I do not care about existing build histories... So if you can remove them, it be ok for me. [09:48:41] You can happily throw gerrit-* away from my point of view [09:48:58] I have backups to bring it back [09:50:15] cleaning up gerrit-plugin-reviewnotes [09:54:27] retriggered it, same issue :/ [09:54:50] hashar: All of a sudden all jobs in Jenkin's �Build Executor Status� window turned �Dead !� [09:55:00] yeah noticed that [09:55:06] no idea what happened [09:55:09] ok. [09:55:14] I had to restart all the executor threads manually :( [09:55:32] Looks like Jenkins sucks at times. [09:55:53] Ok, then I'll try adding all gerrit jobs under new names. [09:56:06] Let's see if that solves the problem. [09:56:21] Can I leave the old gerrit jobs around for a while? [09:57:05] yeah sure [09:57:19] Ok. Thanks a lot for helping. [09:57:24] well [09:57:29] I would prefer to find the root cause [09:57:51] As long as we do not run out of fresh names ... :-) [09:58:27] I am looking at the diff between reviewnotes and reviewnotes-fresh [09:58:51] I was just a plain copy of the job [09:59:13] one of the diff is: [09:59:14] - sop [09:59:14] + [09:59:44] but then that is in the build.xml result [10:00:01] No idea ... really. [10:00:17] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [10:03:09] qchris: so if the -fresh works, I guess the old one can get deleted [10:03:18] then you can attempt renaming -fresh to the old name [10:03:49] hashar: Yes, I hope so too. [10:04:13] But after the renaming, everythings surely is broken again :-) [10:07:36] i hate it when I can't find what is wrong [10:09:36] hashar: Yes, me too. We do not know what kllied our jobs in first place. And we do not know why we cannot simply readd them. I can again happen tomorrow. Hopefully, this does not happen every month. [10:10:02] qchris: it is most definitely caused by the jenkins uipgrade [10:10:05] sorry about that :( [10:10:20] something must have changed in the way they find out the module dependencies in maven jobs [10:11:18] No problem. We have to keep upgrading. Luckily enough it just killed of the gerrit jobs. There are other parts of Jenkins where recreating would take more time. [10:12:24] The main problem for me is that Jenkins did not alert us about dropping the jobs. I only noticed as I was expecting failure emails but none arrived. [10:13:33] maybe it silently discard them after the upgrade [10:13:42] because they had some incorrect setting of some sort :/ [10:14:12] Yes, most likely. [10:14:51] If Jenkins only had a sed API. Then I'd s/silently/screamingly/ [10:19:53] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [10:26:14] New review: Matthias Mullie; "Both are related, yes." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60801 [10:35:34] hashar: I filed a bug for the purging issue on deployment-prep [10:37:04] Nikerabbit: have you tried purging server-side? [10:38:11] but perhaps you don't have access there [10:38:47] duno how it works [10:38:48] New review: Matthias Mullie; "(1 comment)" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/59418 [10:54:30] New patchset: Nikerabbit; "Apply dir and lang to the target language selector trigger" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62235 [11:00:16] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62235 [11:59:54] New patchset: Jeroen De Dauw; "Allow passing arguments to the PHPUnit runner" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62588 [11:59:54] New patchset: Jeroen De Dauw; "Added phpunit.xml file" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62589 [12:00:44] New review: Jeroen De Dauw; "This change depends on https://gerrit.wikimedia.org/r/#/c/62584/" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62589 [12:03:22] New patchset: Nikerabbit; "Fix another path after rename" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62590 [12:12:11] New review: Vedmaka Wakalaka; "The main problem of arraymaptemplate that we unable to set property in template text, because we don..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [12:13:28] New review: Vedmaka Wakalaka; "fixed links:" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [12:14:41] New review: Vedmaka Wakalaka; "ouch, parser ate them (" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [12:24:31] New patchset: Nikerabbit; "Localise language names" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62591 [12:24:31] New patchset: Nikerabbit; "Refactor header()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62592 [12:26:24] New patchset: Zfilipin; "Running Universal Language Selector Accept-Language feature in Chrome" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62593 [12:47:25] New patchset: Nikerabbit; "Make the main page look reasonable without JS" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62594 [12:47:25] New patchset: Nikerabbit; "Make the logo flip on RTL" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62595 [12:50:25] New patchset: Jeroen De Dauw; "Added testsuite so the relevant directory is included by default" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/62596 [12:56:55] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62402 [13:01:26] New review: Nikerabbit; "Where is the default value for this preference set?" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/61770 [13:27:45] New patchset: Nikerabbit; "Use direction of user language to fix placeholder for search" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62597 [13:29:43] New review: Yaron Koren; "Hi," [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [13:40:52] New patchset: MarkAHershberger; "(bug 47950) Fix IndexPager detection of "is first" state" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/62599 [13:43:20] New review: MarkAHershberger; "backport" [mediawiki/core] (REL1_21) C: 2; - https://gerrit.wikimedia.org/r/62599 [13:44:21] New patchset: Liangent; "Introduce a new function: LanguageConverter::findVariantTitle()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62600 [13:48:11] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/62599 [13:49:53] New review: Cmcmahon; "Today's "Media of the day" is a gif, so it won't have a Play control. I'm sure we'll start seeing <..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62231 [13:52:13] New patchset: Liangent; "Do not create babel category when a variant title exists." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/62601 [13:52:56] New review: Liangent; "See I189a8e5671a04d6d8cf5e3ec7563d888b70d3f96 for a usage example." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62600 [13:57:34] New patchset: Liangent; "Do not create babel category when a variant title exists." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/62601 [14:10:20] New patchset: Njw; "Allow custom banner image to be set using $wgEruditeBannerImg config option" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62604 [14:11:52] New patchset: MarkAHershberger; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/62605 [14:14:23] New review: Matmarex; "Sounds reasonable, thanks for the fix." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [14:16:53] New review: Matmarex; "> Without float:left some class="visualClear" can omitted. For example in includes/templates/Usercre..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [14:22:33] New review: Matmarex; "Yes, this is most likely still broken, as I doubt that someone other than me would bother to fix it ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/48252 [14:31:49] ^demon: got a minute for a strange problem with git-review? [14:32:05] New review: Tpt; "Thanks!" [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62440 [14:32:05] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/62440 [14:32:27] <^demon> DanielK_WMDE: It'll probably end in me giving you a workaround to just not use git-review, but sure :) [14:32:28] i just moved my stuff to a new laptop. now, git-review fails with an odd error: it tried to contact gerrit using poprt "none". [14:32:49] hm, that would be sad, git-review has been working nicely for me so far. [14:33:14] <^demon> Ok, pastebin the output from what you attempted, as well as the output from `git remote -v` [14:33:32] hm, that would be sad, git-review has bhttp://pastebin.com/k19r6cDqeen working nicely for me so far. [14:33:44] damn scroll wheel, sorry [14:33:47] http://pastebin.com/k19r6cDq [14:34:29] <^demon> What's the .gitreview file look like? [14:35:15] ^demon: http://pastebin.com/dFzgDAVv [14:35:19] the port is there [14:35:45] <^demon> Weird...so, I see two problems with the output from git-review. [14:35:48] <^demon> "ssh -x -p None gerrit query --format=JSON --current-patch-set change:62474" [14:35:55] <^demon> Obviously port being None is part of it. [14:36:00] yep :) [14:36:01] <^demon> But where's the gerrit.wikimedia.org? [14:36:08] <^demon> Even if 29418 were there. [14:36:15] interesting question [14:36:28] perhaps it's not getting the repo url for some reason? [14:36:32] <^demon> Did you install git-review from apt or pip? [14:36:39] pip [14:36:57] git-review version 1.21 [14:37:42] <^demon> Bizarre. [14:37:56] indeeed [14:38:15] i re-cloned the repo, same same [14:38:17] <^demon> Lemme try cloning that repo fresh and trying with git-review. [14:40:27] <^demon> DanielK_WMDE: Even weirder, wfm on 1.21 :( [14:40:49] <^demon> Fresh clone of repo, `git review -d 62474` [14:40:56] yea, i have 1.21 on another box, works fine [14:41:05] only difference is my local user name [14:42:14] ^demon: it must be some strange edge case i'm hitting with my new install for some odd reason [14:42:36] maybe i copied some config file that contains the wrong user name? but my gerrit user name hasn't changed, it should stay the same... [14:42:48] grr, do i really have to dig into the source code now? [14:43:27] <^demon> Check your ~/.ssh/config [14:43:45] <^demon> I personally set a bunch of options to save typing in Gerrit, maybe something on your old box was helping you out... [14:44:03] i copied that dir [14:44:08] but ok, checking [14:44:35] no match for "gerrit" in that file [14:44:52] i suppose you put the port and user name there? [14:45:56] <^demon> Yeah, so I can just get by with typing `ssh gerrit.wikimedia.org` [14:45:58] <^demon> I'm lazy ;-) [14:46:05] <^demon> brb, phone. [14:46:08] k [14:46:45] New patchset: MarkAHershberger; "Handle invalid titles on ProtectedPages and ProtectedTitles" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/62608 [14:52:48] <^demon> DanielK_WMDE: Can you look at line 750 of git-review on the broken box? Mine has handling for port being None. [14:53:34] New review: Vedmaka Wakalaka; "Yes, you right. But we talking here about different case - to allow specify custom displaying templa..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [14:54:11] ^demon: yea, it'S there. i'm already digging through the code. got up to fetch_url being empty in line 362 [14:54:23] <^demon> Ahh, but parse_git_show() returns str(port), does that turn port into something else? [14:54:25] i'll trie to trace this issue up the stack [14:54:52] ^demon: it fails because it doesn't find a url to parse. it has no handling for this. i'll try to find out why. [14:55:15] it's in the for loop at the top of parse_git_show somehow [14:56:42] the parsing seems to rely on the exact formatting of the output git git produces [14:56:45] oh... [14:56:56] my old box is using anglish locale, the new box has german... [14:57:14] my bet: localized git output screws with that wonky parsing [14:57:20] ^demon: sounds right? [14:57:46] * DanielK_WMDE wonders where to put the LANG=C [14:58:02] <^demon> Ew. [14:58:12] <^demon> I have no idea :\ [14:58:40] So, this is the line it *should* pick up, but doesn't: URL zum Abholen: ssh://daniel@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git [14:59:40] Ah not quite. It's looking for "Push URL", but it gets "URL zum Versenden". [15:00:40] ^demon: where do i submit patches for git review? [15:01:14] New patchset: Nemo bis; "Clarify from form/file (hopefully)" [mediawiki/extensions/DeleteBatch] (master) - https://gerrit.wikimedia.org/r/62610 [15:01:16] <^demon> Openstack. [15:02:19] <^demon> https://review.openstack.org, project openstack-infra/git-review. [15:02:19] ok, got a working patch [15:02:23] <^demon> Requires a launchpad account. [15:02:27] (though it's not exactly portable) [15:02:43] hm, i had a launchpad account at some point... [15:02:50] do i want to invest the time? [15:02:52] *sigh* [15:02:52] <^demon> I know Roan and Marcin have submitted upstream, so they might be able to give a hand. [15:02:56] * DanielK_WMDE is a good netizen today [15:07:36] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62518 [15:07:45] New patchset: Nemo bis; "Fix grammar in revcs-alert-special-parameter" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62611 [15:08:53] New patchset: Alex Monk; "Fix some JS issues" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62518 [15:09:04] New patchset: Anomie; "Make CodeEditor cooperate with the experimental live preview" [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/62612 [15:09:41] New patchset: Nemo bis; "Remove all caps from review-edit-diff" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/62613 [15:12:12] New patchset: Ganeshaditya1; "Added a alias to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [15:14:28] New patchset: Krinkle; "ext.rtlcite: Add to top queue and load with addModuleStyles" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/62540 [15:15:03] New patchset: Nemo bis; "Make revcs-alert-norevision less obscure" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62615 [15:15:28] New patchset: Aklapper; "Add support for Wikimedia Mingle URLs to Bugzilla's 'See Also' field." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [15:16:17] New review: Matmarex; "I don't really like this change. Either it should be renamed (while keeping the Special:Version as a..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62614 [15:16:52] New patchset: Krinkle; "specialpages: Add 'Special:Software' as alias for 'Special:Version'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [15:19:59] New patchset: Demon; "Add 'Special:Software' as alias for 'Special:Version'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [15:22:12] New review: Ganeshaditya1; "@matmarex," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [15:24:25] New review: Krinkle; "The bug asks for a rename, not to add an alias. It should be done the other way around (rename to Ne..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62614 [15:25:32] New patchset: Krinkle; "Add 'Special:Software' as alias for 'Special:Version'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [15:25:56] ^demon: Did you mean to start a gate-and-submit pipeline for ^ ? [15:27:07] <^demon> Yeah... [15:29:44] ^demon: but... whitespace errors! [15:30:11] <^demon> Ohnos, not whitespace! [15:34:05] There might be features in it!! [15:37:26] ^demon: quick fix: alias git="LANG=C git" [15:37:35] Reedy: --^ [15:37:44] adding instructions to the wiki [15:48:16] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62427 [15:48:17] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62427 [15:48:43] New patchset: Liangent; "(bug 48212) Fix I720946e7: $this->opts['year'] shouldn't be modified." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62619 [15:50:30] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62580 [15:50:31] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62580 [15:51:06] New patchset: Liangent; "(bug 48212) Fix I720946e7: $this->opts['year'] shouldn't be modified." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62619 [15:54:54] New review: Krinkle; "Avoid overriding a generic selector in a module. Otherwise other modules using successbox on the sam..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62571 [16:00:05] New review: Ganeshaditya1; "@krinkle. The single box is used only once in that page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [16:00:19] New patchset: Krinkle; "mediawiki.user: Use session ID instead of 1-year cross-session cookies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [16:00:21] New review: Ganeshaditya1; "The successbox*" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [16:00:31] New patchset: Nemo bis; "Fix wording of openid-trusted-sites-delete-confirmation-page-title" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/62621 [16:00:44] New review: Krinkle; "Added context to the commit message (mediawiki.user module). Wasn't clear what this change was about." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [16:00:51] New patchset: Hashar; "PHPUnit for extensions now uses --testsuite" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [16:01:38] New patchset: Hashar; "PHPUnit for extensions now uses --testsuite" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [16:02:56] New review: Hashar; "This is now deployed on https://integration.wikimedia.org/ci/job/mwext-Wikibase-server-tests/" [integration/jenkins-job-builder-config] (master) C: -2; - https://gerrit.wikimedia.org/r/62622 [16:05:16] New review: Yaron Koren; "Well, this is a more compelling argument: that the "ListTemplate" approach is sort of a hack that al..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [16:05:21] New patchset: Njw; "Various improvements to the footer columns" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [16:06:46] New patchset: EBernhardson; "Notification agent whitelist and blacklist" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62624 [16:08:28] greg-g: we are deploying Parsoid quite often, can I mention that in the deployment calendar somehow? [16:09:06] gwicke: Put it in for all day, everyday [16:09:13] haha [16:09:16] gwicke: :-) yeah, that'd be good to have in there, as a note so others know [16:09:33] I think special rights are needed to edit it [16:09:37] oh? [16:09:46] oh, the gcalendar? yeah [16:09:54] at least I did not get the option to add a new event to it [16:10:06] that's just me for now, but I watch the wiki page and keep it in sync from that (the wiki page is canonical) [16:10:13] ah, ok [16:12:58] greg-g: Care to help find a reviewer for https://gerrit.wikimedia.org/r/#/c/62612/ (that CodeEditor change I said I'd do in yesterday's meeting)? [16:13:02] I wished we had visual table editing already [16:14:02] New patchset: Hashar; "rename wikibase-server to wikibase-repo" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62628 [16:14:46] gwicke: YES PLZ [16:15:11] anomie: hrrm, I'm not sure who knows that part of the code really... thoughts? [16:15:20] hashar: So the meeting yesterday.. [16:15:47] Change merged: Siebrand; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62590 [16:16:30] Change merged: Siebrand; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62591 [16:17:08] New patchset: Hashar; "PHPUnit for extensions now uses --testsuite" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [16:17:10] New patchset: Hashar; "rename wikibase-server to wikibase-repo" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62629 [16:17:25] New review: Hashar; "jjb: https://gerrit.wikimedia.org/r/#/c/62629/" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62628 [16:17:35] New review: Hashar; "zuul: https://gerrit.wikimedia.org/r/#/c/62628/" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62629 [16:17:43] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62628 [16:17:50] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62629 [16:17:50] greg-g: I guess I'll just go with my default heuristic: look through recent merged changes and add anyone who recently submitted or merged as victim reviewer, and hope one of them actually does [16:18:08] anomie: I like it. [16:18:30] New patchset: Mwalker; "HTMLForm entity labels are now optional and escaped" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62630 [16:18:30] New patchset: Mwalker; "HTMLTextAreaField: Allow sizes to be overridden by child classes" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62631 [16:18:30] New patchset: Mwalker; "Update CN and core for HTML Forms" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62632 [16:18:31] anomie: and if they can't, they probably had someone else review their code, so, you're closer at least [16:19:34] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62630 [16:19:40] Krinkle: well you canceled the meeting haven't you ? [16:19:44] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62631 [16:19:51] hashar: I don't remember doing such thing [16:19:53] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62632 [16:20:18] hashar: Did I mess up the calendar event? [16:20:41] Krinkle: or something broken on my end :-(( [16:21:25] hashar: Shall we have it next monday then? [16:21:54] New patchset: Cmcmahon; "set cookie and refresh to make sure PDF links are expanded" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62633 [16:22:04] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62126 [16:22:21] Krinkle: yeah definitely. same time [16:22:26] New review: Anomie; "Is this obsoleted by change 62316 and change 62317?" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62127 [16:22:37] Krinkle: sorry we have missed it. I was pretty sure you got it canceled did not bother to double check [16:22:42] Krinkle: should have pinged ya on irc :D [16:23:38] hashar: I joined IRC like 17:58 (I woke up late, was out of town in the weekend), and then I saw you part IRC on 18:20 or somethhing [16:25:55] New patchset: Katie Horn; "Disabling Fundraier Redirect to WMFr per their request" [mediawiki/extensions/FundraiserLandingPage] (master) - https://gerrit.wikimedia.org/r/62634 [16:40:02] New patchset: Alex Monk; "In 'uctop', replace 'top' with 'current' [revision]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [16:40:42] New review: Krinkle; "Does this also remove them from the filearchive table? (To avoid them from still showing up on Speci..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [16:40:48] Gerrit is mangling that link... [16:40:53] not sure how to workaround [16:41:02] Change abandoned: Cmcmahon; "abandoning for better approach" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61820 [16:42:09] Krenair: where? [16:42:22] ah, i see [16:42:34] Krenair: insert enough zeroes before the oldid so that there are at least 41. [16:42:42] (sadly i'm not kidding.) [16:42:43] ... [16:42:48] how about just ignoring it? :) [16:42:52] or just forget it, yes [16:43:16] it'll be correct in git [16:43:24] it's just gerrit being dumb [16:43:44] bit.ly [16:43:47] because someone decided to use a DFA regular expression library and i can't even use damned lookbehind in the regex that autolinkifies commit ids. [16:44:03] dumb java devs. [16:44:39] (it's done properly for bugzilla and it works there) [16:45:16] Krenair: if i were you, i'd just merge that. ;) [16:45:33] New patchset: Krinkle; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/62605 [16:45:33] New patchset: Nemo bis; "In 'uctop', replace 'top' with 'current' [revision]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [16:46:01] Krenair: I've restored the title because if the message is deleted revid is useless and one doesn't have a clue [16:46:06] New patchset: Krinkle; "mw-install-sqlite: chmod +w sqlite database" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62639 [16:46:15] anyway, git log etc. will be ok [16:46:18] Change merged: Pgehres; [mediawiki/extensions/FundraiserLandingPage] (master) - https://gerrit.wikimedia.org/r/62634 [16:51:06] Change merged: jenkins-bot; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/62605 [16:52:54] hexmode: Why did you remove the "Backport?" from https://bugzilla.wikimedia.org/show_activity.cgi?id=47202 ? [16:53:00] ... and then submit a backport to gerrit [16:53:11] Wrong button or was I not supposed to merge that backport [16:54:28] Krinkle, I removed the backport? after submitting the backport [16:54:30] Or does it work differently? I thought ?=pending, +=approved/done, -=rejected? [16:54:41] is that not how to do it? [16:55:03] hexmode: well you removed the field entirely instead of setting it to + [16:55:12] hexmode: and it was done before the change actually was merged [16:55:17] Im confused [16:55:21] ok... me too [16:55:51] This needs to be documented on a wiki somewhere... or if it is, I need to read the page. :P [16:56:03] hexmode: This is what I thought, tell me if that's right: Merge in master, tag for backport (backport=?), lands in branch (backport=+) [16:56:42] not removing the backport field when it lands and not setting it to + before it lands (pending in gerrit means nothing) [16:56:45] krinkle, the problem is, sometimes we have multiple branches to backport [16:57:06] a bug can have multple problems, we mark as done when its done, right? [16:57:34] I still find that field confusing [16:57:35] hexmode: flag=? - someone has suggested backporting [16:57:39] so leave ? until all branches are backported, then + [16:57:46] Yes [16:57:47] hexmode: flag=+ or flag=- - the release manager's reply - we;re backporting or not [16:57:57] hexmode: then we bacport or not, and the flag stays [16:58:05] (that's afaik the usual workflow with this on bugzillas) [16:58:22] MatmaRex: Then how do you keep track of whether or not the change has been succesfully backported? [16:58:26] ok MatmaRex, makes sense. [16:58:36] Krinkle: probably by marking the bug RESOLVED FIXED [16:58:42] Krinkle: or VERIFIED FIXED, if you prefer [16:58:45] MatmaRex: No, the bug is marked fixed when the bug is fixed in master. [16:58:47] i don't know, to be honest [16:58:48] krinkle the gerrit bot leaves a comment [16:58:52] VERIFIED should be killed [16:58:58] hexmode: That's not machine readable [16:59:11] e.g. get a list of changes that need to be backported still [16:59:13] i guess that if the release manager has merge rights, flag=+ means the backport is okay and was merged [16:59:28] you should ask andre__ for details i guess [16:59:29] Right, you approve it by mering it [17:00:05] Reedy: I thought your change on bug 48216 ("blocks bug 1"!) was a joke :) [17:00:05] * hexmode pings andre__ for the answer [17:00:20] New patchset: Pastakhov; "Refactoring of runtime and add basic array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [17:00:59] zeljkof: quiz question: guess what is bug 4 [17:01:01] and bug 5, too. [17:01:05] (hint: they;re both open) [17:01:31] * zeljkof is looking at bugs 4 and 5 :) [17:01:53] cheater. :P [17:02:13] oh, my word, I've been blocking a spammer on one of my wikis .. multiple account creations with gibberish usernames [17:02:37] blocked accounts with "unacceptable user name" [17:03:04] and in the past five minutes they started creating readable user names [17:03:10] zeljkof: Part of it is the amusement of sending all the CC'd people on bug 1 an email :D [17:03:31] Reedy: wiki humor :) [17:06:35] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:10:25] New review: Demon; "Well, that's what the FAQ and other pages on mw.org are for...otherwise we could arguably include te..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [17:11:21] New review: Zfilipin; "Karim, this looks to me like it is a bit to hard for you at the moment. Please consider focusing on ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62231 [17:11:25] New patchset: Krinkle; "Refactoring of runtime and add basic array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [17:11:37] New review: Krinkle; "revisions:" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [17:11:58] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:12:15] New review: Krinkle; "Use the "Review" button on the individual patch set sections for progress/comments on the individual..." [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [17:13:17] New patchset: EBernhardson; "Disable unavailable notification checkboxes" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61509 [17:14:53] New review: Ganeshaditya1; "yeah, but this is suppose to be a special message right ? We are removing this message cause we are ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [17:15:08] New review: Krinkle; "Doesn't work. Class names don't match between css and html. Did you test it?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62571 [17:17:39] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [17:20:41] Ryan_Lane: I haven't mentioned this yet today - so - I really hate scap! I am really looking forward to sartoris whenever that happens. [17:20:59] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:21:21] mwalker: :D [17:21:46] Long live scap [17:22:00] * mwalker stabs it with a spork [17:22:12] It'll just carry on [17:22:27] <^demon> We'll make scap a wrapper for git deploy. [17:22:37] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62639 [17:22:37] <^demon> So those of us too nostalgic to move on can still enjoy it. [17:23:17] New review: Ganeshaditya1; "@krinkle sorry man.. I tested in WAMP server and over written it here from a different source. I do ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:23:52] ^demon: +1 [17:23:59] Reedy: want to look at https://gerrit.wikimedia.org/r/#/c/62408/ ? [17:24:55] New review: Krinkle; "Perhaps you can install them on a subdomain or in a subdirectory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:25:49] Yippie, build fixed! [17:25:50] Project _debug-browsertests-template build #113: FIXED in 59 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/113/ [17:26:22] New review: Krinkle; "Perhaps you can install them on a subdomain or in a subdirectory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [17:27:06] New patchset: EBernhardson; "Disable unavailable notification checkboxes" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61509 [17:27:18] New review: Cmcmahon; "got Profile working in Chrome!" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62593 [17:27:19] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62593 [17:31:27] Project _debug-browsertests-template build #114: FAILURE in 2 min 48 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/114/ [17:36:01] Yippie, build fixed! [17:36:01] Project _debug-browsertests-template build #115: FIXED in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/115/ [17:39:21] New patchset: Mwalker; "Updating FundraiserLandingPage to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62645 [17:39:21] Krinkle: I'm getting reports identical to https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 on Special:LanguageStats and Special:MessageGroupStats on translatewiki.net... what to do? [17:39:35] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62645 [17:39:54] Nikerabbit: Likely something causing a call to document.write [17:40:17] Nikerabbit: Can you verify that none of the extensions are using document.write? [17:41:18] not easily [17:41:19] twn:/www/translatewiki.net/w/extensions (master)$ ack 'document\.write' [17:41:19] Maps/includes/services/GoogleMaps3/geoxml3/ZipFile.complete.js [17:41:19] 608: document.write(IEBinaryToArray_ByteStr_Script); [17:46:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62551 [17:47:06] Nikerabbit: Could be the cause, can't say for sure. [17:47:14] Nikerabbit: Is it an easy extension to temporarily disable? [17:47:33] Nikerabbit: btw, I usually use ack -Q (quick) for non-regex searches [17:47:40] Krinkle: oh [17:47:50] that file is not loaded on that page [17:47:59] ym other suspect is the google adds [17:52:56] Nikerabbit: Can people reproduce the problem in the twn sandbox? [17:52:58] New patchset: awjrichards; "Cherry-picking e37e9d9ae6b8a581569c39ede38fc21827983128" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62647 [17:53:02] Nikerabbit: Perhaps disable ads there [17:54:25] New patchset: Njw; "Make width flexible above 960px" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62648 [17:55:35] New patchset: awjrichards; "Cherry-pick e37e9d9ae6b8a581569c39ede38fc21827983128" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62649 [17:56:53] Change merged: awjrichards; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62647 [17:57:11] Change merged: awjrichards; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62649 [17:58:29] New patchset: Njw; "Various improvements to the footer columns" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [17:59:56] Krinkle: it's definitely not document.write (used search in Chrome) [18:00:33] I see a short flash of the page and then it goes white and browser keeps indicating it is loading the page... although everything is loaded already [18:00:56] ah this is interesting [18:00:56] Nikerabbit: If you're in Chrome... go to the elements panel [18:01:02] What does the DOM look like [18:01:08] *after* it goes white [18:01:22] [18:01:32] So, it is document.write [18:01:57] Nikerabbit: Specifically the one in ResourceLoader [18:02:08] Nikerabbit: Are you using the latest version of mw-core? [18:02:15] Krinkle: updates this morning [18:02:16] Nikerabbit: Which skin? Or is this the twn main page? [18:02:38] https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=wiki-betawiki&suppressempty=1&language=vro this url (but needs many tries to reproduce) [18:02:45] vector skin [18:03:35] Nikerabbit: Logged in? https? [18:04:26] Krinkle: yes, yes (but I also got reports from users who are using http) [18:06:26] Nikerabbit: I can't reproduce it [18:06:39] Nikerabbit: In Chrome? [18:06:45] strnage [18:06:55] Krinkle: Also in Firefox in user reports [18:07:09] I usually click between language stats and message group stats tabs until it happens [18:11:15] Nikerabbit: That color highlighting code, I created that right? [18:11:22] Krinkle: yes [18:11:25] Nikerabbit: Which means I'd use mw.loader.using to load jquery.colorUtil [18:13:24] I think you did [18:13:25] resources/js/ext.translate.special.languagestats.js [18:13:25] 103:mw.loader.using( 'jquery.colorUtil', function () { [18:14:17] https://github.com/wikimedia/mediawiki-extensions-Translate/blob/master/resources/js/ext.translate.special.languagestats.js#L103 [18:14:21] Yep, I just found it a second ago [18:14:54] Nikerabbit: I found the problem [18:15:01] Nikerabbit: view-source:https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=wiki-betawiki&suppressempty=1&language=vro#sortable:4=asc [18:15:05] mw.loader.load(["ext.translate.helplink","mediawiki.page.startup","mediawiki.legacy.wikibits","mediawiki.legacy.ajax","ext.uls.init","ext.uls.interface","ext.translate.tabgroup"]); [18:15:08] mw.loader.load(["ext.translate.special.languagestats","mediawiki.user","mediawiki.page.ready","mediawiki.page.watch.ajax","mediawiki.searchSuggest","mediawiki.hidpi","ext.gadget.HoverPopTools","ext.vector.collapsibleNav","ext.vector.collapsibleTabs","skins.vector.js"],null,true); [18:15:12] or not.. [18:15:17] Yes [18:15:27] The bottom and top queue are both on top [18:16:10] Though I don't see how that could cause this problem [18:16:55] hmm still?? [18:17:08] New patchset: Anomie; "Add Javascript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [18:17:27] Nikerabbit: I'm afraid so, yes. [18:17:27] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [18:17:43] AAARGH [18:17:44] $wgResourceLoaderExperimentalAsyncLoading = true; // Nike 2012-01-11 [18:17:58] Blast from the past. [18:18:02] so there was one in my devwiki, but also one in production! [18:18:49] Project _debug-browsertests-template build #117: FAILURE in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/117/ [18:19:15] this explains a lot of things, but not the cause of this issue [18:21:20] Krinkle: what you suggest? I set that to false and declare that variable as dangerous? [18:21:43] Nikerabbit: Depends, does it fix the problem? [18:22:16] Krinkle: hard to say, my reporters all disappeared [18:22:46] I will know tomorrow for sure [18:22:53] ok [18:23:19] Nikerabbit: If it fixes the problem, we should remove that experimental feature from core as being "unmaintained and broken" [18:23:28] we can add it back later if we consider it again [18:29:24] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [18:32:32] Yippie, build fixed! [18:32:33] Project _debug-browsertests-template build #119: FIXED in 1 min 3 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/119/ [18:34:41] New review: Krinkle; "Suggest rename to wgPageContentModel for consistency and to avoid ambiguity." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62178 [18:35:08] New patchset: MaxSem; "Separate language generation from outputPage" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62652 [18:36:18] Krinkle: yup, I got one user confirmation that setting that variable to false fixes it [18:38:14] New patchset: Vedmaka Wakalaka; "Extended Page Schemas integration" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [18:39:37] (the trick was using &action=purge to reproduce) [18:39:50] Nikerabbit: IIRC, the reason you enabled that was related to https://bugzilla.wikimedia.org/show_bug.cgi?id=33560 [18:39:57] New review: Vedmaka Wakalaka; "removed ListTemplate" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [18:41:13] Nemo_bis: no that is different variable [18:42:32] Nikerabbit: I know it is... [18:44:59] well, too lazy to check logs now [18:51:04] New review: EBernhardson; "Tested, appears to work as desired" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/62110 [18:51:07] chrismcmahon: do you know anything about how redis works with the beta cluster? I keep getting "Unable to connect to redis server" errors [18:53:23] mwalker: sounds like a config problem? https://bugzilla.wikimedia.org/show_bug.cgi?id=41530 [18:54:00] hurm! good call! that looks applicable :) [18:54:36] dinner [18:55:42] mwalker: I haven't seen that error, I've been using beta labs a fair bit [18:56:03] I think the only reason I'm seeing it is just due to how centralnotice interacts with the job queue [18:56:44] CN-jobqueue interactions sounds scary [18:56:58] it gets worse :) it's actually CN->translate->jobqueue [18:57:23] and it's required so that translate recognizes the banner translation group [18:57:34] just read the bug... at least it's more understandable [18:57:41] it's not like "every impression hits jobqueue" [18:57:54] I miss https://gdash.wikimedia.org/dashboards/jobq/ [18:59:44] is it possible to only display patrolled edits? [18:59:49] * hexmode goes to look some more [19:02:31] :O [19:05:29] New patchset: Foxtrott; "fix bug 47150 (sfEditFormPreloadText no longer works as it used to)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [19:06:36] New patchset: Foxtrott; "fix bug 47150 (sfEditFormPreloadText no longer works as it used to)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [19:13:34] Change abandoned: Hashar; "will revisit eventually." [mediawiki/extensions/SwiftCloudFiles] (master) - https://gerrit.wikimedia.org/r/54444 [19:14:58] New patchset: Foxtrott; "fix bug 47150 (sfEditFormPreloadText no longer works as it used to)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [19:26:24] New patchset: Jeroen De Dauw; "Fixed title construction in EPArticle and added regression test" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/62663 [19:26:45] New patchset: Jeroen De Dauw; "Fixed title construction in EPArticle and added regression test" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/62663 [19:32:00] New patchset: IAlex; "(bug 48212) Fix I720946e7: $this->opts['year'] shouldn't be modified." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62619 [19:36:54] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62619 [19:41:47] New patchset: Jeroen De Dauw; "Vote for Wikibase based on the tests currently passing" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/62666 [19:46:05] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62668 [19:47:03] New patchset: Ganeshaditya1; "Bug: 43680 added the MediaWiki logo as the default logo." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [19:51:33] New review: MaxSem; "wiki.png needs to be deleted if we're not using it anymore." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62339 [19:55:21] New patchset: Hashar; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [19:56:42] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [20:00:35] New patchset: Umherirrender; "Add wgPageContentModel to mw.config" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62178 [20:01:09] New review: Hashar; "PS8 fix up all the issues reported by Aaron." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [20:01:40] New review: Umherirrender; "wgPageContentModel sounds good. Changed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62178 [20:04:21] New review: Mattflaschen; "Looks good, except that I don't see a reason for two divs, and a CSS formatting issue. See the comm..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62571 [20:05:30] Project browsertests-en.wikipedia.org-linux-chrome build #43: FAILURE in 2 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/43/ [20:07:46] New review: Mattflaschen; "You can also try https://www.mediawiki.org/wiki/Mediawiki-Vagrant as an alternative to WAMP that wil..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [20:17:28] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62668 [20:17:49] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62652 [20:18:37] New review: Brian Wolff; "Looks good to me." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61897 [20:19:12] Hexmode: --^ [20:20:22] New review: GWicke; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/58113 [20:21:14] Change merged: MarkAHershberger; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61897 [20:24:27] New review: GWicke; "Does this preserve the connection of selected tabs with the body, while unselected tabs appear separ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60123 [20:29:23] New patchset: Brian Wolff; "Fix typo causing sql error" [mediawiki/extensions/intersection] (REL1_19) - https://gerrit.wikimedia.org/r/62720 [20:30:31] New patchset: Brian Wolff; "Fix typo causing sql error" [mediawiki/extensions/intersection] (REL1_20) - https://gerrit.wikimedia.org/r/62721 [20:31:21] New review: Brian Wolff; "Self merging since its a backport of an extension change (I'm assuming backporting stuff for extensi..." [mediawiki/extensions/intersection] (REL1_19) C: 2; - https://gerrit.wikimedia.org/r/62720 [20:33:19] New review: Brian Wolff; "Self merging since its a backport of an extension change (I'm assuming backporting stuff for extensi..." [mediawiki/extensions/intersection] (REL1_20) C: 2; - https://gerrit.wikimedia.org/r/62721 [20:34:12] New patchset: Krinkle; "mw.config: Add wgPageContentModel for content model of current page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62178 [20:34:30] New review: btongminh; "In case you don't want huge .v files on disk." [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/62233 [20:35:02] New patchset: Matmarex; "Don't use a for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [20:37:42] New review: Matmarex; "Yes, the way z-indices are set ensures that." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60123 [20:39:41] Is jenkins actually working, or just super slow again? [20:45:27] bawolff: will lok [20:45:40] bawolff: given the amount of patch sets that have been received (see above) [20:45:43] I guess it is busy building [20:45:44] Change merged: jenkins-bot; [mediawiki/extensions/intersection] (REL1_19) - https://gerrit.wikimedia.org/r/62720 [20:46:15] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [20:46:24] Change merged: jenkins-bot; [mediawiki/extensions/intersection] (REL1_20) - https://gerrit.wikimedia.org/r/62721 [20:46:33] bawolff: see it is still alive :-] [20:46:39] oh speak of the devil :P [20:46:48] bawolff: https://integration.wikimedia.org/zuul/ [20:46:57] that list the events pending in the scheduler [20:47:03] (68 events right now) [20:47:09] and show the jobs being run / pending [20:47:09] New review: Ganeshaditya1; "Now I have tried all the combinations man. See I first put font-weight:bold in successbox in mediawi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [20:47:11] thanks for the link [20:49:35] New review: Mattflaschen; ""Now matt if I ever to merge them into one again(The last combination) I have to make a new generic ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [20:50:02] New review: Ganeshaditya1; "@mattflaschen I will have to try mediawiki-vagrant day after tomorrow. I mean it will take couple of..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [20:50:21] New patchset: MarkTraceur; "Add parsoid-specific image testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [20:53:21] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62178 [20:54:15] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60801 [20:57:40] New patchset: Diederik; "Enable LOAD LOCAL INFILE in MySQL" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/62727 [20:59:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [21:04:59] New patchset: Krinkle; "mediawiki.user: Use session ID instead of 1-year cross-session cookies" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/62728 [21:05:04] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62729 [21:05:20] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62729 [21:08:20] New patchset: Ganeshaditya1; "Removed the font weight from error box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [21:09:37] New patchset: Krinkle; "mediawiki.user: Use session ID instead of 1-year cross-session cookies" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/62732 [21:10:25] New patchset: Adamw; "Save banner messages even if the name contains a hyphen" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62733 [21:11:10] Reedy: I heard you mention something about Undefined index: wgStyleSheetPath earlier [21:11:12] Reedy: correct? [21:11:19] https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-parser/6724/console [21:11:22] wmf branch phpunit is failing [21:11:28] No, I don't think so [21:11:39] Depending on how early earlier was [21:11:58] a few hours [21:12:19] Not today.. [21:12:28] Man, why is everybody bypassing Jenkins when backporting to wmf branches? It is now impossible to track whcih change broke it because jenkins-bot can't V-1 after the merge [21:13:12] Sometimes patience [21:13:23] It is gut vs. head [21:13:23] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62734 [21:13:35] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/62728 [21:13:39] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62734 [21:13:39] Bypassing means everyone else that does wait has to wait even longer [21:13:50] even for your shit to complete of which you won't see the results anyway [21:14:45] about to scap... [21:15:49] New patchset: MarkTraceur; "Fix the Parsoid-only tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62121 [21:16:19] New patchset: Aaron Schulz; "[FileBackend] Process cache negatives for SHA1 on file stat." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62736 [21:16:55] New review: Mwalker; "*facepalm*" [mediawiki/extensions/CentralNotice] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62733 [21:16:56] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62733 [21:17:51] greg-g: we found a small bug in this mornings CN deploy; can I get part of the LD today to push this fix: https://gerrit.wikimedia.org/r/#/c/62733/ [21:17:59] Reedy: Do you know more about why this setting is commented out in wmf branches in DefaultSettings.php? [21:18:00] New review: Ganeshaditya1; "mmm .. I still think adding the font-weight to the successbox has its own semantic importance since ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [21:18:12] Which setting? [21:18:17] Reedy: https://gerrit.wikimedia.org/r/#/c/7606/ [21:18:22] https://gerrit.wikimedia.org/r/#/c/7606/1/includes/DefaultSettings.php [21:18:36] How does the presence of that variable break anything? [21:18:42] I've no idea [21:18:52] Ask Tim, his name is to the comments? ;) [21:18:58] And why is it so hard to move wgAutopromote = array(); to CommonSettings? [21:19:00] argh [21:19:08] mwalker: yeah, just coordinate with Matt F. [21:19:10] "But this only this once" [21:19:27] yeah, something about temporary solutions becoming permanent, well said Tim-away :) [21:19:47] It's possible that first one is now redudant [21:20:12] Krinkle: Having said that [21:20:12] $wgAutopromote = array( [21:20:13] 'autoconfirmed' => array( '&', [21:20:13] array( APCOND_EDITCOUNT, $wgAutoConfirmCount ), [21:20:13] array( APCOND_AGE, $wgAutoConfirmAge ), [21:20:13] ), [21:20:14] ); [21:20:32] greg-g: awesome; thanks :) [21:20:39] Change merged: jenkins-bot; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/62732 [21:20:43] Reedy: Where is that cited from? [21:20:48] CommonSettings.php [21:20:55] Exactly the same minus the & [21:21:31] Reedy: So that patch is a no-op [21:21:37] Looks like it [21:21:56] wmf-config/CommonSettings.php [21:21:56] 247:unset( $wgStyleSheetPath ); [21:22:10] but... [21:22:12] Feel free to create a new patchset on 7606 and then update make-wmf-branch live hack patch reference [21:22:12] 253: $wgStyleSheetPath = "//test.wikipedia.org/w/static-$wmfVersionNumber/skins"; [21:22:13] 257: $wgStyleSheetPath = "//bits.wikimedia.org/static-$wmfVersionNumber/skins"; [21:22:13] 269: $wgStyleSheetPath = $wgResourceBasePath . "/skins"; [21:22:14] 273:$wgStylePath = $wgStyleSheetPath; [21:22:19] !pastebin [21:22:19] Please do not paste more than 2-3 lines of text into the channel as it disrupts the flow of conversation. When sharing multiple lines of code, please use a pastebin such as or and post a link to your paste in the channel. [21:22:38] So it is being unset, to then be re-set [21:22:39] CommonSettings is still a mess [21:22:44] yes [21:22:48] there's a bug for that, too :P [21:22:51] Indeed [21:23:02] I've removed a lot of crap. Still a lot less [21:23:09] *left [21:25:31] Krinkle: Want to remove those live hacks from DefaultSettings? Or shall I? [21:25:52] greg-g: I'd also like to get in line for today's LD to touch some timestamps for cache busting purposes [21:25:57] Reedy: I'm trying to decrypt make-wmf-branch, go ahead this time. [21:26:20] The only line you need to change is [21:26:20] 'refs/changes/66/22466/5' => 'core', // Most of the WMF "live hacks" https://gerrit.wikimedia.org/r/#/c/22466 [21:26:38] how do I create the replacement? I need a base, right? [21:26:43] Change restored: Reedy; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [21:26:49] or an abandoned change on master? [21:26:52] Just amend the previous commit [21:26:54] ah [21:27:06] Then steal the numbers from it [21:27:11] git fetch ssh://reedy@gerrit.wikimedia.org:29418/mediawiki/core refs/changes/66/22466/5 && git cherry-pick FETCH_HEAD [21:27:24] OK [21:27:32] Shal I? [21:27:35] feel free [21:29:24] Reedy: When I rebase it, the commit dissolves [21:29:31] as if it is applied to master already [21:29:35] New patchset: Reedy; "Commit of various live hacks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [21:29:45] Gerrit rebased it fine [21:29:54] Gerrit, yes. [21:30:40] Why rebase manually when you can get something else do it for you? ;) [21:31:01] I was going to do it in one patch set instead of separate [21:31:45] RoanKattouw: fun, that doesn't sound *too* crazy, how many we talking about? [21:31:57] A couple [21:32:04] Actually probably just one or two files [21:33:05] RoanKattouw: well then, if you want to do that after MaxSem is done, that should be fine. (just to not have too many people jockying around during LD) [21:33:14] When would this be? [21:33:35] He actually might be finished... officially 3pm. MaxSem ? [21:33:45] New patchset: Krinkle; "Commit of various wmf-branch live hacks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [21:33:58] reedy@fenari:/home/wikipedia/common$ ps aux | grep -c maxsem [21:33:58] 19 [21:34:00] * Reedy suspects not [21:34:01] New review: Kaldari; "Somewhat relevant discussion:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62118 [21:34:04] New review: Krinkle; "Removed these two patches:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [21:34:14] Reedy: thanks :) [21:36:33] New patchset: Krinkle; "patches: Update patch reference for wmf-branch live hacks" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/62738 [21:37:00] Change abandoned: Krinkle; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [21:37:11] New patchset: Krinkle; "patches: Update patch reference for wmf-branch live hacks" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/62738 [21:37:19] Reedy: For you ^ [21:37:31] greg-g, not yet, scap in progress [21:37:35] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/62738 [21:37:39] ....on early stages:P [21:37:49] :) [21:38:23] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/42537 [21:50:49] New patchset: Krinkle; "skin: Revert font-weight on successbox and move to preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [21:56:15] New patchset: Wizardist; "(Bug 46422) convertPlural makes using 0= and 1= rules impossible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62149 [21:57:47] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62571 [22:00:07] hashar: How was phpcs installed on gallium? [22:00:12] hashar: I can't find any record of it [22:00:16] Nor any package [22:00:25] I'd like to upgrade it because it is failing [22:00:33] 1.4.3 needs to be bumped to 1.4.5 [22:01:17] no idea [22:01:19] maybe from pear [22:01:26] hashar: Did you install it manually with sudo pear install? [22:01:57] PHP_CodeSniffer 1.4.3 stable [22:01:59] yeah via pear [22:02:08] hashar: Can you upgrade it? [22:02:18] hop it is midnight there I am going to sleep sorry [22:02:29] hashar: OK [22:02:36] hashar: How did you verify it was installed with pear? [22:02:38] I am not taking the risk of staying awake one more hour hehe [22:02:45] pear list|grep -i codesniffer [22:02:49] Thx [22:03:29] we should really use a deb package [22:03:47] anyway off for real. [22:03:59] hashar: one thing at a time, fixing breakage goes first [22:04:05] ops could get it upgraded if needed [22:04:19] I'll take care of it by asking someone else with sudo on gallium to do it [22:04:24] and downgraded as well [22:04:29] yeah [22:04:36] * hashar sleeps [22:28:07] New patchset: Indranisen; "Added new test script for print/export feature" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62745 [22:33:39] New review: Krinkle; "Replace all them "function("'s if you will." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/62518 [22:36:23] New patchset: Krinkle; "deleteEqualMessages: Refactor to support all langcode subpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [22:36:28] New patchset: Indranisen; "New test scripts for ULS,login etc.." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62749 [22:39:52] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/57935 [22:46:09] New patchset: Alex Monk; "Fix some JS issues" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62518 [22:53:49] New review: Cmcmahon; "There are a number of problems with this, from misspellings to being checked into the wrong repo, to..." [qa/browsertests] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/62749 [22:56:01] New patchset: Cscott; "parserTests: fix broken parsoid-only tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62752 [22:59:44] New review: GWicke; "I think these differences are normally handled by parsing the fragment to DOM (which we have to do f..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62752 [23:00:25] New patchset: Krinkle; "phpcs: Fix WhiteSpace.LanguageConstructSpacing warnings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [23:03:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62752 [23:04:09] New patchset: Mattflaschen; "E3 lightning deploy for GettingStarted (submodule bump):" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62755 [23:05:39] Yippie, build fixed! [23:05:39] Project browsertests-en.wikipedia.org-linux-chrome build #44: FIXED in 3 min 21 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/44/ [23:10:03] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62755 [23:22:29] New patchset: Krinkle; "phpcs: Fix WhiteSpace.LanguageConstructSpacing warnings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62753 [23:22:29] New patchset: Krinkle; "phpcs: Fix WhiteSpace.LanguageConstructSpacing warnings in maintenance/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62757 [23:28:57] New patchset: Bsitu; "Add new EventLogging schema: EchoMail along with code refactor" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62758 [23:29:01] New patchset: Mwalker; "Updating CentralNotice to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62759 [23:31:48] New patchset: Bsitu; "Add new EventLogging schema: EchoMail along with code refactor" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62758 [23:32:00] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62759 [23:32:30] New patchset: Krinkle; "tests: Don't set wgStyleSheetPath in addition to wgStylePath" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62760 [23:32:43] Reedy: https://gerrit.wikimedia.org/r/#/c/62760/ [23:33:00] superm401: [23:37:05] Krinkle, interesting, thanks. [23:37:14] Why is it unset in WMF branches? [23:37:16] also, wgStyleSheetPath is deprecated. [23:37:19] Are they two different values? [23:37:36] superm401: It has been a patch transferred from wmf branch to wmf branch for a long time [23:37:40] No idea why [23:37:58] TimStarling: Do you remember what the unsetting of wgStylePath alias wgStyleSheetPath is for in wmf config? [23:38:09] It has your signature in the patch :) [23:38:31] It has been moved to CommonSettings.php a while back, so it can now be removed from the wmf branch, but the end result is the same. [23:39:51] Krinkle: to work around a PHP bug that was causing segfaults when references were used in certain ways [23:39:58] the globals were unset to remove the references [23:40:20] New patchset: Krinkle; "tests: Don't set wgStyleSheetPath in addition to wgStylePath" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62760 [23:40:27] TimStarling: I see. [23:40:41] TimStarling: Do you know which php bug / php version? [23:42:10] do you have the date? [23:42:16] you say you have the patch [23:42:36] TimStarling: It has been copied from branch to branch [23:42:58] TimStarling: https://gerrit.wikimedia.org/r/#/c/22466/ [23:43:16] That is the placeholder change (abandoned) of which the reference is fetched by make-wmf-branch and cherry-picked [23:43:20] no, it was a long time before that [23:43:26] I know [23:43:41] Krinkle: hah. https://gerrit.wikimedia.org/r/#/c/7606/ "Reset $wgAutopromote (should be moved to a config change!!)" [23:44:03] that information about it being a PHP bug was in my brain storage so cold it took two minutes for the hard drives to spin up ;) [23:44:07] Reedy: https://gerrit.wikimedia.org/r/#/c/22466/6..7//COMMIT_MSG [23:45:31] * Aaron|home awaits solid-state neural drives [23:45:43] Store everything in DNA [23:45:44] Much easier [23:46:37] * peachey|laptop__ upgrades TimStarling's brain to ssd  [23:46:40] https://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.16wmf1/includes/DefaultSettings.php?revision=64057&view=markup#l151 [23:46:45] Not yet in 1.16wmf1 [23:46:52] so not *that* old [23:47:15] Not in 1.19wmf1 either [23:47:16] https://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.19wmf1/includes/DefaultSettings.php?revision=64057&view=markup#l151 [23:47:18] interesting [23:47:54] Krinkle: the server kittehs did it directly to confuse you [23:48:17] https://github.com/wikimedia/mediawiki-core/blob/wmf/1.20wmf1/includes/DefaultSettings.php#L159-L161 [23:48:48] https://github.com/wikimedia/mediawiki-core/commit/c532e81d583d3d0439fe76eea4d105d675461b56 [23:48:49] yeah [23:49:06] this is the oldest trace I can find of the path (Reedy, TimStarling) in public version control [23:49:18] 2012-04-01 [23:49:53] I seem to recall building that out of numerous svn commits [23:50:14] there was no git pull --rebase back then [23:50:23] so it's unlikely that they were on the server only, right? [23:59:32] New patchset: Bsitu; "Add new EventLogging schema: EchoMail along with code refactor" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62758