[00:56:01] New patchset: Kaldari; "New logic for how Echo interacts with new message alerts (OBOD)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62316 [01:08:19] New patchset: Rasel160; "(bug 27995) Added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [01:12:57] New patchset: Kaldari; "Adding new GetNewMessagesAlert hook" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [01:14:06] New patchset: Kaldari; "New logic for how Echo interacts with new message alerts (OBOD)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62316 [01:23:43] New patchset: Kaldari; "Adding GetNewMessagesAlert hook and wgUserNewMsgRevisionId JS global" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [01:27:01] New patchset: Kaldari; "New logic for how Echo interacts with new message alerts (OBOD)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62316 [01:32:06] New patchset: Kaldari; "Adding GetNewMessagesAlert hook and wgUserNewMsgRevisionId JS global" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [03:02:01] New patchset: Bsitu; "Add extra security check to Echo API to prevent vandalism" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62211 [03:20:45] New patchset: Adamw; "Anonymous users do not have a permanent ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [03:22:01] New patchset: Kaldari; "Adding GetNewMessagesAlert hook and wgUserNewMsgRevisionId JS global" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62317 [03:34:56] New patchset: Adamw; "Anonymous users do not have a permanent ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [03:54:15] New patchset: Bsitu; "(bug 47910) Minor edit should not trigger talk page notif" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61819 [04:03:29] New patchset: Bsitu; "(bug 47910) Minor edit should not trigger talk page notif" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61819 [04:06:52] New patchset: Bsitu; "(bug 47910) Minor edit should not trigger talk page notif" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61819 [04:06:56] New review: Adamw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [04:12:40] New review: Yurik; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62229 [05:03:44] New review: Thaiphan; "So I added instructions to the README. Anything else you want me to do?" [mediawiki/extensions/WindowsAzureSDK] (master) - https://gerrit.wikimedia.org/r/56770 [06:30:15] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/49280 [06:30:48] New patchset: Eloquence; "Restore concurrent uploading functionality." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/62320 [08:16:51] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62229 [09:23:25] New review: Nikerabbit; "Please give the steps to reproduce and describe what you fixed, not what you did." [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/62235 [09:27:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62232 [10:14:41] New patchset: Nikerabbit; "Add .gitreview" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62331 [10:14:41] New patchset: Nikerabbit; "Fix extension name after migration to new repo" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/62332 [10:41:37] New patchset: Nikerabbit; "Fix project icon raster thumb urls" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62335 [12:06:40] hi [12:07:06] can anybody point me to the place in the code where file pages are "imported" from Commons for displaying? [12:59:16] New patchset: Matmarex; "Link to mediawiki.org page in 'edithelppage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [13:00:48] New patchset: Matmarex; "Link to mediawiki.org page in 'edithelppage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [13:03:28] New review: Matmarex; "Siebrand, Niklas: should I remove the previously existing translations, or will this happen automagi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [13:24:26] New patchset: Ganeshaditya1; "Bug: 43680 added the MediaWiki logo as the default logo." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62338 [13:25:15] New patchset: Ganeshaditya1; "Bug: 43680 added the MediaWiki logo as the default logo." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62338 [13:38:19] New patchset: Ganeshaditya1; "Bug: 43680 added the MediaWiki logo as the default logo." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62338 [13:45:54] Change abandoned: Ganeshaditya1; "My previous bug fix is appended to this preventing me from commiting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62338 [13:53:58] New patchset: Ganeshaditya1; "Bug: 43680 added the MediaWiki logo as the default logo." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [13:55:21] New patchset: Rjain; "location entry tooltip should link to geocoding page" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/46960 [14:02:43] New patchset: Rjain; "location entry tooltip should link to geocoding page" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/46960 [14:32:10] New review: Parent5446; "I'm not sure I'm comfortable with this being part of the core. This is more appropriate being put in..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/53195 [15:11:32] New review: Diederik; "Hi Adam," [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53195 [15:21:09] New review: Nikerabbit; "Would it be possible to change the message key? Deleting translations is tedious work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [15:26:55] New review: Matmarex; "Changing the key will in turn require moving the pages everywhere it was customized, which will be m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [15:31:26] Change abandoned: Brion VIBBER; "Everybody seems to prefer the SVG route, so abandoning the raster scaling branch." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62313 [16:13:49] New review: PleaseStand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [16:18:09] New patchset: Nikerabbit; "Use whitelist instead of blacklist for translate tab group" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62340 [16:18:13] New patchset: Nikerabbit; "Update tab links as well when updating page location dynamically" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62341 [16:21:41] New patchset: Nikerabbit; "Remove tooltip for groups from group selector" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62342 [16:30:53] New patchset: Nikerabbit; "Small cleanups" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62343 [16:30:53] New patchset: Nikerabbit; "Rename this.$group to this.$trigger for clariy" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62344 [16:47:36] I need some very quich javascript help... I/mn going crazy [16:48:09] what is wrong with: $( 'li.pt-notifications' ).text().match( /[0-9]+/g ) != null [16:48:18] I always get null [16:50:55] Edokter: #pt-notifications [16:51:15] just realized that 10 seconds ago [16:51:19] still not there though [16:52:22] well [16:52:47] it returns ["0"] for me [16:53:55] yeah... fixed with parseInt(). it's working now [16:55:15] Edokter: there is also apparently mw.echo.overlay.notificationCount [16:55:31] Edokter: about which i've accidentally learned yesterday, when Krenair mentioned it [16:55:46] i have no idea if it's reliable, but it exists [16:56:35] Why is this stuff not in the documentation? [16:57:03] no idea. is there even documentation? [16:57:36] http://www.mediawiki.org/wiki/Echo [16:58:37] so yeah, no documentation i can see. [16:59:15] it's probably internal [16:59:22] but why is it exposed, if so, i have no idea [16:59:33] probably because of designers writing code [17:05:55] There's also http://www.mediawiki.org/wiki/Extension:Echo but doesn't mention it either. [17:07:32] AAAH [17:07:34] Exception thrown by ext.gadget.Notification: Cannot read property 'overlay' of undefined [17:09:21] you'll probably need to wrap that in mw.loader.using [17:09:38] * MatmaRex_ is looking into logs [17:10:52] New review: Diederik; "Haha, so stupid that I didn't see it was php but a js file, yeah so totally ignore my remarks about ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [17:11:13] actually i have no idea where it was said [17:11:24] ask Krenair when he's online :( [17:12:09] my gadget triggers too early, back to reading html [17:12:31] test gadget available on enwiki [17:13:20] what is echos module name? [17:13:44] i have absolutely no idea [17:13:47] actually, let me check [17:14:06] oh my, there are at least four [17:14:30] ext.echo.base, ext.echo.overlay, ext.echo.special, ext.echo.icons [17:14:40] you probably want the overlay one [17:15:59] going to test one more time [17:19:23] I would suspect it would be mw.echo.overlay [17:24:00] that seems to work! [17:29:27] Nope, still exception, except in debug mode [17:31:05] New patchset: Nikerabbit; "Update statsbar when changing group" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62345 [17:31:59] Spoke too soon... working after all [17:31:59] cahing... [17:35:24] New review: Adamw; "Diederik, thanks for the good feedback!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [17:40:15] New review: Adamw; "Parent5446, I totally agree that this would be more appropriate in an extension. However, it is act..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [17:52:59] New review: Brion VIBBER; "Ok, it's not actually LilyPond that's outputting that bad SVGs -- it's ImageMagick, invoked for the ..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [17:56:31] MatmaRex_, Edokter: glad you guys figured it out :) [17:56:57] thanks [18:01:12] New patchset: Nikerabbit; "Load check warnings for fuzzy messages before user starts typing" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62346 [18:10:07] New patchset: Adamw; "Anonymous users do not have a permanent ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [18:10:32] all done [18:10:41] New review: Adamw; "PS4: improve docs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [18:22:38] New patchset: Adamw; "Anonymous users do not have a permanent ID" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [18:23:16] New review: Adamw; "PS5: make the code less readable in order to satisfy jslint :p" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [18:45:36] New review: Mattflaschen; "I am also inclined to put it in an extension, either EventLogging or another one." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53195 [18:48:11] New review: Mattflaschen; "Can you also rename "cheatCookie" to something like "sessionCookie". I assume "cheat" is a referenc..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [18:58:02] New review: Adamw; "Mattflaschen: well, the big question is what we do in core. You think we should do something like PS1?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [19:01:18] New review: Rjain; "Hi, there is already a patch submitted for this bug, you can upload a new patchset there or review i..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [19:55:09] New review: Mattflaschen; "Yes. I replied in more depth to the bug." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53195 [20:04:38] Project browsertests-en.wikipedia.org-linux-chrome build #39: FAILURE in 3 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/39/ [20:04:38] Project browsertests-en.wikipedia.org-linux-firefox build #41: FAILURE in 3 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/41/ [20:08:41] Yippie, build fixed! [20:08:41] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #40: FIXED in 4 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/40/ [20:25:44] New review: Yurik; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62229 [20:34:14] New review: Matmarex; "Here's some raw data: http://pastebin.com/FQTYaWh1 and the script I used: http://pastebin.com/Nsihuv..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [20:37:52] Nemo_bis: ^ [20:38:01] hm [20:38:40] that means a lot of local fixes to be made, unless we decide to throw them out [20:38:55] also, apparently those local help pages usually contain formatting help [20:38:58] unlike the mw.org one [20:39:49] yes, that's all pre-WikiEditor stuff [20:39:57] which is why ne link need change [20:40:32] killing local custom links is ok but not needed [20:41:34] Nemo_bis: the wikieditor help kind of sucks IMO [20:41:43] it's not discoverable well [20:41:53] i had no idea it was there for the longest time [20:42:15] help doesn't belong inside the editing toolbar :/ [20:42:57] New review: Nemo bis; "Most of those local links are to pre-WikiEditor stuff with cheatsheets now included in the toolbar, ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62337 [20:43:20] MatmaRex_: anyway it's too late, it's our best translated cheatsheet [20:43:37] and of course it's supposed to be superseded again, by VE :) [20:44:39] Nemo_bis: also, WikiEditor is not default, and there are people who are not using it (on Wikimedia wikis, too) [20:45:03] sure, but translating those cheatsheets is pointless [20:45:17] okay, but the link should still point to one [20:45:45] that help page on mw.org is kind of useless [20:46:10] I disagree, it has the basics :) [20:46:22] remember that 70 % of clickd to "edit" result in no saving [20:46:30] https://www.mediawiki.org/wiki/Help:Editing_pages really should include https://www.mediawiki.org/wiki/Help:Formatting [20:46:37] (the first section of https://www.mediawiki.org/wiki/Help:Formatting ) [20:46:54] no [20:48:24] yes. [20:48:39] too big, too scary, too obsoleted on too many wikis [20:49:07] I might change my mind if you manage to translate it via {{int:}} inclusion of WIkiEditor translations [20:50:08] the "Text formatting markup" *is* relevant [20:50:15] and personally i'd say crucial [20:50:19] nah [20:50:37] and WikiEditor has been bundled ages ago https://www.mediawiki.org/wiki/Suggestions_for_extensions_to_be_integrated#WikiEditor [20:51:59] oh, i just looked, and the WikiEditor help is showing parse errors. [20:52:07] niiice. [20:52:27] in what language? [20:52:37] in english. [20:52:40] the "Discussion" section [20:52:52] in every one, probably [20:53:00] heh [20:53:08] so that shows how often it's used [20:53:19] this is probably broken since the other jquerymsg problems happened [20:53:24] that was someti me in january, iirc [20:53:32] not really, it shows that newbies don't know how to report bugs :) [20:53:48] or that "wikitext = explosion" sounds SNAFU to people [21:24:07] MatmaRex_: I've asked Kaganer if he can help with the translation of the help page; if I forget and nothing happens, remind me [22:06:56] New review: Krinkle; "Duplicate of I815d3236c60c." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62338 [22:08:15] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [22:15:26] hello [22:33:01] Morning already, TimStarling. [22:33:16] hello [22:33:17] How's the weather tomorrow :) [22:33:19] New review: Tim Starling; "I don't understand why you would want to do this." [mediawiki/extensions/VipsScaler] (master) C: -2; - https://gerrit.wikimedia.org/r/62233 [22:34:25] Hey bryan is back [22:34:26] Aweesome [22:45:13] New patchset: Amire80; "Fixes for empty interlanguage links list" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/62402 [22:47:31] New patchset: Amire80; "Apply dir and lang to the target language selector trigger" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/62235 [23:04:42] Yippie, build fixed! [23:04:42] Project browsertests-en.wikipedia.org-linux-firefox build #42: FIXED in 3 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/42/ [23:04:43] Yippie, build fixed! [23:04:43] Project browsertests-en.wikipedia.org-linux-chrome build #40: FIXED in 3 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/40/ [23:05:36] timidity has NNTP support [23:07:59] like that joke about how any program eventually evolves into a mail client [23:14:23] New patchset: Aaron Schulz; "Revert "Remove Special:ActiveUsers"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58686 [23:21:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58686 [23:59:30] New review: Tim Starling; "It's possible to get the length with zero overhead. If you specify --trace to timidity then it will ..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181