[00:03:35] New review: Krinkle; "There is no module being created named "collapsibleTabs" or "vector.collapsibleTabs". Put the file i..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/55524 [00:10:54] New review: Krinkle; "The whole thing doesn't work:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [00:12:09] csteipp: are you currently the centralauth wizard? [00:12:59] awjr: Close enough [00:13:13] s/wizard/slave/ [00:13:18] hahaha [00:13:33] the way centralauth is currently configured appears to be preventing login to the mobile version of the site on commons and metawiki [00:13:58] As in mobile users can't login on those wikis? Or SUL isn't workin? [00:14:03] i've spent a little time poking around and can probably figure out a soluiton after much digging but thought i'd check with you and see if you have an idea [00:14:16] mobile users can't login on those wikis [00:14:36] more precisely, login appears to be successful at first, but there's no centralauth cookies generated for those domains [00:14:49] so on any subsequent action, they appear to be logged out [00:14:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=47647 [00:14:54] there's relevant bug ^ [00:15:24] most of the wikis get centralauth cookies set with domains like .wikipedia.org [00:15:44] New patchset: EBernhardson; "Link to the notifications FAQ from Preferences" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61888 [00:15:45] but that is not the case with commons and meta - they get cookies set with domains commons.wikimedia.org and meta.wikimedia.org respectively [00:16:12] for some reason, i dont see those cookies set when i login via meta.m.wikimedia.org, but even if they were set it wouldn't matter because of the domain mismatch [00:17:00] Yeah, the wikimedia.org domains are a little different, but they should have a SUL wiki... [00:18:32] csteipp: would it be sensible for me to move that bug from MObileFrontend to CentralAuth? [00:19:21] awjr: Since only mobile users are affected, it may still be a MF issue [00:19:45] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61888 [00:19:59] csteipp: i think it's because of how the domains are being handled - setting a cookie for .commons.wikimedia.org can't be handled by commons.m.wikimedia.org [00:20:49] Oh, so it is attempting to set the cookie? [00:21:27] Ah, rereading above. Yeah. [00:21:52] yeah, i think so; i need to dig more through CentralAuth code to see what's going on, but that's what it is looking like to me [00:21:56] New patchset: Wizardist; "(Bug 46742) SUBJECTSPACE converts spaces to underscores when no page name is given" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61936 [00:22:06] Gatcha. So we can't set the cookie at wikimedia.org, due to something about chapters owning other wikimedia subdomains. [00:22:15] ruhroh [00:22:27] hmm [00:22:52] So we would need to explicitely set the m.wikimedia.org cookie [00:23:37] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61937 [00:24:01] csteipp: MF has a handy hook for allowing things to take actions when we first detect we should be displaying the mobile view; we could conceivably use that to override the cookie domain for commons and meta [00:24:38] If it can touch cookies, that would be the quickest way [00:24:56] The alternative is to give the extension a hook in centralauth to add domains [00:25:14] Which would be a little ugly... but probably doable. [00:25:29] that makes sense [00:25:37] im not sure if our hook fires early enough [00:25:42] but it might [00:25:47] New patchset: Luis Felipe Schenone; "Copied collapsibleTabs module from Vector ext. to Vector skin" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [00:26:04] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61938 [00:27:58] New review: Luis Felipe Schenone; "Damn, moved collapsibleTabs.js to modules/collapsibleTabs.js but forgot to update the ResourceLoader..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [00:29:27] I've got to run, but check and see if that works. Otherwise, like I said we can probably add a hook in centralauth to let MF muck with the domain names and reset those. [00:29:43] cool cool thanks csteipp [00:32:35] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [00:33:55] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61938 [00:34:43] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [00:38:14] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [00:40:02] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [00:40:48] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/61940 [00:46:44] New review: Krinkle; "There is no module being created named "collapsibleTabs" or "vector.collapsibleTabs". Put the file i..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/55524 [00:52:56] New patchset: Luis Felipe Schenone; "Copied collapsibleTabs module from Vector ext. to Vector skin" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [00:54:00] New review: Luis Felipe Schenone; "Thanks for your patience, I moved collapsibleTabs.js to the same directory as vector.js as you sugge..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [00:55:36] New review: MaxSem; "Meh, missed your Apr 29 comment. Let's abandon this for now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57220 [01:01:24] TimStarling: Hi, I'd like your opinion on a debug/logging matter. [01:01:48] Right now fatal errors (missing dependencies, files not existing) in resourceloader are written in a javascript comment in the load.php response [01:01:51] not anywhere else [01:01:53] I'm in a meeting atm, wait 10 mins or so [01:01:57] ok [01:02:17] I'm writing a commit locally that adds a bunch of calls to wfDebugLog( 'resourceloader', ... ) for these. [01:03:02] However my intention is to have a Jenkins job test for these errors (e.g. after making a request to a wiki page, e.g. during the qunit test), and then I realised that wouldn't work [01:03:11] since debug.log contains lots of stuff. not just errors [01:03:40] Is there an error.log for mediawiki? I can't find any. Or should we use php native error_log? It is used in 1 place in core. [01:04:05] (or trigger_error) [01:05:16] most common example: https://github.com/wikimedia/mediawiki-core/blob/master/includes/resourceloader/ResourceLoader.php#L793-L810 [01:11:24] greg-g: ping! [01:12:25] New patchset: Mattflaschen; "Set serializer to none, since we only store primitives." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61943 [01:16:40] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [01:18:00] New patchset: Mattflaschen; "Set serializer to none, since we only store primitives." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61943 [01:18:23] I think $wgDebugRawPage should only affect wfDebug(), not wfDebugLog() [01:18:35] Krinkle: would that solve your problem? [01:18:48] TimStarling: Partly, yes. [01:19:03] also I think wfDebugLog() should prefix its lines when it writes to $wgDebugLogFile [01:19:11] TimStarling: It would solve the problem of getting them without getting the usual stuff repeated. [01:19:43] TimStarling: However it doesn't (nor should) solve the problem of detecting resourceloader problems in Jenkins. [01:19:48] But that should be done by other means [01:20:47] Though I'm not sure exactly. I guess these errors are quite important (resourceloader will omit modules from responses against expectations of modules in the queue). [01:21:08] using trigger_error is fine, that is used in loads of places [01:21:16] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [01:21:37] what is the one place where error_log() is used? I don't see it [01:21:38] TimStarling: We aggregate those in production, right? [01:21:45] TimStarling: outside includes/ [01:21:51] languages I thik [01:22:10] warnings and notices will appear in the syslog [01:22:14] TimStarling: OK [01:22:17] which I suppose is what you want from error_log() anyway [01:22:24] Yeah [01:23:02] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [01:23:14] TimStarling: There's no categories for trigger_error though. Would be be bad to call both in some cases (not all, but the ones where it really is a warning type of thing). Or only one of them (wfDebugLog(resourceloader and trigger_error(WARNING [01:23:53] trigger_error() is more severe than wfDebugLog() [01:24:05] yeah [01:24:18] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [01:24:24] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61937 [01:24:30] partly because it's more likely to be in the developer's face, due to display_errors [01:25:01] TimStarling: Ai, now that's a problem. [01:25:10] TimStarling: load.php should stay valid javascript [01:25:16] which is why we catch these in the first place [01:25:22] New review: Mattflaschen; "This is up at http://toro.wmflabs.org/wiki/Special:GettingStarted for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [01:25:47] Though I guess it's fine since display_errors shouldn't be enabled if you care about that [01:25:55] (html will become invalid too) [01:26:05] you can use ini_set('display_errors', 'off') [01:26:14] sure (it's off by default) [01:26:41] Alrighty, trigger_error it is [01:29:32] TimStarling: I see the wfDebug*/wfError* functions have been touched a lot by you. Do you feel like doing this one? (wfDebugLog bypassing wfDebug's filter for "raw" requests) [01:29:40] New patchset: Adamw; "Amazon IPN listener" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [01:29:50] you can file a bug and assign it to me [01:30:34] because I have enough things to do right now that I will probably forget about it before I have time to do it, so that's the best way to get it done [01:31:14] k [01:31:17] since I check the list of bugs assigned to me regularly, and there's almost no bugs in it now [01:31:47] since we've stopped doing default assignees [01:35:21] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [01:35:37] New review: Mattflaschen; "See inline and patch set 7." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/60882 [01:36:56] TimStarling: done [01:38:05] TimStarling: btw, you don't happen to know why wikibugs (still in #mediawiki) isn't reporting any events? [01:41:43] I'll restart it [01:47:57] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [01:50:31] New review: Rasel160; "I think you are right Krinkle. Writing code to support small screens that doesn't work on older brow..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [01:54:36] TimStarling: Hm.. didn't go as expected? [01:56:41] curious [01:57:58] someone had broken the start script by setting the user's shell to /bin/false [01:58:41] it probably still won't work though, there's another issue [01:58:53] TimStarling: it started [01:58:58] New patchset: EBernhardson; "qqq docs for installer mysql warning" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61944 [02:00:21] New review: EBernhardson; "Follow up commit: https://gerrit.wikimedia.org/r/61944" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [02:03:41] New patchset: EBernhardson; "qqq docs for installer mysql warning" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61944 [02:04:54] yeah, but there's nothing in its log file since 01:22 [02:05:17] that is, its input file [02:05:31] weird [02:05:32] so it wouldn't have sent a message to IRC even if it was alive [02:05:38] Right [02:05:58] TimStarling: UTC [02:06:43] yes [02:07:09] oh... [02:07:20] actually not since 01:22 *yesterday* [02:07:42] root@mchenry:~# ll /var/wikibugs/wikibugs.log ; date [02:07:43] -rw-rw-r-- 1 root Debian-exim 37435642 2013-05-01 01:22 /var/wikibugs/wikibugs.log [02:07:43] Thu May 2 02:06:55 UTC 2013 [02:09:13] it runs as root? [02:09:56] the script that writes to that file runs as Debian-exim [02:10:03] presumably [02:10:50] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [02:11:56] Heh, yeah. It hasn't spoken in #mediawiki since my comment. [02:12:03] 2013-05-01 01:22:33 UTC [02:13:16] and /var/log/exim4/mainlog says that it hasn't sent any mails to wikibugs-irc since then [02:14:22] I thought http://lists.wikimedia.org/pipermail/toolserver-l/2013-May/006008.html was a pretty great e-mail. [02:17:42] ah yes, mail delivery to wikibugs-irc is disabled by mailman due to excessive bounces [02:18:58] quite a system, right? [02:19:09] bugzilla -> mailman -> exim -> wikibugs.pl -> ircecho [02:19:23] it's a wonder it works at all [02:21:25] didn't the bounce processing get killed one of the other times it broke? [02:22:05] fixed it [02:22:40] it didn't look disabled to me [02:26:32] New patchset: Cscott; "Update async, express/connect, optimist, and request packages." [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/61946 [02:26:35] New patchset: Cscott; "Update parsoid package.json, update domino to 1.0.11." [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/61947 [02:50:53] TimStarling: thx [02:52:53] New patchset: Rasel160; "(bug 27995) Added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [02:53:17] TimStarling: You'd think someone would've hacked UDP support into it by now. [02:53:51] is there any reason we don't look at the premade bz irc bots? [02:54:09] Bugzilla requires a root, not a shell user, as I recall. [02:54:20] So finding someone to investigate them is difficult. [02:54:29] Though there's now a test Bugzilla instance, so maybe that could be used. [02:55:02] There are a few good options. The mailing list parsing trick is neat, but it really would be nice to use something more stable/sane. [03:22:46] New review: Karim.rayani; "I ran the above feature (pdf_readonly) locally, and it gave an error as below. I think by default th..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61820 [03:30:03] Change merged: Tim Starling; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61943 [03:32:42] New patchset: Tim Starling; "GettingStarted: set serializer to none to avoid segfaults" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61948 [03:33:46] New patchset: Tim Starling; "GettingStarted: set serializer to none to avoid segfaults" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61949 [03:35:46] Change merged: Tim Starling; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61949 [03:38:33] Change abandoned: Mattflaschen; "It now says just "recent contributors" so no such change is necessary." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61068 [03:42:25] Change merged: Tim Starling; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61948 [03:46:06] New patchset: Mattflaschen; "Add note that wgActiveUserDays affects the NUMBEROFACTIVEUSERS magic word." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61951 [03:47:38] New review: Mattflaschen; "Trimmed down version of https://gerrit.wikimedia.org/r/#/c/61068/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61951 [04:33:34] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [04:47:32] New patchset: Cscott; "Parsoid: remove a bogus test from parsoid-parse-tool-check." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61955 [04:52:03] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [05:10:46] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [05:33:04] New patchset: Kaldari; "Allow mention notifications from project pages" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61957 [05:35:00] New patchset: Kaldari; "Allow mention notifications from project pages" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61957 [05:37:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61944 [05:39:46] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [06:01:53] New patchset: Pastakhov; "Refactoring and add the Debug View (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [06:10:50] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [06:16:43] hi i am intrested in doing the catagory redirects gsoc project [06:17:19] is there anyone around that I can talk to briefly about it? [06:22:24] Tobi__: the mentor for that particular person is 'Bawolff' on IRC. He's usually around during daytime hours, EST. Try in 12 hours, perhaps? [06:22:33] for that particular project, I mean [08:05:22] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [08:56:16] New patchset: Netbrain; "Refactored due to changes in spreadsheet-js Added a redraw timeout to highcharts as it turned out to be cpu consuming to redraw on every valuechange event" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61961 [08:56:33] New review: Physikerwelt; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [08:56:43] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61961 [09:01:28] New patchset: MaxSem; "Fix GeoData validation fail observed in the wild" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/61962 [09:02:18] anyone can review ^^^? it's kinda urgent:) [09:06:55] New review: Daniel Kinzler; "Objects work there? I suppose PHP would convert them to arrays implicitly, but... the parameters are..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [09:10:02] lololo [09:10:19] import is completely, utterly broken [09:10:48] for a week, two possible solutions are bikeshedded to death and beyond [09:13:49] New review: MaxSem; "Merging myself, it's urgent" [mediawiki/extensions/GeoData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61962 [09:14:08] Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/61962 [09:18:00] MaxSem: import is always broken, so why hurry? :) [09:18:19] did someone warn the Germans? they abuse import a lot [09:18:36] yeahhhh! we're not Apple after all [09:23:32] MaxSem: you mean that we don't use FoxConn? [09:29:40] New patchset: MaxSem; "Update GeoData to grab https://gerrit.wikimedia.org/r/61962" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61965 [09:30:29] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61965 [09:42:45] New patchset: MaxSem; "Update Zero" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61966 [09:44:48] New patchset: MaxSem; "Update Zero" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61968 [09:46:34] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61966 [09:46:53] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61968 [10:04:12] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [10:15:17] New review: Physikerwelt; "I can not decide if it is right, since I don't know the command \bold and it is not documented here" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61284 [10:17:34] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61785 [11:29:25] New patchset: Nikerabbit; "Don't add 'suppress' to $wgLogTypes" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61795 [11:30:07] New review: Nikerabbit; "See https://gerrit.wikimedia.org/r/#/c/61798/" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61795 [11:30:49] New review: Nikerabbit; "...which was abandoned already." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61795 [11:53:46] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/57930 [12:07:40] New review: Daniel Kinzler; "After looking at If44292fedf, it seems that the hook calls in Import.php were simply broken - it's n..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/61925 [12:24:47] New review: Daniel Kinzler; "Seems good to go. Would give it a +2 but don't want to override Krinkle's comment about the commit m..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61064 [12:36:59] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61795 [12:42:21] New patchset: Mwjames; "Extend SMW\SpecialsTest" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [12:54:25] New review: Foxtrott; "The patch does not fix the bug." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [13:04:12] New patchset: Daniel Kinzler; "Support langlinks from hooks in ApiQueryLangLinks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60034 [13:26:09] New patchset: Parent5446; "Fix incorrect wfRunHooks usage in XML import." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [13:37:53] New patchset: Krinkle; "Fix incorrect wfRunHooks usage in XML import" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [13:48:31] New review: Nikerabbit; "No svg versions of the images?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61939 [14:24:14] New patchset: Cscott; "Add @since field to Special:Redirect and add a release note." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61982 [14:25:26] New review: Cscott; "@Nikerabbit: added @since in https://gerrit.wikimedia.org/r/61982" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [14:26:12] New patchset: Cscott; "Add @since field to Special:Redirect and add a release note." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61982 [14:28:00] New patchset: Ganeshaditya1; "Removed tag from special:preferences page inside success section" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59822 [14:28:52] New review: Physikerwelt; "Any further comments?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [14:30:29] Change abandoned: Demon; "Let's use the approach in If44292fedf rather than duplicating efforts." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [14:31:17] New review: Demon; "Whoops, meant If44292fedf...copy+paste fail." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [14:41:09] New patchset: Oantnri; "Optimisation of method WordLevelDiff._split()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [14:47:44] New review: Matmarex; "Thank you, looks great :)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59822 [14:53:34] New review: Matmarex; "Fine with me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61896 [14:53:57] New review: Anomie; "> Need someone to read over the english help text. Feel free" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [14:54:06] New patchset: Anomie; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [14:54:23] New patchset: Physikerwelt; "Draft: Merge LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [14:54:30] New review: Matmarex; "Dammit, Opera Mobile is a completely different thing than Opera Mini, stop confusing them :/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [14:54:52] New review: Cscott; "(and just for the record, the 'extensibility' I was referring to was namespace extensibility -- the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [14:55:16] New patchset: Physikerwelt; "Draft: Merge LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [14:56:26] New review: Anomie; "Code looks good to me. Not giving +2 because I'd like someone to review my changes to the help messa..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61817 [14:59:30] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61982 [15:11:40] New patchset: Jdlrobson; "Make CentralNotice device aware" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61988 [15:16:42] mwalker|away: really delayed pong [15:17:43] New review: Nikerabbit; "Jenkins slow today?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61982 [15:18:10] hashar: Can you fill me in [15:19:36] New patchset: Krinkle; "SpecialRedirect: Add @since documentation and add release notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61982 [15:20:13] New review: Krinkle; "re-trigger gerrit event for patch submission. Jenkins was restarted earlier today. The deamon might'..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61982 [15:20:56] Krinkle: do you mean introducing you to OpenStack people? [15:21:09] hashar: no [15:21:19] hashar: the situation here [15:21:30] well it is quiet isn't it ? [15:22:15] hashar: I'd like to do a ci triage soon. Preferably today. next week would work too [15:22:33] going through all open bugs and discussion what to do, what we plan in the short term, what we're working on [15:23:00] things have appeared a bit ad-hoc lately (nobody to blame but myself0 [15:29:19] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [15:30:31] hashar: something is going insanely slow [15:30:33] hashar: https://integration.wikimedia.org/zuul/ [15:30:40] '61982,3' [15:30:47] what is the queue waiting for? [15:30:50] jenkins is doing nothing [15:30:59] it is not in https://integration.wikimedia.org/ci/ [15:31:07] exactly [15:31:21] I guess Zuul will find out the build is lost eventually [15:31:37] is it lost? [15:32:19] New review: Umherirrender; "Thanks for your help, Anomie!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [15:36:53] Hi, i'm searching for a bureaucrat on testwiki. If you are one, please go to the user-renames there and rename/attach my unattached ghost acc :-) [15:37:54] se4598: If you want help you'll need to be more detailed than that. [15:38:00] what accounts? [15:38:41] New patchset: Reedy; "Add archive, externallinks PK" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51675 [15:38:50] Or put on https://test.wikipedia.org/wiki/Wikipedia:Requests/Renames [15:39:22] Krinkle: my automatically created but unattached gosth acc on testwiki, see https://test.wikipedia.org/wiki/Wikipedia:Requests/Renames [15:39:27] New patchset: Reedy; "Create maintenance script to populate archive.ar_len" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [15:40:31] New patchset: Reedy; "Create maintenance script to populate archive.ar_len" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [15:40:44] se4598: ok (I'm not a bureaucrat btw) [15:41:01] se4598: Ah, I am [15:43:53] New patchset: Reedy; "Remove Parser_LinkHooks and CoreLinkFunctions classes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/50774 [15:47:12] se4598: Hi again [15:47:25] se4598: So the existing account 'Se4598' on testwiki, is not yours? [15:47:29] (you can't log into it) [15:48:12] Krinkle: it's unattached but automatically created, so it has no email and no password I can you (there are some bugs about this) [15:48:57] se4598: Interesting, a bug that is now fixed I presume? [15:49:48] se4598: Can you trigger a password forget for the testwiki account? [15:50:00] New patchset: Matthias Mullie; "Casting lottery to int makes it impossible to have e.g. 0.1 lottery size (which dewiki has)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61001 [15:51:19] as I said theres no mail or something set for this sort of accs; https://bugzilla.wikimedia.org/show_bug.cgi?id=39996 and others should be the matching bug [15:52:17] New patchset: Reedy; "* Add --smw option for packaging Semantic Bundle" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/28958 [15:52:24] se4598: I can set an e-mailaddress [15:52:27] New patchset: Reedy; "refactor a bit and add support for .tarignore" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/28956 [15:52:35] New patchset: Reedy; "* Add --smw option for packaging Semantic Bundle" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/28958 [15:52:49] se4598: It is empty indeed [15:54:12] Krinkle: so what do you want now, just rename it or do you need my email? [15:54:32] I'm going to import the email from the mail SUL account [15:57:30] se4598: Try now, account se4598 on testwiki, forget password [15:57:36] you should get an email [15:57:47] and then you can Special:MergeAccount as usual [16:00:26] Krinkle: Thanks, I could merged it: http://toolserver.org/~quentinv57/sulinfo/Se4598 [16:01:57] se4598: great [16:05:32] New patchset: Reedy; "Fix eol-style" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/61992 [16:06:05] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/61992 [16:12:43] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [16:12:53] ori-l: https://gerrit.wikimedia.org/r/#/c/60254/ [16:20:33] New review: Matmarex; "Also, if you decide this is the way to go, then please merge it quickly and backport to appropriate ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61896 [16:26:46] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/57930 [16:34:12] greg-g: I was just poking you yesterday to see if there was anyone doing anything that would prevent me from touching and syncing a couple of files [16:34:21] but kaldari and I sorted it out [16:35:05] New review: EBernhardson; "I'll see if i can track down any svg copies of these images. Not wanting to make anything new we lo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [16:35:14] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [16:35:42] New patchset: Krinkle; "XML Import: Fix incorrect wfRunHooks usage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [16:36:06] New patchset: Nikerabbit; "ULS to master to pick up fix for web fonts" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61996 [16:36:16] New review: Umherirrender; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [16:36:29] hashar: Any suggestions for how to bring apache/php error log into the build environment? [16:36:47] Chmod differently from puppet? Or configure that vhost to put it somewhere else? [16:36:59] we should probably isolate it anyway [16:37:11] to avoid false positives from integration.wikimedia.org requests [16:37:43] mwalker: whew :) [16:39:57] Krinkle: hmm I don't see 61996 in zuul anywhere [16:40:27] Nikerabbit: 'Queue lengths: 50 events, 14 results.' [16:40:34] It isn't processed yet [16:40:35] Krinkle: I got patches waiting for review to change the apaches logs [16:40:41] hashar: link? [16:40:44] hashar: I'm about to do the same [16:41:04] Krinkle: https://gerrit.wikimedia.org/r/#/c/61195/ [16:41:06] Krinkle: ah so it actually shows what's in process [16:41:22] Krinkle: that split the doc / integration / qunit log files to different place. [16:41:24] s [16:41:43] Nikerabbit: It doesn't yet know what the others will do. They might be cancelled before they start building. [16:44:29] New patchset: Oantnri; "Optimisation of method WordLevelDiff._split()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [16:45:27] hashar: I'd do it differently: Move to /srv for qunit [16:45:32] so it can read/reset them [16:45:41] for php warning checking [16:46:17] New review: Oantnri; "Spacing fixed" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61983 [16:46:47] I am off [16:47:01] hashar: Regarding triage? [16:49:18] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61996 [16:50:02] New review: EBernhardson; "Depends on I9670ecdc2cb553df07ee06e3b83b003382471d27 in core" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [17:01:09] New patchset: Alex Monk; "Fix API in XML format" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61998 [17:15:54] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61817 [17:22:11] New review: EBernhardson; "In regards to the images, we dont have any svg's of them but i suppose we could ask one of the desig..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [17:22:13] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [17:38:07] Emergency restart of Jenkins (see -operations and wikisal for more info) [17:47:51] Change merged: Raimond Spekking; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/60881 [17:54:40] New review: Andrew Bogott; "retest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [17:54:51] New review: Andrew Bogott; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [17:57:43] New patchset: Bsitu; "(bug 48011) notlimit parameter does not accept "max" as a value" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62003 [17:57:54] hm, where is jenkins-bot... [18:00:17] New patchset: Reedy; "Add AccountAudit table to new wikis" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/62004 [18:00:25] Krenair: currently down, i think [18:00:35] Krenair: https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:00:59] I was waiting for a merge at https://gerrit.wikimedia.org/r/#/c/61957/ [18:01:01] Krenair: also, #-operations [18:01:17] i think that's where things are happening right now :) [18:01:19] Ah [18:01:24] I'll leave it for now then :) [18:02:49] * James_F grins at https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions&diff=0&oldid=677384 [18:06:20] New patchset: Krinkle; "Import: Fix incorrect wfRunHooks usage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [18:06:37] New review: Krinkle; "Jenkins was being restarted. It missed a few minutes of events." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61064 [18:06:40] New patchset: Balloonguy; "(bug 40207) Make image pagination not require a page load" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [18:06:52] New patchset: Alex Monk; "Allow mention notifications from project pages" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61957 [18:07:11] New patchset: Krinkle; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [18:07:12] New review: Alex Monk; "Jenkins was restarting, retrying" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/61957 [18:08:27] fyi all, see https://integration.wikimedia.org/zuul/ [18:08:37] there are currently 75 events waiting to be processed by Zuul [18:11:28] New review: Matmarex; "Also fixed bug 39237." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/54503 [18:17:42] New review: Alex Monk; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [18:24:10] New patchset: Krinkle; "DairikiDiff: Optimise method WordLevelDiff._split()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [18:25:21] New review: Krinkle; "A database query syntax error has occurred." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [18:25:25] New patchset: Alex Monk; "Fix API in XML format" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61998 [18:25:43] New patchset: Luis Felipe Schenone; "Replaced every HTMLFormField::flattenOptions for $this->flattenOptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62007 [18:32:02] New patchset: Alex Monk; "Fix API in XML format" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61998 [18:33:21] New patchset: Yaron Koren; "Version 0.4" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/62009 [18:37:07] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/62009 [18:44:47] New patchset: Kaldari; "Fix API in XML format" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61998 [18:45:50] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61998 [18:47:54] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61957 [18:49:42] New patchset: IAlex; "Add support for "tabindex" in HTMLFormField subclasses" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62014 [18:53:59] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62015 [18:54:16] New review: Umherirrender; "This is the correct way." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/62003 [18:55:53] New review: Umherirrender; "Error is known, see commit message (depends on Ib6b0fc37)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [18:57:03] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62016 [18:57:21] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/62015 [18:57:47] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/62016 [19:01:22] New patchset: Diederik; "Both the 'pager' and 'prompt' variable are part of the [mysql] section and not the [client] section. This causes mysqldump to fail" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/62018 [19:03:30] Change abandoned: Bsitu; "(no reason)" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61532 [19:03:47] Change abandoned: Bsitu; "(no reason)" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61533 [19:08:26] New patchset: Umherirrender; "Exclude external_user table in DatabaseSqliteTest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62019 [19:09:15] New review: Umherirrender; "Error is unrelated, because the remove of the "external_user" from tables.sql (I794338db) did not ad..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51675 [19:15:38] New review: Mattflaschen; "You haven't addressed my comment on the commit message." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/60882 [19:23:55] hello all and multichill :) [19:24:20] hi chippy, nice to see you here [19:24:30] Krinkle: and the jsduck job for core seems to be broken. The shell has some invalid lines [19:25:09] hashar: I have a tab open for it, but it took 2 hours before it was first run [19:25:41] I am tailing zuul debug log it is really active now [19:25:45] multichill, good to be here. Thanks for helping set everything up [19:26:09] Change merged: MaxSem; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [19:26:17] hashar: debug.log has always been active throughout this [19:26:23] I've tailed it since this afternoon [19:26:26] I'm happy to have you on board so we don't have to start from scratch! [19:26:32] hashar: fixing jsduck now [19:26:50] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [19:26:59] New patchset: Krinkle; "Add support for "tabindex" in HTMLFormField subclasses" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62014 [19:28:07] hashar: did you disable it? [19:28:24] Krinkle: hop, just looked at the conf history [19:28:25] fix pushed [19:28:43] chippy: Where was you code again? [19:28:54] hashar: hop? [19:29:00] hashar: It isn't running [19:29:03] multichill, https://github.com/timwaters/mapwarper [19:29:31] there's a slight revamp in the UI that is expected soon for the warper [19:30:11] basically, ruby on rails + geospatial libraries and Postgres/PostGIS required [19:30:39] ok. is it possible to switch languages? [19:31:30] it's theoretically possible! [19:31:52] i18n is a big thing in the Wikimedia universe [19:32:22] multichill, I thought you meant programming language - were asking if it could be written in Python or something [19:32:32] yes, multichill, it's quite easy to internationalise it [19:32:47] New patchset: Krinkle; "jsduck: Use new jsduck --color and --warnings-exit-nonzero option" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62023 [19:32:47] New patchset: Krinkle; "jsduck: Include branch information in footer" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62024 [19:33:23] Haha, ok. If we would ever reimplement it, it would probably be php (Mediawiki extension) [19:33:42] But we first need to get this up and running ;-) [19:33:51] hehe :) Yeah [19:36:53] chippy: Would be nice to have a first prototype running before https://www.mediawiki.org/wiki/Amsterdam_Hackathon_2013 [19:36:58] hashar: [19:38:28] multichill, yeah - I could probably do a vanilla install of it for then - It's a pity I can't make it to the hackathon - I'm going to be over in the states around then. [19:39:24] That's a bit in the wrong direction ;-) [19:39:40] the warper has a "digitizer" - a vector tracer tool, which some organisations have used to trace over the maps - would this be something within scope of the project? I'm envisaging a more wiki / osm approach to tracing [19:39:52] like what HOSM is doing [19:39:52] hashar: any idea why mediawiki-core-jsduck is not running on core? [19:40:19] Don't think that would be in scope. Presentation is key [19:40:27] okay. gotcha. that's good [19:40:41] It should not use local uploads, but just files from Commons. We would need a way to add files like https://commons.wikimedia.org/wiki/File:1730_Homann_Map_of_Scandinavia,_Norway,_Sweden,_Denmark,_Finland_and_the_Baltics_-_Geographicus_-_Scandinavia-homann-1730.jpg [19:40:51] What kind of information do you keep about an upload? [19:41:18] there is a batch upload feature - which imports maps from a local filesystem [19:41:38] the NYPL have their own system also - pulls the maps from their image system [19:41:48] so something could be written quite easily for this [19:42:10] or... an "upload from URL" could also work [19:42:37] You need the file to generate tiles, right? [19:43:16] yeah [19:44:16] New patchset: Parent5446; "Fixed classification of Tor nodes to only block exit nodes." [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/62025 [19:44:16] New patchset: Parent5446; "Cleaned up workflow for fetching nodes to use Status." [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/62026 [19:44:17] New patchset: Parent5446; "Added If-Modified-Since support to Onionoo loading." [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/62027 [19:44:22] Change abandoned: Parent5446; "https://gerrit.wikimedia.org/r/62025" [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/53917 [19:47:38] chippy: Nice talking to you, calling it a night, later! [19:47:52] multichill, sure thing. talk to you later. thanks again [19:48:30] New patchset: Parent5446; "Make image pagination not require a page load." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [19:55:08] Krinkle: https://gerrit.wikimedia.org/r/#/c/61898/ <— all good now? [19:55:45] Ryan_Lane: Yes [19:55:51] \o/ [19:55:54] Ryan_Lane: Though, did you figure out regarding width [19:56:30] Ryan_Lane: merge will take a while, Jenkins issues [19:57:00] Krinkle: no. you had mentioned you were going to look at wikitech-test [19:57:10] and that htmlform actually works as expected, right? [19:57:15] Yes [19:57:24] There should be no need to set a width with a custom class [19:57:25] it works fine [19:57:37] right, but chosen extends the length [19:57:39] not the width [19:57:49] "length" ? [19:57:56] of the select [19:57:58] err [19:57:59] sorry [19:58:00] height [19:58:10] That's not what I saw [19:58:21] it's definitely the case on wikitech-test [19:58:27] I saw it initiating at the width of placeholder or default value [19:58:33] right [19:58:34] and then expanding naturally as you add more values [19:58:36] but when you add values... [19:58:37] in width [19:58:49] width? really? the project filter extends height [19:58:58] Krinkle: so it seems Jenkins is more or less working now :-] [19:59:01] steps to reproduce? [19:59:16] hashar: seems so [19:59:30] go to: https://wikitech-test.wmflabs.org/wiki/Special:NovaInstance [19:59:38] add some projects to the filter [20:00:02] No Nova credentials found for your account. [20:00:14] due to the switch from nova-precise2 [20:00:17] wrong cookie [20:00:24] url switch, that is [20:00:29] logging out and in again [20:00:34] * Ryan_Lane nods [20:01:48] Ryan_Lane: http://cl.ly/image/18473d2H2836 [20:01:54] Ryan_Lane: no width: http://cl.ly/image/3r2M19440o1s [20:02:05] wtf [20:02:08] which browser is this? [20:02:12] chrome stable [20:02:12] that's not what it does for me [20:02:29] Ryan_Lane: I send the wrong link you misunderstand [20:02:39] yeah :) [20:02:49] Ryan_Lane: currently, with width: http://cl.ly/image/2W1r2z3j2X3G [20:03:01] ah. right [20:03:01] I disabled width in console: http://cl.ly/image/3r2M19440o1s [20:03:11] hm [20:03:13] if you don't force a width it works fine [20:03:26] I'm not forcing a width, though [20:03:36] where's that 173px coming from? [20:03:38] New review: Ori.livneh; "Thank you." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/62018 [20:03:44] good question. no clue [20:04:05] Ryan_Lane: found it: http://cl.ly/image/3O260a0p1Z2n [20:04:11] New review: GWicke; "Can you explain what this contrib repo is used for? We are using a different mechanism in production." [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/61946 [20:04:14] that's the width the original