[00:02:20] New patchset: Aaron Schulz; "[FileBackend] Added "adviseStat" option for the "listing followed by stat" case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [00:02:49] New review: Aaron Schulz; "Need to test with swift/ceph" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/61728 [00:13:00] New patchset: CSteipp; "SECURITY: Check SVG xml encoding against whitelist" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/61643 [00:13:20] New patchset: Mwalker; "(WIP) Rewrite the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [00:14:02] New patchset: Mwalker; "(WIP) Rewrite the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [00:16:46] New patchset: Mwalker; "Rewriting the CN UI (Part 1)" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [00:24:00] New patchset: Ori.livneh; "Add Puppet class for configuring qa/browsertests" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61729 [00:24:50] RoanKattouw: I *think* that was my last amend on this (tinytiny) bug fix. If your record is set by amend-count, I'll have to apply myself to another try. If you go by the code-size vs amend-count ratio, I may have just won. [00:25:44] New patchset: Adamw; "minor cleanup" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61730 [00:26:16] New patchset: Ori.livneh; "(Bug 46920) Add Puppet class for configuring qa/browsertests" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61729 [00:30:38] New patchset: Mwalker; "HTMLForm entity labels are now optional and escaped" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:31:44] RoanKattouw: can you do me a favour and review two htmlforms things? [00:35:51] New review: Mwalker; "No problems in theory -- but fix the test :)" [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/61724 [00:36:02] New patchset: Krinkle; "pipelines.test: Change from Verified+2 to Verified+1" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61720 [00:36:39] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61001 [00:43:43] mwalker: Sure [00:43:48] (Sorry for the late response) [00:43:49] Links? [00:44:10] RoanKattouw: yay! thanks :) https://gerrit.wikimedia.org/r/#/c/59063/ and https://gerrit.wikimedia.org/r/#/c/59439/ [00:45:54] is there any standard way of checking if a MW extension is loaded? or should I just pick one of the global classes/variables it creates and check isset()? [00:46:12] I think you can check through Special:Version [00:46:21] jgonera: class_exists usually [00:46:28] jgonera: You mean programatically? Yeah class_exists [00:47:33] so I just pick any of the classes created by the extension? [00:47:42] Pretty much [00:48:04] ok, I see, thanks [00:48:11] Picking an obviously named one [00:48:21] Rather than el random utility class it adds [00:48:37] at wikia we have global vars to enable/disable every extension and then we check those… [00:48:46] makes for a pretty big config file though. :) [00:48:59] And it makes the code then depend on wikia specific stuff [00:49:02] * Reedy barfs [00:49:26] if ( !class_exists( 'Bar' ) ) { die(); } is portablde [00:49:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [00:49:49] yeah, good point [00:50:33] Certainly more so if it's an extension other people may use [00:51:03] you could trawl through wgExtensionCredits as well to search for it :p [00:51:07] but that's also completely horrid [00:51:12] New review: Catrope; "Looks good, minor stuff" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59439 [00:51:31] mwalker: First one is merged, second one had two minor things [00:52:00] RoanKattouw: awesome! on it! [00:52:13] Reedy, Owyn: You know we do actually have a $wmg variable for most extensions, but the names don't always follow the same pattern [00:52:22] I know [00:52:22] (And the config file is >10k lines) [00:52:29] But it really isn't a valid fix to the problem [00:53:15] yeah, in some places, class_exists makes more sense [00:54:23] Using config variables in config is fine (which we do use). But we don't litter MW extensions with random $wm?gFOOBAR from InitialiseSettings [00:54:34] New patchset: Mwalker; "HTMLForm entity labels are now optional and escaped" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:54:46] True [00:55:06] I'll just stick to class_exists() ;) [00:59:11] Krinkle: It looks like something broke in the testextensions-master job? https://gerrit.wikimedia.org/r/#/c/60954/ [00:59:57] RoanKattouw: 'No tests executed!' [01:00:01] Yes [01:00:13] I mean, the extension doesn't have any tests as far as I'm aware... [01:00:58] Then that job should probably not be enabled [01:01:57] first run: https://gerrit.wikimedia.org/r/#/c/49536/ [01:02:07] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [01:02:49] !g I447ef7e681dcfd40774d5d4c85002b457681972c [01:02:49] https://gerrit.wikimedia.org/r/#q,I447ef7e681dcfd40774d5d4c85002b457681972c,n,z [01:02:53] https://github.com/wikimedia/integration-zuul-config/blame/master/layout.yaml [01:03:43] RoanKattouw: Has been broken since build 1: http://integration.mediawiki.org/ci/job/mwext-Gadgets-testextensions-master/1/console [01:03:55] but the only commits since feb 17 were i18n which overrides it [01:04:29] New review: Krinkle; "fixme: Gadgets doesn't have tests. The job has been failing since the first run on Feb 17, https://..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/49041 [01:05:31] fixing [01:06:02] RoanKattouw: It does have tests it seems [01:07:23] Hah [01:07:28] Then the job is broken in that it's not running it [01:07:32] *running thme [01:07:34] *them [01:07:42] Gah I can't type today, clearly I should just go home soon [01:09:24] They're not running when I try locall either [01:09:31] $ php tests/phpunit/phpunit.php ../extensions/Gadgets [01:09:34] 0 tests [01:09:35] weird [01:09:44] they are being registered in the UnitTestsList hook [01:14:35] RoanKattouw: Ah, it is working when I specify the full path [01:14:46] RoanKattouw: The file name isn't ending in "Test.php" so it doesn't find it [01:14:51] it'll run it when running the entire test suite [01:15:08] but when specifying a path (e.g. extensions/Gadgets) it will auto-discover Test.php files (ignoring the hook) [01:15:23] * Krinkle fixes [01:16:08] I see [01:16:08] Thanks [01:18:40] Published patchset: Tim Starling; "Use RedisConnectionPool" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61733 [01:20:41] New patchset: Krinkle; "tests: Rename file to end in Test.php" [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/61736 [01:20:46] RoanKattouw: ^ [01:20:57] New review: Tim Starling; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61733 [01:36:28] view the source on this puppy: http://info.cern.ch/hypertext/WWW/TheProject.html [01:42:16] New patchset: Aaron Schulz; "Reduced memory usage a bit for copyFileBackend.php with --missingonly." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61738 [01:48:19] Change merged: jenkins-bot; [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/61736 [01:48:30] New patchset: Krinkle; "Allow disabling of legacy gadgets (Mobile support)" [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/60954 [01:48:39] New review: Krinkle; "CR+2 per Catrope" [mediawiki/extensions/Gadgets] (master) C: 2; - https://gerrit.wikimedia.org/r/60954 [01:48:59] New review: Krinkle; "Fixed unit tests in a different commit. Rebasing." [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/60954 [01:49:06] Change merged: jenkins-bot; [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/60954 [01:53:23] New patchset: Aaron Schulz; "Added a --backoff option for syncFileBackend.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61739 [02:01:44] New review: Krinkle; "* Invalid call signature for .css()" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61289 [02:47:46] New review: Krinkle; "Fixed Gadgets in Iaa52a5eafdebf152." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/49041 [02:57:53] New patchset: Mwalker; "Some Simple Cleanup in the CN Controller" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61742 [03:00:32] New patchset: Aaron Schulz; "[JobQueue] Uses gzip on larger jobs in JobQueueRedis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61743 [03:01:51] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/61733 [03:02:45] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61733 [03:05:54] New patchset: Spage; "Message tweaks to new login and create acct forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61168 [03:07:00] New patchset: Spage; "Message tweaks to new login and create acct forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61168 [03:07:51] New review: Mattflaschen; "Are there also multiple Redis servers, or just multiple connections in the pool?" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61733 [03:08:09] New review: Spage; "Reason placeholder now used, and rebased." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61168 [03:09:29] New review: Ori.livneh; "> There is no dependency walking on the server" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [03:13:44] New review: Aaron Schulz; "This would have to be deployed all at once (still resulting in a few recycled jobs and some runJobs ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61743 [03:15:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61631 [03:15:35] New review: Ori.livneh; "> Are there also multiple Redis servers, or just multiple connections in the pool?" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61733 [03:30:16] New review: MZMcBride; "Platonides: do you have time to update this code accordingly?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53190 [03:46:41] Hello ! While creating wiki pages, how do we select categories ? Manually or does it recommends [03:47:46] djadmin22: You add them by linking to them - [[Category:Pages that mention Captain Picard out of context]] for example [03:50:55] There's a JavaScript gadget called "HotCat" that makes the process less painful. [03:58:51] hotcat rocks [04:16:05] New review: Spage; "LGTM, letting i18n review per Mattflaschen's comment." [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/61630 [04:20:24] Change abandoned: Spage; "We went with "NNN recent contributors", Ic3a9bf025cca338218a7dde2fe02d0409d3db2d5" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61165 [04:22:49] New review: Spage; "Regarding Siebrand's comment, MattFlaschen's Icbd1f7738197be061b8b9f12c45024902e3bb2b8 adds PLURAL s..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61246 [04:29:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61617 [04:47:42] New patchset: Aaron Schulz; "Made ProfileSection support multiple section names." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745 [05:02:55] New patchset: Mwjames; "SMW\AggregatablePrinter docs+" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61262 [05:08:19] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61262 [05:16:00] New patchset: Mattflaschen; "E3Experiments is no longer needed" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61747 [05:43:34] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61747 [06:12:02] New patchset: Jiabao; "This patch fixed Bug 47399 - say "you have successfully changed your password"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [06:39:19] New patchset: Mooeypoo; "Quickfix for the keyboard icon position in RTL languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61749 [06:41:51] New patchset: devunt; "Show message when user successfully changed password." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [06:46:53] New review: devunt; "PS2 improve commit message to keep guideline." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [07:06:28] New review: Siebrand; "Thanks for your contribution. This cannot be merged as such. You have made a change to a library tha..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2; - https://gerrit.wikimedia.org/r/61749 [07:08:12] New review: Mooeypoo; "Sorry about that. I'll move this to the proper library in github instead. Thanks!" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61749 [07:18:46] New patchset: Mwjames; "Test docs clean-up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61750 [07:21:51] New review: Amire80; "The code may be OK, and I can test it, but it must be submitted upstream in GitHub." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/61749 [07:21:58] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61750 [07:26:10] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [07:34:07] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [07:41:45] New patchset: Rasel160; "(bug 27995) Added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [07:48:01] New review: Vvv214wth; "I think these part should not be writen here" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61289 [07:51:40] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [07:53:17] New review: Rasel160; "thank you all for the feedback :) the width is now dynamically set(goes down all the way to 418px no..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [07:57:53] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [08:01:45] New patchset: Siebrand; "Update the reminder text" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61751 [08:07:00] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61751 [08:28:22] New patchset: Ori.livneh; "Apache: listen on both 80 & 8080." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61752 [08:28:44] New review: Rasel160; "cant test on IE due to an error only in IE, cant seem to find the solution. Please let me know if yo..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [08:29:35] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61752 [08:30:30] New review: Ori.livneh; "I fixed the port 80 / 8080 issue in change I6adfbb97f." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61729 [08:42:00] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [08:45:42] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [08:49:11] New review: Mattflaschen; "The latest patch set mostly focuses on logging, but there are some UX tweaks too (e.g. I removed the..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [08:56:36] New patchset: Mwjames; "Nicified smwgQEnabled handling in ask/show" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60623 [09:10:58] New patchset: Amire80; "Position the selector icon correctly in RTL languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61749 [09:17:22] New patchset: Mwjames; "Nicified smwgQEnabled handling in ask/show" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60623 [09:22:19] New review: Mwjames; "This doesn't change logic it just makes it easier to test for cases where smwgQEnabled is being disa..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/60623 [09:22:36] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60623 [10:02:58] New patchset: Physikerwelt; "problems with git permissions" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61756 [10:03:26] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61756 [10:12:52] New patchset: Luis Felipe Schenone; "Added the .DS_Store files to .gitignore" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/61757 [10:13:13] New review: TheDJ; "I found one more critical issue and one usability improvement that could be made." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50760 [10:14:07] New review: Luis Felipe Schenone; "This is a very minor change which I did both because it is helpful and because I'm learning and want..." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/61757 [10:14:48] New patchset: Mwjames; "More docs clean-up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61758 [10:14:49] New patchset: Physikerwelt; "new readme file" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61759 [10:18:08] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61758 [10:27:14] New patchset: Reedy; "Update ParserFunctions to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61760 [10:27:36] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61760 [10:28:58] New patchset: Siebrand; "Change "Add description" to "Add documentation"" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61761 [10:33:46] New review: Hashar; "I have done too much python recently. Next patch fix the whitespace and code conventions mistakes re..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61577 [10:34:01] New patchset: Hashar; "rebuildLocalisationCache: Implement --lang option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61577 [10:45:24] New review: Nemo bis; ""Language" name is "qqq - Message documentation" and naming consistency can't harm." [mediawiki/extensions/Translate] (master) C: 1; - https://gerrit.wikimedia.org/r/61761 [10:47:19] New review: Amire80; "(1 comment)" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61761 [10:49:58] New patchset: Siebrand; "Change "description" to "documentation"" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61761 [10:54:40] New patchset: Hydriz; "Adding Wikivoyage to the list." [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/61763 [10:58:11] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/61763 [11:18:13] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [11:23:29] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61761 [11:27:08] New patchset: Mwjames; "Add SMW\StatisticsAggregator class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [11:27:39] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [11:35:19] New patchset: Siebrand; "Shorten extension description and remove punctuation" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61766 [11:41:00] yikes, Echo broke notifications for anons ? [11:47:27] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61761 [12:15:01] @notify superm401 [12:15:01] You already requested this user to be watched [12:15:18] superm401, hello [12:17:23] I suspect he won't be about for 4 hours or so [12:23:04] thanks Reedy :) [12:53:31] New patchset: Mwjames; "SMW\Subobject clean-up constructor, eliminate ContextSource dependency" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [12:56:47] anomie: Hello [12:57:25] hi prageck [12:58:37] anomie: regarding this bugfix https://gerrit.wikimedia.org/r/#/c/61602/, I was not able to get what you were pointing out [12:58:43] in which case would it break ? [13:04:06] If the edit summary is "/* foo [[bar]] */ baz", it will try to have nested links. If Linker::formatComment() is called without a title, it will throw away the autocomment. If somehow or other $sectionTitle is null, you'll throw away the autocomment. Then there are the potential formatting issues with omitting the directional mark or the dir="auto" wrapper. And it looks strange to me for the linked text to be "foo bar: ", rather than just "foo bar" [13:04:07] or even "foo bar:". [13:05:29] And personally, "→" doesn't seem particularly tiny to me in the usual font. [13:09:17] anomie: we can move the colon out of the link [13:17:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61577 [13:20:28] New review: J; "this would only be needed for failed transcodes. missing transcodes get added automatically." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57286 [13:21:03] New patchset: Amire80; "Add a MediaWiki preference for enabling ULS IME" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [13:21:05] anomie: So should we keep the link as "→" only or we can fix the above issues you mentioned ? [13:22:41] prageck: The first one (nested links) will be difficult to fix, without throwing away the ability to have links in the autocomment portion. [13:23:37] New review: Siebrand; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/61770 [13:25:52] New patchset: Amire80; "Add a MediaWiki preference for enabling ULS IME" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [13:28:25] New review: Siebrand; "Nice work. Thanks." [mediawiki/extensions/Cite] (master) C: 2; - https://gerrit.wikimedia.org/r/61634 [13:28:36] Change merged: jenkins-bot; [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/61634 [13:31:35] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [13:32:29] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [13:32:57] New patchset: Yaron Koren; "Fixed newFromPage() to work again for both page names and Title objects" [mediawiki/extensions/AdminLinks] (master) - https://gerrit.wikimedia.org/r/61771 [13:36:17] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61759 [13:40:06] New patchset: Amire80; "Add a MediaWiki preference for enabling ULS IME" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [13:40:14] Change merged: Yaron Koren; [mediawiki/extensions/AdminLinks] (master) - https://gerrit.wikimedia.org/r/61771 [13:41:28] New patchset: Mwjames; "(Bug 47927) $concept->getCacheStatus()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61774 [13:41:51] New patchset: J; "add maintenance script to retry failed transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [13:43:47] New review: Mwjames; "This happens when you don't have a unit test but this file is a mess so making it sane requires som..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/61774 [13:44:01] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61774 [13:47:23] New review: TheDJ; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [13:49:39] New patchset: Mwjames; "SMW\Subobject clean-up constructor, eliminate ContextSource dependency" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [13:52:48] anomie: I tried what you are pointing out, when having nested links, the autocomment part ends as soon as it encounters a nested link [13:54:14] prageck: Either thanks to tidy or your browser's interpretation of the tag soup. Either way, it's still broken. And having the first bit of the autocomment linking to one place, then the second with no intervening space linking somewhere else, and then possibly a third not linking at all, is even more strange behavior. [13:56:40] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [14:00:04] anomie: Change the status of the bug as WONTFIX maybe ? [14:03:08] New review: IAlex; "Please do not create a form for the unique purpose to redirecting the user back to Special:Preferenc..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61748 [14:38:57] New review: J; "would adding a memcache call in getLength be good enough?" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [14:50:24] New patchset: Danny B.; "i18n/cs: Adding Wikivoyage and Wikidata." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/61779 [14:59:21] New review: Siebrand; "This will be in 1.22wmf4." [mediawiki/extensions/WikimediaMessages] (master) C: 2; - https://gerrit.wikimedia.org/r/61779 [14:59:31] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/61779 [15:11:04] New patchset: Ottomata; "user_metrics module changes:" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61781 [15:16:08] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/61468 [15:16:35] New patchset: Ottomata; "user_metrics module changes:" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61781 [15:32:07] New review: Siebrand; "I've tested this, and I suspect this is suffering from reversed login. When I select "Enable" my IME..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/61770 [15:32:21] New review: Siebrand; "login = logic ;)." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [15:41:05] New patchset: Ganeshaditya1; "Removed tag from special:preferences page inside success section" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59822 [15:42:40] New patchset: Andrew Bogott; "Search for projects using ldap_list, part two." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61783 [15:45:05] New patchset: Ganeshaditya1; "Removed tag from special:preferences page inside success section" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59822 [15:50:05] New review: Ganeshaditya1; "@matmarex Sorry man, SSH and FTP is blocked in my university and I had semester exam so I couldnt co..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59822 [15:50:07] New review: coren; "Straightforward." [mediawiki/extensions/OpenStackManager] (master) C: 2; - https://gerrit.wikimedia.org/r/61783 [15:50:18] New review: coren; "Straightforward." [mediawiki/extensions/OpenStackManager] (master); V: 2 - https://gerrit.wikimedia.org/r/61783 [15:50:18] Change merged: coren; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61783 [15:51:32] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [15:59:04] New patchset: Amire80; "Position the selector icon correctly in RTL languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61749 [16:06:55] New review: Amire80; "The patch was merged upstream." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61749 [16:16:57] New patchset: Yaron Koren; "Added "titles=" parameter for Special:ViewXML, in the manner of the MW API" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61784 [16:17:24] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61781 [16:18:18] New patchset: Raimond Spekking; "Fix encoding to UTF-8" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/61785 [16:19:52] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61784 [16:20:34] New review: Ganeshaditya1; "Damn I forgot about the space in shared.css I will change it in 12 hours from now, like in the morni..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59822 [16:22:20] New patchset: Parent5446; "Added hook to override Title::checkQuickPermissions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52910 [16:24:10] New patchset: Kipcool; "Added add Annotation to OmegaWiki API" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/57236 [16:29:09] New patchset: Yaron Koren; "New version: 0.1.8" [mediawiki/extensions/AdminLinks] (master) - https://gerrit.wikimedia.org/r/61786 [16:32:19] New patchset: Andrew Bogott; "Allow any project member to create a service group." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61788 [16:34:05] Change merged: Yaron Koren; [mediawiki/extensions/AdminLinks] (master) - https://gerrit.wikimedia.org/r/61786 [16:35:29] New review: coren; "Simple change." [mediawiki/extensions/OpenStackManager] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61788 [16:35:29] Change merged: coren; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61788 [16:39:22] New patchset: Kipcool; "Added add Annotation to OmegaWiki API" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/57236 [16:39:49] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/57236 [16:46:43] New patchset: MaxSem; "Fix XML import" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [16:58:11] New patchset: Ori.livneh; "Declare mediawiki.api as dependency for ext.openstack module" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61790 [16:58:49] New patchset: Kaldari; "Making sure IP users get orange bar notificaitons" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61791 [16:59:43] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61790 [17:03:41] New patchset: Arrbee; "Test scenarios for the buttons in the editing area of Translate UX" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61792 [17:11:22] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61791 [17:18:24] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61794 [17:20:07] New patchset: Petr Onderka; "Don't add 'suppress' to $wgLogTypes" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61795 [17:27:53] New patchset: Matthias Mullie; "WIP - Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [17:28:42] New review: Lwelling; "+1" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61791 [17:30:11] New patchset: CSteipp; "SECURITY: Check SVG xml encoding against whitelist" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/61643 [17:31:00] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61794 [17:35:46] New patchset: Reedy; "$wgLogTypes contains "suppress" twice on enwiki" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61798 [17:36:14] Change abandoned: Reedy; "Dupe" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61798 [17:44:44] ori-l: I've read your documentation text at https://gerrit.wikimedia.org/r/#/c/56762/ and I'm not sure what it is but it seems like it is saying everything right and yet saying nothing about how/what mw.hooks is to be used [17:44:49] New review: Adamw; "There is only one hard blocker:" [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/57090 [17:45:13] It is describing the principle of hooks in general. [17:47:03] New review: CSteipp; "Verified that JS is working fine with Special:JavaScriptTest/qunit" [mediawiki/core] (REL1_20); V: 2 - https://gerrit.wikimedia.org/r/61643 [17:47:06] ori-l: I was under the impression you were looking for documentation that ensures people don't misuse it the way you originally thought of it. [17:47:31] e.g. don't pass data that is only temporarily relevant [17:47:33] New patchset: CSteipp; "SECURITY: Check SVG xml encoding against whitelist" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/61643 [18:00:56] New review: Hashar; "Good catch! ;-)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61613 [18:01:01] New review: Pgehres; "I haven't tested the mobile detection code since I don't have and have no need for a mobile testing ..." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [18:02:01] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [18:02:13] New review: Nischayn22; "If you append the URL with debug=true maybe you get a better error." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [18:02:46] New review: Ori.livneh; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [18:03:53] siebrand, hi am I in the right hangout (alone)? [18:04:02] qgil: http://hexm.de/i18n [18:12:11] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61613 [18:15:41] New patchset: Aude; "Update Wikibase, DataValues and Diff" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61807 [18:16:27] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61807 [18:30:44] New review: CSteipp; "Untested, but the concept seems like a good idea, and should be safe. This could potentially help wi..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/52910 [18:35:14] New review: CSteipp; "(1 comment)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [18:36:25] New review: Hashar; "Added Aaron who is File* expert :-D" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [18:42:56] New review: Pgehres; "(1 comment)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [19:05:01] New patchset: Foxtrott; "fix bug 47150 (sfEditFormPreloadText no longer works as it used to)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/61815 [19:08:05] New patchset: Krinkle; "Add TitleQuickPermissions hook to Title::checkQuickPermissions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52910 [19:22:23] New patchset: Mwalker; "Rewriting the CN UI (Part 1)" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [19:24:36] Change merged: jenkins-bot; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/60012 [19:24:53] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [19:25:21] New review: CSteipp; "(1 comment)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [19:26:07] So what's the url going to be of the big data talk? [19:26:55] Change merged: jenkins-bot; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/57930 [19:29:34] New patchset: Bsitu; "(bug 47910) Minor edit should not trigger talk page notif" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61819 [19:30:01] hey, will there be a tech talk streaming? [19:30:17] MaxSem: i was just trying to find out; chip isn't in today [19:30:24] so possibly not [19:30:49] can we haz hangouts then? [19:31:29] dschoon: ^ [19:31:44] yesss [19:31:45] setting up! [19:31:46] 1 min [19:31:59] https://plus.google.com/hangouts/_/2882d0856d6408c26231c81f1429d86652288477?authuser=0&hl=en [19:33:04] does that work? [19:33:42] youtube: http://youtu.be/0csFRllZ2Lw [19:33:50] i uninstalled the google voice and video plug-in by accident so fixing that [19:33:57] can someone check that link [19:33:59] the youtube one [19:34:03] and see what one sees? [19:34:17] This live event will begin in a few moments. [19:34:19] New patchset: Mwalker; "Always log campaign changes with full details." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61724 [19:35:10] here we go! [19:35:35] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [19:35:51] can you hear / view? [19:36:05] i can hear but there doesn't seem to be anything to see [19:36:19] ah slides [19:36:21] Wikimedia alnalytics screen? [19:36:22] i can see those [19:36:26] yes [19:36:59] ok, I can take questions. Please ping me [19:37:10] youtube: http://youtu.be/0csFRllZ2Lw [19:37:14] thanks qgil_ [19:39:54] That's sad :P [19:40:04] (we're on #wikimedia-office for IRC participation, right?) [19:40:20] Just when I thought I was going to get everyone's IP [19:40:26] New patchset: Cmcmahon; "changed to clear cookies before loading RandomPage so PDF link is always visible; don't click the Print/export expand/collapse thing at all, put that in a different test; removed Print/export element from RandomPage since it is not needed; removed unneces" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61820 [19:40:43] bawolff: Here according to the invite [19:40:59] Who is talking by the way? [19:41:21] https://www.mediawiki.org/wiki/Meetings/2013-05-01 [19:41:52] multichill: david schoonover [19:42:21] Ok, wasn't sure because he was listed as moderator.... [19:42:38] lol [19:42:53] New review: Anomie; "Can this not reuse the code in ApiQueryAllLinks, as list=alllinks and list=alltransclusions already do?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61817 [19:42:59] i do! [19:43:00] 4/18 [19:43:05] Me to! [19:43:09] 04/1 [19:43:53] New patchset: Mwalker; "Always log campaign changes with full details." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61724 [19:45:03] Question: Will the eventual evil plans to switch to https (if they actually happen) which doesn't have referrer headers (AFAIK) mess up analytics team plans for stats on referrer headers [19:45:28] ok but ping me next time pls [19:46:09] bawolff: HTTPS sends referrers if you're navigating to an HTTPS target [19:47:14] New patchset: Foxtrott; "fixing the version reported by the extension" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/61821 [19:48:37] Change merged: Foxtrott; [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/61821 [19:48:40] bawolff, do you keep the question or has ori-l answered? [19:49:08] ori-l answered, I thought https killed the header, but guess not [19:50:16] SSL Killed the Referrer Headers (sung to the tune of "Video Killed the Radio Star") [19:50:31] New patchset: Mwalker; "Always log campaign changes with full details." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61724 [19:51:06] fyi still here :) [19:51:21] New review: Mwalker; "Now that the test passes..." [mediawiki/extensions/CentralNotice] (master) C: 2; - https://gerrit.wikimedia.org/r/61724 [19:51:21] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61724 [19:51:39] New patchset: Mwalker; "Repair campaign logs" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61726 [19:52:08] New patchset: Mwalker; "minor cleanup" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61730 [19:52:20] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61726 [19:53:05] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/61730 [19:55:00] dschoon: Most viewed image [19:55:31] New patchset: Cmcmahon; "refactor PDF test" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61820 [19:56:17] Just in general [19:56:28] Say for example on the 3th of April [19:56:54] *30th april, Wikipedia [19:57:11] New review: Umherirrender; "Bug number in my previous comment should be bug 32387." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47225 [19:57:14] man :) [19:57:36] starts with 'http://en.wikipedia.org/wiki/File:' [19:57:56] No images, not imagepages [19:58:11] ah, right [19:58:28] i think multichill's idea is better [19:58:33] New review: Cmcmahon; "* Don't click the Print/export because that makes the PDF link invisible. Put that into a separate ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61820 [19:59:17] New patchset: Aaron Schulz; "[FileBackend] Added "adviseStat" option for the "listing followed by stat" case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [19:59:25] dschoon: No https://upload.wikimedia.org/wikipedia/commons/thumb/ [19:59:51] dschoon: The file: is incorrect, I don't care about file pages, I care about the files [20:00:00] So it should something like https://upload.wikimedia.org/ [20:00:01] New review: Aaron Schulz; "Fixed silly bug after testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61728 [20:02:12] New review: Adamw; "1) the banner list is still broken when js fails, 2) a glitch with saving banner messages, I am seei..." [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/57090 [20:03:12] New review: Umherirrender; "Than it will need some namespace adjustments like imageusage has in ApiQueryBacklinks. The database ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [20:03:43] (a serial killer, apparently) [20:04:59] dschoon: Nice! Can you pastebin the result, can't read it on youtube [20:05:28] this is extremely cool, by the way [20:05:38] New patchset: CSteipp; "Force tar format to gnu" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/61823 [20:05:43] http://upload.wikimedia.org/wikipedia/en/thumb/8/8b/Adrian_Boult_signature.svg/175px-Adrian_Boult_signature.svg.png [20:05:49] i mentioned this earlier, but it's worth repeating: i'm especially impressed by how expressive and clear the queries are [20:05:51] ty [20:06:10] http://upload.wikimedia.org/wikipedia/en/thumb/2/2a/Aleppo-Great-mosque-Alp_%28cropped%29.jpg/67px-Aleppo-Great-mosque-Alp_%28cropped%29.jpg [20:06:16] ori-l: Yeah, this is really powerful [20:06:56] http://upload.wikimedia.org/wikipedia/commons/thumb/2/22/Heckert_GNU_white.svg/64px-Heckert_GNU_white.svg.png [20:07:06] dschoon: You could add a constraint on the file size so you only get "real" images [20:07:17] Say a minimum of 200K [20:07:43] The GLAM people will go insane if you have things like this [20:07:44] New review: Cmcmahon; "Very neat. I think there is room for refinement (for example, grab a subset of browser tests releva..." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/61729 [20:08:20] Yes, add response_size [20:08:48] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [20:09:38] hoi drdee [20:09:42] hey [20:09:48] Die demo is erg leuk! [20:09:57] Zou graag los gaan op NRA dataset op dat systeem ;-) [20:10:01] good to hear! [20:10:08] uhm NARA [20:10:11] on the roadmap! [20:10:31] we are not yet storing web request data for upload [20:10:36] at least not unsampled [20:10:47] we still have the sampled logs, those we could query [20:11:03] Is it in Hadoop? [20:11:07] yup [20:11:24] nice :-) [20:11:31] qgil_: for people that are not familiar with map/reduce, i think it would be cool for dschoon to explain briefly how that query actually gets executed, it's impressive [20:13:28] dschoon: Everything on Wikipedia is a thumb [20:13:58] https://upload.wikimedia.org/wikipedia/commons/thumb/e/e6/Perth_CBD_from_Mill_Point.jpg/2600px-Perth_CBD_from_Mill_Point.jpg is a thumb too [20:14:47] http://upload.wikimedia.org/wikipedia/commons/1/1b/Selena_Gomez_2012_(Cropped).jpg [20:14:52] first non-porny result! [20:15:33] New review: Aaron Schulz; "Yes, Mock classes need to go in tests/ instead of cluttering up the main code :)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61276 [20:15:44] http://upload.wikimedia.org/wikipedia/commons/1/1c/Man_holds_a_nice_sized_northern_pike_-_NARA_-_283863.jpg [20:16:08] YEAH! [20:16:52] http://upload.wikimedia.org/wikipedia/commons/0/04/PikiWiki_Israel_15327_Musrara_neighborhood_Jerusalem_.jpg [20:17:07] one use-case for these results is to let contributors of highly-sought images the amount of exposure that their photographs are getting [20:18:04] for other folks than multi chill, i have been working with the GLAM toolset and multi chill about speccing out the user requirements for image related metrics [20:18:13] ori-l: that's a very cool suggestion! [20:18:15] Change abandoned: Aaron Schulz; "Patch not maintained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40308 [20:21:34] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [20:21:54] questions before we start wrapping up? [20:22:08] In case you need another fun query: What percentage of requests are done by Pywikipedia bots (sends the right string) [20:24:50] dschoon: Thanks for you presentation. It was really nice. Yes please! [20:24:54] New patchset: Hashar; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [20:24:59] * awjr_lunch claps [20:25:03] Is the video of this going to be saved? [20:25:04] thank you!!! [20:25:05] my pleasure [20:25:07] thank you guys [20:25:10] video is on youtube [20:25:10] yes, same url [20:25:17] ok. Awesome! [20:25:28] http://youtu.be/0csFRllZ2Lw [20:25:43] thanks dschoon!!!!!!!! [20:25:53] thanks everybody [20:26:16] New review: Hashar; "I have moved the mocked classes under /tests/phpunit/mocks/ . /tests/phpunit/includes/ mostly contai..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [20:26:29] we should post the link to the analytics mailing list and put it on some wiki's [20:26:47] dschoon: thanks, this was excellent [20:26:54] thanks man [20:27:17] Yippie, build fixed! [20:27:18] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #32: FIXED in 4 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/32/ [20:29:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [20:30:02] i'm posting the files to one of our servers [20:30:19] i'll post to the list when it's available [20:30:36] Project browsertests-sandbox.translatewiki.net-linux-firefox build #47: FAILURE in 3 min 17 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/47/ [20:44:42] qgil: the video is "not available" [20:44:44] on youtube [20:44:47] qgil: http://youtu.be/0csFRllZ2Lw [20:44:53] is there another URL? [20:45:24] lemme see [20:46:17] what account did you use? [20:46:18] your own? [20:49:31] New patchset: Alex Monk; "(bug 14862) Global user renaming" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [20:49:43] New review: Alex Monk; "just a rebase" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [20:54:14] drdee: About the day of the meetup. I expect to be doing some last minute things on the Thursday and people will start dropping in on that day [20:54:24] I probably have to do the wireless too around that time [20:54:27] New patchset: EBernhardson; "Link to the notifications FAQ from Preferences" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61888 [20:54:39] It's pretty easy to reach, it's next to Amsterdam Muiderpoort [20:56:18] New patchset: EBernhardson; "Link to the notifications FAQ from Preferences" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61888 [20:58:43] New review: Pgehres; "(1 comment)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [21:00:32] New patchset: Alex Monk; "Add missing to Special:CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61890 [21:02:16] dschoon, weird. It has disappeared. Then I have found Google support forum threads with people complaining about videos disappearing. [21:02:25] heh [21:02:28] dschoon, some reports get the video back after a while [21:02:41] dschoon, some other get them after someone at Google looks for them... (!) [21:02:48] dschoon, I'll post a request now [21:03:13] update the thread if it does [21:05:43] New patchset: Mwalker; "Updating CentralNotice for Historical Allocations" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61894 [21:07:10] New review: CSteipp; "Since it's been a while, and no one has complained, let's merge this and the tests." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/55453 [21:07:33] dschoon, reported: http://productforums.google.com/forum/#!category-topic/google-plus-discuss/hangouts/UXOMXIBiWzY [21:07:49] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/55453 [21:08:09] New patchset: Mwalker; "Updating CentralNotice for Historical Allocations" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61895 [21:08:41] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61895 [21:09:45] New patchset: Alex Monk; "(bug 14862) Global user renaming" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39171 [21:09:57] New patchset: Mattflaschen; "Change font size for edit links to small" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61896 [21:10:08] New patchset: Anomie; "(bug 47950) Fix IndexPager detection of "is first" state" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61897 [21:11:24] New patchset: Luis Felipe Schenone; "Copied collapsibleTabs module from Vector ext. to Vector skin" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:12:14] New patchset: Mwalker; "Updating CentralNotice for Historical Allocations." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61894 [21:12:21] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61894 [21:12:34] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61890 [21:13:43] New review: Swalling; "For context: https://meta.wikimedia.org/wiki/Talk:Change_to_section_edit_links#Font_size" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61896 [21:13:55] New review: Aaron Schulz; "This would only be hit on parse, so it probably won't be hit in cache most of the time (unless peopl..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [21:14:42] Krinkle: can you review this ? https://www.mediawiki.org/w/index.php?title=Manual%3ACoding_conventions%2FJavaScript&diff=682887&oldid=674638 [21:15:09] I had to explain it 3 times in a week [21:17:12] New patchset: Alex Monk; "Add missing to Special:CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61890 [21:17:30] csteipp: it's volatile-lru policy, which means any expired key can be chosen [21:17:43] New patchset: Ryan Lane; "Preserve classes added by cssclass argument" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:17:54] which may not matter if it never gets close to filling up [21:18:17] AaronSchulz: So as long as we know we'll finish before the expire time, it won't ever be evicted [21:18:32] thedj: $([]) would be the cheapest valid empty object. $().length is undefined [21:18:44] csteipp: assuming it never fills up yes [21:18:44] * Krinkle is editing [21:18:51] New review: CSteipp; "Thanks!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/61890 [21:18:54] if it has to evict stuff, then any expiring thing is fair game [21:19:15] Wait, "expiring" or "expired"? [21:19:20] Krinkle: ah, that's important, that means i need to fix something :D [21:19:29] "thing with an expiry" :) [21:19:31] * thedj tries to remember where i recently used that. [21:19:38] Ah, gatcha :( [21:19:56] New patchset: MaxSem; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [21:20:09] thedj: However I have never seen a valid use of an intentionally empty jquery object. Usually bad code. If you need an empty value, leave it undefined. [21:20:27] Unless you intentionally mask errors or are very sure of what you're doing. [21:20:39] if we were worried about it filling up and evicting (which is remote), one could have another instance with 'noeviction' [21:21:05] New patchset: Ryan Lane; "Preserve classes added by cssclass argument" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:22:19] Krinkle: ^^ can you do a quick review on that? [21:22:24] it's a follow-up to the chosen stuff [21:22:44] without being able to apply other css classes, the chosen stuff on htmlform isn't terribly useful :) [21:22:59] it makes these tiny elements that can't be resized [21:25:15] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/55493 [21:25:43] New patchset: Bsitu; "(bug 47924) Category and File links should be namespace escaped" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61900 [21:25:48] thedj: I've made a few minor edits, will review indepth later [21:26:08] thedj: I'm not sure if it deserves this large a section. it isn't a "learn javascript" page if you know what I mean [21:26:17] but I'll see about that later [21:26:18] Ryan_Lane: checking [21:26:39] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61890 [21:27:11] Ryan_Lane: Don't use gerrit url or gerrit numerical id to refer to changes. Isn't linked and hard to reason about outside gerrit context. [21:27:24] for merged changes, use git sha1 [21:27:26] I'll update the cover message. I should use commits? [21:27:29] * Ryan_Lane nods [21:27:40] for unmerged changes, change-id hash [21:29:26] New patchset: Ryan Lane; "Preserve classes added by cssclass argument" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:29:54] ugh. that feature is so fucked [21:30:22] all the comments before that patchset are gone [21:34:40] New patchset: Kaldari; "Fixing CSS for inline badge in IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [21:34:44] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:35:26] New patchset: Kaldari; "Fixing CSS for inline badge in IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [21:36:36] ah. jquery has a trim function. of course it does. heh [21:36:55] Ryan_Lane: Javascript does too String.prototype.trim. " foo ".trim() [21:37:04] but it is ES5 and up. So for cross-browser compat we use $.trim [21:37:10] ah. good to know [21:38:08] New patchset: Krinkle; "jquery.badge: Add CSS inline-block fix in IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [21:38:17] New patchset: Krinkle; "jquery.badge: Add CSS inline-block fix for IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [21:38:31] Krinkle: so, all of my variables after var should be indented? [21:38:52] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [21:39:11] New patchset: Wikinaut; "(bug 47264) SpecialVersion: Add last local update timestamp" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [21:39:22] Ryan_Lane: either that, or initialise them without assignment and assign in separate statements [21:39:35] otherwise they look like separate statements [21:39:40] * Ryan_Lane nods [21:42:39] ori-l: yt? [21:42:41] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Vector] (master) C: -1; - https://gerrit.wikimedia.org/r/61757 [21:42:45] awjr: hey [21:43:07] hi :) i heard you were on vacation so don't want to disturb, but have a quick q if you're up for it [21:43:16] New patchset: Krinkle; "jquery.suggestions: Edit warning wasn't showing up for search in Firefox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36123 [21:43:26] Change abandoned: Krinkle; "Per bug thread" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36123 [21:44:15] awjr: what's up? [21:44:34] ori-l: we're wondering if you have any concerns about logging URLs in NavigationTiming [21:44:40] ori-l: https://mingle.corp.wikimedia.org/projects/mobile/cards/684 [21:45:45] New patchset: Ryan Lane; "mediawiki.htmlform: Preserve classes added by HTMLForm's cssclass option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:46:08] Krinkle: ^^ I think that fixes what's mentioned in the comments [21:46:49] awjr: well, the varnishes are (afaik) still running with an shm log size cap of 1024 bytes, or something like that. take a percent-encoded url for an article in arabic (say) with a long title, percent-encode it again (so that it can be sent as a parameter to another url) and you brush against the limit [21:46:57] New patchset: Luis Felipe Schenone; "Added the .DS_Store files to .gitignore" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/61757 [21:47:01] also, urls are difficult to normalize sometimes [21:47:03] Ryan_Lane: self-reverted the git hash reference [21:47:15] that said, I see why you want this info, so i'm wondering if we should log the title instead [21:47:32] that's what I get for using the gerrit feature [21:47:35] ori-l: yeah; we already know the project the user is accessing so the full URL might be overkill [21:48:08] New patchset: Krinkle; "gitignore: Add .DS_Store" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/61757 [21:48:14] New review: Krinkle; "Thanks!" [mediawiki/extensions/Vector] (master) C: 2; - https://gerrit.wikimedia.org/r/61757 [21:48:19] ori-l: if we just logged title would there be any problems? should we limit string length? [21:48:24] it also saves you from having to homogeonize http://en.m.wikipedia.org/w/index.php?title=Winnipeg and http://en.m.wikipedia.org/wiki/Winnipeg [21:48:34] true tht [21:48:40] New patchset: Ryan Lane; "mediawiki.htmlform: Preserve classes added by HTMLForm's cssclass option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [21:48:56] New patchset: EBernhardson; "Only trigger one notification per user on article save" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61902 [21:49:12] awjr: I think the full title should be fine. It's a shame that special pages don't have numeric IDs :/ [21:49:31] Change merged: jenkins-bot; [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/61757 [21:49:56] Krinkle: ok. now fixed. [21:49:58] Ryan_Lane: Sorry, the sample I gave on irc didn't include the whitespaces you should include (spaces around function arguments ) [21:50:04] Ryan_Lane: replace( .. , .. ) [21:50:08] that's the last of it [21:50:10] ori-l: aye [21:50:16] testing now and will merge assuming it works [21:50:17] ori-l: ok, thanks :) [21:50:45] Ryan_Lane: forgot to add a space between '...' + oldClass [21:50:55] awjr: np. can you & co. update the schema and logging code, or need me to? [21:51:04] ah. indeed [21:51:16] we should be able to take care of it :) [21:51:23] a real space that is, not code whitespace [21:51:23] ori-l: ^^ [21:51:51] awjr: cool :) [21:54:07] Krinkle: do you know about the change to MWMultiVersion.php related to using CLI [21:54:14] Krinkle: by hashar [21:54:50] https://gerrit.wikimedia.org/r/#/c/61424/ [21:54:57] that was merged but not deployed [21:55:26] mutante: I do not [21:56:26] i just ran into it when doing a git pull for unrelated change [21:57:14] mutante, should be safe to sync [21:57:26] thanks Max [22:00:11] New patchset: Ryan Lane; "Revert "Allow any project member to create a service group."" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61903 [22:00:21] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61903 [22:01:39] sync-docroot, create wikimania2014 [22:01:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [22:02:45] actually, the log bot says i already did it before the script stopped running [22:03:47] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61898 [22:04:30] why would it try to talk to professor ?;p [22:04:40] and now it finished [22:05:55] and sync-common-file on MWMultiVersion.php to get that in sync [22:09:33] New patchset: Kaldari; "Fixing CSS for inline badge in IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [22:09:54] New patchset: Ryan Lane; "Limit some NovaProject actions to projectadmin" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61906 [22:10:15] mutante: sync-file, not sync-common-file, right? [22:10:23] Hm.. sync-common-file exists? [22:10:55] yes [22:10:57] https://wikitech.wikimedia.org/wiki/Sync-common#sync-common [22:11:18] i used it [22:11:24] mutante: sync-file uses sync-common-file [22:11:31] sync-file adds syntax and target checks [22:12:01] so the difference is the added PHP syntax check? [22:12:06] gotcha [22:14:05] mutante: syntax check and verification that the target path exists / is a file [22:14:19] you didn't know? [22:16:29] oh, probably, i just don't do it that often [22:17:41] i just wanted the new docroots and that was fine with sync-docroot [22:17:52] New patchset: Pgehres; "Unsetting the email address for a user when the email address is invalidated." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [22:21:47] New patchset: Adamw; "Fix a crash in recurring" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/61909 [22:24:41] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [22:25:18] New patchset: MarkTraceur; "Use specific modes in the parsoid options" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61910 [22:26:19] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/61909 [22:26:30] kaldari: was the added "cursor: pointer;" intentional? Seems unrelated to the commit. [22:27:18] kaldari: https://gerrit.wikimedia.org/r/#/c/61901/3..4//COMMIT_MSG [22:27:32] yes, forgot to mention in the commit summary [22:27:35] fixing... [22:27:42] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60644 [22:27:44] Or do in separate commit? [22:28:01] I'll merge them both right away [22:28:36] New patchset: Kaldari; "Fixing CSS for inline badge in IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [22:28:46] updated [22:29:22] Krinkle: Thanks! [22:31:53] New review: Tychay; "I fully support this fix!" [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/61901 [22:33:45] New patchset: Pgehres; "Adding UserInvalidateEmailComplete hook to CentralAuth." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61912 [22:34:24] kaldari: No rush, but are you planning on updating the commit message (see link) and split the commits? [22:34:28] Krinkle: also thanks for bug 47955. I agree, but had been overruled by the designers [22:35:05] kaldari: designers intentionally regressing usability and useful features? Or just not thought of it? [22:35:15] I would expect this to be done especially by a designer [22:35:33] they strangely believe that Wikipedians will be confused by having more than 1 link [22:35:40] I'd easily forgive a developer for it [22:36:02] kaldari: ... [22:36:27] Krinkle / kaldari: mime type on http://bug-attachment.wikimedia.org/attachment.cgi?id=12227 broken for you too? [22:36:34] New patchset: MaxSem; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [22:36:37] ori-l: yes [22:36:56] yes [22:37:28] New patchset: Kaldari; "Fixing CSS for inline badge for IE7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [22:37:28] Krinkle: OK, commit message should be totally fixed now [22:37:49] New review: MaxSem; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [22:38:26] < Content-Type: text/plain; name="Screen Shot 2013-05-02 at 12.19.14 AM.png"; charset= [22:38:34] odd [22:38:40] New patchset: Pgehres; "Adding aa_method field to track login method." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [22:39:50] New patchset: MaxSem; "Fix XML import" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [22:42:01] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [22:43:47] New patchset: awjrichards; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [22:44:18] New patchset: awjrichards; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [22:44:48] New patchset: awjrichards; "Completely blacklist Opera Mobile from RL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [22:46:23] New patchset: Ryan Lane; "Fix role checking for users" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61915 [22:47:03] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61906 [22:48:27] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/61915 [22:51:49] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61899 [22:54:38] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61064 [22:56:49] New patchset: Kaldari; "jquery.badge: Add CSS inline-block fix for IE 7 and earlier" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [22:59:01] New review: Krinkle; "Can this be done with css queries perhaps? (less browser support, but should be good enough for simp..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61289 [23:02:02] New patchset: Ryan Lane; "mediawiki.htmlform: Preserve classes added by HTMLForm's cssclass option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61898 [23:03:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [23:06:38] New review: Krinkle; "CodeReview: +2" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61901 [23:07:17] Ryan_Lane: So how do I test the cssclass change? [23:07:28] Ryan_Lane: Got an example ready? (in an extension or other gerrit change perhaps) [23:07:47] OpenStackManager has it [23:07:56] it's running on nova-precise2 right now [23:08:09] I didn't push in that change just yet, as I'm still working on it [23:08:51] Ryan_Lane: So the basics are a HTMLMultiSelectField instance with cssclass=mw-chosen ? [23:09:18] yes, but without an additional class to size it, it likely won't look right [23:09:41] so cssclass => "mw-chosen mycustomclass" [23:09:59] Ryan_Lane: To size what? [23:10:04] the select [23:10:44] * Krinkle doesn't get it [23:11:10] I'm changing a preference in core to use this class [23:11:21] (just locally) [23:11:22] https://nova-precise2.pmtpa.wmflabs/w/index.php?title=Special:NovaInstance [23:12:20] Were you guys still unable to find the issue with puppet breaking apache's config? [23:12:45] yeah. I always go in through a socks proxy and haven't had time to fix it [23:12:45] Ryan_Lane: Should https://nova-precise2.instance-proxy.wmflabs.org/w/index.php?title=Special:NovaInstance work ? [23:12:54] no, it redirects [23:13:12] andrewbogott is working on fixing these issues right now, I believe [23:13:17] I can't access that other url and don't feel like setting up socks stuff. Never works right and screws everything up [23:13:25] one sec [23:13:28] I'll screenshot [23:13:29] k :) [23:13:37] I can fix apache's config manually but puppet will just break it again as always [23:13:51] * Ryan_Lane nods [23:13:57] New patchset: Tim Starling; "Update GettingStarted to use RedisConnectionPool" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61921 [23:14:02] Ryan_Lane: http://cl.ly/image/0J0b2C0J2X1R [23:14:07] that looks broken if that's the default [23:14:09] Hm the login message still mentions labsconsole [23:14:15] it needs another class to make it decent? [23:14:18] it has no width by default [23:14:22] why not? [23:14:31] Krinkle: I have no clue what default to set it to... [23:14:46] Ryan_Lane: The width of the select? [23:14:50] New patchset: Tim Starling; "Update GettingStarted to use RedisConnectionPool" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61922 [23:15:23] which browsers auto-size to min( widest width of text value option, width of parent element) [23:15:47] Change merged: Tim Starling; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61922 [23:15:51] Change merged: Tim Starling; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61921 [23:16:01] right, so I still don't really know what would be a sane default [23:16:44] Ryan_Lane: I suspect something is breaking it because if I use it no a plain html page with just jquery and chosen (no mediawiki) it picks a reasonable width by default [23:16:53] having to manually set a width makes no sense [23:16:57] hm [23:17:14] okay https://wikitech-test.wmflabs.org/w/index.php?title=Special:NovaInstance should now work until the next puppet run [23:17:31] maybe it's the mw-input class I'm adding? [23:17:40] oh. crap [23:17:46] I have it in my browser [23:17:47] testing now [23:17:49] checking* [23:17:50] we can't run puppet on that host for a while [23:17:50] heh [23:17:57] I upgraded nova and disabled puppet [23:18:01] well, it'll work for a while : [23:18:03] :D [23:21:02] Ryan_Lane: It is the messing it up [23:21:08] table cells are as narrow as possible [23:21:11] legacy browser stuff [23:21:15] make the table 100% width [23:21:27] (it has transparent borders, won't hurt anything) [23:21:30] htmlform is making the table [23:21:56] right [23:21:57] this is good [23:22:07] Ryan_Lane: htmlform also sets a width for input fields inside the table (for this very reason) [23:22:21] mediawiki.htmlform (in core) should add css rules for chosen the same way [23:22:38] so it has a reasonable width, matching other htmlform generated stuff [23:23:34] so is there some change I should be making with this? [23:23:48] New patchset: Adamw; "More core prequel for Amazon" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/61923 [23:23:55] Ryan_Lane: yes :) [23:24:13] heh. well, you've lost me on what it's supposed to be [23:24:29] should I be setting the table width via the js, or in htmlform? [23:24:38] in core, or when htmlform is called? [23:24:57] Ryan_Lane: forget the table width, I didn't know it was generated by htmlform when I said that [23:25:01] New patchset: Kaldari; "Category and File links should be namespace escaped" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61900 [23:25:34] Ryan_Lane: the module in core that handles htmlform <-> jquery chosen (mediawiki.htmlform.css I suppose) should add stylerules that set a default width [23:26:09] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61900 [23:26:16] on which class? on an htmlform class? [23:26:46] Ryan_Lane: Actually, when testing locally it seems like jquery-choosen is handling it fine. It enforces the proper minimum width [23:27:00] Try not setting any width with your extra classes [23:27:03] what does it do? [23:27:07] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #32: FAILURE in 4 min 13 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/32/ [23:27:11] (in osm in labs) [23:27:16] it has a reasonably sized width [23:27:22] but I wanted it to be longer than that ;) [23:27:30] hence the change I pushed in [23:27:34] Ryan_Lane: It'll be longer when there is something to put inside [23:27:39] nope [23:27:43] it increases the length [23:27:44] not the width [23:27:47] if you select an option and then another, they'll be next to each other [23:27:56] and the box increasees [23:28:16] New patchset: TheDJ; "MathJax: Improve font style inheritence" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [23:28:26] Ryan_Lane: in core with preferences, no extra classes/width: http://cl.ly/image/030y3J07250Z http://cl.ly/image/1i192B0o0C26 [23:28:36] works as expected [23:29:19] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61924 [23:30:06] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #32: FAILURE in 3 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/32/ [23:30:21] Krinkle: http://imgur.com/SrYEvBi [23:30:31] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/61509 [23:30:43] I want to apply an additional class there to make it wider [23:30:57] Ryan_Lane: Add me to more projects so I can use that [23:31:16] I don't want to believe it needs a width set [23:31:42] New patchset: TheDJ; "MathJax: Improve font style inheritence" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [23:32:44] Krinkle: done [23:32:44] Change abandoned: Krinkle; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57220 [23:35:24] New patchset: Demon; "Revert type hinting in Hooks::run()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:36:03] Change abandoned: MaxSem; "Already done on TWN." [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/57418 [23:37:20] New review: MaxSem; "Lol: https://gerrit.wikimedia.org/r/61064" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:37:36] New review: Krinkle; "See also https://gerrit.wikimedia.org/r/#/c/61064/4/includes/GlobalFunctions.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:38:02] New review: Aaron Schulz; "How do objects work here? E.g.:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:38:12] New review: Krinkle; "he, comment conflict. that's a first (for me)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:42:35] New review: Demon; "Objects work just fine, that's all I know." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61925 [23:49:15] New patchset: Kaldari; "jquery.badge: Add CSS inline-block fix for IE 7 and earlier" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61928 [23:50:31] New review: Pgehres; "It looks like unit tests need to be updated. No one considered the possibility of there not being a..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [23:51:04] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61928 [23:51:07] New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [23:53:21] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61930 [23:53:40] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/61930 [23:54:28] New review: Jforrester; "Oh dear. :-)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [23:56:38] New patchset: Krinkle; "Delete collapsibleTabs module in preparation for adding to mediawiki/core" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/56711 [23:57:52] New patchset: Kaldari; "jquery.badge: Add CSS inline-block fix for IE 7 and earlier" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61932 [23:58:12] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61932 [23:59:10] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61933 [23:59:31] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61933