[00:02:10] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61025 [00:05:11] New review: Krinkle; "try-catch blocks are slow in javascript, they should not be used to large code paths in, especially ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60346 [00:09:26] New patchset: Adamw; "WIP: Amazon IPN listener" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [00:15:34] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61514 [00:16:00] New patchset: Inquisitor-sasha; " Adding source code for extension" [mediawiki/extensions/Sarcasm] (master) - https://gerrit.wikimedia.org/r/61518 [00:17:19] New review: Alex Monk; "As far as I know you can't show cross-repository dependencies in Gerrit if that's what you meant. Bu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [00:22:42] New patchset: EBernhardson; "Accept diffs formatted by UnifiedDiffFormatter" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61514 [00:22:49] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [00:28:28] New review: Mwalker; "(1 comment)" [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/59051 [00:34:25] New review: Ori.livneh; "@Krinkle: the performance impact of try / catch is not significant (i.e. hardly measurable). Take a ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60346 [00:43:36] New review: Krinkle; "Agreed it isn't a significant argument on a small scale. I just mentioned it as general information...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60346 [00:51:06] Change merged: Kaldari; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61464 [00:51:23] ori-l: try/catch perf has improved a lot in recent V8. It used to be quite awful [00:51:31] I wonder if JIT has something to do with it [00:51:40] * Krinkle ran some more tests [00:51:59] nice catch [00:53:31] Gonna deploy VE now [00:55:55] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61521 [00:56:27] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61521 [01:01:30] New review: Bsitu; "The cache is not updated or purged, it is possible that $user->getOption( 'echo option' ) would retu..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [01:04:08] New patchset: Rasel160; "(bug 27995) Added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [01:04:24] I just tried to commit (git review) a bunch of commits to gerrit. Got this error: http://pastebin.com/ntjzEwRX anyone got a clue about that? [01:04:37] Eeeewwww [01:04:43] I've never seen that before [01:04:51] Are you sure there aren't any weird characters in your commit message(s) ? [01:05:54] RoanKattouw: I actually have. And \u010d referes to that special c character I am using in "Denny Vrandecic" whom I mention in one of the messages [01:06:07] I used it in a message before though [01:06:18] https://gerrit.wikimedia.org/r/#/c/60981/ [01:06:28] New patchset: Rasel160; "(bug 27995) Added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [01:06:36] All my changes build upon that one and now I can't submit them [01:06:50] haha [01:06:55] You can work around it with git review -y [01:07:02] -y for --yes [01:07:07] It skips the prompt [01:07:16] I'll try that [01:08:12] oh, great, works. Thanks Roan! [01:13:09] New review: Bsitu; "Some category names are defined in extensions: PageTriage & Thanks, I will update them and make sure..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61477 [01:13:59] New patchset: Kaldari; "Making sure user data isn't out of date before updating user" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61489 [01:13:59] New patchset: Kaldari; "Adding maintenance file for updating user caches after CopyExistingEmailPreference" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61531 [01:14:32] Change abandoned: Kaldari; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61489 [01:15:30] New patchset: Bsitu; "Update Notification category name" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61532 [01:15:43] New patchset: Kaldari; "Adding maintenance file for updating user caches after CopyExistingEmailPreference" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61531 [01:16:23] New patchset: Kaldari; "Adding maintenance file for updating user caches after CopyExistingEmailPreference" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61531 [01:21:46] New patchset: Bsitu; "Update notitifcation category name" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61533 [01:31:54] RoanKattouw: Hehe, this is basically the return of legacy wikibits "runOnloadHook" [01:32:05] (