[00:00:11] New patchset: Ori.livneh; "(bug 41729) Move section edit links to after the headings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [00:16:27] New patchset: Rasel160; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [00:18:42] New patchset: Rasel160; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [00:26:46] New review: Diederik; "Thanks Ori!" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60891 [00:29:06] New patchset: Rasel160; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [00:36:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [00:46:07] TimStarling: hi, you probably know - how long does it take for the parser cache to expire entirely on WMF servers? [00:46:20] and how long does it take for the squids cache to do the same? [00:46:25] a month [00:46:28] i assume these don't stick around forever [00:46:30] a month [00:46:38] ah. that's great then [00:46:51] thanks [00:46:59] there was an issue with image links to static resources being cached in parser output [00:47:23] since the URLs were version-dependent, it would break if the relevant version of MW was removed [00:47:31] yeah, i remember, and i remember things were being changed [00:47:37] so now it's consistently 1 month [00:47:47] so i'm asking someone who knows that they're deing instead of trying to find it in the docs ;) [00:48:04] alright, makes sense. thanks. [01:07:52] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [01:09:02] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [01:14:23] New review: Tim Starling; "I don't think it's appropriate to embark on a program of changing everything about our class naming ..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/59804 [01:39:45] New review: Adamw; "Tim: the motivation behind this patch is not solely to follow half of a crummy standard. Here are t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [02:02:06] New review: Tim Starling; "1. You're saying doing stat calls is more efficient? For many non-Wikimedia users, the code is hoste..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [02:24:33] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61025 [02:27:57] New patchset: Rasel160; "fixed css issue where long copyright text and radio buttons are seperated" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [02:40:19] New review: Adamw; "Tim," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [02:47:42] New patchset: Adamw; "AutoLoader, grok namespace" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [02:48:42] New review: Adamw; "PS 13: I've removed the file_exists, along with support for multiple classes per file. I wasn't a f..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [02:48:54] New patchset: Adamw; "AutoLoader, grok namespace" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [03:01:17] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [03:06:14] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [03:08:29] New patchset: Diederik; "Create path using os.join.path instead of ''.join" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61340 [03:19:06] New patchset: Aaron Schulz; "Defer user_daily_contribs updates to reduce deadlocks." [mediawiki/extensions/UserDailyContribs] (master) - https://gerrit.wikimedia.org/r/60944 [03:44:08] New patchset: Mattflaschen; "Change icons to use img tags, allowing easier customization:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [03:47:05] New review: Tim Starling; "The insert query can now fail, since the update query is done in autocommit mode, so the lock is not..." [mediawiki/extensions/UserDailyContribs] (master) C: -1; - https://gerrit.wikimedia.org/r/60944 [03:47:49] New patchset: Mattflaschen; "Update how icon is configured for corresponding Echo change" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61342 [03:48:54] TimStarling: I thought I saw an IGNORE in there...must have been thinking of something else [03:49:06] New patchset: Mattflaschen; "DRAFT: Review after https://gerrit.wikimedia.org/r/#/c/61341/" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61342 [03:49:55] I thought I had better review it carefully since one of the previous onTransactionIdle changes caused a bug [03:50:03] did you see that? [03:50:54] anyway, I only saw that one after I downloaded the change and looked at it in non-diff view [03:52:28] TimStarling: you mean the hook order change? [03:53:05] yeah, I think that was i [03:53:06] t [03:53:30] I couldn't remember many of the details so I wasn't having much luck finding it in bugzilla [03:53:54] I reviewed the fix for that one [03:55:23] gah, I guess it need begin()/commit() or named locks [03:55:26] "update -> insert ignore -> update" would work [03:55:27] * Aaron|home just does the former [03:55:35] that would work too [03:55:36] in autocommit mode [03:55:46] kind of like the incr() memc trick [03:55:57] yeah [03:56:12] and it'd be good to figure out some best practices here, unlike what we did with memcached [03:56:26] where we had half a dozen non-working implmentations of increment-or-zero [03:59:05] one day it might be nice to support "initial values" for BagOStuff incr() like the pecl client already supports [03:59:15] then the logic would be mostly in one place [04:00:09] too bad we don't support ON DUPLCIATE KEY UPDATE [04:00:22] instead of 3 queries ;) [04:01:59] maybe that could still be abstracted out, falling back depending on the rdbms [04:03:27] yes, it would be nice, I think I suggested it on gerrit once [04:04:12] in this case, we can also have the INSERT IGNORE first and only have 2 queries [04:04:21] I think cat counts do that atm [04:08:24] but then you have an average of 2.001 queries per edit instead of an average of 1.001001 [04:08:43] assuming 1000 edits per user and 1/1000 incidence of race condition on insert [04:12:56] I guess the average is just 2 not 2.001 [04:13:42] New patchset: Aaron Schulz; "Defer user_daily_contribs updates to reduce deadlocks." [mediawiki/extensions/UserDailyContribs] (master) - https://gerrit.wikimedia.org/r/60944 [04:14:04] New patchset: Tim Starling; "[JobQueue] Added a delayedJobsEnabled() function." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60929 [04:14:18] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60929 [04:16:48] Change merged: Tim Starling; [mediawiki/extensions/UserDailyContribs] (master) - https://gerrit.wikimedia.org/r/60944 [04:17:06] New patchset: Mattflaschen; "Change icons to use img tags, allowing easier customization:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [04:19:11] New review: Aaron Schulz; "I think having an unused function in a sibling class of one that has a counterpart that *is* used is..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60795 [04:27:26] Change merged: Aaron Schulz; [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/53683 [04:30:15] New review: Kaldari; "See comments on previous patchset." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/61341 [04:49:34] New review: MZMcBride; "Sorry, I had missed this part of your comment." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61065 [04:49:46] New patchset: Mattflaschen; "Add new $icons parameter to Echo hook:" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61343 [04:51:00] New review: Mattflaschen; "Please review after https://gerrit.wikimedia.org/r/#/c/61341/ , the corresponding change to Echo." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61343 [04:54:24] New patchset: Mattflaschen; "Add new $icons parameter to Echo hook:" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61344 [04:57:03] New review: Mattflaschen; "Please review after https://gerrit.wikimedia.org/r/#/c/61341/ , the corresponding change to Echo." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61344 [05:15:38] New review: Mattflaschen; "Thanks. 2 done, and see note regarding $echoIconPath" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [05:18:02] New patchset: PleaseStand; "wfRandomString: Correct bias toward digits 1-7" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61345 [05:27:50] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [05:49:15] New review: Kaldari; "This works fine for me (tested with WikiLove and PageTriage which both use mw.loader). Note, however..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61057 [05:55:34] New patchset: IAlex; "Split line and fixed spacing in skins folder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61175 [05:55:59] New review: Ori.livneh; "Looks good, thanks. What's the canonical source for this file, by the way? Is it unique to this repo..." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/61340 [05:57:35] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61340 [05:58:41] New patchset: Kaldari; "Prevent short-term duplicate thanking" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60914 [05:59:01] New patchset: Mattflaschen; "Change icons to use img tags, allowing easier customization:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [05:59:29] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60914 [06:00:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61175 [06:05:41] New patchset: Mattflaschen; "Change icons to use img tags, allowing easier customization:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [06:11:42] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61341 [06:12:48] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61344 [06:13:14] New patchset: Mwjames; "Add methods to access config/settings array via JS" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61346 [06:13:47] New patchset: IAlex; "Allow to set the ID of the main table in HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61347 [06:14:34] New patchset: Mattflaschen; "Update how icon is configured, due to corresponding Echo change" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61342 [06:15:05] New review: Nischayn22; "Thanks for the change. Could you clarify if this fixes a bug? or if its a change you think is necess..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [06:16:50] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61343 [06:18:58] New review: Mwjames; "QUnit 17 tests of 17 passed, 0 failed." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/61346 [06:19:48] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61346 [06:20:25] New patchset: Nischayn22; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [06:22:38] New review: Nischayn22; "Thanks for the patch, please follow these guidelines for making better commit messages :)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [06:24:02] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/61342 [06:24:26] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61345 [06:30:09] New review: Nischayn22; "I don't think this completely fixes the problem. See http://i.imgur.com/6kVPY5z.png" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61289 [06:30:56] New review: Tim Starling; "> 4. So, you prefer explicit listing of classes to autodiscovery. That's fine, but in the spirit of ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [06:35:41] New review: Matmarex; "This can be safely merged on or after June 7 (30 days after it's deployed to the last wikis), as thi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61072 [06:35:59] New review: Matmarex; "This can be safely merged on or after June 7 (30 days after it's deployed to the last wikis), as thi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [06:36:01] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58684 [06:38:20] New review: Tim Starling; "Given the complaints raised at I14e35ef2, I suggest using Revision::newFromTitle() instead." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53190 [06:43:19] New patchset: Mattflaschen; "Remove unused W icon, now configured outside extension." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61349 [06:45:17] New patchset: Nischayn22; "Use type 'api' for lastuse preferences" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61350 [06:51:33] New review: Adamw; "Tim," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [06:58:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60249 [07:04:16] New review: Rasel160; "sorry, it longer to think about how to describe the issue than to fix it :p" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [07:11:05] New patchset: Nischayn22; "use mw.Api() instead of ajax" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61351 [07:12:32] New review: Nischayn22; "The screenshot looks good. Will test this soonish." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [07:28:23] New review: Karim.rayani; "plz review it" [qa/browsertests] (master) C: 1; - https://gerrit.wikimedia.org/r/61257 [07:54:16] New review: Siebrand; "L10n is fine." [mediawiki/extensions/Nonlinear] (master) C: 1; - https://gerrit.wikimedia.org/r/61274 [07:55:36] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61273 [07:58:19] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61272 [08:03:29] New patchset: Siebrand; "Fix JSHint issues" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61352 [08:05:07] New patchset: Siebrand; "Fix JSHint issues" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61352 [08:12:47] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61352 [08:12:59] New patchset: Siebrand; "Don't let anonymous users change interface language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61271 [08:12:59] New patchset: Siebrand; "Fix typo" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61353 [08:16:35] New patchset: Hashar; "(WIP) Mock filebackend for parser tests (WIP)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [08:25:12] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [08:43:58] New review: Siebrand; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/61271 [08:50:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [09:15:15] New review: Aklapper; "Please write "Bug: 47219" at the end instead of "(bug47219)" in the patch summary, so the Gerrit bot..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61286 [09:20:15] New review: J; "the idea is to allow disabling i.e. TimedText from wikitext, right now its only an option to disable..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57540 [09:24:33] Hey, I have a question about Gerrit: Is there a way to change the "real name" it displays for an account? I thought it would pick it up from commits but it just shows my username in a non-editable text field. [09:25:13] nope [09:25:16] but there's a bug for it [09:25:54] So it's normal behavior, huh? Well, if that's the case, I can live with it ^^ [09:25:58] poke`: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 [09:26:20] it's apparently impossible because of some LDAP stuff [09:27:26] Ah okay, thanks for the link :) [09:33:29] Might as well ask something else: I would like to move my extension's code into a Wikimedia repository; I read all the documentation about it on MW.org, but did not really understand what implications the "code review model" choice has. Does the "merge review" one mean that all changes need to go through Gerrit's review separately, so that even the project owner cannot push to origin directly? And is the straight-push basically open for [09:33:29] anybody to push to origin directly (except on master branch?)? [09:33:29] New review: Siebrand; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/57540 [09:40:20] poke`: there's basically no reason not to use the "code review" model [09:40:33] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [09:40:34] poke`: if you are the repository owner, you can +2 and merge your own changes anyway [09:40:54] poke`: but you get the benefit of them showing up in gerrit and allowing people to comment on them [09:41:25] unlike in the straight push version, where they're not shown in the interface in this way (at least that's how i understand it) [09:41:54] poke`: ^demon or qchris will be able to shed more light on this when they get online :) [09:42:37] I thought doing +2 for own commits was frowned upon ;) [09:42:58] well, yeah, in general [09:43:16] but it's usually okay for extensions no one apart from you commits to [09:43:28] and ones that are not deployed on Wikimedia wikis [09:43:48] and the straight push model is basically +2-ing all of your commits anyway [09:45:20] The reason I'm asking is that the extension is basically only used on the wikis I'm associated with, and it's possibly not really relevant to others anyway. So I don't really expect others to get involved with it.. So I would prefer if I could just push to it directly - but still allow others to propose changes via Gerrit.. [09:45:49] New patchset: Hashar; "(WIP) Mock filebackend for parser tests (WIP)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [09:46:29] is there any way how can module recognize if it has been called or substed? [09:46:29] poke`: i don't really know how this gerrit stuff works, you really should hunt down ^demon or qchris :/ [09:46:38] I will do, thank you :) [09:47:10] Danny_B: What kind of a module? An extension? A code file? [09:47:35] poke`: {{#invoke:foo|func}} [09:49:05] In the parser function's implementation you attach a function to the parser function hook for "invoke". When that function is called, then you know it was invoked - and there you're also supposed to return the resulting code. [09:49:14] in templates, you could do {{ {{{|safesubst:}}}#ifeq:{{ {{{|safesubst:}}}NAMESPACE}}|{{NAMESPACE}} | called | substed }} [09:49:55] i would like to transfer this part of code to the module [09:49:57] Ah, now I understand what you want [09:50:32] so the template will contain only {{ {{{|safesubst:}}}#invoke:module|func }} [09:53:07] New patchset: Hashar; "(WIP) Mock filebackend for parser tests (WIP)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [09:58:08] poke`: use the normal gerrit model, and just selfmerge your changes were appropriate [09:58:54] if you have any i18n in your extension the translatewiki folks will generally pick up any extensions in out git and they dispise the direct push method [10:00:12] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61282 [10:01:47] Danny_B: I looked through the source a bit now, and I don't think it's possible on the extension side to see if the parser function was used in a subst'ed expression or not.. [10:03:00] p858snake|l: Okay, thank you! i18n is definitely something I would be interested in [10:03:44] Danny_B: you could just use a wrapper template with that bit of wikitext to send different arguments to the #invoke call [10:05:26] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [10:06:31] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61354 [10:11:46] New patchset: Siebrand; "Disable upload from URL on Special:ImportTranslations by default" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60983 [10:18:39] New patchset: Nikerabbit; "Disable upload from URL on Special:ImportTranslations by default" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60983 [10:20:27] New patchset: Siebrand; "Disable upload from URL on Special:ImportTranslations by default" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60983 [10:21:44] New review: Aude; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61286 [10:25:13] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/61267 [10:25:34] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61267 [10:26:23] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60983 [10:31:18] MatmaRex: well, that won't actually solve the task "move parser functions from templates to modules"... ;-) [10:43:39] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [10:43:43] New patchset: Matthias Mullie; "Timestamp params (no longer Message->escaped()) still need to be escaped" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61356 [10:44:41] New review: Matthias Mullie; "Nikerabbit: you're right! https://gerrit.wikimedia.org/r/#/c/61356/" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60419 [10:44:52] Danny_B: yeah, but depending on what you're doing it might be a solution to the current problem :) [10:48:17] New patchset: Nikerabbit; "Don't let anonymous users change interface language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61271 [10:58:14] New review: Daniel Kinzler; "@anomie: I tried reworking this class along your suggestions, and it doesn't work:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60278 [11:10:44] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [11:11:31] New review: Daniel Kinzler; "It is confusing and should be fixed. They are public for no reason except testability. Though I don'..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60795 [11:20:14] New patchset: Nikerabbit; "Fix typo" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61353 [11:20:37] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61271 [11:21:07] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61353 [11:34:52] New patchset: Amire80; "Avoid null in the IME languages buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61357 [11:45:11] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [11:47:40] New patchset: Matthias Mullie; "Move check to detect if AFT is enabled down (otherwise class was not yet loaded)" [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/61359 [11:52:50] New patchset: Amire80; "Avoid null in the IME languages buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61357 [11:58:09] New patchset: Hashar; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [12:04:47] New review: Hashar; "Patchset 5 is the one you want to look at, the previous ones were merely drafts." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [12:18:25] New patchset: Matthias Mullie; "If there's feedback, show talk-page link (regardless of AFTv5 being en/disabled)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61360 [12:20:10] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61357 [12:22:45] New patchset: Matthias Mullie; "Bug 42057 - Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [12:25:21] New patchset: Nikerabbit; "Rename confusingly named function" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61361 [12:25:21] New patchset: Nikerabbit; "Join some appends to one call" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61362 [12:25:21] New patchset: Nikerabbit; "Reduce rerenderings in input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61363 [12:27:01] New review: Nikerabbit; "1) scrolls when closing via cog" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/60880 [12:29:57] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61356 [12:31:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60124 [12:31:33] arrbee: sent you a mail please check [12:32:29] parthsrivastav: yep, checked already. Lets have the discussion on the talk page. [12:33:43] arrbee: can u please provide the address [12:33:59] parthsrivastav: umm.. address for? [12:34:07] talk page [12:35:20] arrbee: nevermind figured it [12:35:28] parthsrivastav: :) [12:37:37] New patchset: Hashar; "trigger js jobs only when .js files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61277 [12:37:37] New patchset: Hashar; "trigger pep8/pyflakes only when .py files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61366 [12:37:38] New patchset: Hashar; "trigger PHP related job only when PHP files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61367 [12:39:35] New patchset: Hashar; "trigger PHP related job only when PHP files are changed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61367 [12:39:51] heading home brb [12:48:02] New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [13:00:24] i want to add external link to wiki without the pointing image. [13:02:44] i want to get rid of this png"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAVklEQVR4Xn3PgQkAMQhDUXfqTu7kTtkpd5RA8AInfArtQ2iRXFWT2QedAfttj2FsPIOE1eCOlEuoWWjgzYaB/IkeGOrxXhqB+uA9Bfcm0lAZuh+YIeAD+cAqSz4kCMUAAAAASUVORK5CYII=" [13:08:15] alex_____: use a around the link [13:08:41] New patchset: Nikerabbit; "Fix tipsy behaviour" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61369 [13:14:27] New patchset: Anomie; "(bug 45535) Hook for changing language links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [13:15:24] New review: Anomie; "Yes, it is a breaking change. Previously these functions considered all langlinks, now they don't. I..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59997 [13:22:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [13:30:49] MatmaRex, Thankyou, i have to use it in a div . it worked [13:51:10] New patchset: IAlex; "Factorise call to getSuggestedDurations() in SpecialBlock::getFormFields()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61371 [13:52:37] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61369 [13:54:47] New review: Anomie; "Core changes should seldom be referencing an extension directly. You should think about it more gene..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61286 [13:59:12] New review: Vedmaka Wakalaka; "#arraymap used instead of #arraymaptemplate because if we use #arraymaptemplate, target template wil..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [14:01:35] New review: Zfilipin; "Please see a couple of inline comments." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [14:01:40] New patchset: Zfilipin; "Feature: PDF, Scenario: Click on Download as PDF link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [14:04:15] New review: Vedmaka Wakalaka; "Yep, i divided patches, so every patch is separate from another, so this "values from query" is not ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/57170 [14:07:12] New patchset: IAlex; "tests: mock parser tests file access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [14:07:52] New review: IAlex; "Fixed merge conflict" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [14:08:49] New review: IAlex; "Before: Time: 03:54, Memory: 586.00Mb" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61276 [14:09:50] New patchset: Zfilipin; "Feature: PDF, Scenario: Click on Download as PDF link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [14:10:32] New review: Zfilipin; "I have implemented the changes that I have suggested in a previous review." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [14:10:50] New patchset: Parent5446; "Send a cookie with autoblocks to prevent vandalism." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48029 [14:11:08] µ [14:11:54] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [14:15:05] New review: Yaron Koren; "Hi - in that case, I still don't know what ListTemplate does. Can you point to an example of a templ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [14:16:37] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/61185 [14:19:17] New patchset: Zfilipin; "Remove commented out code" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61372 [14:20:04] New review: Zfilipin; "Merging this into master before Jenkins jobs run (and fail)" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61372 [14:20:05] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61372 [14:27:38] New review: Cmcmahon; "update build docs" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60130 [14:27:39] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60130 [14:27:52] New patchset: Zfilipin; "Moved unimplemented scenarios to backlog folder" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61373 [14:28:14] New review: Cmcmahon; "update build docs" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60137 [14:28:15] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60137 [14:30:32] New review: Siebrand; "Confirmed Niklas' observations." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/60880 [14:31:00] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61354 [14:31:00] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61354 [14:33:30] New review: Vedmaka Wakalaka; "if ListTemplate option of field is set to "MapTemplate" for example and field holds list of values, ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [14:34:18] New review: Siebrand; "Two issues:" [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/60969 [14:38:41] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60450 [14:39:10] New patchset: Zfilipin; "Refactor unimplemented search tests so they are ready for implementation" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61375 [14:43:24] New patchset: Hashar; "mw/ext/Wikibase: split client and server (experiment)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61376 [14:44:20] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61376 [14:46:17] New review: Cmcmahon; "unimplemented scenarios to new backlog folder" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61373 [14:46:18] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61373 [14:47:12] New review: Cmcmahon; "refactor feature to standard language" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61375 [14:47:12] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61375 [14:49:02] New review: Diederik; "Hey Ori," [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/61340 [14:51:40] New patchset: Hashar; "Wikibase client/server jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61380 [14:54:46] New review: Hashar; "Deployed." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/61380 [14:54:46] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61380 [14:55:03] Change abandoned: Cmcmahon; "experiment, no need for this" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59335 [14:57:25] New patchset: Zfilipin; "This test only makes sense for enwiki, it runs on beta labs and production right now and should fail elsewhere. This is a workaround for not being able to change an environment variable from a running script" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [14:57:59] New patchset: Zfilipin; "This test only makes sense for enwiki, it runs on beta labs and production right now and should fail elsewhere. This is a workaround for not being able to change an environment variable from a running script" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [14:59:00] New patchset: Anomie; "(bug 46905) Add "centralauthtoken" to API" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [15:00:21] New review: Anomie; "PS2: Rebased, and adjusted username sanitization to match Ie8731913." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [15:08:41] New review: Yaron Koren; "Hi - it looks like there are few issues with that #arraymap call (more x's are needed), but I think ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [15:09:28] New patchset: Zfilipin; "This test only makes sense for enwiki, it runs on beta labs and production right now and should fail elsewhere. This is a workaround for not being able to change an environment variable from a running script" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:13:11] New patchset: Zfilipin; "Remove tags where not necessary to simplify Jenkins job configuration" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60396 [15:18:30] New patchset: Zfilipin; "Running new preferences feature at en.wikipedia.beta.wmflabs.org and en.wikipedia.org" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60878 [15:20:41] New patchset: Zfilipin; "Add new PDF feature to Jenkins jobs" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60898 [15:23:01] New review: Zfilipin; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:23:04] New review: Cmcmahon; "docs updated" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60396 [15:23:05] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60396 [15:30:54] New patchset: Zfilipin; "Feature: Login SUL" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:32:13] New patchset: Hashar; "Wikibase: run all extensions tests" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61384 [15:32:42] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61384 [15:36:06] New patchset: Hashar; "Revert "Wikibase: run all extensions tests"" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61385 [15:36:18] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/61385 [15:36:19] New patchset: Zfilipin; "Running new preferences feature at en.wikipedia.beta.wmflabs.org and en.wikipedia.org" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60878 [15:36:34] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60878 [15:38:31] New patchset: Zfilipin; "Add new PDF feature to Jenkins jobs" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60898 [15:38:45] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60898 [15:44:21] New patchset: Zfilipin; "Feature: Login SUL" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:45:22] New patchset: Zfilipin; "Feature: Login SUL" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:45:26] New patchset: Yaron Koren; "Added limited-overwrite/"merge" option for importing XML or CSV" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61387 [15:45:41] New patchset: Zfilipin; "Feature: Login SUL" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [15:48:19] New review: Brion VIBBER; "I really, really, strongly recommend making HTTPS required for **all** login sessions when HTTPS is ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47089 [15:48:36] Change restored: Reedy; "Restoring to rebase for a new patchset" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [15:54:29] New review: Vedmaka Wakalaka; "I think this is a bit of misunderstanding, let me show you another example:" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [15:58:02] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:58:02] New patchset: Cscott; "Reimplement Special:Filepath as a redirect through Special:Redirect/File." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61073 [15:58:23] New patchset: Kai Nissen; "(bug 47653) Processing foreign API files protocol-relative" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61390 [15:58:42] New review: Yury Katkov; "Put it shorter the template parameter allow you to format your data in a way you want. It's a lot mo..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [16:04:15] New patchset: Reedy; "Commit of various live hacks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [16:05:48] New patchset: Reedy; "Change live hack revision reference to new patchset" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/61391 [16:06:19] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/61391 [16:08:00] New review: Hashar; "Great! Next thing we will be to abstract out the l10n cache which is rebuild before each test :-)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [16:16:02] Change abandoned: Reedy; "Abandoning again" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [16:18:27] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61387 [16:20:59] Hey qgil: now that I'm registered with google, where do I add my name to his proposal? [16:24:30] New review: Yaron Koren; "Okay. For this kind of very specific setup, I don't see how this approach is any more flexible than ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [16:32:50] New review: Krinkle; "The loader method already has this flag. As I mentioned on the relevant bug (not the one mentioned i..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/61057 [16:33:54] New patchset: MaxSem; "Fix XML import" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61064 [16:33:56] Yippie, build fixed! [16:33:56] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #40: FIXED in 9 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/40/ [16:35:31] New patchset: Matmarex; "(bug 47704) [New UserLogin] Do not show the "(help me choose)" link" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [16:37:56] New review: Krinkle; "Please give some kind of sign of acknowledge or otherwise communicate how you feel. Abandone change,..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57220 [16:39:26] New patchset: Raimond Spekking; "Some consistency tweaks in preparation for adding extension to translatewiki.net" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61396 [16:43:30] New review: Lwelling; "This seems like a valid approach if there are only a small number of active accounts that need the s..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [16:48:06] New patchset: Adamw; "AutoLoader, grok namespace" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [16:48:48] New patchset: Yaron Koren; "Fixed small bug in new limited-overwrite code" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61397 [16:53:17] New patchset: Aaron Schulz; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [16:53:30] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61397 [16:58:22] Change merged: Jforrester; [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61396 [17:00:32] Change abandoned: Anomie; "@Krinkle: Fine. You fix it, if you're not even going to link to whatever "relevant" bug you're talki..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [17:08:12] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61060 [17:09:42] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [17:11:07] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [17:12:07] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [17:14:05] New review: Lwelling; "Needs matching changes to add them to the other extensions, but I assume they are in progress." [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/61151 [17:14:26] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61151 [17:15:03] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/61152 [17:15:34] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61156 [17:16:49] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [17:17:12] Krinkle: you around? [17:29:43] New patchset: Jdlrobson; "Allow disabling of legacy gadgets (Mobile support)" [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/60954 [17:29:44] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59758 [17:32:02] New patchset: Jdlrobson; "Allow disabling of legacy gadgets (Mobile support)" [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/60954 [17:32:18] New review: Jdlrobson; "Tested. No problems with code from this side." [mediawiki/extensions/Gadgets] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/60954 [17:32:24] New patchset: Reedy; "Update wikidata extensions to versions in 1.22wmf2" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61402 [17:35:45] New patchset: Netbrain; "added missing gitreview" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61403 [17:37:13] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61403 [17:38:58] New patchset: Netbrain; "Initial import of Spreadsheet extension" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61405 [17:39:11] New review: Siebrand; "Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/Localisati..." [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61387 [17:39:27] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/61405 [17:42:22] New review: Kaldari; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61163 [17:44:12] New review: Siebrand; "L10n/i18n changes look fine," [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61395 [17:45:03] Change restored: Krinkle; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [17:50:30] New review: Aaron Schulz; "This will slow down parsing with uncached backend GETs. Is there any header or something that could ..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [17:50:43] New patchset: Yaron Koren; "Updated and improved qqq documentation" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61407 [17:51:45] New patchset: EBernhardson; "HTMLCheckMatrix support for forcing options on/off" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [17:54:17] New review: Krinkle; "Issues explained in greater detail on the bug. I'll re-use this change-id to keep things simple." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61057 [17:55:28] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [17:56:10] New review: Umherirrender; "This idea was taken from a comment of bug 47225, where mention that a OOM error or a image bigger th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47225 [17:56:26] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/61407 [17:57:26] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [17:58:06] New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [18:00:19] New review: Raimond Spekking; "+1 from i18n review. But I cannot test the patch locally." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/47225 [18:01:05] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [18:05:24] New review: Siebrand; "i18n/L10n checked. LGTM." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/47225 [18:09:26] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [18:09:38] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61402 [18:11:32] New patchset: Reedy; "Revert "Update wikidata extensions to versions in 1.22wmf2"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61409 [18:11:49] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61409 [18:12:38] New review: Nemo bis; "The message also confused translatewiki.net translators, I must say. Doesn't require release notes b..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/61395 [18:16:11] New patchset: Reedy; "Fix gitreview defaultbranch" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61410 [18:16:25] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61410 [18:16:38] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56079 [18:17:19] I'd love it if someone merged this: https://gerrit.wikimedia.org/r/#/c/61064/ the current failure is blocking one of my tests. [18:17:22] New patchset: Reedy; "Update wikidata extensions to versions in 1.22wmf2" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61411 [18:17:40] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/61411 [18:20:22] New patchset: Reedy; "Revert "Commit of various live hacks"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61412 [18:20:24] New patchset: Reedy; "Revert "Creating new WMF 1.22wmf3 branch"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61413 [18:21:41] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61412 [18:22:02] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61413 [18:25:20] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [18:31:50] New review: Umherirrender; "This can be wrong, when the client used http, but the foreign repo is only https." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61390 [18:32:26] New review: Parent5446; "This patch may be of interest (although I abandoned it, I can restore it): https://gerrit.wikimedia...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56079 [18:33:01] New review: Tychay; "Heads up. Does this affect agora?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54228 [18:34:31] New review: Tychay; "Looks like a bunch of gradients added to the buttons (I didn't examine the images), so I don't see a..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/54228 [18:35:07] New patchset: Krinkle; "mw.loader: Default to async, set sync for top queue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [18:35:33] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/61057/ [18:37:58] New patchset: Legoktm; "Bug 44855, Bug 37743: Improved vector button styles for jquery.ui" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54228 [18:42:05] New review: Krinkle; "That was quick! Please wait just a minute before deploying." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [18:42:38] New review: Krinkle; "(flush)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [18:44:12] New review: Krinkle; "The top queue needs to be blocking. But on all cached html that doesn't yet have "async=false" in th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61057 [18:45:05] New patchset: Kaldari; "A maintenance script for pre-emptively updating email notice option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [18:46:23] New review: Isarra; "Shouldn't affect agora, since from what I understand agora is just a partial skin hacked on top of v..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54228 [18:48:34] New review: Umherirrender; "Please mark this as breaking change, this will break user js/css, site js/css, skin js/css and gadge..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [18:51:36] New review: Umherirrender; "What about ParserOutput? What about caches of third parties?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [18:52:34] New review: Tychay; "Yes, I feel the same, but I added Jorm so that he can give the designers a heads up. If he is okay w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54228 [18:53:22] New review: Vedmaka Wakalaka; "For example, if have template "MapTemplate" with text:" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [18:53:52] RoanKattouw_away: I repeated the potential cache issue on the bug. Could you reply there? I'm not sure whether the cache issue is a problem or not. But I think it might, given how this has caused problems in the past. [18:53:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=47457#c56 [18:57:25] New review: Bsitu; "Kaldari will start with a small threshold then adjust it based on the time it takes" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/61338 [18:57:29] New review: Jorm; "Looks good." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/54228 [18:57:53] New review: Anomie; "Your analysis of the problem in the commit summary is not correct. The problem isn't that the respon..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61390 [18:58:12] New review: Krinkle; "See https://bugzilla.wikimedia.org/show_bug.cgi?id=47457#c56. Please reply there." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61057 [19:01:17] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61338 [19:04:39]