[00:10:43] Project browsertests-test2.wikipedia.org-linux-chrome build #298: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/298/ [00:12:12] Yippie, build fixed! [00:12:13] Project browsertests-test2.wikipedia.org-linux-firefox build #279: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/279/ [00:40:14] New review: Brian Wolff; "This allows uploading of java applets, which is bad. I'll put an example on the bug report of such a..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/44379 [01:43:13] New patchset: Mattflaschen; "Use 'recent contributors' instead of 'contributors this month'." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61246 [03:19:58] New patchset: Mattflaschen; "Don't underline a elements with the mw-ui-button class:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61247 [03:24:12] New patchset: Mattflaschen; "Reuse mediawiki.ui button styles:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/61167 [03:26:31] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/61167 [05:21:21] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [05:27:21] Project MobileFrontend-en.wikipedia.org-mac-operamini build #1: FAILURE in 16 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.wikipedia.org-mac-operamini/1/ [05:44:58] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [05:50:05] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [05:53:15] New patchset: Nischayn22; "Use $.each() instead of for loop" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61249 [05:56:41] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [06:00:04] New review: Mwjames; "I don't get this ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [06:00:28] New review: MarkTraceur; "OK, so maybe it's a stupid question, but...why?" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61249 [06:03:02] New review: Nischayn22; "Mark, please see the comment on the bug report. I myself have no idea why though" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61249 [06:07:35] New review: Nischayn22; "I didn't test this but it all looks amazing." [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/59064 [06:14:50] New patchset: Mwjames; "SMW\HooksTests add unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [06:16:23] New patchset: Wikinaut; "(bug 47264) SpecialVersion: Add last local update timestamp" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:30:33] New review: Mwjames; "Still don't get this every time I add the testOnTitleMoveComplete test, the unit tests get's jumpy w..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61248 [06:35:44] New patchset: Nischayn22; "Check protection status of titles in details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/56371 [06:51:57] New review: Isarra; "I'm not one to -1 for coding style, but I'd suggest giving these files a go-over in general accordin..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61247 [06:53:25] Isarra: Yeeeesss, come to the bikeshed side [06:53:42] lol [06:53:53] Coding conventions are important. [06:54:01] Tpt_: *nod* [06:54:05] Argh, MT [06:54:07] Isarra: *nod* [06:54:11] And is it really a bikeshed when they've already been established as conventions? [06:54:12] Sorry Tpt_. [06:54:26] Isarra: Indeed, without standards the entire bikeshed could collapse on someone [06:54:35] Isarra: No, but soon you will fulfil your deeeestinyyyyy [06:54:57] * Isarra collapses on marktraceur. [06:55:07] Kind of like that? [06:55:10] * marktraceur paints Isarra cyan [06:55:12] marktraceur: No problem. I'm happy to learn new English expressions :-) [06:55:31] Butbut I'm supposed to be blue. [06:55:56] * marktraceur paints Isarra #0000EE [06:56:35] Eeek too blue. [06:56:49] Isarra: See, you're good at this [06:57:08] Heh. [06:57:20] I should be - I am a painter, after all. [06:57:41] Indeed. [06:59:00] * Isarra paints marktraceur groarnge. [06:59:25] Is this color closer to The Cheat, or Bubs' shirt? [06:59:59] I couldn't say. I once wrote an entire Illogicopedia article about what the colour isn't. [07:00:16] It's all I know. [07:00:22] *nod* [07:00:51] I only wish I could see you so as to see what the colour is... [07:01:54] Isarra: I think mixed with marktraceur it becomes sort of Maroonish [07:02:02] Not like Maroon 5, more like Maroon 7.5 [07:02:26] You're dark? [07:02:39] Or just sunburned? [07:03:20] Isarra: No, but the two colleges I have ties to are both maroon-based in their propaganda, so it shows through [07:03:46] Sounds dangerous. [07:04:18] *nod* [07:04:38] I contacted Ecolab to make sure it's not toxic to small children, but they have a 6-month backlog [07:04:52] They did seem optimistic, though [07:05:07] Small children need exposures to such things, though, or they will never develop a proper immunity. [07:05:43] Isarra: True, immunity to irrational and undeserved loyalty is a fundamental lesson that should always be learned [07:05:52] ...at as young an age as possible. [07:05:54] Yes. [07:05:59] Exactly. [07:06:15] Like an immunity to iocane powder. [07:06:20] We should start a program brainwashing children to resist brainwashing. [07:06:52] New review: Nischayn22; "I guess its time for this one to get in." [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/52452 [07:06:54] Isarra: I think this community is already kind of like that [07:07:06] Mayhap. [07:19:52] Heh, bawolff. [07:20:22] Sensible fellow. [07:20:32] Even if it does take multiple tries. [07:20:37] Heh. [07:33:12] Isarra: What keeps you up late on a Saturday? [07:35:01] Panic. [07:36:25] Isarra: Oh dear - nothing too terrible I hope [07:40:46] Just life. [07:40:54] * Isarra hugs marktraceur and wanders off to slee pas well. [07:42:18] * marktraceur hugs back [07:42:29] Sleep well! I hope life is awesome tomorrow. [07:42:53] It'll be horrible. [07:43:29] Aw, come on. You can't know that. [07:44:11] Plausibility says so. [07:45:12] Isarra: Well, a reasonable strategy for me has been to retreat into IRC where there are cool people. [07:45:38] But this will all be over soon enough - I should be graduating in about a week, and from there I just have to get a job and move on with my life and turn into some kind of productive member of society! [07:45:51] ...there will definitely be hiding on IRC involved. [07:46:04] Woo! [07:46:09] Woo to all of that. [07:47:23] I'm scared. [07:47:43] * marktraceur nods [07:49:44] Isarra: There's certainly cause to be scared, but more importantly cause to be excited! [07:50:08] Look, out there on the horizon: There's life in them thar hills [07:52:11] Sure... except there's a very real possibility that it will all go horribly wrong or just generally fail... [07:52:44] Isarra: Exactly, and then you do the next thing [07:53:03] Unfortunately failures here rule out a lot of next things. [07:53:17] Hm. [07:54:04] For instance if I fail to graduate again, that may mean something to potential employers... [07:54:51] Hm. [07:55:02] (again) [07:55:39] Isarra: Sleep sounds like the best plan :) talk more tomorrow, maybe. [07:55:43] I'm not so good with this whole university thing. [07:55:52] Sleep is always a nice plan. [07:56:41] I mean for you; my roommate is being entertaining [07:56:55] Pour sauce on the person. [07:57:28] ...hm, your chaos ESP is strong tonight, I happen to have a half quart of curry right here. But that would be *so* lame. [08:04:13] The lameness is what makes it special. [08:04:33] Well, mostly lame because it would ruin the couch [08:04:54] Oh. [08:23:45] New patchset: Nischayn22; "GroupProgressBar: Only show status "finished" once" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/54127 [08:25:13] marktraceur: Really looking forward to improve the progress bar of UW ^ [08:29:31] Indeed [08:30:16] Nischayn22: Rebasing and making changes at the same time is not ideal [08:30:38] marktraceur: Did I mess up something? [08:30:41] But I'll review it later [08:30:49] No, no, just...it's harder to review [08:31:23] marktraceur: yes, it can be.. But otherwise you have to review twice [08:32:48] Well [08:32:50] Sort of [08:33:02] Basically, Gerrit needs to have better support for rebases [08:34:43] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [08:37:39] New patchset: Nischayn22; "Change addHolder calls to addHolders as per change in AbuseFilter" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/52454 [08:54:34] New patchset: Nischayn22; "Customizable headings for feedback responses" [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/49471 [08:55:39] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/49471 [09:17:12] New patchset: TheDJ; "MathJax: Update to version 2.1" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [09:21:18] New patchset: TheDJ; "MathJax: Update to version 2.1" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [09:27:57] New patchset: Nischayn22; "Link to custom copyright tags were wrong." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53041 [09:57:07] New patchset: TheDJ; "Bug 41677: Protect against tex nodes wrapped in tex nodes." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61252 [10:16:15] New patchset: Amire80; "Remove RTL-specific CSS rules" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/61051 [10:32:22] New patchset: TheDJ; "Bug 35477: Improve transformations of iint and oiint" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61253 [10:43:13] New review: Physikerwelt; "To my mind MathJax should only render the tags converted by" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61252 [10:44:22] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60998 [10:44:24] New review: Physikerwelt; "the link is" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61252 [10:46:01] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61032 [11:11:07] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60985 [11:11:42] New patchset: Amire80; "Use wmf geoip by default" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60995 [11:19:27] New patchset: Mwjames; "Nicified smwgQEnabled handling in ask/show" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60623 [11:25:36] New patchset: Amire80; "Use wmf geoip by default" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60995 [11:26:28] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60995 [11:26:41] New patchset: Amire80; "Load ULS language list from a resource loader module" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60996 [11:38:59] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60996 [11:49:33] New patchset: Physikerwelt; "Merge "Remove even more unused variables"" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61254 [11:49:33] New patchset: Physikerwelt; "merge" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61255 [11:50:41] Change abandoned: Physikerwelt; "completely wrong" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61255 [11:51:23] Change abandoned: Physikerwelt; "completely wrong" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61254 [11:52:47] New review: TheDJ; "For this case that would not matter. It's generated because people put math inside html attributes, ..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61252 [11:56:26] New review: Matmarex; "It's been a month and a half. Has anybody discovered any issues, or maybe this could finally be merged?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:06:52] New patchset: Physikerwelt; "introduce setter and getter" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [12:09:39] New review: Physikerwelt; "OK. You are right." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/61252 [12:09:53] New patchset: Matmarex; "(bug 658) don't use a for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:10:14] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61252 [12:10:27] New review: Matmarex; "Big manual rebase: moved release notes to 1.22, adjusted new parser tests added in the meantime, rem..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:13:52] New patchset: TheDJ; "MathJax: Ignore pagecolor command" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61256 [12:14:26] New patchset: Matmarex; "(bug 658) don't use a
for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:14:52] New review: Matmarex; "Rebased on master once again, for real this time." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:16:51] New patchset: Karim.rayani; "Feature: PDF, Scenario: Click on Download as PDF link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61257 [12:17:04] New review: Matmarex; "So what about this? Can we have the issue fixed?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36391 [12:18:35] New review: Physikerwelt; "for me it looks good, the only difference I could notice is the new version number." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/61251 [12:19:04] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [12:21:12] New review: Matmarex; "> I think the text-transform is fine, but I think it should be opt-in rather than opt-out." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61065 [12:21:52] New patchset: Amire80; "Add a caret for the ULS in the sidebar and adjust its position" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [12:23:18] New review: Matmarex; ""Remember your login" still sounds wrong. CC-ing some designer people." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54326 [12:23:57] any git gerrit masters around ? [12:24:07] i have this patch on a branch that i want to get into master... [12:24:33] i wouldn't call myself a "master", but let's say i'm competent with git (gerrit - not so much) [12:24:52] thedj: you probably just need to cherry-pick it [12:25:06] `git checkout master; git cherry-pick ` [12:25:24] actually, if there's nothing else on the branch, you daon't need to do anything but push it for review [12:25:49] thedj: do you mean that branch is what you want merged with master? or just one specific commit on that branch? [12:26:18] thedj: also - a git branch, or a gerrit "branch"? [12:26:26] DanielK_WMDE: no, gerrit branch [12:26:26] (i assumed the latter) [12:26:27] also, is that a branch on gerrit, or a local branch? if the former, is your change already merged into that branch? [12:26:44] https://gerrit.wikimedia.org/r/#/c/23088/2 that one. [12:27:09] thedj: that is already merged into master [12:27:20] ("Branch: master") [12:28:26] the code isn't there for some reason... [12:28:47] and the only comment that references merged says: Physikerwelt Dec 9 16:47 [12:28:50] Change has been successfully pushed into branch LaTeXML. [12:28:59] there is not Change has been successfully pushed into master [12:29:57] New review: Matmarex; "See inline. Also, needs rebase." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/55498 [12:30:26] thedj: huh, I see what you mean [12:30:31] huh, that;s funny [12:30:40] and "Included in" says the same [12:30:41] lol gerrit. [12:30:42] that sounds like serious gerrit confusion to me [12:30:48] indeed [12:30:52] thatsounds like a sunday [12:30:53] ~ [12:31:15] thedj: well, you can just cherry-pick the commit onto master and submit that to gerrit. [12:31:19] thedj: if i were you, i'd just cherry-pick on master [12:31:24] that's the usual way to port stuff between branches [12:31:47] but it's indeed strange... gerrit appears to be confused about this change. perhaps you do need a gerrit wizard :) [12:33:03] ok. git push gerrit HEAD:refs/for/master/rgbcolors would work for push ? [12:33:17] or is the ref different for master than for branch names ? [12:33:20] i think it's just `git push gerrit HEAD:refs/for/master` [12:33:29] assuming you want to push to master [12:33:30] k, let's try that. [12:33:45] you've cherry-picked it? [12:33:59] yes [12:34:01] To ssh://hartman@gerrit.wikimedia.org:29418/mediawiki/extensions/Math.git ! [remote rejected] HEAD -> refs/for/master (change 23088 closed) [12:34:11] the "refs/for/xxx" is for where do you want to push it [12:34:20] not for where you are pushing from [12:34:26] (that is the "HEAD" part) [12:34:32] ah, yes [12:34:33] thedj: i use "git review master" [12:34:35] kill the change-id [12:34:42] no, keep the change id [12:35:00] New patchset: Mwjames; "I93296527981 follow-up + unit test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61258 [12:35:01] kill it, since apparently gerrit doesn't understand what's happening [12:35:03] it's the same change appied to multiple banches [12:35:06] it sees the patch already on master [12:35:11] so it won't let you push it this way [12:35:17] or change the last character or something [12:35:21] hmpf [12:35:22] or just call ^demon here [12:35:44] so, gerrit thinks it's a change on master, and thinks it was merged into master, while it wasn't. [12:35:45] and have him unbreak it [12:35:45] that sucks [12:35:54] yea, a new change id would solve that, but... ugh... [12:37:22] DanielK_WMDE: i think because it was based on master originally. that's what is confusing it. [12:37:31] New patchset: Matmarex; "Deleted the collapsibleTabs module from the Vector extension" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/56711 [12:37:52] New review: Matmarex; "Manually rebased, there was a conflict with I164f1725." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/56711 [12:38:01] thedj: yes, but usually, gerrit should know which branch it was acutally marged with. it seems confused about that [12:38:12] perhaps Physikerwelt did something evil when pushing to that other branch [12:38:21] New review: Matmarex; "So, can we get this merged at last? :)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/55524 [12:38:27] something that would confuse gerrit [12:38:32] New patchset: TheDJ; "Add support to MathJax for RGB colors" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61259 [12:38:34] well, anyway, gotta go [12:38:46] New review: Mwjames; "1) Scribunto_LuaStandaloneInterpreterTest::testGetStatus" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61258 [12:40:22] New review: TheDJ; "Was already merged before in https://gerrit.wikimedia.org/r/23088 but something went wrong." [mediawiki/extensions/Math] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61259 [12:40:23] Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61259 [12:41:05] There, now only gerrit is a bit confused, but at least history and commit are preserved. [12:41:42] New patchset: Mwjames; "I93296527981 follow-up + unit test " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61258 [12:45:11] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61258 [12:49:52] Change abandoned: Hashar; "I dont think there is any point in keeping this patch around. It is never going to land in 1.19, I a..." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/23999 [12:54:58] New patchset: Hashar; "Fix PHPUnit ORM Tests to work with Postgres" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58422 [13:05:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58422 [13:18:02] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [13:18:17] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [13:24:21] MatmaRex: the genitive stuff.. [13:24:35] what about it? [13:26:30] MatmaRex: your patches add them as messages always to the language object, whereas Krinkle says that they should be pulled with an API request ? [13:26:43] is that a proper summary ? [13:29:06] thedj: well, yeah [13:29:15] but i don't see the point for using API requests there [13:29:41] since for one, that's an unnecessary HTTP request for a tiny bit of data we can preload in this way [13:29:57] and second, we're not doing this for the rest of monthname-related items [13:30:18] tablesorter could use a refactoring, but this seems like a bad way to start [13:31:12] by the way, that snippet looks like it should go into a core module by itself [13:31:22] it could make people's lives easier [13:32:02] yeah indeed [13:41:53] New review: TheDJ; "Mostly a few cosmetic issues." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/60882 [13:42:11] New patchset: Mwjames; "Move SMWAggregatablePrinter (SMW\AggregatablePrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61260 [13:43:57] thedj: I saw you worked around your gerrit problem already. That was a gerrit bug back in 2012. While some such erroneously marked 'Merged' changes might still be in our gerrit's database from back then, the problem was fixed in end 2012 (Ib23e4242dbb7bc1a02a858c33fa7cf9f2e9acbc4 in upstream gerrit) and should no longer happen for new changes. With our current gerrit, I cannot reproduce the problem. [13:45:41] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61260 [13:49:44] New review: Matmarex; "Bumping. I'd really like that bug fixed, it was regression introduced back in March..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58684 [13:50:40] qchris: ok, good to know [13:51:21] New patchset: Alex Monk; "Fixes for most JSHint warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/59064 [14:04:46] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [14:05:52] New review: Alex Monk; "Code style and rebase needed" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60871 [14:06:22] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58684 [14:07:03] New patchset: Physikerwelt; "Introduce getter and setter for the MathRenderer" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [14:08:18] New patchset: Victor Vasiliev; "Fix email address formatting in API credits." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61261 [14:13:23] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [14:15:06] New patchset: Amire80; "Changes to show the display settings in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [14:19:31] New patchset: Mwjames; "SMW\AggregatablePrinter docs+" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61262 [14:34:25] New patchset: Matmarex; "Add $wgCascadingRestrictionLevels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [14:35:32] New review: Matmarex; "Also use $wgCascadingRestrictionLevels for the list of "cascadeable" restriction levels, as used by ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [14:39:24] New patchset: TheDJ; "Use $.each() instead of for(in) loop on Array's" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61249 [14:41:11] Change merged: TheDJ; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61249 [14:56:56] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:08:22] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:09:11] New review: Jeroen De Dauw; "Merge so fix gets into 1.22wmf3" [mediawiki/extensions/EducationProgram] (master) C: 2; - https://gerrit.wikimedia.org/r/60376 [15:10:21] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60376 [15:19:50] New patchset: Mwjames; "Move Query related files into /query/ subdirectory" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61263 [15:22:36] New review: Nischayn22; "I know I made this change, but I am worried now that its wrong." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61249 [15:34:22] New patchset: Mwjames; "Move Specials realted files into /specials/ subdirectory" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61264 [15:34:32] New patchset: IAlex; "Fix email address formatting in API credits." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61261 [15:37:29] New review: Mwjames; "[1] should be merged first as it tests all specials registered." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61264 [15:39:10] New patchset: Mwjames; "Move Specials related files into /specials/ subdirectory" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61264 [15:40:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61261 [15:43:48] New review: TheDJ; "I noticed that you can never remove the initial category. It doesn't seem to receive the control bec..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/9141 [15:45:07] New patchset: TheDJ; "(bug 43593) error for restricted flickr content." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53946 [15:50:09] New patchset: IAlex; "Fixed spacing around parenthesis in includes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61177 [15:52:04] New review: Mattflaschen; "These CSS files are generated code, which is why it doesn't precisely meet the conventions. The sou..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61247 [15:56:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61177 [15:57:36] New patchset: IAlex; "Fixed spacing around parenthesis in languages/tests/maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61176 [16:00:37] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/46960 [16:05:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61176 [16:24:07] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/46960 [16:29:15] Change merged: TheDJ; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/39513 [16:32:55] New patchset: TheDJ; "(bug 40920) handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [16:47:09] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [16:53:35] New patchset: Nischayn22; "(bug 27305) Better error messages." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [17:01:53] New patchset: Alex Monk; "Fixes for most JSHint warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/59064 [17:14:34] New review: Adamw; "Agreed. I'm working on a patch to clean this up in a different way, encapsulating security code wit..." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/23999 [17:22:13] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/49280 [17:22:57] New patchset: Nischayn22; "Catch error thrown by unparseable titles." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/49280 [17:25:22] Hm, I see Nischay patchsets, but no Nischay IRC [17:30:19] Hm, I see defiant Nischay CR comments, but no Nischay IRC [17:31:39] New review: Matmarex; "If64b685c is now merged." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57526 [17:31:44] New patchset: Matmarex; "(bug 46848) fix links inside of collapsible toggles" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57526 [17:32:00] New review: Isarra; "The scss should probably be following applicable general style conventions as well. Dunno if that wo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61247 [17:32:57] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -2; - https://gerrit.wikimedia.org/r/50760 [17:44:53] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/61167 [17:48:11] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61247 [17:49:50] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/60790 [17:49:50] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/60788 [18:04:12] New review: TheDJ; "I don't really like this approach. I would suggesting expanding the config of the licenses in ./Uplo..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/53041 [18:07:55] New review: Swalling; "Glad to see this change! We're trying to follow the same patten in account creation and login, e.g. ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/54326 [18:08:14] New patchset: Kaldari; "Only create notifications that are wanted by the recipients" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61267 [18:08:55] Nischayn22|Away: Just wanna say that I'm glad someone else is taking an interest in UW. [18:09:28] Nischayn22|Away: keep going, it's a tough cookie to bite :D [18:10:15] New patchset: Kaldari; "Only create notifications that are wanted by the recipients" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61267 [18:14:00] thedj: Hey, I am being forced to take interest ;) [18:16:34] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [18:16:35] Heh. [18:19:03] Heh [18:39:37] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [18:46:25] New patchset: Nischayn22; "Add a redlink to dead duplicate file links" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [18:47:38] New patchset: TheDJ; "Check protection status of titles in details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/56371 [18:51:34] thedj: Thanks for coming back to this change, I really didn't know what it was doing [19:06:27] Nischayn22: np. [19:51:26] New review: TheDJ; "I think this might have broken color support in some way." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [20:06:44] New patchset: Poke; "Fix Cite restoration for current Cite extension" [mediawiki/extensions/DynamicPageList] (master) - https://gerrit.wikimedia.org/r/61269 [20:09:02] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #38: FAILURE in 7 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/38/ [20:09:46] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #25: FAILURE in 7 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/25/ [20:30:17] New patchset: Amire80; "Don't let anonymous users change interface language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61271 [20:41:39] Project browsertests-sandbox.translatewiki.net-linux-chrome build #23: FAILURE in 2 min 35 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/23/ [20:44:24] New patchset: Amire80; "Cleanup for jslint and coding conventions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61272 [20:50:43] New patchset: Amire80; "Update webfonts and uls libs from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61273 [20:57:10] Yippie, build fixed! [20:57:10] Project browsertests-test2.wikipedia.org-linux-chrome build #299: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/299/ [20:57:35] New patchset: Ori.livneh; "Add 'troubleshoot' section to README" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60891 [20:57:51] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60891 [21:08:55] New patchset: Adamw; "Cleanup" [mediawiki/extensions/Nonlinear] (master) - https://gerrit.wikimedia.org/r/61274 [21:14:16] New patchset: Adamw; "Unit tests are available for Extension:Nonlinear" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61275 [21:15:58] New review: Matmarex; "What's the status of this? Can we get it merged?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54228 [21:16:22] New patchset: Adamw; "Unit tests are available for Extension:Nonlinear" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61275 [21:22:23] New patchset: Hashar; "(WIP) Mock filebackend for parser tests (WIP)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [21:23:06] New review: Hashar; "Lame attempt at mocking parser tests" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/61276 [21:27:57] New patchset: Hashar; "js jobs are now triggered when a js file change" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/61277 [21:40:24] New review: Parent5446; "So should I just go ahead and submit this? ;)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61276 [21:51:46] New review: Physikerwelt; "all my tests worked." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/61256 [21:52:17] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61256 [21:54:29] New patchset: Ori.livneh; "Default MariaDB character encoding for EL data: utf8 -> utf8mb4" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/61279 [21:54:52] New review: Physikerwelt; "For me color works fine." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [21:55:56] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/61279 [22:14:05] New review: TheDJ; "Nevermind, false alarm. Worked in FF and started working in Chrome when I cleared my Chrome cache. I..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61251 [22:15:29] New patchset: Ori.livneh; "...and back to utf8 as default charset" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/61280 [22:15:42] New patchset: TheDJ; "MathJax: Remove our RGB extension again, added in MathJax 2.1" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61281 [22:16:33] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/61280 [22:18:10] New patchset: Kaldari; "Changing how the enotifusertalkpages user option is handled by Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61282 [22:21:13] New patchset: Kaldari; "Changing how the enotifusertalkpages user option is handled by Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61282 [22:24:03] New patchset: Poke; "Prefix wiki-text redirects with colon" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61283 [22:28:58] Anyone know of any bugs that are making wiki pages blank? [22:29:11] Like I go to load a page and then bang, the browser window is white [22:30:27] Riley|SWMT: yes [22:30:33] there's the wikilove bug thing [22:31:06] Er but I thought wikilove has been disabled already [22:31:25] Riley|SWMT: https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 [22:31:36] right, but other things might cause it apparently [22:32:23] Er but I thought wikilove has been disabled already [22:33:20] [05:31:36 PM] right, but other things might cause it apparently [22:33:50] Sorry, connection issues [22:34:03] I thought Wikilove was disabled already though? [22:34:11] legoktm: [22:34:19] [05:33:19 PM] [05:31:36 PM] right, but other things might cause it apparently [22:34:29] Ah okay [22:34:31] anomie was the one working on it iirc [22:34:35] And this is for all browsers? [22:34:50] not sure [22:35:18] If it matters; I get affected when using Chrome Canary [22:36:59] WikiLove isn't the only thing that causes it. Basically, using mw.loader.using in anything called from an async script can do it. https://gerrit.wikimedia.org/r/#/c/61057/ is waiting on review. [22:37:43] New patchset: TheDJ; "MathJax: Use \mathbf instead \boldsymbol for the \bold command" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61284 [22:37:47] Thanks :) [22:44:19] New patchset: Cmcmahon; "This test only makes sense for enwiki, it runs on beta labs and production right now and should fail elsewhere. This is a workaround for not being able to change an environment variable from a running script" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61285 [22:47:08] New patchset: Kaligula; "(bug47219) Exclude Wikidata edits from Wikipedia feed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61286 [23:09:44] Yippie, build fixed! [23:09:45] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #26: FIXED in 6 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/26/ [23:09:49] New patchset: TheDJ; "MathJax: Support the texvc command \textsf \texttt and \vline" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61287 [23:16:18] New patchset: Reedy; "Check default importImages comment to "Importing file"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61288 [23:33:31] New patchset: Rasel160; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [23:40:04] Yippie, build fixed! [23:40:05] Project browsertests-sandbox.translatewiki.net-linux-chrome build #24: FIXED in 1 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/24/ [23:54:35] New patchset: Tim Starling; "Created ProfileSection class to avoid wfProfileOut() whack-a-mole." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [23:54:55] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [23:56:00] Project browsertests-test2.wikipedia.org-linux-firefox build #281: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/281/ [23:58:04] New patchset: Rasel160; "added support for screen width upto 800px" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61289 [23:59:08] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/61289