[00:00:46] Change abandoned: Kaldari; "We're going to go with a different approach on the defaults." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [00:04:41] New review: Dzahn; "see comment in the file " Whenever adding a new file here, you will have to update puppet configurat..." [wikimedia/bugzilla/wikibugs] (master) - https://gerrit.wikimedia.org/r/54984 [00:23:58] New patchset: TheDJ; "Check If-None-Match header to determine 304 not modified." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [00:25:05] New patchset: Alex Monk; "Tweak account creation interface messages for logged in users" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39862 [00:32:52] New patchset: Alex Monk; "Detect user rights conflicts" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [00:35:35] New patchset: Aaron Schulz; "[JobQueue] Simplified federated queue config by removing wiki/section stuff." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60455 [00:47:04] New patchset: MarkAHershberger; "Disable $wgContentHandlerUseDB during upgrade where fields don't exist." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59369 [00:56:23] New review: MarkAHershberger; "self review" [mediawiki/core] (REL1_21) C: 2; - https://gerrit.wikimedia.org/r/60230 [00:56:24] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60230 [00:57:18] New review: MarkAHershberger; "self review" [mediawiki/core] (REL1_21) C: 2; - https://gerrit.wikimedia.org/r/60234 [00:57:19] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60234 [01:05:02] New patchset: Lwelling; "Set echo preferences for new users after their account is created Default settings for existing users are intended to be low volume and not annoying New users need more encouragement and incentive to return" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60779 [01:08:43] New patchset: MarkAHershberger; "Disable $wgContentHandlerUseDB during upgrade where fields don't exist." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60780 [01:11:01] New patchset: MarkAHershberger; "Disable $wgContentHandlerUseDB during upgrade where fields don't exist." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60780 [01:17:33] New review: Krinkle; "@Dzahn: No, there is no problem with this change. It hasn't been merged, and the change in puppet is..." [wikimedia/bugzilla/wikibugs] (master) - https://gerrit.wikimedia.org/r/54984 [01:35:02] New patchset: Ryan Lane; "Add API action for instance reboots" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60782 [01:35:31] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:35:36] \o/ [01:36:18] and the jslint failures don't surprise me [01:36:31] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60771 [01:37:07] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60446 [01:39:41] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60779 [01:50:03] New patchset: Aaron Schulz; "Changed on-request job running to shell out instead of doing a loop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [02:27:11] New review: Ori.livneh; ":)" [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/60756 [02:27:27] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60756 [03:10:56] New review: Ori.livneh; "Come on, let's do it. https://meta.wikimedia.org/wiki/Change_to_section_edit_links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [03:12:47] New patchset: Spage; "Show newlines and whitespace in schema values." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/60785 [03:14:43] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/EventLogging] (master) C: 2; - https://gerrit.wikimedia.org/r/60785 [03:15:07] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/60785 [03:20:33] New patchset: Lwelling; "Maintainence script to copy the preference of existing users who have opted out of talk page email notifications to the analogous setting in the Echo version of talk notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [04:04:33] New patchset: Spage; "Better test for isGettingStarted()" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60787 [04:13:56] New review: Ori.livneh; "@Krinkle: I think the rationale for the feature and its likely applications need to be stated concis..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56762 [04:17:14] New review: Mattflaschen; "This was actually by design (per Dario), but we agree it's confusing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60787 [04:33:14] New patchset: Mattflaschen; "Allow arbitrary function for okay button, fix to resumeTour:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/60788 [04:35:45] New patchset: Kaldari; "Adding help button to flyout. Fixing ID name per conventions." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60789 [04:36:11] New patchset: Kaldari; "Adding help button to flyout. Fixing ID name per conventions." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60789 [04:44:07] New patchset: Mattflaschen; "Make shouldSkip functions for common actions (edit and submit)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/60790 [04:49:49] New patchset: Mwjames; "Replace MediaWikiTestCase with simpler interface + clean-up unit tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [04:50:16] New patchset: Lwelling; "Maintenance script to copy the preference of existing users who have opted out of talk page email notifications to the analogous setting in the Echo version of talk notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [04:53:29] New patchset: Kaldari; "Only the 'Notifications' part of the header should be bold" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60791 [04:58:56] New patchset: Spage; "Move template header inside form so CAPTCHA works" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60792 [05:02:02] New review: Mwjames; "I can stall this being merged for a day or so but since those tests now derive methods from Semantic..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [05:22:40] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [05:24:18] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [05:31:21] New review: Ori.livneh; "You could save yourself and the database much heartache by being a bit cleverer about this. There's ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [05:42:27] New review: Mattflaschen; "Patch set 10 mainly adds a tour to the navbar, but also makes various other small updates and remove..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [05:53:31] New review: Nikerabbit; "Has anybody checked that this wont interfere with webfonts or ULS?" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60738 [05:56:45] New review: Nemo bis; "What spam fighting? This doesn't help with spam, directly or indirectly." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/16922 [06:21:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60762 [06:30:09] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [06:48:35] New patchset: Aaron Schulz; "Removed unused updateCategoryCounts() from LinksDeletionUpdate." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60795 [06:56:21] New patchset: Aaron Schulz; "Added a wfScopedProfileIn() function to avoid wfProfile() whack-a-mole." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [07:08:39] Yippie, build fixed! [07:08:40] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #31: FIXED in 4 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/31/ [07:28:13] New patchset: Aaron Schulz; "Created wfScopedProfileIn() to avoid wfProfileOut() whack-a-mole." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [08:00:30] New patchset: Siebrand; "Add input checks for Language::sprintfDate()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [08:04:29] New patchset: Zfilipin; "Updated parallel_tests gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60799 [08:04:33] New review: Hashar; "Why dont you simply replace wfProfileIn() with that code?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [08:05:44] New patchset: Siebrand; "Add input checks for Language::sprintfDate()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [08:12:44] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [08:22:16] New patchset: Siebrand; "Add input checks for Language::sprintfDate()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [08:25:15] New review: Nikerabbit; "Filed that as bug https://bugzilla.wikimedia.org/47630 as it is most likely unrelated to this commit..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/60421 [08:26:10] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60421 [08:27:34] New review: Nikerabbit; "Because it needs to be assigned into variable to stay alive - I guess. I'm somewhat worried whether ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [09:21:40] New patchset: Matthias Mullie; "Config var was confusing; all others are ArticleFeedbackv5 prefixed" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60801 [09:38:38] New patchset: Siebrand; "Add some recently added messages as ignored" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60802 [09:40:26] New patchset: Nikerabbit; "Add some recently added messages as ignored" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60802 [09:44:04] hashar, qchris: can you check if a volunteer (karim.rayani@gmail.com) uploaded his ssh key to gerrit correctly [09:44:35] New patchset: Matthias Mullie; "Config var was confusing; all others are ArticleFeedbackv5 prefixed" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60801 [09:44:44] zeljkof: I am lacking permissions :-( [09:44:48] he is getting this error message http://etherpad.wmflabs.org/pad/p/karim_r [09:45:44] qchris: sumana said I you could know the answer :) [09:46:03] maybe hashar will know [09:46:31] it does look like a wrong key installed [09:46:40] or the private key not loaded into the agent [09:46:57] Platonides: he is on ubuntu [09:46:57] zeljkof: Does he see his key in gerrit (web interface)? [09:47:16] Platonides: is there anything specific he has to do? [09:47:23] zeljkof, for what? [09:47:41] qchris: he is not online now, will ask (he is karim_r here) [09:48:01] Platonides: for loading private key into the agent? [09:48:17] usually you do ssh-add [09:48:40] in any case ssh-add -l should list his key [09:48:58] Platonides: I do not see that documented here https://www.mediawiki.org/wiki/Gerrit/git-review [09:49:11] an output like "The agent has no identities" or "Could not open a connection to your authentication agent." is bad :) [09:49:24] Use of ssh-agent is not mandatory [09:49:39] So you can live without it. [09:49:46] but he would need to enter his key passphrase all the time [09:49:53] Yes. [09:50:08] Platonides, qchris: he just needs to do the first commit :) [09:50:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60802 [09:50:22] (pushed to gerrit) [09:52:27] zeljkof: Either way, the line '/etc/host.conf: line 7: bad command `127.0.0.1 localhost'' it his log looks more than just suspicious. [09:52:47] qchris: could the problem be that he cloned the repo using https, not ssh? [09:53:09] zeljkof: the scp should work regardless of where he cloned from [09:53:10] when he comes online, I will ask him to clone the repo again using ssh [09:53:32] we could also try creating a new key [09:53:51] and uploading it again both to gerrit and github, just to check if it work on one or both [09:54:09] I'd just try if he can the scp directly. So something like [09:54:21] scp -P 29418 karim.rayani@gerrit.wikimedia.org:hooks/commit-msg /tmp [09:54:22] qchris, Platonides: thanks for helping me, I can not do much without him [09:54:35] qchris: will try [09:54:42] Ok. [10:02:04] New patchset: Vedmaka Wakalaka; "Extended Page Schemas integration" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [10:08:00] New patchset: Hashar; "git-changed-in-head helper script" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60804 [10:08:34] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60804 [10:09:59] AAAARGH [10:10:09] UnicodeDecodeError: 'utf8' codec can't decode bytes in position 209-212: invalid data [10:10:26] New review: Vedmaka Wakalaka; "I have realized, that we was not able use $template_fields bocause it holds SFTemplateField[], which..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [10:12:07] anyone who can help with git review bugs here? [10:46:08] New patchset: Subramanya Sastry; "Updated wikitext-escaping tests to reflect Parsoid's latest output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [11:23:30] New review: Yaron Koren; "Okay, this is looking better. The $field_options and $template_options additions are a little awkwar..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [11:27:09] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [11:27:10] New patchset: Krinkle; "Monobook: remove OperaNFixes.css files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [11:27:10] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [11:27:10] New patchset: Krinkle; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [11:27:11] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [11:27:11] New patchset: Krinkle; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [11:27:11] New patchset: Krinkle; "mediawiki.log: Add to jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [11:27:12] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [11:27:27] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [11:27:31] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [11:27:36] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [11:27:38] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [11:27:44] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [11:27:45] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [11:27:52] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [11:27:53] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [11:28:42] New patchset: Nikerabbit; "Add refresh-translatable-pages.php script" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60821 [11:28:42] New patchset: Nikerabbit; "Small comment fixes" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60822 [11:35:12] New patchset: Krinkle; "Monobook: Remove OperaNFixes.css files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [11:35:36] New review: Krinkle; "Added release notes and corrected capitalisation in commit message." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [11:36:39] New patchset: Krinkle; "mediawiki.log: Add to jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [11:43:08] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [11:43:09] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [11:43:24] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [11:43:51] New review: Krinkle; "Changed mw.log.warn to take variadic arguments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [11:46:43] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [11:46:44] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [11:48:05] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [11:48:05] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [11:48:06] New patchset: Krinkle; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [12:10:50] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60799 [12:10:50] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60799 [12:18:09] New patchset: Amire80; "Update ULS from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60825 [12:26:12] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60825 [12:26:41] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [12:33:23] New patchset: Amire80; "Scroll the ULS panel into view automatically" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [12:36:50] New review: Matmarex; "Thanks. I didn't add release notes initially, since I2fdd0da8 (which removes a similar file for Fire..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [12:39:11] New patchset: Krinkle; "Remove svnstat stuff used in Doxygen generation" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/60829 [12:39:12] New patchset: Krinkle; "mwdocgen.php: Implement --version option." [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/60830 [12:40:23] New review: Krinkle; "Needed for I1d5b6266e49. Backporting from master." [mediawiki/core] (REL1_20) C: 2; - https://gerrit.wikimedia.org/r/60829 [12:40:41] New review: Krinkle; "Jenkins passes --version, but output at https://doc.wikimedia.org/mediawiki-core/REL1_20/php/html/ s..." [mediawiki/core] (REL1_20) C: 2; - https://gerrit.wikimedia.org/r/60830 [12:45:50] New review: Hiong3-eng5; "Testing. Can you see my comments now?" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/57236 [12:46:26] New patchset: Nikerabbit; "Fix Undefined offset notice" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60831 [12:48:11] hashar: https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/2638/consoleFull [12:48:16] hashar: 12:46:04 Error: 8 attempt to write a readonly database
[12:48:21] It is happening again to REL1_20 [12:48:57] New review: Krinkle; "All tests pass except for a false positive due to a Jenkins problem with read-only sqlite." [mediawiki/core] (REL1_20); V: 2 - https://gerrit.wikimedia.org/r/60829 [12:49:06] Change merged: Krinkle; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/60829 [12:49:14] New review: Krinkle; "All tests pass except for a false positive due to a Jenkins problem with read-only sqlite." [mediawiki/core] (REL1_20); V: 2 - https://gerrit.wikimedia.org/r/60830 [12:49:17] Change merged: Krinkle; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/60830 [12:50:09] New patchset: Krinkle; "Remove svnstat stuff used in Doxygen generation" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60832 [12:50:09] New patchset: Krinkle; "mwdocgen.php: Implement --version option." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60833 [12:50:32] New review: Krinkle; "Needed for I1d5b6266e49. Backporting from master." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60832 [12:51:02] New review: Krinkle; "Jenkins passes --version, but output at https://doc.wikimedia.org/mediawiki-core/REL1_19/php/html/ s..." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60833 [13:00:05] New review: Krinkle; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/60831 [13:00:45] New patchset: Krinkle; "Fix Undefined offset notice" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60831 [13:02:45] New review: Hashar; "fails when the repository only has the initial commit." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60804 [13:08:26] New review: Krinkle; "Indeed, it fails on HEAD^ if there is no parent rev ("fatal: ambiguous argument 'HEAD^': unknown rev..." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60804 [13:11:26] any MediaWiki JS experts around? [13:11:46] * Krinkle whispers [13:11:56] is mediawiki.page.ready.js guaranteed to run before user JS and gadgets? [13:12:16] MatmaRex: the script or the calllback in that script [13:12:16] i'm asking before i start digging into the code :) [13:12:38] no, i'm just asking about the script itself [13:13:09] the $.ready callbacks are as far as i know executed in the order they were added [13:13:19] It is loaded from the bottom queue, so it can run in parallel or slightly after a gadget or user js [13:13:20] so if that script runs first, its callback will run first as well [13:13:28] Indeed [13:14:02] MatmaRex: The traditional work around is to wrap in mw.loader.using('mediawiki.page.ready', function () { $(function () { [13:14:07] you'll see that in a few places [13:14:12] This is why I want mw.hooks [13:14:54] that way you ensure proper execution order, wait until the page.ready module has bound its $.ready handler, and then add your own [13:15:06] MatmaRex: you want mw.util.$content, right? [13:15:30] Krinkle: nope, i'm wondering about the JS bit of https://gerrit.wikimedia.org/r/#/c/49364/30 [13:15:33] (bug 41729) Move section edit links to after the headings [13:16:07] and i'm wondering if it would be better to keep it for consistency, or remove it for sanity of gadget writers [13:16:47] I think I already gave my thoughts on that, though I could be mistaken [13:16:57] yeah, i think you recommended killing it [13:17:04] maybe it could just be moved into page.startup, then [13:17:10] for a different reason though [13:17:48] but avoiding changing the page suddenly confusing gadgets is another reason not to do it. [13:17:58] cached pages will stay as they are, new pages will have the new [13:18:23] apply styles to the new html, not conflicting with old htlm, keep old styles for old html not conflicting with new html [13:18:34] I suppose that's a good enough challenge already [13:18:46] this is going to look really weird for a while until the caches are purged [13:19:24] and if it could be made to (almost) seamlessly change on the cached pages as well, it would be a big win for gadgets, too [13:19:32] especially the old gnarly ones no one dares to touch [13:19:36] like QuickEdit [13:19:36] well, alternatively (for the future) we could have therem be dynamically generated alltogeth [13:19:52] How s? [13:20:03] no need to handle both ways [13:20:21] What is the benefit towards behaviour of gadgets if you do convert the old ones from js after dom ready? [13:20:21] believe it or not, there still exist gadgets not using jQuery for this ;) [13:20:26] why would they need to handle both ways? [13:20:28] and ones which likely rely on nextSibling / previousSibling [13:20:39] because they could encounter both ways until the caches are purged? [13:20:48] unless you're opting for 30 days of breakage [13:20:51] so they pick one (the new one) [13:20:54] but enwikist are going to kill us for it [13:20:58] enwikists* [13:21:07] for one, logged in users don't have squid cache [13:22:00] none of them? [13:22:01] and two, the script ought to already silently fail if the element is not there since it can be disabled with user preferences and with __NOEDITSECTION__ [13:22:18] if you're logged in, you're talking to apaches directly [13:22:23] generating every html page from php [13:22:29] there is still parser cache, of course [13:22:41] but editsection links are only placeholders in there afaik [13:23:15] they're generated in three steps in three different places in the code [13:23:25] the only thing that is cached (from html point of view) is the html parsed from wikitext. the framework/interface is all done from Skin [13:23:25] i think you're right, they're only actually inserted in Skin [13:23:41] okay, i think you have me convinced [13:24:11] i'll kill the JS hack, but place it on the meta page so that sysops can slap it into the site JS, and we can not care about that [13:24:54] You could make it hackier and stick a timestamp check into it so the code will be dead after a month [13:25:12] knowing it is not uncommon to be forgotten about and causing a bug 2 years from now [13:25:13] it'd be simpler to just kill it after a month [13:25:17] it'd become a no-op anyway [13:25:26] not if it changes again [13:25:33] what, the class? [13:25:35] I've seen it happen on various ocasions [13:25:43] anything. [13:25:52] the class name is changing here [13:25:53] moving around elements can cause all kinds of weirdnesses [13:26:03] so unless someone was dumb enough to use class=editsection on wiki pages, this becomes a no-op [13:26:07] Sure, as you said, we can not care. [13:26:16] I'm just giving a recommendation [13:26:34] you put it on a page, it is copied to a mediawiki common js file by someone who will remove it within a month [13:26:44] because the kind of person reading that page is atlike th [13:26:47] is like that* [13:26:48] appreciated :) but i'm fairly sure that apart from the usual troubles with changing the HTML in vivo, this is as harmless as it gets [13:27:22] then someone else copies the entire common.js thing to another wiki for unrelated reasons (e.g. getting legacy collapsibles to work) and there it will stay for all eternity [13:27:57] if we'd have mw.log.warn live you could call that after a month :) [13:28:21] New patchset: Amire80; "Scroll the ULS panel into view automatically" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [13:28:27] My plan is to fast-forward my "Tour de Wiki" by writing a script that detects mw.log.warn calls on wikis [13:28:37] since the manaual way isn't going very fast [13:29:15] Krinkle: re SQLite "attempt to write a readonly database" , I guess two processes are trying to write the DB at the sametime :/ [13:29:18] e.g. visit 3 random pages on every one of the 800 wikis and render it in phantomjs, if mw.log.warn gets called for deprecation warning, log it. [13:29:22] well then, it will just add the overhead of a single getElementsByClassName call forever, then [13:29:35] probably not much worse than instantiating Dates ;) [13:29:39] MatmaRex: Nah, that's not a big problem [13:29:52] Krinkle: hm, interesting idea [13:29:58] Krinkle: no idea what would be the root cause nor how to fix it sorry :/ [13:30:15] MatmaRex: I don't mean efficiency, I mean breakage. Admitted, it is unlikely in this particular case. I was referring to the idea in general (a snippet to be placed in common.js "temporarily") [13:30:20] New patchset: Amire80; "Scroll the ULS panel into view automatically" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [13:30:26] New patchset: Matmarex; "(bug 41729) Move section edit links to after the headings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [13:30:38] New review: Amire80; "Patch set 4 is supposed to address Pau's comments." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [13:30:44] New review: Matmarex; "Rebased." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [13:30:45] hashar: Interesing, though I suspect it is something else, as it is only happening during REL1_20 changes [13:30:54] hashar: And consistently, too. [13:31:22] MatmaRex: Are you familiar with the "Tour de Wiki" [13:32:41] MatmaRex: https://meta.wikimedia.org/wiki/User:Krinkle/Le_Tour_de_Wik%C3%AD/2011_Resource_Walker [13:32:56] MatmaRex: It is an initiative I started 3 years ago after ResourceLoader got first deployed [13:33:03] MatmaRex: The idea is to give wikis a clean slate [13:33:07] New patchset: Matmarex; "(bug 41729) Move section edit links to after the headings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [13:34:10] MatmaRex: Fix all legacy issues from broken scripts from before 2011. You wouldn't believe the things I've seen. Many common.js pages with copy-paste dumps from 2005 and 2006. Random css code pasted on a js page and visa versa. including conditionals for english page names that don't even exist a certain wiki. [13:34:11] etc. [13:34:22] New review: Matmarex; "PS32: removed the JS hack in resources/mediawiki.page/mediawiki.page.ready.js, attmepting to convert..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [13:34:35] though it includes fixing things broken because of ResourceLoader, most if not all are things already broken [13:34:36] New review: Mollywhite; "(1 comment)" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/60367 [13:34:46] Krinkle: oh, i don't doubt it [13:34:51] MatmaRex: I'd love your help. It's been 3 years and I'm still only at 5% [13:35:02] Krinkle: we had a little big cleanup at pl.wiki when RL was being deployed, too [13:35:07] it's a tough pass though, lots of things to check. [13:35:09] although i was mostly just passively watching it happen [13:35:26] basically, almost all of common.js and .css was moved to gadgets [13:35:42] some of them were rewritten in the process, too [13:35:52] sounds like what I'd do, yeah [13:36:08] https://pl.wikipedia.org/wiki/Specjalna:Wk%C5%82ad/Krinkle [13:36:10] and i think that in general pl.wp has one of the saner JS codes around [13:36:29] JS and template, too, but that's not really relevant here :) [13:37:54] MatmaRex: I see pl.wiki still uses the old version of collapsible tables (the javascript I mean). using global functions, href+javascript: [13:37:56] and yeah, Beau was basically the main performer of that clenaup [13:38:21] that's something that will break if the site js is not executed in the global scope [13:38:30] and is bad pratice in general [13:38:32] he submitted a few patches of gerrit around the end of last year, i think they're still sitting in gerrit... [13:38:37] (copied from en.wiki anno 2006) [13:38:47] Could you fix that? [13:40:31] likely :) i'd have to see how it's done properly [13:40:38] as i assume there is an universal way [13:41:09] is that just a matter of adding a few mw-collapsible classes in strategical locations? [13:41:20] No, I wouldn't convert it to use that [13:42:03] In fixing it on dozens of wikis (as part of larger cleanup) I think I fixed it in dozens of slightly different ways [13:42:30] when I took it as a separate thing (more dedicated to upgrade this one) I put it in a separate gadget on wmfwiki and mediawikiwiki [13:42:36] look for it on mediawiki.org [13:43:04] basically, clean up bad coding (new Object(), href="javascript:globalfunction()" => event handler) [13:43:14] i'd rather have less code to maintain than more :) [13:43:18] new Object() -> {} [13:43:19] yeah, i could do that, sure [13:43:28] but it'd still be old hairy code [13:43:41] and this kind of mix is in my experience the worst [13:44:14] frankly, if this was about to break, i'd just add a "window." before those funciton names ;) [13:44:16] MatmaRex: Well, to avoid deeper migration I think its best to ensure thorough migration instead of forwarding it [13:44:25] this is clearly against the "art" [13:44:31] but would most likely still work [13:44:33] so you fix the immediate breakage and then tell the wiki to change prettytable to wikitable and collapsible to mw-collapsible [13:44:53] actually, i was meaning to ask someone about one thing [13:45:11] MatmaRex: As the tour prescribes, it isn't about fixing the immediate breakage, but making it 'right'. There is no rush. [13:45:17] is it possible for mere mortals like wiki sysops to include some "tracking" code into some functions, so that it would be known if they're actually called by anything? [13:45:38] tracking to where? [13:45:41] i know analytics or e3 of whoever does that, i'm just wondering if it's pluggable [13:45:44] use search? [13:45:48] and if it's okay under toe privacy policy [13:46:05] called in what way, what kind of functions [13:46:16] nothing in particular. just wild thoughts. [13:46:56] i know i can scan the dumps or something [13:47:09] there is a search function [13:47:10] .. [13:47:49] https://pl.wikipedia.org/w/index.php?title=Specjalna:Szukaj&search=addonloadhook&fulltext=Search&profile=all&redirs=1 [13:48:49] well, this isn't exactly pretty output, is it. but thanks, i was under impression it doesn't work that way, i'm not sure why [13:49:00] probably it didn't work once when i tried and i gave up [13:49:05] I agree it isn't pretty [13:50:04] Change abandoned: Ganeshaditya1; "Amending the old change" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60388 [13:50:30] New patchset: Ganeshaditya1; "In the last screen of the installer I've added a Info box which carries two links one to the extensions manual and another to the list of extensions available sorted according to there category. This message has been added to the i18n file in both the eng" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59819 [13:51:11] New patchset: Ganeshaditya1; "Added a info box at the end of the page which carries a link to the extensions manual and a link to browse extensions by categories or to view extension matrix to the last screen of the installer at the bottom of the page. All the messages are in i18n and" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [13:52:01] Change abandoned: Ganeshaditya1; "Amending the old change" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59819 [13:58:21] New review: Cscott; "A few 'disabled' which should be 'parsoid'; a few cases where you seem to be changing test cases whe..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60812 [14:03:01] Change merged: jenkins-bot; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60832 [14:04:04] Change merged: jenkins-bot; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/60833 [14:06:59] New patchset: Ganeshaditya1; "Adding a MediaWiki Extension link to the installer last screen" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [14:14:34] New review: Aklapper; "My comments on Patch Set 3 still stand." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59395 [14:25:00] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60034 [14:30:26] New patchset: Platonides; "Remove globals unneeded after 47d1060" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60843 [14:30:45] New patchset: Hashar; "use git show instead of git diff to find changed files" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60844 [14:31:14] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60844 [14:37:12] New review: Platonides; "It may generate lots of "unused variable" messages by some static analysers, but seems good for most..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [14:39:49] New review: Hashar; "deployed a second ago." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60015 [14:43:57] anomie, ok, so it would be ideal to get started on # 1 [14:44:52] yurik: (from #mediawiki) As far as #3, I think I'd prefer backend classes that implement the actual functions, with UI and API as two different interfaces to it. Of course, right now we're a bit on the opposite side of that, with a lot of UI mixed into the "backend" classes. [14:45:34] yurik: Are you talking a presentation, or trying to get people to actually write code for #1 at the hackathon? [14:46:00] anomie, i think we could get started writing something [14:47:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60843 [14:51:04] What are you wanting to write, exactly? [14:55:19] First thing, I think, would be to take the RFC and the various feedback on the talk page and put together an actual blueprint. [14:55:27] yurik ^ [14:57:47] New patchset: J; "add maintenance script to retry failed transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [15:01:41] New patchset: J; "only filter out files not directory" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57040 [15:05:03] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in last screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:05:36] anomie, i will look through the comments again, but i think most of them have already been (partially?) addressed. I still don't have a clear vision of tokens (brion and others had ideas, but i don't understand the topic well enough to write a good spec) [15:05:46] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in last screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:06:09] New patchset: Hashar; "erb linter on ops/puppet" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60856 [15:06:22] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in last screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:06:22] so in a way i am thinking of that RFC as the blueprint [15:06:28] at least most of its parts [15:06:39] the content API should probably be moved out of it [15:06:46] into a separate RFC [15:07:45] yurik: As for tokens, I think the biggest unanswered questions are whether we really need different tokens for different actions and/or whether any tokens need to depend on the user, page title, etc. Much of which is really a question for csteipp. [15:08:17] so… i'm the one that introduced the token salt option, which is what makes separate tokens for some actions [15:08:42] i only did that so that things that would be included in GET URLs (like rollback links) wouldn't expose your editing token [15:08:51] if you copy-pasted the link somewhere [15:09:03] if we're doing those by ajax or form submission these days… then it's probably not necessary [15:09:04] yurik: As for the comments, it seems to me that there are a number of unanswered questions floating around in them. [15:09:17] it simplifies things immensely to have a single session csrf token :) [15:10:18] New review: Ganeshaditya1; "Throw me a bone @aklaper. I have made some tremendous changes since patch 3." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:11:01] brion: OTOH, having a different token for sensitive stuff like checkuser might make sense, since there's less opportunity to accidentally leak it than there is a general do-anything token. [15:11:20] perhaps [15:11:23] New patchset: Brian Wolff; "Allow handler specific parameters in (page number, etc)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60858 [15:11:57] And there's something to be said for using the same token for the same operation whether it's UI or API. E.g. generating those rollback links from a script. [15:12:41] (instead of requiring the script to make pseudo-links that require a js callback, and therefore can't be opened in a new tab or whatever) [15:14:48] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in last screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:15:19] anomie, brion, lets discuss token implementation details in amsterdam - at this point I really want to just get the structure of our meeting there in place, otherwise we might not even get to tokens :) [15:16:13] ok :D [15:16:15] do we want to reserve a small room and iron out these specs? [15:16:32] probably wise. [15:16:37] or do we want to grab as many devs as possible and let everyone grab items from the api and work on them? [15:16:51] maybe a little of both [15:17:05] iron out a proposal, get people to poke at it, and then revise it? [15:17:09] brion, how do these things usually go at hackathons? [15:17:39] i mean - i have a huge wishlist of crap to be done - what's the best approach to bring it into existance :) [15:18:01] well, my experience is usually that i end up in a whirlwind of being briefly consulted about everything :) [15:18:09] If it's anything like last year, there's presentations in the morning where someone gets up and talks for an hour with maybe some Q&A, then in the afternoon there's basically "general hacking" where people just get together and do stuff. [15:18:33] if you've got key goals then yeah, present some base ideas and invite folks to come work on it [15:19:13] hi all [15:19:16] ok, so i will revise the RFC, move things around a bit, and mark implementation details as TBD [15:19:17] hi sumanah [15:19:18] hi sumanah! [15:19:19] are y'all talking about Amsterdam? [15:19:23] yep [15:19:23] yes [15:19:28] ok. so anomie is a bit wrong [15:19:30] echo [15:19:38] "presentations in the morning where someone gets up and talks for an hour with maybe some Q&A" - that is inaccurate [15:19:50] these are meant to be intensely hands-on trainings [15:20:06] * anomie pays attention to learn [15:20:08] your hands should be on keyboard the entire time, learning, etc [15:20:40] if they felt like presentations then please let me know so we can be harder on the trainers next time [15:21:07] but overall, the plan is: at all times, of course you are free to go off by yourself or in groups and hack together [15:21:15] * anomie must have attended the wrong sessions last year [15:21:20] :) [15:21:25] but the scheduled opt-in trainings are going to be in the mornings, yes [15:21:37] * brion checks the current schedule [15:21:38] New patchset: Amire80; "Return Zyyy for an undetermined language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60862 [15:21:57] anomie: https://www.mediawiki.org/wiki/Berlin_Hackathon_2012 - which ones did you hit? [15:22:13] sumanah: will the tutorial sessions be assigned before we get there or picked unconference-style? [15:22:34] New patchset: Hashar; "ops/puppet: lint ERB templates" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60863 [15:22:40] brion: so, anyone can of course decide "hey I want to lead a tutorial" and do that *in addition* to the ones scheduled ahead of time [15:22:45] sumanah: Lua, Optimizing MySQL, writing secure code, and Gadgets 2.0. I forget which I attended when, though. [15:22:47] New review: Aklapper; "It's certainly very nice that you make progress, I just pointed out that my remarks were not fixed y..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59395 [15:23:04] brion: we'll be scheduling ~5-6 of them ahead of time and they will be Sat morning and Sun morning, probably [15:23:10] New review: Matmarex; "So what about this? It's been sitting with no reviews since February..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [15:23:13] sumanah: spiffy! [15:23:45] anomie: I know it's been almost a year, but if you remember which ones felt very TV-like and which ones were more engaging, let me know [15:24:16] New review: Matmarex; "Argh, someone please finally merge this. I submitted this nearly three months ago." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [15:24:42] brion: Rachel Farrand has reached out to some WMF folks to prep tutorials [15:25:16] the goal: have all the notes, slides, text, etc. onwiki before anyone arrives in Amsterdam, and have the trainers go through at least 1 practice session before the Amsterdam get-together as well [15:25:28] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in installation comepletion screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:25:35] i'll keep an eye on the page… and i assume some more emails will go out too as we get closer :) [15:25:48] (this is for the ~5-6 scheduled tutorials, ~3 of which would be by WMF people and ~3 of which would be by people in the larger community) [15:26:00] nice [15:26:05] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [15:26:11] Yes, more emails will be going out [15:26:17] sumanah: secure code had some "here's a problem, look at it for a few minutes then we'll go over the right answers". The rest were mostly "Here's stuff. Questions or examples you'd like to look at?". I suppose "and maybe some Q&A" should be rephrased as "and then a good bit of Q&A". [15:26:33] dammit. [15:26:45] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in installation completion screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:27:00] New patchset: Subramanya Sastry; "Updated wikitext-escaping tests to reflect Parsoid's latest output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [15:27:01] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60863 [15:27:09] New patchset: Ganeshaditya1; "Modified the installer to show a tip about extensions in installation completion screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:27:22] I imagine the Git/Gerrit one was more hands-on, but since I was already somewhat familiar with Git/Gerrit I didn't go to that one [15:27:29] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [15:28:03] Yes, the Gerrit/Git one was very very hands-on [15:28:27] * sumanah looks at https://www.mediawiki.org/wiki/Secure_coding_and_code_review_for_MediaWiki/Tutorial , https://www.mediawiki.org/wiki/Gadget_kitchen/Training , https://www.mediawiki.org/wiki/Lua/Tutorial https://www.mediawiki.org/wiki/Manual:Database_layout/MySQL_Optimization/Tutorial [15:28:30] New patchset: Ganeshaditya1; "Modifiying the installer to show a tip about extensions in installation completion screen." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:28:35] New review: Subramanya Sastry; "I went ahead and changed 'disabled' to 'parsoid' on lot of tests. There are still a few left and I ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [15:28:43] New review: Parent5446; "...or you can use the MWTimestamp class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [15:31:04] New patchset: Alex Monk; "Get rid of wikipedia logo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60867 [15:31:15] anomie: well, argh. I know the secure coding tutorial was supposed to have a collaborative writing session - it had it in the syllabus. It sounds like it did not happen, which sucks [15:31:22] I blame Tim [15:32:02] similarly the Gadget training https://www.mediawiki.org/wiki/Gadget_kitchen/Training was supposed to have some exercises of stuff people would do, hands-on, right there in the session. It sounds like that didn't happen? Mystifying [15:32:37] sumanah: I may have forgotten that part. I know they recorded videos, but it looks like no one linked them from anywhere? [15:32:39] https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_%28users%29/Tutorial hmm, right, this was the one they did. So it was interactive but not as hands-on [15:32:55] anomie: https://www.mediawiki.org/wiki/Berlin_Hackathon_2012 "Videos of the Lua tutorial and step-by-step Git-Gerrit installation are now online." [15:32:57] (link) [15:33:11] it took ages and ages for the videos to get onto Commons [15:34:15] All of them are on freaking Vimeo except the db optimization one, which the videographer lost or did not record properly [15:34:42] New review: Amire80; "Sorry, forgot it. I'll test it tomorrow." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [15:34:48] and then https://commons.wikimedia.org/wiki/Category:Hackathon_Berlin_2012 has the Lua, Gerrit, secure coding, & Wikidata stuff [15:39:48] anomie: I had linked to the videos from the Talk page of the hackathon and had linked to the Commons videos from the main wiki page. I've just linked to all the videos from the main hackathon wiki page [15:40:06] I should check on That Last One and get it onto Commons argh [15:42:37] sumanah: Yay video links! Reviewing the Lua video from last year, it looks like that one had more "hands on" ish stuff than I remember from the other session that I attended. [15:45:37] New review: Brian Wolff; "What if some future version of ploticus includes a width and height parameter. Should we perhaps che..." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [15:46:21] New review: Ganeshaditya1; "This is very embarrassing, I have specifically checked those remarks. some how they are not reflecte..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:50:07] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60856 [15:50:11] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:57:17] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:57:20] New patchset: Matthias Mullie; "Bug 42057 - Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [16:05:42] New review: Hashar; "Re gating job." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/60627 [16:06:11] New review: Physikerwelt; "try again" [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/60627 [16:06:36] hi pastakhov, how is your MediaWiki stuff going these days? [16:08:54] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60627 [16:10:15] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57040 [16:11:14] New patchset: Zfilipin; "test for preferences/appearance per the backlog" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60041 [16:11:25] New patchset: Cscott; "Add parserTests for tilde and equals signs in links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60874 [16:11:31] New patchset: Zfilipin; "test for preferences/appearance per the backlog" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60041 [16:12:42] Hmm. PHP 5.4.9... [16:13:05] Change abandoned: Zfilipin; "Moved to the original commit: https://gerrit.wikimedia.org/r/#/c/60041/1..2/features/step_definition..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60671 [16:14:02] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60041 [16:15:17] New patchset: Hashar; "mw/ext/Math enable unit tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60875 [16:16:03] New review: TheDJ; "@Rtdwivedi check which versions of ocaml you are using." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [16:16:14] New patchset: Aaron Schulz; "Fix manually setting duration/offset without file. This can be used by Score make the player load faster." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60644 [16:19:27] New patchset: Amire80; "Don't show tipsy for an unknown language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60862 [16:20:31] New review: Hashar; "Will have to carefully test that out tomorrow :-]" [integration/zuul-config] (master) C: -1; - https://gerrit.wikimedia.org/r/60875 [16:22:06] New patchset: Amire80; "Don't show tipsy for an unknown language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60862 [16:27:25] New review: Lwelling; "That's a pretty good suggestion Ori. " [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [16:27:36] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60876 [16:29:17] Yippie, build fixed! [16:29:17] Project browsertests-test2.wikipedia.org-linux-chrome build #291: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/291/ [16:31:34] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60876 [16:35:11] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [16:35:20] Change abandoned: Brian Wolff; "Superseded by I4bd3d39ec2938a53e2c6728adc48ee6cf9778d74" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55499 [16:40:03] New patchset: Zfilipin; "Running new preferences feature at en.wikipedia.beta.wmflabs.org and en.wikipedia.org" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60878 [16:40:59] New review: TheDJ; "Or perhaps the fonts that the usepackage for farsi requries are not installed for Physikerwelt or so..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [16:41:01] Yippie, build fixed! [16:41:01] Project browsertests-test2.wikipedia.org-linux-firefox build #272: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/272/ [16:41:21] Yippie, build fixed! [16:41:22] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #10: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/10/ [16:41:51] New review: Subramanya Sastry; "Looks like a transient php test failure:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60874 [16:42:02] New review: Matmarex; "Are you volunteering to code that up? ;)" [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [16:42:38] MatmaRex: I walked into that one :P [16:43:38] bawolff: ;) [16:44:05] bawolff: i'd have to figure out how does one write an if() in perl, y'know [16:44:18] Precisely my thoughts :) [16:44:23] stupid perl [16:44:51] If I code it up though, I can't +2 it ;) [16:45:32] actually, that should be simple enough [16:45:40] if we don't mind doing it with more regexes [16:45:59] I think that's fine [16:46:03] if ( $_ !~ / should do. [16:46:14] i wonder if that syntax will work, though [16:46:23] New patchset: Amire80; "Add a caret for the ULS in the sidebar" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60880 [16:46:33] and i wonder if i still have the testing environment set up [16:47:11] you can do it simpler i think [16:47:37] if ( ! /]+(width|height)/ ) [16:47:55] you need the [^>] instead of . otherwise the width could appear on a different element [16:48:32] in perl if you don't specify a variable to operate on, $_ is used by default, from what I understand [16:48:59] ah, i was thinking that there should be a newline after the , but you're right [16:49:04] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [16:49:15] hm, so i can just write the regex without anything? nice [16:49:23] i should learn perl before coding in it. [16:53:40] New patchset: Subramanya Sastry; "Updated wikitext-escaping tests to reflect Parsoid's latest output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [16:54:46] New review: Aaron Schulz; "What is the common case here? Missing or broken transcodes. Maybe non-sysops should be able to resta..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57286 [17:00:33] New patchset: Demon; "Temporary message for skin removal no longer needed" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/60881 [17:07:53] MatmaRex, stay away from it for you sanity sake :) [17:08:47] yurik: i've understood the old version of {{coordinates}}, notihng fazes me now [17:09:59] New patchset: Physikerwelt; "introduce setter and getter" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60882 [17:13:25] New review: MZMcBride; "Bryan or Yuri: do either of you have time to finish this changeset? I guess it would also need to sw..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/40337 [17:20:16] New patchset: Pgehres; "Initial commit of Extension:AccountAudit" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/53683 [17:21:00] New review: Lwelling; "One problem with the soft migration approach is that it will skew metrics." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [17:28:15] j^: I don't see support in https://gerrit.wikimedia.org/r/#/c/53017/23/resources/mediawiki/mediawiki.jqueryMsg.js [17:28:29] I see it in the unit tests, so I guess it is buried in there somewhere [17:28:49] * Aaron|home also doesn't see any good docs [17:30:29] actually maybe it's not and I'm just looking at wikilink handling [17:34:54] New patchset: IAlex; "(Bug 44357) Update checkStorage.php to not use deprecated Revision::getText()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45937 [17:37:22] Change abandoned: Demon; "Bug was closed as already fixed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59067 [17:37:27] Change abandoned: Demon; "Bug was closed as already fixed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59390 [17:39:46] New review: Aaron Schulz; "The _destruct() behavior is well-documented for PHP." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60797 [17:43:02] New patchset: TheDJ; "Tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [17:48:23] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/52745 [17:48:43] New review: Anomie; "Re the SQL issue from the meeting:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60034 [17:49:13] New review: Aaron Schulz; "I see i/b tag support, but I don't see raw "a"/"div" tag support." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [17:49:23] New review: Kaldari; "I mentioned this to the designer, Vibha, and she wants to keep the W icon for Wikipedia, but have th..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/60867 [17:52:02] New patchset: IAlex; "Add parserTests for tilde and equals signs in links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60874 [17:52:02] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45937 [17:52:48] New patchset: Demon; "Show a tip at the end of the installer to prompt about extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [17:53:47] New patchset: Demon; "Show a tip at the end of the installer to prompt about extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [17:56:14] New patchset: Ori.livneh; "Adding Puppet module for User Metrics API" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [17:58:53] Change merged: Demon; [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/52661 [17:59:17] Isarra: I was skeptical about the whole favicon thing, but I'm seeing it now. Rock on. [17:59:47] why does Jenkis look so slow at the moment? [18:00:24] New patchset: TheDJ; "Check If-None-Match header to determine 304 not modified." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [18:00:28] New patchset: Kaldari; "Changing default for email per specs" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60889 [18:00:40] New patchset: Karim.rayani; "Feature: PDF, Scenario: Check for Download as PDF ink" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60890 [18:00:51] !log deploying 42094 [18:00:51] New patchset: Diederik; "Add Troubleshooting section" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60891 [18:01:12] New review: Dzahn; "just deployed on server" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42094 [18:01:18] marktraceur: Which one? [18:01:36] Or... something. [18:02:00] Isarra: I think the Wikipedia one changed, maybe, but the MediaWiki one is much nicer too [18:02:02] New patchset: Kaldari; "Set defaults for email to false per specs" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/60892 [18:02:16] no more "Zarro Boogs found", now boring "Zero reports found" [18:02:29] Aye, we've changed most of them. And yay! [18:02:48] ...well, maybe not most, but several. [18:02:59] Isarra: They're lookin' good, is my point :) [18:03:03] Since a lot of them were good renders that just didn't happen to have multires. [18:03:11] Thank you. [18:03:17] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [18:03:46] New review: Bsitu; "@Nikerabbit, it just happens that this notification has the same text for the archive page and the f..." [mediawiki/extensions/PageTriage] (master) C: 2; - https://gerrit.wikimedia.org/r/59963 [18:04:02] New review: Dzahn; "works for me. ' Zero reports found. ' on test search" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42094 [18:11:55] New patchset: Alex Monk; "Get rid of wikipedia logo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60867 [18:14:44] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/59962 [18:14:57] alolita, Hi I am interested in the jQuery.ime extensions for firefox and chrome as my GSoC project. [18:15:34] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59959 [18:15:52] New review: Lwelling; "Dario tells me that the actual number of user accounts with the old email opt out setting is 1,037,000." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60786 [18:16:04] I needed to discuss/ get suggestions regarding a few features [18:16:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60874 [18:18:16] New review: Anomie; "Note you need a RELEASE-NOTES-1.22 entry for this change, clearly flagging it as a breaking change i..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [18:18:33] New patchset: Zfilipin; "Feature: PDF, Scenario: Check for Download as PDF ink" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60890 [18:18:58] New review: Zfilipin; "I have made the changes that I have suggested." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60890 [18:21:31] New review: Zfilipin; "The new feature works fine on my machine." [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60890 [18:21:31] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60890 [18:22:30] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/59963 [18:23:00] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/60892 [18:23:12] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60889 [18:24:52] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60867 [18:32:15] New review: Aaron Schulz; "New classes need @since tags. The link loader stuff should go in a subdir of includes/ as well." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60034 [18:32:56] New patchset: EBernhardson; "thanks-thanked message needs GENDER support" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [18:34:56] New patchset: IAlex; "Fixed dumpBlocks fcn" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59616 [18:36:35] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60789 [18:41:47] New patchset: Kaldari; "Updating Echo, PageTriage, and Thanks to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60896 [18:42:35] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60896 [18:44:04] New patchset: Zfilipin; "Add new PDF feature to Jenkins jobs" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60898 [18:52:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59616 [19:08:52] New patchset: Cscott; "Add linkprefix test to parserTests.txt." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60900 [19:14:19] New patchset: Alex Monk; "Slightly rephrase message and add link" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/54861 [19:14:40] New review: IAlex; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60798 [19:14:49] ori-l, got a moment? [19:15:12] New review: Alex Monk; "Rebased, re-applying Luke's +2" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/54861 [19:19:31] New patchset: Alex Monk; "Add DisambiguationPages to alias file too" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/60387 [19:19:45] New review: Alex Monk; "Rebased" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/60387 [19:25:19] New patchset: IAlex; "Use wfShellExec in MimeMagic" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60201 [19:29:09] Change merged: Alex Monk; [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/60387 [19:29:48] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/54861 [19:30:36] New review: Swalling; "https://meta.wikimedia.org/wiki/Change_to_section_edit_links is good enough shape that we can link t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [19:35:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60201 [19:37:08] StevenW: you there? [19:37:17] oui [19:37:23] StevenW: mind if i rewrite https://meta.wikimedia.org/wiki/Change_to_section_edit_links#Why_this_is_changing a little? [19:37:43] go for it, it's your patch [19:37:44] there's too much text and too many names no one cares about :) [19:37:45] New patchset: Lwelling; "Fix enabled/disabled logic for event logging in echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60905 [19:38:04] Actually, let me take a quick hack at it [19:38:30] also, i'll describe the change as being intended as less disruptive and more fitting with the current interface than the original mockup, instead of "interim solution" [19:38:35] as, frankly, that's how i intended it [19:38:50] Change merged: Kaldari; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60905 [19:38:58] and, frankly again, i doubt this is going to change now - and if it did, there would be community outcry [19:39:10] i'm actually writing it right now [19:41:12] New patchset: Kaldari; "update Echo to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60906 [19:41:32] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60906 [19:42:08] MatmaRex: https://meta.wikimedia.org/w/index.php?title=Change_to_section_edit_links&diff=5428178&oldid=5427054 [19:42:10] StevenW: https://meta.wikimedia.org/w/index.php?title=Change_to_section_edit_links&diff=5428181&oldid=5428127 [19:42:33] heh. Anyway, be bold. ;) No strong feelings here about editing/cutting stuff. [19:42:34] i overwrote your changes, let me sync it up [19:42:49] ah, you moved the same part up that i did :) [19:44:12] (right, i'm done.) [19:52:31] New patchset: Catrope; "Update VisualEditor to master again to pick up link inspector fix" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60908 [19:52:57] New patchset: Aaron Schulz; "Made auto-review base rev ID handling smarter." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/60909 [19:53:38] MaxSem: hey [19:54:52] ori-l, so I'm working on getting EventLogging into Labs. first, little tweaks at https://gerrit.wikimedia.org/r/#/c/60680/ - but what else is needed? [19:54:54] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60908 [19:55:52] * Reedy hands MaxSem a mallet [19:56:02] MaxSem: oh, wow, that's cool. I haven't done a lot of puppet work on labs so I don't know exactly how roles and modules are shared between the two. Let me look at your change set and poke a bit. [19:56:32] ori-l, but in general, what components are needed? [19:56:48] e.g. I see some scary vanadioum-relay [19:57:36] oh, you don't need that. It used to be the case (not sure if it is, still) that esams bits caches did not have a route to vanadium, so oxygen is configured to relay traffic to it. [19:58:02] but things should be more or less contained in the 'eventlogging' module [19:58:13] mmm, so I need just to direct logs from varnish to it? [19:58:15] what exactly are you trying to do on labs? [19:59:01] set up EL to be able to test our interaction, cause we've had unnoticed breakages before [20:00:42] MaxSem: so manifests/role/cache.pp is the varnishncsa instance that sends relevant log data from the varnishes to vanadium [20:00:48] that's the other bit that is outside the module proper [20:01:17] New review: Mdale; "Is the goal here to enable the disable controls feature to present the native player controls, or ot..." [mediawiki/extensions/TimedMediaHandler] (master); V: 1 - https://gerrit.wikimedia.org/r/57540 [20:03:15] I'm going to read your change and look around for a few, please wait [20:08:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60900 [20:11:05] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #32: FAILURE in 9 min 11 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/32/ [20:11:06] New patchset: IAlex; "test: describe the parser tests recorder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54653 [20:14:01] New review: Cscott; "Works for me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60812 [20:19:46] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #17: FAILURE in 8 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/17/ [20:20:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54653 [20:21:45] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60618 [20:21:57] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60619 [20:25:11] New patchset: Matmarex; "(bug 47617) Add $wgCascadingRestrictionLevels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:25:47] New review: Matmarex; "PS2: took Tyler's advice. Still needs release notes." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60695 [20:25:58] New patchset: Matmarex; "(bug 47617) Add $wgCascadingRestrictionLevels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:26:23] New review: GWicke; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60812 [20:28:22] New patchset: Matmarex; "(bug 47617) Add $wgCascadingRestrictionLevels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:28:44] New review: Matmarex; "Done." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:29:52] New review: Alex Monk; "Looks good and works, not too confident about some of the i18n changes though." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/60791 [20:33:02] New patchset: IAlex; "Fixed maintenance/tables.sql (typo i guess)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59598 [20:33:58] New patchset: Aaron Schulz; "Updated onTransactionIdle() docs a bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60912 [20:36:11] New patchset: Adamw; "Bad bug broke schema upgrades" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60913 [20:36:40] New patchset: Siebrand; "Add input checks for Language::sprintfDate()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [20:37:00] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60798 [20:37:11] New patchset: Matmarex; "specify width and height of a SVG image to ensure it scales properly" [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [20:37:52] New review: Siebrand; "Can this be revisited, Krinkle?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59010 [20:38:17] New review: Kaldari; "Although this is really stupid, you have to put a space between the bug number and the colon in the ..." [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/60894 [20:38:28] New review: Matmarex; "Per Brian. Note that I didn't test this (I did test the previous patchsets, though, and they worked)." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [20:39:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59598 [20:40:36] New review: Matmarex; "Why are you changing all of the messages? This will prevent them from showing up as containing error..." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [20:40:47] Change abandoned: Siebrand; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56932 [20:46:19] New patchset: EBernhardson; "Prevent short-term duplicate thanking via session" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60914 [20:49:14] New patchset: Adamw; "A bug which would have affected amazon payments when payment_method is set." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60915 [20:52:11] New patchset: EBernhardson; "thanks-thanked message needs GENDER support" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [20:52:40] New patchset: EBernhardson; "thanks-thanked message needs GENDER support" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [20:53:51] ori-l, what else will I need, a database? [20:54:08] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [20:54:24] MaxSem: depends on what kind of verification you want to do. the setup up to and including the zeromq publisher stream is a discrete whole; where the data goes after that is up to you [20:54:40] New review: Mwalker; "Some silly things that need to be corrected -- documentation and I want you to revisit historical ba..." [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/59051 [20:55:09] MaxSem: if all you want to do is to be able to see data as it comes in in the console, then you don't need a database [20:55:15] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60737 [20:55:43] New review: Mattflaschen; "See previous comment." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/49364 [20:57:09] New patchset: Ottomata; "Adding user_metrics dev env module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [20:58:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60912 [21:00:22] New review: Spage; "Deploying" [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60738 [21:02:27] New review: Spage; "Deploying" [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60764 [21:05:26] New review: Cscott; "gwicke's right, there's a bogus minus sign. I misread the diff when I saw it earlier, sorry." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60812 [21:05:54] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [21:07:46] New patchset: Matmarex; "(bug 41729) Move section edit links to after the headings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [21:08:09] New review: Matmarex; "Fixed the comment, thanks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [21:08:13] New review: Spage; "Deploying this" [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60739 [21:09:35] ^demon , E3 is backporting a chain of commits to 1.22wmf2, e.g. https://gerrit.wikimedia.org/r/#/c/60764/ . Does it help Jenkins/zuul to wait for parent gate-and-submits to complete before +2ing the next in the series? [21:10:21] <^demon> I generally approve them in order, so zuul doesn't try to merge too soon. [21:10:58] <^demon> I'm not sure how smart zuul is about *waiting* though. [21:12:22] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60738 [21:13:14] New patchset: EBernhardson; "thanks-thanked message needs GENDER support" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [21:16:42] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60764 [21:17:03] Change merged: Mattflaschen; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60739 [21:19:56] New review: Spage; "Deploying this." [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60740 [21:20:00] New patchset: Reedy; "Parameter type hints" [mediawiki/extensions/HTMLTags] (master) - https://gerrit.wikimedia.org/r/60598 [21:21:24] ^demon thanks. Now it seems jenkins-bot isn't triggering the gate-and-submit jobs, e.g. https://gerrit.wikimedia.org/r/#/c/60740/ [21:21:25] New review: Mattflaschen; "I'm not sure it's a CSS issue. .mw-section was actually present in the DOM immediately before .mw-h..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [21:23:15] New review: Spage; "Deploying this." [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60765 [21:24:16] <^demon> Hmm, noticed that earlier for a different repo. [21:24:22] <^demon> Antoine did just upgrade zuul the other day. [21:24:38] <^demon> spagewmf: For deployment branch, just go ahead and merge yourself and ignore jenkins. I think it's sick. [21:26:02] ^demon it got through the first two slowly (long pause on mediawiki-core-phpunit-parser), but done give up now. [21:27:42] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [21:28:46] Change merged: Mattflaschen; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60741 [21:29:11] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60765 [21:29:46] New review: Demon; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58281 [21:30:05] New review: Matmarex; "I *think* this is a parser cache issue ? the link in generated partially in the Parser/Linker, as a ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [21:30:42] daaaamn. [21:30:45] stupid parser. [21:30:54] graaagh. [21:31:44] New review: Mattflaschen; "Deploying." [mediawiki/core] (wmf/1.22wmf2); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60792 [21:31:52] Change merged: Mattflaschen; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60792 [21:32:16] New review: Matmarex; "I'll mark -1 until I fix that or I'm certain it's not worth worrying about. " [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/49364 [21:32:44] brion: help me, the parser sucks [21:33:39] https://gerrit.wikimedia.org/r/49364 , last three comments - if anyone's got any magical solutions, that would be great. [21:33:46] (afk) [21:34:36] New patchset: Mattflaschen; "Deploy ConfirmEdit, including CAPTCHA refresh." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60924 [21:34:40] New review: Kaldari; "Just minor style issues." [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/60914 [21:35:55] New review: Ryan Lane; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58281 [21:36:42] New review: Spage; "d74dfc8 is the latest, what we want." [mediawiki/core] (wmf/1.22wmf2) C: 2; - https://gerrit.wikimedia.org/r/60924 [21:37:13] New patchset: Catrope; "Allow iiurlheight to be used without iiurlwidth" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60450 [21:37:25] New patchset: EBernhardson; "MyISAM warning when InnoDB is not available" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [21:37:35] New review: Mattflaschen; "Forcing due to Jenkins." [mediawiki/core] (wmf/1.22wmf2); V: 2 - https://gerrit.wikimedia.org/r/60924 [21:37:40] Change merged: Mattflaschen; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60924 [21:42:06] New review: Rtdwivedi; "I will get back to this in a few days after my exams get over." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [21:43:07] New patchset: Ori.livneh; "Add API action for instance reboots" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60782 [21:43:44] New review: Aaron Schulz; "Release notes don't mention schema change or feature" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/52601 [21:46:25] New patchset: Aaron Schulz; "[JobQueue] Added a delayedJobsEnabled() function." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60929 [21:48:47] greg-g: Can I use the Matthew Walker Ceremonial Deployment Window of Glory today? [21:48:57] * sumanah smiles [21:50:51] Dude WTF is up with Jenkins [21:51:03] It's not running for VisualEditor changes at all any more [21:51:18] ^demon: Do you know? ---^^ [21:51:19] RoanKattouw: btw, did you re-upstream that git-review fix? [21:51:26] <^demon> RoanKattouw: No, I think it's zuul. [21:51:31] I would ask hashar or Krinkle|detached but they're away [21:51:32] <^demon> Noticed it earlier on couple of other repos. [21:51:33] Right [21:51:47] Aaron|home: The rebase stuff? Yes, haven't checked back as to what they've commented though [21:52:01] <^demon> Antoine upgraded zuul like yesterday or the day before. [21:52:06] <^demon> Wonder if it's got a problem :\ [21:52:28] New review: Kaldari; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60926 [21:52:52] Aaron|home: Hmm looks like I didn't explicitly upstream it, I just complained by commenting on the commit that broke it [21:53:24] <^demon> Heh, that's the best way to get things fixed :) [21:53:50] Apparently not :) [21:58:25] New review: Rtdwivedi; "@TheDJ" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [21:59:38] New review: Demon; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [22:00:55] New review: Rtdwivedi; "$LANG: en_GB.UTF-8" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [22:03:24] RoanKattouw: yes, mwalker only has some favicons to push [22:05:36] OK, excellent [22:05:46] I have a config change and probably some JS stuff [22:07:09] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/33383 [22:07:58] New patchset: EBernhardson; "Prevent short-term duplicate thanking via session" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60914 [22:12:22] New patchset: Mattflaschen; "(bug 41729) Move section edit links to after the headings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [22:13:56] New patchset: EBernhardson; "MyISAM warning when InnoDB is not available" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [22:14:03] New review: Mattflaschen; "I took the liberty of amending to add a proposed CSS hack. It basically uses first-child to target ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49364 [22:21:42] New patchset: Ori.livneh; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [22:23:17] New review: Ori.livneh; "PS2 makes some drive-by jshint fixes, but I intend to make a few additional suggestions too." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [22:37:47] New patchset: Ryan Lane; "(bug 47153) improved version. Using Html Class. Removed one unneeded parameter ("id") Making reviewer less anxious." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/58858 [22:38:35] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60894 [22:46:39] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Thanks] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/60914 [22:52:30] Change merged: Ori.livneh; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [22:57:01] New review: Kaldari; "Oops, nevermind, I accidently did " [mediawiki/extensions/Thanks] (master); V: 1 - https://gerrit.wikimedia.org/r/60914 [22:59:22] New patchset: Aaron Schulz; "Defer user_daily_contribs updates to reduce deadlocks." [mediawiki/extensions/UserDailyContribs] (master) - https://gerrit.wikimedia.org/r/60944 [23:08:05] New review: Krinkle; "You didn't answer it I believe. I'd recommend not introducing a new return statement. Leaving it as ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59010 [23:08:27] Yippie, build fixed! [23:08:27] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #33: FIXED in 6 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/33/ [23:09:09] Change merged: Krinkle; [mediawiki/extensions/HTMLTags] (master) - https://gerrit.wikimedia.org/r/60598 [23:09:39] New review: Kaldari; "There is one problem though. If I thank someone and then soft-refresh the page, I still get the old ..." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/60914 [23:10:46] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [23:13:04] New review: Krinkle; "Adding myself as reviewer. Will check it out soon and see if this should go in." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [23:18:54] Yippie, build fixed! [23:18:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #18: FIXED in 9 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/18/ [23:21:42] Change merged: Kaldari; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60926 [23:28:14] New patchset: Kaldari; "Making page title bold in flyout version of revert notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60946 [23:30:11] Yippie, build fixed! [23:30:11] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #10: FIXED in 7 min 17 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/10/ [23:46:06] New patchset: Tim Starling; "Changed on-request job running to shell out instead of doing a loop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [23:46:18] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [23:51:20] xyzram: that change needs a rebase [23:51:57] want me to amend it ? [23:52:12] the change that dumps the global config you mean ? [23:53:53] if you click "rebase" in gerrit it fails with a path conflict [23:54:19] so it would be nice if you could resolve that conflict manually and upload a new patchset [23:55:00] ok, I'll take a look. [23:58:27] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60946