[00:16:43] New review: Spage; "Patch 21 is a rebase to master. I think it's good to merge. Note existing forms are unchanged unless..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [00:18:51] New review: Dzahn; "(1 comment)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [00:19:02] New patchset: Aaron Schulz; "Fix bug in OOM avoidance for RepoGroup cache." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60615 [00:22:11] Aaron|home: loading the item will insert the job again [00:22:43] New patchset: Aaron Schulz; "Fix bug in OOM avoidance for RepoGroup cache." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60615 [00:23:03] so it user triggered then? figured [00:23:37] Reedy: https://gerrit.wikimedia.org/r/#/c/60615/ [00:36:05] Ryan_Lane: ^demon|gone: It looks like "TemplateData" isn't updating in the meta repository [00:36:19] for some reason it is stuck at a version where TemplateData.php doesn't even exist [00:36:22] sorry, I don't know how that works…. [00:36:26] e.g. the very first revision [00:36:29] ok [00:36:31] magic [00:36:33] yep [00:36:44] for the most part gerrit is magic to me now :) [00:36:56] people do things and stuff happens [00:37:02] whenever I do git pull, I get a fatal error on my wiki about TemplateData.php not existing [00:37:09] weird dude [00:37:14] Figured it out eventually [00:37:28] heh. yeah, that is weird [00:37:34] apparently it's been this way for a while, git-pull must've skipped it until now (dirty copy) [00:38:15] Okay, I've successfully rearranged my IRC channels. [00:38:40] New patchset: Krinkle; "Attempt to fix broken updating of TemplateData submodule" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/60616 [00:38:48] Susan: And ##krinkle is on top :P ? [00:38:55] :-) [00:39:05] -dev moved up significantly. [00:39:08] As did -operations. [00:40:53] Change merged: Krinkle; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/60616 [00:41:31] Krinkle: You have a fan channel? :) [00:41:48] I have several. [00:42:03] lol [00:42:17] IRC is the new Google Reader, didn't you hear? [00:42:23] :P [00:42:27] RIP, Reader. [00:42:29] * Krinkle actually switched to Feed.ly [00:42:35] More like Google Reader was a failed experiment at being IRC [00:42:39] I just don't read. [00:42:47] I use ##krinkle to to push all github notifications of my repositories [00:42:52] RSS, as it turns out, has many _free_ clients... [00:43:04] any pushed commits, opened issues/pulls, and travis-ci [00:43:15] The only cost of using Reader was your privacy, wasn't it? [00:43:19] I mean, it didn't have a direct monetary cost. [00:43:25] and there is a plugin to my ecma brain [00:43:43] Your brain supports JavaScript? [00:43:55] Susan: Hi, marktraceur, guess we haven't met [00:44:10] * marktraceur points to his FSF cloak [00:44:43] No freevangelism! [00:44:56] * marktraceur resents the parallel [00:45:05] Susan: Try ecmabot-wm in ##krinkle, Am I not the human ecmascript compiler? [00:45:19] Skynet. [00:45:23] All these bots. [00:45:33] Apparently there are these "smart" thermostats now. [00:45:45] Terrifying. [00:45:49] Sorry marktraceur, butchagotta admit there are a few zealots. [00:46:07] Amgine_: I'm not sure I've met them [00:46:16] Heh. [00:46:24] marktraceur is a .NET guy of kind. [00:46:48] Amgine_: Some people bring in weird issues to the conversation, like cost of the software or privacy, but zealots I dunno [00:47:09] * Krinkle needs to compile .NET csharp visualstudio project once a week and run with mono [00:47:13] not a fun maintenance task [00:48:10] when adding custom api actions, should I have an individual action for everything, or should I group actions together and use a parameter to indicate subactions? [00:48:26] Neither is getting wifi working on debian. Actually, come to think of it, I've failed the last two times I tried. [00:48:50] Ryan_Lane: hehe, there's what you should do and what everybody else does [00:49:04] group them, or individual? [00:49:42] I tend to believe grouping is the better option. [00:49:50] ok [00:49:54] But it depends on whether that is practical with your parameters [00:50:05] you want to make use of the build in validation of parameters [00:50:21] if you are forced to make everything optional because you're grouping them, them grouping may not be so good. [00:50:25] indeed [00:50:30] e.g. common parameters between actions or every different [00:50:38] some groups of actions I think are really easy to group [00:50:54] instance actions always take basically the same parameters [00:50:59] api-visualeditor groups them because only the subaction is different the other parameters are the same [00:51:14] abusefilter separates them [00:51:27] delete, reboot, getconsoleoutput all take exactly the same params [00:51:39] create and configure also take the same ones, but have some optional ones [00:51:57] by special page perhaps? [00:51:59] I think I'll group by general special page [00:52:00] yeah [00:52:02] cool. thanks [00:52:16] e.g. Special:ControlInstance -> api.php?action=osm-instancecontrol [00:52:23] tends to be the same kind of grouping I guess [00:52:29] * Ryan_Lane nods [00:52:49] though really, I'd love this *this* to be documented [00:52:52] heh [00:52:54] very inconsistent [00:52:59] yeah, the api extension docs aren't very good either [00:53:18] I should probably be nice and update stuff as I go through [00:53:19] Ryan_Lane is volunteering to write docs. :-) [00:53:28] He sure is :) [00:53:35] I should I *should* :) [00:53:42] err [00:53:45] I said* [00:54:00] now that 20% got whacked, we no longer have to document our code, right? [00:54:13] hahaha [00:54:41] I believe 20% has morphed into a Nintendo game. [00:54:50] I've seen the mushroom [00:54:54] mushroom room [00:54:56] I call Yoshi. [01:05:24] New patchset: Tim Starling; "Remove is_numeric check from Title::checkUserBlock" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58308 [01:05:51] New review: Tim Starling; "Thanks for that, it looks good." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/58308 [01:13:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58308 [01:30:01] New review: Yaron Koren; "Can't you call those hooks on $psTemplate before calling createTemplateText(), and then modify the $..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [01:31:30] New patchset: Mwalker; "More ThankYou Fun" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60618 [01:34:12] New patchset: Mwalker; "Fixing a small bug in ThankYou Gen" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60619 [01:34:41] New patchset: Mwjames; "SMW\Test\HooksTest use group Database" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60620 [01:37:36] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60620 [01:39:25] New patchset: Aaron Schulz; "Moved RC purge logic to RecentChange::purgeExpiredChanges()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60621 [01:58:58] New review: Aaron Schulz; "(2 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [02:08:04] New patchset: Mwjames; "SMW\Test\PropertyStatisticsTableTest issue on Windows" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60622 [02:09:56] New patchset: Mwjames; "SMW\Test\PropertyStatisticsTableTest issue on Windows" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60622 [02:12:08] New patchset: Mwjames; "SMW\Test\PropertyStatisticsTableTest issue on Windows" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60622 [02:13:29] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [02:13:39] New review: Aaron Schulz; "Simplified some code" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [02:30:46] New patchset: Mwalker; "Allow HTMLForm entities to not have labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [02:34:12] New patchset: Mwjames; "Clean-up smwgQEnabled usage in ask/show" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60623 [03:50:31] New patchset: Mattflaschen; "Fix HTML escaping error" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [04:19:37] New patchset: Mattflaschen; "Add script to dump Redis database for debugging." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60343 [04:20:20] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60343 [04:32:40] New review: Parent5446; "(5 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60440 [04:33:49] New review: Parent5446; "(3 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [04:36:14] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60229 [04:47:39] New patchset: Mwjames; "Replace MediaWikiTestCase with simpler interface + clean-up unit tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [04:55:33] New review: Parent5446; "(6 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59572 [04:59:44] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [05:05:41] New patchset: Mattflaschen; "Tweak GettingStarted notification wording." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60625 [05:17:27] New review: Tim Starling; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/57671 [05:25:12] New review: Swalling; "Copy only change, looks correct." [mediawiki/extensions/GettingStarted] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60625 [05:25:13] Change merged: Swalling; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60625 [05:30:56] New patchset: Mwjames; "Replace MediaWikiTestCase with simpler interface + clean-up unit tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [05:47:12] New review: Mwalker; "This is a good step and I feel should be deployed! We're not completely solved yet -- we need to add..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/57518 [05:57:57] New review: Mwalker; "I'm working on addressing all y'alls issues -- but wanted to rebase and such first." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59439 [06:03:44] New patchset: Physikerwelt; "renaming of read and write methods for database access" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60627 [06:16:36] Change merged: Tim Starling; [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/58306 [06:19:45] New patchset: Tim Starling; "(bug 47300) Fix sandboxing with require" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59576 [06:19:54] Change merged: Tim Starling; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59576 [06:28:28] New review: TheDJ; "(3 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [06:38:31] New patchset: Physikerwelt; "remove unused code" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60629 [06:47:43] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [06:54:12] New review: Nikerabbit; "(3 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60229 [07:03:55] New review: Nikerabbit; "I guess the

was there for a reason, because now the language selection buttons don't appear." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/60402 [07:04:14] New review: Nikerabbit; "Seems to also need manual rebase." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [07:08:22] New review: Nikerabbit; "Works. But if I disable webfonts, the change does not take effect until I manually refresh the page...." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/60421 [07:16:17] New review: Pginer; "A couple of comments:" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [07:21:14] New patchset: Ori.livneh; "Add 'git' module; re-organize accordingly" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60633 [07:23:04] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60633 [07:27:03] New review: Ori.livneh; "Re-tested. LGTM." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/57823 [07:28:43] hhello [07:29:49] hi hashar [07:30:10] ori-l: I was looking at your post on ops list regarding graphing the mw exceptions and fatals [07:30:27] ori-l: maybe that should be done in graphite instead of ganglia [07:30:38] ori-l: would let us created a nice gdash entry [07:30:48] ori-l: though ganglia is nice :-} [07:31:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [07:31:44] well, the rate of errors is persistent enough that it can be usefully graphed, but it still has flat periods [07:32:01] so you really have to wrestle with ganglia to get it to show the information in a way that is useful [07:32:48] i don't have much experience with graphite, though. can you point me to some repo (internal or external) that uses it to graph metrics? [07:33:16] ori-l: no idea :( [07:33:33] ori-l: I don't think we have any documentation for sending data to graphite [07:34:09] ori-l: then the graph definition is done via a puppet class [07:34:39] otto added a similar facility for ganglia views [07:34:46] oh [07:36:07] hashar: but i'm reluctant to put *too* much thought into graphing data because ideally there wouldn't be enough of it to graph :) [07:36:39] i don't really know too much about this, but i figure that there's a case to be made for the abiding relevance of things like OOMs and time limit exceeded fatals [07:36:59] these things represent the underlying limitations of the platform and are not likely to be fixed in a comprehensive way ever [07:37:53] but fatals and exceptions resulting from programming error only accumulate because they are a little obscure and do not always reach the developer [07:38:03] from casual programmer error i mean [07:38:50] so the solution there is just to make it reach the programmer and over time become intolerant of people letting fixable fatals/exceptions go unfixed [07:39:07] ori-l: we have mostly handled that manually I guess [07:39:25] whenever a new wmf branch is pushed, fatal/exceptions are being filled as bugs [07:39:43] if I could clone() myself, I would wrote a small python script that would tail the log files, parse the errors and accumulate them in some database [07:39:58] I thought using EventLogging would be a nice way to handle that [07:40:29] but then I am not sure it is a good idea to have a pile of PHP being run as an exception handler. I am a bit worried about possible loop [07:40:40] like the exception handler causing an exception [07:40:46] anyway, [07:40:48] hashar: https://gist.github.com/atdt/5450356 [07:40:53] shhhh [07:40:57] once the fatal/exceptions are in a DB, we could write a dashboard to report them nicely [07:41:05] with top offenders, bug attached etc [07:41:14] aha [07:41:25] work-in-progress [07:42:54] but yeah, that was my thinking too [07:43:13] in the meantime the ganglia thing was just very easy and quick to do and better than nothing [07:43:41] well, easy and quick because i have been spending the last few months doing variants of "tail stream using python, process / accumulate" [07:49:24] with open('exception.log') as f: [07:49:25] ahh [07:49:28] that is fun [07:50:27] ori-l: that parse_exc.py should land somewhere in Gerrit :-D I will definitely help reviewing / imrpoving [07:50:39] could even be a light daemon that could be queried :-] [07:51:44] yes, i just put it up for the purpose of sharing with you, i use gist as a persistent pastebin. i want to make sure i got the format right before i do an initial commit, but i will soon.. i even got a repo setup [07:51:50] mediawiki/tools/fluoride :) [07:51:59] \O/ [07:52:07] let me add pep8 / pyflakes jobs for that hehe [07:52:33] the name is a homage to fluorine and to anticavity toothpaste [07:52:49] git gerritclone mediawiki/tools/fluoride [07:52:49] Cloning into '/Users/amusso/projects/mediawiki/tools/fluoride'... [07:53:07] ^^^ my own little script I have to publish that let one easily clone a repo from gerrit \o/ [07:53:22] share! [07:53:27] * ori-l wants [07:53:35] it is buggy as hell [07:53:44] that's how i like my software [07:53:46] will definitely publish it by the end of the week though [07:54:02] Hey guys [07:54:09] hello [07:54:16] CAn someone help me? [07:54:24] maybe; what's up? [07:54:39] so I was given a bug to fix [07:54:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=42775 [07:54:55] but when I installed it on my mediawiki [07:55:00] its already fixed? [07:55:29] there's some discussion in the bug thread about what is and isn't fixed [07:56:05] do you mean to say that even kaldari's comment at the bottom is out-of-sync ? [07:56:39] yup [07:57:19] New patchset: Hashar; "python jobs for mw/tools/fluoride" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60634 [07:57:31] well, I think the nice to do in such cases is to run "git log" in the repository and see if you can find the commit that fixed the last outstanding issues [07:57:35] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60634 [07:58:01] and then add a comment in bugzilla saying something like: "hey, I think these problems were fixed in change Iabc123def, can you verify?" [07:58:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60582 [07:59:00] Thanks a ton [07:59:38] New patchset: Hashar; "pep8/pyflakes (voting) for mw/tools/fluoride" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60635 [07:59:41] np. a lot of developer work is unexciting like that :) [07:59:56] ori-l: https://twitter.com/hipsterhacker/status/322069579239153664 :P [08:00:05] hashar: i know we have pre-merge CI, but i think this might be the first case of pre-code CI :) [08:00:16] New patchset: Matthias Mullie; "Docs for Redis' ->exec() return value" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60636 [08:00:25] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60635 [08:00:26] legoktm: heheh, cute [08:07:33] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/60343 [08:07:42] New patchset: Hashar; "fluoride phplint->pyflakes and make them really voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60637 [08:07:44] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60343 [08:08:24] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60637 [08:09:01] ori-l: you should have pyflakes / pep8 for mw/tools/fluoride [08:09:23] ori-l: I am watching that repo so should receive mail notifications to it. Feel free to add me as a reviewer as well. [08:09:35] hashar: wee, thanks! i will take you up on that offer [08:10:29] ori-l: and I still don't have python-tox on gallium :( [08:10:40] ori-l: the back porting is not trivial, need to tweak some dependencies. [08:12:20] hashar: it'd be neat to have, but it's not at all urgent. the number of repositories that would benefit is quite small. i'm sure there's a lot more to do before then [08:13:24] ori-l is there anyway I can download the old code? [08:13:49] Aayush|Away: if you used git to download the repository, you already have [08:14:02] if you run "git log -p" you will actually see the changes to the source code [08:14:12] that were made by each commit [08:14:55] Aayush|Away: when you did "git clone", you actually copied all the code we have written over the last ten years :-] [08:15:26] Aayush|Away: in mediawiki/core.git try out: git show d82c14fb4fbac288b42ca5918b0a72f33ecb1e69 [08:16:35] Thanks :) [08:17:33] New review: Ori.livneh; "Thanks for the additional reformatting" [mediawiki/extensions/ConfirmEdit] (master) C: 2; - https://gerrit.wikimedia.org/r/60468 [08:17:36] ori-l: so my lame clone helper is named `gerritclone` and installs a script named git-gerritclone. Any idea about where it could land in the Gerrit git hierarchy? [08:17:46] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [08:18:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60636 [08:19:58] hashar: under wikimedia/ maybe? [08:21:05] New patchset: Hashar; "mw/tools/dippybird phplint" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60638 [08:21:26] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60638 [08:22:50] New patchset: Hashar; "mw/tools/dippybird triggers phplint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60639 [08:23:00] ori-l: probably [08:23:05] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60639 [08:28:43] New review: Aklapper; "Links to tickets in Mingle are currently pasted as free text in Bugzilla, see e.g. https://bugzilla...." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [08:35:34] ahh [08:35:43] reminds me I need to have some perl linting job [08:36:32] I think I am going to upgrade Zuul [09:02:16] New patchset: Zfilipin; "Updated ffi gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60640 [09:05:40] * hashar upgraded Zuul the jenkins triggering system. [09:23:34] New patchset: Mwjames; "Replace MediaWikiTestCase with simpler interface + clean-up unit tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [09:42:22] New review: Mwjames; "Added ApiTestCase as test case framework, add new test ApiAskTest, and changed ApiSMWInfoTest accord..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60624 [09:51:41] New patchset: Physikerwelt; "Remove even more unused variables" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/60642 [10:06:00] New patchset: J; "fix manually setting duration/offfset without file" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60644 [10:16:33] New patchset: Hashar; "int/zuul-config validate Zuul layout" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60645 [10:16:52] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60645 [10:17:38] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60646 [10:19:32] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60646 [10:20:45] New patchset: Hashar; "integration-zuul-layoutvalidation" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60647 [10:21:04] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60647 [10:21:37] New patchset: Nikerabbit; "(bug 46925) visible on translation pages in source language" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60648 [10:21:38] New patchset: Nikerabbit; "Documentation formatting udpate" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60649 [10:28:53] New patchset: Hashar; "int/zuul-config diff layout with previous commit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60650 [10:29:10] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60650 [10:30:11] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60646 [10:33:29] New patchset: Hashar; "integration-zuul-layoutdiff" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60651 [10:33:58] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60651 [10:34:38] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60646 [10:34:56] Change abandoned: Hashar; "(no reason)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60646 [10:36:33] lluunnch [10:56:43] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50755 [10:58:03] New patchset: Daniel Kinzler; "Support langlinks from hooks in ApiQueryLangLinks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60034 [11:16:15] i [11:29:15] hi [11:29:22] hello browser tests [11:29:32] New patchset: Ori.livneh; "Lint" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60653 [11:30:03] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60653 [11:30:41] Hello anyone there to guide [11:31:51] Hello browser testers [11:32:16] New patchset: Ori.livneh; "Notify Service['apache2'], not Package['apache2']" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60654 [11:33:10] New patchset: Ori.livneh; "Notify Service['apache2'], not Package['apache2']" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60654 [11:33:21] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60654 [12:13:39] hello karim_r :) [12:14:03] hashar: I am trying to find if it is already reported that search is broken at wmflabs [12:14:14] New patchset: Hashar; "mw/ext/PoolCounter , build the daemon!" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60656 [12:14:23] I have found a few bugs at https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=labs&list_id=196689 [12:14:32] zeljkof: define broken ? :D [12:14:54] hashar: try searching for anything [12:14:59] you get "An error has occurred while searching: The search backend returned an error: Error opening index." [12:15:06] at http://commons.wikimedia.beta.wmflabs.org/ [12:15:14] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60656 [12:15:47] hashar: is that a known problem? [12:15:59] this one? https://bugzilla.wikimedia.org/show_bug.cgi?id=46459 [12:16:00] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/PoolCounter] (master) - https://gerrit.wikimedia.org/r/54427 [12:16:36] zeljkof: I guess some instance died [12:17:12] hashar: should I report is separately, or just add a comment to 46459? [12:17:47] New patchset: Hashar; "mwext-PoolCounter-build `make` the C daemon" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60657 [12:18:00] zeljkof: I will fix it [12:18:10] bug 46459 is the root cause most probably [12:18:10] hashar: great [12:18:26] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60657 [12:18:46] hashar: I am showing a volunteer how to automate search, but it is hard to do because it is broken :) [12:20:30] zeljkof: there are two main issues: 1) the daemon uses too much memory, that is fixed but need a review/merge by ops [12:20:36] 2) there is no monitoring of the process in labs [12:20:37] :( [12:23:13] hashar: should I report a bug for #2? :) [12:25:04] hmm lucene is running on both boxes [12:36:28] 2013-04-24 12:35:11,472 [main] WARN org.wikimedia.lsearch.oai.OAIHarvester - Error reading from url (will retry): http://aa.wikipedia.beta.wmflabs.org/w/index.php?title=Special:OAIRepository&verb=ListRecords&metadataPrefix=mediawiki&from=2001-01-01 [12:36:29] ahh [12:38:12] <^demon|breakfast> That was just fixed in master. [12:38:59] in my case it is timing out [12:39:20] <^demon|breakfast> That'll do it too...I was referring to the "fetching from bogus urls" bit. [12:40:05] zeljkof: iptables -t nat -I OUTPUT --dest 208.80.153.219 -j DNAT --to-dest 10.4.0.17 :D [12:40:15] zeljkof: that might have been the root cause for lucene not updating in labs [12:40:34] <^demon|breakfast> The latest master of MWSearch has improved logging of those timeouts as well, if you enable logging for the 'mwsearch' debug log group. [12:41:02] hashar: my iptables-fu is not so good :) [12:41:15] something was blocked? [12:41:33] oh, something was redirected to 10. IP? [12:42:19] so [12:42:53] lucene-search-2 fetch its updates by accessing the public domain commons.wikimedia.beta.wmflabs.org [12:42:56] which in beta is a public IP [12:43:09] and an instance can not access the public IP :/ [12:43:20] need to reroute the packet to the internal instance [12:49:33] simplewiki-d0bcbbe8: 1.2280 27.2M Interwiki::getInterwikiCacheEntry( an ) [12:49:33] simplewiki-d0bcbbe8: 1.2284 27.2M Interwiki::getInterwikiCacheEntry( arc ) [12:49:34] simplewiki-d0bcbbe8: 1.2289 27.2M Interwiki::getInterwikiCacheEntry( ast ) [12:49:35] simplewiki-d0bcbbe8: 1.2293 27.2M Interwiki::getInterwikiCacheEntry( az ) [12:49:36] yeah moooaar spam [12:53:53] zeljkof: that seems to work [12:54:04] zeljkof: I was trying with "San" hoping to get San Francisco [12:54:20] zeljkof: did not work. But entering 'Flags' gives me a few articles [12:54:44] ok, at least it is not completely broken :) [12:54:49] hashar: thanks [12:54:55] zeljkof: what were you searching for ? [12:55:16] nothing in particular [12:55:22] just testing the search feature [12:56:27] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/PoolCounter] (master) - https://gerrit.wikimedia.org/r/54427 [13:01:34] Krinkle: In jquery modules, you need the mw in ( function ( mw, $ ) {} when using mw right ? [13:01:49] thedj[work]: Yes [13:01:51] this explains why WikiLove is broken I think. [13:01:58] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikiLove.git;a=blob;f=modules/ext.wikiLove/ext.wikiLove.core.js;h=8ec2e5602bfbc039775340180cb9aa3fbeea80c9;hb=HEAD [13:02:02] thedj[work]: preferably if it is a jquery.*.js file, put $ before mw in the closure [13:02:03] it doesn't have it. [13:02:20] if it is a ext. or mw. file, mw first [13:02:33] thedj[work]: No, because mw is a global variable [13:02:38] we just prefer not to use it [13:02:45] (like $) [13:03:02] it shouldn't cause anything fatal in normal cases [13:03:21] the only case where it can go wrong, which is another reason to use the closure, is if the reference gets messed with [13:03:41] ah, if something is overriding mw somewhere ? [13:03:47] e.g. if somebody loads jquery.js manually from a gadget (which is insane) it would redefine $ and jQuery and blow away all plugins in $.fn.* [13:04:01] but by using the closure you keep a reference to what jQuery was at your module's run time [13:04:13] Krinkle: hmm, that could explain: https://bugzilla.wikimedia.org/show_bug.cgi?id=47457 [13:05:48] <^demon> qchris: I pushed the gerrit repo to our gerrit (just master) [13:05:55] <^demon> (we're owners) [13:06:03] thedj[work]: Not sure how it relates to that bug, haven't read it all yet though [13:06:11] ^demon: Yay \o/ [13:06:23] ^demon: So we're free to put our patches on top of that? [13:06:36] <^demon> Yeah, I'm trying to pick an initial branch point/name. Thoughts? [13:06:56] Krinkle: blank user pages with FF20 if Wikilove is enabled. [13:06:57] <^demon> Do we want to go with what we've got currently deployed, or is there other stuff we want to cherry pick? [13:07:15] ^demon: I'd go with what we have deployed currently. [13:07:30] ^demon: We want to bring in the rename stuff at some point I guess [13:07:45] oh wait, where is that FF20 regex issue at ? [13:08:09] <^demon> Sounds good. How about 2.6-wmf for the branch name? [13:08:28] ^demon: 2.6-wmf sounds good [13:08:50] <^demon> Ok, we're set then. [13:08:58] ^demon: or wait ... are we on 2.6 branch? I tohught we're on master. [13:09:09] <^demon> We've been on master. [13:09:20] ^demon: Ok. 2.6-wmf then. [13:09:56] <^demon> 2.6-rc0-328-g72b7141 is the deployed version right now. [13:11:12] <^demon> Should probably setup a cron to fetch master from upstream every so often. [13:12:21] 2.6-rc0-328-g72b7141 is a commit in the master branch, not stable-2.6. [13:12:48] But I am fine either way [13:13:18] <^demon> Yeah, I know it's from master. [13:13:40] <^demon> Gerrit's versioning confuses me. [13:13:59] Then the branch name '2.6-wmf' is a bit confusing. But I can live with that. [13:14:08] <^demon> master is 2.6-rc0, but so is stable-2.6? But master's also 2.7-SNAPSHOT ;-) [13:14:20] <^demon> Got another idea for a branch name? [13:14:29] gerrit uses 'git describe', which goes back to the last tag. [13:14:34] What about 'wmf'? [13:14:42] Change merged: jenkins-bot; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/59423 [13:14:42] That's what I've used up to now. [13:15:07] <^demon> Hmm, that could work too since we plan to mostly track master. [13:15:18] <^demon> Then we won't need a new branch name each time upstream bumps the release. [13:15:27] <^demon> k, wmf it is. [13:15:53] We've got a name. The project is done. \o/ [13:20:46] qchris: time to add a new object to the gantt chart? [13:22:22] p858snake|l: Hehe. No. I was just kidding. For some projects, finding a name seems like the most central problem. [13:23:22] <^demon> We need to clean up the gerrit stuff in jenkins. [13:23:29] ^demon: didn't you flick something at one stage so images got shown on diff changes (concerning images)? [13:23:49] p858snake|l: I am just working on that [13:24:21] p858snake|l: A commit ~9 months back broke that, by putting an if guard to the wrong block [13:24:39] <^demon> Ahh, I knew that used to work. [13:24:59] New patchset: Nikerabbit; "Code consistency" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60659 [13:25:04] New patchset: Nikerabbit; "Simplify tracking of changed units and fix invalidation" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60660 [13:25:04] New patchset: Nikerabbit; "Replace method which already exists as strtr" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60661 [13:25:21] <^demon> hashar: I was trying to modify the gerrit-core job and I got an ugly stacktrace: http://p.defau.lt/?BIcSZJoev1mbvgY2Fa1RJQ :( [13:26:32] <^demon> (tried twice, same result) [13:26:38] ^demon: using jenkins job builder? [13:26:48] <^demon> No, gerrit jobs don't use that yet. [13:26:50] <^demon> On my todo list. [13:27:02] save yourself the troubles of using JJB if you do not need it [13:27:09] as for the stracktrace hmm no idea [13:27:13] Caused by: java.lang.IllegalArgumentException: gerrit-core [13:27:16] some parameters is wrong? [13:27:44] ^demon: maybe the project can not contains a dash :( [13:27:48] <^demon> Was trying to remove a child job that doesn't exist anymore. [13:27:49] New review: Ottomata; "I think I'd rather let you migrate the mediawiki::git stuff over to use misc::git::clone, if you lik..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60577 [13:30:01] ^demon: gerrit-core is passed to a public static ModuleName fromString(String n) { [13:30:06] int idx = Math.max(n.indexOf(':'),n.indexOf('$')); [13:30:06] if(idx<0) throw new IllegalArgumentException(n); [13:32:22] <^demon> It's always worked fine :\ [13:33:19] I am trying to understand what that piece of code is doing [13:36:57] ^demon: no idea sorry. Seems the name must contains : or $ [13:37:12] <^demon> That makes no sense. [13:37:18] <^demon> We have lots of jobs with hyphens. [13:37:21] <^demon> And few with : or $ [13:37:24] <^demon> (if any?) [13:37:50] maybe that is internally crafted? [13:38:00] like "root job:sub job" ? [13:38:20] New patchset: IAlex; "Simplify the logic to decide whether to show "variant" and "noconvertlink" on Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60248 [13:38:33] <^demon> Always a possibility. [13:38:33] New patchset: IAlex; "Simplify the logic to decide whether to show "variant" and "noconvertlink" on Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60248 [13:40:09] <^demon> The rest of the stacktrace is dominated by the Copy Artifact plugin...wonder if its to blame. [13:41:14] <^demon> qchris: So, since sha1s are going to change (being on different branches) between our changes and what we submit upstream, wanna adopt the policy of using the same change-id? [13:41:20] <^demon> That way we can search it on both ends at least. [13:41:49] I guess that would be good, yes. [13:42:11] <^demon> Statistically unlikely to conflict, makes it a tad easier to keep track imho. [13:42:22] Yes, I am all for it. [13:42:28] you can also have a look at `git cherry` [13:43:04] it compares the patch code (aka no commit metadata such as the dates or summary) [13:47:33] git remote add wikimedia ssh://hashar@gerrit.wikimedia.org:29418/gerrit.git [13:47:34] git checkout -b wikimedia-master -t wikimedia/master [13:47:35] git checkout -b google-master -t google/master [13:47:47] then to find out from wikimedia what is needed to reach google: $ git cherry wikimedia-master google-master [13:47:48] + 5d8a290d0622ce0469fb0abfdab182b5e100189f [13:48:05] just have to cherry-pick that one and blame you are up to date :-} [13:51:49] ^demon: qchris: is it correct we can inject our JQuery in Gerrit web interface? someone filled a bug to get Zuul status reported directly on a Gerrti change [13:51:58] and Zuul advertise what it is doing via https://integration.wikimedia.org/zuul/status.json [13:52:17] <^demon> I wrote a patch to do so. [13:52:31] New review: Vedmaka Wakalaka; "Yes, its the way i think, but there is problem also: if we call hooks before createTemplateText(..) ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [13:52:46] ^demon: upstreamed / deployed ? ;à [13:52:48] And now we can pull that in on our own :-) [13:53:05] \O/ [13:53:21] should I fill a bug requesting the ability to inject javascript in Gerrit? [13:54:19] I guess so. Just in case we omit that change when pulling what's in our queue for gerrit upstream. [13:54:46] New patchset: Demon; "Allow JS plugins to contribute JS located outside a plugin" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/60662 [13:54:59] New review: Rtdwivedi; "I think I need a bit of help with this issue now." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [13:55:07] hashar: ^^ I just got pulled in :-) [13:55:14] come on [13:55:29] s/I/it/ [14:03:42] <^demon> The fact that that patch has sat for so long is :( [14:04:00] <^demon> It's 23 lines. [14:04:25] I was merely complaining about how fast you fulfilled the feature request :-] [14:04:51] <^demon> Hehe, well the patch has been upstream for a couple weeks. [14:12:52] <^demon> hashar: I got it to work. I removed the entire build promotion section (didn't need it), removed the invalid project name from children builds, removed the artifact to copy (saved) [14:12:55] New patchset: Yury Katkov; "Fixed bug when $options array was empty in $select DomElement at SF_AutoeditAPI.php" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53270 [14:13:02] <^demon> Then re-added the artifact to copy (saved) [14:13:05] <^demon> So now it's how I want it. [14:13:25] ^demon: happy you have figured a workaround [14:17:10] New review: Physikerwelt; "Unfortunately I can not do more." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [14:24:38] <^demon> qchris: Can I just say that gitblit's built.xml is quite possibly the craziest build file I've ever seen? [14:24:51] Full ACK. [14:25:15] But I read that David made it work with ant again. [14:25:34] But I have not tested that. [14:25:59] <^demon> I built it with ant, but it might still be relying on his silly moxie crap. [14:26:06] * thedj[work] hopes that FF 20 didn't make inline document.write async. then our bootloader is broken... [14:26:09] <^demon> Wasn't really paying attention. [14:26:24] I am not too much fan of everybody reinventing new build systems on its own :-) [14:26:41] Yes this moxie stuff :-( [14:26:46] <^demon> "Moxie is written for those who prefer Ant or for those who must continue building with Ant, though they may yearn for Maven or Gradle." [14:26:48] with 'everybody' being the proper identification of the problem [14:27:50] <^demon> The set of people he's describing includes him and him alone. [14:27:55] <^demon> Nobody else on earth would want that. [14:28:06] :-))) [14:28:36] Btw. have you decided on gitblit vs gitiles yet? [14:28:42] <^demon> gitblit :D [14:28:46] <^demon> Way more features. [14:28:50] Ah. Nice and shiny :-) [14:28:51] New review: Anomie; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/47582 [14:29:00] And it comes with the new jgit API :-) [14:29:11] <^demon> Running standalone it'll be pretty damn fast. [14:29:21] Looking forward to seeing that in action [14:29:54] <^demon> Already got a box and puppet manifests in progress, just waiting on a couple of things from ops :) [14:30:48] <^demon> Hmm, we're gonna want to pull my gitweb change that went in a couple days ago as well. [14:33:14] I guess over the next few days, we'll probably pull in most of the stuff that we were waiting on upstream for. [14:33:26] (That's what I hope for at least) [14:33:44] New patchset: Anomie; "Add parentid to output of list=usercontribs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60571 [14:35:58] New patchset: Krinkle; "Allow UI plugins to contribute JS located outside a plugin" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/60662 [14:36:44] <^demon> Yeah. How do we want to handle generally merging from master? Waiting too long and we'll miss good stuff. [14:37:20] New review: Krinkle; "Stating the obvious, but by CDN I assume you mean bits.wikimedia.org? Because I don't think we'd wan..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/60662 [14:38:33] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [14:39:17] thedj[work]: do you know what any of these recent blank / jquery undefined errors have to do with "wyciwyg" ? [14:39:25] I see that term being used over and over and it doesn't seem relevant in any way [14:41:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60571 [14:44:31] New review: Yaron Koren; "Oh, I see. In that case, I think the best solution is to create two new parameters for createTemplat..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [14:48:03] Krinkle: if you get the blank page, then look at your history, it shows you that you are on a wyciwyg page [14:48:25] thedj[work]: aha [14:48:28] that's.. weird [14:48:31] basically, it seems firefox opens a new document (which it moves into it's cache, which is what wyciwyg is I think) [14:48:42] ok [14:49:05] Krinkle: I can even go back and get the 'original' document in my history it seems. [14:49:50] thedj[work]: so you can reproduce it on your own computer then [14:49:57] I got it once. [14:51:05] I think i can reproduce by 'command' clicking a user link to open in a new tab. [14:51:11] that seems to affect the load order. [14:51:53] thedj[work]: From any page? [14:51:54] https://en.wikipedia.org/w/index.php?title=Main_Page&action=history [14:52:01] cmd clicking user names there [14:52:06] I'm in Firefox 19.x Mac [14:52:17] (not normally, but for this bug) [14:53:54] Krinkle: yes, with 20.0 for Mac [14:54:00] New review: Liangent; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/47582 [14:54:09] * Krinkle updated to 20.0 without realizing [14:54:13] yeah, I'm on that too [14:54:24] I don't use Firefox that often :) [14:54:30] Krinkle: ok, i just clicked three names. 2 triggered the bug [14:54:53] User:Tariqabjotu, User:Killiondude but not for User:Edokter [14:54:54] logged in, https, from history page, cmd-click user names [14:55:01] any other factors? [14:55:15] logged in, https [14:57:11] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60667 [14:58:26] CN is open..... [14:59:24] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60668 [15:01:44] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60668 [15:01:53] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60667 [15:02:48] New patchset: Liangent; "New variable: new_pst which provides a PSTed version of new_wikitext" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/47582 [15:04:07] hmm, it uses document.write for addScript(jquery.isReady===false, async===false)... [15:06:44] thedj[work]: yeah, I've been meaning to get rid of that since it seems no longer useful [15:06:57] it was done originally to spare a callback dance, as it was supposed to be synchronous [15:07:02] but that's bullshit [15:07:07] addScript can work at any time [15:07:09] and is more stable [15:08:06] hmm, i have to go :( [15:10:47] New review: Aklapper; "Of course you're right about URL encoding the search string instead of excluding characters, thanks...." [wikimedia/bugzilla/modifications] (master) C: 1; - https://gerrit.wikimedia.org/r/54503 [15:15:58] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60659 [15:18:11] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60640 [15:18:12] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60640 [15:19:36] so... what's the preferred way to construct a cross wiki memcached key? [15:19:44] i want to cache something based on the wiki's content language [15:20:02] so the cached object can be shared by all wikis that have the same content language. [15:20:20] Do I just use "MyThingy/$lang"? [15:21:53] Sounds about right, not using wfMemcKey() [15:22:50] ok [15:23:55] New review: Hiong3-eng5; "testing, can you check my comments?" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/57236 [15:30:52] New review: Helder.wiki; "(1 comment)" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/60367 [15:33:01] New patchset: Umherirrender; "Use wfShellExec in MimeMagic" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60201 [15:34:57] New review: Umherirrender; "I have searched in core and found some places, where also the first part of wfShellExec is escaped w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60201 [15:37:54] Change abandoned: Umherirrender; "Looks like the messageMap should not get more entries. Duplicate of the message text is not a option..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57039 [15:43:04] New patchset: Umherirrender; "Do not bold all items of a unvisited page on Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [15:45:25] New patchset: Cmcmahon; "do not set the radio buttons just check that they exist" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60671 [16:22:29] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60660 [16:22:53] New patchset: Siebrand; "Documentation formatting update" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60649 [16:24:13] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/60649 [16:25:28] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60661 [16:34:32] New patchset: Siebrand; "(bug 46925) visible on translation pages in source language" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60648 [16:34:43] New review: Siebrand; "Merge conflict fixed in PS2." [mediawiki/extensions/Translate] (master) C: 2; - https://gerrit.wikimedia.org/r/60648 [16:35:14] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59127 [16:35:32] New patchset: Siebrand; "Documentation formatting update" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60649 [16:35:46] New review: Siebrand; "PS3 fixes typo." [mediawiki/extensions/Translate] (master) C: 2; - https://gerrit.wikimedia.org/r/60649 [16:39:58] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60648 [16:44:32] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60649 [16:57:10] New patchset: Matthias Mullie; "cleanup" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60678 [17:35:08] New review: Siebrand; "Please do not score your own code. It makes no sense in a review workflow." [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/60675 [17:49:26] New review: Ori.livneh; "I pushed a change last night that adds a git::clone resource. Is it adequate?" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60577 [17:58:22] New patchset: Hoo man; "Sanitize user auto creation in CentralAuth" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57671 [17:59:38] New review: Hoo man; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57671 [18:00:03] New review: Hoo man; "Addressed Tim's comment." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57671 [18:03:57] csteipp: have a moment? [18:10:06] New patchset: Umherirrender; "Do not bold all entries of a unvisited page on the Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [18:12:08] New patchset: Umherirrender; "Do not bold all entries of a unvisited page on the Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [18:13:14] New review: Umherirrender; "Reworded commit message and get confused by the newline myself, because the editor is breaking the l..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [18:21:16] New patchset: Kaldari; "Modifying Echo defaults per Echo/Feature_requirements" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60685 [18:22:37] New patchset: Pgehres; "DO NOT SUBMIT: Block creation of clashing local accounts" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60686 [18:23:03] New review: Pgehres; "Pending discussion about the ramifications." [mediawiki/extensions/CentralAuth] (master) C: -2; - https://gerrit.wikimedia.org/r/60686 [18:24:27] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60685 [18:36:50] pgehres: Did you upload a dupe of https://gerrit.wikimedia.org/r/16922 ? :P [18:37:15] hoo: apparently so :-) [18:37:47] Change abandoned: Pgehres; "Dupe of https://gerrit.wikimedia.org/r/#/c/16922/" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60686 [18:38:35] pgehres: I guess we can only merge this after we have proper name conflict resolution [18:38:59] yeah, i think we merge as soon as we are done with the SUL finalization [18:39:10] to make doule sure that people cannot do this [18:39:12] *double [18:39:16] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [18:39:28] even though all accounts should be global at that point [18:40:08] pgehres: Sounds good... just don't want people killing the Stewards because they can't register on a new site or so [18:40:23] yeah, notice the big warnings on mine :-) [18:40:36] also, I had a config variable to enable/disable :-) [18:40:52] Maybe you want to override the other one? [18:40:59] * hoo didn't look at the code [18:41:26] the same issues that I thought of are brought up in the other one [18:41:31] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [18:41:37] if we go through with it, we should use the old oe [18:41:38] *one [18:43:00] hoo: if you're looking for a little CR, https://gerrit.wikimedia.org/r/#/c/60305/ will unblock the next step of the grand unification :-) [18:45:56] pgehres: My Wikidata testing environment will soon fall apart, so I guess I should fix that one first :P [18:46:23] thankfully I don't have one of those [18:46:35] a centralauth environment is touchy enough for me [18:46:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60073 [18:47:05] pgehres: That's why I automatized my CentralAuth testing env. [18:47:21] oh? with vagrant? [18:47:37] Nah, I'm not into puppet, I wrote it in plain old PHP [18:47:50] https://github.com/mariushoch/MediaWiki-Testing [18:47:56] I plan to add Wikibase to this [18:48:11] * pgehres goes off to look at that since he keeps braking his [18:48:47] Unix like systems only, btw (heavily used rsync and stuff) [18:49:12] I may work on a mac, but I run ubuntu dev vms for testing [18:49:29] i like the ability to delete the image and start over [18:50:45] hoo: missing a space between foreach and ( on Create.php::38 :-p [18:51:05] :D [18:51:58] well, I think I am going to give this a try [18:52:13] certainly better than what I currently have [18:52:21] I currently only use it for CA + AF and have different environments for the other stuff... [18:52:36] But I hope that get that all merged into one awesome thing soon [18:53:04] that is mainly what I work on these days [18:53:10] CA, not AF [18:53:24] but I might send you a pull req if I find something else I need :-) [18:56:33] New review: Demon; "(2 comments)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/60689 [18:59:58] New review: Reedy; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:00:16] mwalker: Sorry about that.. yeah, what's up? [19:05:37] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:06:02] New patchset: Mwalker; "Allow HTMLForm entities to not have labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [19:07:35] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:07:52] New review: Reedy; "(4 comments)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:09:03] New review: Spage; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:10:34] New review: PleaseStand; "Can you please move your release note to the 1.22 file as well as change your code comment?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785 [19:12:11] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:12:17] New review: Dzahn; "ok with me since aklapper tested it and +1ed" [wikimedia/bugzilla/modifications] (master) C: 2; - https://gerrit.wikimedia.org/r/54503 [19:12:27] New review: Dzahn; "ok with me since aklapper tested it and +1ed" [wikimedia/bugzilla/modifications] (master); V: 2 - https://gerrit.wikimedia.org/r/54503 [19:12:30] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/54503 [19:15:26] New patchset: Demon; "Handle search engine returning status objects to the API" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60693 [19:15:26] New patchset: Demon; "Updating MWSearch to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60694 [19:18:33] New review: Dzahn; "i would have merged it but it needs rebasing, and rebasing has a path conflict. could you fix?" [wikimedia/bugzilla/modifications] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59862 [19:20:10] New patchset: Matmarex; "(bug 47617) Add $wgCascadingRestrictionLevels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [19:20:18] deployed 2 changes: a) improved wiki linking in Bugzilla (54503) b) pester IRC as well when a draf is published on gerrit (50044) [19:21:37] New review: Dzahn; "please fix escaping as pointed out by demon, then it can be merged" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/52251 [19:26:54] New patchset: Matmarex; "Add CVE linker" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/52251 [19:27:28] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:27:50] New review: Lwelling; "(5 comments)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:29:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59368 [19:30:08] New review: Matmarex; "(1 comment)" [wikimedia/bugzilla/modifications] (master) C: 1; - https://gerrit.wikimedia.org/r/52251 [19:32:05] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:32:06] New review: Parent5446; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [19:32:10] New review: Demon; "(1 comment)" [wikimedia/bugzilla/modifications] (master); V: 2 - https://gerrit.wikimedia.org/r/52251 [19:32:11] Change merged: Demon; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/52251 [19:32:29] ^demon: https://gerrit.wikimedia.org/r/#/c/60615/ [19:32:33] Change merged: Demon; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/52252 [19:34:13] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60450 [19:35:54] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60695 [19:37:41] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [19:37:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60615 [19:45:23] New review: Demon; "Needs rebasing, but looks ok." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59369 [19:49:52] New patchset: Matmarex; "(bug 46837) fix Bugzilla wikilinking to sections" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/60701 [19:50:00] New patchset: Aaron Schulz; "Fix bug in OOM avoidance for RepoGroup cache." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60702 [19:50:34] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785 [19:51:04] New review: Matmarex; "As usual, untested :(" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/60701 [19:51:13] New review: Krinkle; "Move release notes to 1.22 unless this is intended to be backported, which is only justified if it i..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/49785 [19:51:43] New patchset: Matmarex; "(bug 46837) fix Bugzilla wikilinking to sections" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/60701 [19:52:10] New patchset: Matmarex; "(bug 46837) fix Bugzilla wikilinking to sections" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/60701 [19:52:14] New patchset: Mwalker; "Allow HTMLForm entities to not have labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [19:55:26] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60702 [19:57:38] New review: Parent5446; "(7 comments)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/60689 [19:59:01] New patchset: Mwalker; "HTMLForm entity labels are now optional and escaped" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [20:00:48] Change merged: Demon; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60693 [20:01:05] Change merged: Demon; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60694 [20:08:18] Change abandoned: Mwalker; "Replaced by https://gerrit.wikimedia.org/r/#/c/57518/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56345 [20:10:49] New patchset: Demon; "$it can also be a Status" [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60731 [20:11:02] Change merged: Demon; [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60731 [20:11:55] New patchset: Demon; "Fix condition" [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60732 [20:12:08] Change merged: Demon; [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60732 [20:12:54] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:14:25] New patchset: Demon; "Updating MWSearch to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60734 [20:14:36] Change merged: Demon; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60734 [20:18:59] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60695 [20:29:38] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60343 [20:35:10] Change abandoned: Ottomata; "Eees gooooood." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60577 [20:39:26] ^demon: hi! can you help us fix a problem that arose during wikidata client deployment? [20:39:38] there's a hot fix coming up in a few minutes that needs to be deployed. [20:39:59] <^demon> I'm in the middle of a deployment myself with search stuff. [20:40:15] ok, just let us know who could or when you could [20:40:18] it'S not absolutely critical in terms of security. [20:40:19] <^demon> mk [20:41:29] basically, rendering stuff from wikidata will currently generate english output, ignoring the local content language. that output gets into the parser cache. the longer we wait, the more pages need to be purged. [20:43:54] Change abandoned: Matmarex; "False alarm, see bug." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/60701 [20:47:03] New patchset: Lwelling; "Add event logging call to notifications sent by email Add deliveryMethod to logged data as described in the new schema at http://meta.wikimedia.org/wiki/Schema:Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60737 [20:47:12] Published patchset: Ori.livneh; "Backport 'VForm' change to account creation form" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60735 [20:48:00] Change abandoned: Ori.livneh; "Better to backport each commit individually." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60735 [20:49:44] New patchset: Spage; "Set Agora font stack to mw-ui-container in Vector" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60738 [20:49:47] New patchset: Spage; "Clean up, comments, remove obsolete mw-ui-formlist" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60739 [20:49:49] New patchset: Spage; "Don't repeat label styling" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [20:57:43] New patchset: Spage; "Don't repeat label styling" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [20:58:11] New patchset: Ori.livneh; "Update extensions/GettingStarted to master (logging changes)" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60741 [20:58:58] New review: Ori.livneh; "Leaving this here for now so we can just rebase / merge tomorrow." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60741 [21:00:07] New review: Wikinaut; "Siebrand wrote:" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [21:00:34] New patchset: Spage; "Clean up, comments, remove obsolete mw-ui-formlist" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60739 [21:02:30] New patchset: Ottomata; "Adding user_metrics dev env module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [21:07:31] New patchset: Spage; "Set Agora font stack to mw-ui-container in Vector" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60738 [21:08:47] New patchset: Spage; "Don't repeat label styling" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [21:09:04] New patchset: Spage; "Clean up, comments, remove obsolete mw-ui-formlist" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60739 [21:10:20] New review: Wikinaut; "@Siebrand:" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [21:10:55] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [21:11:24] New patchset: Spage; "Don't repeat label styling" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [21:13:02] New patchset: Ottomata; "Adding user_metrics dev env module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [21:13:24] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [21:13:40] New patchset: Ottomata; "Adding user_metrics dev env module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60744 [21:16:20] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60746 [21:18:42] New patchset: Wikinaut; "added newline character after the delete message." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [21:19:50] New review: Wikinaut; "verified: works." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/60675 [21:23:41] New patchset: Demon; "Also handle error case for pool counter" [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60748 [21:30:15] Change merged: jenkins-bot; [mediawiki/extensions/MWSearch] (master) - https://gerrit.wikimedia.org/r/60748 [21:31:03] New patchset: Demon; "Updating MWSearch to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60754 [21:31:12] Change merged: Demon; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60754 [21:33:50] New patchset: Mattflaschen; "Add stronger warnings against --all in production." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60756 [21:34:48] New patchset: Mattflaschen; "Add stronger warnings against --all in production." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60756 [21:34:53] New patchset: Lwelling; "Add event logging call to notifications sent by email Add deliveryMethod to logged data as described in the new schema at http://meta.wikimedia.org/wiki/Schema:Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60737 [21:45:21] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [21:45:29] Change merged: Demon; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60746 [21:49:50] New review: Lwelling; "It was a deliberate style choice to present it as a line, so Vibha and Fabrice should have the oppor..." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/60186 [21:50:38] New patchset: Aaron Schulz; "Clarified PoolCounter::execute() docs a bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60762 [21:51:09] New review: Aaron Schulz; "WIP" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/60455 [21:52:49] New patchset: Amire80; "Add help text above the buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [21:53:47] New patchset: Amire80; "Add help text above the buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [21:54:25] !change 60763 | brion [21:54:32] brion: https://gerrit.wikimedia.org/r/#q,60763,n,z [21:56:49] :) [21:57:39] hi brion how are you? [21:57:47] * brion waves [21:57:49] doing good [21:58:33] if we get a damned coffee maker that dispenses cups [21:58:45] im happy to solder in a microcontroller and write python control scripts [21:58:54] mutante: ^ [21:59:08] New review: Amire80; "> But if I disable webfonts, the change does not take effect until I manually refresh the page." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60421 [21:59:34] RobH: that would be awesome:) [21:59:53] but i need the smart logic of the vending type machines [22:00:00] for cup sensing,etc... [22:00:26] the kind that you put the cup in place yourself (like ours) will just lead to folks remotely brewing coffee which is then dispensed onto the floor. [22:00:37] messy [22:00:47] maybe we can rig up espresso pipes to the desks? [22:01:08] cheaper to hire an admin to refill gerbil type bottles and hang on partitions [22:01:33] RobH: that's what interns are for -- they're *free* [22:01:44] in the future the pipes will be: data, power, water, and coffee [22:01:57] don't get the lines crossed....! [22:02:14] unless its the end of the movie. [22:02:15] New patchset: Mattflaschen; "Set 'skin' template parameter rather than override parent method" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60764 [22:03:03] New patchset: Mattflaschen; "Set 'skin' template parameter rather than override parent method" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60764 [22:04:50] RobH: but it needs to actually implement RFC 2324 :) [22:05:05] http://tools.ietf.org/html/rfc2324 [22:05:17] with the BREW method and all , hehe:) [22:06:04] "Coffee pots heat water using electronic mechanisms, so there is no fire. Thus, no firewalls are necessary [22:06:34] New patchset: Mattflaschen; "Clean up, comments, remove obsolete mw-ui-formlist" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60739 [22:09:40] New patchset: Mattflaschen; "Don't repeat label styling" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60740 [22:13:51] New review: CSteipp; "After the "SUL Finalization", I think we can (and should) enable something like this, if it has a co..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/16922 [22:17:47] New patchset: Mattflaschen; "Create account form with vertical form appearance" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60765 [22:19:06] New review: CSteipp; "hoo addressed Tim's concerns, thanks to both of you!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/57671 [22:20:00] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57671 [22:20:29] csteipp: I think we should leave the bug open for now and wait for results [22:20:50] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60737 [22:20:52] hi hoo, how are you today? [22:21:18] sumanah: Fine, thanks :) What about you? [22:22:34] I'm okay! I'm seeing http://www.generalist.org.uk/blog/2013/wikipedians-in-residence-a-recap/ and gratified at the growth of the Wikimedian/Wikipedian In Residence trend [22:23:18] hoo: what's making you happy today? :) [22:24:12] sumanah: Nice weather, I managed to get a lot of stuff done today and Wikidata phase 2 is live without fully blowing up :) [22:26:13] New review: Mattflaschen; "Replaced with a chain of single cherry-picks." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60735 [22:31:46] New review: Mattflaschen; "In general, you should be careful renaming public methods. However, in this case no one should be c..." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/60627 [22:35:29] dschoon: did you breath water? [22:35:46] *breathe [22:35:47] no no. the water *helped* [22:36:06] hoo: yay for all of those things! \o/ [22:43:04] andre__: yt? [22:43:27] StevenW, yepp [22:43:34] Can you add me as default CC for user login and signup? Pretty please. [22:44:31] StevenW, oh sure. done! [22:44:46] Dankeschön [22:57:15] New patchset: Kaldari; "Maintainence script for changing user options for existing users" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689 [23:02:45] New patchset: Kaldari; "New red heart icon for Echo gratitude notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60771 [23:11:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #30: FAILURE in 9 min 30 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/30/ [23:22:14] New patchset: Mattflaschen; "Update extensions/GettingStarted to master:" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60741 [23:39:07] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [23:39:14] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [23:43:57] New review: Parent5446; "Two minor issues. Almost good to go." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60689