[00:00:01] :/ [00:02:20] so, i did not want to revert all of those changes to the "puppetize wikibugs" class, but i had to "revert" by just removing it from site.pp for now [00:02:26] ^demon|busy: ^ [00:02:40] <^demon|busy> ok. [00:02:49] so it's still there but not applied to mchenry and wikibugs runs manually with the old start script as before [00:02:59] and puppet can keep running on mchenry without rebreaking it [00:03:08] <^demon|busy> Sounds good. I'll revisit it tomorrow and try to clean that up. [00:03:16] ok, thanks [00:05:47] New review: Tim Starling; "Since safe_mode is deprecated, it'll become increasingly common for disable_functions to be used to ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59797 [00:05:56] New patchset: Mwalker; "HTML Text Area Size can Be Overriden" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [00:06:11] New patchset: Mwalker; "Allow HTMLForm Entities to not have Labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:13:05] New review: Jdlrobson; "(3 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:22:50] New patchset: MZMcBride; "Allow HTMLForm entities to not have labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:28:52] New review: Mwalker; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [00:30:42] Isarra: Moar favicons!? [00:31:29] * Isarra grins at mwalker. [00:31:35] There are more! [00:32:20] well; I guess I'll be upholding the tentative renaming of the lightning deploy window to "Mwalker's deploy window" :p [00:32:34] New patchset: Adamw; "Contacts and Contributions export fixes" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60364 [00:32:45] greg-g: there are more favicons to deploy! Can I get a slot tomorrow :D [00:37:19] What, are you saying I should finish more of them? [00:37:57] Only if you have more important things you want to procrastinate against [00:38:09] Of course I do. [00:39:01] well then! [00:39:07] what about... the book! [00:39:08] ? [00:39:16] Book. [00:39:42] New patchset: Alex Monk; "Detect user rights conflicts" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [00:41:49] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/60343 [00:42:10] actually though; if you want to get your hands dirty in core -- we could make the skin change to allow arbitrary icons and SVG formats and all that fun stuff! [00:42:23] and by we I really mean you because I'm scared of skin code [00:42:49] but I can poke it with a sufficiently long stick [00:47:05] I wouldn't know how. [00:48:52] is there some group of default icons that can be used in mediawiki? [00:49:12] in skins/common, I'm guessing? [00:49:12] New patchset: Adamw; "Contacts and Contributions export fixes" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60364 [00:49:49] Ryan_Lane: yep -- otherwise people make there own or import from the noun project/commons [00:49:54] *their own [00:50:04] is there any reason we don't have noun by default? [00:50:17] I'm assuming this is what agora is supposed to be doing, eh? :) [00:50:26] jorm: ^ [00:50:28] ? [00:50:42] because I'm trying to do some interface work and this sucks a lot [00:51:15] our docs are really bad [00:51:30] I haven't even gotten to the level of iconography yet -- I still struggle with what bloody CSS class to use [00:51:42] most of our default resource loader modules just link to the damn source code [00:52:13] Agora is set up pretty weirdly. I'm still not sure what it has to do with core, though having something like that as defaults in core would probably be a good idea. [00:52:35] this is basically impossible for a noob like me [00:52:37] YES! if I create a form / html element -- give me some sane defaults! [00:52:47] Yes. >.< [00:53:42] but; Ryan_Lane; do you have a more specific question I can try and help with? I can try to share some of the pain of discovery [00:54:01] maybe stab it with a spoon [00:54:15] well, I'm doing an action, inserting a spinner, then when the spinner is done I want to replace it with a check or a red X [00:54:23] if it's a red X, I want to add a tooltip [00:54:36] adding the tooltip is easy enough, I use tipsy [00:54:44] I need to figure out how to properly add the image, though [00:55:27] typically I see a lot of hidden divs being present on the page which are revealed as required [00:55:46] ah. I see. [00:55:58] alternatively; you could use two CSS classes -- and then set the background image of each to check/red X [00:56:14] and then use jQuery to flip the class at the same time as you add the tooltip [00:56:37] good idea. I could use three and just set the class [00:59:07] thanks :) [00:59:30] yep -- and if you haven't found them, spinner.gif, tick-32.png, and warning-32.png (under skins/common/images) look like decent candidates for your endevour [00:59:36] yep [01:06:09] New patchset: Mwjames; "Extend testNewFromGlobals test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60365 [01:07:16] New patchset: Adamw; "Contacts and Contributions export fixes" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60364 [01:08:59] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60365 [01:14:31] hm. how do I tell it to load images from skins/common, rather than inside of my own extension? [01:15:47] hmm; you might have to play with the base path declaration in your resourceloader config thing for your extension [01:15:56] in centralnotice we just load them straight from bits [01:16:00] * mwalker looks innocent [01:20:01] * Isarra huggles mwalker. [01:22:03] Ryan_Lane: it looks like most extensions are just loading it straight from bits as well [01:22:12] how do you load it from bits? [01:22:37] you do something silly like this in php: mw.config.get( 'stylepath' ) + '/common/images/spinner.gif' [01:22:58] but MobileFrontend is doing it in css by setting the source path to ../common/images/ [01:23:02] so you might try that [01:23:41] e.g. @ajaxLoadingImage: url(../common/images/ajax-loader.gif); [01:23:54] not sure what the @ sign there does [01:24:58] New patchset: Adamw; "WIP: objects to manage allocations data" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/59366 [01:25:18] Isarra: huggle sounds like you're going to trap me in a hug and then tickle me [01:25:20] it's ominous [01:27:08] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60364 [01:27:51] ok. well, I'll try this stuff later [01:28:25] good luck! you might try pinging roan or kaldari tomorrow and see if they have any good ideas [01:28:52] thanks [01:28:56] * Isarra tickles mwalker. [01:29:20] * Aaron|home arrests Isarra [01:29:45] Axck! [01:29:47] Ack. [01:29:50] I can type. [01:30:33] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60352 [01:30:49] oh no! the heinous crime of tickling over IRC! [01:31:06] its abuse! [01:31:11] * Isarra collapses on mwalker. [01:31:20] * mwalker falls over [01:39:46] * marktraceur trips over mwalker [01:39:48] The hell [01:40:11] ah shit [01:40:18] someone needs to fix the rug [01:40:27] far too many people on the floor here [01:47:54] New patchset: Mwjames; "Add SMWHooks::registerUnitTests test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60185 [01:51:49] New patchset: Mwjames; "Add SMWHooks::registerUnitTests test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60185 [01:54:09] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60185 [01:54:17] /i/win 31 [01:54:39] Thanks SSH [02:02:40] New patchset: Spage; "Get Asirra captcha working on more forms" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60366 [02:05:20] New review: Spage; "I stumbled into this bug while testing the new login form with alternative captchas." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60366 [02:06:21] I was going to tell Ryan_Lane about the Iconathon. [02:06:25] Maybe I'll send him a memo. [02:11:15] https://meta.wikimedia.org/wiki/Iconathon [02:11:43] New review: Spage; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [02:12:27] New patchset: Spage; "Move template header inside form so CAPTCHA works" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [02:14:24] New patchset: Mollywhite; "(bug 47509) Move left/right key navigation to bookmanager.js" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/60367 [02:26:10] New patchset: Mollywhite; "(bug 47509) Move left/right key navigation to bookmanager.js" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/60367 [02:28:33] New review: Tim Starling; "Still -1 per previous review" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/8784 [02:29:36] New patchset: Spage; "Move template header inside form so CAPTCHA works" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [02:29:59] New review: Spage; "rebased and comment improved." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [03:15:56] * Krinkle added link to channel logs to topic (Reedy, Susan) [03:17:36] Krinkle: You registered wmbug.com? [03:19:38] * Krinkle made bit.ly link https [03:19:42] Susan: I did [03:19:59] I intend to set it up further, like other major oss projects have done as well. [03:20:15] Examples? [03:20:29] I'm not familiar with the concept. [03:20:31] crbug.com jqbug.com wkbug.com [03:20:39] And there are more [03:20:58] all have / -> portal /new -> report bug / -> issue view [03:21:08] Huh, interesting. [03:21:46] Yep [03:22:08] afaik it isn't a standard thing, they just kind of all copied each other. [03:33:34] New review: Yaron Koren; "Great! Overall this looks good, and I'm looking forward to getting it into the code - I think this w..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [03:50:06] New patchset: PleaseStand; "Web installer: always autoselect some DB type" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60369 [04:01:22] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [04:21:51] New review: Spage; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [04:21:53] New patchset: Spage; "Move template header inside form so CAPTCHA works" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [04:57:57] Change merged: Mattflaschen; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [04:59:35] New review: Mattflaschen; "Sorry, I clicked "Publish and Submit" instead of "Publish Comments" by mistake." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [05:11:56] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:20:18] New review: Spage; "PS 18 is primarily CSS cleanup (prefix benefits names with "mw-",fix some margins). It also only rep..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:31:14] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:33:27] New review: Spage; "PS19 fixes Jenkins failure. (I had jshint 0.9.1 installed locally, upgraded it to 1.1.0)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:47:16] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [05:54:23] New review: Mattflaschen; "I fixed some messages." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [06:44:08] New patchset: IAlex; "improved style for TOC - fix a.selected css selector into li.selected, since that class is applied to the
  • rather than the - improve overall styling (compare before: http://i.imgur.com/fHz8dMB.png and after: http://i.imgur.com/ub5QAaW.png) - c" [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/56607 [06:44:17] Change merged: IAlex; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/56607 [06:52:53] New patchset: IAlex; "HTMLForms: Support non submit buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55009 [06:58:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55009 [07:01:08] New review: Parent5446; "Interesting. I'm surprised we've gone so long with HTMLForm without having a button field." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55009 [07:02:24] New patchset: Krinkle; "HTMLTextAreaField: Allow sizes to be overridden by child classes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [07:03:18] New review: Krinkle; "Rephrased commit summary to not Arbi Trarily Space things and Use Upper Case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [07:03:28] New patchset: Krinkle; "HTMLTextAreaField: Allow sizes to be overridden by child classes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [07:07:31] New review: Krinkle; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59439 [07:10:59] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [07:12:38] Hi there, I'm using MediaWik 1.22alpha and the latest snapshot of VisualEditor. Ive installed the parsoid-Server and have it linked in the LocalSettings.php as I have put in the default configuration for VisualEditor. The Editor shows up under SpecialPages:Version When I go to .../index.php/VisualEditor:Sandbox the Editor just won't show up. [07:17:56] marcel_: Browser name and version? [07:17:59] marcel_: Public url? [07:18:10] marcel_: Do you see an error in the browser developer console? [07:18:36] I check with firebug. Im Using Chrome and Firefox (the newest version) Im sorry it is a local installation on a ubuntu server [07:19:02] marcel_: console [07:19:29] What's that? [07:19:36] Firebug throws : rror: Unknown dependency: jquery.collapsibleTabs [07:19:41] marcel_: The place where you interact with javascript and see errors [07:19:52] Firebug has a console, for example [07:19:56] Chrome has one too [07:20:21] marcel_: In Chrome menu > Tools > Developer Tools [07:20:38] (or cmd+shift+i and then Escape) [07:20:45] Unknown dependency: jquery.collapsibleTabs [07:20:54] yeah ahh ok.. so maybe thats why [07:20:56] in load.php [07:20:57] marcel_: Do you have the Vector extension installed [07:21:01] Yes [07:21:13] I have installed the following extensions: Nuke, Renameuse, Parserfunctions, ConfirmEdit,Gadget, Vector,WikiEditor and VisualEditor [07:21:25] see release notes, you probably have an outdated version of Vector [07:21:28] which uses jquery.collapsibleTabs from core. [07:21:32] unrelated to VE [07:21:53] Ok so can I just try another skin [07:21:59] No [07:22:16] marcel_: Either upgrade Vector (you need to do that anyway, these versions are not compatible) or remove it from LocalSettings.php [07:22:19] Vector extension, not skin. [07:22:30] ah ok then i remove it from LocalSettings. I try that [07:22:48] You can add it back later to upgrade it [07:24:24] Damn.. I switched the skin of my User to Standard now the System is broken. Apache log: [Tue Apr 23 09:23:04 2013] [error] [client 192.168.18.143] PHP Fatal error: Class 'SkinLegacy' not found in /var/www/irswiki/skins/Standard.php on line 17 [07:24:35] Is there a way to reset the skin for the user without beeing logged in [07:27:18] New patchset: Spage; "Don't repeat label styling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60373 [07:27:58] New patchset: IAlex; "Make current year default value in the Special:Contributions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59393 [07:28:50] New review: Nikerabbit; "(4 comments)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/59827 [07:28:58] New patchset: IAlex; "Make current year default value in the Special:Contributions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59393 [07:29:00] Already got it [07:31:33] New review: IAlex; "- Changed date() to gmdate() for consistency with ReverseChronologicalPager::getDateCond()" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59393 [07:31:39] New review: Ori.livneh; "This change looks right to me. I'm sorry for the delay in merging it -- I haven't had a chance to te..." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/59716 [07:33:34] New review: Nikerabbit; "(2 comments)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [07:35:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59393 [07:38:27] New review: Nikerabbit; "We have now 5 cog files. That feels unnecessary duplication and confusing." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [08:05:33] New patchset: Mwjames; "Add SMW\Test\HooksTest docs+" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60374 [08:06:32] New review: Nikerabbit; "(2 comments)" [mediawiki/extensions/ConfirmEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/60350 [08:07:28] New review: Nikerabbit; "What do you mean with expensive?" [wikimedia/fundraising/crm/drupal] (master) - https://gerrit.wikimedia.org/r/60348 [08:07:58] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60374 [08:12:14] New review: Nikerabbit; "I fail to see the point of this change. It's not our fault if PHP is lacking human friendly array sy..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53628 [08:15:37] hello [08:24:26] New review: Nikerabbit; "Assuming Amir meant to do CR+2." [mediawiki/extensions/Narayam] (master) C: 2; - https://gerrit.wikimedia.org/r/60242 [08:24:36] Change merged: jenkins-bot; [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60242 [08:33:25] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [08:41:08] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53189 [08:46:22] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60232 [08:51:11] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60272 [08:56:10] New review: Nikerabbit; "Isn't this actually making it do nothing too, instead of deprecating?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [09:04:55] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60232 [09:06:45] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60126 [09:07:40] New review: Nikerabbit; "Amir: Why did you add Verified+2?" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60245 [09:08:26] New review: Nikerabbit; "Are these settings copied from somewhere? Do they make sense for us?" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60245 [09:08:26] Change merged: jenkins-bot; [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60245 [09:11:13] New review: Siebrand; "They are the same as for others extensions LangEng maintains." [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60245 [09:11:40] New review: Krinkle; "Indeed. They've been deprecated in 1.17 (as documented), this removes them for dummy placeholders th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [09:11:41] New review: Nikerabbit; "Why is tipsy violating normal jQuery expectations?" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60235 [09:15:29] New patchset: Krinkle; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [09:16:29] New review: Nikerabbit; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60229 [09:18:32] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60225 [09:19:12] New review: Amire80; "Maybe plugins behave differently? I don't know." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60235 [09:19:38] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60272 [09:22:51] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53189 [09:34:58] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53189 [09:35:34] New patchset: Jeroen De Dauw; "Fix how student id is passed to ArticleTable" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60376 [09:36:58] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60272 [09:44:39] New review: Nikerabbit; "Wouldn't this be better done in code? For example, the logging code uses different variables for use..." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/59963 [09:44:50] New patchset: Campbell Tang; "my first commit" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/60377 [09:49:20] New review: TheDJ; "Hmm, I'm mostly ambivalent about this. The handheld media query never really saw much success I ques..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [09:59:01] New review: Nikerabbit; "(4 comments)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [10:01:19] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [10:03:19] New review: J; "(2 comments)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [10:05:17] New patchset: J; "add maintenance script to retry failed transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [10:09:50] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [10:11:49] New patchset: Campbell Tang; "my first commit" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/60377 [10:16:58] New patchset: IAlex; "Renamed QoS_Atomic => QOS_ATOMIC in some places." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60237 [10:17:01] New review: J; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60249 [10:17:40] New patchset: J; "(bug 47483) update file metadata in importImages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60249 [10:22:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60237 [10:33:44] guillom, in http://blog.wikimedia.org/2013/04/22/wikipedia-adopts-mariadb/ the tag should be Percona, not Percola [10:34:00] MaxSem: thanks, will fix now [10:34:11] New patchset: Matthias Mullie; "WIP - UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [10:34:12] * aude looks for the edit button on the blog :) [10:34:43] Fixed [10:34:52] guillom: while you're at it, could you please update the "MediaWiki commits" link? [10:34:55] in the sidebar [10:35:09] aude: sure, if you tell me what to update :) [10:35:18] well, it still links to svn stuff [10:35:39] link it to https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core,n,z [10:36:05] ok [10:36:05] just something i noticed [10:36:37] or if you want all the changes [10:36:50] fixed [10:36:54] k [10:36:58] :) [10:37:13] looks good [10:38:28] New patchset: Mwjames; "SMWHooks::addRefreshTab clean-up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60379 [10:40:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60379 [10:45:29] New patchset: Matthias Mullie; "No need to cache lb's, they're cached in LBFactory classes already." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59991 [10:57:39] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60301 [10:57:56] New patchset: Reedy; "Lossless PNG compression..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60381 [10:58:49] New review: Reedy; "reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ git pull ssh://reedy@gerrit.wikimedia.org:2941..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60381 [11:08:26] New review: Ori.livneh; "lintastic" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/60269 [11:11:42] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [11:15:13] New patchset: Platonides; "Simplify the nested ifs of Preprocessor_DOM::preprocessToObj()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60382 [11:15:13] New patchset: Reedy; "Lossless PNG compression..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60381 [11:21:05] New patchset: Platonides; "Fix case of $wgLocalTZoffset from 7e3386d4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60383 [11:25:32] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [11:26:41] New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [11:26:52] New review: Liangent; "I?m not sure what the purpose of the following line is, but it doesn't matter because it's already i..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60248 [11:27:29] New patchset: IAlex; "StatCounter doc tweaks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60318 [11:29:56] New patchset: Mwjames; "SMWHooks::addPoweredBySMW clean-up" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60384 [11:32:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60318 [11:36:41] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [11:38:25] New review: Parent5446; "My apologies. (I'll refrain from +2 just in case.)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60383 [11:39:17] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59819 [11:39:41] New patchset: IAlex; "Moved CryptRand.php to MWCryptRand.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60236 [11:43:22] New patchset: Nikerabbit; "(bug 47262) Magic word localization in Galician." [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59652 [11:43:55] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59652 [11:44:47] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60236 [11:48:12] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60384 [11:52:45] New patchset: IAlex; "User::addGroup could cause duplicate groups" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57284 [11:55:28] New review: Sumanah; "Congratulations on your first commit!" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/60377 [11:55:47] Change abandoned: Hashar; "so that needs root. I will have to find another way to build packages :(" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56407 [11:57:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57284 [11:57:56] New patchset: Pginer; "WIP: Split language settings view into two tabs" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60271 [12:16:19] New patchset: Amire80; "Split language settings view into two tabs" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60271 [12:25:26] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [12:28:45] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [12:37:16] New patchset: Amire80; "Add the sidebar ULS cog icon and $wgULSPosition variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [12:37:21] New patchset: Raimond Spekking; "Add DisambiguationPages to alias file too" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/60387 [12:38:02] New review: Amire80; "All addressed except the images issue." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [12:41:02] New patchset: Ganeshaditya1; "Adding a MediaWiki Extension link to the installer last screen" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60388 [12:43:33] New review: Nikerabbit; "(15 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57823 [12:47:38] New review: Zfilipin; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [12:51:33] New patchset: Mwjames; "SMW\DataValueFactory add assertion" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60391 [12:53:10] New patchset: Mwjames; "SMW\DataValueFactoryTest add assertion" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60391 [12:53:26] New review: Zfilipin; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [12:54:19] New patchset: Pginer; "Add the sidebar ULS cog icon and $wgULSPosition variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [12:58:20] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60235 [12:59:29] New review: Mwjames; "Lesson learned always check the whole function definition especially when parameters set by default." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/60391 [12:59:40] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60391 [13:03:41] New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [13:05:10] New patchset: IAlex; "Simplify the nested ifs of Preprocessor_DOM::preprocessToObj()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60382 [13:06:01] New review: Zfilipin; "(2 comments)" [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/60041 [13:10:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60382 [13:17:36] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60391 [13:18:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60383 [13:22:09] New review: Cmcmahon; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60041 [13:27:23] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [13:31:11] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60391 [13:31:34] New patchset: Demon; "Revert "Remove Special:ActiveUsers"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58686 [13:31:45] oh? [13:31:59] I guess the community has spoken [13:32:15] ^demon: hello :] [13:32:32] New patchset: IAlex; "Fix TimestampTest broken by 7e3386d4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60392 [13:32:54] New patchset: Demon; "Revert "Remove Special:ActiveUsers"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58686 [13:32:59] ^demon: I am going to request a bunch of git repositories deletions. Either migrated ones or some that have been created but never used. [13:33:23] apergos: if by spoken you mean, by prodding with pitchforks, than yes [13:33:42] that's what it usually amounts to [13:33:49] i mean not at first but [13:34:19] that whole 'speak softly an carry a huge pitchfork' thing is highly overrated. you have to actually put it to use [13:37:54] New patchset: Mwjames; "Refactor SMWParserExtensions, convert static into an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60393 [13:38:51] New review: Cmcmahon; "Chrome support" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60003 [13:38:52] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60003 [13:39:35] New review: Cmcmahon; "update FF to v 20" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60120 [13:39:36] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60120 [13:40:13] New review: Mwjames; "I'll have to make a preceding commit that only contains the file renaming in order to keep the commi..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60393 [13:40:55] New patchset: Demon; "Make it possible to disable Special:Activeusers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60394 [13:41:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60393 [13:42:00] New patchset: Demon; "Make it possible to disable Special:Activeusers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60394 [13:43:48] ^demon: thought about adding misermode checks onto that as well, so you don't kill domas's soul on the cluster? [13:44:00] <^demon> Every wiki is miser mode. [13:44:14] <^demon> Which is why I introduced a new global for it. [13:44:53] New review: Nikerabbit; "Can we use $wgMiserMode? Besides there are other ways to disable special pages, no need for config v..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60394 [13:44:58] hah [13:45:03] sorry I didn't see your discussion [13:45:20] still, I think the global is not needed [13:45:25] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:46:16] New review: IAlex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [13:46:20] <^demon> Meh, global was easy. [13:46:36] <^demon> But yeah, miser mode won't work here :) [13:49:54] New patchset: Zfilipin; "Remove tags where not necessary to simplify Jenkins job configuration" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60396 [13:53:45] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60243 [13:53:45] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60243 [13:54:37] New patchset: IAlex; "Update messages.inc and rebuild MessagesEn.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60398 [13:56:56] New review: Anomie; "(3 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60198 [13:58:09] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [14:31:26] New patchset: Hashar; "remove executable bits from files" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/60401 [14:31:47] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [14:32:15] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [14:33:49] New patchset: Nikerabbit; "Split language settings view into two tabs" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60271 [14:34:05] New patchset: Amire80; "Add hlep text above the buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [14:34:13] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [14:39:38] New patchset: Hashar; "labs/incubator triggers phplint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60403 [14:39:38] New patchset: Hashar; "labs/nagios-builder now has gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60404 [14:39:38] New patchset: Hashar; "triggers for mediawiki/skins/*" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60405 [14:40:00] New patchset: Hashar; "labs/incubator phplint job" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60406 [14:40:01] New patchset: Hashar; "phplint jobs for mw/skins/*" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60407 [14:41:20] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60271 [14:41:27] New patchset: Nikerabbit; "Add help text above the buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [14:42:22] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60406 [14:42:29] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [14:42:31] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60407 [14:43:11] New patchset: Hashar; "labs/nagios-builder now has gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60404 [14:43:11] New patchset: Hashar; "triggers for mediawiki/skins/*" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60405 [14:43:12] New patchset: Hashar; "labs/incubator triggers phplint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60403 [14:43:52] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60403 [14:44:05] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60404 [14:44:15] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60405 [14:45:57] New review: Hashar; "recheck" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/60401 [14:47:23] New patchset: Matthias Mullie; "Claim feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/33383 [14:48:03] New patchset: Amire80; "Add help text above the buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [14:54:16] New patchset: Demon; "Adding a couple of recent extensions to meta repo" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/60411 [14:54:48] New patchset: IAlex; "Update AutoLoader" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60412 [14:55:08] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60402 [14:59:00] New review: IAlex; "Please amend the parent commit instead of submitting a new one. Thanks." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60388 [14:59:19] New patchset: Hashar; "ops/sw/redactatron : pep8 linter" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60413 [15:00:20] New patchset: Hashar; "ops/sw/redactatron triggers pep8" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60414 [15:00:31] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60413 [15:00:38] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60414 [15:18:16] New review: Daniel Friesen; "Personally I'd sooner exterminate actions then improve them." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/49785 [15:23:07] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49777 [15:32:03] gerrit keeps returning a "Permission Denied (public key)" for some reason [15:32:14] it was working perfectly fine till yesterday! [15:33:22] New patchset: Matthias Mullie; "MWTimestamp::getHumanTimestamp no longer returns Message but simple string" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60419 [15:34:38] New patchset: Mwjames; "Follow-up, use set/getExtensionData() for MW 1.21+ in SMWFactbox" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [15:34:48] New review: Matthias Mullie; "Not to be deployed before https://gerrit.wikimedia.org/r/#/c/45651/ is" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -2; - https://gerrit.wikimedia.org/r/60419 [15:35:11] New review: PleaseStand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60269 [15:50:34] New review: Jeroen De Dauw; "(4 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [15:53:42] New patchset: PleaseStand; "Remove is_numeric check from Title::checkUserBlock" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58308 [15:54:42] New patchset: Amire80; "Show the web fonts selectors only if they are enabled" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60421 [16:13:19] New patchset: Reedy; "Add $wgTorBlockProxy. Used for loading Tor exit node list" [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/60422 [16:17:07] Change merged: jenkins-bot; [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/60422 [16:27:24] New patchset: Reedy; "Update TorBlock to master" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60429 [16:27:49] New patchset: Reedy; "Update TorBlock to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60430 [16:31:07] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60429 [16:31:12] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60430 [16:34:42] New patchset: Mwjames; "Follow-up, use set/getExtensionData() for MW 1.21+ in SMWFactbox" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [16:35:53] New review: Mwjames; "(3 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [16:38:18] <^demon|away> Nikerabbit: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/TwnMainPage.git;a=summary - how's this look? This split the history of the MainPage directory into its own repo. [16:38:40] <^demon|away> I think it's prolly best to not rewrite the existing history to remove the path...just delete it in a commit and move forward. [16:39:03] ^demon|away: yes that's my plan [16:39:37] <^demon|away> Okay, you should be all set then. [16:40:44] thanks! [16:41:18] <^demon|away> yw. [16:42:28] New patchset: Mwjames; "Follow-up, use set/getExtensionData() for MW 1.21+ in SMWFactbox" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [16:43:18] <^demon|away> Nikerabbit: If you're ever looking to do something like this yourself, the tool you're looking for is `git filter-branch.` :) [16:44:21] ^demon|away: let's hope not but one can never know :) [16:47:32] Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/60411 [16:51:38] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60436 [16:52:44] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60437 [17:06:45] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [17:08:12] New patchset: IAlex; "Move "SpecialSearchResultsPrepend" note back to 1.21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59850 [17:14:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59850 [17:14:26] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [17:17:06] greg-g: There is a new favicon to push for wikidata if I can have room in the LD today [17:18:11] New patchset: Reedy; "Fixup truncated license header" [mediawiki/extensions/TorBlock] (master) - https://gerrit.wikimedia.org/r/60439 [17:18:28] mwalker: awesome, sounds good, add it to the wiki page, plz [17:19:30] mwalker: Yay, Mr. FavIconMan. :-) [17:20:07] yeppers, using *his* lightning deploy window [17:22:32] no no; since Isarra's the one creating the favicons -- it's Ms. FavIconista or something [17:22:57] mwalker: You're the one helping the community make it happen, though. [17:23:08] mwalker: So lots of credit to you too. :-) [17:23:18] Aye, he doesn't hate me. [17:23:27] After everything I've done, that's pretty impressive. [17:23:53] matthew lightning walker [17:23:59] now... If only I could remember my password to wikitech :p [17:24:31] Matt Lightwalker? [17:24:53] I've been called worse [17:24:57] ori-l: He changed his first name from "Greased" [17:24:57] mwalker: Losing your lustre here. :-) [17:25:15] heh [17:25:32] Achievement unlocked, cause James_F to laugh uproariously [17:28:43] marktraceur: well done, sir. here's your ceremonial smile: [17:28:45] marktraceur: :) [17:29:12] New review: Ori.livneh; "I think we need to also run 'apt-key update':" [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/59716 [17:29:19] New patchset: TheDJ; "Check for If-None-Match to determine changed responses" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [17:29:37] Ooh, a TheDJ patch [17:31:20] mwalker: I have some other favicons that I haven't figured out how to get into gerrit yet, so you might want to do the lot at once. [17:31:57] Isarra: it's really quick to deploy these so no worries -- as you get to them [17:32:36] Okay. [17:32:53] If a community doesn't like a change, who would they yell at? [17:34:18] they don't know who to yell at most of the time. [17:34:21] Isarra: Since Ironholds isn't in this channel we'll go with him [17:34:27] Isarra: it's determined by the wheel of blame http://en.wikipedia.org/wiki/User:MZMcBride/Blame_wheel [17:34:52] Cool. [17:35:06] but in all seriousness -- the individual or team who made the change [17:35:15] wow, that wheel needs some expanding. now at least half of it should be 'WMF' [17:35:27] That wheel is also rather project-specific. [17:35:54] Says nothing of the intricacies of the polish wikisource. [17:36:05] what? [17:36:12] did polish wikisource wrong you? :P [17:36:15] thedj: Hey, welcome back by the way, haven't seen you about recently (or maybe I wasn't paying attention) [17:36:30] Naw, it was just the first non-english non-wikipedia that came to mind. [17:36:47] but yeah, wikisources are scary. [17:36:59] mwalker: How would they find out who made the change? [17:37:25] they can look at gerrit [17:37:35] or even use "git blame" literally [17:37:36] deployments calendar is also good if it's off the train [17:37:48] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60436 [17:37:49] marktraceur: i was inactive for about 4 months yes, maybe 5 [17:38:00] or actually -- if all else fails send an email to wikitech [17:38:23] Cool, I thought so [17:38:31] thedj: So yes, definitely welcome back :) [17:38:53] And how many community people would know to (or even how to) do any of that? >.> [17:40:09] very few -- which is why teams watch a lot of pages to try and find complaints -- and to a certain extent rely on community members who do know how to get in contact with us to poke us when they see things [17:40:50] but; this is also an argument for having dedicated community members ala Ironholds but for features as well as product [17:40:51] But there are so many pages! Too many to watch all. [17:41:06] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60437 [17:41:18] Isarra: yup, eternal problem [17:41:24] Dedicated community people for sister projects would be nice. [17:41:32] ...well, in theory. [17:41:53] I just had a horrible thought of a turkish lynch mob. >.> [17:42:42] Heh, it took us 8 months to figure out Tim had killed our method of being listed with Google News. [17:43:12] >.< [17:44:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60412 [17:44:11] Really? When did that happen [17:44:14] New review: Anomie; "(3 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [17:44:23] The instigation for GNSM, bawolff. [17:44:24] New patchset: TheDJ; "Check for If-None-Match to determine changed responses" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [17:44:59] Oh you mean the noindex on non canonical urls [17:45:18] No, the removal of the number from the urls. [17:45:32] Which, at the time, google news required. [17:46:23] Change abandoned: Aaron Schulz; "Archived" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56567 [17:46:32] New patchset: Daniel Kinzler; "Support langlinks from hooks in ApiQueryLangLinks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60034 [17:52:31] New patchset: Reedy; "Adds the spoofuser table to the centralauth database." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/39008 [17:53:32] New patchset: Reedy; "Refactoring specials/SpecialGlobalGroupPermissions.php to use XML forms." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52300 [17:53:56] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52300 [17:55:37] New patchset: Reedy; "Refactoring SpecialGlobalUsers.php and SpecialMergeAccount.php to use XML and HTML forms." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52337 [17:57:45] New review: Reedy; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/52337 [17:58:26] New patchset: Reedy; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [17:59:41] New review: Reedy; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/23177 [18:01:33] New patchset: Reedy; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [18:02:57] New patchset: Reedy; "Refactoring Special:CentralAuth to use XML and HTML forms." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52297 [18:04:01] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52297 [18:04:17] New review: Mwalker; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [18:06:26] New patchset: Kaldari; "Some comment fixes" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60446 [18:06:36] New patchset: IAlex; "Minor fixes to the code documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57826 [18:08:24] Amgine: I don't recall that happening - the original issue was the numbers triggered noindexing headers which googlebot didnt like for the obvious reason [18:08:51] New review: Mwalker; "Drupal/Civi/+other 3rd party modules have terrible strict problems -- ie; on the order of thousands ..." [wikimedia/fundraising/crm/drupal] (master) - https://gerrit.wikimedia.org/r/60348 [18:10:31] New patchset: Reedy; "Add option to meta=globaluserinfo to provide global edit count" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [18:10:39] New patchset: Reedy; "Add option to meta=globaluserinfo to provide global edit count" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [18:10:51] bawolff: I don't remember the exact situation, other than tracking it down in Sept. to SVN commit by Tim in January; which he then 'fixed' by adding googlehack to DPL. [18:11:07] thanks Reedy [18:11:09] Which got about 70% pickup by googlebot. [18:11:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57826 [18:12:49] New patchset: Reedy; "Add option to meta=globaluserinfo to provide global edit count" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [18:17:42] New patchset: Reedy; "Bug 28768 - meta=globaluserinfo doesn't display homewiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58873 [18:17:51] New patchset: Reedy; "Bug 28768 - meta=globaluserinfo doesn't display homewiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58873 [18:21:46] New patchset: Jeroen De Dauw; "Added CourseActivity special page" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60449 [18:23:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60449 [18:23:36] New patchset: Pgehres; "Refactoring SpecialGlobalUsers.php and SpecialMergeAccount.php to use XML and HTML forms." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52337 [18:25:28] New patchset: Reedy; "Refactoring SpecialGlobalUsers.php and SpecialMergeAccount.php to use XML and HTML forms." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52337 [18:25:35] http://wtfjs.com/2013/02/21/why-am-i-a-number [18:25:38] https://github.com/brianleroux/wtfjs/issues/61 [18:25:52] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52337 [18:27:19] New patchset: Catrope; "Allow iiurlheight to be used without iiurlwidth" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60450 [18:27:29] New review: Reedy; "Not sure if just commenting out (for now) the exclude group code would be the simplest option, then ..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [18:27:55] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60225 [18:28:17] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [18:28:22] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [18:31:06] New patchset: Aaron Schulz; "Include cluster name in JobQueueDB cache keys." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60225 [18:35:00] Reedy: thanks for all the CR [18:35:13] np [18:35:31] I noticed it was a bit backlogged [18:35:50] Heh, yeah, and since no one cared about a refactor … it languished [18:38:21] New patchset: EBernhardson; "Hide preference for disabling fly-out notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [18:38:53] There's another 3-4 that can probably be merged now.. 1 with some code to comment out I think [18:38:59] Change abandoned: EBernhardson; "test commit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60349 [18:40:12] Happy to make any changes. I try to make them as quickly as I can after someone comments [18:40:45] New review: Kaldari; "Looks good" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/60451 [18:40:47] These are other peoples commits.. so you could even merge them! ;) [18:40:51] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/CentralAuth,n,z [18:41:31] Reedy: I could, yes, but I still seem to miss things, and when it comes to CentralAuth, better safe than sorry :-) [18:41:53] Still wrapping my head around that hairball [18:42:54] pgehres: If you think you understand CentralAuth... you don't. [18:43:03] So true [18:43:23] [18:43:42] New patchset: EBernhardson; "Hide preference for disabling fly-out notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [18:43:43] Virtual cookies for working on it, though. [18:44:37] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58873 [18:44:47] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/56397 [18:45:23] New review: Alex Monk; "Why would we want to do this...?" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [18:47:45] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [18:48:02] New review: Nischayn22; "I am not sure, The original author replied to my mail and seemed happy about this migration. I reque..." [mediawiki/extensions/MsUpload] (master) - https://gerrit.wikimedia.org/r/60101 [18:48:46] j^: reminds me, how does deleting transcode table items trigger retries? [18:50:49] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [18:54:18] New patchset: Katie Horn; "Adjustment to the iFrame liberator such that it hides all elements that other resourses might add (skin stuff, whatever) while we're waiting for the liberated iframe contents to load." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/60453 [18:56:38] New review: Adamw; "Won't this result in a blank page?" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/60453 [18:57:54] New review: Katie Horn; "Yes. A blank page is exactly the intention, as it's still in the iframe at that point." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/60453 [18:59:40] New patchset: Pgehres; "(bug 38082) Check read permissions in ApiFeedContribs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20922 [19:00:44] Change merged: Adamw; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/60453 [19:00:50] New review: Pgehres; "PS5 is a rebase" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/20922 [19:01:02] New review: Kaldari; "bug 47562" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [19:07:03] greg-g: if anyone needs to deploy; I'm done [19:07:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20922 [19:08:46] New patchset: Aaron Schulz; "[JobQueue] Simplified federated queue config by removing wiki/section stuff." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60455 [19:11:44] New patchset: Hashar; "python jobs for analytics/*" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60456 [19:11:52] brion: https://gerrit.wikimedia.org/r/#/c/60073/ [19:13:15] New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/60456 [19:13:15] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60456 [19:13:15] New patchset: Kaldari; "Hide preference for disabling fly-out notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [19:13:35] New review: Ori.livneh; "Can you remove 'analytics/glass'? The repository needs to be deleted. I have been lazy about it -- s..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/60456 [19:15:45] New patchset: Hashar; "triggers pep8/pyflakes for analytics/*" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60458 [19:16:06] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60458 [19:16:12] New patchset: Kaldari; "Hide preference for disabling fly-out notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [19:17:06] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/60451 [19:20:36] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60201 [19:22:44] New patchset: Vedmaka Wakalaka; "Extended Page Schemas integration" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [19:24:37] New patchset: Demon; "Change default logo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57533 [19:25:00] New review: Mattflaschen; "(3 comments)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [19:25:18] New patchset: TheDJ; "Use wfShellExec in MimeMagic" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60201 [19:25:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60225 [19:26:43] mutante: did you find out what was causing the wikibugs change to not be deployed? [19:27:26] Krinkle: oh, multiple reasons at once :p [19:27:53] it doesn't have the separated logfiles, it cant git clone, it started multiple processes [19:29:08] New patchset: Mattflaschen; "Fix HTML escaping error" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [19:29:35] New patchset: Anomie; "Add Javascript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [19:31:02] New patchset: Demon; "Change default logo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57533 [19:33:25] New patchset: Vedmaka Wakalaka; "Extended Page Schemas integration" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [19:33:39] New patchset: Anomie; "Update Cite to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60470 [19:34:34] New review: Anomie; "Backport fix" [mediawiki/core] (wmf/1.22wmf2); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60470 [19:34:35] Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60470 [19:50:08] New patchset: Ori.livneh; "Remove 'reload-apache2' exec; set backup => false" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60473 [19:52:24] lilypond is big [19:52:25] 0 upgraded, 57 newly installed, 0 to remove and 0 not upgraded. [19:52:25] Need to get 373 MB of archives. [19:52:25] After this operation, 955 MB of additional disk space will be used [19:53:23] New patchset: MaxSem; "Update MobileFrontend and Zero" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60474 [19:56:21] o_0 [19:56:27] lilypond-doc is 249MB [19:57:25] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [19:58:40] New review: Vedmaka Wakalaka; ">>It looks like the and tags are now attributes of ..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [19:58:58] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [19:59:00] Isarra: re your wikiquote and wikimania favicons -- they don't seem to have 16x16 variants -- was that just an oversight? [19:59:44] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [20:00:28] New review: Cscott; "Patch set 4 incorporates Parent5446's comments. Patch set 5 is a rebase on current master." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [20:00:49] Reedy: 250MB ? must include examples or something... [20:01:28] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60474 [20:03:00] http://packages.ubuntu.com/quantal/lilypond-doc [20:03:04] "LilyPond Documentation in HTML, PS and DVI formats" [20:03:39] Hmm, it's only supposed to be recommends [20:03:44] mwalker: The 16x16 ones would just be scaled down versions of the same, no tweaking. Unless there are browsers too stupid to scale down the 32px ones, no need to include 16px too. [20:03:54] That said, I wouldn't rule that possibility out. >.> [20:04:12] Do you have any idea who might be able to say for more sure? [20:04:59] And even better than that, I bet most of them will have changed for 13.04 [20:05:11] Isarra: not really -- brion is a good guess, jorm, possibly roan [20:06:31] Isarra: mwalker: I *suspect* they'll scale down 32x32 just fine. suspect. :) [20:06:45] What a coincidence! I suspect that too. [20:06:56] :) [20:07:01] It's IE6 that I'm skeptical about [20:07:02] That said, wikitravel is already doing it that way - has anyone complained about that one? [20:07:20] i wouldn't worry about IE; it'll almost certainly use standard Windows functions to decode and draw the .ico [20:07:34] cool [20:07:49] my windows xp VM isn't handy so i can't test right now [20:08:13] i should stick my spare VMs on a SD card or something so i can have them with me without eating up SSD space [20:08:14] I broke my vmware, so I can't test anything anymore. >.< [20:08:30] kk -- I'll push it and then test in crossbrowsertesting [20:08:34] Upgrading, it turns out, was not such a good idea. [20:08:58] heh [20:09:08] licensing issues? [20:09:31] Graphics. [20:09:37] New review: Cscott; "(4 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [20:09:54] yay old hardware! [20:10:02] It's not that old! [20:10:13] the exact thing virtualization was invented to solve! [20:10:16] If I can play skyrim, it can't be that old! [20:10:20] * Isarra grumps. [20:10:34] it's not just off the factory line -- that's terribly old in computer terms! [20:10:35] ps3 can play skyrim, it's ancient by now :) [20:10:54] >.> [20:11:06] I don't actually know of any current games. [20:11:38] New review: Cscott; "Status of this patch: likely to be abandoned since https://gerrit.wikimedia.org/r/59572 (Special:Re..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [20:12:02] GW2 was released less than a year ago, but given how long it was in production... the graphics are from like 2008. [20:13:28] mwalker: Contrast is a potential issue with a lot of these favicons, but how common are blue tab backgrounds, really? [20:13:57] ...should we put them on white thingies? I recall that being explicitly turned down for the wmf one, at least. [20:14:05] But that's three colours. [20:14:24] I was more thinking about people who save to a mobile device and it places the icon directly on whatever background they're using [20:14:37] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [20:14:37] People do that? [20:14:43] http://bug-attachment.wikimedia.org/attachment.cgi?id=12162 WFM :D [20:14:49] I'm guessing they bookmark the homepage [20:14:55] but it's probably also a bit of an edge case [20:15:02] and iDevices do their composed icon crap [20:15:17] I'll check on Android [20:16:28] Reedy: what is the point of WikibaseClient? [20:16:31] it's just empty [20:17:00] It was deleted quite a while ago [20:17:05] How do you do that with a smartphone? [20:17:11] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikibaseClient.git [20:17:21] Someone lended me one to play with for a bit, but I have no idea how to do anything with it. [20:18:12] I'm discovering that myself currently [20:18:21] Reedy: git clean -df is my friend [20:18:32] lol [20:18:45] Delete all your extensions from time to time [20:18:47] and clone again [20:19:13] does git submodule sync not clean away old things? [20:19:34] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60468 [20:20:06] Reedy: huh, it says it removed them but they are still there [20:20:53] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [20:20:53] New patchset: Brian Wolff; "Do not allow sorting Special:Listfiles by img_name when filtering by username" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [20:21:25] Isarra: on my phone at least it looks like bookmarks are created with a custom icon that has nothing to do with the site it came from :p [20:21:39] marktraceur: Hmm, it rebased both of them at once! [20:21:43] Yup! [20:21:50] Magic of git. [20:21:56] mwalker: Of course. >.< [20:22:42] mwalker: Favicons? Just take the first tag in the page, that'll be *way* more user friendly [20:23:15] nah; create a 2d barcode of the URL [20:23:21] Oh, hell yeah [20:23:22] that way everythings distinct! [20:23:35] Then we can take a picture of the bookmark with our phone and...no, wait [20:23:36] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [20:24:14] marktraceur: sounds very web 3.14159 [20:24:33] New review: Brian Wolff; "PS4: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [20:25:35] mwalker: Web 3.14159 is just sending packets in dough [20:25:47] mwalker: But there's 100% packet loss...*delicious* packet loss [20:26:29] please tell me you've seen the RfC for IPoAC? [20:26:41] New patchset: Ottomata; "Adding apt.wikimedia.org to this machine's sources.list.d" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [20:28:36] Uhhh maybe not [20:28:37] AC? [20:29:15] Avian Carrier -- http://www.ietf.org/rfc/rfc1149.txt and then w/ QoS: http://tools.ietf.org/html/rfc2549 [20:29:24] Oh, yeah [20:29:30] IPoP was my recollection [20:29:35] IP over Pigeon [20:30:07] I think someone made an experimental implementation that used pidgeons [20:31:05] Yeah, I remember that [20:31:06] It beat out some South African ISP [20:34:30] New review: Vedmaka Wakalaka; "Hi, Mwjames!" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/53980 [20:34:47] New review: Brian Wolff; "PS3: rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [20:34:53] <^demon|away> marktraceur: Probably beats most connections in the DPRK. [20:35:35] New review: Anomie; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [20:36:11] ^demon|away: They're experimenting with IP over Goosestepping [20:36:16] 's not going very well [20:42:41] New patchset: Reedy; "Update Wikibase with patch for link item widget" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60314 [20:43:50] Yippie, build fixed! [20:43:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #12: FIXED in 5 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/12/ [20:44:02] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [20:45:41] New review: Anomie; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60450 [20:48:30] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60314 [20:51:19] New review: Hoo man; "Thanks :)" [mediawiki/extensions/CentralAuth] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/52022 [20:53:01] New patchset: Ottomata; "Adding apt.wikimedia.org to this machine's sources.list.d" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [20:56:31] New patchset: Vedmaka Wakalaka; "Fixed but when $options array was empty in $select DomElement at SF_AutoeditAPI.php" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53270 [20:57:41] New review: Vedmaka Wakalaka; "Hi, Foxtrott!" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53270 [20:58:51] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [21:01:06] New review: Hoo man; "(3 comments)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/60282 [21:02:22] New patchset: Ottomata; "Adding apt.wikimedia.org to this machine's sources.list.d" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [21:03:17] New patchset: Brian Wolff; "Add parentid to output of list=usercontribs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60571 [21:05:14] New review: MarkTraceur; "Forgot to submit, Raylton" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/59367 [21:05:46] New review: Ori.livneh; "Per IRC convo, I think this should be replaced with a proper apt module, but since it's not included..." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/59716 [21:06:23] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [21:06:23] hoo, oh wow, what was I thinking with that in_array... [21:06:27] anyway thanks for the review [21:06:41] :D [21:06:43] New patchset: Ori.livneh; "Remove 'reload-apache2' exec; set backup => false" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60473 [21:07:08] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60473 [21:08:02] New patchset: MaxSem; "Update MobileFrontend and Zero" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60573 [21:08:32] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60573 [21:10:14] New patchset: Amire80; "WIP: Scroll the ULS panel into view automatically" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60574 [21:10:19] hoo, I'm kinda wondering how that worked in testing now... I swear the logic is backwards... [21:10:56] New review: Amire80; "Don't submit at least until the upstream change is merged. And there may be more issues, of course." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/60574 [21:11:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [21:11:37] Krenair: :P Maybe you had the flag already? [21:15:42] New review: MarkTraceur; "Good!" [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/52628 [21:15:56] New patchset: Reedy; "Update Score to master" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60575 [21:16:11] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60575 [21:16:20] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/52628 [21:17:34] New patchset: Brian Wolff; "Add parentid to output of list=usercontribs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60571 [21:18:47] Change merged: Raylton P. Sousa; [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/59367 [21:19:41] New patchset: Hoo man; "Deprecate addHolder for addHolders." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:20:26] New review: Hoo man; "Improved code styling + comments. Tested." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:21:14] New review: Hoo man; "Seems more sane than the old function ;)" [mediawiki/extensions/AbuseFilter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/52360 [21:21:35] New review: Raylton P. Sousa; "Done, thank you :)" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/59367 [21:22:38] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:22:55] New patchset: Ottomata; "Adding misc::git::clone define" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/60577 [21:23:27] New patchset: Brian Wolff; "Add Special:[All]MyFiles as alias for Special:[All]MyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [21:23:40] New patchset: Yaron Koren; "Added DTPageComponent and DTPageStructure classes to improve code structure" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/60578 [21:23:50] New review: Brian Wolff; "PS3: rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [21:26:33] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [21:26:34] New patchset: Brian Wolff; "Do not allow sorting Special:Listfiles by img_name when filtering by username" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [21:26:34] New patchset: Brian Wolff; "Add Special:[All]MyFiles as alias for Special:[All]MyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [21:26:42] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/60578 [21:26:51] ok, that should definitely be enough rebasing [21:27:45] bawolff: Hang on, I'll merge something to core for you so you can do it again [21:28:22] meh, if jenkins doesn't like it now, I'll just wait for someone to give it a +2 before attempting to rebase [21:30:05] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/52981 [21:30:24] New patchset: Mwalker; "Add All Fields!" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60581 [21:32:04] New review: MarkTraceur; "I like!" [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/55110 [21:32:49] New patchset: Aaron Schulz; "Fixed return value for RedisBagOStuff::cas()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60582 [21:33:05] New review: Krinkle; "Should merge() also be deprecated?" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:33:31] New review: Krinkle; "Ah, my copy is outdated. commit message is updated and change merged." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:35:34] New review: Hoo man; "I guess we should... AbuseFilter itself isn't using it anywhere now." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/52360 [21:36:59] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/55110 [21:37:22] New review: Adamw; "(4 comments)" [wikimedia/fundraising/crm] (master) C: -1; - https://gerrit.wikimedia.org/r/60581 [21:41:09] New review: Ori.livneh; "There's a similar git class in puppet/modules/mediawiki/git.pp which should be made more reusable or..." [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/60577 [21:45:00] New patchset: MarkTraceur; "(bug 40920) handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [21:46:58] New review: Mattflaschen; "This also resolves some conflicting styles (e.g. margin and width)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/60373 [21:51:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60373 [21:52:36] New patchset: Alex Monk; "Allow MultiLock users to use a temporary bot right for RecentChange entries" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60282 [21:54:09] New review: MarkTraceur; "Tested by adding Template:PD-Blah with text" [mediawiki/extensions/UploadWizard] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/50755 [21:58:22] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/53041 [22:04:31] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [22:06:30] Any AFTv5 people? [22:08:14] Jarry1250: Whatcha need? [22:09:10] marktraceur: I'm interested in this week's enwiki deployment, specifically, what articles are involved [22:09:48] kaldari: Care to field? [22:10:13] deployment of what? [22:10:38] Oh AFTv5 [22:10:59] It should only affect articles that are opted into AFT as far as I know [22:11:40] and they are opted into AFT via a hidden category [22:13:18] New review: Spage; "(14 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [22:14:06] kaldari: Okay, thanks, that's what I suspected but I thought I'd check [22:14:36] New patchset: Reedy; "Don't pass an array when a string is what is wanted..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/60591 [22:15:01] Aaron|home: ^^ That fixes the wrong passing of parameters [22:17:39] Change merged: jenkins-bot; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/60591 [22:18:25] New patchset: Reedy; "Update Score to master" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60593 [22:19:13] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60593 [22:22:22] DarTar: were you still planning on building an EventLogging schema for Echo email delivery? Should I pull Luke to work on this or wait until you have the schema ready? [22:24:05] reedy: btw Score errors are ugly [22:24:06] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [22:24:13] I know [22:24:23] they're a dump of console output [22:24:57] New patchset: Reedy; "Update Score to master" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60595 [22:25:14] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/60595 [22:34:09] New patchset: Alex Monk; "Detect user rights conflicts" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [22:34:53] New review: Alex Monk; "Turns out I was making this way more complicated than it needed to be. Thanks to hoo for the idea." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [22:35:25] oril-l, I'm researching how to enable EventLogging on Labs. Looks like it needs a machine with eventlogging class applied, anything else? [22:40:31] wee https://www.mediawiki.org/wiki/Thread%3AProject%3ASupport_desk/000webhost [22:40:55] New patchset: Reedy; "Parameter type hints" [mediawiki/extensions/HTMLTags] (master) - https://gerrit.wikimedia.org/r/60598 [22:42:12] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60420 [22:43:49] New patchset: Hoo man; "[WIP] Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [22:45:29] New review: Hoo man; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [22:46:03] New review: Krinkle; "(1 comment)" [mediawiki/extensions/HTMLTags] (master) C: -1; - https://gerrit.wikimedia.org/r/60598 [22:46:51] New patchset: Hoo man; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [22:57:15] New patchset: Mwalker; "Updating ThankYou emails" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60603 [22:57:32] New review: MZMcBride; "The sooner the better." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58686 [22:59:46] RoanKattouw_away: so, I'm trying to use some interface elements from skins/common/images in css in classes, then using javascript to toggle classes on spans, but I don't seem to understand how to load these [22:59:52] RoanKattouw_away: any suggestions? [23:00:11] Ryan_Lane: Load what, the CSS? [23:00:13] New review: Adamw; "Greek to me :(" [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60603 [23:00:14] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60603 [23:00:20] since this is in an extension, the style path isn't from the root [23:00:28] the images in the css [23:00:40] Oh, right [23:00:47] Are you loading the CSS via ResourceLoader? [23:00:51] yep [23:00:59] Then all paths are relative to the CSS file itself [23:01:01] RL remaps them for you [23:01:10] except that I want to use the common images [23:01:16] You are also encouraged to use /* @embed */ as much as possible, which will data-URI-embed the images [23:01:18] they don't exist in my extension [23:01:18] Ah I see [23:01:41] I don't think we've ever run into that use case [23:01:42] I see that almost every extension adds the same images over and over in their extensions [23:01:44] it's really silly [23:01:48] You generally don't know where the common images are [23:01:51] we should have a shared set of interface elements [23:01:54] Yes [23:02:03] We should just define classes in shared.css for those images then I suppose [23:02:21] RL or no RL, you don't know the relative path from your extension to core [23:02:34] meh. screw it. I don't want to make another core change [23:02:41] I guess if you wanted to be really clever you could write a custom RL module that generates the CSS, based on inspection of $IP [23:02:43] I'll just duplicate the images [23:02:49] or that [23:02:52] -_- [23:03:02] as you can tell, I'm not a fan of this :) [23:03:16] You act as though you're going to have handwrite the file copies. [23:03:28] it's inefficient and wasteful [23:03:35] and it leads to an inconsistent interface [23:03:51] I agree [23:04:08] But any real solution to this problem is probably gonna involve a core change [23:04:13] indeed [23:04:24] I'm not a front-end person. you *really* don't want me doing it :) [23:04:45] Liquor in front; poker in the rear. [23:05:00] based on that, I'd be a front-end person [23:05:26] ok. duplication it is! [23:09:27] Ryan_Lane: The proper solution in that case is not to share a common file but a common css class. The background image of an interface component (or whatever) is just part of that an element is made to look like. Using a single image of it out of context can lead to problems. [23:09:33] that way the responsibility is separated [23:09:47] that's fine too [23:09:53] as long as I have some way of doing it [23:09:59] is there some way of doing it currently? [23:10:02] that way core is concerned with making it look right (wither with 1 image, 2 images, or no images at all with CSS3) [23:10:09] Ryan_Lane: Which image? [23:10:26] tick-32.png, spinner.gif [23:10:41] Ryan_Lane: spinner has a css class, see jquery.spinner.js [23:10:59] Ryan_Lane: It also has a class in a non-javascript stylesheet [23:11:42] tick-32.png is not used anywhere in css, not even in core [23:11:47] it is from the installer [23:11:56] so that one you'll have to copy [23:12:26] Ryan_Lane: .mw-small-spinner and .mw-ajax-loader [23:12:33] (css classes for the spinner) [23:12:55] it would be awesome if stuff like this was documented :) [23:12:55] pick whichever you prefer, tack it onto an element with no other content and it'll work :) [23:13:07] skins/common/shared.css [23:13:31] well, doing common interface things being documented would be nice [23:13:38] being a noob this is pretty difficult [23:13:49] every single extension seems to do this differently [23:14:20] it is a tough one to document, if you see it in core, you look for it and re-use the class. Seems like the obvious thing to do. [23:14:30] LIsting every single class on a wiki page wouldn't help [23:14:54] you're assuming I know to do that [23:15:09] I see it going wrong, I'm not saying it is obvious (I did..) [23:15:22] but not sure how it can be documented in a way that makes sense [23:17:32] "Step 1: file a bug. Step 2: wait for someone else to deal with it." [23:18:53] Ryan_Lane: http://twitter.github.io/bootstrap/components.html [23:19:01] Ryan_Lane: Something like that would be nice, right? [23:19:05] yes [23:19:09] very much so [23:19:16] bootstrap as a whole is easy to use [23:19:46] The reason it doesn't exist is because these css classes were written in 2006-ish when it was better to put it in a css file then to inline it. Not to be re-used in an extension as a "standard". [23:20:02] * Ryan_Lane nods [23:20:18] Once we actually have a style (right now its just random css on top of native browser controls), it'll be documented like that. [23:20:25] Should be part of the Agora project [23:20:34] Agora Kraken. [23:20:36] mw-ui-spinner I imagine [23:21:00] and it will absolutely need to have a page like that of bootstrap's [23:23:17] ugh. this background image is too large [23:23:32] and it can't be resized with css2, it seems [23:23:44] Ryan_Lane: mw-small-spinner perhaps? (I mentioned 2 classes) [23:23:55] well, I want to display an error image if an action fails [23:23:59] the spinner is the right size [23:24:25] critical-32 is not [23:24:50] https://github.com/wikimedia/mediawiki-core/blob/master/skins/common/shared.css#L821-L838 [23:25:05] yeah. I'm using that ;) [23:25:10] Ryan_Lane: The spinner and status badge are used in the same position? [23:25:31] should I use a status badge rather than error and success images? [23:25:57] I guess that's doable easy enough [23:26:16] I was under the assumption that the error image is part of a status badge. [23:26:36] a visual of what you're embarking on would help :) [23:26:37] heh [23:27:15] on "Manage instances" on wikitech [23:27:20] I click "reboot" on an instance [23:27:25] a spinner appears next to it [23:27:34] if the action fails, I want the user to know [23:27:35] Krinkle: if we had an equivilant to that github page... oh man... I would be a happy matt [23:27:57] if it succeeds, it'll change the instance status to rebooting, but some visual for success that's more apparent would be nice too [23:28:19] so, I was going to have a red x if it fails (with a tool tip as to why) and a green check if it succeeded [23:28:23] where the spinner was [23:28:26] to make it obvious [23:29:13] I could instead have an "error" badge and a "success" badge, I guess [23:29:26] checking [23:29:50] though it seems badges are only for errors? [23:31:25] Ryan_Lane: Define "badge" [23:31:31] http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jquery.badge [23:32:06] I'm trying to use the default modules as much as possible. alas, almost all of them just link to source code [23:32:25] Ryan_Lane: Hm.. that's more meant to be used as a badge on another element (e.g. like on iOS when you get a text message there is a counter badge on the Messages app with "1" in it) [23:32:33] ah. I see [23:32:55] and the Echo notifications in MediaWiki on your user name is a standalone usage of it [23:32:59] probably not what you want [23:33:00] * Ryan_Lane nods [23:33:02] indeed [23:33:09] The name is misleading though [23:34:00] Ryan_Lane: I'd insert a message underneath the associated heading and re-use that throughout [23:34:15] Ryan_Lane: I agree, just changing the status is too subtle, a confirmation is nice [23:34:33] a message under the header? for the project? [23:34:44] Ryan_Lane: So when you click 'reboot' underneath the ==project== heading is inserted a ^^ yes [23:34:59] and that message says "(spinner) loading" at first [23:35:00] Animated GIF unicorn. [23:35:09] and the becomes success or error accordingly [23:35:23] that's going to get ugly quick if people do multiple actions [23:35:36] that's why I wanted to do it inline with the action [23:35:55] You could use the successbox and errrorbox classes as uses in core for Special:Preferences although I find those quite ugly and am happy those are only used for preferences and not anywhere else (in login too, actually) [23:36:03] Ryan_Lane: Right. [23:36:15] Ryan_Lane: You could use mw.notify [23:36:20] Ryan_Lane: Like the ajax watch star [23:36:25] Try it [23:36:33] oh. that would be perfect. I thought that was a popup [23:36:36] (in case you forgot what it looks like nowadays) [23:37:01] nope. I know what it looks like :) [23:37:26] yeah, that's perfect [23:37:35] thanks [23:37:37] alrighty [23:38:32] in which way is that anchored on the element? [23:38:36] is it called from the element? [23:39:12] Ryan_Lane: What element? [23:39:22] it isn't a jquery plugin [23:39:31] https://www.mediawiki.org/wiki/RL/DM#mediawiki.notify [23:39:32] well, I see when I click watch/unwatch that it appears by the element [23:39:41] it's based on where I click, eh? [23:39:43] oh, no. it appears on the top right of the page [23:39:48] you've been fooled :) [23:39:54] hahaha [23:39:55] ok [23:39:57] I have indeed [23:40:02] it's like Growl or Notification Center on OSX [23:40:06] right [23:40:07] (loosely based on that actually) [23:40:11] that's still totally ok, though [23:40:34] I hope at some point we can make it use HTML5 Notificiations API [23:40:37] as long as I give context on what the notification is for [23:40:48] (at least add support for title, link, button and icon), but for now it is plain text [23:40:56] * Ryan_Lane nods [23:41:13] cool. hopefully I'll have way less noobish questions for you in the future :) [23:41:15] yeah, please do give the proper context, but keep it short too. The watch message is a bit on the long side (or used to be anyway) [23:41:34] Ryan_Lane: this has been interesting, I had forgotten about mw.notify [23:41:39] heh [23:42:10] Ryan_Lane: Note there is a 'title' property in mw.notify you can use [23:42:18] yep [23:42:37] this has made my life way easier :) [23:42:47] now I just need the spinner and to put up notifications [23:44:06] Ryan_Lane: See also mediawiki.page.action.patrol.ajax.js [23:44:11] (in core) [23:44:22] cool. thanks. that should be a good example :) [23:44:23] it also places a spinner and ends with mw.notify [23:44:44] New review: CSteipp; "Tested and works well. I agree with hoo's comment on PS2, it seems like there should be a better way..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60282 [23:44:44] though this one *replaces* the [patrol] link with a [ (...) ] spinner [23:44:51] I could do that too [23:44:58] if you have multiple action links that might not be what you want, but you can use the code regardlress [23:45:02] (prepend/append instead of replace) [23:45:32] the main reason I did that is to avoid clicking the link again while it is still spinning [23:45:34] well, that's not a bad idea. I don't want people sending multiple calls while they are waiting [23:45:39] :D [23:45:40] exactly [23:45:52] it takes it off the list basically [23:45:56] yep [23:45:57] and puts it back if it failed [23:46:01] that's important too :) [23:46:06] it also means I don't need to add a span [23:46:11] don't leave a gap after removing the spinner if it failed [23:50:08] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [23:54:28] \o/ that's perfect and really easy