[00:30:31] New review: Tim Starling; "The diff doesn't seem to match the commit message. Why do you think it has no impact on the handling..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54121 [00:31:43] New review: MarkAHershberger; "Thanks for the comments." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60230 [00:59:48] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [01:00:53] New patchset: MarkAHershberger; "update release notes" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60230 [01:02:45] New review: MarkAHershberger; "(3 comments)" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60230 [01:05:18] I'm filing a bug about when a particular hook fires and Bugzilla's automatic dupe search produced two bugs about things that should die in a fire, heh. [01:10:38] ori-l: I'm betting I filed one of those ;) [01:11:18] oh yeah, $wgAuth->getCanonicalName() [01:11:39] yep. I need to throw it into the depths of hell. I hate that function [01:12:57] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [01:13:20] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59834 [01:13:25] New patchset: Tim Starling; "Handle search engine returning status objects to the API" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59834 [01:14:00] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [01:17:06] New review: Ori.livneh; "In the commit message of PS1, I claimed that the change in the order of hooks firing amounted to a b..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [01:21:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59834 [01:25:30] New review: Aaron Schulz; "This could just use memcached. Actually, that would also avoid devious users from constantly spammin..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [01:45:59] New patchset: MarkAHershberger; "update version number" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60234 [02:10:51] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/60233 [02:19:26] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:21:00] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:22:33] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:25:53] * Aaron|home tries not to be gadfly ;) [02:26:37] Aaron|home: hrm? [02:26:54] *be a [02:27:04] * Aaron|home also tries to type [02:27:16] was that re: 60233? [02:27:44] It was nice of you to take a look, actually. If you have other feedback, please share it. [02:30:14] Aaron|home: did you mean to leave a comment or a review? All I see is the -1 for PS5 [02:30:33] the comment was on PS4 [02:30:44] it was a race condition while you updated the summary I thnk [02:31:07] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:31:19] huh, why was that still a draft comment [02:32:23] oh, that's subtle [02:32:28] good catch [02:32:53] I guess if you leave a comment on ps4 and press "u" to go up and then press the main review button (which is now for ps5) you get this behavior [02:33:16] * Aaron|home wants for Isarra to moan about gerrit [02:37:15] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:38:42] * Aaron|home eyes that "!" [02:39:23] Oh, what the hell. I should take a break. That is really sloppy. [02:41:21] Gerrit sucks etc yadda 'sup? [02:41:46] New patchset: Ori.livneh; "(Bug 47482) Update redis in bulk onTransactionIdle" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [02:42:24] You can tell I don't really like this code [02:42:37] but I'm waiting for another round of usability testing to complete before working it over thoroughly. [02:42:38] Just remember - one day the earth will hatch and a baby space whale will emerge from the shell. [02:43:29] I should be careful not to let my waning enthusiasm translate into carelessness though :/ [02:43:29] Sometimes it's better to do even temporary things properly just so you stay in the habit or whatever. [02:43:39] Not that I have any idea what's going on. [02:43:51] Isn't it still the weekend? Are you working? [02:45:03] Sorry. [02:45:28] New review: Mattflaschen; "Patch set 5 is okay, but was not really necessary (you can loop over the values of an associative ar..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [03:18:40] "UX" is the new "usability." [03:19:01] It me longer to realize that than it probably should have. [03:23:32] took me * [03:34:09] user experience is said to be more general than usability [03:34:38] although I believe "usability" was defined in extremely broad terms in the first place, probably broad enough to encompass most things [03:40:02] We've shifted away from the "usability initiative" toward "user experience" enhancements. [03:40:19] It seems to mostly be silly marketing. [03:42:44] Susan: what term would you prefer? [03:43:41] Is a term necessary? [03:44:00] I mean, you could just improve the software without focusing on packaging/selling those changes. [03:45:05] "Workflow" also seems less awful to me, if that's what "user experience" is being used as a synonym for. [03:46:04] * Aaron|home reads http://thepolywellblog.blogspot.com/2013/04/an-ode-to-fusioneer.html [03:46:16] Well, one of the things we are trying to do is to collect feedback from people who are not already acquainted with MediaWiki about what they find confusing. [03:46:42] It's not necessary to have a term for that, but it's useful to have some shorthand for referring to that process. [03:47:20] And what demerits the common coinage has, it does have the merit of being common, and thus intelligible to people outside of our community. [03:48:06] "UX" is intelligible? [03:48:58] The collecting feedback/data-driven model is basically the same as the Usability Initiative. [03:50:02] * Susan shrugs. [03:50:17] Sorry, I'm confused. What's your point, exactly? [03:50:49] That there's a lot of meaningless jargon being passed around in order to try to justify common sense enhancements to the software. [03:51:36] But they're not "common sense enhancements"; occasionally they're the subject of bitter dispute. [03:51:54] Sort of. [03:52:11] I think the account creation form was mostly a backdoor. [03:52:30] To? [03:52:30] Which is where the jargon becomes more grating and harmful. [03:52:51] Well, rather than convincing local communities to reduce the amount of text in the interface, those messages were simply discarded. [03:53:02] The default interface isn't very cluttered. [03:53:33] But in the name of usability (err... user experience), that problem can disappear! [03:53:58] The good gets mixed in with the bad. [03:54:58] I didn't realize the parallels to the Usability Initiative as clearly until recently. [03:55:53] I'm still not sure what point you're trying to make, sorry. [03:57:00] I forgive you. [03:59:41] Well, rather than convincing local communities to reduce the amount of text in the interface, those messages were simply discarded. [04:01:13] That's not true, actually: they haven't been "simply discarded": the feature is deployed as off-by-default specifically to collect feedback from local communities. [04:02:23] https://www.mediawiki.org/wiki/Special:UserLogin?uselang=qqx&useNew=1 [04:02:33] No more Loginstart. No more Loginend. [04:02:47] No more Loginprompt. [04:03:27] https://en.wikipedia.org/wiki/MediaWiki:Loginend [04:03:33] New patchset: Nischayn22; "Watching and Unwatching made 'Change Subject' disappear." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/51834 [04:04:38] https://www.mediawiki.org/wiki/Special:UserLogin?type=signup&useNew=1 [04:04:44] I'm not sure how to trigger the new form for signups. [04:04:55] But I imagine we'd see the same messages disappear. [04:06:56] You're omitting some context: this is not the interface; you're linking to a parameter-gated version that is deployed explicitly to facilitate a period of feedback from local communities. [04:08:01] Heh. [04:08:17] I don't think E3 is focused on feedback from local communities. [04:08:21] It's focused on Wikipedia. [04:08:31] Just like the Usability Initiative was focused on Wikipedia. [04:09:00] And the local community has said it wants that text there. [04:09:05] So the response has been to remove the messages. [04:09:22] That seems pretty backdoor to me. [04:11:29] I don't agree, and this is so fantastically remote from anything to do with the term 'UX' that it's difficult to believe that you're interested in being constructive or fair, so I'm giving up. [04:12:23] Fantastically remote from the term "UX"? Heh. [04:12:35] Your team has labeled this whole project "Account creation user experience." [04:12:43] If this is unrelated, we can point to... :-) [05:56:21] mwalker: Reporting from home! [05:57:35] marktraceur: yay [05:58:23] Should be less of a hassle this time. [06:00:06] *fingers crossed* [06:00:36] Well, having secondary ID helps. [06:08:58] marktraceur: it's all lies! I deny that you are in fact marktraceur [06:09:25] mwalker: My mistake was leaving my screen session in my wallet [06:09:48] ya; gotta watch those pty's [06:25:33] https://meta.wikimedia.org/wiki/Wikimedia_exit_interview/Sue_Gardner [06:37:08] New patchset: Amire80; "Check that there are editing controls when removing tipsy" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/60235 [06:58:17] New patchset: Aaron Schulz; "Moved CryptRand.php to MWCryptRand.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60236 [07:04:24] New patchset: Aaron Schulz; "Renamed QoS_Atomic => QOS_ATOMIC in some places." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60237 [07:05:12] TimStarling: so you guys are really into coal power, right? [07:05:16] * Aaron|home trolls [07:05:59] yes, we love coal [07:06:33] and we love nuclear, evidenced by the massive uranium mining [07:06:47] just as long as it doesn't go into any australian reactor it is fine [07:07:52] there is a lot of coal mining around where I live, and coal-fired power stations fed directly from the mines [07:08:24] got to go for dinner now [07:08:31] heh [07:14:53] Yippie, build fixed! [07:14:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #11: FIXED in 7 min 1 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/11/ [07:15:35] Yippie, build fixed! [07:15:35] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #24: FIXED in 8 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/24/ [07:19:13] Yippie, build fixed! [07:19:13] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #11: FIXED in 4 min 20 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/11/ [07:19:36] New patchset: Amire80; "Cleanup CSS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60238 [07:20:10] New review: Daniel Kinzler; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54121 [07:24:39] Change abandoned: Daniel Kinzler; "@tim: Ok, I hadn't though about extensions using this info in their hook functions. Since we can't k..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54121 [07:32:41] New review: Daniel Kinzler; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/50042 [07:33:23] ori-l: ping [07:33:30] legoktm: hey [07:34:24] hey [07:34:30] so im nearly done fixing the bot [07:34:31] but [07:34:33] https://gerrit.wikimedia.org/r/gitweb?p=operations/debs/adminbot.git;a=blob;f=adminlogbot.py;h=3bea8a53f2157f8441a0ef5f4e905ebbfede93d8;hb=HEAD [07:34:39] what is the point of the on_quit function? [07:34:54] Yippie, build fixed! [07:34:54] from what i see is that it just makes sure the nick is correct? [07:34:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #10: FIXED in 8 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/10/ [07:35:51] legoktm: if someone quits, and the nickname of that someone is the nickname the bot is configured to use, it changes to that nick [07:36:06] ohhhh [07:36:07] basically attempts to reacquire its own nick if it's ghosted [07:36:14] i got it [07:36:21] its not the bot quitting, its when someone else quits [07:36:32] i think so, yeah [07:46:41] ori-l: I think it should work now, any ideas on how to test it? i dont want to set up a full local environment for it... [07:47:37] what does "full local environment" entail? just adminlog and irclib, no? [07:48:44] if you submit the patch to gerrit, I'll try testing it tomorrow [07:48:49] off to sleep now [07:48:53] Change merged: Netbrain; [mediawiki/extensions/SideBarMenu] (master) - https://gerrit.wikimedia.org/r/46216 [07:49:04] ok, ill just do that :) [07:55:22] lo [07:56:00] New patchset: Daniel Kinzler; "Fix debug log line for $userLimit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60239 [08:06:02] New patchset: Siebrand; "Update spelling for Odia" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60242 [08:06:24] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60243 [08:08:03] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/60245 [08:16:22] New patchset: Amire80; "WIP: Add the sidebar ULS cog icon" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [08:16:33] New review: Daniel Kinzler; "(1 comment)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/60126 [08:18:55] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60239 [08:22:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60126 [08:25:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60127 [08:40:40] New patchset: Amire80; "Add the sidebar ULS cog icon and $wgULSPosition variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [08:52:15] New patchset: Hashar; "mw/ext/ULS tests no more depends on jslint passing" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60246 [08:53:02] New review: Hashar; "Reported by Siebrand. No other occurrences." [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/60246 [08:53:02] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60246 [08:53:55] hey legoktm [08:54:08] hey ori-l. [08:54:17] finished sleeping already? :P [08:54:19] heyo YuviPanda [08:54:24] hello :) [08:54:25] i put it on gerrit btw [08:54:32] legoktm: he never sleeps [08:54:35] legoktm: something like that, yeah. do you mind if i update the patch? [08:54:42] [02:48:49 AM] off to sleep now [08:54:56] it's a lie [08:55:00] go for it :D [08:55:30] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60238 [08:55:36] cool [08:55:40] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60223 [08:56:07] * YuviPanda wanders back to Androi [08:56:07] d [08:56:23] you did get an MZMcBride approval, though, so I'm basically tampering with perfection [08:56:31] but i'll take my chances [08:58:03] oh is this the pep8 patch? [08:58:24] i'm looking at https://gerrit.wikimedia.org/r/#/c/59371/2 [08:58:41] ok [08:59:25] it shouldnt mess up the next patch though right? [08:59:27] New patchset: Pginer; "Add the sidebar ULS cog icon and $wgULSPosition variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [09:00:24] oh, there's another one coming? [09:00:42] the one thats based on it, https://gerrit.wikimedia.org/r/#/c/60240/ [09:01:41] oh, nice [09:01:51] the one you offered to test ;) [09:02:10] yep [09:02:56] New patchset: Amire80; "Add the sidebar ULS cog icon and $wgULSPosition variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59827 [09:07:31] New patchset: Krinkle; "mediawiki.util: Fix roundtripping of tooltip in portlet links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60247 [09:28:10] New patchset: IAlex; "Simply the logic to decide whether to show "variant" and "noconvertlink" on Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60248 [09:29:05] New patchset: IAlex; "Simply the logic to decide whether to show "variant" and "noconvertlink" on Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60248 [09:44:28] New patchset: J; "(bug 47483) update file metadata in importImages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60249 [10:20:18] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [10:38:05] New review: Daniel Kinzler; "looks like this needs a manual rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [10:43:34] New review: Krinkle; "So who broke jshint passing in this extension? And why aren't we fixing that instead?" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60246 [10:48:55] New review: Krinkle; "It seems this change is trying to fix a theoretical problem." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/59053 [11:11:05] New patchset: Krinkle; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [11:11:22] New patchset: Krinkle; "Add Special:[All]MyFiles as alias for Special:[All]MyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [11:12:31] New patchset: Krinkle; "ResourceLoader: Serve stylesheets with "Access-Control-Allow-Origin: *"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [11:19:16] New patchset: Krinkle; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [11:20:20] New patchset: Krinkle; "NewPagesFeed: Fix layout bug with "Sort by" in Chrome" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/60189 [11:22:08] New review: Krinkle; "Moving it up seems like the proper way to fix it." [mediawiki/extensions/PageTriage] (master) C: 1; - https://gerrit.wikimedia.org/r/60189 [11:23:05] New review: Krinkle; "Removed now-obsolete FF2Fixes.css in I2fdd0da8c17553." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57693 [11:23:10] New review: Krinkle; "Removed now-obsolete FF2Fixes.css in I2fdd0da8c17553." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58465 [11:24:03] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [11:25:49] New review: Krinkle; "To the approver: After merging in master, cherry-pick and merge in REL1_21 (see bug report)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [11:33:18] New patchset: Matmarex; "Monobook: remove OperaNFixes.css files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [11:34:58] New review: Vedmaka Wakalaka; "Hi, Yaron!" [mediawiki/extensions/PageSchemas] (master) - https://gerrit.wikimedia.org/r/53866 [11:36:04] New review: Vedmaka Wakalaka; "Hi, Yaron!" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/57170 [11:36:49] New review: PleaseStand; "Why is the release note added to RELEASE-NOTES-1.22 instead of to RELEASE-NOTES-1.21 if the change i..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [12:07:53] New patchset: Krinkle; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [12:08:57] New patchset: Jeroen De Dauw; "Work on timeline code [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/53608 [12:18:21] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [12:21:02] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/53608 [12:39:36] New patchset: Krinkle; "Monobook: remove OperaNFixes.css files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [12:42:30] New patchset: Matmarex; "Remove the $wgHandheldStyle config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [12:45:05] New review: Matmarex; "Needs release notes, I'll add them if we decide we want to get this merged." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60259 [12:47:13] i love removing code. [12:55:06] <^demon> Especially junk code that should've been removed years ago ;-) [13:06:20] i should get some stats on how many lines i've added and removed. [13:06:31] i wonder if there's a git one-liner for this [13:33:41] New patchset: Krinkle; "mediawiki.log: Add to jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [13:33:41] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [13:33:41] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [13:33:42] New patchset: Krinkle; "wikibits: Deprecate checkboxShiftClick globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [13:33:42] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [13:33:42] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [13:38:00] well [13:38:02] it seems that [13:38:25] overall, my merged commits removed 328 lines of MediaWiki code. [13:38:48] New patchset: Krinkle; "SpecialSearch: Don't show pagination controls on top of the page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49930 [13:38:49] this is a little flawed by cd415914, though. [13:39:33] New patchset: Krinkle; "SpecialSearch: Add duplicate pagination controls on top of the page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49930 [13:39:54] if anyone cares, the command was: git rev-list --author=matma.rex HEAD | xargs git show --format=format: --shortstat | perl -pe "s/(\d+) files changed, (\d+) insertions..., (\d+) deletions.../+$2-$3/" | ruby -e "p eval readlines.join('').gsub(/\s/, '')" [13:40:08] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [13:42:57] New patchset: Anomie; "(bug 25592) LogEventsList:showLogExtract should ignore WebRequest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47200 [13:43:19] New review: Anomie; "Trivial rebase, +2ed by Tim and Aaron already." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/47200 [13:47:03] New patchset: Amire80; "WIP: Split language settings view into two tabs" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60271 [13:48:53] New review: Parent5446; ":/ Just when I thought this patch was done and out the door." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [13:54:29] New patchset: Amire80; "Update from upstream and remove the concatenated file" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/60251 [13:56:34] New review: Anomie; "Code looks good. Should have an entry added to RELEASE-NOTES-1.22." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60198 [13:59:02] New review: Parent5446; "(4 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60229 [13:59:04] New patchset: Matmarex; "Separate adding body classes and other attributes in Skin/OutputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59604 [13:59:05] New patchset: Matmarex; "Clean up the class building logic in OutputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60272 [13:59:57] New review: Matmarex; "I've split the non-controversial part to I2a09282d." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59604 [14:00:10] New review: Matmarex; "Split out from I0d3c29ec." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60272 [14:01:07] New patchset: Parent5446; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [14:03:45] New review: Parent5446; "Why is CORS being allowed for all domains? It only needs to be allowed for whatever origin the JavaS..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60200 [14:07:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47200 [14:10:36] New review: Parent5446; "(5 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/50042 [14:10:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60232 [14:17:52] New review: Matmarex; "(7 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60265 [14:18:29] Change abandoned: Jeroen De Dauw; "NyanData all the way across the sky! Figure it out yourself guys" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/50042 [14:25:04] New patchset: Arrbee; "Rewritten and added the ULS IME test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [14:27:42] Change abandoned: Jeroen De Dauw; "Blocked by issues elsewhere in the API that I am not fixing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49781 [14:28:53] New review: Jeroen De Dauw; "Reedy: No, I need the actual prefix." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52177 [14:29:52] New review: Nischayn22; "I have no idea :) CSS stuff always seem to work randomly for me :p" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/60189 [14:31:23] New review: Matmarex; "Probably caused by whitespace changes in ef2f507d23eb227194d5690518a2c3255dfcdca3, should be easy to..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [14:37:53] New patchset: Daniel Kinzler; "Introducing test case for ApiQueryLangLinks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60278 [14:41:54] New patchset: Matmarex; "Cleaned up Hooks code, comments, and documentation." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [14:42:18] New review: Matmarex; "Fixed by checking out pre-ef2f507d version of includes/Hooks.php, then cherry-picking this and squas..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [14:42:50] parent5446: ^ :) [14:43:07] this could probably be also done by using the 'ours' strategy when rebasing [14:43:17] or 'theirs', i can never remember which one is which [14:43:25] but this way we're sure nothng was lost [14:43:50] MatmaRex: Mhm. I forget how to do that on CLI, though. [14:44:30] git ch ef2f507d~1 -- includes\Hooks.php [14:44:43] git co -m lol [14:44:54] that ugly cherry-pick command you can copy from gerrit [14:44:58] git rebase -i HEAD~3 [14:45:07] Lol I'll check it out. [14:45:18] type 'squash' in the appropriate place, :wq [14:45:31] <^demon> cherry pick is your friend when you're having to manually fix conflicts on a rebase. [14:45:40] also i apparently rebased this on a wrong place first, so i had to cherry-pick the result on master again. [14:45:42] <^demon> $ cherry pick kungfu [14:45:45] <^demon> $ git mergetool [14:45:51] <^demon> $ git cherry-pick --continue [14:46:05] ^demon: have you tried `git mergetool` on this? i did, and bailed out :P [14:46:16] <^demon> Not on this specific conflict, no. [14:46:23] whitespace changes are looovely. [14:46:25] <^demon> But you can set your mergetool your your diff/merge tool of choice. [14:46:30] Hmm, didn't know git mergetool even existed. Thanks. [14:46:32] * MatmaRex uses meld [14:46:44] <^demon> I use meld too, which generally works well. [14:46:54] maybe i just don't know how to use it [14:46:59] * parent5446 has been using vim to manually resolve conflicts. [14:47:03] <^demon> Ouch. [14:47:07] but often resolving manually is simple and faster [14:47:19] simpler* [14:47:42] Mhm, in the easy cases it is. [14:47:52] also, uh, 'ch' in my earlier copy-pastes is 'checkout', and 'co' is 'commit' - sorry, forgot i have aliases :P [14:53:10] New review: Daniel Kinzler; "+2 again after rebase" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/27255 [14:57:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [14:59:42] New review: Matmarex; "Uh, whoops, I just realized I reset the author of the latest patchset to myself accidentally :/ Sorry!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [14:59:53] D: [14:59:58] parent5446: ^ sorry about that :/ [15:00:07] MatmaRex: Lol, no problem. [15:00:26] well, it'll look silly when blaming [15:00:35] i didn't even read that code, and now i'm its author [15:00:53] :P [15:01:43] gj MatmaRex [15:01:58] we should add a commit note here or something, but we're not using commit notes for this kind of things, do we, ^demon? [15:02:11] only for the r1234 links [15:02:14] thanks Reedy [15:02:17] always glad to help [15:08:27] New patchset: Matthias Mullie; "WIP - UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [15:11:06] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [15:11:07] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [15:11:07] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [15:11:07] New patchset: Krinkle; "wikibits: Deprecate checkboxShiftClick globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [15:11:08] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:14:06] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:17:34] New patchset: Daniel Kinzler; "(bug 45535) Hook for changing language links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [15:17:35] New patchset: Parent5446; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [15:18:31] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [15:18:31] New patchset: Krinkle; "Monobook: remove OperaNFixes.css files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60255 [15:18:31] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [15:18:31] New patchset: Krinkle; "Monobook: Remove unused file FF2Fixes.css" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [15:18:32] New patchset: Krinkle; "wikibits: Deprecate useragent and tooltip/accesskey globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [15:18:32] New patchset: Krinkle; "wikibits: Deprecate checkboxShiftClick globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [15:18:32] New patchset: Krinkle; "mediawiki.log: Add to jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [15:18:33] New patchset: Krinkle; "Implement mw.log.warn and mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:21:42] New review: Yaron Koren; "Great! It was worth the wait. Merging this now." [mediawiki/extensions/PageSchemas] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53866 [15:21:43] Change merged: Yaron Koren; [mediawiki/extensions/PageSchemas] (master) - https://gerrit.wikimedia.org/r/53866 [15:22:18] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [15:22:56] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [15:23:00] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [15:23:08] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [15:23:11] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60264 [15:23:29] New review: Krinkle; "Rebased" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60255 [15:23:40] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60254 [15:28:06] New patchset: Alex Monk; "Allow MultiLock users to use a temporary bot right for RecentChange entries" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60282 [15:28:34] New review: Daniel Werner; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60126 [15:29:53] New patchset: Alex Monk; "Allow MultiLock users to use a temporary bot right for RecentChange entries" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60282 [15:31:54] New patchset: Ragesoss; "Modified text for Special:MyCourses when it is blank to be more general" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60283 [15:32:34] New review: Krinkle; "Regarding messages being in cache, I'm not sure that's true. Though MediaWiki has a localisation cac..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53189 [15:40:26] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:40:37] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:42:30] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [15:47:36] New review: Krinkle; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53189 [15:47:57] New review: Krinkle; "Needs release notes (new feature)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53189 [15:51:28] New review: TheDJ; "I'm not 100% sure if I'm correct, but Roan could maybe further clarify, since he last analyzed it (s..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [15:51:32] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60287 [15:54:51] I don't understand how we got stuck with Gerrit, such a poorly maintained product from UI perspectie [15:55:11] I get uncaught exceptions by the hour [15:55:37] And features breaking (regressions) every other week and not being fixed for months. [15:56:13] Pressing 'r' from an inline comment to submit review throws a null pointer exception and "Working.." stays visible. Reported weeks ago after a deployment. [15:56:16] No progress since... [15:56:51] > Complaining about Java products. [15:56:53] ;) [15:57:49] What were the reasons we didn't switch to Phabricator? [15:59:00] parent5446: Among other things, it has too much extraneous stuff we don't need, plus there was some problem with permissions [15:59:14] And it doesn't lend itself to anonymous browsing of changesets [15:59:50] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60287 [15:59:53] Ah, OK. [16:03:25] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60265 [16:05:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60283 [16:08:49] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/55126 [16:09:32] Change abandoned: Krinkle; "Abandoning in favour of I0d3d7d076b which seems to be in better shape. Please add comments there if ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55126 [16:10:47] New review: Krinkle; "Recommended closing this change per previously mentioned points. Also note that bug 47202 is also ad..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59053 [16:13:28] New review: Yaron Koren; "Sorry about the delay - I wasn't sure how connected the various patches were, so I didn't want to lo..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/57170 [16:32:05] New patchset: Reedy; "Add getTablePrefix method to DatabaseBase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52177 [16:34:22] New review: Reedy; "Per my first comment:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/52177 [16:34:57] welcome dr0ptp4kt / abaso as a mediawiki deployer. he just got added [16:35:14] thx, mutante [16:35:21] dr0ptp4kt: ^ resolving your access request ticket. if any issues poke me [16:35:31] mutante, will do [16:35:58] ^ hope to check access today. won't touch anything today…well, unless [16:36:01] you got the shells on fenari and bast1001 and you got the gerrit group membership, so looks good to me [16:36:26] (and wikidev group on systems) [16:38:42] Change abandoned: Hoo man; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59053 [16:43:36] James_F: ^demon|busy: having them both in -feed and -dev isn't crazy. I think that is very valid and harmless. [16:43:55] I'd say propose it. I don't see how anyone can possible disagree with tag. [16:43:57] that* [16:44:03] <^demon|busy> I gave up on -feed. And bots. [16:44:07] <^demon|busy> Do what you'd like. [16:44:07] New review: Parent5446; "Aha, indeed that is true. Removing -1." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [16:44:21] I don't use -feed either. [16:44:45] * James_F just deletes the channel from his list, then. [16:45:03] I'm fine with a (sanely relevantly filtered) feed in the regular channels. That's where I look most of the time for things (from people directly or via bots). [16:45:33] But If someone prefers a separate feed that's fine I guess, anyone who wants to pursue that, go ahead. I don't think anyone will oppose as those not using -feed wouldn't see it happen in -feed anyway. [16:45:54] * James_F is not fine with even a filtered general feed in a channel meant for real discussion. [16:46:22] It works for a hugely-filtered specific feed (e.g. the VisualEditor one) because there are so few changes relative to conversation. [16:46:28] But never mind. :-) [16:46:42] * ^demon|busy doesn't care anymore. [16:46:57] Let's just move all the discussion and all the bots to #wikipedia [16:47:04] It'll be way more fun [16:47:05] meh, i got shouted at for trying to kick the bots out of human channels [16:47:20] so i settled for kicking the out to #-dev [16:47:23] one reason for sharing a channel between bots and humans is that you can also just refer to bot messages by using ^ and stuff, instead of starting to copy/paste or point people to "that message in the other channel" [16:47:38] which apparently didn't work anyway [16:47:48] so now we have four different bots in threedifferent channels [16:47:49] yay [16:48:18] hey, mutante, you could fix that [16:48:20] :) said so but didn't want to block the whole change with a minority opinion [16:48:32] restart wikibugs for me, please? [16:48:38] i think the relevant change is merged already [16:48:41] but not deployed [16:48:43] or something [16:48:50] oh, that doesnt sound so bad [16:48:58] i thought you wanted to change it again :o [16:49:34] https://gerrit.wikimedia.org/r/#/c/57753/ and/or https://gerrit.wikimedia.org/r/#/c/57752/ [16:49:38] i'm not sure myself [16:49:46] New review: Siebrand; "(4 comments)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [16:49:51] btw, can i !log here? [16:50:23] !log restarting wikibugs on mchenry [16:50:26] but if it breaks, not my fault ~ [16:50:32] i'm not sure if that's deployed [16:50:40] New review: Krinkle; "@Ori: Exactly what kind of documentation did you have in mind? It is already documented the doc bloc..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56762 [16:50:40] unless you did that already [16:50:57] mutante: in -operations only. [16:52:12] AH, so that was the reason it wasn't moved. [16:52:32] I was wondering what went wrong. I remember mutante talking about doing those changes, but it never happened. [16:52:46] mutante: It restarted back to #mediawiki [16:53:37] New patchset: Parent5446; "Slight improvements to FormSpecialPage behavior." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59720 [16:53:58] Krinkle: yeah, so it wasn't already merged and just not deployed as expected.. i'll take a look [16:54:41] mutante: so you deployed the gerrit change and then restarted? Or just restarted? [16:55:37] Krinkle: i just restarted it, because i expected it to be already included in a change that moved the other bot .. [16:55:52] <^demon|busy> wikibugs isn't puppetized. [16:56:52] * jeremyb_ spies a qgil [16:57:12] jeremyb_, feel free :) [16:57:24] qgil: you has mail [16:57:36] ^demon|busy: It isn't? But I thought your change puppetised it? And even before then there was code in puppet with which channel it is in [16:57:42] ^demon|busy: Or is that code unused? [16:57:58] <^demon|busy> That code was unused, hence my change. [16:58:15] OK [16:58:17] <^demon|busy> Someone pretended to start puppetizing it, but didn't go all the way ;-) [16:58:49] jeremyb_, ok thanks. OPW does accept automated testing related projects, while GSoC not, this is why there is a point in knowing whether the person interested is a woman or not [16:59:02] qgil: oh, ewwww [16:59:10] qgil: i wonder why... [16:59:17] jeremyb_, ask Google [16:59:24] right... [16:59:47] jeremyb_, then again the program is called Summer of CODE, therefore it makes sense to restrict it to coding projects [17:00:12] qgil: well idk what "automated testing" means to you. to me it could mean programming [17:00:27] (or a number of other things) [17:00:39] jeremyb_, sure, but for GSoC is unclear and I'd rather not play with students' expectations [17:01:08] yeah, sure [17:01:09] jeremyb_, in OPW we control 100% the scope of the projects, in GSoC not [17:01:58] qgil: anyway, they can still do GSoC and just find something that's not automated testing [17:02:08] jeremyb_, exactly [17:03:56] qgil: actually, same user with the same IP is in #wikimedia right now [17:04:19] so don't have to worry about whether that user page is a different person [17:04:38] jeremyb_, ok, good to know [17:04:59] jeremyb_, I'll contact her through the user page, then [17:05:18] erm, my point was you could just contact on IRC [17:05:29] on user page then there is some slight chance it's a different person [17:18:56] ^demon|busy: Unfinished puppetisation, would https://gerrit.wikimedia.org/r/#/c/53973/3 make it work? [17:19:10] If so, we maybe mutante forgot that one? [17:20:18] <^demon|busy> Should. [17:20:27] <^demon|busy> I haven't tested, so ymmv. [17:26:35] New patchset: Krinkle; "Fix logging in user language" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [17:35:43] mutant, just logged into fenari, thx again [17:35:52] s/mutant/mutante/ ^ [17:39:46] dr0ptp4kt: cool:) [17:41:13] New patchset: Nemo bis; "(Bug 14281) Allow the bad image list to be redirected elsewhere." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53190 [17:42:01] New review: Aaron Schulz; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60249 [17:44:33] New patchset: Krinkle; "mwext-TranslationNotifications: Voting for phpunit and jshint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60294 [17:49:30] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60294 [17:53:09] New patchset: Krinkle; "Fix comma separated list logging with user language" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [18:07:34] New patchset: Kaldari; "Refactor MWTimestamp::getHumanTimestamp and add hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45651 [18:14:57] New review: Brion VIBBER; "Handheld stylesheet is pretty solidly obsoleted by MobileFrontend. Kill it!" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60259 [18:18:43] New patchset: Adamw; "Prevent some PHP warnings" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60298 [18:20:43] Change merged: Katie Horn; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60298 [18:22:34] New patchset: IAlex; "Fix HTMLForm's documentation example" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60299 [18:29:32] DanielK_WMDE: LinksDeletionUpdate::updateCategoryCounts seems unused [18:29:44] New patchset: Jeroen De Dauw; "DO NOT MERGE" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/60301 [18:34:11] I'm fixing this bug that calls for a change in the text of the SpecialPasswordReset page [18:34:26] Is the password reset-text really necessary? [18:34:30] seems redundant to me [18:35:01] https://www.mediawiki.org/wiki/Special:PasswordReset [18:35:09] https://www.mediawiki.org/wiki/Special:PasswordReset?uselang=qqx [18:35:18] passwordreset-text [18:35:26] and passwordreset-pretext [18:35:30] they're redundant [18:36:51] New review: Aaron Schulz; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59359 [18:38:51] New review: Aaron Schulz; "Can this be abandoned?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54655 [18:39:44] brion: https://gerrit.wikimedia.org/r/#/c/60236/ [18:42:28] New review: Pragunbhutani; "Should I add that entry and amend?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [18:52:49] New patchset: Pgehres; "Updates to migrateAccount." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [18:53:55] New patchset: Adamw; "move a civi class into wmf_civicrm" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60306 [18:55:16] Change abandoned: Lwelling; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54655 [18:56:15] New review: Aaron Schulz; "(2 comments)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [19:04:48] New patchset: Aaron Schulz; "deduplicate transcode jobs" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59597 [19:05:31] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59597 [19:07:52] New patchset: Kaldari; "Refactor MWTimestamp::getHumanTimestamp and add hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45651 [19:08:05] New patchset: Aaron Schulz; "Avoid use of __METHOD__ in closure." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60307 [19:09:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54652 [19:11:23] hi [19:11:38] hashar: Howdy, how goes? [19:11:47] tired [19:12:02] *nod* that can happen [19:12:03] but got some packages accepted at debian.org \O/ [19:12:30] Yay! [19:12:51] hashar: An ex-roommate (geofft) was pinging me about that recently, I guess it must have gone well [19:13:08] http://qa.debian.org/developer.php?login=hashar@free.fr [19:13:09] :D [19:13:13] thanks to faidon [19:13:21] he has been amazingly helpful :D [19:13:56] Niiice [19:16:13] New review: Anomie; "Yes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [19:17:16] New patchset: Adamw; "move a civi class into wmf_civicrm" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60306 [19:18:16] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59364 [19:18:39] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60307 [19:21:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45651 [19:25:33] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [19:28:56] hashar: yayyy re: packages! [19:29:14] AaronSchulz: huh. can you file a bug about updateCategoryCounts? I mean, category counts *should* be updated when links get deleted... [19:29:17] uhh [19:29:28] it says build failed on this new patch that I submitted for review [19:29:47] DanielK_WMDE: it does delete them, just not using that function [19:29:59] it seemed to work just fine till the previous patch set [19:30:11] and all I added was a couple of lines to the release notes [19:30:16] ori-l: and I get commit right on Debian python module repo (which is mostly a work area to prepare packages) [19:30:19] help please? [19:30:33] ori-l: did you get python-jsonschema packaged? I have not followed the story of that project [19:30:52] Yep! Ottomata and Faidon did it [19:31:35] hashar.brain.erase_task('look at Ori python-jsonschema packaging') [19:31:40] >>> True [19:34:20] New review: Pragunbhutani; "Uh oh, that doesn't look good. Why does it say build failed? Help please!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [19:35:14] hashar: Hi [19:35:26] pragunbhutani: link? [19:35:52] * Krinkle initiates two-way sync on continuous integration activities between hashar and Krenair [19:35:57] Krinkle* [19:36:11] looks like my irc client never autocompletes two my own name [19:36:19] to* [19:37:11] New review: Alex Monk; "(4 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [19:38:36] New patchset: Arrbee; "Rewritten and added the ULS IME test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [19:41:09] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/60198/ [19:42:41] New review: Arrbee; "As per the review from Siebrand, I have removed the additional white-spaces and corrected the text i..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [19:44:37] pragunbhutani: your pat6ch no longer applies cleanely ("unable to be automatically merged with the current state of the repository") [19:44:48] you have to rebase it against current master [19:45:34] get fetch --all; git rebase origin/master; git mergetool; git commit --amend; git review -R [19:46:14] ahm no sorry. not "git commit --amend", but "git rebase --continue". [19:46:49] pragunbhutani: --^ [19:47:09] DanielK_WMDE: ok, I'll give it a shot [19:49:52] New patchset: Pgehres; "Updates to migrateAccount." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [19:50:01] pragunbhutani: don't run all that as one line, look at the output of each [19:50:10] ...command [19:50:15] New review: Pgehres; "(4 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [19:51:32] DanielK_WMDE: after rebasing to master, should I merge my changes that are in a different branch to master? [19:52:58] pragunbhutani: no. you rebase your branch against current master. no merging. [19:53:17] pragunbhutani: gerrit will merge your branch into master once it has been approved. [19:53:50] DanielK_WMDE: so basically I have to checkout and run the above command then. Right ? [19:54:06] yes [19:54:10] the rebase basically means you pretend you made your changes against a newer version of master. that way, it can cleanely be merged, with no conflicts. [19:54:19] DanielK_WMDE: and gerrit will take care merging for me in the process. Got it ! [19:54:45] New review: Siebrand; "(3 comments)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60276 [19:55:24] hm, but while we are talking about git & gerrit... [19:55:44] can a change depend on two other, independent, changes? [19:56:15] could i base my branch on one of them, then merge (or cherry-pick?) another into the branch, then work on top of that? [19:56:31] would gerrit understand that? [19:56:50] hashar: do you know? [19:57:43] New patchset: Krinkle; "mediawiki.util: Fix roundtripping of tooltip in portlet links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60247 [19:58:51] DanielK_WMDE: there was a conflict that I just resolved [19:59:18] Change merged: Trevor Parscal; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60247 [19:59:22] DanielK_WMDE: should I do git commit -a? [20:00:25] DanielK_WMDE: or rather git commit --all --amend [20:02:48] pragunbhutani: nither. you are in the middle of a rebase, kind of a limbo state [20:02:54] you need to resolve that first [20:02:59] git rebase --continue [20:03:21] pragunbhutani: you need to add the file you resolved the conflict in first, though. [20:03:31] unless you used git mergetool. that does this for you. [20:03:57] DanielK_WMDE: I didn't use merge tool, but I've resolved the conflict manually and then added the file [20:04:08] ok, so rebase --continue [20:04:22] so now should I do a git commit -a before doing a git rebase --continue? [20:04:27] or is it not needed? [20:04:29] no, no commit [20:04:34] okay, gotcha [20:05:00] (just `git add` for each file) [20:05:08] (ah, you did it, nevermind me) [20:05:16] the rebase is re-generating the commits on your branch. there is no need to create a new one (in fact, that will get you into a confused state) [20:06:08] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [20:06:58] New patchset: Aude; "Update Wikibase with patch for link item widget" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60314 [20:07:30] DanielK_WMDE: jenkins-bot still says build failed [20:07:32] same message [20:11:21] New patchset: Pragunbhutani; "Introducing a new variable {{ROOTPAGENAME}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60198 [20:11:36] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #25: FAILURE in 9 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/25/ [20:12:42] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60227 [20:13:15] DanielK_WMDE: turns out it was because release-notes-1.2.2 were being modified by someone else at the same time as me [20:13:22] fixed now, build succesful [20:13:29] DanielK_WMDE: thanks a ton! :) [20:17:23] New review: Alex Monk; "(2 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [20:18:07] DanielK_WMDE: about the change depending on two independent changes ... that works just fine. However, you'd need 'Push Merge Commit' permission. [20:19:14] qchris: hm? i did changes depending on three others and they Just Worked [20:19:27] * MatmaRex once again jumps into discussion not knowing what is being talked about [20:19:35] New patchset: Pgehres; "Updates to migrateAccount." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [20:19:35] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #11: FAILURE in 8 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/11/ [20:20:03] New review: Pgehres; "(2 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60305 [20:20:11] Hi there, is this the right place for questions regarding the VisualEditor Extension for MediaWiki? [20:20:45] marcel_: mostly yes. there's also a #mediawiki-visualeditor channel for it [20:20:59] (and #mediawiki-parsoid for the underlying structure) [20:21:40] MatmaRex: :-) His question was whether that works with gerrit or not. Now he's got a second votes for "Yes, it works" [20:22:44] Ah ok, I'm having some problems getting the Editor running using the latest snapshot from mediawiki and the latest from VisualEditor. THe VIsualEditor shows up under Special Pages, Ive installed the Parsoid Server and linked to it in the LocalSettings. When I open the VisualEditor:Sandbox Page, the editor just won't show up :( [20:23:45] MatmaRex, qchris: ah, cool! So... how exactly do I do it? By cherry-picking the additional changes? [20:24:42] hm, no, merging, i guess... but those merge commits... they should not really go into master, should they? [20:24:43] DanielK_WMDE: Since you need merge permission anyways, a simple 'git merge' works. [20:24:54] marcel_: it has a couple of options for making it disabled, not sure what the defaults are, marktraceur might know [20:24:56] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [20:25:09] Oh boy [20:25:28] I used the default settings described on the VisualEditor installation page.. ITs enabled by default [20:25:33] and set as the default Editor [20:25:47] marcel_: If you've installed it with the default settings, you need to enable it in your user preferences and then go to a page, and click the VisualEditor button...or maybe just Edit? [20:26:19] Ok I will try to find that option in the usersettings.. It's pretty good hidden I guess since I already had a look and didnt find it [20:26:32] *nod* [20:26:34] New patchset: IAlex; "Fix the target URL of HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [20:26:42] DanielK_WMDE: Not sure what's the policy of the repo you need. But as it would be a plain merge, that merge would make it into master then. [20:26:44] marcel_: the very bottom of the Editing section, if it's the same as the Wikipedia's config [20:26:46] It would be in the editing section - if you don't see it, maybe just try going to a page [20:26:47] But basicly it should work with the latest Snapshot of MediaWiki? [20:26:53] It should, yeah [20:26:59] marcel_: It should be at Special:Preferences#mw-prefsection-editing if installed in that way. [20:27:17] Ok then I shall find it and hopefully dont get this PArsoid-Error again. Thanks for your time! See ya [20:27:20] qchris: ok, i'll play with it and see [20:27:43] New patchset: Aaron Schulz; "StatCounter doc tweaks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60318 [20:35:47] New review: Ottomata; "Our apt repo is public. Anyone can add it and install packages from it." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [20:48:30] New patchset: Aaron Schulz; "Bumped RING_SIZE to use 28 bits to improve weight accuracy a bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60326 [20:50:00] brion: https://gerrit.wikimedia.org/r/#/c/60326/1 microcommit [20:50:11] looking [20:50:57] New review: Brion VIBBER; "Doesn't look like it'll explode. :)" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60326 [20:50:58] Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60326 [20:53:24] New patchset: Vedmaka Wakalaka; "Extended Page Schemas integration" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [20:54:35] New patchset: Reedy; "Move SiteMatrix special page to its own file" [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60328 [20:55:10] New review: Vedmaka Wakalaka; "Hi, Yaron!" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/53864 [20:56:25] New patchset: Reedy; "Move SiteMatrix special page to its own file" [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60328 [21:02:23] New patchset: Reedy; "Blacklist alias languages on Special:SiteMatrix" [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60329 [21:09:09] New patchset: Cscott; "Update entities module to 0.2.2." [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/60334 [21:18:03] K4-713: As it turns out using a realtor would be super-expensive, but she may have some contacts. So thanks again :) [21:18:31] New review: Spage; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57823 [21:20:56] marktraceur: Aw dang. Well, hopefully the contacts work out, anyway. [21:21:01] Indeed. [21:28:53] Change merged: MarkTraceur; [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/60334 [21:29:58] New review: Mattflaschen; "Looks good. Works on toro." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/60233 [21:30:12] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60233 [21:31:42] New patchset: Reedy; "Bug 28768 - meta=globaluserinfo doesn't display homewiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58873 [21:38:33] New review: Reedy; "(2 comments)" [mediawiki/extensions/AccountAudit] (master) C: -1; - https://gerrit.wikimedia.org/r/53683 [21:39:53] New patchset: Reedy; "Initial commit of Extension:AccountAudit" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/53683 [21:40:15] New review: Reedy; "Rebased to fix .gitreview" [mediawiki/extensions/AccountAudit] (master) C: -1; - https://gerrit.wikimedia.org/r/53683 [21:42:12] New patchset: Alex Monk; "Replace weird usage of explode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53628 [21:43:11] New review: Alex Monk; "Originally approved by Parent5446, but it looks like there was a merge conflict after Jenkins starte..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/53628 [21:47:00] https://en.wikipedia.org/w/index.php?title=Wikipedia%3ASandbox&diff=551673095&oldid=551671584 [21:47:02] {{#property:p36}} is the capital. [21:50:37] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53628 [21:52:42] New patchset: Alex Monk; "Move maintenance scripts to maintenance directory" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/52745 [21:54:24] New review: Alex Monk; "Rebased" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/52745 [22:01:08] qgil: so, openstack folks are considering redoing using semantic mediawiki [22:01:25] New review: Alex Monk; "Needs rebase" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/51675 [22:02:01] it currently uses confluence (because that's what the contractors used for a proof of concept), but they want it to be open source [22:02:32] Ryan_Lane, :) maybe we have to wait until they have done it and then just use the argument that "if it's good for OpenStack it must be good for us" [22:02:41] heh [22:02:46] well, or we can work together with them [22:02:57] Ryan_Lane, more seriously: yes [22:02:58] they are doing basically the same thing we want [22:03:19] maybe we can pool some resources together for a project and benefit both communities [22:03:34] Ryan_Lane, on the other hand they are also working with Bitergia on http://activity.openstack.org/dash/ [22:03:44] yep [22:03:49] Ryan_Lane, the Bitergia guys were in SF last week and I had a meeting with them [22:04:14] Ryan_Lane, I'm all for this type of game, yes [22:05:05] Ryan_Lane, so one is metrics and the other is corss-search? [22:05:10] New patchset: Adamw; "move a civi class into wmf_civicrm" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60306 [22:05:10] cross [22:06:28] yeah, one shows data by project and user [22:06:50] and the other has graph data [22:08:50] New patchset: Mwalker; "ThankYou Date is Optional" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60340 [22:30:16] New patchset: Mattflaschen; "Add simple script to dump Redis database for debugging." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60343 [22:31:29] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [22:38:55] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [22:42:51] Any Echo'ers about? I'm wondering if that's "opt-in", "opt-out", or active for everyone? [22:42:58] The enwiki deployment, I mean. [22:43:39] (Also, the re-enabling of AFTv5, which articles is that for? A random subset? Or the "opt in" categroy?) [22:43:58] Jarry1250 somewhere in between. Opt in for email opt out of in browser display [22:46:18] New patchset: JGonera; "Call error on unknown dependencies in mw.loader.using()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60346 [22:46:25] lwelling: Ah, gdgd, the FAQ says existing users will start with "most email notifications turned off" [22:47:15] ...which intrigued me because I would think email notifications being opt-out would, er, raise a few eyebrows [22:47:38] [Not FAQ, section of the main page. My bad.] [22:48:37] What do you mean raise a few eyebrows? [22:49:21] New patchset: Adamw; "Don't enable E_STRICT by default." [wikimedia/fundraising/crm/drupal] (master) - https://gerrit.wikimedia.org/r/60348 [22:49:55] Krenair: Controversial. Exactly how so would be hard to say of course. [22:51:28] jarry1250 you might see some email change. If you had email notifications turned on for talk page messages, then you'll get talk page notifications from echo instead, but if you have an existing account you should not get new types of notificaitons by email without opting in [22:51:52] lwelling: Ah, that makes sense. [22:53:22] Change merged: Mwalker; [wikimedia/fundraising/crm/drupal] (master) - https://gerrit.wikimedia.org/r/60348 [22:54:24] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [22:54:48] New patchset: EBernhardson; "fixme" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60349 [22:54:53] New patchset: Spage; "Use addCaptchaAPI to supply info to signup form" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60350 [22:55:00] weee [22:55:49] New patchset: Adamw; "deprecate Advanced Search "contacts and contributions" view" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60351 [22:56:13] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60351 [22:56:13] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60306 [22:57:37] New patchset: Pgehres; "Initial commit of Extension:AccountAudit" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/53683 [22:58:03] New review: Pgehres; "(5 comments)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/53683 [22:58:07] lwelling: User preference toggle if people want to opt-out? [22:59:37] New patchset: Adamw; "deprecate Advanced Search "contacts and contributions" view" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60352 [23:02:03] Jarry1250 there is currently an opt out but it has generated bugs already so its lifespan will depend on its popularity [23:02:52] lwelling: I guess users could just try hiding all relevant HTML elements? [23:03:45] are there any spinners that come with mediawiki to use with async javascript actions? [23:03:59] I see wikilove includes its own [23:04:30] sure Jarry1250. The visual change is small so you could restyle it locally to hide it [23:04:42] https://www.mediawiki.org/wiki/User:Splarka/Throbber [23:05:11] Susan: I mean distributed with mediawiki [23:05:18] so that I don't need to include my own [23:05:26] hm [23:05:26] NFI. [23:05:31] I bet jquery.ui does [23:05:32] Ryan_Lane: $.spinner? [23:05:36] But that stroopwafel version is adorbz. [23:05:46] resources/jquery/jquery.spinner.js [23:06:14] Yippie, build fixed! [23:06:14] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #26: FIXED in 4 min 18 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/26/ [23:07:00] Ryan_Lane: Must use resources/jquery/images/spinner.gif I'm guessing [23:07:07] * Ryan_Lane nods [23:08:33] hi, how to web-view the version 1.21.0rc4 ? [23:08:35] I want to know, whether https://gerrit.wikimedia.org/r/#/c/54986/ which is merged into master is really part of > 1.21.0rc4 < [23:08:51] cannot find the tag on the github clone-copy [23:10:52] New patchset: Mwalker; "ThankYou Date is Optional" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60340 [23:11:18] Wikinaut: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=shortlog;h=refs/heads/REL1_21 looks like your best bet [23:12:10] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [23:12:41] csteipp: did you ever find that utf8 thing? is iconv ok? [23:13:10] mutante: wikibugs_ and wikibugs in here and both are silent? [23:13:27] yes, it's broken [23:13:39] Sigh. [23:13:42] i'm trying to find some work around but i guess i have to revert [23:13:53] <^demon|busy> We tried puppetizing it today. [23:13:57] <^demon|busy> I'm fine with reverting for now. [23:14:39] well, i can just set it to the old log path i think , and make all the log file names the same [23:14:42] Glad to hear you're fine with unbreaking the bot. ;-) [23:14:47] later we can then split them up [23:15:04] marktraceur: thanks for your hint. My patch is merged to master, but not (yet) part of REL1_21 [23:15:24] that it's running twice is another issue [23:15:41] Wikinaut: That's correct [23:15:49] ok, and good night [23:15:53] Change abandoned: Mwalker; "Ugh; stupidity" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60340 [23:17:06] New patchset: Mwalker; "ThankYou Date is Optional" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60354 [23:20:39] Yippie, build fixed! [23:20:39] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #12: FIXED in 7 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/12/ [23:21:06] ^demon|busy: I've seen maybe six or seven individual complaints about Special:ActiveUsers being disabled lately. [23:21:11] ^demon|busy: What's the plan to get it re-enabled? [23:22:17] New review: Adamw; "Good save" [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/60354 [23:22:17] Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/60354 [23:22:31] <^demon|busy> I pushed a change, didn't finish cleaning it up. [23:22:53] Ryan_Lane: can i has https://wikitech.wikimedia.org/wiki/Shell_Request/EBernhardson_(WMF) ? [23:23:15] already done by Coren [23:23:27] you guys are good [23:23:28] thanks [23:23:37] Change merged: jenkins-bot; [mediawiki/extensions/SiteMatrix] (master) - https://gerrit.wikimedia.org/r/60328 [23:27:11] hey. does wikibugs speak here now, for real? [23:27:52] guess not [23:28:33] But soon. [23:28:36] <^demon|busy> Susan: I'll clean the patch up tomorrow. [23:32:01] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #11: FAILURE in 4 min 20 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/11/ [23:32:02] ^demon|busy: Great, thanks. [23:35:23] AaronSchulz: iconv works ok when I know what the encoding is. When I don't, I'm having issues detecting it [23:36:40] csteipp: that sounds kind of unsolvable ;) [23:36:48] AaronSchulz: I added you https://gerrit.wikimedia.org/r/#/c/53683/ [23:36:51] :-D [23:36:52] * AaronSchulz wonders who accurate guessing could be [23:38:12] James_F: https://gerrit.wikimedia.org/r/#/c/60229/ [23:39:42] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60350 [23:40:08] New patchset: Mattflaschen; "Use addCaptchaAPI to supply info to signup form" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60350 [23:45:26] New patchset: Alex Monk; "Detect user rights conflicts from user_touched" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60229 [23:47:07] New review: Tim Starling; "In what way does not having this patch "break partial data exchange between two MW instances"?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34338 [23:55:13] New patchset: Mwalker; "HTMLForms: Support non submit buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55009 [23:56:49] New patchset: Mwalker; "HTMLForms: Support non submit buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55009 [23:58:00] Why doesn't the topic link to the channel logs? [23:58:37] http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/ [23:59:01] wmbug.com? [23:59:13] Whyyy. [23:59:45] Krinkle's domain, I guess.