[00:01:01] New review: Spage; "PS16 rebases onto master (all its dependencies are merged), adds RELASE-NOTES-1.22. In includes/temp..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [00:02:18] * Aaron|home looks for an egg timer [00:02:24] yeah I hit a problem [00:03:00] I didn't really want to open up the port on the default security group, and I couldn't work out how to change the security group of the instance I created already [00:03:54] TimStarling: I don't think you can change it [00:04:04] so I just made another instance in a new security group [00:04:05] Which is why the docs tell you to create the security group first [00:04:07] But no one ever remembers that [00:04:18] I haven't read the docs [00:04:41] [17:04] TimStarling I haven't read the docs [00:04:45] wow [00:05:00] the UI is pretty self-explanatory [00:05:03] * ori-l waits for "...I *am* the docs." [00:05:25] Tim always reads the docs ;) [00:06:49] done [00:16:10] New patchset: Adamw; "Refactor to facilitate historical allocations" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/59051 [00:16:47] New patchset: Adamw; "GlobalAllocation can show historical configurations" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/55450 [00:19:06] New patchset: MarkTraceur; "Use proper CL option for RT testing" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59978 [00:23:50] Change merged: MarkTraceur; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59978 [00:24:26] New patchset: Catrope; "Update VisualEditor to master again" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59979 [00:24:52] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59979 [00:24:55] New patchset: Catrope; "Update VisualEditor to master again" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59980 [00:25:06] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59980 [00:25:41] bawolff: Ready to leave in ~5 ? [00:25:53] marktraceur: Yep. [00:26:01] Coolio [00:26:21] marktraceur: A thought just occoured to me though - I might not have proper shoes for this (I have crocs). Does that matter? [00:26:54] bawolff: There are handy rental shoes and harnesses - $5 for both as a package, and I'll swipe you in with my monthly guest pass [00:27:10] Cool, thanks :) [00:29:07] New review: Spage; "Error in MessagesQqq.php, PS17 coming." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [00:29:42] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [01:03:18] New patchset: Adamw; "experimenting with namespaced class autoloading" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [01:06:32] New patchset: Adamw; "experimenting with namespaced class autoloading" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [01:07:28] TimStarling: maybe my php_redis.dll is just crap [01:08:54] Aaron|home: install linuc [01:09:01] *linux [01:09:53] * Aaron|home already has a box with linux...actually two counting the wmf laptop [01:09:59] maybe I should just take that one home [01:10:15] there is something to be said about developing on the same platform that the cluster runs on; however, it's also good to have a diverse development environment so that we can discover bugs that affect all our potential users [01:10:17] though I'd have to carry around and back [01:10:53] mwalker: Using table prefixes for no reason is a good one [01:11:17] Reedy: agreed -- so many queries broken due to query prefixing [01:21:00] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59958 [01:25:52] TimStarling: ;) [01:28:42] twice as fast! [01:30:06] I'm guessing he is not counting the busy loop in timeWaitUntil() in that calculation [01:30:47] btw we've used the idea of double precision numbers as large integers in several other places [01:33:16] floating point numbers in PHP are double in C [01:33:34] New review: Parent5446; "(4 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57518 [01:33:39] New patchset: Adamw; "WIP: objects to manage allocations data" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/59366 [01:33:43] and IIRC the C spec guarantees that double will be IEEE 754 [01:34:43] http://en.wikipedia.org/wiki/Double_precision_floating-point_format [01:35:23] so it's not really machine-dependent [01:37:08] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [01:39:28] check out this code I wrote for OggHandler: http://paste.tstarling.com/p/wHCPyv.html [01:41:37] it's basically x >> y, where x is 64 bits and y is less than 32 [01:41:52] implemented using floating point division, which happens to be exact when the divisor is a power of 2 [01:48:47] New review: Reedy; "(17 comments)" [mediawiki/extensions/GWToolset] (master) C: -1; - https://gerrit.wikimedia.org/r/59405 [01:55:47] New patchset: Tim Starling; "Factored JobQueueRedis::redisEval() into RedisConnRef::luaEval()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59800 [01:55:53] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59800 [02:00:10] New review: Reedy; "(7 comments)" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [02:05:14] New patchset: Tim Starling; "[JobQueue] Deprecated confusing Job::getId() function." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54901 [02:05:47] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54901 [02:20:52] New patchset: Aaron Schulz; "[LockManager] Added a RedisLockManager class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49799 [02:23:46] New patchset: Aaron Schulz; "[LockManager] Added a RedisLockManager class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49799 [02:33:35] TimStarling: didn't test that ;) [02:33:56] * Aaron|home wonders whats wrong with the driver [02:34:32] yeah, you wouldn't think much could go wrong with a text protocol [02:34:49] so you want me to wait until monday before I merge it? [02:36:34] > var_dump( $conn->info( 'MEMORY' ) ); [02:36:35] bool(false) [02:37:09] ok, var_dump( $conn->info() ); gives stuf [02:37:11] *stuff [02:40:49] how about $conn->set('foo', 'bar') [02:41:02] I just tried it and it worked for me, dbSize() now gives 1 [02:41:37] TimStarling: 2013-04-19 02:41:17 AARON-PC-GAME wikidb-mw_: Lua script error: ERR unknown command 'EVALSHA' [02:41:47] is it 2.6 redis? [02:42:07] 2.2.12 [02:42:08] 2.2 [02:42:09] lol [02:42:34] I'll fix it [02:42:37] you know, my windows one is 2.4 [02:43:02] it's just the one from Ubuntu 12.04 [02:43:19] yeah, that's clearly not new and sexy enough [02:48:44] try now [02:49:02] I just did a source install [02:50:28] runJobs does stuff now, that's a good sign [02:54:10] New review: MZMcBride; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/59773 [02:55:24] hrm, some 'Unknown Redis command called from Lua script' [03:02:22] hmm, probably delete => del [03:02:30] also that first loop has some wonk in the logic [03:05:00] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [03:05:11] A mantissa sounds like an angry sea creature. [03:07:09] wiktionary notes that it is an anagram of satanism [03:07:36] ++TimStarling [03:09:48] Wikipedia calls it an alternate form of "significant," but the diagram uses a "mantissa" label. [03:09:54] Significand, rather. [03:09:58] Thank you, auto-correct. [03:10:14] 'proscribed' usage, Susan [03:10:29] Is Adam Wight's middle name really "Roses"? [03:15:27] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [03:16:54] New patchset: Bsitu; "Remove static object cache to avoid cross wiki related issue" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59984 [03:19:09] New patchset: Aaron Schulz; "[LockManager] Added a RedisLockManager class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49799 [03:19:17] TimStarling: that's better [03:20:53] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49799 [03:24:23] New patchset: Aaron Schulz; "Changed on-request job running to shell out instead of doing a loop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [03:25:24] New patchset: Tim Starling; "[JobQueue] Added JobQueueFederated class for partitioned queues." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51823 [03:27:08] New review: Tim Starling; "PS17: fix typo in comment." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51823 [03:27:16] New patchset: Tim Starling; "[JobQueue] Added JobQueueFederated class for partitioned queues." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51823 [03:30:02] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51823 [03:30:15] New patchset: Tim Starling; "[FileBackend] Disallow files ending in / and clarified some docs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57685 [03:30:23] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57685 [03:32:58] New patchset: Tim Starling; "[FileBackend] Made stat cache factor in last-modified time." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59084 [03:33:06] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59084 [03:36:53] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [03:38:20] New patchset: Aaron Schulz; "Changed on-request job running to shell out instead of doing a loop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [03:38:56] New review: Tim Starling; "What if the wiki is running in safe mode? Or if $wgPhpCli is not correctly configured? $wgPhpCli is ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59797 [03:40:03] there we go, negative CR on all your remaining changes [03:40:18] I think that means I have officially caught up with Aaron [03:41:36] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [03:42:17] New review: MZMcBride; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57685 [03:42:31] Code review yay. [03:44:27] http://www.php.net/manual/en/ini.sect.safe-mode.php#ini.safe-mode [03:44:32] wow, that really got the axe [03:44:43] in 5.4 [03:45:52] New patchset: Nischayn22; "Hide the 'Next' button until a license is chosen." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/52628 [03:46:09] TimStarling: no snarks about HashRing? I'm surprised. [03:50:59] New patchset: Bsitu; "Remove static object cache to avoid cross wiki related issue" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59984 [04:00:22] Aaron|home: the HashRing class itself looked fine [04:01:46] I was expecting something a bit different: I saw a kind of hash ring structure used for load balancing in a C app once, I forget which one [04:01:54] maybe varnish [04:02:48] but it was quite a different concept, it used points instead of ranges [04:03:41] I considered recommending that you cache the HashRing objects in the JobQueueFederated object [04:04:07] but it's hard to get really passionate about a millisecond or two of performance on a function which shouldn't be called very often [04:04:32] in a class that probably won't be used in the near future [04:06:32] aside from the initial wikidata job copy (which used 50% of the ram), we tend to hover around 1-2% usage atm [04:07:13] so we should be able to sit on that for a long time (unless Echo or something piles on the spam) [04:07:54] * Aaron|home is glad that we have good headroom since random bugs could easily back up the queue [04:08:22] TimStarling: at least it doesn't sort the list of servers for each item ;) [04:08:38] or, item placement, I should say [04:09:51] hmm, is_executable( $wgPhpCli ) only works if it's not something like 'php', I wonder what the best way to check that is [04:10:08] one could try to run it and see if 127 came back [04:10:11] * Aaron|home shrugs [04:11:52] if it was easy, I would have done it in 2006 [04:25:53] > $r=1; wfShellExec( 'meow &', $r ); echo $r; [04:25:55] 0 [04:27:03] heh, even without & it gives 1 [04:31:53] New patchset: Aaron Schulz; "Changed on-request job running to shell out instead of doing a loop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [05:22:21] Aaron|home: I did see it. I wonder though where wgTmpDirectory is used for. Doesn't it default to something good? [05:44:13] New review: Tim Starling; "Can't this be merged with maintenance/getConfiguration.php ?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17069 [05:45:36] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [05:57:23] New review: Krinkle; "(4 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59050 [06:10:22] New patchset: Jdlrobson; "Separate language generation from outputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59986 [06:19:38] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [06:29:02] New patchset: IAlex; "Only allow fields from isFieldSortable to be sorted on." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59879 [06:29:34] New patchset: IAlex; "Only allow fields from isFieldSortable to be sorted on." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59879 [06:30:05] New review: IAlex; "fixed whitespace" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59879 [06:34:50] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59879 [06:46:30] Thanks ialex :) [06:51:11] Krinkle: not to a tmpfs [06:51:23] it might make the tests a bit faster to use one [06:51:30] Aaron|home: k [06:51:59] Aaron|home: (I'll change it, no problem) Isn't it like possible to have linux's /tmp be on tmpfs? [06:52:13] Seems like much easier than have it be in a nonstandard place and try and point everything to it. [06:52:17] people do that to [06:52:27] it would work there [06:52:49] most of the unit test code tends to rely on wfTempDir() which uses that global [06:53:45] [06:53 UTC] krinkle at gallium in /srv/ssd/jenkins/workspace/mediawiki-core-install-sqlite ((no branch)) [06:53:45] $ php maintenance/eval.php [06:53:46] > echo $wgTmpDirectory; [06:53:47] /tmp [06:55:26] Aaron|home: Should I set it to /var/lib/jenkins/tmpfs or make a directory inside there? [06:55:46] We already have [06:55:46] $wgSQLiteDataDir = "/var/lib/jenkins/tmpfs/mediawiki-core-install-sqlite"; [06:55:57] well, tmpfs/$JOB_NAME really [06:56:54] sure, as long as the dir exists when the tests run [07:11:18] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:30:50] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:34:20] New review: Mattflaschen; "This works locally. It has pretty much everything except the guiders." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/59575 [07:42:17] Krinkle /tmp @ tmpfs is really evil thing [07:42:27] solaris is doing it and it's serious bleh [07:42:35] petan: care to elaborate? [07:42:51] first of all: it eats a lot of ram [07:43:09] petan: I'm not talking about using tmpfs in general. [07:43:18] what did you mean then [07:43:21] and isn't /tmp in memory anyway? [07:43:26] no it's not [07:43:34] /tmp is regular folder on filesystem [07:43:44] on most systems except for solaris [07:43:46] petan: But it is cleared on reboot, right? [07:43:52] in ubuntu it is [07:43:58] Mac as well [07:44:00] anyway [07:44:01] but that depends on configuration [07:44:15] anyway - in /tmp you can find stuff that eats several gb on some systems [07:44:19] petan: I mean, we installed tmpfs on gallium.wikimedia.org to improve performance of mediawiki in Jenkins with regards to sqlite files [07:44:19] you don't want to have that in ram [07:44:27] I see [07:44:37] some applications aren't even cleaning up /tmp so that it would eat ram and it would not get auto cleaned [07:44:50] when app is using /tmp and you kill it you leave a lot of crap in your memory [07:44:59] OK ok [07:45:16] I assume this is something that tmpfs could adress though [07:45:21] by being smarter about what's hot and what's not [07:45:32] you would need to write some daemon for that [07:45:37] which would auto clean it... [07:45:57] eventually setup some quotas [07:46:06] anyway, I'm not doing that [07:46:09] Nevermind [07:46:19] I'm not proposing to use tmpfs for /tmp [07:47:42] ok I just saw "/tmp" and tmpfs and that's it :P [07:47:47] * Aaron|home compiles redis 2.6 on windows [07:47:48] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [07:47:49] I don't really know what you were discussing before [07:56:28] ohh, it still has the cute ascii art [08:04:31] New patchset: Krinkle; "ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59989 [08:04:53] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59989 [08:07:54] Krinkle: the only thing to worry about might be test leakage [08:08:35] it would suck if empty directories kept being left in [08:08:47] unless old items get nuked regularly [08:09:20] Aaron|home: Every job has an empty directory in /var/lib/jenkins/tmpfs (a namespace basically) [08:09:30] I don't know whether hashar has set up automatic cleaning [08:09:40] so far the only file put in there is the sql file [08:09:44] and it isn't being clean up [08:09:50] though it is deleted at the begin of every install [08:10:26] we could extend that to simply delete everything recursively in its tmpfs namespace instead of just the sql file [08:11:08] e.g. rm -rf /var/lib/jenkins/tmpfs/mediawiki-core-phpunit-parser/* instead of rm /var/lib/jenkins/tmpfs/mediawiki-core-phpunit-parser/my_wiki.sqlite [08:11:37] Lets see how it goes first, so we know what is being left being. [09:08:33] New patchset: Mwjames; "(Bug 46458) ApiSMWInfo add count information of individual query formats" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59990 [09:12:27] New patchset: Mwjames; "(Bug 46458) ApiSMWInfo add count information of individual query formats" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59990 [09:12:38] New patchset: Matthias Mullie; "No need to cache lb's, they're cached in LBFactory classes already." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59991 [09:15:12] New review: Mwjames; "You gotta love a failing test ..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/59990 [09:50:56] New patchset: Pastakhov; "Refactoring (version 0.1.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/59814 [10:02:33] New patchset: Spage; "Move template header inside form so CAPTCHA works" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59993 [10:31:06] New patchset: Mwjames; "Don't access the db twice, eliminate globals" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59994 [10:51:59] New patchset: Matthias Mullie; "(bug 46713) Getting AFTv5 logs via API times out on English Wikipedia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59418 [11:05:22] New review: Aklapper; "Thanks. This would fix bug 46837. As the automatic linking in Bugzilla has a &go=Go parameter, creat..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/54503 [11:28:08] New patchset: Daniel Kinzler; "(bug 45535) Hook for changing language links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [11:56:29] New patchset: Mwjames; "Move SMWSpecialSemanticStatistics into SMW ns" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60001 [12:19:02] New patchset: Zfilipin; "Run Universal Language Selector feature in Chrome" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60003 [12:22:57] New patchset: Platonides; "RedisLockManager class added in ed01e813 checks for RedisException" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/60004 [12:26:06] New patchset: J; "deduplicate transcode jobs" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59597 [12:28:47] New patchset: Hashar; "pass validator" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60005 [12:30:34] New review: Platonides; "We don't follow PSR in autoloading or filenames (nor some other places)." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59804 [12:31:12] New review: Hashar; "yeah" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60005 [12:32:07] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60005 [12:32:24] New review: Hashar; "boum" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60005 [12:37:31] New patchset: Rtdwivedi; "Replaced Xml class by Html." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/59442 [12:45:57] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59418 [12:46:29] New patchset: J; "add unique constraint on transcode name, key" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57536 [12:59:45] New patchset: Umherirrender; "Pass array to Title::getLocalURL instead of an urlencoded string" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59855 [13:00:20] New review: Umherirrender; "The array syntax is easier to read, in my opinion that does not makes things bad, but I have removed..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59855 [13:14:12] New patchset: J; "add maintenance script to retry failed transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [13:15:42] New patchset: J; "add maintenance script to retry failed transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/60006 [13:19:09] New review: Anomie; "(5 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [13:29:52] New patchset: Umherirrender; "API: Add new hook 'APIGetPossibleErrors'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57103 [13:40:16] New review: Anomie; "Not +2ing yet to give anyone else a chance to comment on the log changes. If no one else does in a f..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59766 [13:48:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57103 [13:51:37] New patchset: Matthias Mullie; "Trim leading/trailing spaces from comments" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [13:53:57] New patchset: Matthias Mullie; "Trim leading/trailing spaces from comments" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [14:07:46] New patchset: Zfilipin; "Scenario: User can see input method keyboard icon" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/55266 [14:19:00] New patchset: Zfilipin; "Scenario: User can see input method keyboard icon" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/55266 [14:19:23] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/55266 [14:33:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59994 [14:56:56] New patchset: Anomie; "Add Javascript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [15:01:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60001 [15:06:26] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/58689 [15:06:40] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58689 [15:08:18] New patchset: Alex Monk; "Fix new messages count update on marking threads as read from Special:NewMessages" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/60012 [15:10:41] New review: Jeroen De Dauw; "(3 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/59990 [15:10:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59990 [15:19:19] New review: Jeroen De Dauw; "(5 comments)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59057 [15:21:04] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59057 [15:21:10] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/59595 [15:21:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59595 [15:23:02] hashar: mwext-VisualEditor-qunit is doing weird again [15:23:07] HTTP 200 OK, empty response [15:23:19] apc fluuk again? [15:23:45] New review: Daniel Kinzler; "(5 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59997 [15:24:30] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/59052 [15:26:11] New patchset: Jeroen De Dauw; "Work on timeline code [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/53608 [15:27:18] curl --silent http://localhost:9412/apc_cache_info.php|egrep -o '/srv.*php'|sort | uniq --repeated [15:27:19] gives nothing [15:27:37] I should puppetize that [15:27:38] :D [15:29:07] hashar: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/381/console [15:35:45] Krinkle: well that does not give that much info [15:36:06] one possibility would be to add a curl to dump out the page [15:36:16] I already did that [15:36:17] look at it [15:36:18] at least the headers and some lines [15:36:28] ah [15:36:29] nice [15:36:39] yeah 200 + 0 lenght [15:36:43] don't you have debug log enabled ? [15:36:44] The output is exactly the same as we had earlier, that one we fixed by doing apc clear [15:37:06] New patchset: Jdlrobson; "Separate language generation from outputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59986 [15:37:08] not for every unit test run, no. [15:37:37] I've got error reporting, mediawiki debug and php display errors enabled [15:37:43] it has to be something *very* early on [15:37:55] like last time with apc weird being [15:39:48] Change abandoned: Cmcmahon; "branch was for demo purposes, no longer needed" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59446 [15:41:23] New review: Hashar; "(1 comment)" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59989 [15:41:47] Krinkle: a different subject. I don't think your $wgTmpDirectory change works https://gerrit.wikimedia.org/r/#/c/59989/ [15:41:56] see inline comment at https://gerrit.wikimedia.org/r/#/c/59989/1/jobs/_shared/ExtraSettings.php,unified :) [15:42:15] I have checked APC cache, it looks fine [15:42:31] the only way to debug the issue you are facing would probably to use $wgDebugLogFile to somewhere [15:42:35] maybe to the build directory [15:42:42] so we can keep an history of them [15:45:44] New patchset: Krinkle; "ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60015 [15:46:04] New review: Krinkle; "(1 comment)" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59989 [15:46:13] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/60015 [15:50:50] New patchset: Zfilipin; "Update readme file" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60018 [15:51:11] New review: Markus Kroetzsch; "Thanks, I like the new design for a web button that blends better with low-contrast skins. The orang..." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/58320 [15:51:19] New review: Anomie; "(3 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [15:51:37] New patchset: Anomie; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [15:53:09] New patchset: Zfilipin; "Update readme file, there is not enought tests there." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60018 [15:56:35] New patchset: CSteipp; "Re-add afl_ip=afl_user_text to ip searches" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/60021 [15:56:40] Change abandoned: Zfilipin; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60018 [15:58:50] New review: Alex Monk; "Per commit message "Having this condition *will break* searching for IPv6 addresses"" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/60021 [15:59:18] Probably should've -2'd that one [15:59:19] oh well [16:05:26] New review: Hoo man; "Can't we just fix this properly? Even per hand adding the indexes on enwiki seems more proper to me..." [mediawiki/extensions/AbuseFilter] (master) C: -2; - https://gerrit.wikimedia.org/r/60021 [16:07:01] If the *stewards* give an okay? [16:07:09] That's... new criteria, but okay [16:07:45] csteipp, I CC'd you to that bug about enabling Extension:Widgets on enwikivoyage [16:08:36] Krenair: I'll take a look [16:09:00] It had some XSS issues IIRC [16:10:44] However if it can be made to only cause the same security issues as sysop's editinterface for javascripts it should be okay, I think [16:23:04] guillom: I knew you were take that as a call for help from you :) [16:23:17] guillom: thanks for the suggestions there about the Roadmap [16:23:19] greg-g: heh :) [16:23:47] greg-g: "Did somebody ask for advice on Dark MediaWiki Magic?" [16:23:52] :) [16:24:28] afk for a bit, gotta cook dinner [16:24:32] enjoy! [16:24:37] thx [16:26:14] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [16:30:25] New patchset: Umherirrender; "API: Add more generic possible errors" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57039 [16:45:09] New review: Mwalker; "@Platonides; just because we don't currently follow PSR doesn't mean that we cannot slowly migrate t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [17:03:23] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/56397 [17:08:14] Whee, is that a new favicon for mw.org I see [17:08:22] or perhaps I just never noticed it before. [17:08:25] New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/56397 [17:08:27] In any case, looks good [17:08:50] bawolff: I'm pretty sure that was a part of the favicon 'deploy' yesterday [17:09:03] * Isarra hugs bawolff and collapses. [17:09:20] Yeah, mww and wikisource got new ones. Isssssalll shiny. [17:09:38] At least I think wikisource did. It was supposed to, though I never actually checked... [17:10:25] What changed about the mww one? It looks the same to me. [17:10:31] New render. [17:10:55] It's less squashed and has better shadows and hinting now. And high-res version. [17:11:14] Just don't ask what changed about wikisource because I really don't know. [17:11:32] I don't see it sense the favicon doesn't show up in my address bar, I think because I have DNSSEC validator installed? [17:11:39] sense? since. [17:12:06] Is it normal for them to not show up? [17:12:15] With that? [17:13:13] dunno, honestly :) I see it in my tab, uh, tab. [17:13:41] what is that thing called?! [17:13:45] the tab's tab? [17:14:13] Isarra: help! [17:14:16] * marktraceur suggests more coffee [17:14:17] ;) [17:14:37] marktraceur: good idea [17:15:07] Muaha, dance puppets [17:15:14] * Isarra looks confused. [17:15:53] Oh, does the favicon usually show up in address bar and on the tab label? [17:16:04] And it's only doing the latter? [17:16:11] *nod* [17:16:37] tab label? that's what it is called? [17:16:44] Isarra: I think greg-g is right, I don't see it in my address bar either, but either Firefox changed that functionality or the fact that we're using HTTPS is changing the behaviour [17:17:09] Isarra: so, just FYI, you didn't break anything, I think it is my Firefox setup, I have non-standard addons including Tree Style Tabs and DNSSEC [17:17:19] yeah, or HTTPS [17:17:24] Ah. [17:18:04] it's just how firefox works -- mine is almost completely bog standard and google/facebook show up exactly the same way we do [17:18:07] only in the tab tab [17:18:14] marktraceur: but, I just forced non-ssl and it doesn't show it, either, just the grey/white globe [17:18:18] Hrm. [17:18:24] tab tab! [17:18:31] * sumanah likes hearing phrase "tab tab" [17:18:34] tab [17:18:36] So yeah, probably they just took out the display for the address bar [17:19:02] \t\t [17:19:20] ok, I'll shutup now :) [17:19:22] does anyone else get annoyed when they cannot tab complete the internet? [17:19:37] mwalker: I get annoyed when I can't tab complete real life conversations [17:19:43] hehe [17:19:49] +1 [17:20:25] +1 [17:20:56] greg-g: You'd still need to remember the first few characters - better to have people's names float above their heads [17:21:12] What would you tab complete, though? [17:21:21] The internet is vague and there are so many options... [17:21:44] Isarra: context aware tab-complete [17:22:12] But would does it know which context? [17:22:15] -does [17:22:50] I just want Vannevar Bush's memex [17:24:17] I'll just leave this here for everyone: http://xenia.media.mit.edu/~rhodes/Papers/wear-ra-personaltech/index.html [17:25:00] the software: http://remem.org/ [17:25:03] mwalker: there? [17:25:12] But does it support single-operation pasting? [17:25:23] Isarra: I uh... don't know what that means [17:25:43] Isarra: you can do anything in emacs with 11 fingers, if that helps. [17:26:02] Like how with X you can copy and paste with two clicks total. [17:26:22] Instead of using keyboard and stuff along with a mouse... [17:26:26] I've seen photos of people setting up sewing machine pedals to work as an extra keyboard key [17:26:35] so you can use your foot [17:26:36] clearly emacsen ^ [17:26:37] oh, well, it's all emacs, so however you've configured it. He used a special one-handed keyboard, dunno details [17:26:59] sumanah: yeah, my keyboard had the option foot pedal addon [17:27:03] sumanah: A modifier key, or an actual character? I can see Ctrl, Alt, Super, and spacebar as viable options. [17:27:04] optional [17:27:08] Blimey. [17:27:12] anywho, about meeting time [17:27:22] Maybe backspace or delete, but I'm not sure how you'd choose [17:28:01] meeting. [17:28:15] Mmmkay then [17:42:34] New review: Tychay; "Even if you don't follow PSR exactly, you can now include PSR-compliant3rd party libraries and frame..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [17:45:49] New review: Adamw; "All I would add to that is, we can replace very many lines of $wgAutoloadClasses entries with a sing..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [17:47:36] New review: Adamw; "@Tychay: on that note, 3rd-party libs are a good argument for implementing the entire PSR thing here..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [17:53:00] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [17:57:42] New review: Tychay; "Wouldn't other spl_autoload registers catch the loading for 3rd parties if the namespace is wrong? T..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59804 [18:04:05] New patchset: Umherirrender; "Fixed spacing in api folder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60028 [18:09:55] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59991 [18:18:58] New patchset: Kaldari; "Making sure disclaimer message is parsed in Flickr interface" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/60029 [18:23:52] New review: Kaldari; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/60029 [18:29:07] New review: Siebrand; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59819 [18:51:24] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59959 [18:54:51] Change abandoned: CSteipp; "Index added by Asher, so this isn't necessary. Yay!" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/60021 [19:06:42] xyzram: hi :-]  I am really not ruby aware :D [19:08:21] hashar: np; my suggestion just makes the code a little more compact [19:09:04] Because that is one of the best parts of Ruby -- being compact, yet readable (unlike perl :-) [19:09:20] indeed :-D [19:11:44] >> "".empty? [19:11:45] => true [19:12:03] xyzram: ^^^that is why I used String.length > 0 [19:18:04] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [19:18:19] New review: Aaron Schulz; "* Set missing user name token on login wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [19:30:24] New patchset: Prageck; "Fixed Bug 40464 Placeholder attribute of searchInput element" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60035 [19:57:33] alolita: in the LCM dashboard project listed in GSoC ideas 2013 one has to make a front end that displays the same data as is done in the spreadsheet? [20:04:39] New patchset: Kaldari; "Initial version of Disambiguator extension" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/41043 [20:05:36] Change abandoned: Kaldari; "Squashed this one" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/44273 [20:05:44] New patchset: Aaron Schulz; "Added abandoned job stats." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60040 [20:07:49] New patchset: Cmcmahon; "test for preferences/appearance per the backlog" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/60041 [20:12:56] New patchset: MarkTraceur; "Remove parsoid-testCommit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60042 [20:15:50] anomie: did you ever deploy that fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=46978 ? [20:15:53] * AaronSchulz can't remember [20:16:47] AaronSchulz: No, never got around to it [20:24:54] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #4: FAILURE in 5 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/4/ [20:26:30] New review: Adamw; "(24 comments)" [mediawiki/extensions/CentralNotice] (master) C: -1; - https://gerrit.wikimedia.org/r/57090 [20:29:15] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #4: FAILURE in 2 min 10 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/4/ [20:31:54] jdlrobson: I [20:32:06] I'm writing a notice for meta/enwiki about the CN deployment [20:32:40] we're pushing this banner to logged in/anonymous on enwiki to alpha/beta mobile users on android on en.m.wiki [20:32:41] ? [20:33:25] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60040 [20:35:45] New patchset: Aaron Schulz; "[JobQueue] Use regular wfDebug() in some places." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60073 [20:42:57] New patchset: Umherirrender; "Fixed spacing in specials folder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60077 [20:51:19] New review: Adamw; "* Special:CentralNoticeBanners/Edit/existingbanner -> "There are problems with some of your input", ..." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [20:52:01] anomie: Do you think MediaWiki should still allow using a pure PHP JSON library? I ran across this: https://github.com/php/php-src/blob/master/ext/json/JSON_parser.c#L18 [20:52:12] So MediaWiki currently requires non-free software in order to run [20:53:14] PleaseStand: Ugh. [20:53:21] * anomie looks for a 10-foot pole [20:53:37] eh? [20:53:53] oh noooooo the good not evil again :D [20:55:01] That's a non-free license? [20:55:18] free licenses don't discriminate based on usage [20:56:10] the liberty to do evil [20:56:28] New patchset: Umherirrender; "Fixed spacing in specials folder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60077 [21:08:06] anomie: I'm thinking of reverting the change on REL1_21 while I come up with something for master, which will go out with 1.22. Does that make sense? [21:26:41] New patchset: Anomie; "Don't pass negative years to Language::sprintfDate" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/60078 [21:26:47] New patchset: Anomie; "Don't pass negative years to Language::sprintfDate" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/60079 [21:27:34] New patchset: Kaldari; "Initial version of Disambiguator extension" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/41043 [21:30:40] New patchset: Kaldari; "Initial version of Disambiguator extension" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/41043 [21:37:25] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59993 [21:38:59] Change merged: jenkins-bot; [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/49392 [21:51:53] New patchset: Kaldari; "Initial version of Disambiguator extension" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/41043 [21:55:37] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59984 [21:55:50] New patchset: PleaseStand; "Revert "Combine JavaScript and JSON encoding logic" and follow-ups" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/60080 [21:59:37] New patchset: Anomie; "Don't pass negative years to Language::sprintfDate" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/60079 [21:59:53] New patchset: Anomie; "Don't pass negative years to Language::sprintfDate" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/60078 [22:01:13] New review: MarkTraceur; "Yup yup" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/60042 [22:01:13] Change merged: MarkTraceur; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/60042 [22:03:42] mwalker: best to talk to Maryana in wikimedia-mobile [22:04:53] Change merged: jenkins-bot; [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/60079 [22:06:57] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/60078 [22:14:29] New patchset: Adamw; "Don't use civi functions during installation!" [wikimedia/fundraising/crm/civicrm] (master) - https://gerrit.wikimedia.org/r/60081 [22:15:07] New patchset: Kaldari; "Initial version of Disambiguator extension" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/41043 [22:15:17] Change merged: Mwalker; [wikimedia/fundraising/crm/civicrm] (master) - https://gerrit.wikimedia.org/r/60081 [23:06:52] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #19: FAILURE in 5 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/19/ [23:06:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #6: FAILURE in 4 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/6/ [23:24:29] Yippie, build fixed! [23:24:29] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #5: FIXED in 5 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/5/ [23:27:32] New patchset: Aaron Schulz; "Added $wgCentralAuthLoginWiki option." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [23:27:59] New review: Aaron Schulz; "* HTTP vs HTTPS fixes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [23:29:39] Yippie, build fixed! [23:29:39] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #5: FIXED in 3 min 8 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/5/ [23:39:40] New review: Spage; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/53794 [23:50:59] New patchset: Aaron Schulz; "[JobQueue] Fixed numbers given to redis queue stat calls." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60085 [23:51:58] bawolff: https://gerrit.wikimedia.org/r/#/c/60085/ [23:52:08] * AaronSchulz was chasing that goose for 3 days [23:52:09] New review: Kaldari; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59986 [23:53:54] New patchset: Aaron Schulz; "Fixed redis job queue stat value for "recycle"." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/60086 [23:54:06] New patchset: Jdlrobson; "Separate language generation from outputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59986 [23:55:00] New review: Brian Wolff; "Note I only visually inspected, did not test since I don't have redis set up" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/60085 [23:56:04] AaronSchulz: A good reason why things like count should throw errors instead of returning 1 when given a primitive variable [23:57:08] :)