[00:19:52] New patchset: Adamw; "Squashed commit of the following:" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59562 [00:21:22] New review: CSteipp; "(2 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [00:42:12] New patchset: Aaron Schulz; "Small doc fix to JobQueueRedis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59566 [00:44:33] New review: Ori.livneh; "Thanks!" [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/59534 [01:02:07] New patchset: Kaldari; "Add 'Mark all as read' button to overlay" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59568 [01:02:43] New review: Kaldari; "Might have performance issues for users with lots of notifications." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/59568 [01:04:56] New patchset: Spage; "WIP - create account form with VForm appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [01:20:12] New patchset: Aaron Schulz; "Set up the profiler in CLI mode." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [01:21:39] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/59547 [01:21:39] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/59546 [01:24:16] New patchset: PleaseStand; "mw.loader: Guard against odd setTimeout behaviour in old Firefox" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59571 [01:26:23] New patchset: Legoktm; "Add option to meta=globaluserinfo to provide global edit count" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [01:28:10] New review: Legoktm; "I haven't been able to test this since I don't have a testwiki set up with CentralAuth yet." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [01:28:23] New review: Legoktm; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/52022 [01:34:13] New patchset: devunt; "Special:WantedPages no longer lists any page having at least one redirect pointing to it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54120 [01:34:52] New review: devunt; "PS6: removed trailing whitespace" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54120 [01:35:10] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59534 [01:40:34] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [01:41:36] New review: Cscott; "See https://gerrit.wikimedia.org/r/59572 for the alternative implementation GWicke suggests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [02:08:14] New patchset: Mwjames; "Clean-up RecurringEvents class, add test docs" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59574 [02:10:35] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [02:13:13] New review: Mattflaschen; "So far, I'm done the landing page. You can test on http://toro.wmflabs.org/wiki/Special:GettingStar..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [02:14:40] New patchset: Mattflaschen; "DRAFT - Implement new GSv3 design:" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/59575 [02:16:50] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59574 [02:24:14] Change abandoned: Mwjames; "(no reason)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58293 [02:49:25] New patchset: Anomie; "(bug 47300) Fix sandboxing with require" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59576 [02:51:05] New patchset: Mwjames; "Decouple responsibility, move value factory out of ParserData" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59057 [03:10:09] New review: Parent5446; "(5 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59572 [03:22:30] Change abandoned: Ori.livneh; "(no reason)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/55534 [03:26:50] New patchset: Spage; "Clean up, comments, remove obsolete mw-ui-formlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59025 [03:50:11] New review: Spage; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59025 [03:54:16] New patchset: Ori.livneh; "Set 'skin' template parameter rather than override parent method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [04:00:52] New review: Ori.livneh; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [04:14:29] New review: Spage; "Excellent." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59577 [04:19:48] New patchset: Krinkle; "TemplateData: Add phpunit, remove jshint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59578 [04:20:48] New review: Nikerabbit; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [04:21:41] New review: Nikerabbit; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [04:25:40] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59578 [04:30:16] New patchset: Liangent; "Clean up old way to disable variants (using a special name 'disable')" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59579 [04:35:14] New patchset: Liangent; "Clean up old way to disable variants (using a special name 'disable')" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59579 [04:56:44] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [05:02:07] New patchset: Krinkle; "TemplateData: Fix syntax error in If185f1079" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59594 [05:02:26] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59594 [05:07:53] New patchset: Mwjames; "Move SMWDataValueFactory and add tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59595 [05:17:06] New review: Spage; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:21:15] New patchset: devunt; "Special:WantedPages no longer lists any page having at least one redirect pointing to it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54120 [05:29:38] New review: Wikinaut; "can someone explain to me why jenkins-bot failed ?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:30:38] New patchset: Spage; "Create account form with vertical form appearance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57823 [05:32:10] Does anyone know if we changed something in the installer or updater that would cause REL1_20 to be unable to write to an sqlite database where 1.21/1.22/master can? [05:32:24] Perhaps some kind of permissions bug that was too strict and was fixed? [05:35:36] hello, there is an angoing problem with Jenkins bot see https://integration.wikimedia.org/ci/job/mediawiki-core-merge/11824/console [05:37:18] Wikinaut: It is a known issue with zuul, assuming it hasn't gotten worse, it is still unpredictable and not consistently happening. [05:37:38] Wikinaut: Rebase / recheck usually makes it run. Have you tried that? [05:37:48] I have to move this channel. [05:37:56] Because I had it sorted near "unimportant channels." [05:38:00] And now it has the bots. [05:38:40] I see wikibugs is still in #mediawiki and gerrit-wm was already in this channel for non-core non-operations repositories [05:38:51] now for core as well. [05:39:12] I'm not really sure what was ever wrong with -tech. [05:39:15] But whatever. [05:39:58] New patchset: Krinkle; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:40:38] Susan: -tech was for operations, not dev. Though that has changed, but by that time -dev was already created and -tech repurpused for another audience. [05:41:20] Does this mean I can part -feed? [05:41:21] I think it does. [05:41:36] Krinkle: the last 25 changes have jenkins -2. It is not intermitent at the moment [05:41:45] Good riddance to that channel. [05:42:03] Jenkins is only failing mediawiki/core [05:42:09] Susan: Well, it is a mystery why -feed was already created, but yeah, looks like it will be redundant now. [05:42:22] -feed was the new -codereview. [05:42:25] bawolff: I'm not an expert on zuul backend, but I'll see what I can do. [05:42:32] Because Petrb didn't know about -codereview, I guess. [05:42:40] If it isn't fixed within the hour, ping hashar (I'll mail him too). He should be waking up soon. [05:44:32] Its all the same error: ERROR: Problem fetching from origin / origin - could be unavailable [05:44:37] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59373 [05:46:51] Krinkle: the problems are consistenly since a while (not since my patch) see https://integration.wikimedia.org/ci/job/mediawiki-core-merge/ [05:49:20] The local origin repo looks fine to me [05:49:21] /var/lib/zuul/git/mediawiki/core [05:49:37] git reports no errors in there, must be the -merge job perhaps [05:49:49] New patchset: Wikinaut; "(bug 47264) Special version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:49:54] but since that one blocks the others.. [05:51:04] New review: Wikinaut; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:51:48] New review: Krinkle; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [05:52:19] Krinkle: regarding this settings, there are persons who insist on the local update time. I think we should leave them their fun to have it. We could set the default to false (i.e. be default to show only the upstream commit date) [05:52:30] Looks like someone moved the zuul origins from /var/lib/git/mediawiki/core to /var/lib/zuul/git/mediawiki/core [05:52:30] s/settings/setting/ [05:53:16] Wikinaut: I think having a setting for this is absurd. There's no path to discussion through me, but feel free to try someone else. [05:53:32] DaSch has added several bugzillas [05:53:46] and was unhappy wiht my recent patch [05:53:55] (upstream commit dates) [05:54:14] I think, we should not be too stric tin our view [05:54:25] Personally I am also in favour of seeing the both dates [05:55:13] I do understand, that there is a common sense not to flood DefaultSettings with new ones [05:55:19] I _do_ [05:55:46] what is about setting the default to false [05:57:14] New review: Krinkle; "It looks like this practically took down our Jenkins server." [integration/jenkins-job-builder-config] (master) C: -2; - https://gerrit.wikimedia.org/r/59556 [05:57:39] Wikinaut: I am not for or against the feature, I'm saying having a switch for it is crazy. [05:57:45] Anyway, I don't care right now. [05:58:01] ^demon where are you? It looks like you broke the build. [06:00:21] hashar isn't up yet [06:00:26] Oh well, here goes nothing. [06:00:32] * Krinkle takes out a revert hammer [06:00:48] Be gentle. :-) [06:01:20] Well, all jenkins are broken. [06:01:25] It can't get much worse. [06:01:36] Of cours, the change isn't in the repository .. [06:01:39] argh [06:03:33] New patchset: Wikinaut; "(bug 47264) Special:Version: add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:05:35] New review: Ori.livneh; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [06:05:56] New review: Wikinaut; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:07:03] ori-l: recheck won't do it. The server is pointing to the wrong location to fetch changes from git/gerrit. [06:07:09] I'm fixing it now. [06:07:23] https://gerrit.wikimedia.org/r/59556 [06:07:28] but maybe if i keep pressing the button, the elevator will come faster... [06:07:32] :) [06:07:45] thanks for fixing [06:12:08] Should be working now. [06:13:57] New patchset: Krinkle; "Set 'skin' template parameter rather than override parent method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [06:14:41] New review: Krinkle; "btw, shouldn't one of these classes have another change as well? (the call to getSkin and/or reading..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [06:16:29] New patchset: Krinkle; "(bug 47264) SpecialVersion: Add last local update timestamp" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:19:27] New review: Krinkle; "Since there was no change to revert[1], I've re-generated jobs on latest master and pushed them for ..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [06:46:43] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59545 [06:47:17] New review: Krinkle; "Both /var/lib/zuul/git/ and /var/lib/git/ exist. " [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [06:48:19] TimStarling: The git-remote configuration change hashar and/or chad pushed has been reverted. Jenkins should be working again (so you can let the tests run and automerge) [06:48:24] just fyi :) [06:48:37] I gotta get to bed now, hashar will be up soon I think. [06:51:23] New review: Krinkle; "(1 comment)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [06:59:26] New review: Ori.livneh; "> btw, shouldn't one of these classes have another change as well? (the call to getSkin and/or readi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [07:02:21] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [07:09:52] New review: Wikinaut; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59373 [07:38:56] hi [07:40:34] hey [07:42:35] New review: Daniel Kinzler; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [07:50:46] New patchset: Legoktm; "(bug 44792) Merge "globalunblock" right into "globalblock"" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/48608 [07:52:10] New review: Legoktm; "I rebased the patchset and fixed the one last occurrence of the right. Ran a grep and didn't see any..." [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/48608 [07:52:58] New review: Hashar; "Caused bug 47307 which I have no marked as resolved. https://bugzilla.wikimedia.org/show_bug.cgi?id=..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [07:57:34] ori-l: if you have a sec, setting up vagrant threw an error http://dpaste.de/SfavO/raw/ [07:57:57] legoktm: you need 1.1+ [07:58:06] ah [07:58:09] will upgrade [07:58:16] also, hi hashar [07:59:03] hi hi :-) [07:59:32] also hi hashar and ori-l :) [07:59:41] howdy YuviPanda [07:59:45] mornin [08:04:49] legoktm: if you get a chance, let me know how it works [08:05:00] still downloading the box :) [08:05:54] ah [08:06:59] regarding the pep8 changes: i don't have merge rights in operations/puppet, so we'll need to find someone with root to merge it. tim said he'd be willing to review it, but he was specifically interested in fixing the connectivity issue. [08:07:20] so i wonder if it's worth creating a new repository specific for the bot that is not in operations/puppet [08:07:29] ^ legoktm [08:08:15] ah ok [08:09:03] i was going to work on the connection issues thing on friday [08:09:25] makes sense to stick it in another repository though [08:09:49] you can request one here https://www.mediawiki.org/wiki/Git/New_repositories/Requests [08:11:53] do we need to talk to someone in the ops team first? [08:14:18] might be good to ask tim what he thinks, she he volunteered to do some of the reviewing [08:14:45] and it looks like andrew bogott was working on it most recently [08:15:24] s/she he/since he [08:15:57] ok [08:17:33] btw, i still need to think of a good way to manage that, but all the debug settings that are active actually make the vm a little slow [08:18:28] if you find it to be slow, just edit LocalSettings.php and set $wgDebugProfiling, $wgDebugDumpSql and $wgDebugToolbar to false [08:18:57] that did the trick for me, but i haven't had time yet to go back and be more granular in determining the exact cause [08:19:19] New patchset: Liangent; "Clean up old way to disable variants (using a special name 'disable')" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59579 [08:22:58] ori-l-away: its up :D [08:23:16] New patchset: J; "add maintenance script to reset transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59597 [08:30:59] New patchset: J; "add unique constraint on transcode name, key" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57536 [08:32:04] New patchset: Freakolowsky; "Fixed maintenance/tables.sql (typo i guess)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59598 [08:32:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59579 [08:56:41] New patchset: Krinkle; "mw.loader: Guard against odd setTimeout behaviour in old Firefox" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59571 [09:11:06] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59571 [09:11:56] New patchset: Siebrand; "Rebuild MessagesEn.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [09:16:01] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:16:46] New review: Siebrand; "PS2 squashes Change-Id: Idb553d46cdb13af0f88f638a6f3bc82e31df4de5 into this patch set at the request..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:17:40] Change abandoned: Siebrand; "Squashed into Change-Id: I0e334d910a311f067276215b6bff94cd814fc3b3 per request" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59079 [09:20:25] New review: Liangent; "I assume this is intended to be a followup of Change-Id: Ifb005e7cc9efd0b4a4f87fd491a71c8d5e1a5748, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [09:22:10] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:22:23] New review: Siebrand; "PS3 fixes a merge conflict in includes\specials\SpecialFewestrevisions.php and rebases to HEAD of ma..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:22:29] New patchset: J; "Revert temporary plain text output from I75e37906" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [09:24:31] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59079 [09:31:35] New patchset: Matmarex; "drop useless HTML comments in Vector" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59181 [09:31:35] New patchset: Matmarex; "remove invalid comment from SkinVector::setupSkinUserCss" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59603 [09:31:35] New patchset: Matmarex; "separate adding body classes and other attributes in Skin/OutputPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59604 [09:37:53] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:38:11] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:38:49] New review: Siebrand; "PS4 fixes an issue pointed out in Change-Id: Idb553d46cdb13af0f88f638a6f3bc82e31df4de5" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59078 [09:49:40] New patchset: Wikinaut; "(bug 47264) SpecialVersion: Add last local update timestamp" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [09:53:42] New review: Aklapper; "Log message misses reference to bug 43504." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59395 [09:54:25] New review: Wikinaut; "code can be seen working live on " [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59373 [09:56:56] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59050 [09:57:57] New review: Siebrand; "Oops. Meant -1." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59050 [09:58:42] New review: Peachey88; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59395 [10:05:03] New review: Peachey88; "(2 comments)" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [10:05:07] New review: Siebrand; "(3 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59572 [10:05:13] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [10:13:27] New review: Siebrand; "(6 comments)" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [10:18:54] New review: Matmarex; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59603 [10:19:15] New review: Matmarex; "UNTESTED" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59604 [10:22:42] New review: Siebrand; "(8 comments)" [mediawiki/extensions/GWToolset] (master) C: -1; - https://gerrit.wikimedia.org/r/59405 [10:27:58] New review: Siebrand; "(5 comments)" [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/59575 [10:31:37] New review: Siebrand; "(2 comments)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/59568 [10:36:09] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [10:37:02] hashar: So the problem with -qunit in core is related to sqlite being read-only and triggers HTTP 500. That seems easy to solve (at least we know what the problem is) [10:37:09] hashar: however in visualeditor-qunit we have a different problem [10:37:22] mediawiki is serving HTTP 200 but 0 length body [10:37:31] I can consistently reproduce it once it is in this weird state [10:37:52] it only happens on 1 in 10 builds, but when it does I can curl it 10 times from gallium and it'll serve the same weird thing [10:38:01] I have it in this state right now and disabled the jenkins job for now [10:38:39] both index.php, load.php and api.php server HTTP 200 OK with 0 content-length [10:38:53] no php errors anywhere either, I've bumped mediawiki debugging and php error reporting, nothing [10:39:02] maintenance scripts work fine (eval.php, update.php etc.) [10:39:13] curl --include 'http://localhost:9412/mediawiki-extensions-VisualEditor-e3c07d148bcbcb9b32c9604e222471739f989441/index.php?title=Special:BlankPage' [10:39:21] Any idea what this could be? [10:39:30] Must be some kind of bug in MediaWiki I guess. [10:39:53] HTTP/1.1 200 OK [10:39:54] Content-Length: 0 [10:39:58] X-Powered-By: PHP/5.3.10-1ubuntu3.5+wmf1 [10:40:43] Reedy: [10:41:05] that's very strange [10:41:09] I've never seen anything like it [10:41:27] The run the triggered it is here: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/276/console [10:41:52] I guess you already checked that there's no caching in the middle [10:41:55] If I re-enable it it'll wipe the workspace, re-install everything and work, and then at some point it'll happen again. it happens like once an hour. [10:42:09] yeah, these installs have no caching. [10:42:42] I'm definitely interacting with mediawiki itself, not getting the same cached error twice. [10:42:53] can you tar everything and check at a different place if those contents fail, too? [10:43:19] Krinkle: hi :] [10:43:28] Krinkle: thx for fixing the mediawiki jobs overnight! [10:43:34] yw [10:43:34] to have fixed [10:43:36] well [10:43:37] whatever [10:43:47] I wonder if it may be a problem at my_wiki.sqlite [10:44:10] that it got corrupted and is marked as 'busy', thus timeouting all following requests [10:44:19] hashar: feel free to jump in at gallium. /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit and /srv/localhost/qunit [10:44:26] Krinkle: maybe enable wgDebugLogFile in the workspace ? [10:44:30] they're returning immediately [10:44:30] Krinkle: since what it outputs [10:44:41] hashar: I can't see apache logs, root only [10:44:45] can you check error_log? [10:44:50] ah that is unfortunate :-] [10:44:52] I'll enable wgDebugLogFile [10:45:19] you can also try phpunit tests [10:45:29] if it's mediawiki, it's likely that those would also fail [10:45:53] I should split the access/error logs [10:46:16] [Wed Apr 17 10:46:06 2013] [error] [client ::1] PHP Fatal error: Class 'WebRequest' not found in /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/includes/DefaultSettings.php on line 89 [10:46:28] Krinkle: client is ::1 must be from qunit [10:46:57] Krinkle: stack trace http://dpaste.com/1061723/ [10:47:08] hashar: When I run it with the debug log, the log file is not being created, its failing very early on. That was to be expected since the body output is 0 length, not even an error (not even HTTP error, HTTP 200) [10:47:12] I am wondering why a Fatal Error would give a 200 though :-] [10:47:18] Why is that not causing HTTP 500? [10:47:26] maybe [10:47:42] hashar, probably because it didn't run the code yet where we set header("HTTP/1,0 500"); [10:47:44] that happens in WebStart which is early on [10:47:57] Platonides: There is no such code [10:48:03] Platonides: PHP does that if there is a fatal error [10:48:08] (well, it should, anyway) [10:48:18] hashar: we should enable display_errors [10:48:36] in prod? no way :-] [10:48:36] so we don't have to dig through error_log to get fatal errors [10:48:42] hashar: This is not prod. [10:48:52] ? [10:48:56] gallium is :-] [10:48:57] but [10:49:10] but we could get localhost.qunit to log its errors to a public dir [10:49:16] nothing on gallium is what I consider prod, and even so, its easy to set on just some virtual hosts instead of all. [10:49:48] Why at all to a file? Jenkins gets a lot of jobs, I don't want to dig through logs for anything. everything related to a job should be right in the console where stuff happens. [10:49:50] gallium is definitely production. Any access / private data etc are covered by the exact same NDA we have filled for the rest of the infra :-] [10:50:04] That request came from qunit, but which of the 10 extensions using it, which branch, which commit etc. [10:50:20] ahh [10:50:35] so yeah maybe enable display_errors for the qunit.localhost vhost [10:50:56] since that is only access by localhost / jenkins I guess we can disclose that safely [10:50:57] hashar: besides php fatal errors only contain paths and names of classes that are in source contorl. [10:51:06] hashar: and requests are firewalled and listen only on localhost [10:51:12] yeah [10:51:32] So back to the error. [10:51:45] when I run index.php outside apache (from cli) I don't get an error either [10:52:08] File does not exist: /srv/org/wikimedia/doc/favicon.ico haha [10:52:24] exit code 0 [10:53:09] New patchset: Hashar; "doc.wikimedia.org now uses the WMF favicon" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/59608 [10:53:13] hashar: not important, we have a favicon in the html. Probably some browser trying it anyway. We could set up a wrapper like for mw live root. [10:54:12] New review: Krinkle; "lets not duplicate the icon? Some browsers check this but it is also in the html. So it isn't an iss..." [integration/docroot] (master) - https://gerrit.wikimedia.org/r/59608 [10:54:20] hashar: So back to the error at hand [10:54:31] Are you sure that's the one caused by this request? [10:54:49] [10:52 UTC] jenkins at gallium in /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit [10:54:50] $ php index.php; echo $? [10:54:50] 0 [10:54:59] no output, no error, not even an exit code. [10:55:04] this doesn't make any sense. [10:55:37] try with curl? [10:56:10] curl --include 'http://localhost:9412/mediawiki-extensions-VisualEditor-e3c07d148bcbcb9b32c9604e222471739f989441/index.php?title=Special:BlankPage' [10:56:17] gives me the same stacktrace [10:56:28] I've tried that at least a 100 times. [10:56:45] And when I just did it again, the same, nothing. [10:57:04] https://gist.github.com/anonymous/a0a84c6d9088ff7afd98 [10:57:12] that produced the same stacktrace [10:57:19] oh, in the debug file [10:57:23] yes, I see [10:57:24] in error_log [10:57:30] no stracktrace in the debug file [10:57:42] hashar: I can't see the error_log, remember? [10:58:04] yeah but I pasted it to you http://dpaste.com/1061723/ [10:58:09] I see [10:58:11] I am tail -f the error log in a term [10:58:13] that doesn't help much though [10:58:19] https://gist.github.com/anonymous/162b83239c41aa6dfd17 [10:58:22] ^ mw debug log [10:58:40] funny isn't it ? :- ] [10:58:45] the class not found is nice, but why is it not causing an error [10:58:57] not to mention, how come it can't find that class ... [10:59:02] DefaultSettings [10:59:10] is in Setup after autoloader [10:59:41] I guess $IP is incorrect [11:00:02] Hey guys [11:00:07] /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit [11:00:08] mm [11:00:08] No, that's because I did "php index.php" once from the wrong directory [11:00:26] (about 20 minutes ago, probably in your log, it can't find includes/Init.php) [11:00:29] Is gerrit-wm a bot which auto feeds changes being made to wikimedia code? [11:00:48] Aayush251: It reports events from https://gerrit.wikimedia.org [11:01:32] Aayush251: They're aren't always changes, as much as proposed changes and discussion about them. The "merge" is when they are approved and included in the code. To be released some time in the future (days, weeks, ..) [11:01:48] Nice [11:02:12] Its actually quite usefull [11:02:34] * Krinkle smiles [11:02:47] hashar: maintenance scripts still function, try it. It's weird. [11:03:11] but any end point towards the front-end is broken. [11:03:56] so [11:04:01] I have hacked WebRequest.php [11:04:05] to output a message [11:04:15] now I have a new error PHP Fatal error: Class 'Title' not found in /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/languages/Language.php on line 335 [11:04:18] must be APC [11:04:43] $IP must be correct, otherwise it wouldn't include DefaultSettings.php and the other includes would've failed. [11:05:18] yeah that is a weird cache issue [11:05:33] hashar: I don't see anything in WebRequest.php [11:05:34] if I touch the file, it works [11:05:54] after editing WebRequest the autoloader managed to load it properly [11:06:04] the next request complained about Title [11:06:15] I have touched include/Titles.php [11:06:26] now it complains about the next loaded class [11:06:31] Interesting. [11:06:55] hashar: Is MW_COMPILED defined? [11:07:05] I have no idea what that is [11:07:23] define( 'MW_COMPILED' or $_SERVER['MW_COMPILED'] [11:08:26] ah so core is installed using git archive [11:08:46] maybe wiping the workspace would work [11:09:41] Okay, MW_COMPILED isn't enabled for some weird reason. Never mind that. [11:10:11] hashar: I've been wondering about that [11:10:17] hashar: mediawiki core jobs should use scm "git-zuul-no-submodules" instead of "mwcore-no-submodules" [11:10:33] though, that couldn't cause this [11:10:48] hashar: I noticed there is no .git indeed. [11:10:58] Why is that? [11:11:00] yeah the macro just do a git archive [11:11:10] Ah, of course [11:11:12] this isn't a core test [11:11:14] that is for extensions to avoid cloning the whole git repo [11:11:33] hashar: Perhaps it is taking the wrong state of the core repo (not really master but whatever change was last tested in master) [11:11:34] mark enhanced JJB to support multiple git repos though [11:11:51] it is arching from the gerrit slave [11:11:54] so we could use the git plugin to clone from the bare repo in /var/lib/git/mediawiki/core.git [11:11:56] archiving* [11:12:10] since that is local, I think the Git Plugin creates hard link which would be very fast [11:12:10] that should be the same as archive installing it [11:12:27] I mean, how can that cause this. [11:12:40] thinking about it [11:12:51] The installer works, maintnenace scripts work even now. [11:12:53] but to me that seems like a cache issue in APC [11:13:10] where it would consider the file has not changed [11:13:52] Why is APC even enabled for the mw installs by jenkins [11:13:58] Or is that done from php.ini for all of gallium [11:16:19] hashar: I enabled display_errors from localsettings for now [11:16:20] Fatal error: require(): Cannot redeclare class siteconfiguration in /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/includes/AutoLoader.php on line 1143 [11:16:48] yup [11:17:17] if you touch includes/SiteConfiguration.php that would invalidate the file in the cache [11:17:20] and let it find it [11:18:35] hrmgbmb [11:19:18] the APC cache info list the file twice [11:19:19] http://dpaste.com/1061756/ [11:20:41] $ stat --format='Birth: %W Access: %X Mod: %Y Change: %Z' /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/includes/SiteConfiguration.php [11:20:41] Birth: 0 Access: 1366197491 Mod: 1366197491 Change: 1366197491 [11:20:46] New review: Daniel Friesen; "Can you explain why we need another method for this?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59604 [11:20:48] New patchset: Krinkle; "ExtraSettings.php: Some debugging for MediaWiki installs in Jenkins" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59609 [11:21:01] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/59609 [11:22:26] so yeah APC has duplicates copies that must not help [11:23:13] New review: Krinkle; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59604 [11:24:19] hashar: Can APC be disabled from within php or do we need to configure it from an ini file and then somehow load that from the apache vhost for jenkins localhost/qunit [11:24:32] I am going to clear the cache [11:24:46] k [11:25:43] New review: Krinkle; "In favour in general, but letting open for other input." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59181 [11:25:47] Change merged: Theaitetos; [mediawiki/extensions/DynamicPageList] (master) - https://gerrit.wikimedia.org/r/43868 [11:25:50] New review: Daniel Friesen; "Strictly speaking that comment is in fact correct. The issue is that RL has a completely different bug." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59603 [11:26:06] Krinkle: apc_clear_cache() fixed it [11:26:18] hashar: Where did you invoke that [11:26:28] I am not sure how it get corrupted though :-(((( [11:26:47] maybe it is confused by the symlink in /srv/localhost [11:26:57] * Krinkle re-enables the jenkins job [11:27:15] Stuff is going to be wiped soon [11:27:34] Change merged: Theaitetos; [mediawiki/extensions/DynamicPageList] (master) - https://gerrit.wikimedia.org/r/59071 [11:28:52] so hmm [11:28:57] Krinkle: keep it around please [11:29:10] /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/includes/SiteConfiguration.php had two cache entries [11:29:21] Did you clear the cache? [11:29:24] but with different inodes 279956281 and 279956283 [11:29:36] I would like to find out what those in odes are [11:29:36] It is working [11:29:55] I'm rebasing a gerrit change now to see if it works. It won't mean anything since it already worked 1/10 times. [11:30:06] https://gerrit.wikimedia.org/r/#/c/59570/ passed [11:30:08] trying another one [11:30:38] ah the first inode is the file that is /srv/ssd/jenkins/workspace/mwext-VisualEditor-qunit/includes/SiteConfiguration.php [11:30:43] the second inode I have no idea :-D [11:30:50] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/278/console also passed [11:31:32] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/279/console [11:31:47] yep, curl reports a regular html page [11:31:51] that is crazy [11:32:18] There's a few more open changes in VE with broken jenkins-bot scores, will slowly try them all one after another. [11:32:45] If it still shows no failure it seems we fixed it (unless it is caused by hitting php a lot over time, in which case it might strike back in a few weeks) [11:33:10] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/VisualEditor+is:open+label:Verified-1,n,z [11:34:15] that is some weird APC corruption [11:34:19] not sure what caused it though [11:34:37] I have no idea how it look up the file internally [11:34:42] yeah, and php not throwing a hard enough error to trigger HTTP 500 [11:34:44] could just look by filename [11:34:51] and never look at the inode [11:35:06] I mean, I know it isn't incapable of doing that in general on gallium. [11:35:18] Earlier this week we had HTTP 500 in mw-core-qunit for the db read only stuff [11:37:15] Krinkle: if you want to check the APC cache in apache : curl --silent http://localhost:9412/apc_cache_info.php [11:37:26] then simply grep the PHP files [11:37:30] there should be no duplicate [11:37:32] aka: curl --silent http://localhost:9412/apc_cache_info.php|egrep -o '/srv.*php'|sort | uniq --repeated [11:38:06] Yippie, build fixed! [11:38:07] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #12: FIXED in 3 min 13 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/12/ [11:45:32] hashar: Rebased them all, nothing caused another failure like this (some failed, but just failed assertions in qunit) [11:46:04] Krinkle: the APC cache is fine :D [11:51:30] hashar: well, it's not obvious. It got messed up some how [11:51:36] Giving it a bunch of jobs to crunch on could've easily broken it again. [11:51:56] But fortunately that didn't happen, so we're in the clear for now. [11:52:05] New patchset: Zfilipin; "Added en.wikipedia.org to browsertests template" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59610 [11:53:06] New review: Ganeshaditya1; "working on putting the messages in i18n, also working on fixing my English :) @peachey88 I thought c..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [11:56:33] Krinkle: the APC cache does not have dupe entries this time [11:56:44] Not yet ;-) [11:57:27] hashar: Question, do you know of a way to have multiple builders in a job and have them all run (instead of stopping at first error), and then marking the job failure if one or more builders failed. [11:57:30] New review: Siebrand; "Other languages get updated as there are changes from twn" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [11:57:55] I know it can be done if you hack it together in 1 builder and save the exit code and then throw it manually at the end, but that's ugly. I like re-using macros etc. [11:59:14] New patchset: Zfilipin; "Fixed scenario wording" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59612 [12:01:37] Change abandoned: Legoktm; "Not really, hopefully someone else is." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/38716 [12:02:42] New review: Liangent; "So is TWN updater always running rebuildLanguage.php before submission? If so, I don't understand wh..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [12:06:43] Project browsertests-en.wikipedia.org-linux-firefox build #1: SUCCESS in 1 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/1/ [12:11:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [12:14:19] New review: Siebrand; "Twn exports do not change English" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [12:18:13] New patchset: Hoo man; "Use post for syntax checks instead of get" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [12:19:04] New patchset: Freakolowsky; "Fixed dumpBlocks fcn" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59616 [12:21:37] New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59617 [12:26:53] New patchset: Krinkle; "Use POST method for action=abusefilterchecksyntax API requests" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [12:28:23] New patchset: Hoo man; "Add .jshintrc for AbuseFilter" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:31:34] New review: Krinkle; "(2 comments)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/59618 [12:32:21] New review: Siebrand; "(3 comments)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [12:32:42] New review: Siebrand; "i18n/L10n review" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/59211 [12:33:21] New patchset: Siebrand; "Email digest header tweaks" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59537 [12:33:25] New patchset: Siebrand; "Email digest header tweaks" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59537 [12:33:29] New patchset: Liangent; "DO NOT MERGE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59619 [12:35:15] New review: Liangent; "https://gerrit.wikimedia.org/r/59619 - this is a test run of rebuildLanguage.php on master. I don't ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [12:35:41] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:36:14] hoo: https://integration.wikimedia.org/ci/job/mwext-AbuseFilter-jslint/87/console [12:37:41] New patchset: PleaseStand; "Move release notes from 1.21 to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [12:37:47] hoo: Empty line between browser and predef [12:37:51] predef is not environment [12:38:05] and no trailing comma [12:38:16] and forgot a comma after onevar: true [12:38:26] 12:36:42 ERROR: Can't parse config file: /srv/ssd/jenkins/workspace/mwext-AbuseFilter-jslint/.jshintrc [12:38:44] ah... got it :) [12:39:07] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:39:30] ah, the gerrit bot is over here now :) [12:41:38] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:42:40] Krinkle: Now it passes :) [12:44:26] New review: Legoktm; "Tested against the filter that errored on enwiki, and it works fine." [mediawiki/extensions/AbuseFilter] (master) C: 1; - https://gerrit.wikimedia.org/r/59615 [12:44:31] hoo: :D [12:46:03] New review: Krinkle; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/59618 [12:46:26] hoo: one minor thing [12:46:50] New review: Siebrand; "(8 comments)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/59537 [12:47:04] onevar should be improved to also check the location of the (single) var statement, though it doesn't validate that now, that's just jshint's implementation, it doens't change the convention, just means it isn't automated yet unfortunatley. [12:47:14] * Krinkle makes a note [12:47:46] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:47:58] Probably nice that way, ye [12:47:58] s [12:48:16] New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:49:41] New review: PleaseStand; "I have added all owners/authors of the listed change sets as reviewers." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [12:49:56] Yippie, build fixed! [12:49:56] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #9: FIXED in 3 min 20 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/9/ [12:54:42] hoo: This will likely come up more often in the future, so thats why I'm being thorough this time. [12:54:49] New review: Krinkle; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/59618 [12:55:00] If in doubt, keep the assignment where it was and only moved the declaration. [12:57:14] Change abandoned: Demon; "I can abandon this, but it was not this change that cause problems. I was attempting this fix manual..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [12:57:26] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [12:59:27] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [12:59:44] New review: Krinkle; "So neither of you ran something like `$ jenkins-jobs --conf etc/jenkins_jobs.ini update config/ ...`..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59556 [13:00:12] hoo: What operating system and editor do you use? [13:00:44] Krinkle: The system I used for those commits is a CentOs 6.4 box [13:00:46] and geany [13:01:23] I got FC18 on my local machine, tough (tend to ssh to the box mentioned above, toguh) [13:02:12] hoo: You may want to install nodejs + npm + node-jshint, so that you can just exec "$ jshint ." from any directory (or on one or more indivual files) and run it [13:02:35] There's also some plugins on the internet for Geany to integrate jshint in the editor (instead of running manually) [13:02:43] google 'geany jshint' [13:02:49] anyhow, you got the error report from jenkins I assume. [13:02:52] missing semi colon [13:03:07] ah really, gnah [13:03:17] https://github.com/trongthanh/geany-for-front-end-dev/wiki/Using-JSHint-with-Geany [13:03:47] New patchset: Hoo man; "Add .jshintrc for AbuseFilter and make it pass" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [13:06:30] New review: Krinkle; "For next time, it is preferred to group variables declared without definition before those with defi..." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/59618 [13:06:41] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59618 [13:06:59] New review: Krinkle; "Unable to rebase, merge conflict." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [13:08:40] New review: Krinkle; "You may want to use this commit to also use the (now documented) format for jshintrc:" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [13:09:39] New review: Krinkle; "See core's and VisualEditor's file for an example." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [13:10:03] New patchset: PleaseStand; "Backport some tweaks to 1.21 release notes" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [13:11:18] New patchset: Hoo man; "Use POST method for action=abusefilterchecksyntax API requests" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [13:11:38] New review: Hoo man; "Rebased" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [13:12:37] New review: Krinkle; "I'm not sure how the topic "1_21_to_1_22" makes sense, did you leave something out of the commit mes..." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [13:13:19] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59615 [13:17:54] New patchset: PleaseStand; "Some 1.21 release note tweaks" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [13:18:39] New patchset: Aklapper; "Bugzilla frontpage: make common tasks easier accessible" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [13:19:37] New patchset: Zfilipin; "Simplified the way the tests are executed" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59622 [13:20:25] New review: Kaligula; "Gosh, sorry, I thought too fast for it (I shouldn't review, yup?)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [13:21:09] Change abandoned: Hashar; "not needed, that is defined in the HTML already :D" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/59608 [13:21:43] New review: Aklapper; "Latest patchset #5 fixes those three issues pointed out in reviews: Horizontal scrolling: removed "r..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [13:21:50] New patchset: Krinkle; "Sync 1.21 release notes from master" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [13:22:24] New review: PleaseStand; "Hopefully, I have addressed your concern about the commit message not accurately reflecting establis..." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [13:23:34] New patchset: Krinkle; "Sync 1.21 release notes from master" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59623 [13:23:50] Yippie, build fixed! [13:23:51] Project browsertests-test2.wikipedia.org-linux-firefox build #264: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/264/ [13:24:08] New patchset: PleaseStand; "Move release notes from 1.21 to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [13:25:08] New review: Krinkle; "Looks like there are more notes out of sync in the 1.21 file. Either there are more commits that sho..." [mediawiki/core] (REL1_21) C: -1; - https://gerrit.wikimedia.org/r/59621 [13:25:53] Change abandoned: Krinkle; "Wrong branch." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59623 [13:27:48] New review: PleaseStand; "For those who don't care about this change (and who have already confirmed that their changes have n..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [13:30:34] New review: Krinkle; "Forgot to move "The Special:ActiveUsers special page was removed."" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59620 [13:40:14] oh [13:40:18] so we got all the spam there [13:40:29] * hashar finds a new home :-D [13:48:51] <^demon> hashar: Back to #mediawiki! [13:49:51] New patchset: PleaseStand; "Revert "Remove link to Special:ActiveUsers from Special:Statistics"" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59624 [13:51:52] ^demon: well it is spamed by wikibugs :D [13:52:57] which you already have ignored... [13:54:38] :-] [13:54:46] but then I need to ignore gerrit-wm in this channel [13:54:56] though I wanted to keep notification for the repos that were there [13:55:06] much more complicated though the ignore command seems to support it :-] [13:55:32] * hashar goes and ignores mediawiki/(?:extensions|core} [13:59:36] Yippie, build fixed! [13:59:36] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #298: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/298/ [14:00:12] New review: PleaseStand; "(4 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:03:21] New patchset: PleaseStand; "Move release notes from 1.21 to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:13:50] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59624 [14:14:02] New patchset: PleaseStand; "Sync 1.21 release notes from master" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [14:16:27] New review: MarkAHershberger; "Thanks for looking at these. If you think they should be in 1.21, please submit them to the REL1_21..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:20:04] New patchset: Matthias Mullie; "Alternative method to detect the existence of a user/talk page discussion" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59627 [14:25:20] New patchset: Krinkle; "Move release notes from 1.21 to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:27:27] New review: Krinkle; "Removed part in comment message about removing the file from master. That's not how we work. Changes..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59620 [14:28:14] New patchset: Krinkle; "Sync 1.21 release notes from master" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59621 [14:30:59] New patchset: Ganeshaditya1; "Added a info box at the end of the page which carries a link to the extensions manual and a link to browse extentions by categories or to view categories matrix Change-Id: Iba5d53a485d7b0b04cb9104d7d964fc01a1c1cae" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [14:32:28] New review: PleaseStand; "Krinkle: I think it does make sense to update HISTORY and then remove RELEASE-NOTES-1.21, because re..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:38:44] Yippie, build fixed! [14:38:45] Project browsertests-test2.wikipedia.org-linux-chrome build #283: FIXED in 6 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/283/ [14:39:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59620 [14:47:42] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [14:48:27] New review: Siebrand; "Latest PS updates jehintrc to what the documentation prescribes. Will do the same for Translate and ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [14:50:17] New review: Umherirrender; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58903 [14:53:01] New patchset: Zfilipin; "Simplified the way the tests are executed" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59622 [14:53:14] New patchset: Siebrand; "Update .jshintrc to convention" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [14:53:54] New patchset: Umherirrender; "else if -> elseif" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59461 [14:54:41] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [15:01:11] New patchset: Zfilipin; "Simplified the way the tests are executed" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59622 [15:06:55] New patchset: Siebrand; "Update .jshintrc to use same settings as core" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [15:08:41] Yippie, build fixed! [15:08:42] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #248: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/248/ [15:11:43] New review: Cmcmahon; "add enwiki to recognized sites" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59610 [15:11:44] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59610 [15:13:07] Yippie, build fixed! [15:13:07] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #251: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/251/ [15:14:08] New review: Cmcmahon; "per-browser tags for test runs" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59622 [15:14:08] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59622 [15:14:36] New patchset: Ganeshaditya1; "Added a info box at the end of the page which carries a link to the extensions manual and a link to browse extentions by categories or to view extension matrix. All the messages are in i18n and links are placed thru wiki text rather than hardcoding them C" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:14:57] New review: Cmcmahon; "change wording to not mention sandbox" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59612 [15:14:58] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59612 [15:17:40] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [15:19:41] New review: Aklapper; "In my humble opinion the commit message still needs improvement: it does not mention anything about ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59395 [15:20:37] New patchset: Siebrand; "Update .jshintrc to use same settings as core" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [15:21:27] New patchset: Siebrand; "Update .jshintrc to use same settings as core" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [15:23:24] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/59631 [15:25:33] New patchset: Ganeshaditya1; "Added a info box at the end of the page which carries a link to the extensions manual and a link to browse extentions by categories or to view extension matrix to the last screen of the installer at the bottom of the page. All the messages are in i18n and" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:26:01] New patchset: Siebrand; "Add .jshintrc" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/59631 [15:26:11] New patchset: Siebrand; "Update .jshintrc to use same settings as core" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [15:26:35] New patchset: Siebrand; "Update .jshintrc" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59632 [15:26:53] New review: Reedy; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:26:54] New review: Ganeshaditya1; "Sir am very glad for your review. Could you please point out the link to use instead of the list of ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:27:16] New patchset: Ganeshaditya1; "Added a info box at the end of the page which carries a link to the extensions manual and a link to browse extensions by categories or to view extension matrix to the last screen of the installer at the bottom of the page. All the messages are in i18n and" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:28:34] New patchset: Zfilipin; "Running more tests at commons.wikimedia.beta.wmflabs.org" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59633 [15:28:51] New review: Ganeshaditya1; "I totally didn't think about the qqq part :( @reedy I mean I read about it only once so it didn't oc..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59395 [15:30:22] New review: Cmcmahon; "run more tests than just UW on beta commons" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59633 [15:30:22] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/59633 [15:32:12] New review: Cscott; "(8 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:37:15] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:38:34] New review: Cscott; "@Parent5446: I checked OutputPage.php:function output() and the redirect URL is passed through wfExp..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:38:43] is it possible to add more actions for violating a rule to the abuse filter? [15:39:23] New patchset: Reedy; "Replace weird usage of explode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53628 [15:39:40] New patchset: Siebrand; "Update .jshintrc" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [15:40:26] RickyB98: yes [15:40:26] New review: Siebrand; "@Liangent: Non English files are no longer pretty formatted. It's been like that for over a year." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59601 [15:40:27] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [15:40:38] you just need to add hooks [15:40:43] legoktm: how can I do that? [15:41:18] New patchset: Cscott; "Clean up SpecialFilepath." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [15:41:30] how do I add hooks? sorry I'm not an expert of those things xD [15:41:36] here's a somewhat example: https://gerrit.wikimedia.org/r/#/c/48121/ [15:41:37] New review: Cscott; "Rebased to poke jenkins." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59524 [15:41:38] its not perfect though [15:45:04] thx [15:47:06] New patchset: Cscott; "Create a Special:UserById page redirecting to a user page given a numeric id." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [15:47:20] and if I have a code like this: action == "purge" & !("sysop" in user_groups) how do I add purge to the possible actions? (this is sth else) I mean : I want users not to purge a page more than 3 times in a minute. how can I add "purge" action? [15:47:58] New review: Cscott; "rebased; fixed siebrand and nikerabbit's issues." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [15:48:22] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [15:48:32] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [15:48:35] Change abandoned: Liangent; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59619 [15:50:21] New patchset: Cscott; "Create a Special:Redirect page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:52:01] New review: Cscott; "Changed is_numeric to ctype_digit, as per nikerabbit's comments on https://gerrit.wikimedia.org/r/59050" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [15:52:30] New patchset: Lwelling; "Update email footer to approved launch phrasing." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59635 [15:55:09] New patchset: Lwelling; "Update email footer to approved launch phrasing." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59635 [16:00:40] New patchset: PleaseStand; "Add parser method to call parser functions" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59637 [16:20:21] <^demon> Restarting gerrit in a moment to hopefully fix the Jetty problem. Please don't panic. [16:29:28] New patchset: Lwelling; "Split out notification emails to a separate from address so they can be configured as specified for launch." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59640 [16:30:24] New review: Lwelling; "Untested. Don't merge yet." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/59640 [16:36:56] New review: Daniel Kinzler; "don't feel qualified to review this, removing myself" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [16:37:04] New patchset: Legoktm; "Add a "ucase" function to convert the provided string to uppercase." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59641 [16:38:14] New patchset: PleaseStand; "Fix WDDX formatted output" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59643 [16:38:57] New review: Reedy; "Not sufficient." [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/59641 [16:40:25] New patchset: Legoktm; "Add a "ucase" function to convert the provided string to uppercase." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59641 [16:44:48] New review: Ori.livneh; "PS1 +2'd by Spage; PS2 changed commit message only." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59577 [16:48:20] New patchset: PleaseStand; "Move WDDX release note back to 1.21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59645 [16:48:32] New patchset: Legoktm; "Add a "ucase" function to convert the provided string to uppercase." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59641 [16:51:19] New review: PleaseStand; "Release note moved back to 1.21 in I25247f36." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59643 [16:52:25] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [16:53:33] New review: Kaldari; "(2 comments)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/56536 [16:55:14] New patchset: Lwelling; "Split out notification emails to a separate from address so they can be configured as specified for launch." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59640 [16:55:26] New patchset: Kaldari; "Pref for showing notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/56536 [16:55:41] New review: Daniel Kinzler; "Looks ok, but it would be nice to take the opportunity to improve HooksTest, so it actually tests al..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27255 [16:55:48] New review: Aaron Schulz; "Seems fine but it should also have a sql file just for this patch and hook into the hook LoadExtensi..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57536 [16:57:55] New patchset: Brian Wolff; "E_USER_DEPRECATED undefined prior to php 5.3" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/59423 [16:58:41] New review: Brian Wolff; "PS2: Jenkins, Jenkins, Jenkins..." [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/59423 [16:58:55] New patchset: Marcoil; "Expose namespaces with enabled subpages." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59649 [16:59:16] New review: Robotto7831a; "Works fine." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34329 [17:02:45] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [17:03:06] New patchset: Brian Wolff; "RefreshLinks on imagelinks on new uploads to kill tracking cat." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59359 [17:03:24] New review: Swalling; "(2 comments)" [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/59575 [17:03:44] New review: Brian Wolff; "PS4: Jenkins sucking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59359 [17:04:30] New patchset: Aaron Schulz; "Set up the profiler in CLI mode." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [17:05:38] New patchset: Aaron Schulz; "Small doc fix to JobQueueRedis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59566 [17:05:50] New patchset: Aaron Schulz; "Reduced DB contention in User::saveOptions()." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59511 [17:05:56] New patchset: Aaron Schulz; "Reduced DB contention in User::saveOptions()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59490 [17:06:03] New patchset: Aaron Schulz; "[JobQueue] Added per-type stat counter calls for better graphs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59433 [17:06:53] New patchset: Aaron Schulz; "[FileBackend] Simplified the shard list iterator to use AppendIterator and FilterIterator." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56778 [17:11:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59577 [17:11:25] New review: Daniel Kinzler; "Looks good and works for me." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59569 [17:14:31] New review: Aaron Schulz; "All jobs are in redis, so this won't work." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/59597 [17:15:52] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/56536 [17:23:32] New patchset: Adamw; "Drupal7 upgrade and api changes" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59562 [17:26:30] New review: Bsitu; "(2 comments)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59537 [17:26:40] New patchset: Brian Wolff; "getPageDimensions failure handling incorrect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [17:28:47] New review: Krinkle; "(4 comments)" [mediawiki/extensions/Translate] (master) C: 1; - https://gerrit.wikimedia.org/r/59629 [17:32:48] New review: GWicke; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59649 [17:35:26] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59566 [17:39:11] New patchset: Lwelling; "Split out notification emails to a separate from address so they can be configured as specified for launch." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59640 [17:45:26] New review: Anomie; "I'm willing to be convinced otherwise, but why is looking for the "subpages" property in an API quer..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/59649 [17:46:53] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59649 [17:48:05] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59511 [17:50:09] New review: Krinkle; "O_o Looks like you reverted yourself there. Doing the update to the new format separate from this is..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [17:50:20] siebrand: ^ [17:51:06] Krinkle: Sorry, don't understand. What is wrong? [17:51:25] siebrand: You reverted back to PS1, where it doesn't have /* Common */ and /* Local */ [17:51:41] and not browser:true (thus causing the window undefined error) [17:51:47] Hmm, really? [17:51:49] Grr. [17:54:45] Krinkle: From what I can see, it never had Commons and Local, and in PS5, .jshintrc has more comments than PS1. browser:true is not documented as enforced, is it? [17:54:56] Krinkle: It's totally unclear to me what the documentation wants. [17:55:06] Krinkle: Can you please amend the patch set? [17:55:29] siebrand: browser is section // Environment [17:55:36] see jshint.com/docs/ [17:55:52] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59562 [17:56:00] http://jshint.com/docs/#enforcing_options [17:56:07] Krinkle: You referred me to https://www.mediawiki.org/wiki/CC/JS#Linting [17:56:16] Krinkle: I did exactly what was documented there. [17:58:03] New review: Aaron Schulz; "Already +2ed" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59490 [17:58:04] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59490 [17:58:30] New review: Aaron Schulz; "Already +2ed" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56778 [17:58:31] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56778 [17:58:58] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59569 [18:01:15] siebrand: Yes, but you (as you shoudl) you also added some local options. in your case use "predef" right now. [18:01:39] New patchset: Brian Wolff; "RefreshLinks on imagelinks on new uploads to kill tracking cat." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59359 [18:02:02] I'd recommend to indicate that with /* Local */, add a header for the common ones /* Common */ and add an additonal local option for // Environment as "browser": true [18:02:04] greg-g: I have three patches to push today if I can have a slot in the lightning deploy (two are for CN and mobile integration) and (one is a follow up to yesterdays ContributionReporting patch) [18:02:23] since the js in Echo has references to window [18:02:35] which throw a warning in js if it isn't configured [18:03:01] (as you can see at the jshint job link) [18:03:15] New patchset: Dereckson; "Magic word localization in Galician." [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59652 [18:03:33] New patchset: Aaron Schulz; "Set up the profiler in CLI mode." [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59653 [18:03:40] siebrand: I must've confused it with your other jshintrc commit in Translate [18:03:47] Indeed, this didn't have that yet, [18:04:17] New patchset: Dereckson; "(bug 47262) Magic word localization in Galician." [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59652 [18:07:30] New review: Dereckson; "(1 comment)" [mediawiki/extensions/Scribunto] (master) C: -1; - https://gerrit.wikimedia.org/r/59652 [18:07:40] mwalker: sounds good, if you can, please add to the wikitech /Deployments calendar, thanks! [18:07:53] will do [18:08:24] New patchset: Dereckson; "(bug 47262) Magic word localization in Galician." [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/59652 [18:12:25] New patchset: Umherirrender; "Add missing braces to for in wfGetCallerTest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59654 [18:19:12] mwalker: awesome, thanks for the detail [18:20:23] New patchset: Aaron Schulz; "Cleaned up test cleanup for FileBackend and avoid use of @." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59658 [18:21:35] New review: awjrichards; "(4 comments)" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/59138 [18:22:08] New review: awjrichards; "See inline comments. In the future, it would be sweet if this took some args to specify start/end co..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/59138 [18:22:36] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59653 [18:23:16] New review: Krinkle; "Aborting test since it is blocking the queue and is already force merged." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59511 [18:27:11] New patchset: Aaron Schulz; "Set up the profiler in CLI mode." [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59660 [18:27:44] AaronSchulz: Can you not force merge this one and instead let it merge asynchronous [18:28:01] The queue is building up rapidly with all those force merges. Some are waiting for 20 minutes now. [18:28:29] (3 jobs are added in under a second: submission patch set, gate submit, postmerge) [18:29:06] too bad it doesn't avoid adding jobs when stuff is merged already [18:29:41] It has some basic detection for aborting things, but it definitely needs improvement. [18:29:45] normally I wait even when merging into wmf just for sanity, though I've been trying to getting certain things done since last morning and it's gotten pretty annoying [18:29:49] Though it should always run at least one of them [18:30:18] Its only building up more and thus also delaying things for master. [18:30:25] New patchset: Mwalker; "Allow HTMLForm Entities to not have Labels" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59439 [18:30:36] You can write it off as done in your mind by just doing CR+2 and moving on. [18:31:20] New patchset: Ori.livneh; "Initial commit; add .gitreview, .gitignore & README" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/59662 [18:32:01] Change merged: Ori.livneh; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/59662 [18:32:41] Krinkle: well normally I do that anyway [18:33:01] and I also have to make a note of it my mind to deploy right after it gets merged (whenever that happens) [18:33:10] Right, there's that. [18:34:04] we're experiencing some scalability/growth issues. rapidly iterating through improvements, but at the same time activity is also increasing. [18:34:31] for now all I can say is that its best for everybody to wait a few minutes then for one person to jump and every body else to have to wait 3x the amount of time. [18:38:17] Krinkle: is fixing this a high priority now? [18:38:51] I'm not fixing anything. Just chatting while I'm waiting for a change I'm trying to get tests results of [18:39:32] and noticed it was basically blocked by 3 changes in 'test', 'gate-and-submit' and 'postmerge' pipelines that were already merged. So I aborted them [18:39:34] I'm asking you as a proxy for Hashar, you live closer to him ;) [18:39:45] You'll get a jenkins-bot comment stating a failure, just ignore it. [18:40:06] AaronSchulz: You mean fixing the scalability in general? [18:40:13] yes [18:40:35] That hasn't been spoken about really, afaik I just called it out out loud for the first time here. [18:40:57] But it is something we need to address and hashar and I are working on that among other things. [18:41:29] If we don't fix it, as activity increases, the queue you made right now will be natural. [18:41:37] you'd have to wait 30 minutes to get anything for anything. [18:41:51] that's obviously not acceptable [18:43:38] ^demon|busy: Jenkins currently has a global concurrent execution limit of 10 [18:43:49] ^demon|busy: Which isnt' the issue either, it is usually at 8 or 9. [18:44:04] the main issue is that there can't be more instances of the same job simultaniously [18:44:11] so there can be projecta-lit and project-b lint [18:44:15] but not twice project-a-lint [18:44:55] and since projects have a dependency like merge > phplint,jshint > phpunit-stuff,phpunit-otherstuff we're not optimal [18:58:17] New review: Siebrand; "I copied the core .jshint file and removed the nomen setting." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [18:58:59] New patchset: PleaseStand; "Add parser method to call parser functions" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59637 [18:58:59] New patchset: PleaseStand; "Fix WDDX formatted output" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59643 [18:59:22] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59660 [18:59:45] New review: Hoo man; "Unit test(s) pass and looks fine in filters. Thanks for the patch!" [mediawiki/extensions/AbuseFilter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59641 [19:00:33] Change merged: Hoo man; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59641 [19:01:58] New review: Hoo man; "Untested" [mediawiki/extensions/GlobalBlocking] (master) C: 1; - https://gerrit.wikimedia.org/r/48608 [19:05:40] New review: Hoo man; "(2 comments)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/52022 [19:08:15] New patchset: Aude; "Update Wikibase, DataValues and Diff" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59667 [19:11:12] New patchset: Umherirrender; "Fixed spacing in languages folder" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59668 [19:15:45] New patchset: Physikerwelt; "rename tests/MathRenderTest.php" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/59669 [19:16:10] New review: Siebrand; "recheck" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59183 [19:17:19] New review: Siebrand; "Does not merge cleanly." [mediawiki/extensions/CentralAuth] (master); V: -1 - https://gerrit.wikimedia.org/r/38904 [19:19:28] New patchset: Brian Wolff; "Make concurrent runs of FileBackendTest independent" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59670 [19:19:55] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59334 [19:20:03] New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/56397 [19:22:27] New patchset: Siebrand; "Add gender to 'passwordreset-emailerror-capture' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58861 [19:22:58] New patchset: Adamw; "use PHP unlink. d7 api changed." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59674 [19:23:41] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59617 [19:24:08] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59674 [19:26:23] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59407 [19:29:32] New patchset: Hoo man; "Got rid of some global $wgContLang usage in SpecialAllpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [19:29:48] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/59666 [19:29:50] New review: Adamw; "This is actually not dependent on "HTMLForms: Support non submit buttons"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59063 [19:30:50] New review: Hoo man; "... code conventions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [19:31:36] Change merged: jenkins-bot; [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/59631 [19:31:41] New review: Aaron Schulz; "I don't think this helps anything." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59670 [19:34:53] New patchset: Hoo man; "Got rid of some global $wgContLang usage in SpecialAllpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [19:35:37] New review: Siebrand; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59180 [19:37:01] New review: Hoo man; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [19:37:23] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59629 [19:38:16] New review: Siebrand; "Please do not force a merge. A +2 on code review will make Jenkins run tests, and if all is well, it..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [19:40:13] New patchset: Aaron Schulz; "Cleaned up test cleanup for FileBackend and avoid use of @." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59658 [19:40:37] New review: Siebrand; "A test timed out:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58913 [19:40:44] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58913 [19:43:05] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/59708 [19:51:20] New review: Umherirrender; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59180 [19:55:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58861 [20:02:03] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #10: FAILURE in 5.8 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/10/ [20:03:42] New patchset: Adamw; "missed some d7 api" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59713 [20:08:37] New patchset: Physikerwelt; "rename tests/MathRenderTest.php" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/59669 [20:10:40] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59180 [20:18:19] Project browsertests-test2.wikipedia.org-linux-firefox build #265: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/265/ [20:19:47] New review: Parent5446; "Trivial style fixes. Looks good to me." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59524 [20:24:35] * hashar jenkins jobs are on hold for an emergency fix sorry. [20:24:54] New patchset: Mwjames; "Add Hooks class test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [20:27:27] hashar: Thanks for the notice, what's up with Jenkins? [20:27:46] (can answer later, I'm sure you're busily fixing it) [20:27:52] New review: Brian Wolff; "Putting the wiki-id in, should mean a LockManagerGroup with a different domain is constructed, which..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59670 [20:28:39] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [20:28:56] New review: Parent5446; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59572 [20:31:27] New patchset: Ottomata; "Adding apt.wikimedia.org to this machine's sources.list.d" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/59716 [20:31:57] Love the new CodePen.io terms of use [20:31:58] http://blog.codepen.io/terms-of-service/ [20:32:01] MIT license required [20:32:18] Gotta love the "Don't be a jerk." repetition half-way in the legalese translation [20:32:24] New review: Aaron Schulz; "Ah, that's right. I forgot I added that domain code a while back." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59670 [20:32:48] Krinkle: except their plain english summary is wrong [20:32:50] " Public Pens you build on CodePen are MIT licensed, meaning other people are free to use it for whatever they like as long as that is also MIT licensed. Don’t put anything on CodePen where that wouldn’t be OK. Private Pens are un-licensed so that you may apply your own license and retain direct ownership. [20:33:05] didn't mean to copy all that, just the first sentence. [20:33:08] Right, MIT isn't share-alike, is it? [20:33:12] not at all [20:33:37] greg-g: Though it is in a way [20:33:44] "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." [20:34:42] You can't make it more liberal than MIT, it can be made more restricting though [20:34:48] Right? [20:35:08] http://opensource.org/licenses/MIT [20:35:21] so, MIT means that all you need to do is not remove the (C) notice in the source files, that's it. You can do whatever you want with it, including making a proprietary derivative [20:36:14] it is also "GPL compatible" in that GPL'd software can include MIT licensed libraries/stuff, but that doesn't change the license of the MIT licensed parts [20:36:51] greg-g: It is both the copyright and permission notice that MIT wants included. [20:37:06] So it isn't just attribution, but also share-alike ish. Isnt't it? [20:37:07] sure, the copyright/license header [20:37:11] no [20:37:22] it doesn't affect any other code it touches at any point [20:37:24] I can't dump the MIT license, drop in CC-BY and use the copyright notice as attributino. [20:37:44] so, hold on, you're confusing two different things here ;) [20:37:46] AaronSchulz: That's odd. Both you and jenkins bot +2'd the filebackend test change, but it didn't merge... [20:38:02] 1) you can't change the license of anything, since you aren't the copyright holder. [20:38:14] bawolff: I've seen that a lot lately [20:38:20] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59670 [20:38:29] * AaronSchulz clicks buttons [20:38:33] * bawolff mutters about gerrit being black magic [20:38:43] 2) simply having the requirement that the license stays in place *on the specific files* is not reciprocal, in that it doesn't affect anything else ie, the other GPL'd or proprietary bits that interface with it. [20:38:58] Right [20:39:31] share alike has a very specific meaning that any derivatives are also the same license, MIT doesn't have that [20:40:07] I can make a derivative of an MIT licensed thing, keep the license headers intact, but also license my whole thing under a proprietary license and never disclose the source code even if I distribute binaries [20:40:07] * marktraceur doesn't see the term "Copyleft" in the scrollback [20:40:15] marktraceur: "share alike" [20:40:27] New patchset: Spage; "Add a button to request a new fancy captcha" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [20:40:29] *nod* [20:40:47] greg-g: righ [20:41:26] ok, enough copyright license nerdery [20:41:27] ;) [20:41:34] New patchset: Mwjames; "Add Hooks class test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [20:41:43] Krinkle: Re: Initial topic, also, hilarious that the software doesn't appear to be free [20:43:32] marktraceur: what software? [20:43:37] New review: Bsitu; "need to make sure https://gerrit.wikimedia.org/r/#/c/59086/ is merged as well since this one depends..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/56536 [20:43:39] Is someone messing with Zuul? [20:43:40] Krinkle: CodePen? [20:43:49] 'Service Temporarily Unavailable' [20:44:09] New review: Marcoil; "Thanks for the comments, I've been able to get the data I needed from the existing API, so this chan..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59649 [20:44:13] New review: Brian Wolff; "Looks good" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59658 [20:44:17] Krinkle: hashar took down Jenkins for a sec [20:44:23] 2013-04-17 - 13:24:17 * hashar jenkins jobs are on hold for an emergency fix sorry. [20:44:54] Subtle. [20:45:04] Jenkins too/ [20:45:23] New review: Spage; "PS19 rebases to master and I improved the commit message." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [20:45:45] marktraceur: CodePen is not open source, Why is that hilarious? [20:46:35] They have commercial services as well. And are a rising startup. They'd stand no chance if they were open source at this time. Someone impatient would fork it, make slightly more improvements and steal the show. [20:46:42] they open to open it up though [20:47:07] Krinkle: I didn't say open source, but sure [20:47:22] Krinkle: It's ironic because they require their customers to be more ethical than they're willing to be [20:47:55] It is a pastebin [20:48:40] hashar: How long is this expected to take and what are you doing? [20:49:16] New patchset: Parent5446; "Slight improvements to FormSpecialPage behavior." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59720 [20:49:52] Krinkle: why they didn't choose CC0 I don't know cc marktraceur [20:50:20] * marktraceur isn't amused [20:50:48] Krinkle: Who cares what it is? Software is software. [20:51:09] Krinkle: stopped zuul. The git cloning kills gallium [20:51:24] Krinkle: I am moving the git repos to the ssd [20:55:14] hashar: k [20:55:31] hashar: not sure if that's the bottle neck, but it'll certainly provide breathing room. [21:00:02] New patchset: Bsitu; "Add nextSequenceValue() to support dbs like PostGres" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59726 [21:02:15] New patchset: Aaron Schulz; "[JobQueue] Added per-type stat counter calls for better graphs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59433 [21:03:43] New review: Parent5446; "So after https://gerrit.wikimedia.org/r/59720 gets merged," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [21:17:41] New patchset: Reedy; "Update Wikibase, DataValues and Diff" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59667 [21:20:50] Krinkle: almost done :-] [21:20:54] Krinkle: jenkins is resdtarting [21:21:04] Krinkle: I am writing a mail for wikitech-l and eng list [21:21:43] New patchset: Adamw; "missed some d7 api" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59713 [21:22:39] New patchset: Aaron Schulz; "Do not bother with ForkController for procs=1." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59730 [21:24:46] New review: Alex Monk; "(3 comments)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [21:26:12] New review: Bsitu; "(2 comments)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59537 [21:26:51] New patchset: Brian Wolff; "Make UserCache only look up a user once." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59731 [21:28:36] New patchset: Adamw; "missed some d7 api" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59713 [21:31:52] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59713 [21:40:46] New patchset: Adamw; "d7 did not support db_update -> join" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59733 [21:42:15] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59733 [21:43:50] New patchset: Bsitu; "Email digest header tweaks" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59537 [21:50:47] New patchset: Brian Wolff; "Don't allow '-' in db name - seems like bad idea with wikiId." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59736 [21:56:10] New patchset: Adamw; "deprecated call to db_fetch_object" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59737 [21:56:29] New review: Spage; "(3 comments)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [21:57:48] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59737 [21:59:20] New patchset: Mwalker; "WIP: Rewriting the CN UI" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/57090 [21:59:26] New review: Brian Wolff; "What's the motivation for backporting this?" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59637 [22:06:52] New review: PleaseStand; "The latest version of Scribunto (from master) calls the new function, which can cause a fatal error ..." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59637 [22:10:44] New patchset: Mwalker; "Updating CentralNotice and ContributionReporting to latest" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59741 [22:13:13] Change abandoned: PleaseStand; "I probably shouldn't bother. WDDX is a weird serialization format that should just die." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59645 [22:13:24] Change abandoned: PleaseStand; "I probably shouldn't bother. WDDX is a weird serialization format that should just die." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59643 [22:13:27] New patchset: Mwalker; "Updating CentralNotice and ContributionReporting to latest" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59742 [22:13:40] New patchset: Adamw; "missing dependency. cleanup. add logging for checks import error" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59743 [22:14:06] New patchset: Hashar; "Zuul repos have been migrated to /srv/ssd" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59744 [22:14:28] Krinkle: I am refreshing all jenkins jobs to points them to the new Zuul git repos https://gerrit.wikimedia.org/r/59744 [22:14:57] Change abandoned: Mattflaschen; "E3Experiments is no longer implementing ACUX, but this is being carried on by ConfirmEdit (still htt..." [mediawiki/extensions/E3Experiments] (master) - https://gerrit.wikimedia.org/r/46473 [22:15:21] hashar: btw, why is it mounted under /srv anyway? [22:15:36] Seems kinda nonstandard given how we tend to use that for document roots. [22:15:51] /mnt/ssd01 seems more intuitive [22:15:56] or something like that [22:16:39] per filesystem hierarchy standard: /srv : Data for services provided by this system [22:16:52] http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM [22:17:18] I'm familiar with the ambiguities of unix root dir assignments. [22:17:26] There is a reason it is different everywhere. [22:17:33] Nothing is obvious. [22:17:44] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59743 [22:17:48] eh, yea, even that has the "The methodology used to name subdirectories of /srv is unspecified as there is currently no consensus on how this should be done. " [22:18:00] Im just saying in Ubuntu and specifically at WMF, we use /srv for document roots. [22:18:27] and /mnt or /data for mounted drives or the like [22:18:28] Krinkle: mark asked for /srv :D [22:18:39] Krinkle: /a/ should die and for some reason /mnt is not used [22:18:40] Now I have to add a gitignore in integration/docroot.git [22:18:45] everything is mounted somehow .. shrug [22:18:53] for /ssd [22:18:58] how messed up is that [22:19:24] yeah that is annoying [22:19:33] /mnt is just for "temporarily" mounted filesystem.. fwiw [22:19:42] mutante: Right, removables [22:19:47] or virtual ones [22:19:55] New review: Spage; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [22:20:00] so /data then [22:20:09] which is the king of non-standard but consistency among wmf [22:20:30] * AaronSchulz puts his backups in /media [22:20:30] /data isnt even in the standard at all ..uhmm [22:20:54] heh, yeah, my flash drives automounts in /media [22:21:19] mutante: /data is in some standard [22:21:25] Directories are so bourgeois. /me dumps all files in / [22:21:28] http://xkcd.com/927/ [22:22:13] New review: Hashar; "deploying right now" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/59744 [22:22:14] * marktraceur still wants the XKCD with a graph showing the percentage of conversations where there's a relevant XKCD comic [22:22:16] you might wanna localize them :p [22:22:23] New review: Hashar; "deploying right now" [integration/jenkins-job-builder-config] (master); V: 2 - https://gerrit.wikimedia.org/r/59744 [22:22:23] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/59744 [22:22:26] hashar: Next up, moving /var/lib/jenkins to ssd and moving workspaces back under jenkins/jobs/ ? [22:22:48] I find this /workspaces//* rahter confusing [22:23:23] mutante: http://xkcd.com/33/ [22:23:33] the Zuul git repos and workspaces need to be on the same device :D [22:23:34] I need to document that out somewhere [22:23:51] hashar: Yes, this would stay like that [22:23:55] did you read the rest? [22:25:06] Krinkle: :) [22:25:28] Krinkle: the xkcd ? I don't understand it :( [22:25:36] hashar: not the xkcd [22:25:40] "hashar: Next up, moving /var/lib/jenkins to ssd and moving workspaces back under jenkins/jobs/ ?" [22:25:41] ;-D [22:25:49] " I find this /workspaces//* rahter confusing" [22:26:03] ": the Zuul git repos and workspaces need to be on the same device" [22:26:15] honestly I don't have the time to bike shed about it [22:26:18] maybe tomorrow :-] [22:26:24] I'm not bike shedding [22:26:33] I'm proposing additional migration in the future [22:26:40] Change abandoned: PleaseStand; "Turns out that the latest version of Scribunto also depends on the recent change to Language::sprint..." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/59637 [22:26:41] but you missed part of it, again. [22:26:45] I'll repeat it tomorrow. [22:26:49] yeah please [22:26:52] I am too tired [22:26:58] and monitoring a few background processes [22:31:52] New patchset: Mwjames; "Use SMW_OUTPUT_WIKI for imgCaption instead" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/59750 [22:35:24] New patchset: Alex Monk; "Set the GlobalBlock form to submit to the special page" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/59751 [22:35:58] New patchset: Alex Monk; "Set the GlobalBlock form to submit to the special page" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/59751 [22:36:14] New patchset: Krinkle; "Add .jshintrc" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [22:38:13] Change abandoned: Worden.lee; "Abandoning this change, since it was improved in https://gerrit.wikimedia.org/r/50598 (and merged)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/48092 [22:38:16] New review: Cscott; "I think your FormSpecialPage version doesn't support the http://.../Special:UserById/1234 url, which..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59050 [22:38:43] New review: Krinkle; "* jshintrc: Added missing "browser: true" setting that was causing jshint warning for window undefined" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/59607 [22:40:07] Susan, my patch for this goes to Special:GlobalBlock instead of index.php. Is that okay? I don't think we can do the / bit... [22:43:40] New review: Krinkle; "(2 comments)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59010 [22:44:35] hashar: status? Im looking to enable jshint for an extension later [22:45:06] Krinkle: stil reconfiguring [22:45:20] Krinkle: I found yet another cause of slowness for JJB [22:45:35] Susan, oh actually I have found a way. nevermind [22:45:39] Krinkle: whenever you update a job via the API, it reparse the whole build history :/ [22:45:46] New patchset: Alex Monk; "Set the GlobalBlock form to submit to the special page" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/59751 [22:45:55] hashar: hehe [22:45:55] New review: Yury Katkov; "guys! The documentation still doesn't work!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/29882 [22:45:56] Krenair: As long as you construct a valid title, you should be able to redirect to anywhere. [22:46:03] hashar: It's like they're making it slow for kicks [22:46:08] Even outside the wiki if you really wanted to. [22:46:16] I'm not redirecting anywhere. [22:46:28] Ah, I see. [22:46:33] I'm just not submitting to $wgScript and setting title with a hidden input [22:46:37] Krinkle: 21 jobs still [22:46:47] setting the form action to $this->getFullTitle()->getLocalURL() instead [22:47:07] hashar: https://github.com/whatthejeff/fab-phpunit-resultprinter [22:47:14] hashar: awesomeness https://github.com/whatthejeff/nyancat-phpunit-resultprinter [22:47:28] New review: MZMcBride; "Thank you for working on this. :-)" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/59751 [22:47:32] Krinkle: fabulous! [22:47:44] Krenair + Krinkle are too similar. [22:47:48] Someone needs to /nick. [22:47:51] :P [22:47:52] hashar: I like the nyancat one, because it saves vertical space [22:48:18] Susan, also I see this weird issue on the globalblock page which involves the 'other' options for expiry and reason. Will look into fixing that as well [22:48:23] hashar: Instead of endless repeating .....\n ... it simply increases a number and keeps rotating the artwork. [22:48:42] Krenair: You're wonderful. Thanks for poking at the extension. The stewards will really appreciate it. [22:48:59] I looked at installed GlobalBlocking locally last night very briefly. [22:49:02] Susan: 3 characters, 3 key strokes, that's all I ask. [22:49:12] before the tab is being hit :) [22:49:28] (the right keys of course :P ) [22:49:45] You can do "Kr" and tab a few times as well. [22:49:52] fancy [22:49:59] easy to screw up though [22:50:01] Some clients know which nick last spoke. [22:50:03] Yeah, for sure. [22:50:04] in my client the order isn't consistent [22:50:17] if I say something while you're not looking [22:50:30] Ah, LimeChat. [22:50:38] Susan: Don't look under my dress please. [22:50:42] You love it. [22:52:06] New patchset: Aude; "Update Wikibase, DataValues and Diff" [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59667 [22:52:13] New patchset: Adamw; "civi required fields have changed." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59752 [22:52:40] New review: Siebrand; "Thanks for the additions, Timo." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/59607 [22:54:56] New patchset: Mattflaschen; "Add a button to request a new fancy captcha" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/44376 [22:55:54] New review: Siebrand; "(2 comments)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59010 [22:56:14] Susan: So you're on Mac too? Didn't know. [22:56:27] yikes though ``EOL: MacIrssi is no longer actively maintained.`` [22:56:38] I used to use that. [22:57:29] New review: Siebrand; "Can't be merged in the current state. Needs fixing of merge conflicts." [mediawiki/extensions/UploadWizard] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/3808 [22:57:29] New patchset: Mwjames; "Use outputMode to determine imgCaption text" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/59750 [22:57:48] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59752 [22:59:06] New patchset: Krinkle; "Add HTML5 drag and drop support" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [22:59:49] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/59750 [23:00:36] New review: Krinkle; "Use comments for discussion and progress. Commit message should represent current state of the chang..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [23:01:24] New review: Siebrand; "Doesn't merge. Needs rebase." [mediawiki/core] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/39862 [23:02:25] New patchset: Siebrand; "Customizable headings for feedback responses" [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/49471 [23:03:26] New patchset: Mwjames; "Add SMW\HooksTest class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [23:03:40] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59607 [23:03:53] New review: Krinkle; "Adding a jshint job to this project now." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59632 [23:05:01] Krinkle: Yeah, I've been on a Mac since... 1995. :-) [23:05:08] And, yeah, MacIrssi is EOL'd. :-( [23:05:14] I'm not sure what I'm gonna switch to next. [23:05:17] Maybe Textual. [23:05:20] New patchset: Krinkle; "Gitignore: Add /ssd, which has been mounted over here at gallium" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/59754 [23:05:22] But not until MacIrssi breaks. [23:05:24] New patchset: Aude; "Update Wikibase with ORM backport patch" [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59755 [23:05:45] * hashar jenkins is back up [23:05:48] I'm just glad to no longer be using Colloquy. ;-) [23:05:53] New review: Siebrand; "(1 comment)" [mediawiki/extensions/MoodBar] (master) C: -1; - https://gerrit.wikimedia.org/r/49471 [23:06:12] Susan: Oh yeah, I definitely liked Colloquy, but it became too unmaintained and messy. [23:06:23] It's great if you get on IRC once a month. [23:06:30] Yippie, build fixed! [23:06:30] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #11: FIXED in 4 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/11/ [23:06:36] But if you live on IRC, it's got too many quirks. [23:06:48] I think bug 189 is gonna be resolved soon. \o/ [23:06:51] I do however use a homemade theme for LimeChat that takes some of the bits I liked from Colloquy [23:07:13] Reported: 2004-08-22 14:57 UTC [23:07:27] Susan: http://cl.ly/image/3v3s2e1V1P1t [23:07:28] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf1) - https://gerrit.wikimedia.org/r/59741 [23:07:28] I find Colloquy's default theme (orange + red) to be atrocious. [23:07:38] Plus the background image... [23:07:38] I had to customize it heavily to be usable. [23:07:41] Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf2) - https://gerrit.wikimedia.org/r/59742 [23:07:53] Hah, you imported those colors. [23:08:00] I like the control of it and the non-monospace font. [23:08:12] channel/server separated from nicks [23:08:31] that was one thing in Colloquy, the sidebar was too small. it never fit. So everything is collapsed, but then you can't see the nicks. [23:08:35] and lots of bugs yeah [23:08:37] unstable [23:08:39] too slow [23:08:57] couldn't handle connecting to a bouncer on monday morning after detaching for the weekend [23:09:00] just crashed [23:09:04] Yeah, I hit that a lot. [23:09:07] I used to flood off constantly. [23:09:17] Or when there was a netsplit, it would just lock up for ten minutes. [23:09:38] As I said, it's fine for occasional IRC use, but it wasn't built for serious IRC use. [23:09:50] what I like about both LimeChat and Colloquy is that they're HTML/CSS based which makes them easy and fun to customise [23:09:51] New patchset: Adamw; "only append zip+4 if it exists" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/59758 [23:09:57] hmm, the logging schema is rather odd - recording which page id the event happens to, but yet being used for things that don't have page ids... [23:10:12] I feel more in control with LimeChat, and not being aware of it being there. I'm just doing what I want to do [23:10:22] https://github.com/Krinkle/limechat-theme-colloquy [23:10:24] New review: Siebrand; "Can't be merged. Needs updating." [mediawiki/extensions/UploadWizard] (master); V: -1 C: 1; - https://gerrit.wikimedia.org/r/52628 [23:10:25] (if you're interested) [23:10:54] http://pruebita.com/macirssi-2013-04-17.png [23:11:05] I was stalking you on GitHub just yesterday. ;-) [23:11:16] I've been seeing more dotfiles repos lately. [23:11:42] Oh, I love snooping around those things [23:11:48] New patchset: Mwjames; "Add SMW\HooksTest class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [23:11:53] I recently cooked up function dotfiles-pull() [23:12:02] I considered making one myself, but I don't customize very much, TBH. [23:12:13] And all the shit I do customize, I probably wouldn't want on GitHub. [23:12:20] Mostly server aliases. [23:12:23] It is pretty neat. It fetches latest from github, but without affecting work tree (for security reasons as well). Then generate a diff locally and put up a prompt. [23:12:39] What's it written in? [23:12:43] bash [23:12:50] * Susan shudders. [23:13:10] bash scripting gives me chills. [23:13:11] https://github.com/Krinkle/dotfiles/blob/master/modules/functions.bash#L93 [23:13:19] its quite neat for things like this [23:13:25] very expressive and minimalistic [23:13:45] * Susan nods. [23:14:00] I don't oppose it, I just always hit that point where I'm like "Jesus, why didn't I just do this in a proper programming language." [23:14:06] I get annoyed at bash's limitations. [23:14:56] New review: Siebrand; "I fail to see how this helps the usability of the upload use case." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/53716 [23:15:22] Never underestimate the sizepower of my bear clawsbash. [23:15:47] I always underestimate its limitations. ;-) [23:15:57] its limitations? [23:16:17] String manipulation. [23:16:36] And I find the syntax awkward and difficult to debug. [23:16:54] New patchset: Mwjames; "Add SMW\HooksTest class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [23:17:18] A double negative is confusing, except when it's not misunderstood. [23:17:25] New review: Siebrand; "Can you please add tests for the new code paths you added?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53740 [23:17:28] Susan, on Special:GlobalBlock when you specify a non-other expiry, the 'other expiry' row is supposed to hide. But only the input box does [23:17:38] Looks like because this uses MediaWiki's Xml::buildForm, we can't change the ids of the table rows without changing the message key used [23:17:58] It's only deployed to Meta-Wiki and used by power-users. [23:18:07] So if you need to change messages or whatever, it's minimally disruptive. [23:20:02] It feels weird to be active in here. [23:20:13] I haven't spoken much in here in years. [23:20:29] New review: Krinkle; "Also reverting a pointless change I made earlier. The pipelines are already sorted server side. It j..." [integration/docroot] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59754 [23:20:29] Change merged: Krinkle; [integration/docroot] (master) - https://gerrit.wikimedia.org/r/59754 [23:21:18] ""The beauty of the normal names is that they sort: check, gate, post.""" ~~ krinkle [23:21:26] I enjoy your Gerrit comments :-] [23:21:32] :-) [23:21:35] Yippie, build fixed! [23:21:36] Project browsertests-test2.wikipedia.org-linux-firefox build #266: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/266/ [23:21:51] jdlrobson: I just pushed the centralnotice change you made yesterday [23:21:59] mwalker: \o/ [23:22:02] on en.wiki? [23:22:04] so if you have a moment to tell me if it's behaving [23:22:10] hashar: Thanks :) [23:22:12] wmf1 and wmf2 so -- yes! [23:23:21] cool [23:23:45] New patchset: Mwjames; "Add SMW\HooksTest class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [23:24:47] New patchset: Alex Monk; "Fix hiding of other expiry input row" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/59760 [23:25:06] New review: Hashar; "recheck" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/52628 [23:25:55] There's a message key rename there, not sure if I need to notify the i18n guys about that... [23:26:02] New patchset: Krinkle; "JSHint: Vote in Echo, add job for UniversalLanguageSelector" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59762 [23:26:16] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/59762 [23:27:50] mwalker: seems to be working as expected on test wiki [23:27:57] just generated a request to https://test.m.wikipedia.org/wiki/Special:BannerRandom?userlang=en&sitename=Wikipedia&project=test&anonymous=true&bucket=0&country=US&device=android&slot=14 [23:28:23] woot [23:28:25] New patchset: Krinkle; "Split out notification emails to a separate from address so they can be configured as specified for launch." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59640 [23:28:39] New review: Siebrand; "L10n/i18n LGTM" [mediawiki/extensions/GlobalBlocking] (master) C: 1; - https://gerrit.wikimedia.org/r/59760 [23:28:46] mwalker: although notice https://meta.wikimedia.org/wiki/Special:BannerRandom?userlang=en&sitename=Wikipedia&project=wikipedia&anonymous=true&bucket=1&country=US&device=&slot=21 is occurring on en wiki [23:28:56] (empty device string) [23:29:03] hurm; that's curious [23:29:06] New patchset: Krinkle; "Update .jshintrc" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59632 [23:29:18] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59180 [23:29:31] mwalker: mw.config.get( 'wgMobileDeviceName' ) is currently null on en.wiki [23:29:31] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53771 [23:29:40] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58913 [23:29:40] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59668 [23:29:44] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59654 [23:29:48] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59461 [23:29:52] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57529 [23:29:56] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58471 [23:30:03] New review: Siebrand; "recheck" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59183 [23:30:12] New patchset: Krinkle; "Fix logging in user language" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [23:30:44] jdlrobson: iy [23:30:51] it's correctly replacing blank with desktop for me [23:30:57] what browser are you usign? [23:32:33] New patchset: Bsitu; "Add execption to email job so error will be tracked" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59764 [23:33:37] New review: Krinkle; "Lots of failures to fix (or files to add to .jshintignore). But gotta start somewhere." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59632 [23:33:37] Change merged: Krinkle; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/59632 [23:34:07] mwalker: https://en.m.wikipedia.org/wiki/Ghost_town, beta, chrome [23:35:09] New patchset: Alex Monk; "Add HTML5 drag and drop support" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [23:35:35] That's odd. Gerrit just said that had a merge conflict on rebase. I downloaded it and ran git pull --rebase origin master and it completed without any manual fixes [23:35:38] New patchset: Bsitu; "Add execption to email job so error will be tracked" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/59764 [23:35:57] siebrand: recheck will execute pipeline. If you want to trigger unit tests, rebase or change commit message. [23:36:08] Or in your case, re-do CR+2 so it will do the gate and submit. [23:36:23] (click [x] at your name and publish CR+2) [23:36:52] k [23:41:44] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/59183 [23:45:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58471 [23:47:38] New patchset: Brian Wolff; "Add identifying info (img_timestamp and img_sha1) to upload log." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59766 [23:48:27] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57529 [23:49:00] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #300: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/300/ [23:51:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59654 [23:53:59] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/59715 [23:54:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59461 [23:58:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59668