[00:00:49] New review: Tim Starling; "Reporting a bug against parsekit seems like wishful thinking. It's hard to imagine what could be don..." [mediawiki/tools/code-utils] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/57829 [00:00:49] Change merged: Tim Starling; [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/57829 [00:06:31] New review: preilly; "Yeah, that code seems a little heavy handed for sure. ;-)" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/57829 [00:08:39] New review: Tim Starling; "This will cause problems when parsing any file with a class called "Args". Some more distinctive nam..." [mediawiki/tools/code-utils] (master) C: -1; - https://gerrit.wikimedia.org/r/57830 [03:03:49] TimStarling: what automated failure are you referring to? [03:05:25] in the PHP client there is _dead_host() etc. [03:05:32] is that not in the PECL one? [03:05:56] it is not documented, though there is an experimental server ejection option [03:06:01] we don't enable that though [03:06:16] it also could cause consistency problems with flapping [03:06:31] sure, and it did when we used the PHP client [03:06:36] when asher and I last talked about this, the idea would be to eventually have two twemproxy pools [03:06:41] one that ejects and one that doesn't [03:06:49] it also prevented some more serious issues [03:07:47] immutable, short-lived, and things with e-tags/timestamps checked against the DB could go in the former, and other stuff in the later [03:08:20] realistically the message cache would go in that first category [03:09:16] anyway, I think the pecl one will fail fast for servers that get a lot of errors [03:09:23] I've seen log messages to that effect [03:10:04] Memcached::OPT_AUTO_EJECT_HOSTS [03:10:18] that would be for actual failover [03:10:48] anyway, I'd like this get merged fairly soon since we are serving thousands of exception messages to users every day [03:11:08] +to [03:11:14] so how helpful would the 'test' key be? [03:11:20] seems of limited use [03:11:37] like I said on gerrit, it is just for when there is a single memcached host [03:12:21] maybe I could add a pingKeyServer( $key ) function to bagostuff some day [03:14:08] sure [03:22:01] TimStarling: are you amending? [03:22:54] I did another two patchsets already, is that not enough? [03:23:26] lol [03:24:20] it's not too much unless you have to scroll down past the patch sets to see any diff info [03:37:29] TimStarling: I can do it [06:35:00] New review: Krinkle; "The negative look-ahead only works as a single item. If you separate it, it will match and thus brea..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/58273 [07:55:11] New patchset: Hashar; "macro to wipe workspace" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58467 [07:55:11] New patchset: Hashar; "mediawiki-core-code-coverage now wipe the workspace" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58468 [07:56:15] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58467 [07:56:23] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58468 [08:05:04] New review: Krinkle; "I know parsekit has issues with global functions having the same name in lint.php and the compiled f..." [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/57830 [10:43:15] !bug 46723 [10:43:15] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=46723 [10:58:59] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/58483 [12:40:48] Project en.m.wikipedia.beta.wmflabs.org-MobileFrontend-linux-firefox build #3: FAILURE in 3 min 17 sec: https://wmf.ci.cloudbees.com/job/en.m.wikipedia.beta.wmflabs.org-MobileFrontend-linux-firefox/3/ [12:40:49] * zeljko.filipin: Wait until login page opens [12:40:49] * zeljko.filipin: Removed unnecessary step [12:40:50] * zeljko.filipin: Fixed Rake task so it reports failures properly [12:40:50] * zeljko.filipin: Update to Cucumber 1.2.5 since 1.2.4 was yanked [12:40:51] * zeljko.filipin: Upgrade to the latest stable version of Firefox [12:40:51] * l10n-bot: Localisation updates from http://translatewiki.net. [12:40:52] * jrobson: Regression: Add handshake javascript module [12:40:52] * maxsem.wiki: Make device modules mobile-targeted [12:46:27] Project en.m.wikipedia.beta.wmflabs.org-MobileFrontend-linux-android build #5: FAILURE in 9 min 38 sec: https://wmf.ci.cloudbees.com/job/en.m.wikipedia.beta.wmflabs.org-MobileFrontend-linux-android/5/ [12:46:27] * jrobson: Regression: Stop low res main menu icon from 404ing due to move [12:46:27] * zeljko.filipin: Added option to run mobile frontend tests at en.m.wikipedia.beta.wmflabs.org [12:46:28] * jrobson: Urgent fix: Provide greater expect-ations (fix breaking tests) [12:46:28] * zeljko.filipin: It is useful to sometimes debug problems in Firefox [12:46:29] * maxsem.wiki: Remove disable_zoom now that it's unused [12:46:30] * jrobson: Bug 41519: Only request token when clicking the star [12:46:30] * jrobson: Story 400: Deal with first time user upload [12:46:30] * jrobson: Remove tumbleweed code for WLM banner [12:46:31] * jrobson: Minor QUnit test fixes [12:46:32] * jrobson: Rename jsEnabled class to client-js to be consistent with desktop [12:46:32] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:33] * jrobson: Go more ResourceLoader native for head scripts and styles [12:46:33] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:34] * maxsem.wiki: rm unused variables [12:46:34] * jgonera: Add missing dependency [12:46:34] * jrobson: Use embed the correct way, fix Nokia N95s [12:46:35] * arichards: Change diff colors after design input [Alpha] [12:46:46] * jgonera: Don't add more than one photo upload button [12:46:47] * maxsem.wiki: WIP: Avoid SkinMobile-specific functions and properties [12:46:47] * jrobson: Bring watch star css/html markup closer to desktop [12:46:48] * arichards: Un-skip MobileContextTest::testUpdateDesktopUrlHost [12:46:48] * jrobson: Moving zero specific code over to Zero [12:46:49] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:49] * zeljko.filipin: Run parallel_tests with bundle exec [12:46:50] * zeljko.filipin: Escaped all regular expressions [12:46:50] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:51] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:51] * zeljko.filipin: Updated Ruby gems [12:46:52] * zeljko.filipin: Wait until login page opens [12:46:52] * zeljko.filipin: Wait until login page opens [12:46:53] * zeljko.filipin: Removed unnecessary step [12:46:53] * jrobson: Disable upload CTA when $wgMFEnablePhotoUploadCTA is false [12:46:54] * maxsem.wiki: Bug 46480: Enable mobile site module [12:46:54] * l10n-bot: Localisation updates from http://translatewiki.net. [12:46:55] * jrobson: Make special pages declare their modules [12:49:11] Project en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-ipad build #4: FAILURE in 8 min 21 sec: https://wmf.ci.cloudbees.com/job/en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-ipad/4/ [12:49:11] * jrobson: Regression: Stop low res main menu icon from 404ing due to move [12:49:11] * zeljko.filipin: Added option to run mobile frontend tests at en.m.wikipedia.beta.wmflabs.org [12:49:12] * jrobson: Urgent fix: Provide greater expect-ations (fix breaking tests) [12:49:12] * zeljko.filipin: It is useful to sometimes debug problems in Firefox [12:49:13] * maxsem.wiki: Remove disable_zoom now that it's unused [12:49:13] * jrobson: Bug 41519: Only request token when clicking the star [12:49:14] * jrobson: Story 400: Deal with first time user upload [12:49:14] * jrobson: Remove tumbleweed code for WLM banner [12:49:15] * jrobson: Minor QUnit test fixes [12:49:15] * jrobson: Rename jsEnabled class to client-js to be consistent with desktop [12:49:16] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:16] * jrobson: Go more ResourceLoader native for head scripts and styles [12:49:17] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:17] * maxsem.wiki: rm unused variables [12:49:18] * jgonera: Add missing dependency [12:49:18] * jrobson: Use embed the correct way, fix Nokia N95s [12:49:19] * arichards: Change diff colors after design input [Alpha] [12:49:35] * jgonera: Don't add more than one photo upload button [12:49:35] * maxsem.wiki: WIP: Avoid SkinMobile-specific functions and properties [12:49:35] * jrobson: Bring watch star css/html markup closer to desktop [12:49:35] * arichards: Un-skip MobileContextTest::testUpdateDesktopUrlHost [12:49:35] * jrobson: Moving zero specific code over to Zero [12:49:35] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:35] * zeljko.filipin: Run parallel_tests with bundle exec [12:49:35] * zeljko.filipin: Escaped all regular expressions [12:49:35] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:35] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:35] * zeljko.filipin: Updated Ruby gems [12:49:35] * zeljko.filipin: Wait until login page opens [12:49:36] * zeljko.filipin: Wait until login page opens [12:49:36] * zeljko.filipin: Removed unnecessary step [12:49:37] * jrobson: Disable upload CTA when $wgMFEnablePhotoUploadCTA is false [12:49:37] * maxsem.wiki: Bug 46480: Enable mobile site module [12:49:38] * l10n-bot: Localisation updates from http://translatewiki.net. [12:49:38] * jrobson: Make special pages declare their modules [12:53:36] Project en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-iphone build #4: FAILURE in 7 min 8 sec: https://wmf.ci.cloudbees.com/job/en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-iphone/4/ [12:53:36] * jrobson: Regression: Stop low res main menu icon from 404ing due to move [12:53:37] * zeljko.filipin: Added option to run mobile frontend tests at en.m.wikipedia.beta.wmflabs.org [12:53:37] * jrobson: Urgent fix: Provide greater expect-ations (fix breaking tests) [12:53:38] * zeljko.filipin: It is useful to sometimes debug problems in Firefox [12:53:38] * maxsem.wiki: Remove disable_zoom now that it's unused [12:53:39] * jrobson: Bug 41519: Only request token when clicking the star [12:53:39] * jrobson: Story 400: Deal with first time user upload [12:53:40] * jrobson: Remove tumbleweed code for WLM banner [12:53:40] * jrobson: Minor QUnit test fixes [12:53:41] * jrobson: Rename jsEnabled class to client-js to be consistent with desktop [12:53:41] * l10n-bot: Localisation updates from http://translatewiki.net. [12:53:42] * jrobson: Go more ResourceLoader native for head scripts and styles [12:53:42] * l10n-bot: Localisation updates from http://translatewiki.net. [12:53:43] * maxsem.wiki: rm unused variables [12:53:43] * jgonera: Add missing dependency [12:53:44] * jrobson: Use embed the correct way, fix Nokia N95s [12:53:44] * arichards: Change diff colors after design input [Alpha] [12:53:55] * jgonera: Don't add more than one photo upload button [12:53:56] * maxsem.wiki: WIP: Avoid SkinMobile-specific functions and properties [12:53:56] * jrobson: Bring watch star css/html markup closer to desktop [12:53:57] * arichards: Un-skip MobileContextTest::testUpdateDesktopUrlHost [12:53:57] * jrobson: Moving zero specific code over to Zero [12:53:58] * l10n-bot: Localisation updates from http://translatewiki.net. [12:53:58] * zeljko.filipin: Run parallel_tests with bundle exec [12:53:59] * zeljko.filipin: Escaped all regular expressions [12:53:59] * l10n-bot: Localisation updates from http://translatewiki.net. [12:54:00] * l10n-bot: Localisation updates from http://translatewiki.net. [12:54:00] * zeljko.filipin: Updated Ruby gems [12:54:01] * zeljko.filipin: Wait until login page opens [12:54:01] * zeljko.filipin: Wait until login page opens [12:54:02] * zeljko.filipin: Removed unnecessary step [12:54:02] * jrobson: Disable upload CTA when $wgMFEnablePhotoUploadCTA is false [12:54:03] * maxsem.wiki: Bug 46480: Enable mobile site module [12:54:03] * l10n-bot: Localisation updates from http://translatewiki.net. [12:54:04] * jrobson: Make special pages declare their modules [12:54:09] * MaxSem sends wmf-selenium-bot a ray of diarrhea [12:56:56] MaxSem: I am working on selenium tests, they should fail less often in the next few days :) [12:57:07] apologies for the spam [12:57:14] :) [12:57:29] New patchset: Hashar; "stop cleaning mw/core workspace to save I/O" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58502 [12:59:56] New review: Hashar; "not deployed, will look at that later on." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/58502 [14:20:47] anyone here familiar with jQuery UI position method? [14:23:28] zeljkof: oh beta got broken this afternoon. Gluster was not server some files [14:23:32] zeljkof: that is fixed though [14:24:03] hashar: I have noticed tests failing, did not have the time to investigate yet [14:24:15] I will rerun the tests then [14:54:53] Sales Account Code, ASA, ASALES, d, (a.U_SRCKEY=d.S_ACCKEY) left join ASTDTLS g on (a.U_TRANKEY=g.U_TRANKEY), S_ACCNO, , T, 10, 200, SalesAccount, 11, 0, 0, , [14:54:54] SQL! [14:55:00] The best thing to store in database tables [16:27:12] AaronSchulz: Any chance you could do todays deployment? I'm not going to be around at the time. CC greg-g [16:43:56] <^demon|sick> Reedy: What timeframe? I'll be around. [16:51:57] ^demon|sick: just to make sure, https://bugzilla.wikimedia.org/show_bug.cgi?id=35497 isn't something that's being worked on by anyone else atm? [16:52:52] <^demon|sick> No. I've been hoping someone upstream would finish his plugin he was writing, but I've heard nothing in like a month and a half. [16:53:36] Wikimedia Language Engineering team office hours in a few minutes in #wikimedia-office. Wall of text: http://lists.wikimedia.org/pipermail/wikimedia-l/2013-April/125006.html [16:54:49] ^demon|sick: do you have pointers to an upstream bug? [16:55:06] ^demon|sick: I wrote a small script that does it, thinking of polishing it off this weekend. Making sure I'm not duplicating work. [17:24:49] Reedy: so, he's not here yet, but I hope he'll be here soon as he's on point for the Redis stuff today, if all goes according to plan [17:25:23] oh, there's Aaron|home now, missed the join [17:25:31] 16:27 < Reedy> AaronSchulz: Any chance you could do todays deployment? I'm not going to be around at the time. CC greg-g [17:39:03] <^demon|sick> greg-g: As I said, I'll be around too if you guys need another hand. [17:41:02] ^demon|sick: as, missed that, thanks man [17:41:05] s/as/ah/ [17:42:14] <^demon|sick> Long as we're not having any pie-eating contests or other GI-intensive tasks, I'm here :) [17:43:53] * Nemo_bis worries for ^demon|sick [17:58:37] ^demon|sick: just don't pass out half-way through the deploy [17:58:51] <^demon|sick> zzzzz...wha? [17:59:15] so, 2 minutes until the window starts, Aaron|home can you do it (along with the Redis-related stuff)? [17:59:50] ^demon|sick: pie eating? [17:59:56] <^demon|sick> nom nom. [18:00:11] ^demon|sick, you take the pie [18:00:15] the other people eat it [18:00:28] you're too sick for that... ;) [18:07:50] greg-g: would it be possible to get a CentralAuth maintenance script update deployed during the 11a-1a window by whomever does the deploy? [18:39:58] hey Nikerabbit [18:40:12] Nikerabbit: do you remember where the memcached pecl setting was? [18:40:16] for the too long keys? [18:41:07] YuviPanda: i don't think it was setting [18:41:22] oh? so pecl memcached is supposed to automatically handle this? [19:33:01] chrismcmahon, was it you who edited QA and QA/Roadmap? Just checking [19:33:52] hi qgil yes, linked to a new page from there [19:34:42] chrismcmahon, I know I'm a pita with the editign as registered user thing, but please understad that it's not easy what to think when you see an IP address doing this: https://www.mediawiki.org/w/index.php?title=QA/Roadmap&curid=108071&diff=672047&oldid=652973 [19:34:56] yes [19:35:03] (and I could type better English, yes) [19:36:36] chrismcmahon, why don't you simply login and set the option "remember me for nn days"? [19:36:53] ^demon|sick: Where can one find the source for gerrit-wm? cscott and I are musing about making some improvements. [19:37:14] <^demon|sick> puppet repo! [19:37:15] but ok, promise to myself that I won't bother you about this again :) [19:37:18] <^demon|sick> files/gerrit/hooks/* [19:37:19] * marktraceur nods [19:37:20] Ta [19:37:40] <^demon|sick> If you're at it, take a peek at BZ, there's a number of things filed regarding gerrit-wm [19:37:53] marktraceur: aren't you in a sprint right now? [19:37:58] ^demon|sick: I'll tell cscott, I think he's just looking to self-itch now [19:38:01] greg-g: Little bit [19:38:07] :) [19:38:23] marktraceur: self itch? or self scratch? [19:38:37] greg-g: self-(verb) [19:38:39] Whatever. [19:38:46] :P [20:54:07] ^demon, gerrit is sooooo slowwww [21:40:25] How is $wgDBname set on our production systems ? [21:41:00] xyzram: wmf-config/multiversion [21:41:08] Based on incoming hostname. [21:41:33] Since we host all wikis (*.wikipedia.org, *.wiktionary.org) from the same source code. [21:42:26] xyzram: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L126 [21:44:16] Krinkle: thanks. So what would it be for uawikimedia ? [21:44:51] xyzram: All dbnames: https://github.com/wikimedia/operations-mediawiki-config/blob/master/all.dblist [21:45:08] xyzram: Also, if you open a url in your browser, run this in the javascript console: mw.config.get('wgDBname'); [21:45:14] That'll tell you without a doubt [21:45:37] Ok, thanks. [21:45:45] generally it is subdomain + projectname [21:46:00] except for wikipedia which is just 'wiki' (for historic reasons, when wikipedia was the only project, renaming databases is hard) [21:52:32] Krinkle: Is a 'project' just a name like wikemedia, wiktionary etc. ? [21:52:54] Projects: https://www.wikimedia.org/ [21:53:41] chapter wikis and wikimedia-general wikis (nl.wikimedia.org, ua.wikipeida.org but also commons and meta) are in the same project, which is technically wrong [21:53:55] chapter wikis and wikimedia-general wikis (nl.wikimedia.org, ua.wikimedia.org but also commons and meta) are in the same project, which is technically wrong [21:54:23] But is easier to work with behind the scenes as they are both under *.wikimedia.org [21:54:41] perhaps one day they'll be separated, but its just a behind-the-scenes detail. [21:55:06] Ok I follow the general notion of a project, but concretely, is a project a particular set of files, directories, etc. (from a dev perspective) ? [21:56:16] xyzram: From a dev perspective projects is just a way to simplify configuration of individual wikis [21:56:45] e.g. instead of configuring de.wikipedia en.wikipedia completely separate they can both be configured as 'wikipedia'. [21:56:55] Still individual wikis can override settings [21:57:17] basically a project is a root domain match, a base logo and an entry on wikimedia.org portal. [21:57:41] Ah, ok that's the sort of definition I was looking for. [21:57:43] and a social culture / topic / wiki page namespaces, but that's beyond dev perspective. [21:58:04] Watch out, virus spreading. [21:58:19] ^demon|sick: You alright? [21:58:33] So, given a DB, we can say uniquely which project it belongs to ? [21:58:41] Yes [21:58:42] <^demon|sick> Krinkle: Stomach bug. [21:59:05] Ah, regression and upstream to body control. Nasty one. [21:59:07] ;-) [21:59:16] xyzram: If I may, what's your interest? [21:59:53] xyzram: Ah, I remember now. [22:00:07] Krinkle: Just trying to understand our code and terminology better after being buried in lsearchd for a while. [22:00:17] Yeah [22:00:28] The proximate interest is trying to fix a bug in the Ukraine wiki [22:00:31] I didn't recognize the irc nick so I wasn't quite sure what your angle is. [22:00:44] But I remember now that I mentally separated 'xyz' from 'ram' [22:00:44] Honorable angle :-) [22:00:56] ram@wm.o [22:01:27] Yes the xyz confuses people but ram was already in use. [22:02:54] new nick for freenode? Or been using it elsewhere? [22:03:44] !core [22:03:44] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tree [22:03:50] !dump [22:03:50] For information on how to get dumps from Wikimedia Wikis, see http://meta.wikimedia.org/wiki/Data_dumps . For a how-to on importing dumps, see https://www.mediawiki.org/wiki/Manual:Importing_XML_dumps . [22:03:54] @dump [22:04:10] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [22:04:10] Krinkle: Invalid arguments [22:04:54] @replag all [22:04:55] Krinkle: [s1] db1017: 0s, db1049: 0s, db1050: 0s, db1051: 0s, db1052: 0s, db1056: 0s, db1058: 0s; [s2] db1034: 0s, db1002: 0s, db1009: 0s, db1018: 0s; [s3] db1019: 0s, db1003: 0s, db1010: 0s, db1035: 1s [22:04:57] Krinkle: [s4] db1038: 0s, db1004: 1s, db1011: 0s, db1020: 1s; [s5] db1039: 0s, db1005: 0s, db1026: 0s, db1021: 0s; [s6] db1006: 0s, db1022: 0s, db1027: 0s, db1040: 0s; [s7] db1041: 0s, db1007: 0s, db1024: 0s, db1028: 0s [22:05:03] just freenode. [22:05:38] !corehack is https://www.mediawiki.org/wiki/Do_not_hack_the_core [22:05:38] Key was added [22:05:46] !hack alias corehack [22:05:46] Created new alias for this key [22:10:20] ^demon|sick: Bad restaurant food ? [22:15:28] <^demon|sick> bad leftovers. [22:19:29] ^demon|sick: I find ginger tea helps some; get well soon. [22:35:59] greg-g: i can has a pane in the lightening deploy window today? [22:53:15] pgehres: just a sigle one, not a double, too expensive [22:53:33] haha, okay [22:54:00] jdlrobson: so tell me what's going on with mobile frontend thing and centralnotice? [22:54:16] if I merge this and deploy tomorrow are we good? [22:55:19] pgehres: what's the deploy, btw :) [22:55:28] the stuff from earlier [22:55:36] CentralAuth maintenance scripts [22:56:04] mwalker: you upstairs? [22:56:04] pgehres: gotcha [22:56:33] no; I'm at home quarantined due to a cold :( [22:57:01] awww [22:57:14] so yeh that should be all. Do you have device support in CentralNotice yet? [22:57:24] it's being pushed tomorrow [22:57:40] sweet :) [22:57:44] i think we're good then [22:57:54] the patch i sent merely removes it from the stable version of the site :) [23:00:18] kk [23:21:09] greg-g: csteipp: deploy done, things look good [23:21:41] cool [23:21:52] Btw, greg-g, is anyone else using the window today? [23:22:13] * csteipp asks to an empty chair... [23:41:02] TimStarling: do have any time to look at https://gerrit.wikimedia.org/r/#/c/57663/ this week?