[00:51:53] New patchset: Krinkle; "ExtraSettings: Remove settings for testswarm/qunit." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/57699 [00:52:18] New patchset: Krinkle; "ExtraSettings: Remove settings for testswarm/qunit." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/57699 [00:52:24] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/57699 [00:53:35] New patchset: Krinkle; "grunt-tasks: Remove unused phplint task." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/57700 [00:53:47] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/57700 [03:17:53] TimStarling: so, is https://gerrit.wikimedia.org/r/#/c/57217/ ok? [03:18:25] yes [03:20:07] * Aaron|home still has https://gerrit.wikimedia.org/r/#/c/49777/ and https://gerrit.wikimedia.org/r/49785 on his dashboard [03:26:19] TimStarling: https://gerrit.wikimedia.org/r/57532 &https://gerrit.wikimedia.org/r/57530 "easy" commits [03:26:47] ok [03:27:54] * Aaron|home feels dirty firing gerrit links around to solicit CR [03:32:31] I was planning on doing some more work on https://gerrit.wikimedia.org/r/#/c/57281/ today [03:32:59] it is a high priority bug assigned to me, after all, and apparently we're sending thousands of exception messages to users daily [03:41:54] "set -e causes untested non-zero exit statuses to be fatal. It is a debugging feature intended for use only during development and should not be used in production code, especially init scripts and other high-availability scripts." [03:42:26] uhhh...what? set -e is great [03:42:35] http://wiki.bash-hackers.org/scripting/obsolete [03:42:39] I don't want my bash scripts just steamrolling errors [03:44:12] http://mywiki.wooledge.org/BashFAQ/105 [03:44:52] "rking's personal recommendation is to go ahead and use set -e, but beware of possible gotchas. It has useful semantics, so to exclude it from the toolbox is to give into FUD. " heh [05:01:19] does the code get verified on submit? [05:01:32] because i just commited something and it didn't [05:01:35] https://gerrit.wikimedia.org/r/#/c/57708/ [05:01:53] nor this -https://gerrit.wikimedia.org/r/#/c/57709/ [05:05:28] New patchset: Jeroen De Dauw; "Run tests for DataValues" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57711 [05:07:13] you probably have to give it +2 before it will run tests [05:07:35] because it just runs them on bare metal, there's no chroot or VM or anything [05:07:50] also some extensions don't have unit tests configured in jenkins [05:07:51] TimStarling, but I don't want it to merge, just to lint [05:08:03] well, use php -l [05:08:15] well, true, but its not me i'm worried about :) [05:08:33] (although i do make mistakes very frequently too ):) [05:08:46] basically i was hoping for core-like service her [05:08:48] here [05:09:02] but just the first jenkins run, not the second [05:10:54] also, TimStarling, do you know how we handle code duplications? [05:11:13] i want code that is almost identical to the eventlogging\remoteschema.php class [05:14:02] just copy it, it's not a big class [05:14:29] maybe if it was 1000 lines I would be scratching my head thinking of a good place to put it, but for 100 lines it doesn't seem worth it [05:14:49] bleh, hate code dups :) [05:14:54] thx [05:32:42] yurik: there is work in core IIRC that roan and trevor did for resourceloader 2 [05:32:46] for a remote resource type [05:33:04] i don't remember why exactly but there was some reason it wasn't usable for my purposes [05:33:19] it may only be that i found out about it too late [05:33:33] ori-l, you mean it does the same as that class? [05:33:45] something very close to it [05:34:02] let me see if i can dig it up [05:36:04] thx! [05:36:25] (i'm fighting php segfault that resets connection without any results :(( [05:38:16] if only i could make debugger break on exception :( [05:40:00] yurik: most of the work is here: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93247#c23660 [05:40:43] Hello, is it safe to configure mediawiki right in the git repo, and commit in it? [05:41:21] Zhaofeng_Li: sure, but it can make it a bit difficult to test changes [05:42:26] ori-l, thanks! will try to make sense of it. Do you know how PHP can stop when it segfaults? [05:42:37] i mean - how to catch that? [05:42:59] the debug log contains a few queries, and than it simply stops [05:43:23] and then it restarts and repeats once [05:43:54] i can set a breakpoint before that, but can't step through [05:49:05] if you're using the vagrant instance you can run 'phpsh -X' to invoke a repl with xdebug [05:49:30] but i need to simulate a request, right? [05:49:32] yes, vagrant [05:50:31] yeah. there's probably a very easy way to do it for bona fide web requests, but i know very little about the zend engine and xdebug [05:51:29] run it under gdb somehow? i think 5.3 has a built in web server or something [05:51:41] sigh, ok, will play around it [05:52:47] if only i could make debugger break on exception :( [05:53:00] easy enough [05:53:35] if by exception you mean segfault [05:53:43] yes [05:54:22] does the segfault happen every time? [05:55:00] yep [05:55:13] TimStarling, i suspect its some silly config setting [05:55:17] can you trigger it with a GET request? [05:55:20] yes [05:55:31] and you're on linux? [05:55:44] i'm on windows, but the php is running on vagrant [05:55:56] with xdebug configured to connect to the host [05:56:05] i.e., linux [05:56:11] right [05:56:27] vagrant = VPS with root access? [05:56:36] yep [05:56:50] virtualbox [05:57:04] ok, so get a random PID from ps -C apache2 [05:57:19] attach to it with gdb -p [05:57:22] bleh, there's tons of them [05:57:24] grr [05:57:31] yes, just a random one [05:57:48] then hit the server with requests for that URL using ab until it happens to segfault in the process you attached to [05:57:59] e.g. ab -n1000 'http://.....' [05:58:05] heh [05:58:21] should i disconnect debugger? [05:58:25] (phpstorm) [05:58:33] installing gdb [05:58:37] doesn't matter [05:58:44] you should also install PHP symbols [05:58:59] is it ubuntu? [05:59:06] yeah, 'php5-dev' should be installed [05:59:29] you need php5-dbg not php5-dev [05:59:55] installing... [05:59:58] * ori-l adds to puppet manifest [06:00:18] ori-l, that's another 100MB [06:00:24] sorry, 51 [06:00:53] you can use ab on the same server, rather than on your desktop, it'll be faster [06:01:19] yep, doing that [06:01:33] (simply because i don't have "ab" on windows ;) [06:02:36] well, not adding it then [06:02:39] segfaults are kind of rare [06:02:54] and this is targetting newbie developers [06:03:38] but am still taking notes :P [06:04:35] bleh, TimStarling , its not working because i need special headers [06:04:38] checking AB [06:05:01] what needs special headers? [06:05:13] my code [06:05:13] its the zero extension [06:05:15] -H'X-Foo: bar' [06:05:19] it only works when special request headers are set [06:05:22] thx [06:07:35] there are ways to do this for bugs that aren't so easily reproducible [06:07:51] you can enable core dumps, either the normal way or via apport [06:08:15] or you can run apache with -X or MaxClients=1 so that the worker PID will be consistent [06:09:02] grr, now i can't repro [06:09:53] after all restarts [06:10:30] btw, TimStarling , have you ever encountered this weird behavior - I used XDEBUG_SESSION_START=ECLIPSE_DBGP as a param from firefox [06:10:44] and afterwards it keeps trying to connect to debugger even when i don't pass it [06:10:54] even after restarting appache [06:11:15] I haven't used that feature of xdebug [06:11:32] in other words GET request will hang until my phpstorm starts listening for connections [06:11:54] are there any processiies that might keep state? [06:11:56] other than apache? [06:12:44] no idea [06:13:06] want to enable core dumps now? [06:13:36] could you tell me how, and i will enable it once its starts repoing again [06:13:40] service php5-fpm restart? [06:14:26] oh, if it's php5-fpm then attaching to apache won't work [06:14:41] ori-l, thanks, so far I have these as part of my "~/r" script -- [06:14:42] sudo /etc/init.d/memcached restart [06:14:43] you would have to attach to PHP [06:14:44] sudo /etc/init.d/apache2 restart [06:14:45] sudo service php5-fpm restart [06:15:16] it changes the way to enable core dumps also [06:15:43] TimStarling, its ok, it might have been some weird x-debug hickup [06:15:53] it kinda works now, will explore [06:16:04] it is fpm, fwiw [06:16:34] thanks though! [06:16:44] i will definitly pick your brains at a later time :) [06:17:00] TimStarling, are you coming to amsterdam? [06:17:07] probably [06:17:15] kul! [06:24:12] ori-l, still, some funny state remains - i had to halt & up vagrant for this to go away [06:24:36] somehow something remembers that I requested xdebug from firefox GET call [06:24:51] and all following requests also try to use debug [06:25:01] which means that it expects debugger to be attached [06:25:09] at the same time, chrome requests go through without that [06:25:22] very strange, and i have seen this before [06:25:28] does xdebug use cookies? [06:25:42] or phpstorm? [06:27:41] hmm... maybe [06:27:50] actually i didn't think of that [06:28:15] but wait, that would also last through reboot [06:28:32] or would not last through service restart [06:31:09] TimStarling, just great, it started doing segfaults the moment i attached debugger [06:31:30] I guess I was wrong then, it did matter [06:32:23] i get the debug break, but i can't do anything - any step command gets ignored and segfaults [06:32:37] bt [06:32:49] oh, this is interesting - if i remove all breakpoints, it works [06:33:10] oh, you mean you get an xdebug break [06:33:25] grr, why can't development be proper, with a normal debugger, and without tamborine dances [06:33:27] it doesn't suprise me that xdebug is generating segfaults [06:33:42] never did before (: [06:33:43] :( [06:34:59] so are you going to report it, fix it or ignore it? [06:35:44] well, since i guess i can repo it every time, i might as well try to report it [06:36:24] should i try to connect dbg to apache2 again? [06:36:57] no, since php is running under fpm [06:37:50] if it's not convenient to reproduce it with ab, then I would just enable core dumps if I were you [06:38:19] how do i do that? [06:38:40] there's a file called /etc/init/php-fpm.conf, right? [06:39:12] add to that the line "limit core unlimited" [06:40:01] btw, xdebug does use a cookie [06:40:04] nope, don't see it [06:40:20] TimStarling, don't see a file like that [06:40:21] is there /etc/init.d/php-fpm? [06:40:25] yurik: ./php5/fpm/php-fpm.conf [06:40:36] er, /etc/php5/fpm/php-fpm.conf [06:40:47] no, not /etc/php5/fpm/php-fpm.conf [06:42:00] "ps -C php-fpm" shows some processes doesn't it? [06:42:08] oh, the init script [06:42:11] is /etc/init.d/php5-fpm [06:42:15] php5-fpm [06:42:37] to /etc/init.d/php5-fpm add near the top: "ulimit -c unlimited" [06:42:39] yep, thanks ori-l , found it [06:43:09] i'm going to shut up now and stop embarrassing myself [06:43:16] then run: /etc/init.d/php-fpm stop [06:43:24] then: killall php-fpm [06:43:41] then: ps -C php-fpm [06:43:46] that should show none still running [06:43:52] then /etc/init.d/php-fpm start [06:44:13] ok [06:44:26] then ps -C php-fpm then pick a random PID [06:44:41] ok [06:44:45] i already ran the crash [06:44:52] so if there is a dump somewhere [06:45:07] then: cat /proc//limits [06:45:28] I am doing this the slow way since it is a bit tricky [06:45:40] ok [06:45:58] core file size unlim [06:46:05] usually core dumps are placed in the current working directory [06:46:21] what would that be for the service? [06:46:35] well, at the time of the segfault, it is probably the wiki root [06:46:46] the directory with index.php in it [06:47:11] so that directory would have to be writable by the user that php-fpm runs as in order for the core dump to work [06:47:49] i might as well make absolutelly everything writable :) [06:48:07] is there a magic command for that? [06:48:21] you can use /proc/sys/kernel/core_pattern to put it somewhere other than the cwd [06:48:26] ori-l, i'm sure it should be set up that way :) [06:48:29] that is probably more secure than making everything writable by everything [06:48:45] tim, its a private, non-accessible VM [06:48:49] without network [06:48:51] its fine :) [06:49:08] but sure, looking [06:49:33] the file contains "core" [06:50:16] echo /tmp/core.%p > /proc/sys/kernel/core_pattern [06:50:34] that would probably work [06:51:06] permissions denied [06:51:11] ran it as sudo [06:51:20] never mind [06:51:25] worked [06:51:41] now its "/tmp/core.%p" [06:51:41] sudo sh -c " /tmp/core.%p > /proc/sys/kernel/core_pattern" [06:51:52] got to go, I think it should work for you now [06:52:01] if not check "man 5 core" [06:52:03] where would they be, in core? [06:52:12] i mean - /tmp/core? [06:52:21] files called /tmp/core.XXXX where XXXX is the PID [06:52:28] thanks tim! [06:52:32] will play around a bit more :) [06:52:34] then run gdb /usr/bin/php-fpm [06:52:37] then bt [06:52:44] ok [06:53:21] sigh, still no files :( [08:27:31] New patchset: Hashar; "Add jobs for mw/ext/Foxway" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [08:27:55] New review: Hashar; "Nice. Will do the Zuul part too :-]" [integration/jenkins-job-builder-config] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/56587 [08:27:55] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [08:31:38] hashar: hi, What is Zuul? [08:32:30] New patchset: Hashar; "triggers for mw/ext/Foxway" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57719 [08:35:17] hashar: it's clear, thanks [08:36:22] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57719 [08:37:10] New review: Hashar; "INFO:jenkins_jobs.builder:Creating jenkins job mwext-Foxway-jslint" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [08:37:21] New review: Hashar; "Zuul triggers https://gerrit.wikimedia.org/r/57719" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [08:43:53] YuviPanda, hello [08:48:34] pastakhov_: Zuul is the system that listen for Gerrit events and triggers Jenkins jobs :-] [09:11:32] hashar: what credentials do I use to log in to integration.wikimedia.org? [09:11:37] the same one as gerrit? [09:12:18] please ignore, I have answered my own question, gerrit it is :) [09:14:52] was't integration.wikimedia.org site at integration.mediawiki.org until recently? [09:15:14] "was't" should be "wasn't" [09:18:09] hashar: what does qa-browsertests-ruby1.9.3lint job do? [09:18:12] https://integration.wikimedia.org/ci/job/qa-browsertests-ruby1.9.3lint/ [09:18:31] just run "ruby -c file_name.rb" for all files in the repo? [09:18:36] zeljkof: yeah we moved everything under wikimedia.org [09:18:55] the ruby1.9.3lint jobs find any file named '.rb' and run ruby -c on them [09:19:02] whenever one fail, the job is a failure [09:19:08] hashar: ok, that is a start [09:19:12] Zuul is bugged right now though [09:19:27] but we should probably find a proper ruby lint in the future [09:20:17] hashar: you should run the ruby -c for mobilefrontent repo too [09:20:21] we have ruby code there too [09:20:43] and by the way, thanks for setting this up :) [09:20:56] can you fill a bug about it please ? [09:20:59] before I forget :-] [09:21:03] sure [09:21:20] under CI component, right? [09:26:03] hashar: done https://bugzilla.wikimedia.org/show_bug.cgi?id=46919 [09:26:18] thx [09:44:40] New patchset: Zfilipin; "last scenario check that moved pages are actually OK" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/57644 [09:45:51] New review: Zfilipin; "I have tagged the scenario @login since logging in is required:" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/57644 [09:46:15] New review: Hashar; "That is now running properly =)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [09:49:49] New review: Zfilipin; "(1 comment)" [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/57644 [10:07:15] New patchset: Hashar; "generic puppet validation macro and job template" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/57723 [10:08:40] New review: Hashar; "$ jenkins-jobs --conf jenkins_jobs.ini update config/ mediawiki-vagrant-puppet-validate" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/57723 [10:08:40] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/57723 [10:08:53] New patchset: Zfilipin; "Updated readme file" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/57724 [10:10:47] New patchset: Hashar; "Have Jenkins check / gate & submit mediawiki/vagrant" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57452 [10:11:15] New review: Hashar; "And the JJB jobs are in https://gerrit.wikimedia.org/r/#/c/57723/" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/57452 [10:11:15] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57452 [10:22:44] ori-l: do you have a minute to chat about vagrant? [10:24:24] zeljkof: um, sure [10:24:36] what's up? [10:26:15] how hard would it be to set up ruby 1.9.3 or 2.0 in the VM? [10:26:43] probably not too hard [10:27:13] what's the use case? [10:27:26] sorry, I have to go [10:27:37] ok [10:27:43] I have another internet connection installed, the tech has just arrived [10:27:47] will ping you later [10:27:53] i'm going to bed :) [10:28:06] via mail or bugzilla then :) [10:46:32] New patchset: Hashar; "ruby 1.9 linter for MobileFrontend" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/57730 [10:49:50] New patchset: Hashar; "trigger ruby1.9 linter on mw/ext/MobileFrontend" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57731 [10:50:11] New patchset: Hashar; "ruby 1.9 linter for MobileFrontend" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/57730 [10:50:34] New review: Hashar; "PS2: use camel case for the extension name." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/57730 [10:50:34] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/57730 [10:51:03] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/57731 [10:56:01] zeljkof: MobileFrontend now has ruby 1.9 linting (was https://bugzilla.wikimedia.org/46919 ) [11:08:17] lunch time [11:20:28] New review: Demon; "Leaving comment to test something, please ignore." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/56399 [12:45:16] ^demon: hello. I have recreated FundraisingEmailUnsubscribe.git bare repo on gallium [12:48:26] New review: Pastakhov; "Yes, it is. Thank you" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/56587 [12:49:02] <^demon> Thanks. Different error now. Lemme look. [12:49:47] <^demon> "error occurred during unpacking on the remote end: index-pack abnormal exit" [12:55:17] :( [13:00:36] New patchset: Zfilipin; "Pairing with Runa, work in progress" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/55266 [13:05:30] <^demon> Well, as long as nobody triggers a ref change on the repo, it won't restart replication again. [13:05:41] <^demon> I killed it before it could re-queue :p [13:05:56] <^demon> It's harmless, just noisy. [13:10:19] <^demon> hashar: I'm out for the weekend. I just sent you an e-mail re: stream-events (just in case). [13:10:23] <^demon> Adios. [13:55:38] leaving out as weel [13:55:40] well [13:55:50] might poke around from time to time to verify Zuul status though [13:55:54] see you on monday [14:20:18] hey qgil [14:20:46] hi Rahul_21 I'm answering your email right now. Please give me 5 mins. :) [14:21:18] qgil, yeaaay.thanks :) [15:25:23] New patchset: Cmcmahon; "forgot to remove unnecessary commented lines" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/57747 [15:48:43] Change merged: Krinkle; [integration/docroot] (master) - https://gerrit.wikimedia.org/r/57496 [16:12:39] New patchset: Sumanah; "Adding basic 'file' feature, step defn, & class file" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/57750 [16:24:48] Krinkle, hello [16:27:32] Rahul_21: Hi [16:28:18] Krinkle, as per as suggestions given to me i have moved the editwarning component from the vector extension into the core [16:28:48] Krinkle, https://gerrit.wikimedia.org/r/#/c/56881/16 [16:31:27] Krinkle, do ping me back if any change is needed [16:32:28] Rahul_21: Sure, I'll check it soon. It's on my dashboard (since I've been added to the Reviewer list) and have been getting notifications of every comment/patchset so far. [16:32:42] Rahul_21: Who assigned it to you if I may ask? [16:33:27] Krinkle, MatmaRex asked me once if i was interestd ,i said ill try and now its done [16:34:40] Krinkle: if you're asking about the bug metadata, i think Rahul assigned it to himself [16:34:59] Vector editwarning integration [16:35:34] and i'm sort of managing the parent (tracking) bug, since i'm apparently the only person that cares [16:36:08] Krinkle, MatmaRex i hope i have not offended any assining policy ,sorry if i have [16:36:33] No problem. [16:36:52] no, it's okay [16:37:16] assigning the bug to yourself when you're working on it seems like a good practice to me, it's immediately clear whose the patch is [16:37:58] Krinkle, MatmaRex there's one problem i have noticed ,only in the firefox browser the warning displays firefox's generic message!rest it works fine on all [16:38:05] It's just that this isn't a very exciting change or something high priority (basically maintenance). Not something I'd give to a volunteer. Not wrong by any means, but there may be things you're more interested in that are more visible to you and are higher on the priority list for someone like me to review. [16:38:50] ^ would be to the person that gave it to you. If you assign it to yourself it's fine of course. [16:39:04] But since you assigned it amongst yourself, no problem :) [16:39:06] Just checking. [16:39:40] i'm not sure how Rahul_21 ended up working on this, but i did advertise https://bugzilla.wikimedia.org/show_bug.cgi?id=45051 around as something reasonably easy for a semi-new developer to play with :) [16:39:43] Krinkle, I can understand you being thoroughly proffessional here,but since i am new to mediawiki,i get to learn alot by doing such stuff [16:39:48] but yeah, it's not very exciting [16:40:42] Rahul_21: That's great. I'm trying to find a balance between priority, visibility and ease. There's high priority easy bugs too. And If you look at it as easy instead of maintenance it makes a lot more sense. [16:40:53] Because as you say, those are a good way to get into the environment. [16:43:11] Krinkle, if you have relatively easy bugs assigned to no1,feel free to tell me ,if it is in my capacity ill surely give it a shot [16:43:44] agh. i need a gerrit expert. [16:44:00] for some reason luis's mail on https://gerrit.wikimedia.org/r/#/c/55524/ is not linked [16:44:10] (the Committer Luis Felipe Schenone Apr 3, 2013 4:55 PM part) [16:44:14] MatmaRex, i had a talk with Luis Filippe Schenone ,he told me i could work on merging the collapsible nav [16:45:27] MatmaRex, luis is apparently is busy ,as he is moving out of his country [17:53:41] Reedy_: https://gerrit.wikimedia.org/r/#/c/57469/1 easy [18:18:49] A new version of git-review is available on PyPI. [18:18:50] Woo.. [18:31:08] Reedy_, at least it installs now [18:50:05] RoanKattouw_away: Krinkle I remember discussion about getting a template engine into RL. Did that ever happen? [18:50:27] No, there might be an open bug for it though. [18:54:21] who modified interwiki/interwiki.cdb on fenari? [18:54:26] chrismcmahon, hi [18:54:59] chrismcmahon, are fine with dedicating the browser testig QA week to ACUX? [18:55:27] chrismcmahon, it's time to announce but I's rather have your explicit confirmation first [19:09:36] qgil: I think so yes [19:10:05] chrismcmahon, ok thanks! [19:12:03] chrismcmahon, any day next week you CAN'T because of moves etc? [19:12:05] qgil: next week should be fine [19:12:07] chrismcmahon, thinking of Wednesday [19:30:13] qgil, https://www.mediawiki.org/wiki/User:Rahul21/Gsoc [19:30:46] qgil: Care to be roped into some talk with a school that wants interesting free projects to work on? [19:36:07] csteipp: are you still working on the rename script? [19:36:53] AaronSchulz: Not at the momnet... it's bellow other priorities right now [19:37:00] But in general, yeah, I'm planning to finish it. [19:37:02] aside from the security fix, it is low on the list? [19:37:26] Security fixes, then OAuth stuff, then Admin tools. [20:32:03] New patchset: Ori.livneh; "Remove ClickTracking extension" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/57770 [20:36:25] qgil, busy? [20:41:12] New review: Ori.livneh; "Depends on Ib1f9fd249" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/57770 [20:44:52] marktraceur, hello [20:47:30] Rahul_21: Hullo! [20:47:33] What's up? [20:49:02] marktraceur, i am fine,remember i had asked you about making a function public from protected [20:49:47] marktraceur, https://bugzilla.wikimedia.org/show_bug.cgi?id=38221 [20:50:05] the filer has replied in the last comment [20:50:46] Ah yes. [20:51:36] Rahul_21: Add the explanation in the commit message. [20:52:35] marktraceur, but even his arguement is valid i feel [20:55:07] Rahul_21: Add the explanation in the commit message. [20:55:17] If it's valid, then you should add it to the commit message. [20:59:35] marktraceur, added:) [21:00:14] marktraceur, https://gerrit.wikimedia.org/r/#/c/56672/ [21:02:01] Rahul_21: 80 characters per line, please. [21:05:55] marktraceur, yes done:)check it out [21:06:18] Muuuuch better. [21:07:08] marktraceur, sorry for the trouble :) [21:07:21] Rahul_21: Jenkins will be along to merge shortly, and don't worry, you're no trouble :) [21:08:27] qgil: Re-ping about foss.rit.edu being interested in MediaWiki [21:09:39] marktraceur, hi yes please. [21:09:56] Rahul_21, pong [21:10:05] sorry, I was afk [21:10:21] qgil, busy bee:) its okay [21:10:34]