[00:00:12] too bad MediaWiki doesn't have any high level documentation [00:01:41] ori-l: thnks [00:01:48] I think that's it [00:11:18] http://hisham.hm/2011/05/04/luas-and-or-as-a-ternary-operator/ [00:11:21] "readable", heh [00:12:29] New patchset: Reedy; "Rewrite most of make-deploy-notes so it handles bugs in footers" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52086 [00:12:38] * AaronSchulz disagrees [00:12:48] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52086 [00:13:02] AaronSchulz: yup. You have to squint at such expressions to verify the logic. [00:14:42] AaronSchulz / anomie: do you know what the process is for benchmarking modules against wikitext? Trying to get http://en.wikipedia.org/wiki/Module:Yesno going [00:14:58] benchmarking lua modules against wikitext templates, I mean [00:15:40] (speaking of going overboard with ternary expressions...) [00:16:43] ori-l- I'm not sure there is a process yet. One thing I did once was use the API action=parse&text=... to parse the Lua version and the old version each several times, extract the "Lua time usage:" out of each response, and compare the averages. [00:17:38] I imagine someone who actually remembers anything about statistics could improve on the analysis. [00:18:38] hm, if i get a chance i'll try to hack together some sort of benchmarking script [00:26:01] I wonder if Scribunto has the record for most unit tests in an extension. I'm sure it does if the optional Unicode normalization tests for mw.ustring are downloaded, but that shouldn't count. [00:35:52] anomie: do you have "ponder about templatelinks/invalidation" on your todo list? :) [00:36:32] AaronSchulz- I was hoping you'd do it, but yes. I spent all day today working on bug 45684. [00:36:45] * AaronSchulz is just reviewing and commenting atm [00:38:22] Hmm, it looks like Jenkins got confused trying to test 52569, it tested 52572 instead. [00:38:43] yeah, I see lots of failures [00:39:54] The error at the bottom is what you'd get from 52572 without having 52568 applied to your luasandbox extension. [00:40:07] New patchset: Reedy; "Make list bullet pointed" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52573 [00:40:49] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52573 [01:55:49] TimStarling: Any opinion whether the OggHandler code in Score should be kept around as a fallback if no TMH support on the wiki? [01:57:00] I think it probably should, it wouldn't do any harm would it? [01:57:10] TMH is a big bundle of stuff to require [01:57:41] OggHandler would be less scary for non-Wikimedia users [01:57:50] I can't see any. It's a minimal amount of extra code to keep around [02:16:48] Should be nearly good to go [04:48:19] Reedy: thanks for the merge [08:28:12] New patchset: Krinkle; "Clean up comments." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52595 [08:28:24] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52595 [08:35:03] New patchset: Krinkle; "QUnit: Disable for mediawiki-core@REL1_19." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52597 [08:35:17] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52597 [14:50:23] ** Bugday on MediaWiki bugs starting here in 10 minutes, see https://www.mediawiki.org/wiki/Bug_management/Triage/20130307 for more info ** [14:53:49] andre__: was the whiteboard removed from bz? [14:53:59] Danny_B, no [14:54:11] does it require rights? [14:54:32] or is it simply not present in enter bug form? [14:54:39] (which is a bug) [14:55:04] many things are not on enter_bug.cgi [14:55:11] see bugzilla.mozilla.org for the ticket about it [14:55:14] Danny_B, did you click on show advanced options? [14:56:12] shown by default [14:57:36] it's not shown. [14:57:42] and there's an upstream request, as for everything [14:58:26] :-) [15:01:21] So, welcome everybody to this Bugday on MediaWiki bugs which is going to take place here for the next hours [15:01:25] https://www.mediawiki.org/wiki/Bug_management/Triage/20130307 provides more info [15:01:47] we're going to "triage" some of the existing general MediaWiki bug reports in the issue tracker [15:01:57] general info about triaging can be found on https://www.mediawiki.org/wiki/Bug_management/Triage [15:03:11] Hello Bug Squad! [15:03:20] hi Soli, and welcome! [15:03:41] so, quick info again: Bugday on MediaWiki bugs, more info on https://www.mediawiki.org/wiki/Bug_management/Triage/20130307 [15:04:03] Soli: Do you know a bit about triaging already? [15:04:13] Thanks you andre__, it's my first time. I saw the invitation on MediaWiki-l. [15:04:21] (though I see your "wikipedia" hostmask, I never know the background of people) [15:04:23] ah, great! [15:05:17] Soli: did you have time to take a look on https://www.mediawiki.org/wiki/Bug_management/How_to_triage ? [15:05:52] andre__: I did fill a few bugs before. Made a patchs or two too. Reading Triage/20130307 and Bug_management/How_to_triage now [15:06:05] oh nice! [15:08:17] Soli, http://etherpad.wmflabs.org/pad/p/BugTriage links to a table with all reports that we could take a look at [15:09:11] andre__: thanks you, will look up after catching up with the Howto. [15:09:36] Soli, if you have any questions, ideas, comments etc please tell us. The documentation can always be improved. :) [15:13:17] so http://etherpad.wmflabs.org/pad/p/BugTriage is the best starting point for today's bugday, and if you want the full choice of tickets, click the link in the right bottom corner of the table linked form that etherpad [15:14:17] take a look at a report, if it's clear, when the last comment took place and if it's still an issue, [15:14:37] or if something is unclear bring it up here so we can all together take a look and get things going [15:17:06] ...and the results of triaging a report are then added to http://etherpad.wmflabs.org/pad/p/BugTriage [15:17:09] that's basically how it works [15:17:49] hello bug squad [15:18:25] hello zeekzack [15:18:51] I'll bump https://bugzilla.wikimedia.org/show_bug.cgi?id=21494 to Version = 1.21 as it's still an issue as per duplicate [15:18:55] hej zeekzack, welcome! [15:19:14] Hey zeekzack and Soli! [15:19:38] :-) [15:19:40] zeekzack, here for the bugday? [15:19:41] Hello valeriej [15:19:47] yeah [15:21:12] zeekzack, Great! [15:21:20] zeekzack, have you triaged reports a bit before? [15:21:34] nope, beginner [15:22:04] Uh yay :) Triaging is a nice way to get more involved. (Actually that's how I ended up in Open Source years ago, as a non-programmer) [15:22:14] https://www.mediawiki.org/wiki/Bug_management/How_to_triage is a good intro [15:22:24] you don't need to read that all though, just as a reference [15:22:42] so my usual recommendation is "Use common sense" and "If unsure, ask first". [15:23:05] for today's bugday we use http://etherpad.wmflabs.org/pad/p/BugTriage which has a link to a table with the bug reports we want to take a look at, and update [15:24:42] * andre__ should stop chatting and also triage some tickets [15:26:06] so I take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=29731 and it reminds me of a report that I've seen before, about the charset of database tables. So I'll search for the duplicate and cross fingers that I will find it [15:26:36] andre__, Dharmadhyaksha is reporting a bug in #wikimedia-commons [15:27:10] Platonides, okay, but wouldn't bugzilla.wikimedia.org be better so it doesn't get lost? :P [15:27:37] okay..i hv good programming knowledge...i understand this....nd going through bugs that you 're mentioning :-) [15:27:48] zeekzack, that's definitely helpful! [15:28:20] discussion of reports takes place here on IRC, and we then add findings/resolutions/etc to the etherpad on http://etherpad.wmflabs.org/pad/p/BugTriage [15:29:12] andre__, the odd thing is that he reports UploadWizard not working [15:29:29] while I would expect everybody to have noticed it in such case [15:30:24] Platonides, the UploadWizard bug reports filed in the last week are here: https://bugzilla.wikimedia.org/buglist.cgi?list_id=184789&chfieldto=Now&query_format=advanced&chfieldfrom=-7d&component=UploadWizard&product=MediaWiki%20extensions [15:30:49] oops, that query actually has all *changes* in the last week [15:31:36] so for the bug 29731 that I'm taking a look at, I'll go to the Advanced Search on https://bugzilla.wikimedia.org/query.cgi?format=advanced and try to search for Product=MediaWiki, Component=Database, and Comment=encoding, and I don't choose anything under "Resolution" because I also want closed bug reports in my search results. Let's see... [15:32:17] hmm, 25 results. [15:33:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=20831 and https://bugzilla.wikimedia.org/show_bug.cgi?id=38250 might be similar issues to https://bugzilla.wikimedia.org/show_bug.cgi?id=29731 that I am looking at [15:34:45] yeah, I think they might all three be duplicates - latin1 etc. instead of utf8 encoding [15:35:07] bug id 20831is similar to bug id 29731 [15:36:01] zeekzack, yeah, definitely. [15:37:25] But I'm normally careful with closing as duplicates, so I'll add comments to both 20831 and 29731 [15:37:36] asking the reporters to check the database encoding [15:38:12] plus I will set the status whiteboard to "aklapper-moreinfo". That whiteboard allows any kind of tagging, and I normally use these tags to find the tickets again where I've asked the reporter for more info [15:38:16] to check back after a few weeks [15:38:34] seeing how old these reports are, I assume that they will end up being closed as RESOLVED WORKSFORME. [15:38:43] okay...bug 38250 looks more of a database setting issue [15:38:56] atleast from comments... [15:39:29] Does anyone with Konqueror want to retest bug 40286? If not I'll ask for a retest. [15:40:28] I have a Konqueror browser somewhere on this computer [15:40:54] zeekzack, might be :-/ [15:41:36] i am out of kubuntu distro for 2 days..can check that later [15:41:52] hah [15:42:44] wondering where to enable the debugtoolbar on some wikisite, or if I really need to install my own instance of MediaWiki for that [15:43:43] yeah, would require an instance running on my own [15:43:43] andre__: I wondered that as well. Let me search around. [15:43:52] andre__: Ah, you got it. [15:43:53] vl be comeback in hour !! [15:43:56] I can test it locally if needed [15:44:05] I didn't even know about that new toolbar [15:44:15] Platonides, oh nice [15:44:30] I think I also still have a MediaWiki installation somewhere [15:44:35] * andre__ takes a look at his other machine [15:45:57] argh, I reinstalled. I see. [15:48:00] confirmed [15:48:19] Platonides: Thanks! [15:48:22] Soli: do you need any help with something for triage? (just asking if I can do something, no expectations or requirements here) [15:48:24] Platonides, thanks, nice [15:49:09] andre__: I'm working on 38135 right now. I'm trying to remember how to submit a patch to gerrit. [15:49:30] Soli, you already did that in the past? [15:49:41] Platonides: What version? [15:50:05] valeriej, version of what? [15:50:37] Soli: ah, I see. I normally follow http://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch for that [15:51:27] Platonides: On what version of MediaWiki did you test bug 40286? I wanted to update the version field, if you tested on a newer version. [15:51:37] master [15:51:59] actually, master merged with change 51022 [15:52:19] (we normal bump the Version field to reflect when the bug was seen for the last time) [15:53:14] I'll try to reproduce the Firefox crash in https://bugzilla.wikimedia.org/show_bug.cgi?id=42283 again [15:53:51] but I think I am going to close this as INVALID, just for the fact that browsers should not crash on websites, so it's something for the Mozilla developers to fix and not for us [15:53:56] Platonides: Thanks again! [15:54:27] valeriej, np [15:54:48] if we used some complex javascript which does that, we could try to workaround the bug, as we did in the past [15:55:01] but I don't see a problem there [15:55:07] also, it's not crashing for me [15:57:28] * andre__ upstreams https://bugzilla.wikimedia.org/show_bug.cgi?id=42283 to bugzilla.mozilla.org in order to close it - there's nothing that Wikimedia developers can do [15:57:46] spoke too soon [15:57:51] it crashed now :( [16:03:50] it's a bit shy, but it still crashes :) [16:03:57] I've upstreamed the bug report to Mozilla at https://bugzilla.mozilla.org/show_bug.cgi?id=848801 [16:10:36] As part of today's triage I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=41329 and https://bugzilla.wikimedia.org/show_bug.cgi?id=41327 [16:10:49] wondering whether to move these to Extension requests too, as per dependency on bug 43666 [16:10:54] but I guess I'll just leave comments [16:12:01] ah no, one has a patch that would go into mediawiki core [16:16:47] For those who have recently joined: We have a bugday going on here, see https://www.mediawiki.org/wiki/Bug_management/Triage/20130307 [16:22:45] Hello Bug Squad! [16:23:50] andre__, valeriej hi [16:24:05] Welcome qgil_! [16:24:15] Hllo qgil_! [16:24:18] gimme a task please :) [16:24:21] *Hello [16:24:31] http://etherpad.wmflabs.org/pad/p/BugTriage [16:24:54] choose your favorite bug report from that URL, and triage it, and if you need help ask here :) [16:25:59] hmm, I wonder if I also have these powers to change the topic [16:29:38] andre__, if I have them probably anybody has them [16:30:07] I will try going through the uncategorized enhancement requests: https://bugzilla.wikimedia.org/buglist.cgi?action=wrap&chfieldfrom=6m&chfieldto=Now&component=General%2FUnknown&product=MediaWiki&resolution=---&bug_severity=enhancement&priority=Unprioritized&list_id=184823 [16:30:24] I admit I didn't try here, hah. [16:30:38] *unprioritized. Thanks! [16:31:47] this channel doesn't have +t, so anyone can change the topic [16:34:21] yeah, I didn't look at it. Good to know [16:37:53] andre__, so I pushed https://bugzilla.wikimedia.org/show_bug.cgi?id=40763 to another component, hopefully the right one. Do I need to add this in the etherpad or we put there only more significative changes? [16:38:09] evening all [16:38:33] qgil_, we should add any changes/"results" to the etherpad, yeah [16:38:37] see also my way to advertise the bug day in my comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=40763 - it goes to a very targeted audience that might be interested [16:39:04] Does that look like spam or useful advice / context? [16:39:47] qgil_: spam if the rest of the comment doesn't add value [16:40:16] but after all we have bugzilla users who consistently reiterate the content they change in fields also in a comment text [16:40:34] so we're used to spamming [16:41:14] Fedora Bugzappers also add such a comment when triaging. [16:41:22] Nemo_bis, "adding value" is subjective. Now the people reading that bugmail know that there is a Bug Day affecting the bug report(s) they are following [16:41:22] I'm undecided. [16:41:40] anyway, just experimenting a bit [16:41:49] qgil_: I said "rest of the comment" on purpose [16:42:15] andre__: Bug 40508. When I can't reproduce the bug, do I still leave it as Unconfirmed and go on? [16:42:21] Nemo_bis, ah :) [16:42:23] good point [16:43:01] Soli: best to add a comment what you tested and how, on which MediaWiki version, and that you cannot reproduce the problem [16:43:33] Soli: and then adding a short item in http://etherpad.wmflabs.org/pad/p/BugTriage . And thanks for testing that one! [16:43:54] * andre__ looking at RTL/I18N math bug https://bugzilla.wikimedia.org/show_bug.cgi?id=30630 [17:07:35] andre__, can anybody prioritize an unprioritized component or is this something that only maintainers and people in the know should do? [17:09:15] qgil_, mixed, per project. but mostly it's fine if others set it. When it comes to higher priorities, preferably people who have a clue (whatever that means - project members, bugmasters, etc) [17:09:59] ok, and now I have learned that when editing the topic of a bug and clicking "Save changes" whatever you have in the comment field will be posted as well. :P [17:10:05] Bugzilla is so pre-JS [17:10:39] ehehe [17:10:57] New review: Platonides; "What about the files with a shebang?" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/48602 [17:10:59] yes. feel free to CC on https://bugzilla.mozilla.org/show_bug.cgi?id=40896 [17:11:30] does anybody use Safari for browsing? Would love to know if someone can reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=44152 [17:14:22] * andre__ will be back in 10min, short break [17:18:07] qgil_, that's what I would expect [17:19:23] Platonides, are you talking about editing summary vs comments? [17:20:51] Is there a way to tag a bug to mention that it affect only wmf/* branches? [17:22:39] andre__: ^ [17:22:59] Soli: I don't see an applicable keyword: https://bugzilla.wikimedia.org/describekeywords.cgi [17:23:33] Soli, no, there isn't. Could you elaborate? [17:23:42] valeriej: I've mentionned it on the comments anyhow. [17:23:44] I'd probably just add a comment in that case [17:23:48] Soli, which bug? [17:23:59] andre__: https://bugzilla.wikimedia.org/show_bug.cgi?id=40508 [17:24:06] qgil_, yes [17:24:16] since you usually want to change both [17:24:28] otherwise, why would you have something filled into the comments field? [17:27:25] anybody with MSIE who wants to give https://bugzilla.wikimedia.org/show_bug.cgi?id=42408 a try? [17:27:47] andre__: Will do. [17:28:28] thanks! [17:32:51] Platonides, I guess it was Flickr who got me used to do both things separately but yes you are right. [17:33:56] andre__, trying to find the right component for https://bugzilla.wikimedia.org/show_bug.cgi?id=43257 I realized that tere are Gallery report filed under Interface, Parser, File management and Special pages - without being really clear where this one belongs to [17:34:54] sigh... "depends" on the level. [17:35:01] in this case I'd say Interface [17:35:07] ok [17:35:34] depends on the level - if it's really a storage issue, File management would be correct for example [17:42:03] I think that would be parser [17:44:36] Whoa now. Looks like a style bug to me, at least primarily. [17:45:50] it's an enhancement request and indeed it touches the parser. Better than under General/Unknown in any case [17:46:50] ok, done with unprioritized enhancement requests. Looking at the "High" enhancement requests now [17:53:29] Reedy: https://gerrit.wikimedia.org/r/#/c/52583/ tiny [17:53:35] * andre__ back in 30min for the triage, need to find food - just ask your questions here on IRC if you have some! [17:54:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=26992 is marked as High but in fact it hasn't seen actual work in 2 years and no meaningful word since July. [17:54:32] should I set as normal or it doesn't matter? [17:54:45] m back here...:-) [17:55:07] bah, applying "be bold" [17:55:35] I bumped it in comment 16, probably guided by wishful thinking, so I'd say: Set it back to normal, yeah. [17:56:26] qgil_: https://bugzilla.wikimedia.org/show_bug.cgi?id=42238 – any clearer now? [17:56:57] Hey zeekzack. [17:57:15] Nemo_bis, thank you :) [17:58:45] valeriej: whats going on right now? [17:59:51] zeekzack: Still triaging reports. Check the etherpad: http://etherpad.wmflabs.org/pad/p/BugTriage We've made good progress! [18:01:27] yeah, that is from where i left...:-P [18:01:27] point me something to look in..:-) [18:03:16] zeekzack: heh, that's the classic chicken and egg problem I guess. :) It's often up to the triager to chose what s/he wants to take a look at; it's not that we "assign" tasks or so (as triaging should be fun). So the full list of issues to choose from is here: https://bugzilla.wikimedia.org/buglist.cgi?action=wrap&chfieldfrom=6m&chfieldto=Now&component=General%2FUnknown&product=MediaWiki&resolution=--- [18:04:09] andre__: https://meta.wikimedia.org/wiki/Metrics_and_activities_meetings/2013-03-07 hope you can make it (in 1 hour) [18:04:34] Krenair: Nemo_bis Platonides Nischayn22 petan saper_ yurik_ ^^ [18:04:55] andre__: okay looking into it.. [18:04:55] qgil_:should i write summary of change in bug id 26992 in etherpad? [18:05:06] sumanah: I am not too sleepy so I think I can [18:05:18] cool [18:05:28] zeekzack, this is what andre__ told me when I asked the same question :) [18:06:47] andre__, no unprioritized and no High enhancement requests at General/Unknown anymore. And now I have to leave the Bug Day and do some other stuff [18:10:48] Thanks, qgil_! [18:13:22] qgil_: Thank you ..!! [18:20:13] valeriej: https://bugzilla.wikimedia.org/show_bug.cgi?id=30072 look a this bug....should we change its importance ? [18:21:41] zeekzack: What do you think it should be? Here's an explanation of those fields: https://www.mediawiki.org/wiki/Bugzilla/Fields#Priority [18:24:04] as it is related to login issue for new editors to wikimedia project..it should be fixed in near future.. [18:27:27] qgil_, thanks for your help! [18:27:30] * andre__ back [18:27:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=32777 this bug [18:27:52] looks like existence of this bug is not confirmed any more.. [18:28:19] andre__: welcum back..you have last commented on this bug [18:31:27] zeekzack, uhm. and now even the testcase is not online anymore, the link is a 404 [18:32:20] yeah, i have checked..should we close this bug?..nd there is no other instace of report of this bug [18:32:23] zeekzack, so the original reporter has been asked twice to elaborate what the problem is but unfortunately has not answered. [18:32:54] zeekzack, I'd close the report as RESOLVED WORKSFORME, and add a comment to explain it, like "Unfortunately closing this report as no further information has been provided. Please feel free to reopen this report if you can provide the information asked for and if this still happens. Thanks!" [18:33:07] to make clear why it was closed. [18:33:59] zeekzack, do you want to do that? (I wonder if you have permissions to edit a bug report's status?) [18:34:17] let me try..tell u in a moment.. [18:36:11] i dont find a way to close it..:-D [18:37:57] zeekzack: hehe, then I need your email address (private IRC message) to give you permissions :) [18:38:26] zeekzack, there should be a dropdown at the bottom, below the field where you can add a comment [18:39:20] zeekzack, reload the page and try again [18:39:26] look at this: https://bugzilla.wikimedia.org/show_bug.cgi?id=36911 [18:39:26] i m adding comment to clarify when this occurs.. [18:40:45] zeekzack, Sam knows what he's talking about and I assume he doesn't know - it's just in the log [18:40:58] zeekzack, so it might make more sense to inspect the code if this can still happen instead [18:41:10] but normally, Sam's reports don't need triaging :) [18:41:26] zeekzack, see https://bugzilla.wikimedia.org/show_bug.cgi?id=36911#c3 [18:41:36] there is a link to a corresponding patch (at least for comments in the code) [18:44:03] okay, i was just presuming the situation.unfortunately a wrong one :-D..so leaving it for now..:-) [18:44:37] heh, yeah, some bugs just don't need help :) [18:44:40] and thanks for closing bug 32777! [18:46:29] yay! i did my first closure in bugzilla..thanks for your help:-) [18:46:55] hashar: I'm going to make qunit voting for mwcore later today [18:46:59] I looked through all the runs [18:47:20] there were a few failures, those were either genuine failures or REL1_19 or wmf/1.21wmf10 [18:47:28] REL1_20, master and wmf11 are fine [18:47:30] I fixed wmf10 [18:47:35] disabled qunit in REL1_19 [18:47:51] (see zuul-config) [18:48:08] Awesome, zeekzack! Don't forget to record that you closed the bug and any other bug changes on the etherpad. :) [18:52:30] valeriej: thanks !! :-) [19:10:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=14369 [19:10:40] priority change: low to normal?? [19:11:19] zeekzack, normally the question I try to ask myself is: Has something made the problem more urgent recently? [19:11:47] (actually to me, "low" is a way more realistic priority than whatever "normal" implies, considering limited manpower and the number of requests) [19:12:05] zeekzack, so personally I'd keep this as low, but maybe you have good reasons why to change it? :) [19:12:53] okay, it has been idle for more than 4 years.. so it is fine as it is now.. [19:13:39] last comment (number 10) was in 2012, so I wouldn't call it totally idle. [19:13:51] the age of a report normally does not mean anything. [19:14:00] Sort of. [19:14:17] Older bugs are typically more annoying (read: difficult) to resolve. [19:14:24] hey Susan! [19:14:28] Hi. :-) [19:15:14] yeah, tru [19:15:15] e [19:15:21] discussion of wikidata right now in the monthly metrics meeting [19:15:25] https://meta.wikimedia.org/wiki/Metrics_and_activities_meetings/2013-03-07 [19:19:44] Krinkle: great :-] [19:48:00] Quick reminder for everybody who has recently joined: Bugday in this channel for another 75 minutes, see channel topic [19:48:14] * andre__ looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=44111 [19:51:13] leaving bugday.. [19:51:55] valeriej: andre_: had a good time with you.. :-) [19:52:10] zeekzack, hey! Thanks a lot for your help! [19:52:13] zeekzack: Thanks for joining! [19:52:15] zeekzack, I hope it was some fun? [19:52:23] and hopefully see you next time! :) [19:53:20] yeah, it was fun...so i will try to fix a bug soon...nd yes will surely join next bugday..:-) [19:53:44] oh cool. great to hear. and if you have any ideas for improvements, we're also interested! [19:53:54] zeekzack, and feel free to add yourself to http://www.mediawiki.org/wiki/Groups/Proposals/Bug_Squad [20:02:51] yeah added my self to group..will love to work with you awesome guys..:-) [20:04:24] :) [20:06:45] ^demon: https://gerrit.wikimedia.org/r/#/c/52588/ [20:08:59] hashar: I'd like to remove https://gerrit.wikimedia.org/r/#/c/14068/ from my dashboard [20:09:05] though that would remove the -1 [20:09:10] ABANDON [20:09:31] Reedy: volunteering? [20:09:36] Aaron|home: feel free to abandon it [20:09:40] To press the abandon button? [20:09:42] not in a mood to fix that one [20:09:56] hashar: just in the mood for pizza [20:09:56] I am having Pizza on 6th bbl [20:15:56] man gerrit is slow [20:16:34] Reedy: we should run it off an IBM mainframe with RAIDed SSDs [20:17:55] a beowulf cluster of those, actually [20:17:56] :P [20:18:15] http://www.linuxplanet.com/linuxplanet/reports/2127/1/screenshot1451/ [20:18:46] that's only slightly bigger than a Galaxy Note 2 [20:19:37] Yeah, but try to find server racks that fit the latter. [20:24:32] If bug 4591 is filed in Parser, would bug 5126 (a possibly related bug) be filed in parser as well? [20:25:03] valeriej, yes! [20:25:10] * andre__ trying to understand https://bugzilla.wikimedia.org/show_bug.cgi?id=37515 as part of today's bugday [20:25:16] andre__: Thanks! [20:25:16] valeriej, good catch [20:34:30] anyone with better SQL skills than me help check http://pastebin.com/vK8qYjFF [20:34:31] ? [20:35:46] yo kaldari, you have changes in wmf11 on fenari... ? E3 is going to scap [20:40:19] spagewmf: yes, we're finishing our deployment now [20:40:28] give us a little bit [20:40:32] YuviPanda: try killing the w/s in "COUNT ( DISTINCT T2.event_username )" after COUNT [20:40:43] whitespace could be a problem? [20:40:44] * YuviPanda kills [20:41:11] Aaron|home: :| [20:41:13] that worked [20:41:14] wut [20:41:58] it matters for function calls (which aggregates are) [20:42:46] Aaron|home: okay. Thanks! [20:42:52] I never saw that coming :| [20:48:47] kaldari, you're not in #wm-operations [20:59:09] andre__: Both bug 33364 and bug 33365 have requests from you for more info with no reply. [21:02:24] andre__: Should those reports be closed? [21:02:27] valeriej, let me take a look [21:02:42] plus I hereby declare this bug report as a success, and finished. :P [21:03:06] andre__: Yay! [21:04:17] I think I'll ping one more time by asking the reporters [21:05:06] Yeah, it seems like something we'd want to investigate more, if the reporter would help us out. [21:12:30] New patchset: MarkTraceur; "Initial commit" [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52670 [21:12:41] Change merged: MarkTraceur; [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52670 [21:21:35] Reedy: still around? I am trying to figure out which server host the OAI database. [21:21:48] Reedy: seems each of our mysql master has an `oai` table isn't it ? [21:28:27] <^demon> Yes. [21:29:50] ooookkky [21:30:00] going to set that up on the beta mysql servers [21:39:22] hashar: Errr [21:39:43] Reedy: err like wrong ? :-] [21:39:43] hashar: it's on s3 [21:40:05] then if a wiki is on s5 how does it find out it has to connect to the s3 master? [21:41:23] If you look at s1, you'll see it doesn't have an oai ;) [21:42:58] $this->mAuditDb = $lb->getConnection( DB_MASTER, 'oaiAudit', $oaiAuditDatabase ); [21:43:10] Uhh [21:43:10] global $oaiAuditDatabase; [21:43:11] $lb = wfGetLB( $oaiAuditDatabase ); [21:43:11] $this->mAuditDb = $lb->getConnection( DB_MASTER, 'oaiAudit', $oaiAuditDatabase ); [21:43:36] ping TrevorParscal [21:43:57] TimStarling: is it possible to require pages from other namespaces in module? and is module name limited or can contain any character which can be in page title ()/:. etc...? [21:44:01] hashar: Magic! [21:44:02] string(10) "10.64.16.8" [21:44:03] ["hostName"]=> [21:44:03] string(6) "db1019" [21:44:58] hashar: Looks like it's defined as a "wiki" [21:45:03] so somewhat of a hack [21:45:16] :/ [21:45:37] I don't get it sorry [21:47:15] ahhhhhhhhh [21:47:16] RoanKattouw, are you here? [21:47:30] Platonides: Yes [21:47:40] Reedy: so yeah the LB looks for the oai which is not configured so that fallback to S3 which is the default Mysql cluster. Correct? [21:47:48] do you know what are those offsets in WikiEditor/modules/jquery.wikiEditor.toolbar.config.js ? [21:48:00] hashar: Sounds about right [21:48:53] Platonides: They're pixel offsets into a sprite [21:49:41] but the icon is a filename :S [21:50:50] Yeah not sure why we have both [21:51:03] Oh I think it's for some old IE version where you can't do spriting the way we're doing it there. Or something [21:51:04] Legacy [21:51:35] so, for adding a new file, how should I make up those values? [21:52:00] Platonides: Just don't put them in I think [21:52:37] the sprite seems to be modules/images/toolbar/button-sprite.png [21:53:16] the sprite should be autogenerated by RL if needed [21:53:27] instead of needing manual edits [22:11:45] Yeah, this is all pre-RL [22:14:43] WikiEditor requires the RL :/ [22:14:49] well, the images work [22:15:06] although I don't like how they assume the location of extensions folder [22:16:06] Yeah what I meant was, the way the toolbar loads icons predates RL and wasn't changed to use RL [23:06:01] ^demon: I don't see the usefulness of it, should probably at least ignore comments by bots and comments that only contain votes or inline commnets. [23:06:18] <^demon> Krinkle: Iterations :) [23:06:24] and the other comments, what's the point of those? [23:06:35] discussion of a need and implementation should be separate not? thats why we have code review. [23:06:47] those that need the cr, have email notifications from gerrrit [23:06:51] now I get both in my inbox [23:07:01] I can filter it, but who wants it? [23:07:23] <^demon> Auto-notifs of "Someone committed a patch to fix this bug and here's a link" is useful, since most people do that by hand anyway. [23:07:31] <^demon> But you're right, posting all comments is annoying. [23:07:37] oh god, that thing is posting comments when jenkins says "Starting gate-and-submit jobs." [23:07:45] sure, a one time comment "This has been associated with" [23:07:47] that's great. [23:08:00] The Jenkins spam is enough as it is [23:08:20] but only once per bug/change-id combination [23:08:23] I don't think going from 4 emails to 8 emails is a good idea [23:08:42] (per jenkins approval) [23:09:19] <^demon> Indeed...I'll disable it for now until we fix it up a bit further. [23:10:10] ^demon: btw this ability is great. Did you create it? I'd love to see the source code. [23:10:19] <^demon> Christian and I worked on it. [23:10:24] <^demon> It's upstream. [23:10:43] <^demon> https://gerrit.googlesource.com/plugins/hooks-bugzilla/ - here's the plugin. [23:10:56] <^demon> It depends on a base plugin called hooks-its. [23:11:10] <^demon> (We wrote it generically with the GerritForge guys who needed it for jira) [23:11:46] Currently I get "Starting gate-and-submit jobs." "Verified+1, Build successful" "Verified+2, Build successful" "jenkins-bot has submitted this change and it was merged." "Build successful" [23:12:01] <^demon> Disabled for now. [23:12:06] That's 5. Just from jenkins-bot (Code Review) [23:12:51] Krenair: good news is that at least on Thunderbird I can read them all as a single one, collapsed in a thread of which I get excerpts [23:12:59] (That's what I got from https://gerrit.wikimedia.org/r/51963 anyway) [23:13:15] <^demon> *nod* [23:19:11] <^demon> So yeah, there's actually discussion going on upstream regarding spammy notifs to issue trackers. I weighed in and was like "let's do this in hooks-its, not just hooks-jira, we want the same configurability for hooks-bugzilla" [23:20:55] qgil_: hey, I saw you at lunch for a second and had to give someone else my attention, sorry -- I think you were going to bring something up? [23:21:39] nope, just small talk :) [23:22:03] oh ok! Nevertheless it may have seemed as though I was blowing you off, and I'm sorry [23:41:27] New patchset: MarkTraceur; "Fix up the main file and add tests" [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52723 [23:41:55] New review: MarkTraceur; "Self-review is amusing." [integration/junitdiff] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/52723 [23:41:55] Change merged: MarkTraceur; [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52723 [23:42:24] hashar: And with that, I'm happy with the junitdiff tool. We can deploy it, but I'll need to add the node dependencies somewhere. [23:44:07] I'd also not mind running the unit tests I added in Jenkins. It's almost recursive! [23:55:13] New patchset: MarkTraceur; "Fix package.json, add modules" [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52727 [23:55:22] Krenair: ^^ [23:55:54] marktraceur, was that meant for Krinkle ? [23:55:57] :) [23:56:03] Yes, he pinged me in -parsoid as well [23:56:10] Oh, damn it. [23:56:11] I thought my sounds was off [23:56:26] marktraceur: one of those packages has a lint error [23:56:32] Oh? [23:56:34] marktraceur: ... Just kidding! [23:56:48] use single quotes in all of the code [23:56:51] xD [23:56:56] I was about to say...are you going to let me guess at which one? [23:57:09] Krinkle: I do! It's great stuff. [23:57:10] well, or have you styilize upstream code [23:57:20] Oh, I see. [23:57:35] gotta put those semi colon in, moar cowbell [23:58:00] Is Krinkle having a stroke? [23:58:12] New review: Krinkle; "cheers" [integration/junitdiff] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/52727 [23:58:12] Change merged: Krinkle; [integration/junitdiff] (master) - https://gerrit.wikimedia.org/r/52727 [23:58:18] nah, just merging arbitrary code. [23:58:29] Yaaay. [23:58:33] Same thing, really [23:58:42] oh, now I better be careful. [23:59:03] * marktraceur rubs hands together maniacally now that Krinkle merged the doomsday device disguised as an XML library.... [23:59:06] I checked them against npmjs tgz and verified npmjs IP. [23:59:20] at least it is what they put on npmjs originally [23:59:27] The trick is, XML itself is a doomsday device. W3C has already doomed us all. [23:59:47] now you could've hacked the accounts of those npmjs users and pushed it into their github repo with their private key and then published a version. [23:59:54] but that's the risk we're taking. [23:59:59] Krinkle: Assume I don't have time for that