[00:14:43] New patchset: Hoo man; "Whitelist l10n-bot for full core unit tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/51972 [00:16:16] New review: Alex Monk; "I don't think this is necessary - if you look at that change, you'll see the tests did get run and d..." [integration/zuul-config] (master) C: -1; - https://gerrit.wikimedia.org/r/51972 [00:18:03] New review: Hoo man; "That's because it ran the tests after the change was merged. But only gerrit administrators can merg..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/51972 [00:24:41] New review: Hoo man; "Just for the record: I would probably even do this if that wouldn't fix the given bug... just more s..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/51972 [16:54:45] gerrit broken [16:55:05] broken how? [16:55:40] snafu here [16:57:18] https://gerrit.wikimedia.org/r/#/c/52035/2,publish does not load [16:58:25] Interesting. That link doesn't work for me directly, but if I press Review it loads. [17:03:26] parent5446: I quoted that on https://bugzilla.wikimedia.org/show_bug.cgi?id=45707 [17:03:47] OK [17:23:41] Reedy: heya, just curious when you're planning on creating the wmf11 branch (and updating the release wiki page with changes). Just so I know when to plan to summarize the big changes on the wiki page. [17:29:12] Hi parent5446. [17:34:34] greg-g: Now-ish [17:34:43] I could do with finding a desk though [17:34:46] Breakfast first [17:39:52] Reedy: cool. [18:12:09] New review: Hashar; "The l10n bot does a self merge so this change is probably not going to fix anything." [integration/zuul-config] (master) C: -1; - https://gerrit.wikimedia.org/r/51972 [18:14:26] mwalker|away: grab me when you're free to talk CentralNotice! [18:14:46] what is Template:Mbox.http://www.drrajkabur.info/index.php/Article on https://www.mediawiki.org/wiki/File:Kraken_flow_diagram-2.png ? [18:15:01] I'm seeing it on lots of upload pages on mediawiki.org [18:15:10] Can't figure out why it's there. [18:15:37] Someone's broken the template [18:16:06] Fixed: https://www.mediawiki.org/w/index.php?title=Template:PD&diff=655112&oldid=652209 [18:16:30] Maybe we should protect that page [18:17:59] jdlrobson: I have a note in my playback buffer that you want to talk about CentralNotice today? [18:18:29] mwalker: yeh just continuing friday's conversation :) [18:18:42] New patchset: Reedy; "Update Wikidata related extensions to use 1.21wmf11 branch points" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52058 [18:18:58] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52058 [18:20:37] Welp. Glad to see it looks better. :) ty Krenair [18:21:02] jdlrobson: cool; let me catch up on the mornings email and then I'll wander downstairs [18:40:52] siebrand: Why the tirade against 'behaviour' this morning? [18:41:48] mwalker: I've just looked up tirade. According to wiktionary, it means " A long, angry or violent speech; a diatribe" [18:42:09] I took artistic license with the word :) [18:42:10] mwalker: Can you please explain how you interpret what I did as that? I didn't mean to, and I'd like to learn. [18:42:50] mwalker: What is that, "taking an artistic license with a word"? [18:43:54] you didn't do anything wrong -- it just looks like you decided British spelling in comments was an evil thing and therefore decided to expunge it! somehow that makes a connection to the word diatribe in my mind [18:44:37] is this going to be officialish policy though that we should attempt to use american spelling? [18:44:55] mwalker: practice is to choose American English spelling in MediaWiki core, and by extension, in extensions deployed on Wikimedia wikis. [18:45:15] cool; didn't know that [18:45:25] I'll have to change my spelling dictionaries then [18:45:34] mwalker: A volunteer translator notified us of inconsistencies on [[Support]] on translatewiki.net. [18:46:01] Also wiktionary says tirade is an anagram of airted, which means guided. [18:46:04] mwalker: As I have some 190 extensions cloned, and active in PHPStorm, I did a search, so see if it was worth doing a wider scoped replace. [18:46:09] hi parent5446! [18:46:16] hi! [18:46:39] mwalker: btw, I'm not that happy with your choice of words. It implies malicious intent from my side, and that's not the case at all. Please be more neutral. [18:47:12] mwalker: So I found a lot of inconsistencies, decided to fix them, 1-by-1, not using a regex or a script, and subsequently submitted patch sets. [18:47:45] certainly I shall try -- tirade for me has a more humorous meaning over the malicious intent; but note fairly taken [18:47:48] mwalker: As you had previously indicated that you were willing to review trivial L10n related patch sets, ins tead of my self merging, I added you as reviewer to a bunch of them. [18:47:56] yep; not a problem [18:48:04] mwalker: DOes that sufficiently explain what I did and why? [18:50:26] mwalker: anyway, thanks for asking. I've seen a hand full of others on IRC making assumptions about what I did and why, and even call what I did "beyond retarded". [18:50:50] siebrand: yep, totally makes sense -- I didn't mean to put you on the defensive or anything btw -- I'll defer to you for language things (I assumed you had good reasons), but I sincerely appreciate you following the 2 reviewer thing [18:51:51] these things are picky, easy to misunderstand [18:57:26] New review: Hashar; "Markus that was a good idea but since l10n-bot self merge, that is not going to prevent such a fault..." [integration/zuul-config] (master) C: -2; - https://gerrit.wikimedia.org/r/51972 [18:59:25] Change abandoned: Hoo man; "Per Hashar: I thought only gerrit admins can merge if a change was -2ed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/51972 [19:03:53] siebrand: I didn't see the american english thing on the coding conventions page; so I've added a little bit about it (http://www.mediawiki.org/wiki/Manual:Coding_conventions#System_messages) you should add some additional text if you know of preferred spellings in other languages (I'm thinking pt vs pt-br that sort of thing) [19:13:54] tewwy: The org chart with the pictures was never online, it was just a document someone had made and printed out a few times; and I wasn't involved in that [19:15:45] marktraceur: Good to know. It's still floating around even though it's 8 months old. I'll give people the new link in wmflabs [19:16:37] *nod* [19:17:21] tewwy: I guess worthwhile to finish up the remaining TODOs on that project and deploy it somewhere a little more stable, but that's probably some way out for now. I got it to a workable point so Mel could start updating it. [19:18:04] marktraceur: I'll put a reminder to remind me in a month or so. [19:18:10] mwalker: coding conventions is probably not the best place for documenting style guidelines for various natural languages ;) [19:18:43] Nikerabbit: yes and no -- it's something that is in code so it should at least be mentioned on the page [19:18:59] but if you have a better place for it -- I think a link to it is totally acceptable [19:19:40] mwalker: Also, we don't have a preference - see https://gerrit.wikimedia.org/r/52004 [19:19:41] mwalker: I don't think we have portuguese anywhere in our code except i18n files [19:19:52] English is an exception [19:20:49] * tewwy throws Nikerabbit an English exception [19:21:16] marktraceur: interesting point -- but I think siebrand still was onto something -- we do need a consistent UI [19:21:50] mwalker: Maybe UI, but I guess for codebase it would be good to point out that both spelling systems are acceptable. [19:22:07] Nikerabbit: do you know if i18n has any plans in the future of fully supporting locales? [19:22:12] mwalker: I'm not sure if the language code 'en' means "any English" or "American English" [19:22:24] mwalker: we already do, kind of [19:23:48] Nikerabbit: I guess what I'm looking for is support for all the locales (this would actually help CentralNotice; I can take a look at the country someone is coming from and their browser requested language if given and serve them an appropriate locale) [19:24:49] marktraceur: indeed :p I was going to defer to the i18n team on it really -- but to a certain extent, the code should also reflect the UI; and certainly the release notes [19:25:09] mwalker: the main showstopper for that is bug 1495 [19:25:24] !b 1495 [19:25:24] https://bugzilla.wikimedia.org/1495 [19:25:33] because to use zh variants one has to translate everything from scratch, for instance [19:25:39] Nemo_bis: which I fortunately have a patch in for :p [19:25:50] mwalker: the approach so far as been that we are not creating locales just because we can, but only when needed... hence 'fi' serves all Finnish speaking users regardless of the country they are in [19:28:03] Nikerabbit: I feel that makes sense from a projects perspective -- but I'm not seeing a downside for supporting it in the code -- are there performance concerns? [19:28:33] mwalker: we do have effective fallback system [19:30:09] I'm not seeing where fallbacks come into this outside of bug 1495 [19:31:54] we certainly cannot change the content of the wiki by locale, but it seems reasonable to me that we should make an attempt to serve a localized UI where possible [19:32:06] *shrugs* I know I also have a biased view on this due to fundraising [19:32:14] where messages in one country don't work terribly well in others [19:32:24] so locales would help us immensly [19:36:08] New patchset: Hashar; "(bug 45713) points jslint URL to the checkstyle report" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52076 [19:36:31] mwalker: we are serving localised UI where possible, aren't we? [19:36:40] especially with ULS [19:36:40] Nikerabbit: not in centralnotice [19:37:09] Nemo_bis: well, I can't speak for it [19:37:16] but they are getting better fallbacks soon [19:38:03] that's what he said, I was replying to your reply to that :p [19:38:12] New review: Hashar; "Example run:" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52076 [19:38:36] so -- you're saying that I can create a message in en-GB and ULS will allow me to display that? (or more specifically to my case, that I can create a language object for en-GB and pull messages from it that are localized?) [19:40:05] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52076 [20:18:11] New patchset: Demon; "Rewrite most of make-deploy-notes so it handles bugs in footers" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52086 [20:20:03] New patchset: Demon; "Rewrite most of make-deploy-notes so it handles bugs in footers" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/52086 [20:32:06] ^demon: https://gerrit.wikimedia.org/r/#/c/51891/ tiny change [20:49:50] James_F: https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf11 [20:57:34] New patchset: Krinkle; "gruntjs 0.4.0 (fc956fa002)" [integration/gruntjs] (master) - https://gerrit.wikimedia.org/r/52096 [20:57:34] New patchset: Krinkle; "NPM dependencies for gruntjs 0.4.0" [integration/gruntjs] (master) - https://gerrit.wikimedia.org/r/52097 [20:58:23] Change merged: Krinkle; [integration/gruntjs] (master) - https://gerrit.wikimedia.org/r/52096 [20:58:44] Change merged: Krinkle; [integration/gruntjs] (master) - https://gerrit.wikimedia.org/r/52097 [21:13:55] New patchset: MarkTraceur; "Parsoid: Voting, and added to gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52099 [21:14:10] hashar: ^^ [21:17:02] hashar: btw, how do I publish only 1 job via the api? [21:17:16] https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder#Deploy_changes [21:17:25] It always pushes them all, which can take hours [21:18:32] $ jenkins-jobs --conf etc/jenkins_jobs.ini update config/ [21:18:41] I guess maybe update can take a file instead of a directory? [21:20:31] Reedy: You're wonderful (as well you know). :-) [21:26:09] New review: Hashar; "(2 comments)" [integration/zuul-config] (master) C: -1; - https://gerrit.wikimedia.org/r/52099 [21:27:08] Krinkle: you can pass the job name as a last argument [21:27:19] Krinkle: jenkins-jobs --conf etc/jenkins_jobs.ini update config/ NAME_OF_JOB_HERE [21:27:22] ok [21:27:24] Krinkle: probably need to update the doc :-] [21:29:10] New patchset: MarkTraceur; "Parsoid: Voting, and added to gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52099 [21:29:13] hashar: Done %^ [21:29:30] ohh [21:29:34] the full block :-] [21:29:38] no need to let a comment in [21:29:38] hehe [21:29:39] sorry [21:30:52] New patchset: MarkTraceur; "Parsoid: Voting, and added to gate-and-submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52099 [21:32:23] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52099 [21:49:06] Krinkle: I have updated our jenkins job builder fork [21:49:12] Krinkle: 793a1fc..b1cfa3b [21:49:27] Krinkle: mostly work that Will Soula has done [21:50:03] hashar: any idea why "FOO=/bar; readlink $FOO" does not do the same as "readlink /bar" ? [21:50:14] for some reason it won't take a variable [21:50:24] drop the semi column ? [21:50:33] FOO=/bar readlink $FOO [21:50:39] No, doesn't matter [21:50:45] these are separate bash commands [21:50:48] echo $FOO works fine [21:51:36] Try it yourself [21:51:39] GRUNT_BIN='~/Development/wikimedia/integration/jenkins/bin/grunt' [21:51:40] FOO=/tmp; readlink $FOO [21:51:41] private/tmp [21:51:50] $ readlink ~/Development/wikimedia/integration/jenkins/bin/grunt [21:51:51] ../tools/node_modules/.bin/grunt [21:51:58] $ readlink $GRUNT_BIN [21:51:59] $ [21:52:01] nothing [21:52:10] $ echo $GRUNT_BIN [21:52:11] ~/Development/wikimedia/integration/jenkins/bin/grunt [21:53:41] piece of crap [21:53:46] ah maybe read link does not know how to expand ~ ? [21:53:53] could be [21:53:56] tryout with /home/krinkle instead of ~ [21:54:15] there might be a way to ask bash to expand it for you [21:54:18] anyway, I did it a cleaner way [21:54:20] no need for readlink [21:58:20] hashar: Yay, tests passing (locally) [21:58:27] $ ~/Development/wikimedia/integration/jenkins/bin/wmfgrunt qunit --qunit-url='http://alpha.wikipedia.krinkle.dev/wiki/Special:JavaScriptTest/qunit' [21:58:27] Running "qunit:all" (qunit) task [21:58:27] Testing http://alpha.wikipedia.krinkle.dev/wiki/Special:JavaScriptTest/qunit................................................................................................................Exception thrown by test.module1: expected [21:58:29] Error: expected [21:58:31] ....................................................OK [21:58:33] >> 822 assertions passed (3188ms) [21:58:35] Done, without errors. [21:58:46] \O/ [21:59:25] eventually will have to figure out how to get rid of "Exception thrown by test.module1: expected" :-D [21:59:30] but congrats! [22:00:20] Krinkle, if you expect the ~ to be expanded, don't put it inside single quotes :) [22:00:59] yeah, I figured that, I had it around it because there used to be a space in the real path [22:01:05] but then I moved it into ~ [22:01:14] anywy, not using that code anymore [22:04:04] New patchset: Krinkle; "JS: Refactor, upgrade and integrate grunt-contrib-wikimedia code." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/38645 [22:12:23] New review: Krinkle; "Needs `npm install` to be done on linux instead of macosx, so that the it downloads the correct pre-..." [integration/jenkins] (master) C: -1; - https://gerrit.wikimedia.org/r/38645 [22:27:53] New patchset: Krinkle; "JS: Refactor, upgrade and integrate grunt-contrib-wikimedia code." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/38645 [22:33:25] New review: Krinkle; "Swapped binary from phantomjs-1.8.1-macosx.zip for phantomjs-1.8.1-linux-x86_64.tar.bz2" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/38645 [22:33:31] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/38645 [22:45:08] hashar: re the patch you're working on for centralnotice to support sqllite -- do you happen to know anything about the rule in our coding conventions to "Don't add more than one column per statement:" because sqllite cannot support it? [22:45:24] binasher has had me modify a couple of patches to only use one modify per table [22:45:35] these two things seem like contradictions :) [22:47:00] * binasher doesn't care about sqlite  [22:47:49] mwalker: I am a noob :-] [22:49:30] hashar: updated https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder#Deploy_changes with the job name argument [22:49:52] Krinkle: great [22:50:00] pushing the test-mediawiki jobs now [22:50:20] and git-pulling intergration/jenkins updated on gallium [22:53:41] binasher, hashar; I'm just wondering if there is a secret way to reconcile these two requirements that I don't know about [22:54:10] New patchset: Krinkle; "QUnit: Add macro for QUnit and enable for test/mediawiki" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/52162 [22:55:04] New patchset: Krinkle; "QUnit: Add macro for QUnit and create jobs for test/mediawiki" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/52162 [22:56:08] New patchset: Krinkle; "QUnit: Enable qunit job for test/mediawiki" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52163 [22:56:41] New patchset: Krinkle; "QUnit: Enable qunit job for test/mediawiki" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52163 [22:56:48] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/52163 [23:01:16] hashar: Theres a few entries in zuul.log that look off [23:01:24] not sure if they were there arleady [23:01:25] Unable to find change queue for project mediawiki/core [23:01:26] "Unable to find change queue for project mediawiki/core" [23:05:46] hashar: okay, so they are unrelated [23:06:10] I guess that is the pipelines discarding some changes [23:06:12] hashar: -merge is not working, I recall you had this problem before and was going to document it [23:06:14] but I don't see it? [23:06:15] https://integration.mediawiki.org/ci/job/test-mediawiki-merge/1/console [23:07:04] Krinkle: wrong repo maybe ? [23:07:21] well, I just listed it https://gerrit.wikimedia.org/r/52163 https://gerrit.wikimedia.org/r/52162 [23:07:27] I'm assuming the template takes care of the rest? [23:07:35] We use -merge everywhere [23:07:37] the test-mediawiki-merge list /var/lib/zuul/git/mediawiki/core which is mediawiki/core [23:07:48] Why ? [23:08:34] -_- [23:08:39] mediawiki.yaml [23:08:43] maybe test-mediawiki-merge needs an update [23:08:44] - job-template: [23:08:44] name: '{name}-merge' [23:08:47] is mwcore specific [23:09:34] I honestly don't even know the purpose of -merge afiak all of them do that by default (they have to) [23:09:40] I'll remove it afaik [23:09:46] I'll remove it again* [23:10:35] that prevents Zuul from trigerring all the other jobs [23:10:43] which would all fail with the same error :-] [23:11:13] It just needs one as a dependency, right? [23:11:31] anyway, as I said I'm removing it "again"