[01:00:18] New patchset: Zfilipin; "Upgraded Ruby to 2.0" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50860 [01:04:35] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/50860 [01:04:36] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50860 [01:25:20] hashar: I added QQQ placeholders and entries to messages.inc for watchlist grouping code. As well as fixing my rebase fails [01:46:31] Reedy nice :-] [01:46:41] Reedy: you will have to remember me about it [01:46:46] xyzram: :) [01:46:56] hi [01:47:03] So we could do with working out what else is left outstanding too.. [01:48:00] Reedy: working with xyzvram on Lucene right now [01:48:02] maybe tomorrow ? [01:48:06] (afternoon) [01:48:42] xyzram : ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config.git [01:53:04] Yeah [01:53:09] There's no big rush [02:07:14] hashar: Do you have a minute in 10 minutes (briefly walk to R31 if you can), just to say hi in the hangout :) [02:08:05] Or we can just create a new hangout/skype of course. [02:09:40] brb [02:27:35] test [02:48:56] Krinkle|detached: sorry was busy teaching xyzram some MediaWiki tricks :-] [10:18:07] Project _debug-irc build #16: SUCCESS in 0.33 sec: https://wmf.ci.cloudbees.com/job/_debug-irc/16/ [17:05:23] New patchset: Jeroen De Dauw; "Re-enable voting for EducationProgram" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/50916 [17:15:30] New patchset: Platonides; "Check the whole history of included files for Maintenance.php" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50918 [17:30:18] Project _debug-irc build #17: SUCCESS in 90 ms: https://wmf.ci.cloudbees.com/job/_debug-irc/17/ [17:56:32] chrismcmahon: please notice that wmf-jenkins-bot posted to the channel! :) [17:57:12] \o/ \o/ \o/ \o/ \o/ \o/ and the crowd goes wild :) [19:52:17] mwalker: re wikitech-l, works for me [19:52:42] what does "git remote -v" show? [19:52:57] and what actual command did you type to get it to fail? [19:53:25] I'm doing a "git review -d Iaaf6ccebd8c40c9602748c58c3a5c73c29e7aa4d" [19:53:46] git remote -v [19:53:47] gerrit ssh://mwalker@gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice.git (fetch) [19:53:47] gerrit ssh://mwalker@gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice.git (push) [19:53:47] origin https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CentralNotice.git (fetch) [19:53:47] origin https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CentralNotice.git (push) [19:58:15] right [19:58:22] that change is in core, not CentralNotice [19:58:36] I am such an idiot [19:58:38] thanks :) [19:59:14] want to post a "never mind" followup on wikitech-l so you don't have half a dozen other people trying to debug that? ;) [19:59:42] oh yes, in process [20:53:28] New patchset: Spage; "Simple test that signup has Create account button" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/51002 [20:54:58] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/51002 [21:25:33] New patchset: Platonides; "Whitelist phpversion()" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/51027 [21:40:37] New patchset: Platonides; "dirname(dirname(__DIR__)) and JobQueueAggregatorRedis.php" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/51033 [21:52:42] Brio [21:56:32] hashar: I am getting old. Whom better to ask for code review E:RSS (this runs for example on mediawiki.org )? [21:56:49] Wikinaut: in meeting sorry [21:56:55] uh [22:55:56] Project _debug-irc build #18: SUCCESS in 0.31 sec: https://wmf.ci.cloudbees.com/job/_debug-irc/18/ [23:11:03] Krinkle, hey, are we supposed to add a dependency for mediawiki.jqueryMsg to use mw.msg? [23:11:57] This seems like a silly question now but I'm unsure :/ [23:12:10] Krenair: Only if you need it's parser [23:12:12] mw.msg is in core [23:12:18] e.g. $1 replacements and html escaping [23:12:30] if you need more than that ^, then you need to depend on jqueryMsg [23:12:46] which will provide support for {{SITENAME}},{{PLURAL}} etc. [23:12:54] and [[links]] [23:14:39] Hm we need {{PLURAL}} [23:23:32] Project _debug-irc build #22: SUCCESS in 0.28 sec: https://wmf.ci.cloudbees.com/job/_debug-irc/22/ [23:30:00] Ryan_Lane: I assume we're importing all of wikitech and not using the {{MoveToLabs}} template (which never took off) [23:30:04] Krinkle: yep [23:30:12] and we'll do cleanup after [23:30:21] ok [23:30:21] the way we were going this was never going to happen [23:30:28] Project MobileFrontend-mac-ipad build #253: SUCCESS in 6 min 56 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-ipad/253/ [23:30:29] jrobson: Bug 45459: Fix photo uploads not being marked as mobile edits [23:33:04] Project MobileFrontend-mac-iphone build #260: SUCCESS in 6 min 24 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-mac-iphone/260/ [23:33:04] jrobson: Bug 45459: Fix photo uploads not being marked as mobile edits [23:35:51] zeljkof: I know you just started wmf-selenium-bot, but you'll probably want it to go to #wikimedia-mobile instead. [23:36:07] teams with their own channels prefer that, and keeps -dev quieter [23:36:18] Krinkle: yes, fixing the channel as I write this [23:37:06] k [23:37:09] mediawiki core selenium tests will send notifications here, mobile frontent tests will send notifications to #wikimedi-a-mobile [23:38:15] New review: MZMcBride; "Looks good to me." [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50590 [23:40:46] New review: Platonides; "That check doesn't make sense. It's complaining about mediawiki coding style." [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50590 [23:48:46] New patchset: Spage; "Improve README" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/51069 [23:50:49] New review: Spage; "Some things Ċ½eljko said that seem useful. I ran this through http://daringfireball.net/projects/ma..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/51069 [23:54:53] can module require from different namespace than "Module:"?