[03:45:20] <Emw>	 if i want to search the source code of all extensions in gerrit for a certain string, is there a way to do that?
[03:50:05] <TimStarling>	 check them all out and then use grep
[09:48:11] <hashar>	 hello
[09:51:21] <saper>	 hello, hashar
[13:22:40] <DanielK_WMDE_>	 anyone up to reviewing a small patch? I'm kind of blocked on that.
[13:22:42] <DanielK_WMDE_>	 https://gerrit.wikimedia.org/r/#/c/49852/
[14:22:50] <hashar>	 DanielK_WMDE_: sure :-D
[14:22:56] <hashar>	 DanielK_WMDE_: status.php is unrelated :-]
[14:24:25] <hashar>	 DanielK_WMDE_: also I am wondering if you could add a new formatting option instead
[14:24:40] <hashar>	 in addition to text / escaped / parse / plain
[14:24:47] <hashar>	 maybe something like 'representation' or 'internal'
[14:24:56] <hashar>	 that would make it available to everyone
[14:29:05] <DanielK_WMDE_>	 hashar: i'd love it if Messages would know what format they *are* in, and then you tell them what format you *want*, and it figures out what conversion to apply.
[14:29:14] <DanielK_WMDE_>	 telling it directly how to convert sucks.
[14:29:59] <DanielK_WMDE_>	 hashar: Status.php is not directly connected, but it is related - the getters the the Message object make Status::getErrorsByType a lot more useful
[14:30:08] <DanielK_WMDE_>	 which was the original intention
[14:30:13] <DanielK_WMDE_>	 but it's noerged now, anyway
[14:30:17] <DanielK_WMDE_>	 *mergedf
[14:32:02] <hashar>	 DanielK_WMDE_: so your comment make sense :-]
[14:32:13] <hashar>	 err
[14:32:30] <hashar>	 your comments in Status.php can stay in the change since they are related to the new acessor
[14:32:40] <hashar>	 but really, that would be nicer to add a new formatting function
[14:32:49] <hashar>	 I guess you have one already?
[14:39:14] <DanielK_WMDE_>	 hashar: for Status? I wrote one elsewhere, yes, using MessageCache::parse.
[14:39:32] <DanielK_WMDE_>	 Status::getHtml doesn't seem to be used in core. I guess it could just be changed to actually return HTML.
[14:39:39] <DanielK_WMDE_>	 i suspect the current behavior wasn't intended
[14:46:45] <sumanah>	 thanks hashar
[14:57:23] <yurik>	 who knows why phpcs gives tons of duplicates?  https://integration.mediawiki.org/ci/job/mediawiki-core-phpcs-HEAD/2685/console
[14:58:05] <yurik>	 "Duplicate class name "ApiFormatBase" found; first defined in"    is repeated 20 times
[18:12:18] <rmoen>	 YuviPanda: Yeah!  I came through discussion tasty breakfast sandwiches :)  Can't wait to see you man.  When you coming through ?
[18:12:35] <rmoen>	 discussing^
[18:12:44] <YuviPanda>	 rmoen: at least a year, I guess :(
[18:12:47] <YuviPanda>	 rmoen: but wikimania?
[18:13:10] <rmoen>	 YuviPanda: awww well then hopefully wikimania.
[18:13:45] <YuviPanda>	 rmoen: yeah, hopefully.
[19:19:38] <Wikinaut>	 crossposted from #mediawiki: anyone against me submitting my last patchset of E:RSS Version 2.18 ?? https://gerrit.wikimedia.org/r/#/c/3925/ Code Review was done for previous patchsets
[19:19:50] <Wikinaut>	 by C.Steipp and Ori.Livneh
[19:20:03] <Wikinaut>	 from my point of view, it is ready for submission
[19:20:16] <Wikinaut>	 is it okay for you, if I submit now ?
[19:23:32] <marktraceur>	 csteipp, ori-l-away, ping re ^^
[19:24:17] <Wikinaut>	 csteipp: ori-l-away : 	crossposted from #mediawiki: anyone against me submitting my last patchset of E:RSS Version 2.18 ?? https://gerrit.wikimedia.org/r/#/c/3925/ Code Review was done for previous patchsets
[19:24:34] <Wikinaut>	 marktraceur: thanks
[19:24:39] <Wikinaut>	 I think, they will agree
[19:24:51] <marktraceur>	 Well, good luck to you
[19:25:04] <Wikinaut>	 because I didn't introduce (important) changes after their code review
[19:26:02] <Wikinaut>	 marktraceur: given, that a patchset x is codreviewed, and I add further ps x+1, x+2 ... which do not contain substantial changes...
[19:26:09] <Wikinaut>	 I think, I can submit
[19:26:18] <Wikinaut>	 can you confirm?
[19:26:49] <csteipp>	 Wikinaut: Yes, that shouldn't be a problem if you were just doing rebases or trivial updates
[19:27:26] <Wikinaut>	 csteipp: ty
[19:30:27] <Wikinaut>	 Reedy ?
[19:30:33] <Wikinaut>	 Reedy: ping
[20:47:25] <hashar>	 re
[21:31:49] <gerrit-wm>	 New patchset: Platonides; "Use stream_resolve_include_path to detect files loaded from pear" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50055
[22:22:02] <gerrit-wm>	 New patchset: Platonides; "Use stream_resolve_include_path to detect files loaded from pear" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50055
[22:23:18] <Platonides>	 ping csteipp
[23:25:37] <gerrit-wm>	 New patchset: Platonides; "Add support for dirname( __DIR__ ) to find-entries." [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50117
[23:26:04] <gerrit-wm>	 New patchset: Platonides; "Add support for dirname( __DIR__ ) to find-entries." [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50117
[23:44:52] <gerrit-wm>	 New patchset: Hashar; "(bug 44961) 'Patch Set' no more part of comments" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/50121
[23:51:25] <gerrit-wm>	 New patchset: Platonides; "Skip the $evaluatedFiles cache for Benchmarker.php" [mediawiki/tools/code-utils] (master) - https://gerrit.wikimedia.org/r/50122