[10:05:19] Hi matthiasmullie, extension DataModel had a samples,tests/DataModelSampleTest.php , it's missing from AFTv5/data. Good news, I tried it and it passes. [10:07:45] spagewmf: I had deleted it since datamodel no longer makes sense on its own; though it would probably make sense to create a test-suite specifically for AFT [13:12:45] New patchset: Hashar; "ops/apache-config linter will now Verified+2" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/49824 [13:13:57] New patchset: Hashar; "ops/apache-config linter will now Verified+2" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/49824 [13:14:10] New review: Hashar; "Patch Set 2: Verified+2 Code-Review+2" [integration/zuul-config] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49824 [13:14:11] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/49824 [13:28:36] hashar, what's wrong with https://integration.mediawiki.org/ci/job/mediawiki-core-jslint/842/console ? :/ [13:36:57] Krenair: jshint not passing ? ;-D [13:37:24] I can't see any useful errors [13:37:36] 13:12:34 Build step 'Execute shell' marked build as failure [13:37:55] yeah that is not showing up [13:37:58] not really useful [13:37:59] hmm [13:39:50] oh yeah [13:39:52] Krenair: so [13:40:00] the stupid console does not show anything [13:40:13] cause jshint output an XML feed which is redirected to a .xml file [13:40:21] the result is in https://integration.mediawiki.org/ci/job/mediawiki-core-jslint/842/checkstyleResult [13:40:23] at [13:40:24] https://integration.mediawiki.org/ci/job/mediawiki-core-jslint/842/checkstyleResult [14:02:32] New patchset: Hashar; "jslint job now always show the help message" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/49828 [14:02:44] Krenair: https://gerrit.wikimedia.org/r/49828 [14:02:55] Krenair: the help message was not being shown in the console :-] [14:03:01] ty [14:03:38] New review: Hashar; "Patch Set 1: Verified+2 Code-Review+2" [integration/jenkins-job-builder-config] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49828 [14:03:40] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/49828 [14:07:53] marktraceur, hi. I tried to fix https://gerrit.wikimedia.org/r/#/c/3808/ up a bit [14:08:46] It's the oldest open changeset in Gerrit now: https://www.mediawiki.org/wiki/Gerrit/Reports/Oldest_open_changesets [14:11:03] The rebase included flickr support, so now it looks a bit odd: https://dl.dropbox.com/u/10971457/Wikimedia/MediaWiki/UploadWizardFlickrDragDropSupport.png [15:05:01] ^demon: if you got sometime, could you revise your vote on a change I made to some method declaration https://gerrit.wikimedia.org/r/#/c/48744/ [15:05:17] the bike shed is about the order of abstract/final/static/public keywords :-] [15:05:35] you asked for some statistics, I provided them as a comment on the change :-] [16:37:51] andre__: are you around? [16:38:03] zeljkof, yepp [16:38:10] great [16:38:23] who do I ask why guided tour is not working at test2? [16:38:41] do you know if it is already reported? [16:39:34] not working, or not deployed? [16:39:43] but yeah, https://test2.wikipedia.org/wiki/Wikipedia?tour=gettingstarted doesn't do anything [16:39:56] and https://noc.wikimedia.org/conf/InitialiseSettings.php.txt says it's deployed on test2 [16:39:59] it was working [16:40:06] in 'wmgUseGuidedTour' [16:40:11] I have noticed browser tests failing [16:40:24] should I report a bug? [16:40:33] or is there somebody I should ping first? [16:41:25] zeljkof: you could contact the E3 dev team, or file a bug report. As it's deployed I rather consider it a bug [16:41:43] thanks [16:41:49] how do I contact them? [16:41:56] is there a mailing list? [16:42:03] * zeljkof is checking wmf lists [16:43:22] I could not find e3 list here https://lists.wikimedia.org/mailman/listinfo/ [16:45:35] zeljkof: why is either not listed, or really not public, would be another interesting question. [16:46:04] not sure how to join it [16:46:16] I will try sending mail there and see what happens [16:46:39] ok, list page is here [16:46:40] https://lists.wikimedia.org/mailman/listinfo/e3-team [16:48:40] zeljkof, then you found another bug worth to report about the mailing lists list. ;) [16:48:50] :) [16:49:01] I will file a bug in bugzilla for now [16:49:08] that seems to be a better way [16:49:44] +1 [16:49:48] and in Wikimedia/MailingLists [16:50:05] probably Wikimedia/TestingInfrastructure [16:50:48] Wondering how to change the channel topic here, to mention https://www.mediawiki.org/wiki/Bug_management/Triage/20130219 [16:52:00] *** Git/Gerrit Bug Triage starting in 10min in #wikimedia-dev (this channel) - Feel free to join, everybody welcome! More info: https://www.mediawiki.org/wiki/Bug_management/Triage/20130219 *** [16:58:07] <^demon> Hi folks :) [16:58:30] hi [17:00:25] So.... Welcome everybody to our Git/Gerrit Bug Triage which will take place here in the next hours, led by ^demon, valeriej and andre__ ! [17:01:06] We'll be looking at Git/Gerrit bug reports: http://etherpad.wmflabs.org/pad/p/BugTriage-2013-02 [17:01:16] and more info can be found here: https://www.mediawiki.org/wiki/Bug_management/Triage/20130219 [17:01:47] <^demon> Ok, first one that I'm curious about is https://bugzilla.wikimedia.org/show_bug.cgi?id=35860 [17:01:49] with a general focus on upstream issues that got fixed, since a new version of Gerrit was deployed to Wikimedia servers recently [17:02:06] <^demon> I'm thinking this is generally better now, and the referenced problem change seems to work well for me. [17:03:02] Heh. My Firefox 18 says: [17:03:03] <^demon> Ah, not in firefox. [17:03:07] <^demon> Just tried that. [17:03:08] A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete. [17:03:08] Script: https://gerrit.wikimedia.org/r/gerrit_ui/CF42DB02C9A85777BE331C90AA0419DE.cache.html:4386 [17:03:30] Same for me [17:03:58] * andre__ tries to find the memory issue instructions for Firefox in his Mozilla triage script [17:04:37] <^demon> Works fine for me in safari and chrome. [17:04:49] <^demon> But yeah, can definitely replicate in firefox. [17:06:48] so entering about:memory?verbose in Firefox' address bar might provide some more info [17:10:26] ^demon, I'll file an upstream ticket in bugzilla.mozilla.org about bug 35860 [17:10:40] <^demon> 8,388,608 B (10.28%) ── string(length=4181450, "a:49286:{s:19:"8:filereado...") looks fairly suspicious. [17:13:02] <^demon> https://bugzilla.wikimedia.org/show_bug.cgi?id=35802 is definitely not fixed. I had it fixed, but I got reverted. [17:13:46] <^demon> qchris: Actually, Robla mentioned that one to me the other day and was wondering if it'd be an easy one for you to knock out. [17:14:03] * qchris just takes a look [17:16:40] <^demon> I believe 35883 is fixed. I'll leave a comment asking saper to confirm. [17:18:37] so I've forwarded https://bugzilla.wikimedia.org/show_bug.cgi?id=35860 to https://bugzilla.mozilla.org/show_bug.cgi?id=842623 and added the "upstream" keyword, and that URL to the "See Also" field, and set "Web browser" to "Firefox". [17:19:28] <^demon> What's mozilla going to say? "Lol fix gerrit?" [17:19:37] <^demon> :) [17:20:04] <^demon> I've never reported to Mozilla, have no experience. Thanks for filing! [17:20:27] For whatever it's worth: The file referenced in 35860 worked nicely for me when turning diff coloring etc off. [17:20:46] (in firefox) [17:20:48] <^demon> Hmm, wonder if it's code-prettify causing problems. [17:20:58] ^demon, we'll see what they'll say. They could make their browser more robust, for example :) [17:21:04] <^demon> Indeed. [17:21:08] I read lots of similar problems with coloring diffs. [17:21:21] Was this ever reported upstream? https://bugzilla.wikimedia.org/show_bug.cgi?id=36467 [17:21:24] <^demon> Yeah, I've gotten the impression code-prettify isn't great. [17:21:32] If so, we can add a link to that report. [17:22:09] <^demon> valeriej: I don't believe so. But qchris has done some work on the search predicates...dunno if that's related. [17:22:41] no i do not think it's related. [17:23:03] search needs lots of TLC :-( [17:23:12] <^demon> Indeed. Lucene. [17:23:29] Yes :-) [17:23:34] <^demon> I know why (2) is a bug. [17:23:48] <^demon> Something about the search code requires an is: by default. You can't search all statuses. [17:23:57] <^demon> So it implies is:open if you omit an is: [17:24:05] https://code.google.com/p/gerrit/issues/detail?id=1441 is "Optimize commit message search predicate" [17:24:08] <^demon> Yeah [17:24:19] <^demon> That's why is:merged + message:foo is slow. [17:24:25] <^demon> Problem (3) [17:24:26] status:open i guess. and this is expanded and there the mayhem starts... [17:24:36] <^demon> Yep. [17:24:51] several issues in one report. sigh. [17:34:52] * andre__ tries to do several things at the same time. Probably not good. [17:37:07] * andre__ writes that bug 35948 is still valid [17:37:11] Reedy: did you deploy to test2wiki and mw.o yesterday? http://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap#Schedule_for_the_deployments [17:39:36] <^demon> andre__: That's never been an upstream bug--requires someone to work on the hook scripts we maintain. [17:40:46] I know. I sometimes get side-tracked, I admit. :) [17:45:29] <^demon> andre__: I'm curious if the various opera bugs will all become non-bugs soon ;-) [17:45:51] haha [17:45:59] true, WebKit FTW [17:46:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=36169 ("Whitespace fixer to gerrit") looks rather like "Allow editing code in Gerrit" to me. [17:47:01] also upstream, I guess? [17:47:25] <^demon> Editing code in gerrit would be nice, but unlikely to happen anytime soon. [17:48:06] I'll tag it as upstream. It's nothing we're gonna implement. [17:51:27] I'll give bug 36172 a shot in Chrome now. [17:51:28] <^demon> The semi-related bug 35600 wouldn't be too hard I think. [17:51:46] <^demon> If we agree it's a good idea. I know there's some people who don't like being told they have trailing w/s. [17:52:27] <^demon> Now that the commit validation stuff went in. [17:52:58] geez, ^demon was faster with testing. [17:53:06] 36172 I mean [17:54:08] ^demon, shall I also leave an upstream ticket comment if we both cannot reproduce the problem anymore? [17:54:41] <^demon> Lemme track down where that was fixed. [17:55:22] oh, sounds like you want FIXED instead of WORKSFORME. okay. :) [17:55:52] <^demon> Ah, I think it's a dupe. [17:57:51] <^demon> It was probably https://code.google.com/p/gerrit/issues/detail?id=1759. [17:58:01] <^demon> Or https://code.google.com/p/gerrit/issues/detail?id=735 [17:58:23] <^demon> But one of those two definitely fixed 1492 [18:03:58] ^demon, "Unified diff on one page" https://bugzilla.wikimedia.org/show_bug.cgi?id=38100 is high priority, but not much happening at https://code.google.com/p/gerrit/issues/detail?id=938 - does the priority make sense then? [18:06:03] <^demon> It'd be super nice, but there's licensing problems :\ [18:10:58] I fail to find where to enable "Intraline Difference" in Gerrit... [18:11:20] ntraline Difference? [18:12:16] yeah. some bug reports mention it for Reviews, and I'd like to reproduce. Cannot find it in Review view nor in Preferences though. [18:14:14] <^demon> It's in your patch preferences. [18:14:28] <^demon> Under syntax coloring [18:15:02] <^demon> Heh, trying to merge the unified diff didn't end well: http://p.defau.lt/?osFKysAmuLyQLO9JS3HcYg [18:18:05] ^demon, so I'll close 36172 as FIXED (the one with two potential upstream fix candidates) if that's okay with you [18:18:13] <^demon> Sounds good. [18:23:31] upstream Gerrit bugtracker is so untidy, sigh.... want to clean up... [18:23:34] I'll upstream https://bugzilla.wikimedia.org/show_bug.cgi?id=35967 [18:23:40] 'Gerrit git review enforces "Topic" too strong' [18:24:34] <^demon> That's a git-review bug. [18:24:36] <^demon> Not gerrit. [18:25:12] <^demon> They use launchpad, I believe. [18:26:15] urgh. True, thanks. Darrn. [18:35:23] <^demon> Lunchtime. I'll be a bit less attentive for a bit. [18:45:06] ^demon: When you get back: https://bugzilla.wikimedia.org/show_bug.cgi?id=36684 Do you plan on disabling the behavior or increasing the interval? [18:46:15] * andre__ also less attentive - preparing dinner [18:48:35] <^demon> I tried to disable the behavior (setting interval to 0 does that). [18:48:37] ... and adding git-review's upstream home to mw:Bug_management/Upstream_bugtrackers after reading its README file... [18:48:41] <^demon> We could set it to some huge number. [18:48:42] launchpad was right :) [18:49:03] <^demon> Retry like once a week :p [18:54:03] hi [18:57:33] hashar: Hello! [19:01:55] valeriej: :-] [19:02:03] valeriej: turns out I am over busy tonight ahah [19:02:18] daughter is sleeping already, still have to cook dinner [19:02:40] hashar: No worries! [19:02:48] the list of git gerrit bugs is soooooo long [19:04:39] hashar: Indeed. :) [19:19:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=40241 Upstream bug says a fix was released. It looks like this can be closed. [19:21:14] Pah, calling 70 bugs a long list. :D [19:21:56] :-) sorry I've been absent [19:22:41] valeriej, but it's still not working for elseif, see the example :-( [19:22:46] Hm, reading the upstream bug descriptions... now I'm not sure... [19:22:55] andre__: Yeah. [19:23:26] so still valid :-/ [19:23:34] feel free to add a comment "Still valid" in that case [19:23:44] ...and update the Etherpad with a short comment [19:30:09] dinner sorry [19:33:39] 1 [client 208.80.152.86] Invalid URI in request GET /wiki/PHP/SQL_Injection=../../../../../../../../../../../../../../../../../../../../../../../../proc/self/environ HTTP/1.0 [19:33:40] lol [19:37:47] we should implements it [19:38:11] SQL Injection? [19:38:47] yeah [19:39:07] and grant the attacker an access on a fake database :D [19:39:11] would be fun to watch [19:39:31] that is an "honey pot" [19:41:31] like https://noc.wikimedia.org/conf/highlight.php?file=LocalSettings.php ? :) [19:41:46] andre__: kind of :-] [19:45:51] * andre__ off for dinner etc. [19:45:57] be back later [19:49:19] <^demon> qchris: This seems to happen intermittently https://gerrit.wikimedia.org/r/plugins/hooks-bugzilla/Documentation/index.html [19:49:39] ? [19:49:51] Mhmm anything in the logs? [19:50:04] <^demon> Yup, IllegalStateException from JarFile. [19:50:15] <^demon> From the call in HttpPluginServlet.onDefault() [19:51:05] * MatmaRex commented on https://bugzilla.wikimedia.org/show_bug.cgi?id=45163 [19:53:14] * qchris just pushes a few commits upstream and then he'll take a look. [19:53:51] <^demon> Heh, speaking of upstream. [19:54:06] <^demon> Dave was busy. Looks like he just pushed 26 commits to master :p [20:01:24] [20:01:36] haha [20:01:48] I am a carnivore but I don't think today's lunch will have meat in it [20:02:03] Startling none-the-less, I assure you. [20:46:55] ^demon: *...* [20:47:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=38114#c5 [20:47:08] https://gerrit-review.googlesource.com/#/c/36560/ [20:47:22] Is that the stylesheet we wrote live on gerrit-review as well? They're using it as their default? [20:47:43] Or has it even replaced the yellow style completely? [20:48:08] <^demon> Yep, it's replaced it entirely. [20:48:17] <^demon> No more puke green/yellow. [20:48:25] I clicked it and initially thought I was on the wrong tab, since it looked to good to be a gerrit repo :P [20:48:48] I'm glad they dumped piss yellow (cf. friday night dinner) [20:49:07] Oh well, so, we're on 2.5 [20:49:09] That's awesome [20:49:29] <^demon> Almost-2.6 :) [20:51:49] ^demon: I can now reproduce the "zip file closed" problem. It's not the plugin :-) It's gerrit's (un)loading :-( [20:52:00] You can achieve this with any plugin. [20:52:17] <^demon> Yeah, I figured it wasn't specific to the plugin. [20:52:47] It happens when a plugin is removed from the plugins folder, gerrit cleans up all of them [20:53:16] <^demon> Ah. [20:53:28] Pages that have been visited before are still available. Pages that have not been visited get the "zip file closed" problem upon first visit [20:53:51] I'll look into that tomorrow if that's ok for you. [20:54:23] <^demon> Sounds fine. I removed a plugin I had been testing, so it's probably my fault. [20:55:06] Restarting gerrit should bring everything up correctly again. [21:50:09] kaldari: hey, got a moment? [21:50:17] sure [21:51:24] kaldari: for direct Flickr upload on Commons via UW -- do you think it'll ever be accessible to any logged-in user? [21:51:28] or just to, like, filemovers? [21:52:12] As far as I'm concerned, it up to the Commons community [21:52:19] Sure, I ask what you predict [21:52:22] if you have a prediction [21:52:48] hard to say, the Commons community is sharply divided on the issue of Flickr images [21:53:03] I should have known [21:53:06] a lot of Commons admins want Flickr to die [21:53:21] because it is a place people put their photos and is not Commons? [21:53:35] due to how much work it creates (policing copyvios) [21:53:37] ah [21:53:43] ok, that makes sense [21:54:09] and even if the Flickr user who puts up an image says "CC-BY" that doesn't mean they were actually careful about where they got it from [21:54:10] right? [21:54:15] transitive licensing hygiene? [21:54:19] but, of course, a lot of people on Commons want Commons to be a larger repository and would welcome more images from Flickr [21:54:38] yeah, aka, Flickr-washing [21:54:44] MaxSem: hey, just curious: a while back you suggested using isset( $wgAutoloadClasses[ 'FooClass' ] ) rather than class_exists( 'FooClass' ) -- what was the rationale? [21:55:09] I realized now that I adopted your suggestion without really understanding the rationale. [21:55:28] ori-l: I like class_exists( 'FooClass' ) better :P [21:55:39] less likely to confuse people [21:56:03] I think so too. [21:56:17] plus people don't always list subclasses in the autoloader [21:56:39] class_exists() is slower [22:08:35] MaxSem: what makes you think that? [22:09:31] in worst case, class_exists() calls autoloader, loads the file with that file, etc [22:09:51] less of a problem when you have APC around, of course [22:10:13] http://dpaste.de/Sswnw/raw/ [22:11:06] i guess that's not very helpful because DO_FCALL 'class_exists' is a bit of a black box [22:16:03] MaxSem, ori-l: Is Autoloader intended to be a definitive list of classes, or just a definitive list of files defining classes? [22:16:37] classes, I think [22:23:13] kaldari: It's a list of classes that might conceivably be used outside of the file they're defined in [22:23:17] So to be safe, all classes [22:34:03] "ssh -l aklapper gerrit.wikimedia.org gerrit foo" triggering "Permission denied (publickey)" while "ssh -p 29418 aklapper@gerrit.wikimedia.org gerrit foo" works is slightly confusing. [22:34:37] That's because you're not specifying -p 29418 in the first example [22:34:41] yeah, we should really get rid of that non-standard port number [22:34:58] theeere's a bug for that [22:35:03] I've tried to ssh to gerrit.wikimedia.org on the default port accidentally before. I wonder what wmf ops thought :P [22:35:11] Krenair_, ah, I see. Thanks [22:35:27] * greg-g waves (ok, he'll stop doing that with every new channel he joins) [22:35:36] yes, that's bug 35611 [22:35:41] greg-g! Welcome! [22:35:52] andre__: Hello there! [22:36:02] "We got to talk." :) [22:37:18] andre__: indeed we do.... I'm going to get some legs the next day or so, but if not this week, definitely next week. You will be here (SF), right? [22:37:44] yepp, will be in SF. [22:39:52] What script does the initial clones, when a new branch (e.g. 1.21wmf10) is rolled out? [22:41:31] I'd like to see https://gerrit.wikimedia.org/r/#/c/5130/ get more attention... 21 comments :P [22:43:14] Krenair_, there were a lot of requests for improvements, none of which were acted on. [22:43:21] Do you want to take over the change? [22:43:31] That could help move things forward. [22:44:51] Krenair_: http://lists.wikimedia.org/pipermail/mediawiki-api-announce/2013-February/date.html [22:44:56] Clipboard fail [22:45:02] Krenair_: The change could not be rebased due to a path conflict during merge. [22:51:03] superm401, I guess I could try... not sure if I can deal with all of the issues [22:51:56] Krenair_, at the very least you'll be moving it forward. It's not going to get merged anytime soon with no patch sets since April. [23:03:34] Alright: Thanks everybody who hung around here and helped a bit with the Git/Gerrit Bug Triage that took place in the last hours! Cheers. [23:06:26] oh there was one, good :) [23:06:54] saper, ~25 out of 70 tickets touched, it seems. [23:08:36] andre__: yeah my gmailbox hurts :) [23:08:51] what, there was a bug triage? [23:08:55] how'd i miss it? [23:09:13] aude: don't worry we can still make our own [23:09:26] WONTFIX bug 1 [23:09:27] saper: If your gmailbox says that after only a few emails, it does not know what real pain is. [23:09:28] http://code.google.com/p/gerrit/issues/ is an unreadable disaster [23:09:31] heh [23:09:37] yes, it is. [23:09:38] next time i'll be there [23:09:44] great! [23:10:06] aude: yeah I considered adding myself to cc on all git/gerrit bugs [23:10:16] so many gerrit bugs :o [23:10:32] andre__: actually, can you add marcin.cieslak@gmail.com as (hopefully not the only one) default assignee to git+gerrit? [23:10:33] saper, I can do that by editing the "default CC" in Bugzilla, and not even let you know before ;) [23:10:51] see, great minds think alike :) [23:11:12] * aude biggest complaint is that the +2 and jenkins checkmark disappear on a merged change [23:11:25] used to stay there [23:11:33] don't know if there is a bug for that [23:13:08] aude: from the list of all bugs? [23:13:30] saper, added you. good luck. :P [23:13:51] andre__: now I feel like somebody actually needs me for something [23:13:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=43485 looks similar yet different [23:15:05] saper: if you yearn for that, I can CC you on a lot of other stuff too. [23:16:05] also, i am "Aude" on gerrit (when i merge stuff) but aude in git when i make patches [23:16:23] seems no way to fix me "real name" on gerrit to match [23:20:00] andre__: can you also CC me by default on extension/CheckUser and extension/Collection? [23:20:24] aude: w8 [23:21:12] aude: you may ask to set your "cn" in LDAP to "aude", since you have cn=Aude, sn=aude and uid=aude [23:21:21] I have cn=sn=uid=saper and I'm very happy with it :) [23:21:58] hmmm [23:22:44] Duesentrib had this problem also recently, didn't know what to give gerrit on login [23:23:13] oh [23:24:52] saper the cn=sn=uid advocate :D [23:25:43] saper: andre__ may be away. I'll get that for you. [23:26:15] not that i care about stats at all (i don't), but [23:26:23] http://www.ohloh.net/p/wikibase/contributors counts me twice :) [23:26:38] and other places it's like that [23:26:52] Nemo_bis: I'm from the Redundancy Department [23:27:15] all those sockpuppets of aude [23:27:19] heh [23:28:02] aude: and you can't claim it to get them merged? [23:28:10] Nemo_bis: not tried [23:28:31] aude: *I* care about stats, you should :p [23:28:39] github bases it on email address [23:28:43] saper: I just added you as default CC to those extensions. [23:28:44] so i get counted as one [23:29:05] valeriej: thank you, not that it will make solving them faster :( [23:29:20] Nemo_bis: it's like edit count [23:29:36] * aude not have editcountis [23:29:45] :) [23:29:50] saper: More eyes can help. [23:29:51] editcountitis :) [23:30:31] valeriej: one of my checkuser changes ( a refactoring ) is stuck in gerrit forever https://gerrit.wikimedia.org/r/#/c/11562/ [23:30:46] looks unsurprising :p [23:32:45] saper: should you become maintainer of it? CU needs a bit of love, although not as tragically as other extensions [23:33:42] I'd love to [23:33:55] preferably co-maint [23:33:56] usually csteipp approves stuff there but would be nice to get more maintainers [23:34:09] I'd love to work with csteipp on it too :) [23:34:16] yay! [23:34:39] I'll take a look saper [23:35:14] csteipp: oh great [23:35:21] one day CU might get a new UI :) [23:35:29] would be great [23:36:09] but first we need to fix broken links to whois tools etc. that's shameful [23:36:18] yep [23:36:19] saper: Oh, good. It may not be there forever. I'll be heading out for a bit. [23:36:23] (I never use them but checkusers do) [23:37:00] this is one of those changes "don't touch what's not borken"