[09:06:27] <gerrit-wm>	 New patchset: Hashar; "decorrelate phplint and jshint jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48422
[09:07:50] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48422
[09:09:54] <gerrit-wm>	 New patchset: Hashar; "decorrelate phplint and jshint jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48423
[09:10:05] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48423
[09:42:27] <gerrit-wm>	 New patchset: Hashar; "(bug 44846) JSHint is always wrong in MediaWiki REL1_19" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48427
[09:42:45] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48427
[10:00:11] <gerrit-wm>	 New patchset: Hashar; "tweak jslint branch exclusion" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48431
[10:01:23] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48431
[10:13:35] <gerrit-wm>	 New patchset: Hashar; "mediawiki-core-jslint is a voter" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48434
[10:13:51] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48434
[10:37:15] <lechucks>	 hi all! anybody has working with Fileindexer extension?
[10:54:28] <Susan>	 lechucks: Doubt it. Why do you ask?
[10:56:57] <lechucks>	 well, i installed it but i have an error
[10:57:12] <lechucks>	  PHP Fatal error:  Call to undefined function intGetHashPathForLevel()
[10:57:31] <lazowik>	 uh
[10:57:34] <lazowik>	 looks like a typo
[10:57:54] <lechucks>	  i watched discussion page and i saw that code was changed for solution another error.
[10:58:05] <lazowik>	 nope, sorry, that's not C
[10:59:06] <lechucks>	 originally was "FileRepo::getHashPathForLevel" and changed to "intGetHashPathForLevel()"
[10:59:18] <lazowik>	 I can install and chceck that if you want
[11:00:07] <lechucks>	 this will be fantastic
[11:01:17] <Susan>	 You really want #mediawiki, not this channel.
[11:01:27] <lazowik>	 true
[11:25:13] <lazowik>	 lechucks: not installed yet
[11:25:15] <lazowik>	 but
[11:25:35] <lazowik>	 in the same file there are both intGetHashPathForLevel and FileRepo::getHashPathForLevel
[11:25:36] <lazowik>	 ...
[11:25:55] <lazowik>	 ioh
[11:25:56] <lazowik>	 oh
[11:26:04] <lazowik>	 sorry wrong channel
[13:20:56] <gerrit-wm>	 New patchset: Hashar; "phpcs-HEAD for test/mediawiki.git" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48446
[13:21:21] <gerrit-wm>	 New patchset: Hashar; "trigger for test-mediawiki-phpcs-HEAD" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48447
[13:21:42] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48446
[13:21:51] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/48447
[13:47:42] <gerrit-wm>	 New patchset: Hashar; "(bug 44567) phpcs-HEAD should skip" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48450
[13:52:58] <gerrit-wm>	 New review: Hashar; "Seems to work fine now :-)" [integration/jenkins-job-builder-config] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/48450
[13:52:58] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/48450
[14:03:51] <hashar>	 Reedy: gooood morning Sam!
[14:55:29] <hashar>	 ^demon: got a lame patch for you to review : https://gerrit.wikimedia.org/r/#/c/47074/
[14:55:41] <hashar>	 enforce  $wgDBuser = 'wikiuser'
[14:56:11] <^demon>	 I don't see why we'd ever change the core default, but fine.
[14:56:57] <hashar>	 I don't see either
[14:57:06] <hashar>	 but I guess Roan reasoning is "better safe than sorry"
[14:57:20] <hashar>	 will deploy
[14:58:25] <^demon>	 I'll grab some tinfoil. Let's make hats :)
[14:59:18] <hashar>	 ;-D
[14:59:19] <hashar>	 http://en.wikipedia.org/wiki/Tin_foil_hat
[14:59:32] <hashar>	 make sure to submit a pic of it on commons to enhance that article
[17:30:22] <MaxSem>	 ^demon, could you take a look at https://www.mediawiki.org/wiki/Git/New_repositories/Requests when you have the time, please?
[17:30:49] <^demon>	 I suppose I should.
[17:45:44] <^demon>	 MaxSem: Done.
[17:45:58] <MaxSem>	 thanks, Chad
[17:45:59] <MaxSem>	 :)
[18:14:08] <gerrit-wm>	 New review: Hashar; "@Platonides $PHPReserved list globals declared internally by PHP. One might want to access them from..." [mediawiki/tools/codesniffer] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/48353
[18:15:38] <gerrit-wm>	 New review: Hashar; "Ideally we would prepopulate an array containing all allowed globals by using array_merge(). That wo..." [mediawiki/tools/codesniffer] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/48353
[18:18:17] <gerrit-wm>	 Change merged: Hashar; [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/48353
[18:21:31] <gerrit-wm>	 New patchset: Hashar; "codesniffer: b03329d..1488273" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/48483
[18:21:45] <gerrit-wm>	 New review: Hashar; "Applied in production with https://gerrit.wikimedia.org/r/48483" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/48353
[18:21:56] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/48483
[19:00:21] <xyzram>	 getting an error when importing mwdumper SQL output:
[19:00:42] <xyzram>	 ERROR 1062 (23000) at line 34: Duplicate entry '0-Main_Page' for key 'name_title'
[19:01:00] <kaldari>	 marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=44883
[19:01:23] <xyzram>	 I have the "--default-character-set=utf8" option on.
[19:02:41] <xyzram>	 and I also changed the character set on the DB to binary as suggested here: http://www.mediawiki.org/wiki/Manual:MWDumper
[19:03:02] <xyzram>	 Anybody know what I'm doing wrong ?
[19:04:16] <marktraceur>	 kaldari: Sorry about that
[19:04:33] <kaldari>	 no problem, looks like it's probably an easy fix
[19:05:04] <marktraceur>	 I'd guess so
[19:05:12] <marktraceur>	 Just an addclass call somewhere
[19:27:08] <brion>	 xyzram: i'd guess you didn't clear out the page table before importing?
[19:32:32] <xyzram>	 This is a new install ...
[19:33:48] <xyzram>	 The import via importDump.php seems to work but horrendously slow.
[19:34:32] <xyzram>	 It will probably take 3 days to import a 5MB SimpleWiktionary dump file.
[19:35:01] <brion>	 a fresh mediawiki install will create a Main Page in the database
[19:35:10] <brion>	 so you might need to clear that out before importing
[19:35:20] <xyzram>	 Oh ... didn't realize that.
[19:35:39] <xyzram>	 How come the PHP import doesn't have the same problem ?
[19:36:46] <brion>	 the wiki's own import system is designed to check for conflicts
[19:37:00] <brion>	 mwdumper is designed for importing lots of data into an empty database
[19:39:29] <xyzram>	 So after going through the MW install process, do I delete all the tables (or all rows from all tables) before importing ?
[19:40:15] <brion>	 you can delete the rows from all the tables, or you can just create a fresh database from maintenance/tables.sql
[19:41:55] <xyzram>	 Are the default character set settings adequate or do those need to be tweaked too ?
[19:49:32] <apergos>	 you probably selected binary; this is fine
[19:49:43] <apergos>	 I think that's now the default as well
[21:54:11] <Jarry1250>	 Hey all. I'm looking at the [[:mw:Wikimedia_Engineering/2012-13_Goals#Visual_Editor]] raodmap, but I feel like I've seen a more up-to-date version somewhere
[21:54:15] <Jarry1250>	 Maybe a few weeks ago?
[21:56:20] <YuviPanda>	 Jarry1250: RoanKattouw_away showed a few slides on the metrics meeting on friday about the roadmap, I think
[21:56:52] <Jarry1250>	 Oh cool, I'm just after the most up-to-date thing so that'll do nicely
[21:57:07] <YuviPanda>	 :) I Think the video recordings were mailed out
[21:57:15] <YuviPanda>	 his was the second presentation, right after maryana's
[21:57:57] <Jarry1250>	 Sent out?
[22:00:04] <YuviPanda>	 Jarry1250: ? the recordings?
[22:01:41] <Jarry1250>	 YuviPanda: As in email? Jan 10 is on https://commons.wikimedia.org/wiki/Category:Wikimedia_Foundation_Metrics_and_Activities_Meetings
[22:01:58] <Jarry1250>	 But not Feb 7 (though some images from it are)
[22:04:02] <YuviPanda>	 looking
[22:04:22] <YuviPanda>	 Jarry1250: https://www.youtube.com/watch?v=17rTFSUy3Xk&feature=youtu.be
[22:04:27] <YuviPanda>	 says 'still processing' :(
[22:04:30] <YuviPanda>	 that maybe why it isn't up yet
[22:05:11] <YuviPanda>	 Jarry1250: that explains why it isn't up out yet, I guess
[22:05:22] <YuviPanda>	 Jarry1250: poke RoanKattouw_away i'm sure he'll be happy to put up his slides on commons
[22:07:31] <Jarry1250>	 You've already pnged him twice :)
[22:08:30] <YuviPanda>	 right
[22:08:47] <YuviPanda>	 unlike Wil Wheaton, he does not appear instantaneously when you mention him thrice
[22:08:53] <YuviPanda>	 but I am not tempted to try :)
[22:32:52] <hashar>	 !zuul-config is https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml
[22:32:52] <wm-bot>	 You are not authorized to perform this, sorry
[22:32:56] <hashar>	 ..
[22:34:47] <gerrit-wm>	 New review: Platonides; "My point was that we never use that (plus it doesn't make sense for the autoglobals)." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/48353
[22:44:51] <gerrit-wm>	 New review: Hashar; "I have encountered that issue at least one time, probably with argv so instead of hardcoding just on..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/48353
[22:45:12] <hashar>	 Platonides: have you tried code sniffer? :-D
[22:58:47] <Platonides>	 hashar, no
[22:59:13] <Platonides>	 where should I know more about it?
[22:59:21] <hashar>	 Platonides: I wrote a very basic doc at http://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer
[22:59:28] <Platonides>	 btw, do you have an idea why I could be getting an error at WikitextContentTest::testGetParserOutput with data set #0 ?
[22:59:32] <hashar>	 it covers the installation
[22:59:39] <hashar>	 setup to get our standard
[22:59:46] <Platonides>	 I get '<p>hello <i>world</i></p>', not the expected "'<p>hello <i>world</i>\n</p>"
[22:59:48] <hashar>	 and how to run it with some various possible reports
[23:00:12] <hashar>	 no idea about that one, maybe tidy ?
[23:00:24] <hashar>	 tidy is not enabled on the contint host
[23:00:34] <Platonides>	 I tried adding an assrtEquals $wgTidy, false
[23:00:37] <Platonides>	 but it didn't fail
[23:00:44] <Platonides>	 it's something changed by some previous test
[23:00:48] <Platonides>	 it works standalone
[23:01:20] <hashar>	 :-(
[23:01:36] <hashar>	 yeah that is the hard case
[23:01:40] <hashar>	 finding out what changed :(
[23:02:04] <hashar>	 one possible way is to dump the $_GLOBAL array and compare it between the working and non working builds
[23:02:05] <Platonides>	 I went back to September 2012, and it still fails
[23:02:14] <hashar>	 ah
[23:02:40] <hashar>	 Platonides: does it fail with a default LocalSettings.php ?
[23:02:50] <hashar>	 I mean without various $wg being set ?
[23:03:21] <Platonides>	 good point
[23:08:29] <Platonides>	 yes, it depends on something of LocalSettings.php
[23:09:38] <Platonides>	 btw, I sent the CV to WMF
[23:12:40] <hashar>	 Platonides: Niklas had several issues on translatewiki.net
[23:12:57] <gwicke>	 AaronSchulz: http://www.mediawiki.org/wiki/Parsoid/About
[23:12:57] <hashar>	 turned out that the site has ton of various $wg settings
[23:13:20] <hashar>	 Platonides: and tests not always take in account all of the settings. So it is merely about finding out which setting cause the issue and fix the test (sometime fix the code too)
[23:13:39] <Platonides>	 locating is usually the hard piece
[23:14:00] <hashar>	 yeah
[23:14:17] <hashar>	 I got all my $wg hacks in a file which is included from LocalSettings.php
[23:14:25] <hashar>	 so then I just comment out half the file, run the test
[23:14:40] <hashar>	 then un comment and comment another part
[23:14:40] <hashar>	 etc
[23:14:47] <hashar>	 until I isolate the setting
[23:15:41] <Platonides>	 PHP Fatal error: Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Source file does no exist' xD
[23:17:01] <hashar>	 :-D
[23:38:11] <Platonides>	 yes, it seems to be having $wgUseTidy = true in Localsettings
[23:39:21] <Platonides>	 but it's not just the variable