[05:18:12] <pastakhov>	 hi, all!
[05:18:14] <pastakhov>	 how to pass value from  php to javascript?
[05:18:20] <pastakhov>	 this for extension, I need to pass the value from localsettings in javascript
[05:41:44] <TimStarling>	 pastakhov: you can use a MakeGlobalVariablesScript hook
[05:41:58] <TimStarling>	 $wgHooks['MakeGlobalVariablesScript'] = 'MyClass::myFunc';
[05:42:02] <TimStarling>	 class MyClass {
[05:42:13] <TimStarling>	 static function myFunc( &$vars ) {
[05:42:25] <TimStarling>	 global $wgMyConfVar;
[05:42:34] <TimStarling>	 $vars['wgMyConfVar'] = $wgMyConfVar;
[05:42:35] <TimStarling>	 }
[05:43:15] <TimStarling>	 maybe with "return true" in there before the closing brace
[06:10:34] <pastakhov>	 TimStarling: thanks!
[07:55:22] <gerrit-wm>	 New review: Hashar; "That should already be in your local / personal git ignore. When ever you used vim and various git r..." [integration/jenkins-job-builder-config] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/44852
[07:59:16] <gerrit-wm>	 New patchset: Hashar; "whitelist Semantic MW authors" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/44854
[08:00:21] <gerrit-wm>	 New review: Hashar; "PS2:" [integration/zuul-config] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/44854
[08:02:57] <gerrit-wm>	 New patchset: Hashar; "jobs for mw/ext/Maps" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44958
[08:03:39] <gerrit-wm>	 New review: Hashar; "Will rebase on top of  https://gerrit.wikimedia.org/r/44958 which is the change adding Maps.   I for..." [integration/jenkins-job-builder-config] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/44853
[08:04:45] <gerrit-wm>	 New patchset: Hashar; "jobs for mw/ext/Maps" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44958
[08:05:23] <gerrit-wm>	 New review: Hashar; "Deployed that last friday :-]" [integration/jenkins-job-builder-config] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/44958
[08:05:23] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44958
[08:10:02] <gerrit-wm>	 New patchset: Hashar; "dependencies for Semantic{Maps,ResultFormats}" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44853
[08:10:51] <gerrit-wm>	 New review: Hashar; "Rebased on top of the change that build the Maps jobs: https://gerrit.wikimedia.org/r/#/c/44958/2" [integration/jenkins-job-builder-config] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/44853
[08:10:51] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44853
[08:14:15] <hashar>	 hello
[08:24:49] <Nikerabbit>	 hi hashar
[08:24:53] <Nikerabbit>	 https://integration.mediawiki.org/ci/job/mwext-Translate-testextensions-master/184/console what is this about?
[08:26:29] <hashar>	 that is the console for the Translate unit tests ? :-D
[08:26:35] <hashar>	 good morning
[08:27:10] <hashar>	 need to verify
[08:27:28] <hashar>	 apparently we have some sanitization tests that verify the value passed to @group in commnets
[10:21:52] <gerrit-wm>	 New review: Jeroen De Dauw; "Huh. Thanks for the tip. That seems like an argument against most gitignore files we have in wmf hos..." [integration/jenkins-job-builder-config] (master) C: 0;  - https://gerrit.wikimedia.org/r/44852
[10:26:20] <hashar>	 JeroenDeDauw: I guess so :-]
[10:26:36] <hashar>	 JeroenDeDauw: we can merge it in though :]
[10:27:13] <JeroenDeDauw>	 hashar: I guess it's usefull for those poor people that don't know about the global thing like me
[10:27:23] <hashar>	 indeed
[10:27:24] <gerrit-wm>	 New patchset: Hashar; "Added gitignore" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44852
[10:27:48] <hashar>	 do we really want to ignore  any dot file ?
[10:28:19] <pastakhov>	 JeroenDeDauw: hi, where uses function removeLine (), removeMarker (), etc in jquery.googlemap.js? they needed?
[10:29:38] <gerrit-wm>	 New patchset: Hashar; ".gitignore (for dotfiles and editor temp files)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44852
[10:30:04] <gerrit-wm>	 New review: Hashar; "* added comment in .gitignore" [integration/jenkins-job-builder-config] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/44852
[10:30:35] <hashar>	 JeroenDeDauw: I have added comments in .gitignore / updated summary https://gerrit.wikimedia.org/r/#/c/44852/4
[10:30:46] <hashar>	 JeroenDeDauw: if that works for you, I merge it :-]
[10:31:03] <hashar>	 I have set the -1 just to make sure you learn about the global .gitignore trick :-]
[10:31:37] <pastakhov>	 JeroenDeDauw: I'm talking about expansion maps. services\googlemaps3
[10:34:03] <JeroenDeDauw>	 hashar: sure, and ty
[10:34:18] <JeroenDeDauw>	 hashar: did not expect that one to end up with 4 patchsets tho ;p
[10:34:32] <hashar>	 JeroenDeDauw: patch sets are cheap
[10:34:42] <hashar>	 just +1 and I merge https://gerrit.wikimedia.org/r/#/c/44852/4 ;-]
[10:35:20] <JeroenDeDauw>	 pastakhov: I have no idea, I did not write those
[10:36:34] <gerrit-wm>	 New review: Hashar; "Per discussion with Jeroen. Not everyone knows about the global .gitignore :-]" [integration/jenkins-job-builder-config] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/44852
[10:36:34] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/44852
[10:36:38] <hashar>	 thanks !
[10:37:33] <pastakhov>	 JeroenDeDauw: @author Jeroen De Dauw
[10:37:48] <JeroenDeDauw>	 hashar: slightly odd that in order to put global config you need to set some global config pointing to a second config file
[10:38:03] <JeroenDeDauw>	 pastakhov: i created the file and original code
[10:38:12] <JeroenDeDauw>	 but assure you that it changed plenty since
[10:38:19] <JeroenDeDauw>	 just do a git blame :p
[10:38:34] <JeroenDeDauw>	 probably writen by kim/netbrain
[10:40:12] <pastakhov>	 JeroenDeDauw: ok, thanks
[11:19:56] <pastakhov>	 JeroenDeDauw: git said blame you https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Maps.git;a=blob;f=includes/services/GoogleMaps3/jquery.googlemap.js;h=46bee15a7978fa8dbdfa91a5203e85d0f6705fb3;hb=1abf9b5ce6c01f154621d8df521cbc6180cc31d1#l55
[11:21:10] <JeroenDeDauw>	 pastakhov: ????
[11:21:58] <JeroenDeDauw>	 pastakhov: https://github.com/wikimedia/mediawiki-extensions-Maps/blame/master/includes/services/GoogleMaps3/jquery.googlemap.js
[11:22:11] <JeroenDeDauw>	 looks like its blamed on me yes, since I applies someone else his patch
[11:22:12] <pastakhov>	 JeroenDeDauw: about function removeMarker
[11:22:23] <JeroenDeDauw>	 netbrain wrote those
[11:22:32] <JeroenDeDauw>	 Anyway, why are you caring who wrote them?
[11:22:44] <JeroenDeDauw>	 I don't have the answer to your question either way
[11:22:52] <JeroenDeDauw>	 Even If I'm wrong and did write it
[11:22:54] <JeroenDeDauw>	 ...
[11:23:01] <pastakhov>	 JeroenDeDauw: it seems they are not needed
[11:23:17] <JeroenDeDauw>	 pastakhov: them kill them if they annoy you :)
[11:23:52] <pastakhov>	 JeroenDeDauw: ok :-)
[12:33:49] <DanielK_WMDE>	 Reedy: can you do me a favor and review something for me? https://gerrit.wikimedia.org/r/#/c/38689/5
[12:34:04] <DanielK_WMDE>	 this has been sitting there for a month now. it fixes a fatal error on the live site.
[13:44:43] <Reedy>	 DanielK_WMDE: Sure
[14:58:22] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/44855
[15:04:32] <hashar>	 JeroenDeDauw: around ? :-D
[15:04:51] <hashar>	 JeroenDeDauw: for the Wikibase entry point at https://gerrit.wikimedia.org/r/#/c/44863/  just wondering if that is not a biit too much complicated
[15:04:53] <hashar>	 :-]
[15:05:05] <hashar>	 JeroenDeDauw: also  I am wondering if that would work both for a client and a server install
[15:05:18] <hashar>	 I believe the difference between both is based on some $wg setting
[15:07:05] <gerrit-wm>	 New review: Hashar; "ah great :-]" [integration/jenkins-job-builder] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/44836
[15:27:23] <DanielK_WMDE>	 hashar: eeewww... do we really need this?...
[15:27:58] <DanielK_WMDE>	 i mean, i guess it's needed for jenking to treat it as one extension
[15:28:40] <DanielK_WMDE>	 But it's three extensions. It will not work like one extension. If you load all three extensions at once, it's likely to cause trouble.
[15:28:44] <hashar>	 DanielK_WMDE: not really needed
[15:28:47] <DanielK_WMDE>	 (i guess we should check for that)
[15:28:48] <hashar>	 we can hack the jenkins extension loader
[15:28:56] <hashar>	 I have exchanged a few mails with Jeroen yesterday about that
[15:29:23] <DanielK_WMDE>	 i'd prefer that. if it doesn't cost too much time, that is.
[16:03:00] * hashar  waves

[16:03:03] <hashar>	 might connect tonight
[17:01:30] <Reedy>	 Hmm
[17:01:36] <Reedy>	 mediawiki-config tests might be broken
[17:01:39] <Reedy>	 https://integration.mediawiki.org/ci/job/operations-mw-config-tests/905/console
[17:01:43] <Reedy>	 16:26:57 1) dbconfigTests::testDbAssignedToAnExistingCluster
[17:01:44] <Reedy>	 16:26:57 Invalid argument supplied for foreach()
[17:02:09] <Reedy>	                 foreach( $this->lb['sectionsByDB'] as $dbname => $cluster) {
[17:07:07] <JeroenDeDauw>	 DanielK_WMDE: if you load all 3 at once it causes trouble??? should not :)
[17:07:17] <JeroenDeDauw>	 DanielK_WMDE: and like my comment on gerrit says
[17:07:21] <JeroenDeDauw>	 this is not perfect
[17:07:33] <JeroenDeDauw>	 its just going after the low hanging fruit with a rough approach
[17:07:36] <JeroenDeDauw>	 that works
[17:07:47] <JeroenDeDauw>	 which is better then not having anything work just because it could be better
[18:10:17] <My76Strat>	 Any issues?
[18:13:03] <My76Strat>	 Hello kaldari, I just got here, is there talk about the wiki being down?
[18:13:32] <My76Strat>	 in this channel?
[18:13:39] <Reedy>	 Not this channel
[18:13:43] <Reedy>	 But yes, it's down for most people
[18:14:17] <My76Strat>	 What is the tech channel too watch discussions?
[18:14:40] <Reedy>	 #wikimedia-operations
[18:14:50] <Reedy>	 though #wikimedia-tech is also relevant
[18:15:20] <apergos>	 if you go to -operations it really is a watch-only channel though because people work in there.
[18:15:35] <My76Strat>	 Right, I'll be opening this, and the other one at startup from here.
[18:16:34] <My76Strat>	 I don't mind watching, and I was surprised to see such calm, in a place I imagined would be abuzz.
[18:17:05] <binasher>	 should be sorted now
[19:45:19] <gerrit-wm>	 New patchset: Hashar; "whitelist Semantic MW authors" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/44854
[19:45:29] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/44854
[20:14:28] <gerrit-wm>	 New review: Krinkle; "How is that a do-not-submit reason? The entire purpose of our fork is so that we can experiment and ..." [integration/jenkins-job-builder] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/44836
[21:20:55] <gerrit-wm>	 New review: Ori.livneh; "- Use 'is' to compare w/None (x is None, x is not None, etc.)" [integration/jenkins-job-builder] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/44836
[21:27:28] <gerrit-wm>	 New patchset: Hashar; "PHP CodeSniffer macros and templates" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/45063
[21:27:28] <gerrit-wm>	 New patchset: Hashar; "phpcs jobs for mediawiki/core" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/45064
[21:28:28] <gerrit-wm>	 New patchset: Hashar; "phpcs jobs are non voting for now" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/45065
[21:28:29] <gerrit-wm>	 New patchset: Hashar; "triggers for PHP CodeSniffer" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/45066
[21:36:38] <hashar>	 so I found out that PHP has some coding standards
[21:36:51] <hashar>	 named PSR1 and PSR2  https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md  https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[21:36:53] <hashar>	 reading PSR2:
[21:36:57] <hashar>	 Code MUST use 4 spaces for indenting, not tabs.
[21:37:00] <hashar>	 There MUST NOT be a hard limit on line length; the soft limit MUST be 120 characters; lines SHOULD be 80 characters or less.
[21:37:04] <hashar>	 Opening braces for classes MUST go on the next line, and closing braces MUST go on the next line after the body.
[21:37:08] <hashar>	 Opening braces for methods MUST go on the next line, and closing braces MUST go on the next line after the body.
[21:37:14] <hashar>	 that is enough read
[21:37:21] <hashar>	 we are never going to support PSR2 :-]
[21:37:24] <Krenair>	 oh god
[21:37:31] <hashar>	 standard are a good thing
[21:37:38] <aude>	 oh no, tabs!
[21:37:50] <hashar>	 except the tab / space bikeshed
[21:37:54] <hashar>	 some other points are a good things
[21:38:05] <Krenair>	 The only thing I like it the line length limits
[21:38:29] <hashar>	 i do everything in terminals which are 80 chars wide
[21:38:41] * aude  has a bright red line in vim at 80 chars

[21:38:42] <Krenair>	 Are you from the 90s?
[21:38:45] <aude>	 do not cross it!
[21:38:52] <hashar>	 Krenair: kind of :-]
[21:39:25] <hashar>	 80 col + sometime 40 lines
[21:39:36] <hashar>	 I manage to have 3 split windows in such a small term hehe
[21:39:51] <hashar>	 then C+w, arrows  to navigate
[21:39:57] <aude>	 :)
[21:40:00] * hashar  reads PSR1

[21:40:05] <hashar>	 anyway
[21:40:18] <hashar>	 I looked a bit at CodeSniffer again
[21:40:26] <hashar>	 and might cherry-pick some rules from PSR1 / PSR2
[21:40:31] <hashar>	 to start reporting about them
[21:41:04] <hashar>	 Files MUST use only UTF-8 without BOM for PHP code.
[21:41:05] <hashar>	 hehe
[21:42:54] <hashar>	 will look at that later on
[21:42:55] <hashar>	 :-]
[21:42:57] <hashar>	 beeed time
[21:45:50] <hashar>	 beeed time
[21:45:52] * hashar  waves