[00:02:06] New patchset: Alex Monk; "Add me to the Zuul whitelist for MediaWiki core please" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712 [00:05:11] New review: Hashar; "Thanks for mixing my non alphabetically sorted list :-]" [integration/zuul-config] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/39712 [00:07:31] New patchset: Hoo man; "Adding myself to the unit test white list" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39711 [05:50:19] New patchset: Stefan.petrea; "Fixed totals in SquidReportClients" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39724 [08:38:31] eeexcellent, Jerkins is broken again [09:29:22] hello [09:34:39] New patchset: Hashar; "whitelist Marius Hoch (Hoo Man)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39711 [09:35:58] New patchset: Hashar; "whitelist Alex Monk (Krenair)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712 [09:37:39] New review: Hashar; "Rephrased commit message." [integration/zuul-config] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/39711 [09:37:43] New review: Hashar; "Rephrased commit message." [integration/zuul-config] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/39712 [11:11:11] off for long lunch, be back in roughly 2 hours [13:09:32] anyone familiar with multiversion? Reedy? [13:13:15] * apergos peeks in [13:19:27] it seems that MWScript.php corrupts unnamed arguments in $argv [13:23:08] hmm it's possible, I think I've only passed named ones in [13:23:23] lemme have a look [13:24:09] apergos, in wmf6/extensions/WikimediaMaintenance there is wikisWithSetting.php which I'm trying to get to work [13:25:10] I tried listing it as wikiless and not, but it seems to persistently chew the first arg [13:25:14] actually [13:25:23] the first arg is the one that needs to be --wiki= [13:25:25] every time [13:25:38] if you don't want a specific wiki put aawiki [13:25:59] hmm there is an exception for wikisWithSetting.php I see [13:26:03] just a sec [13:26:13] nah, I tried it too [13:26:37] ok, it will stuff in --wiki=aawiki if it's missing, according to the code [13:26:49] for wikisWithSetting.php in particular I mean [13:26:58] yes [13:27:11] so what does your command line look like? [13:27:40] mwscript extensions/WikimediaMaintenance/wikisWithSetting.php --wiki=aawiki wmgUseGeoData [13:27:51] $this->getArg() returns NULL [13:36:47] New patchset: Hashar; "warn users about gate-and-submit starting up" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39584 [13:40:35] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39584 [13:43:30] yeah there must be a reason it only goes throgh the logic if the first arg is an option and not --wiki=something (instead of the first arg is not an option at all) [13:46:52] New patchset: Hashar; "(bug 43300) stop voting Code-review -2" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39585 [13:47:40] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39585 [13:51:11] New patchset: Hashar; "update workflow with Verified+2 enhancement" [integration/doc] (master) - https://gerrit.wikimedia.org/r/39085 [13:51:28] New review: Hashar; "PS3 Bug 43300 requested we stop voting on Code-Review label as well, that " [integration/doc] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39085 [13:56:45] if you look at the args you can get to directly without using getArg, how are those? [13:57:40] or comparing to what $this->mArgs has in it [13:58:27] I think I'm not ready to blame the multi scripts but something in the maintenance class handling perhaps [14:00:47] apergos, $argv is array('--wiki=aawiki', 'wmgUseGeoData') indeed [14:07:07] don't you have to pass --setting=? [14:07:37] (just from looking at the wikiswithsetting script) [14:07:51] "setting" is a name of the arg purely for usage [14:08:28] e.g. it shows "Syntax: wikisWithSetting.php [value] [parameters] [14:08:36] ok [14:10:56] !g Ie12ef08b8692919056d66d9febd006dad96916ef [14:10:56] https://gerrit.wikimedia.org/r/#q,Ie12ef08b8692919056d66d9febd006dad96916ef,n,z [14:11:33] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39690 [14:12:50] I have no good thoughts but I still think you'll need to poke at the maintenance class handling of args [14:14:02] New patchset: Hashar; "(bug 42628) lint whitespaces using git diff --check" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37803 [14:14:15] New review: Hashar; "rebased" [integration/jenkins-job-builder-config] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37803 [14:15:32] New patchset: Hashar; "(bug 42628) lint whitespaces using git diff --check" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37803 [14:15:48] New review: Hashar; "rephrase a comment" [integration/jenkins-job-builder-config] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37803 [14:17:49] lets have fun now [14:17:58] git diff --check for the win [14:22:57] stepping out for a bit again (errand #2 and last for the day) [14:28:52] New patchset: Hashar; "(bug 42628) lint whitespaces using git diff --check" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37803 [14:33:36] New review: Hashar; "deployed for mediawiki-core-lint" [integration/jenkins-job-builder-config] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37803 [15:54:34] anomie: I got some more patch deployed :-) [15:54:41] anomie: sorry should have pinged earlier [15:54:54] hashar- Nifty. How many do we have left? [15:55:18] anomie: the wikimedia maintenance one https://gerrit.wikimedia.org/r/#/c/33388/ [15:55:27] and the huge https://gerrit.wikimedia.org/r/#/c/32167/ ;) [15:55:36] I have rebased it again [15:56:08] anomie: I was not confident enough in having it merged / deployed today [15:56:22] anomie: it mostly contains the change to use the getRealmSpecificFile() [15:56:31] anomie: I guess you could get it deployed on monday with sam ? [16:05:04] once again: Extension:Math (sorry for spaming about this issue) what information is missing a review https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 [16:05:25] ^^for a review [17:45:56] New review: Erik Zachte; "merged" [analytics/wikistats] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39724 [17:45:56] Change merged: Erik Zachte; [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39724 [18:14:58] AaronSchulz, we have 198246 refreshLinks jobs on enwiki, of them only 1241 unique [18:15:28] duplication owchie:) [18:17:10] MaxSem: based on what? [18:17:27] select count(distinct job_token) from job where job_cmd='refreshLinks'; [18:18:29] that means there are 1251 claimed jobs now [18:18:36] what does that have to do with uniqueness? [18:18:39] ah [18:18:45] *1241 [18:18:56] doing that on job_sha1 would be more useful [18:19:02] sha1 is dedup [18:19:21] my bad:) [18:29:33] New patchset: Ori.livneh; "whitelist Alex Monk (Krenair)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712 [18:34:28] Change merged: Ori.livneh; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712 [18:44:06] Krinkle|detached: when you have a moment, can you update gallium w/ https://gerrit.wikimedia.org/r/#/c/39712/ ? [19:03:48] MaxSem: hoy, can i pm? [19:03:56] sure [19:33:31] Dereckson: are you sure of https://www.mediawiki.org/w/index.php?title=Git%2FTutorial&diff=619162&oldid=619158 ? [19:33:51] Someone claimed somewhere that installing it via apt *seems* to work but in fact does not. [19:35:29] <^demon> Also, the versions in apt have tended to lag the versions in pip, fwiw. [20:08:09] ori-l: you there ? :-0 [20:09:36] uga [20:18:25] hi hashar [20:18:54] ori-l: I noticed you merged a change in zuul-config to whitelist Krenair. That does not deploy the change automatically though :) [20:19:12] ori-l: so that was just to let you know :)] [20:19:14] hashar: I know; I read your instructions. But I don't have access to gallium [20:19:29] I pinged Krinkle earlier to do it since I figure he'd be on again before you [20:19:48] ah lack of access is indeed a non goer :) [20:20:57] i wouldn't mind having access but i don't need it either [20:21:07] ori-l: I have reloaded Zuul :-) [20:21:22] New review: Hashar; "deployed :)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712 [20:21:39] hashar: thanks!! [20:21:44] ^ Krenair [20:21:57] Krenair: you are now whitelisted and unit tests will run for you :-] [20:21:58] thanks hashar and ori-l [20:22:31] ori-l: I will get in touch with you in january to talk about Vagrant and test isolation [20:22:39] ori-l: seems we could also use AppArmor [20:22:41] cool :) [20:23:00] * ori-l has to run at the moment [20:23:20] ori-l-away: have a good lunch! [20:44:35] hi, I'm trying to test out the VisualEditor on a local, private wiki, but I can't seem to enable it (?). I have parsoid running, and I've enabled it on NS_MAIN according to the setup instructions on http://www.mediawiki.org/wiki/Extension:VisualEditor - I'm having a hard time finding even error messages, though - I just see the default editor in VisualEditor:Sandbox, main namespace, etc. [20:44:56] I'm using the latest snapshot of both mediawiki and the visualeditor, I should say [20:45:04] do you have a preference enabled? [20:45:09] yeah [20:45:23] the enwiki install requires individual users to set the preference for themselves. [20:45:26] both in my account preferences as well as the default global setting in LocalSettings [20:46:20] RoanKattouw: ping ^^ [20:46:27] Roan may know. I do not. [20:47:16] okay [20:48:05] do I need $wgUseSiteJs = true; enabled? [20:48:44] i don't know. [20:49:20] ugly: one thing to also note is to test VisualEditor locally, you must also be running the Parsoid service. [20:49:37] rmoen: yeah I have it running, I can telnet to port 8000 [20:50:14] ugly: however, this is not the current issue. [20:52:09] you would think I'd see something in my debug log, at least [20:52:10] nada. [20:52:23] as if I hadn't enabled it at all from LocalSettings [20:53:25] So to confirm, you do not see the VisualEditor tab next to the edit tab on any page in the main namespace ( while logged in ) [20:53:52] nope, just a normal Edit tab [20:54:26] So in your user preferences you have Editing->Enable VisualEditor (only in the main and user namespaces) ticked ? [20:55:00] yeah [20:56:08] ugly: moving to pm [20:56:41] ppls, there seems to be a letter missing in the editor's special character function. Is that part of the code somewhere, or specific wiki config? [21:16:08] ugly: sorry man, my wifi is crap at the airport. Any luck yet ? [21:16:36] nah, was looking around at permissions, but everything looks readable [21:49:13] Nemo_bis: tested, ^demon is true, this is an old version [21:49:43] Dereckson: which however works? [21:49:55] * Nemo_bis knows nothing of what the faults were [21:52:28] <^demon> Dereckson: Huh? Context? I've been fighting comcast the last couple of hours and have no idea what anyone's talking about anymore. [21:53:28] Nemo_bis: it's 1.12... [21:53:39] ^demon: ubuntu package for git-review [21:54:26] Nemo_bis: yes, it works, but it misses some stuff like the -s [21:57:01] Nemo_bis: http://www.freshports.org/devel/git-review/ -> FreeBSD one is 1.20 [21:58:09] fedora 1.18