[10:21:07] New patchset: Hashar; "jobs for mw/ext/WikimediaMaintenancee" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39548 [10:21:28] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39548 [10:22:55] New patchset: Hashar; "pipelines for WikimediaMaintenance (will submit)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39549 [10:23:09] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39549 [10:25:47] New patchset: Hashar; "disable unit tests for mw/ext/WikimediaMaintenance" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39550 [10:26:01] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39550 [10:43:00] Is anyone here? [10:56:00] sprconan: yup :) [11:28:27] I am finding someone who is responsible for the jquery.ime github repository. [11:36:37] New patchset: Hashar; "run pep8 on operations/software" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39557 [11:37:07] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39557 [11:39:59] New patchset: Hashar; "pep8 for operations/software" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39559 [11:40:14] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39559 [11:42:07] sprconan: what is the URL ? [11:42:24] ahh https://github.com/wikimedia/jquery.ime#readme [11:43:13] sprconan: looking at the commit history that is the Wikimedia i18n team. they are in #mediawiki-i18n [11:43:34] sprconan: you can mail them too. https://github.com/santhoshtr and https://github.com/amire80 [11:50:16] bah [13:11:23] New review: Hashar; "You can abandon this change. We no more generate jobs this way but use Jenkins Job Builder instead." [integration/jenkins] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/32834 [13:15:24] <^demon> hashar: Can't you abandon it? [13:18:22] New patchset: Hashar; "Test extensions in multiple branches" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/38790 [13:18:59] New review: Hashar; "rebased" [integration/jenkins-job-builder-config] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/38790 [13:23:22] ^demon: now I can :-D [13:23:37] Change abandoned: Hashar; "We no more generate jobs this way but use Jenkins Job Builder instead." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/32834 [13:24:09] ^demon: mark told me he was unable to submit a change I made in operations/software https://gerrit.wikimedia.org/r/#/c/39556/ [13:24:15] ^demon: though he could CR+2 it [13:24:44] <^demon> Hmm. Lemme double check. [13:25:26] <^demon> hashar: Haha, ops can review it now. Roan and I were the only ones with submit :p [13:25:31] <^demon> https://gerrit.wikimedia.org/r/#/admin/groups/13,members [13:25:54] I can't view that group :-] [13:26:25] <^demon> Hrm. [13:26:33] <^demon> now you can [13:26:43] :-D [13:27:14] thanks! [13:28:09] worked for him ! [13:31:55] New patchset: Hashar; "Test extensions in multiple branches" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/38790 [13:43:01] hashar- How did the merging those config changes early this morning go? [13:43:51] anomie: I have managed to merge some [13:44:15] anomie: the WikimediaMaintenance has been merged. I had an issue on fenari earlier so it is not synced yet [13:44:25] anomie: some changes will need to be rebased AGAIN :( [13:45:19] trying out right now [13:45:33] sync-dir php-1.21wmf6/extensions/WikimediaMaintenance [13:45:34] ;°D [13:46:15] anomie: so at least we no more have then cross repo dependency [13:52:19] New patchset: Hashar; "testextensions now use the branch too" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39569 [14:00:32] New review: Hashar; "I have fixed the branch reference: remotes/origin/{branch} is invalid since we snapshot from a bare ..." [integration/jenkins-job-builder-config] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/38790 [14:00:32] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/38790 [14:01:33] New patchset: Hashar; "testextensions been split by mw branches" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39569 [14:01:53] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39569 [14:02:32] doh [14:02:37] Jenkins has 6 jobs running at once :-] [14:02:40] pooor gallium [14:07:32] <^demon> hashar: We should give it a slave :\ [14:07:53] ^demon: that is ok for now, it has plenty of CPU power [14:08:19] <^demon> Does https://integration.mediawiki.org/ci/view/Java/job/gerrit-plugin-replication/22/promotion/WMF%20Deploy/promotionBuild/2/ make any sense to you? [14:08:27] <^demon> I'm trying to use Promotion + Copy Artifacts. [14:11:26] ^demon: never used that [14:13:41] ^demon: could it be a permission issue? [14:14:08] ^demon: /srv/org/mediawiki/nightly/wmf does not exist [14:14:13] <^demon> Oh man. [14:14:14] missing "integration" after mediawiki [14:14:15] <^demon> Typo. [14:14:23] <^demon> integration/nightly/gerrit/wmf [14:14:33] and [14:14:37] it will work :) [14:17:39] <^demon> Yay, it worked :) [14:17:40] <^demon> Thanks. [14:18:37] <^demon> Hmm, ${GIT_REVISION} isn't working :\ [14:19:58] ^demon: GIT_COMMIT [14:20:07] which is not SVN_REVISION [14:20:08] ;-D [14:20:26] tip to get all env variable, add a build step that simply executes 'export' [14:20:32] that brings you all declared envs [14:20:43] <^demon> Ahh [14:23:13] <^demon> Hmm, doesn't seem to work still. [14:23:59] https://integration.mediawiki.org/ci/job/gerrit-plugin-replication/23/console ? [14:24:24] <^demon> Ah, when it's in the promotion stage, you use PROMOTED_* [14:24:30] <^demon> So in this case, PROMOTED_GIT_COMMIT [14:24:44] oh [14:29:36] <^demon> Yay, got it working for all my gerrit plugins. If I promote a build, it'll show up in https://integration.mediawiki.org/nightly/gerrit/wmf/plugins/ [14:30:03] <^demon> Now to do it for core. [14:40:34] <^demon> hashar: Got it working for core too :) [14:42:39] ohh [14:42:40] so you are generating tarballs? [14:43:05] <^demon> No, wars/jars. [14:43:11] <^demon> For gerrit [14:45:14] <^demon> I wanted to get the whole build system in jenkins A) So I don't have to do so much by hand, and B) Someone else could eventually replicate what I've done if they had to. [14:46:13] <^demon> I also publish gerrit nightlies at https://integration.mediawiki.org/nightly/gerrit/ for the gerrit community. [15:28:29] I have a change that depends on three other changes, although those three are not related to each other. Anyone know how to get that into Gerrit without blowing everything up, and without rebasing those 3 other changes to depend on each other in some arbitrary order? [15:28:33] I can think of three possibilities. 1) git stash my change, make a new branch from master, git merge --no-commit the three other changes, then git stash pop my change and recommit it as a merge + bunches of other code changes. Not sure what Gerrit would make of that, though, or what would happen when those other three get updated or merged. 2) Create a sandbox branch merging the three other changes, then rebase my change on top of that sandbox bra [15:28:33] nch. Not sure what Gerrit would make of that, either. At least future rebasing would be easier. 3) Take the Fermat approach: say "I have a truely marvelous change set, which Gerrit is too narrow to contain", and then wait until two of the three are merged. [15:30:06] <^demon> https://groups.google.com/forum/?fromgroups=#!topic/repo-discuss/jB4wVdWi9To [15:30:20] <^demon> anomie: See the second post in that thread [15:31:19] New patchset: Hashar; "warn users about gate-and-submit starting up" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39584 [15:31:20] New patchset: Hashar; "(bug 43300) stop voting Code-review -2" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39585 [15:31:51] <^demon> anomie: So, mixing a merge commit with real code changes seems like a Bad Idea. You can take the 3rd approach ;-) [15:33:51] ^demon- I already did, actually (see 38013). I just don't really want to wait to get it up for review. [15:35:28] <^demon> You could go ahead and push it and self -2 to prevent merging maybe? [15:36:36] <^demon> anomie: I'm trying to run the unit tests with the standalone, but I'm getting '"" is not a valid magic word for "invoke"' :\ [15:37:55] How to push when I can't express what it's based on? I think I'll throw it into a sandbox branch and link that for anyone who wants to look at it before I can actually get it into gerrit. [15:38:10] Unit tests on master, or which changeset? [15:38:53] (i'm not sure what is being talked about, but i think i did submit a merge-commit to gerrit once to get the dependencies right) [15:41:04] <^demon> anomie: master of core and Scribunto. [15:47:55] ^demon- Hmm. All the tests seem to pass for me here. I wonder what's going on with that. [15:48:01] <^demon> Dunno. [15:51:31] What's your Scribunto.magic.php look like? [15:58:09] New patchset: Stefan.petrea; "Fixed div-zero problems, fixed tablets" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39587 [16:18:30] New patchset: Diederik; "Add Stefan Petrea as whitelisted developer" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39590 [16:23:07] <^demon> anomie: http://p.defau.lt/?OYxDaqBnmji2hvpLJO4Mdw [16:24:08] ^demon- I hope that's a copy-paste error cutting it off at the end [16:24:44] <^demon> Indeed, it is. [16:25:38] hi anomie, replied, it seems this thread is getting out of hand :( [16:26:28] number of links on each page doesn't matter -- you still get the same results [16:34:42] <^demon> anomie: I merged your "compare standalone to sandbox" [16:34:56] <^demon> I also got sandbox compiled on osx. Will push those changes shortly. [16:40:02] ^demon- I can reproduce your unit test error locally if I convince $magicWords['en']['invoke'] to be unset, or remove the entry for loading Scribunto.magic.php from $wgExtensionMessagesFiles. No clue how you might be getting either of those to happen, though. [16:40:35] <^demon> Hmm, the error doesn't happen when I run the scribunto tests. [16:40:42] <^demon> Just if I run all of them (make phpunit) [16:50:53] <^demon> anomie: I've got a couple of easy reviews: https://gerrit.wikimedia.org/r/#/q/owner:Demon+is:open+(lua+OR+Scribunto),n,z :) [16:51:32] ^demon- Oh, ok. Let me try that then. I usually just run the Scribunto tests because running all tests takes so long. [17:07:40] hey, did somebody add me to jenkins's whitelist? i noticed it started -2ing my changes :P [17:08:15] ... Not being on the whitelist gives -2? [17:08:28] Oh, being on it gives you -2? What? [17:10:03] well, the tests fail [17:10:08] but it didn't run them before [17:10:15] https://gerrit.wikimedia.org/r/#/c/37503/ [17:12:05] whitelisted emails are here: https://gerrit.wikimedia.org/r/gitweb?p=integration/zuul-config.git;a=blob;f=layout.yaml;hb=HEAD#l81 [17:12:25] yeah, i just found it as well [17:12:30] doesn't look like i'm there [17:12:43] so it's either a bug, or a workflow change [17:39:19] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39590 [17:40:05] New review: Hashar; "Deployed, thanks for the patch!" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39590 [17:41:21] New patchset: Hashar; "Whitelist Stefan Petrea second email" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39599 [17:41:35] New review: Hashar; "follow up https://gerrit.wikimedia.org/r/39599" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39590 [17:41:45] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39599 [17:42:03] New review: Hashar; "deployed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39599 [17:44:06] New patchset: Hashar; "apply whitelisting to analytic jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39601 [17:44:41] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39601 [17:45:08] New review: Hashar; "deployed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39601 [17:45:49] the changes above are related to some requests made to me by analytics :) [17:46:07] hashar: can you look at #-tech real quick? [17:54:14] what's up with jenkins? [17:55:14] ori-l: I don't see anything obviously wrong, what do you see? [17:55:20] ori-l: depends on what you are asking about. it seems to be fully testing more changes than it should [17:55:41] (as i noted above) [17:56:02] hashar at #-tech wanted me to file a bug, but i'm pretty busy as well :/ [17:56:05] "No candidate revisions" ori-l [17:56:20] https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-databaseless/565/console [17:56:26] That does seem like bug material [17:56:45] MatmaRex: ^ [17:56:54] this change: https://gerrit.wikimedia.org/r/#/c/39602/ [17:58:02] heh [17:58:03] Hi, there will be a Wikimedia Mobile team office hour in #wikimedia-office - please participate:) [18:01:48] MaxSem: aren't office hours supposed to be in eng calendar? [18:02:22] Nikerabbit, I've no idea, it wasn't scheduled by me [18:18:25] hmph [18:18:30] twn:/resources/nike/wmf (wmf/1.21wmf6)$ git submodule update --init [18:18:30] Initialized empty Git repository in /resources/nike/wmf/extensions/wikidiff2/.git/ [18:18:34] fatal: '/mediawiki/extensions/wikidiff2.git': not a Gerrit project [18:18:36] fatal: The remote end hung up unexpectedly [18:18:39] Clone of 'ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/wikidiff2.git' into submodule path 'extensions/wikidiff2' failed [18:19:02] anyone who knows how to fix that+ [18:20:05] Nikerabbit: Well, it's not a repository [18:20:24] Nikerabbit, you should update your mediawiki/extensions.git [18:20:44] https://gerrit.wikimedia.org/r/#/c/38831/ [18:20:51] I just did git pull, isn't that enough? [18:21:11] note that this is mediawiki/core.git in wmf branch [18:21:26] Oh those might be broken still... [18:21:57] I would just delete the submodule [18:24:49] I did it with somehting like this IIRC: git config -f .git/config --remove-section submodule.extensions/wikidiff2 && git config -f .gitmodules --remove-section submodule.extensions/wikidiff2 [18:25:22] why not replace with the new location? [18:29:17] Nikerabbit, you don't usually include /php/ repos do you? [18:29:29] It's a PHP extension, not a MediaWiki one... [18:35:05] Nikerabbit: `git pull` in `extensions` directory removed that dir for me [18:40:32] it's not extensions repo! [18:41:10] D: [18:48:46] Is it new? [18:48:49] Who added it? [18:49:42] Reedy: it was deleted from extensions repo like krenair linked: https://gerrit.wikimedia.org/r/#/c/38831/ [18:50:27] ah [18:50:34] deleting submodules is annoying [18:50:42] <^demon> Deleting submodules is great fun. [18:50:52] <^demon> I'll fix it. [18:58:46] New patchset: Stefan.petrea; "Fixed div-zero problems, fixed tablets" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39587 [19:01:11] is there shell command to get the commit id of the submodules are pointing to? [19:02:34] Nikerabbit: git submodule status [19:02:41] It might give you some other stuff, too. [19:05:13] nice [19:06:43] Failing that, cd path/to/submodule && git log --mak-count=1 --pretty=format:"%H %ci" [19:10:32] New patchset: Stefan.petrea; "Fixed div-zero problems, fixed tablets" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39587 [19:22:09] Any bugzilla admins about? [19:22:27] andre__, ? [19:23:34] <^demon> Krenair: What's up? [19:23:38] pm [19:24:21] Krenair, yepp [19:26:46] andre__, has been dealt with by chad now. thanks anyway [19:27:25] ah, thanks, I saw it now [19:28:39] <^demon> andre__: Took care of it, sent a private e-mail to the user. [20:02:05] !g 39618 | ^demon [20:02:05] ^demon: https://gerrit.wikimedia.org/r/#q,39618,n,z [20:02:22] ^demon- Fixes that bug with the unit tests from earlier [20:14:34] <^demon> anomie: Just cherry picked, running now. [20:16:24] <^demon> Looks good, +1 :) [20:21:19] New review: Erik Zachte; "Two minor suggestions for SquidCountArchiveProcessLogRecord.pm" [analytics/wikistats] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/39587 [20:36:30] WTF, Gerrit? Why did it mark I81ba3228 and Ic416552f as merged because I referred to them in a sandbox branch? [20:37:31] New patchset: Stefan.petrea; "Fixed div-zero problems, fixed tablets" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39587 [20:37:59] New review: Erik Zachte; "approved" [analytics/wikistats] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39587 [20:37:59] Change merged: Erik Zachte; [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/39587 [20:40:45] ^demon, hashar - Any way to fix I81ba3228 and Ic416552f? I referred to them in a sandbox branch, so Gerrit decided to mark them as merged. WTF? [20:41:34] <^demon> Ugh, there's a bug for this. [20:41:39] <^demon> I hate when this happens. [20:47:38] ... Do they actually get merged? [20:48:32] yup [20:48:35] in the branch [20:48:41] !g I81ba3228 [20:48:41] https://gerrit.wikimedia.org/r/#q,I81ba3228,n,z [20:48:56] that is how one can merge a change in ops/puppet which freak out the ops :-] [20:49:02] oh ok, but not into master right? [20:49:12] well it is merged in the repo [20:49:18] but in your sandbox branch [20:49:26] the sandbox branch is harmless [20:49:28] you still have to get the sandbox merged in the target repo [20:49:55] i was worried about unauthorised people being able to force stuff past review [20:49:56] <^demon> hashar: We could get rid of the sandbox branches on the puppet repo ;-) [20:50:23] ^demon: I find the feature really cumbersome [20:50:38] <^demon> It's just a branch. [20:50:46] I guess the idea is that someone pick the patches in his sandbox, eventually improve them and then submit a merge request [20:51:10] <^demon> Either that. Or just a testbed to throw some patch you don't want to forget about. [20:51:15] i am wondering what workflow they add in mind when coding that merging feature though [20:56:52] * AaronSchulz finds himself wishing he had uuid4 [20:57:00] ^demon: can you look at https://gerrit.wikimedia.org/r/#/c/37052/7 sometime? [20:57:54] <^demon> I know zilch about uuid, I've been avoiding it :\ [20:58:26] ^demon: only that one function is based on the rfc [21:01:11] <^demon> I mean I guess it looks ok. Running the tests now. [21:14:07] <^demon> anomie: I'm getting a stupid failure from scribunto. "1) Scribunto_LuaStandaloneInterpreterTest::testTestMemoryLimit Failed asserting that exception of type "ScribuntoException" is thrown." [21:15:21] ^demon- Hmm, I'll have a look. Any luck fixing those changesets that got screwed up? Feel free to delete my sandbox branch if necessary. [21:16:17] <^demon> I'm not sure how to unwind it. I think in the past we just abandoned and made a new change (with a new sha1). [21:16:33] <^demon> The underlying problem has to do with using the same sha1 on multiple branches. [21:46:04] anomie: if still around. I did not get the opportunity to merge all the multi data center changes. [21:46:11] anomie: will work on that tomorrow morning again [21:46:15] hashar- ok [21:46:21] anomie: hopefully will manage to merge & deploy the remaining one. [21:47:14] I will have to rebase / tweak your change https://gerrit.wikimedia.org/r/#/c/32167/ again :] [21:47:33] though I will probably pick up changes from it and deploy them in independent changes [21:47:49] this way if something goes wrong, it would be easier to revert & spot the faulty line [21:52:34] New patchset: Hashar; "run pep8 on labs/nagios-builder" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39689 [21:52:50] New patchset: Hashar; "pep8 job for labs/nagios-builder" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/39690 [21:53:52] New review: Hashar; "job already created" [integration/jenkins-job-builder-config] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/39690 [21:54:01] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39689 [22:07:42] New patchset: Hashar; "labs-nagios-builder-pep8 is now voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39694 [23:28:33] New patchset: Hashar; "actually match all emails" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39710 [23:28:45] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39710 [23:37:40] New patchset: Hoo man; "Adding myself to the unit test white list" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39711 [23:38:49] New patchset: Alex Monk; "Add me to the Zuul whitelist for MediaWiki core please" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/39712