[00:04:28] Lexein: they has such bugs on Commons [00:04:40] afaik they solve it with {{rotate|0}} or so [00:05:05] rotate bot fixing the double rotation actual + EXIF with some magic [00:07:15] https://gerrit.wikimedia.org/r/#/c/37776/ - core reviewers, trivial patch here [00:19:39] Thanks Nemo_bis [05:04:19] Thanks Amgine - I filed a bug on the exif issue, and bawolff was auto notified [05:04:27] \o/ [09:07:32] New patchset: Hashar; "(bug 42905) Run JSHint on mediawiki/core" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37797 [09:08:22] New review: Hashar; "That did put JSHint in mediawiki/core.git workflow. We can retrigger the existing jobs by replying "..." [integration/jenkins-job-builder-config] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37797 [09:08:22] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37797 [10:12:12] hashar: hey! got time to skype? [10:18:44] New patchset: Hashar; "(bug 42628) lint whitespaces using git diff --check" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37803 [10:22:31] DanielK_WMDE: oh yeah [10:22:41] DanielK_WMDE: I am in a coworking place right now, so that is not ideal [10:22:51] DanielK_WMDE: mind using the plain text IRC instead ? [10:23:08] if you want audio, we can reschedule it tomorrow :-D [10:32:08] hashar: you just dropped off. did you get my message? [10:32:39] hashar: my second question is about jenkins for wikidata. what's the problem there? can I help? [10:36:33] DanielK_WMDE_: only got the message about skype [10:36:51] grr. just a sec [10:37:07] [11:25] hashar: oh, we can just chat here [10:37:08] [11:25] hashar: i have two questions. the first is... do you know how the ES setup works? [10:37:10] [11:26] this is a real issue, and I could use some help: https://bugzilla.wikimedia.org/show_bug.cgi?id=42825 [10:37:11] [11:26] who knows about this stuff except Tim? Asher? [10:37:22] ES assuming external storage, I have no idea how it works. [10:37:49] ES apparently the text table points to some cluster name and an ID then we do a SQL connection to that MySQL sub cluster and ask the id to get the text. [10:37:54] [11:32] hashar: my second question is about jenkins for wikidata. what's the problem there? can I help? [10:38:01] beside that, I don't know how ES works :( [10:38:13] and Tim is in vacations i think [10:38:31] hashar: yeah, that's how it works. but i don't know how the setup/config stuff works. well, it doesn't seem to work as I expected :P [10:38:39] so... whom to ask? [10:38:47] us (platform engineering) [10:38:48] hehe [10:39:35] we have a weekly call tonight, I can add this bug to our agenda [10:39:46] oh yes, please! [10:40:17] DanielK_WMDE_: you might want to add a wfDebugLog( "wikidata-es-fetch" ) in that code path [10:40:39] to log what is asked (aka db://clusterXX/YYYYY ) and the result ( ok / ko ). [10:40:45] that might help figuring out what is happening [10:41:08] though that might generate a huuuuuge log file [10:41:16] so maybe just log failures [10:42:09] hashar: we already did that. the blob url is ok. and when run through evel.php, it works [10:43:22] DanielK_WMDE_: do you have code to paste in eval.php to fetch an entry ? [10:43:55] Revision::getRevisionText( some object ) [10:45:13] soo many code paths that can be wrong [10:45:36] hashar: have to dig up the log from my conversation with ^demon [10:47:35] hashar: http://pastebin.com/cwjiCAzb [10:48:43] ah [10:48:45] hashar: when chad tried this, it worked. [10:48:56] but on the site, it fails [10:49:00] I just got PHP Notice: unserialize(): Error at offset 0 of 15292 bytes in /home/wikipedia/common/php-1.21wmf5/maintenance/eval.php(72) : eval()'d code on line 1 [10:49:22] hashar: o_O [10:49:42] interesting. [10:49:56] sounds like it's getting back an empty string (or false), and tried to deserialize that [10:50:02] then the question is... why does that happen? [10:50:13] can you find the line where the unserialize happens? [10:50:14] here my lame test: http://dpaste.org/7qwaL/ [10:50:37] in Revision::getRevisionText() whenever the row object is passed 'object' [10:50:41] hashar: ah, no, this has to be executed on test2wiki [10:50:44] as a flag [10:51:20] but you didn't even call that [10:52:14] hashar: but anyway - don't dig in too deep now. let's find someone who knows this stuff and move on :) [10:52:35] with test2wiki: [10:52:36] > var_dump( ExternalStore::fetchFromURL( 'DB://cluster25/316188' ) ); [10:52:37] bool(false) [10:52:46] so maybe test2wiki is not properly configured [10:53:08] yes. the big question is: how?! [10:53:28] anyway. what about the failing jenkins builds? why is this reported as a failure? https://integration.mediawiki.org/ci/job/Ext-Wikibase/2130/console [10:57:39] hashar_: ...shall I repeat? [10:59:29] so [10:59:36] I have pasted the bug report for our weekly meeting tonight [10:59:46] thanks [10:59:57] we will see :) [11:00:07] as for Wikibase job [11:00:13] I am going to phase out Ext-Wikibase [11:00:24] what time will it be? we have wmf6 deployment up for wikidata.org at 20:00 CET [11:00:26] to replace it with two jobs, one for client the other for server [11:00:30] I think you sent an email about it [11:00:34] ahh [11:00:42] the conf call is at 11pm CET [11:00:48] ic [11:00:56] not a big deal, the issue is about the client anyway [11:00:57] so might not work [11:01:11] maybe we can talk about it with chad and sam when they show up [11:01:27] bring it up in any case, it's a real blocker, even though we may be able to work around it for a week or two. [11:01:45] yea, though i have another issue to debug with them first [11:01:51] we are mostly lacking proper error logs though :/ [11:02:33] that could be changed: https://gerrit.wikimedia.org/r/#/c/37815/ [12:04:49] New patchset: Hashar; "lame hack to install MW Extensions under a workspace" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37824 [12:06:46] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37824 [12:14:11] New patchset: Hashar; "Jobs based on Gerrit Trigger have been disabled" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37826 [12:14:11] New patchset: Hashar; "explicits defaults set by Jenkins" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37827 [12:14:23] New review: Hashar; "sync with production" [integration/jenkins] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37826 [12:14:42] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37826 [12:14:46] New review: Hashar; "sync with production" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37827 [12:14:46] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37827 [12:22:40] Reedy: can you help me out with https://bugzilla.wikimedia.org/show_bug.cgi?id=42547 ? [12:23:27] I'd need https://gerrit.wikimedia.org/r/#/c/37792/1 merged and deployed, and then a debug file for the "wikibase" log group. [12:23:46] and then enable pollForChanges in cron again. [12:23:54] or shall we wait for chad to show up? [15:04:46] Nemo_bis_- Is it better to update /qqq messages for my extension on translatewiki or in Gerrit? If the former, poke. [15:04:59] New patchset: Stefan.petrea; "Added test for countries arithmetic" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37834 [15:26:10] Reedy: you there? [15:26:46] anomie: you can do it on twn, but if you are adding new messages you should mention that you already added them in twn to avoid -1 for missing docs [15:30:57] Nikerabbit- The /en messages are already in the code. One of the /qqq messages needs an update, a few more could use clarification, and then some got left out in the initial checkin that I may as well throw in. I can easily enough put all that into Gerrit, but if twn would prefer I do it through their thing I can do that too once Nemo_bis gives me the right permissions per his email. [15:33:13] anomie: 1) you can do it on twn 2) use the green button on the front page to get rights [15:53:48] New patchset: Hashar; "use a real mirror instead of just bare repository" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37845 [15:54:02] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37845 [15:55:16] New patchset: Hashar; "the bare clone of mw/core need to be a mirror" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37846 [17:50:12] New review: Diederik; "Ok." [analytics/webstatscollector] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36944 [17:50:13] Change merged: Diederik; [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/36944 [18:08:38] New review: Diederik; "Ok." [analytics/wikistats] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37607 [18:10:10] New patchset: Stefan.petrea; "Added test for countries arithmetic" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37834 [18:19:54] Reedy: chrismcmahonbrb - https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf6#Most_important_changes is that about right, as a summary? I know I'll be adding more when the extensions get added [18:24:17] csteipp, I saw https://gerrit.wikimedia.org/r/#/c/37858/ [18:24:44] You do realise I already made https://gerrit.wikimedia.org/r/#/c/28836/ right? [18:25:06] And you're listed as a reviewer [18:29:15] Ha, wow... Krenair, I totally missed that one. Sorry about that [18:30:55] Change abandoned: Stefan.petrea; "can't convince gerrit to accept my merge changes so I can git-review" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37607 [18:31:09] Krenair: I'll try and get your version merged, then I do want to break out the locking / hiding pieces into the CentralAuthUser class. I need to do all that logic in one more place too [18:32:45] New patchset: Stefan.petrea; "Refactoring bash scripts for generating reports" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37859 [18:33:30] New review: Diederik; "Ok." [analytics/wikistats] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/37859 [18:33:30] Change merged: Diederik; [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37859 [19:53:24] New patchset: Stefan.petrea; "Fixed configure.in" [analytics/libanon] (master) - https://gerrit.wikimedia.org/r/31858 [20:03:24] Change abandoned: Stefan.petrea; "the changes in this changeset have made their way to master through a different changeset" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/32493 [20:06:22] New patchset: Stefan.petrea; "Fixed configure.in" [analytics/libanon] (master) - https://gerrit.wikimedia.org/r/31858 [20:06:49] New patchset: Hashar; "git --mirror=fetch is git v1.8+" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37873 [20:08:41] New patchset: Hashar; "the bare clone of mw/core need to be a mirror" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37846 [20:09:14] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/37873 [20:10:22] New patchset: Hashar; "the bare clone of mw/core needs to be a mirror" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37846 [20:10:35] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37846 [20:51:00] hi kaldari - sorry to nag you but I just wanted a quick OK before sending out that ambassadors email re Flickr [20:51:21] go for it :) [20:51:26] thanks! [20:51:27] ok [20:52:56] Administrators on Commons can now use UploadWizard to grab freely licensed photos directly from Flickr. Go to Special:UploadWizard, and you should see, next to the "Select a media file to donate" button, a button that lets you "Add images from Flickr". [20:52:56] Commons administrators, please test this and let us know how it works! I believe we want to be able to open it up so all users will be able to upload multiple images at once from Flickr to Wikimedia Commons. [20:52:56] (in Bugzilla: https://bugzilla.wikimedia.org/show_bug.cgi?id=28731) [20:53:09] sent [20:53:12] commons just made a request to enable it for image-reviewers [20:54:30] can anyone point me to an explanation of what the log_action="create2" in the logging table is for? [20:55:32] Manual:Logging_table doesn't have enough details [20:55:59] Create2? Isn't that for a logged in user creating someone else's account? [20:56:51] Krenair: that's what I thought but I couldn't find it anywhere in the docs and have fully dug into the code [20:57:08] s/have/haven\'t [20:57:11] logentry-newusers-create2 - User account $3 was created by $1 [20:57:21] Whereas logentry-newusers-create - User account $1 was created [20:57:32] ok good catch, thx! [21:05:00] New review: Diederik; "Ok." [analytics/libanon] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/31858 [21:05:00] Change merged: Diederik; [analytics/libanon] (master) - https://gerrit.wikimedia.org/r/31858 [21:09:43] DarTar, it's for what Krenair said [21:12:32] Platonides: can you guys also confirm that auto create is for SUL-attached users? [21:12:48] Krenair ^ [21:13:40] Change abandoned: Diederik; "Abandon." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/31828 [21:25:07] hashar: Hey, any news in the wikibugs move to git? [21:31:30] marktraceur: none [21:31:35] marktraceur: sorry :/ [21:31:51] marktraceur: let me send myself a reminder to poke Faidon about git::clone :-] [21:31:58] hashar: Is there anything I can do to help push it forward? [21:32:27] write a new bot in node.js ? :-D [21:32:46] * marktraceur seriously considers it [21:33:12] I think Mozilla uses supybot ( a python bot ) with a plugin to get modifications from bugzilla [21:33:32] Change abandoned: Diederik; "Abandon." [analytics/libanon] (master) - https://gerrit.wikimedia.org/r/31854 [21:33:44] marktraceur: the blocker is https://gerrit.wikimedia.org/r/#/c/27175/ which adds ensure => to git::clone [21:33:49] Change abandoned: Diederik; "Abandon" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/33407 [21:34:20] marktraceur: I will poke Faidon about it to find out what we could do on git::clone. Probably going to use tags or simply 'master' [21:34:53] marktraceur: the repo hosting the wikibugs perl script belong to ops, so that should be safe. [22:59:03] New patchset: Hashar; "(bug 42628) lint whitespaces using git diff --check" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/37803 [23:00:00] New review: Hashar; "Patchset 2 does a diff of HEAD^..HEAD so we do not diff temporary files or other garbages in the wor..." [integration/jenkins-job-builder-config] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/37803 [23:01:02] Change abandoned: Diederik; "Abandon" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/25036 [23:03:43] beed time [23:12:21] New review: Erik Zachte; "The bash file SquidReportArchive.sh needs a bit of tweaking I believe" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37607 [23:38:31] New review: Erik Zachte; "Either I am totally confused or this patch doesn't change anything, " [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/37663 [23:40:55] Change abandoned: Diederik; "Abandon." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26701 [23:56:50] Change abandoned: Diederik; "Abandon" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/28506 [23:57:36] Change abandoned: Stefan.petrea; "change made its way to master through other changesets" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/33120