[00:06:34] Two alolitae! We're so lucky! [00:10:14] hey marktraceur my system is replication on irc :-) [00:14:59] How do I view all of my changes in Gerrit? i.e. more than just the recent ones? [00:15:47] kaldari: "owner:(your username)" [00:16:02] ah [00:23:57] I have set up a new mediawiki instance and pulled the latest code of uwz, but it's not working. It shows a HTTP error 500. [00:43:19] TimStarling: who is the best person to review https://gerrit.wikimedia.org/r/#/c/28433/ [00:45:19] Trevor could have given it +2 [00:45:56] TimStarling: can you glance at it? [00:47:29] I am glancing [00:48:51] TimStarling: thanks! [00:49:16] is brion not around? [00:50:49] I do not see brion [00:51:27] so the point of it is to reduce the size of the startup module? [00:52:29] TimStarling: yes [00:53:32] TimStarling: That only modules matching the filter get registered [00:55:40] ok [00:56:49] TimStarling: did you invert the conditional in the loop? [00:58:37] TimStarling: thanks Tim [00:58:50] TimStarling: I really appreciate you taking the time to look at that issue [00:58:59] TimStarling: I had another question about xhprof [00:59:12] TimStarling: binasher mentioned that you found some XSS issues? [01:00:17] yes, it has plenty of those [01:01:42] TimStarling: did you create a list? [01:03:15] it would be a long list, there isn't a single instance of htmlspecialchars() in the extension [01:04:12] or filter_*() or anything else which might protect it from XSS [01:06:37] I confirmed it with the "run" parameter [01:10:48] TimStarling: bah [01:11:38] TimStarling: have you looked at this version https://github.com/preinheimer/xhprof ? [01:29:52] no [12:59:24] New review: Hashar; "This is already in production." [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28397 [12:59:24] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/28397 [13:08:26] New patchset: Stefan.petrea; "Squashed commit of the following:" [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/28506 [15:31:53] New patchset: Stefan.petrea; "Added module to parse iPad user agents and tests." [analytics/wikistats] (master) - https://gerrit.wikimedia.org/r/28506 [17:07:29] ori-l-away: I created https://github.com/wikimedia/wmf-vagrant [17:15:37] mlitn: https://trello.com/c/ludSmNWQ [17:16:05] aside from the activation logic, we'll need to review with spagewmf potential conflicts with the ACUX tests [17:17:02] DarTar: thanks; just pushed the change to gerrit [17:17:17] if you'd want to, it could probably get deployed today already [17:17:33] oh wait, we actually don't want to deploy it until next Tue at the earliest [17:17:45] i just changed all of CTA6 impressions to CTA4; logged-in users will still see CTA1 - right? [17:17:50] ok, i'll make sure it's not merger in by then [17:18:13] I need to touch base with aaron first (talking to him tomorrow) [17:18:14] thanks [17:19:54] mlitn: that's actually not correct, [17:20:03] currently we're serving CTA1 to anons [17:20:14] CTA6 to logged-in [17:20:22] yes of course, I'm confusing them again [17:20:26] ok [17:20:31] sorry :) [17:21:06] so we're just going to replace CTA1 with CTA4 at 100% for anons and let CTA6 unchanged for logged-in [17:22:04] roger that! [17:22:18] do we have (or need) a bugzilla ticket for this? [17:22:26] or is the trello card enough? [17:38:48] E_WARNING: OMAR'S COMIN', YO! [17:43:26] DarTar: no need to create another bugzilla ticket, pushed to gerrit already [17:43:55] ori-l-away: can you please not merge your own pull requests https://github.com/wikimedia/wmf-vagrant/pull/1 [17:47:48] mlitn: fabrice just created one [17:48:10] just noticed :p [18:56:55] mlitn: regarding AFT moderation source [18:57:23] these are changes only apply to the logging table, no schema change for aft_*, correct? [18:57:38] indeed [18:57:38] k cool [18:57:41] only a change in params-column in logging [18:57:59] I'll need to update the queries for the dashboards once this goes live [18:58:15] is it going live on testwiki/enwiki today? [18:58:36] yes [18:58:40] sweet [18:58:43] preilly: yes, sorry; i got confused about the direction of the merge. [18:58:59] ping me when it's on and I'll look up the data [19:26:32] tfinc, http://www.meetup.com/Wikipedia-Engineering-Meetup/events/79987122/ is garbled " Admin tools - Chris Steip" should be on its own line [19:27:03] spagewmf: it shows on its own line for me [19:36:56] tfinc, odd, for me - Admin tools and - Chris Steip are in separate p tags in both Chromium and Firefox [19:57:18] btw there's https://www.mediawiki.org/wiki/Meetings/2012-10-18 on #wikimedia-dev-meetings [19:57:32] (wasn't this a channel for meetings? :) ) [20:43:33] mlitn: anything live yet re: AFT moderation? [20:44:15] afaik, still pushing to production [20:47:49] k [21:15:54] Unknown or bad timezone (America/Pau dos Ferros) [21:18:31] spagewmf: hi [21:19:15] sumanah hi, busy deploying [21:20:17] spagewmf: I tried to chase down people to approve the "give +2 to spage etc" item for PostEdit, decided to unilaterally approve it [21:20:22] so you have it now [21:35:49] sumanah, thanks [21:36:11] yw :) [21:42:59] kaldari, approved and merged, so when you're ready [21:43:14] one sec... [21:56:04] marktraceur: thank you for setting up EtherpadLite. We've started switching to that instance for a bunch of our meetings and it's so much better than the old Etherpad [21:56:56] sumanah: My pleasure! I saw Reedy using it yesterday, that made me happy. The new versions are getting a lot better, I've been watching some very cool things coming out of that community :) [21:59:10] where-is-it [22:00:47] Nemo_bis: example: http://etherpad.wmflabs.org/pad/p/WM-hackathon-retro [22:01:30] sumanah: ah, thanks, root astutely redirects to the wiki instead [22:02:18] Nemo_bis: either at /pad or /p it says "oh, wanna start a pad?" [22:02:49] sure [22:02:56] my firefox doesn't like it [22:03:59] blergh [22:04:29] Nemo_bis: In what way? [22:05:13] marktraceur: keeps saying "loading...", but surely my fault, noscript or whatever (although it doesn't seem so)... works on chromium [22:05:28] Hm. Intriguing. [22:05:43] Nemo_bis: If you have the chance to open it in developer tools it would be helpful :) [22:08:39] marktraceur: it complains about so many things that I don't know where to start :) [22:09:36] Ha, fair enough [22:09:57] Nemo_bis: If you want to log it somewhere and send it out, I might be able to decipher it a bit [22:10:24] marktraceur: 1) it's in Italian, 2) I never got how to copy and paste it all [22:11:10] Nemo_bis: Fair enough :) if it was just #1, I'd look on it as an awesome new adventure in reading foreign languages, but #2 seems to be prohibitive. [22:12:54] marktraceur: ah [00:12:32.033] GET http://etherpad.wmflabs.org/pad/socket.io/1/?t=1350598351663 [HTTP/1.1 500 Internal Server Error 154ms] [22:13:11] Hm. [22:13:17] Maybe the server has more info. [22:16:09] marktraceur++ for etherpadlite, old etherpad was dying fast in all of my browsers [22:16:34] Nemo_bis: I can't find that request in the log, sorry [22:17:14] ok [22:42:41] TimStarling: any idea whats causing "Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.21wmf2/includes/User.php on line 4192" ? [22:43:28] I'll look [22:45:28] Based on the code, it's presumably still null... [22:47:16] But it seems to be happening fairly frequently in 1.21wmf2, no sign of it in 1.21wmf1 [22:47:24] https://gerrit.wikimedia.org/r/#/c/7376/ touches the same area.. [22:57:21] mysterious [23:03:31] it's possible that something is re-entering the load function of a half-initialised user object [23:03:50] I'm hoping that the exception hack I just added will give us a backtrace and identify the culprit [23:05:49] hmm, I suppose I should actually log a backtrace... [23:05:54] extension hook? [23:06:01] ;) [23:08:11] ah, we did log a few, so at least we have a URL now [23:08:22] 2012-10-18 23:01:15 mw18 enwikibooks: [160350ad] /wiki/Special:AutoLogin?token=7cbe546e2d7ed4bd6ffcfef39de0a830 Exception from line 4194 of /usr/local/apache/common-local/php-1.21wmf2/includes/User.php: User::saveOptions: invalid user options, cannot save [23:09:19] it wouldn't be the first time CentralAuth has caused re-entrant load calls in the user object [23:11:06] ok, I have a backtrace: http://paste.tstarling.com/p/XCrbQS.html [23:18:11] so it was probably https://gerrit.wikimedia.org/r/#/c/7037/ [23:19:58] is that after the branch point? is there any way to tell now? [23:21:35] you mean in 1.21wmf2? [23:23:45] look at the date ti was merged [23:23:58] too late for wmf1, but before wmf2 [23:38:44] chrismcmahon: Dereckson has been writing UNIT TESTS! for InitializeSettings.php . \o/ Thought you'd want to know :) [23:39:43] sumanah: nice! I was just discussing the state of CI with andre__ [23:40:23] Dereckson: the current push is to write unit tests for the bits of MediaWiki that are being deployed right now and don't have good enough automated testing [23:40:38] chrismcmahon: Dereckson sometimes finds his changesets delayed in review in https://gerrit.wikimedia.org/r/#/q/status:open+project:operations/mediawiki-config,n,z [23:41:22] Dereckson: the big pushes that the WMF QA team is doing: ContentHandler tests, tests of downloading PDFs & books [23:41:25] and mobile [23:47:29] Ok. [23:53:46] TimStarling: another strange one. After numerous variables were added for wikivoyage usage, all given defaults, any idea why on wikinews and wiktionary projects (on fenari at least), these would give undefined variable notices? Feels somewhat deja vu also [23:54:26] example? [23:55:40] mwscript eval.php zuwiktionary [23:56:50] It's being cached... [23:57:52] Reedy: CommonSettings.php, L177-184 [23:57:52] think that's the culprit [23:58:28] try sync-common [23:58:55] yes of course it's cached, you think we parse 11000 lines of configuration code on every request? ;) [23:59:07] and yes, I checked the cace file just now and it doesn't have those variables [23:59:16] Usually when you change something on fenari, it's changed on fenari :p [23:59:22] I ran sync-common before... [23:59:31] ffs [23:59:34] Fixed it that time [23:59:36] Thanks