[01:43:32] I'm in over my head, and need somebody to tell me if I've done the right thing. I have an extension in SVN. I would like to migrate it to git, because apparently that's "the right thing to do". I have a login for wikimedia labs and for git, and I have added my extension to http://www.mediawiki.org/wiki/Git/Conversion/Extensions_still_in_svn#Migrate_to_Git. Am I done, until my extension magically appears in git? [02:10:43] Kroocsiogsi: probably not. [02:10:55] oh, well, [14:14:29] hi lwelling - welcome! [14:14:56] lwelling: (btw I got to see Laura this past week) [17:00:08] mwalker: as far as I understand it does not handle 'table.field = table2.field' etc in conditions and group by and stuff like that [17:00:24] that's why we usually have unique field prefixed for every table [17:01:01] that's true; but it also looks like it is not prefixing the table name in the from clause either [17:01:39] mwalker: well my first patch fixes that, it's because $wgFooDb is not false [17:02:10] Nikerabbit: oh; you've pushed patches; I've apparently missed that [19:40:42] Tim-away: ping [20:17:40] hashar, around? [20:17:56] Eloquence: in 1/1 with rob right now. Will be available in 13 minutes. [20:18:35] np - for later: beta.wmflabs.org needs a kick (contenthandler patch needs to be applied now that it's been merged) [20:30:48] Eloquence: back :) [20:32:44] ah got it [20:32:50] going to update the database :-) [20:46:28] Or set the bool to false ;) [20:52:42] Reedy: I think we want to use "beta" to test out a bit contenthandler [20:52:51] heh, yeah :) [20:53:08] I pre-emptively did it on the cluster earlier today :D [20:58:01] we were talking with chrismcmahon about how sql patches are not applied on beta :-D [20:58:15] Reedy: do we have any workflow / process to apply the sql patches ? [20:58:24] (beside asking asher to review them hehe) [20:58:33] we do, sort of [20:59:02] http://wikitech.wikimedia.org/view/Schema_changes [20:59:09] Content handler has been on the list for quite a while [20:59:25] There's also a backlog now that we should really get dealt with.. [21:00:31] we need a SqlCodeReview extension [21:00:34] where people could comment [21:00:41] and we could flag them as applied on beta / prod :-] [21:00:43] or fill in bugs [21:01:39] Reedy: what about non-schema-change updates e.g. https://gerrit.wikimedia.org/r/#/c/23382/ [21:03:05] should probably be a similar process :-D [21:03:22] I should update the 'beta' doc to explain how to apply a sql change [21:10:25] Schema changes on small tables can just be done [21:14:05] chrismcmahon: so I guess you should poke me until I update the doc [21:15:06] Eloquence: content handler patch being applied. The beta commons seems to be working http://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page [21:15:20] Eloquence: thanks for the notification :-] [21:17:10] hashar: my biggest issue right now is identifying updates to the db at all. when a .sql patch is squashed in with other code changes, for example [21:18:03] chrismcmahon: I got a bug for it. Aka to write a job that add reviewers whenever a sql file is added/changed [21:18:17] chrismcmahon: could be made to send a notification on some wiki page or mailing list or whatever [21:19:09] hashar: would you add me to that bug the next time you're in there? [21:19:43] * chrismcmahon goes looking for it...  [21:22:26] chrismcmahon: it is in my list let me find it [21:22:52] chrismcmahon: https://bugzilla.wikimedia.org/show_bug.cgi?id=36228 -- Add specific reviewer in Gerrit on SQL changes [21:46:27] 187 PHP Fatal error: Call to a member function getName() on a non-object in /usr/local/apache/common-local/php-1.21wmf1/includes/upload/UploadBase.php on line 558 [21:49:26] https://bugzilla.wikimedia.org/39195 <- Seems I already logged it [23:19:33] tfinc: Care to elaborate on the nature of talk(s) that should go into this pad? [23:19:55] marktraceur: for the engineering meet up ? [23:20:27] *nod* [23:21:31] marktraceur: last time we had three presentations 1) Analytics/Kraken by David 2) Mobile challenges by Jon 3) Visual Editor by Roan/Trevor [23:22:48] marktraceur: these meet ups are meant to showcase the work that you guys are doing to the broader sf dev community [23:22:55] Ah, K. [23:22:58] That's helpful, thanks. [23:24:15] marktraceur: since its only 5min it should be pretty easy for you to put something toghether [23:24:42] i'm sure the nerds out there would like to here about were the backend pieces of the visual editor are at [23:24:46] *nod* that's pretty clear, my only lack of knowledge was "what is this event?" [23:24:50] And the email didn't say [23:25:29] I suppose other questions like "where" and "when" will be answered later [23:26:04] let me respond and add those bits [23:26:07] Apparently I'm talking! Thanks gwicke! [23:26:18] ;) [23:29:49] +1 on five minutes [23:30:04] Oh, hm. Thursday evening. I guess I should just about give up trying to play bridge on Thursdays, it's clearly not OK :P [23:31:54] tfinc: Your tags could probably also include Free Software, and you could very much add JS to the parenthetical "especially, but not exclusively, in PHP" especially with the Parsoid team rolling out to present. [23:33:23] marktraceur: where are you looking for that ? [23:33:30] (on the meetup page, sorry) [23:33:37] (I've been told I'm bad at context) [23:35:14] the Meetup Group description .. gotcha [23:35:46] I suspect I've been slowly getting lazier at including details in messages [23:35:57] I guess it finally got to the point where people called me on it [23:36:03] marktraceur: good thing your responsive to make up for it [23:36:12] True that [23:38:15] marktraceur: description updated but i can't for the life of my find where tags are updated. i will leave that one to a smarter/patient person than i [23:38:26] He, K [23:38:28] heh* [23:41:09] New patchset: Stefan.petrea; "Added root check to debianize.sh" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/27381 [23:42:30] New review: Diederik; "Ok." [analytics/udp-filters] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27381 [23:42:30] Change merged: Diederik; [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/27381