[00:01:35] hi TimStarling, thanks for those Swift fixes to Score [00:13:33] hey, does anyone know how to trigger a jQuery modal with JavaScript in a wiki> [10:14:55] Reedy: so I rewrote your ApiQueryGenerator tests : https://gerrit.wikimedia.org/r/#/c/22936/ [10:14:59] using data providers [10:15:07] that make the output a bit nicer for the user [10:15:24] I am not testing $wgAPIGeneratorModules though [10:15:41] Defeats the point then :p [10:16:00] though, the apiquery module will give you it with getmodules [10:16:52] indeed [10:17:47] you can try adding/removing entries in ApiQuery.php , run test and see the nice error messages [10:18:04] I have added something like: 'something' => 'Title', [10:18:08] to the mQueryGenerators [10:19:03] The tests really weren't exactly needed [10:19:17] It's like, only 2 or 3 extensions add generators.. [10:49:07] New patchset: Stefan.petrea; "Transferred existing code from filter to udp-filters." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26027 [11:12:32] sorry I'm late to my own meeting :( [11:13:10] But maybe no one else is here for it... [11:13:14] so I'm ok [11:18:37] out for lunch [11:18:43] ah [11:18:48] sorry for missing the meeting hexmode : / [11:18:58] forgot about it / wasn't aware :-) [11:19:12] I am getting a take away so might be back before it ends [11:19:15] cya [11:21:48] heh [11:22:17] so I can bug hashar about a couple of good patches... [11:22:41] Krinkle|detached: if you get back, I'll bug you :) [13:23:56] New review: Diederik; "Some minor comments." [analytics/udp-filters] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/26027 [13:46:30] Can anyone think of a good reason why I'm getting a "Permission denied (publickey)." when trying to ssh into gerrit to run a query? I've triple-checked and the key that's in my gerrit settings is the one that's in my .ssh folder. [14:14:16] hello ^demon [14:15:09] <^demon> Howdy [14:15:32] ^demon: when you have a minute, I could use some help with this: Can anyone think of a good reason why I'm getting a "Permission denied (publickey)." when trying to ssh into gerrit to run a query? I've triple-checked and the key that's in my gerrit settings is the one that's in my .ssh folder. [14:16:07] I'm probably missing something but I can't figure out what. [14:16:32] <^demon> That's the only reason you'd get a public key error--if the key's not in gerrit or not on your ssh-agent. [14:17:14] I don't use an ssh-agent, I use gerrit only occasionally so I was expecting to type my passphrase [14:18:41] I thought maybe it was due to the .config file, but when I remove gerrit from it I have the same problem [14:20:34] <^demon> Offhand, I'm not sure what the problem could be. Maybe ask Ryan, when he shows up? [14:20:42] ok, thanks [14:22:43] <^demon> hashar: https://gerrit.wikimedia.org/r/gitweb?p=operations%2Fgerrit.git;a=shortlog;h=refs%2Fheads%2Fwmf-2.5 :) [14:22:47] <^demon> I'm testing the build now. [14:30:55] wonderfull [14:32:03] chrismcmahon: sumana's wondering if you're joining the hangout [14:32:39] ^demon: I opened https://bugzilla.wikimedia.org/show_bug.cgi?id=40682 to track it [14:32:48] guillom: strangely, I'm not seeing an open hangout [14:33:14] chrismcmahon: ok, sumana's working on it [14:33:37] <^demon> I saw. You opened lots of bugs :) [14:34:23] ^demon: now I need to fix / implement them! [14:41:57] ^demon: I found the problem: I wasn't using the right username (my gerrit username is gpaumier, and I was using Guillom, which is my labs username). [14:42:07] <^demon> Ah, that'll do it too. [14:58:12] ^demon: I am migrating wikibugs from svn /trunk/tools/wikibugs to git (got a local repository crafted). Any idea for a name in Gerrit ? I was thinking about operations/tools/wikibugs [14:58:32] errr operations/software/wikibugs.git [14:58:39] <^demon> operations/bugzilla/* [14:58:48] <^demon> Or wikimedia/bugzilla [14:58:52] <^demon> Actually, the latter. [14:58:54] <^demon> Put it in wikimedia/* [14:59:16] ^demon: there is a wikimedia/bots can it get there ? [14:59:42] <^demon> We need repos for stuff like our customization with BZ, so that makes the most sense to me. [14:59:57] <^demon> I have no clue what wikimedia/bots is. [15:00:03] so wikimedia/bugzilla/wikibugs [15:00:08] bots are random anti spam stuff [15:02:15] <^demon> Yeah, do wikimedia/bugzilla/wikibugs. [15:02:35] <^demon> It can just inherit from wikimedia/* to start, those permissions would suffice. [15:03:07] <^demon> We can add more later if we want. [15:08:27] ^demon: can you give me the super rights on https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/bugzilla/wikibugs,access please ? I need to git push -f my local repo [15:09:21] <^demon> I gave platform-engineering owner rights, you can adjust anything now. [15:20:17] New patchset: Stefan.petrea; "Transferred existing code from filter to udp-filters." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26027 [15:29:45] New patchset: Stefan.petrea; "Transferred existing code from filter to udp-filters." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26027 [15:42:49] New review: Diederik; "Ok." [analytics/udp-filters] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26027 [15:42:49] Change merged: Diederik; [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26027 [16:05:41] zeljkof: Oh, quit lurking, you :) hey, how are the browser tests? [16:20:31] marktraceur: we started a discussion page with preliminary ideas: http://www.mediawiki.org/wiki/Browser_test_automation_discussion [16:22:44] Anyone know Daniel Werner's nick? [16:25:40] nullspoon: I think it's DanWe or something similar [16:27:29] marktraceur: In other words he's not here. :) [16:27:39] nullspoon: Believe so [16:28:06] marktraceur: Okay. I'll just wait for him to get a chance to take a look at the change. [16:28:19] wow that came out wrong. [16:28:24] Danwe_WMDE [16:28:25] sounded needy [16:28:29] haha [16:28:30] He left 40 minutes or so ago [16:28:33] thanks Reedy [16:29:16] Reedy: Okay. I can wait. Thanks! [16:52:58] chrismcmahon: There's some policy about not running tests on labs, FYI [16:54:14] chrismcmahon: Also, with the configuration file patch that I added, you shouldn't need to store a sensitive password, just *a* password for the test MediaWiki instance (which won't even need to be externally accessible) [16:54:46] marktraceur: aha, thanks [17:00:21] marktraceur: I was thinking to run browser tests targeted at beta labs (at least) which would require hiding the password I think [17:09:37] Oh, I see [17:09:45] chrismcmahon: Yeah, I can see how that might be problematic [17:12:04] marktraceur: and/or severely restricting what particular test accounts can accomplish. I was reading about user permissions, I think that's feasible also. [17:47:28] New patchset: Milimetric; "Erik's updates for October's meeting" [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26339 [17:48:47] New review: Diederik; "Ok." [analytics/reportcard/data] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26339 [17:48:47] Change merged: Diederik; [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26339 [18:45:57] TrevorParscal: There's a pending change for the diff styles. I'm checking it out now. You may want to take a look as well. It appears they want it in 1.20 as well, not sure why it is that urgent ( @ hexmode ) [18:46:13] https://gerrit.wikimedia.org/r/#/c/25743/ [18:46:17] thanks for the heads up [18:49:04] TrevorParscal: Krinkle: it was marked as a 1.20 blocker (not by me) and I saw you had a fix. If you don't think it is appropriate, then, by all means, take 1.20 off the bug and don't worry about the merge :) [18:49:17] but you guys are already looking ... so... [18:49:32] it doesn't seem offensive to me, but also certainly not urgent [19:26:33] zeljkof: Do you has a user page on mediawiki.org? [19:27:07] zeljkof: Never mind, found User:Zeljko.filipin(WMF) [19:28:36] New patchset: Milimetric; "fixing data and scripts for October's meeting" [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26351 [19:29:35] New review: Diederik; "Ok." [analytics/reportcard/data] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26351 [19:29:35] Change merged: Diederik; [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26351 [19:33:16] restarting gerrit [19:33:37] * siebrand grumbles at Ryan_Lane  [19:33:46] before you grumble [19:33:52] we're enabling replication to github [19:33:55] you're welcome ;) [19:34:00] crap [19:34:02] it failed to start [19:34:28] Ryan_Lane: just had two clones aborted, so I grumble. [19:34:41] * Krenair grumbles at Ryan_Lane? :P [19:34:51] omg cloning, abortion... [19:35:19] Nemo_bis: We talk about all the issues here [19:35:26] :D [19:35:28] marktraceur: glad to hear so! [19:35:32] the channel was too quiet [19:35:37] syntax is slightly off on the replication bits [19:35:44] it'll be a couple mins [19:36:10] Hm, I guess this might be contributing to the problem I'm having in our test runner [19:42:53] it's back [19:43:37] marktraceur: yes, that is my page [19:44:19] zeljkof: Great :) [19:44:32] zeljkof: I cleaned up bits of the automated testing discussion page [19:51:44] New patchset: Milimetric; "just minor change to test gerrit + gitflow" [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26354 [19:51:44] New patchset: Milimetric; "Merge branch 'release/August2012'" [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26355 [19:52:29] New review: Diederik; "Ok." [analytics/reportcard/data] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26354 [19:52:30] Change merged: Diederik; [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26354 [19:53:05] Change merged: Diederik; [analytics/reportcard/data] (master) - https://gerrit.wikimedia.org/r/26355 [19:57:06] marktraceur: I planned to do some cleanup today, but I got distracted will all the accounts that I needed to set up [19:57:29] zeljkof: I know the feeling, I was there about two weeks ago. :) [20:18:13] :) [20:24:25] marktraceur zeljkof my life was kind of quiet there for a while, things are really picking up now! [20:36:22] marktraceur: there is something wrong with the link to my user account here http://www.mediawiki.org/wiki/Browser_test_automation_discussion [20:36:32] it leads to "page does not exist" [20:37:24] it's waiting for you to create the page [20:37:34] zeljkof: You have to write something about yourself :) [20:37:37] the account is fine [20:37:41] (not to distract you more :P ) [20:40:54] no one's welcomes him yet [20:41:39] We have bots for that! [20:41:42] (don't we?) [20:41:44] *welcomed [20:41:49] I dunno [20:42:01] in 2010 we didn't, maybe these days we do but [20:42:13] I wonder if I need to subst on this tempalte [20:43:01] * apergos doesso [20:43:46] apergos: yes you do or meno will do it for you anyway :p [20:44:19] too late with that answer :-P [20:44:25] heh [20:44:37] zeljkof: I think you're supposed to use https://www.mediawiki.org/wiki/Template:User_info [20:44:46] you don't have to though [20:45:04] I think that's for wikimediafoundation [20:45:14] here you can be a lot less formal [20:45:35] it's for all wmf staffers [20:45:53] not that I like it much :p [20:46:41] wow, more stuff to set up :) [20:46:49] will do it these days [20:47:26] Normal users don't need to have user pages, it's optional. Don't know about WMF employees [20:47:28] just write a line or two with maybe your area of interest and your irc nick (if you like) [20:47:32] that's plenty [20:47:50] it's still optional [20:48:09] but it's nice to have as people start working with you more [20:51:08] afk for the night, see folks tomorrow [21:28:47] New patchset: Stefan.petrea; "Separated logic" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26404 [21:33:35] New review: Diederik; "Please add GPL license text to all *.h and *.c files" [analytics/udp-filters] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/26404 [21:33:40] New patchset: Stefan.petrea; "Separated logic" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/26404 [22:04:34] Can anyone confirm that in "refs/changes/xx/yyyyy/zz", xx will always be the last two digits of yyyyy? [22:04:39] (in Gerrit refspecs) [22:13:48] Never mind, wouldn't matter anyway [23:18:15] New review: Diederik; "Ok." [analytics/udp-filters] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25408