[08:32:21] hi [08:32:47] I'd like the request the backport of a recent commit to the French wiki installation [09:37:16] Od1n: salut :) [09:37:19] Od1n: quel commit ? [09:37:49] salut [09:38:05] https://gerrit.wikimedia.org/r/#/c/23237/ [09:39:39] ce bug est vraiment gênant, je pense que ça justifie de le corriger sans attendre le prochain déploiement [09:41:30] ah appliqué aujourd'hui [09:41:35] au master [09:42:43] tu pourrais le puller sur wmf11/12 ? [09:43:27] j'ai réouvert le bug https://bugzilla.wikimedia.org/show_bug.cgi?id=40098 [09:44:15] oui je viens de voir [09:48:52] Od1n: j'ai fait la paperasse, il faut que ce soit revu avant d'être déployé [09:49:30] je trouverais quelqu'un cette après-midi [09:51:21] super, merci beaucoup [09:51:26] Od1n: sinon recontacte moi dans l'apres midi :) [13:35:42] New patchset: Stefan.petrea; "added a test comment(and 2 other trailing changes for documentation)" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24286 [13:42:14] New review: Diederik; "Please try submitting again, do not forget to use the --amend" [analytics/webstatscollector] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/24286 [13:44:32] New patchset: Stefan.petrea; "added a test comment(and 2 other trailing changes for documentation) Fix #1" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24286 [13:46:59] New review: Diederik; "All good." [analytics/webstatscollector] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24286 [13:46:59] Change merged: Diederik; [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24286 [15:06:31] Heiya, I would like to report a problem which occurred twice on mw.o during the last days, e.g. http://www.mediawiki.org/wiki/Extension:YetAnotherKeywords displayed "whiteTemplate:Belgekirin" instead of the contents. So I just resaved the page without doing a change, et voilà all is back to normal. Is it still possibel to investigate this behaviour? [15:07:16] I am a bit worried about having something on display which differs from what should be there. [15:08:43] kghbln: that is weird. hmm. so this only started happening in the last few days? [15:08:50] Reedy: ^ could this be because of the most recent deployment? [15:10:11] sumanah I acutally did not discover it. Cavila did. That is the post on my talk page http://www.mediawiki.org/wiki/Thread:User_talk:Kghbln/Extension:YetAnotherKeywords [15:11:02] I should have reported earlier, i.e. yesterday :( [15:11:57] It is a bit frightening [15:15:08] Hmm, that does sound odd [15:15:22] kghbln: remind me, did you already file a bug? [15:17:26] sumanah no so far I did not. Good idea though. Will do asap. [15:23:24] kghbln: when I do a google search for the string "whitetemplate:belgekirin" google returns a single result which is http://www.mediawiki.org/wiki/Thread:User_talk:Kghbln/Extension:YetAnotherKeywords with a date of Dec 1 2011, the last date before your recent modification. I'm not sure why just yet, but that's interesting. [15:24:13] ah, actually this page: http://www.mediawiki.org/wiki/Extension:YetAnotherKeywords [15:32:07] chrismcmahon O_o I can remember that I reviewed the page back then. I did this just by having a look at the diff. So I did not have a look at page itself. / I reported this with https://bugzilla.wikimedia.org/show_bug.cgi?id=40361 [15:33:13] Hmm, this is really weird. [16:19:41] rats still no aaron [16:20:11] * apergos lurks and looks at the clock [16:21:54] kghbln: any answer? [16:39:18] Anyone have a good heuristic for when it's ok to make a function that's not declared static, but does everything in a static way, to be static? (WebRequest::getRequestURL() to be exact) I searched the git extensions, and nothing seems to extend it... just FauxRequest in core. [16:50:14] csteipp: isn't WebRequest used as an instantiated object ? [16:50:22] aka $wgRequest->getRequestURL() [16:50:42] hasher: usually, but I'm trying to use it before it gets instantiated [16:50:47] from the webinstaller : 423: $url = $this->request->getRequestURL(); [16:50:48] ahhh [16:52:52] I think it is initialized in Setup.php, you must be doing something before that [16:53:09] or you could create an instance [16:53:15] <^demon> As long as it doesn't depend on the object's state in any manner, I think it's fine to mark something static if you need it elsewhere. [16:53:19] <^demon> Nooooo [16:53:24] ;) [16:53:24] <^demon> Don't create new instances of WebRequest. [16:53:32] <^demon> That causes things to explode. [16:53:42] <^demon> (Never did get around to fixing that) [16:54:02] ^demon: I was just trying to use the one function... not create a new instance [16:54:10] Although that would be a fun trick to try.. [16:55:10] <^demon> csteipp: Yeah, then go ahead and mark it static as long as there's no weird dependencies on object state. [16:55:19] <^demon> I was just telling hashar to not suggest that ;-) [16:55:53] <^demon> https://bugzilla.wikimedia.org/show_bug.cgi?id=11558#c0 old bug :p [16:56:30] so many bugs [16:56:38] I am just afraid of us breaking some back compatibility [16:56:40] hey AaronSchulz [16:57:07] I didn't forget your change, and I need you to explain something to me before I can give it the (not very rubber) stamp [16:57:15] <^demon> hashar: Well step 1 is to make sure nobody's using $_SUPERGLOBALS directly and only accessing them through webrequest. [16:57:36] <^demon> As long as some code use $_(SERVER|GET|POST|etc) directly, we can't fix it. [16:58:07] AaronSchulz: basically I need to know why the code as it is now would work ok for thumbs in /archive but needed the change for stuff in /temp [16:58:25] I agree that the code does what the commit message says, but what I don't know is that difference in behavior [16:59:44] anyway, dinner time! [16:59:45] see you later :) [17:00:05] apergos: /archive is fine since it is part of the path relative to the zone of the repo [17:00:48] whereas the base of the temp repo thumb zone is /thumb/temp, so we don't want to include /temp in the "zone relative path" [17:03:15] the point of this is partly to check if the paths people request are valid (e.g of the form "zonepath/zonerel"), where "zonerel" is a valid path to a thumb relative to the thumb zone [17:04:14] so a request for "thumb/archive/a/ab/x.jpg/15px-x.jpg" is not valid if x.jpg is actually in shard a/ae or something [17:05:28] hate my connection. hate [17:06:40] so the piece I'm missing is where the temp repo thumb zone url is defined [17:06:46] everything else is good to go [17:07:17] so did you get any of that then? I guess not [17:07:20] I got [17:07:26] the point of this is... [17:07:29] 10:00-10:04? [17:07:30] as the last thing you typed [17:07:40] the whole statment starting with that I mean [17:08:15] anyway, you can look at FileRepo.php for the method "getTempRepo" [17:08:27] ok lemme check that, that's probably the bit I couldn't find [17:08:31] it defines the zones for the "temp repo" for the local one [17:08:40] thats it [17:09:51] yep ok tht clears it up, I was pulling my hair out trying to figure out why archive paths would be ok and temp wouldn't, but I didn't get that temp is actually included in that url [17:10:48] you need me to +2 this right? [17:11:27] AaronSchulz: [17:12:04] yeah [17:12:17] it would be nice to deploy before commons deployment [17:12:26] since it would only affect like 3 tiny wikis [17:12:30] done [17:12:50] it's been quite a while since I looked at some of the related code [17:13:06] it was a nice refresher (plus a lot's changed since then) [17:13:37] wikis using uploadstash or whatever it is? [17:14:22] apergos1: all wmf12 wikis [17:14:50] ah [17:15:43] but yeah, all wikis use the stash, commons more so than others since it has UW [17:15:56] yeah [17:16:08] I went looking for thumb/temp on ms5 to see what was up [17:16:17] and found commons had it and some other obvious choices didn't [18:14:09] jdlrobson: sorry for spamming you on bugzilla :) [18:14:17] kaldari: that's cool [18:16:29] sumanah I was off for tea. No, so far I did not get a response. [18:33:15] New patchset: Stefan.petrea; "Adapted generate-test-data.pl to cope with format expected by collector. Switched to udp port instead of tcp for transmitting test data. Modified PERIOD to 60 for debugging purposes" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24319 [18:41:39] New review: Diederik; "Maybe it's an idea to add a debug switch to collector and if the debug switch is enabled then #defin..." [analytics/webstatscollector] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/24319 [18:47:35] New patchset: Stefan.petrea; "Adapted generate-test-data.pl to cope with format expected by collector. Switched to udp port instead of tcp for transmitting test data. Modified PERIOD to 60 for debugging purposes. Added compiler directives to set PERIOD accordingly for debuggin" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24319 [18:49:31] New review: Diederik; "Ok." [analytics/webstatscollector] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24319 [18:49:31] Change merged: Diederik; [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24319 [20:46:21] New patchset: Stefan.petrea; "Fixed filter problem related to chroot(Otherwise special privileges would have been needed to run filter)." [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24375 [20:55:24] New patchset: Stefan.petrea; "Fixed filter problem related to chroot(Otherwise special privileges would have been needed to run filter)." [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24377 [21:08:58] New review: Diederik; "Ok." [analytics/webstatscollector] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24377 [21:08:58] Change merged: Diederik; [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24377 [21:15:19] New patchset: Stefan.petrea; "removed old source files, everything is in src/ now" [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24379 [21:16:21] New review: Diederik; "Ok." [analytics/webstatscollector] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24379 [21:16:22] Change merged: Diederik; [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24379 [21:20:02] Change abandoned: Diederik; "Merged in different commit." [analytics/webstatscollector] (master) - https://gerrit.wikimedia.org/r/24375