[00:28:51] anyone having an issue with gerrit? [00:28:56] it won't take my public key anymore [00:30:17] ^demon: [00:31:06] it worked 20 minutes ago [00:32:18] Krinkle, well I can download changes [00:32:29] yes, that doesn't use auth [00:47:22] wow, nice blog loading animation http://koyeung.blogspot.nl/2009/11/bashrc-vs-bashprofile-on-mac-os-x-and.html [00:47:31] gets old fast, but fun at first [17:08:44] Wiki data (powered by Google): http://cl.ly/image/3N0L1r193L1Q [18:50:04] RoanKattouw: Looks like my terminal keeps forgetting the ssh keys. is ssh-add broken or what?> [18:50:14] I don't want to re-add it every time I restart the console or reboot the computer. [18:50:24] in the old position (being the default) this was never an issue [18:50:36] now that I have 2 with custom names it forgets them. [18:50:37] When rebooting you definitely have to re-add [18:50:51] You could move the one you use most back to the common name [18:50:54] RoanKattouw: You run that every time you reboot as well? [18:50:57] Yes [18:50:59] You have to [18:51:05] The agent data is stored in memory [18:51:33] Isn't there a .dotfile for this? (other than running it from .bash_profile with > /dev/null which I'd rather not) [18:51:53] Well you have to enter the passphrase [18:52:04] hm.. right [18:52:16] no, actually mine only does that when it uses it [18:52:21] Hah [18:52:35] It lets you add to the agent without a passphrase, and then prompts once upon first use? [18:52:36] That's neat [18:52:42] ssh-add doesn't ask for pass phrase on ssh-add, it brings up a GUI prompt when I execute ssh [18:52:49] Fancy [18:52:59] * Krinkle googles further [18:53:11] OSX clearly has its own ssh-agent that differs from Ubuntu's then [18:53:16] Hm.. IdentityFile in ~/.ssh/config ? [18:53:19] Is that any good? [18:53:26] IdentityFile ~/.ssh/id_rsa_krinkle [18:53:27] Doesn't do what you want [18:53:35] Probably not at least [18:53:46] There is something you can do to avoid losing your agent every time you close the console [18:54:13] I'm actually surprised that that happens, it doesn't break that way in Ubuntu [18:54:42] I just created a clean bash where ssh to toolserver would fail due to no poblic key, then I reloaded it after I put that ^ in ./config. Seems to work now (asked for pass phrase first time) [18:55:02] Does it ask for the pass phrase every time? [18:55:04] Or just the first time? [18:55:16] first time I execute ssh command that offers it [18:55:23] Well sure [18:55:26] But what about the second time [18:55:30] nope [18:55:51] Actually I think ssh-add does ask for pass phrase right away. I was testing IdentityFile in cofig not ssh-add [18:55:53] config* [18:56:12] Right [18:56:23] My understanding is IdentityFile would ask each time [18:57:19] I'd say try it sometime. I have 2 lines in ~/.ssh/config now it appears it just reads that whenever I execute ssh. And just like the default location (plain id_rsa) it asks once per bash session or something like that (actually I think it is general computer session, e.g. until reboot) [18:57:42] not when the bash starts but when ssh is executed [18:57:55] Right [18:57:57] RoanKattouw: btw, regarding https://gerrit.wikimedia.org/r/#/c/16718/6 [18:58:01] I've tried that but it asks each time for me [18:58:07] what is jquery.badge.js ? Is that some new file? I don't have that in my repo [18:58:14] I don't know, let me see [18:58:46] commit f239fb3905e6b3ade16b1c99c7bc4faca91ccdee [18:58:48] Author: Andrew Garrett [18:58:50] Date: Mon Jul 30 14:16:56 2012 -0700 [18:58:51] Clean up badger.{css,js} from PageTriage, generalise it and move it into core. [18:59:20] hm.. [18:59:45] * Krinkle checks out master (!) [18:59:49] Yeah, got it now. [18:59:56] I was in an old topic branch that didn't need rebasing [19:10:45] gwicke: Ahm, WTF? Could this be a serializer bug? https://www.mediawiki.org/w/index.php?title=VisualEditor%3ATest&diff=570606&oldid=570600 [19:11:46] * RoanKattouw tests some more [19:12:10] more likely a link handler bug [19:12:38] Yeah I'm poking at that now [19:12:55] rts nicely in parsoid.wmflabs.org [19:14:15] *grumble* [19:14:37] Is that what happens when you pass a prefix to Parsoid, you get prefixed link hrefs? [19:14:40] I guess that kind of makes sense [19:15:34] yeah, the prefix becomes part of the overall prefix [19:15:49] So now I'm really gonna need either an article path in the so I can make sense of hrefs, or what I'd really like at this point, a separate attribute for internal link targets [19:16:10] * RoanKattouw fixes production by setting the prefix to '' [19:16:20] since you made the request, you probably know the path prefix already [19:16:35] easier to strip it imo [19:16:55] and better anyway [19:17:50] Right [19:17:54] Well [19:18:08] The thing that makes the prefixed request and the thing that interprets the HTML are different things [19:18:18] The prefix is handled in PHP, abstracted away from JS [19:18:23] they tend to communicate though [19:23:41] an alternative solution would be to use relative links for wikilinks [19:24:17] on pages that contain slashes in their title, there would need to be ../ prefixes for that to work [19:25:10] the bit after the ../ would always be a full page title [19:25:55] so you would not need to know the exact prefix, just strip any ../ to get the link target [19:40:18] Krinkle: You around? [19:40:32] on a Skype call [19:40:41] Could you approve https://gerrit.wikimedia.org/r/#/c/18405/ real quick? [19:40:56] It's a trivial captialization change that I'd like to deploy to the live site [19:45:24] RoanKattouw: [19:45:43] Thanks ma [19:45:44] n [20:39:38] ialex, I'm not sure I understand how parseAsBlock (as you suggested here: https://gerrit.wikimedia.org/r/#/c/16464/3/includes/specials/SpecialUpload.php ) works [20:40:13] Krenair: this is to replace $this->getOutput()->parse() call [20:40:35] As so it'd be $uploadFooter->parseAsBlock() instead? [20:40:54] okay, thanks [20:41:02] correct :) [23:08:50] ^demon|away: So I just did some accidental scalability testing re # of inline comments :D https://gerrit.wikimedia.org/r/#/c/18209 [23:17:54] hoi bsitu [23:18:13] hey, what's up [23:18:55] do you have a moment to walk me through the page curation data model tomorrow? /me wants to start playing with the data [23:19:26] yeah, sure [23:21:04] cool [23:23:17] kaldari: hey [23:26:42] howdy [23:36:23] I had submitted the changes we had talked about in the mail : https://gerrit.wikimedia.org/r/#/c/12269/.