[00:47:36] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/16718/ [00:48:00] its been over a week :/ [00:48:48] Oh sorry about that :S [00:50:13] I'm about to go hoe [00:50:15] *home [00:50:21] But I'll look at it in the morning [00:50:27] ok [00:50:58] Rebase Change in gerrit complains. I'll rebase it later today (before you get in) [00:51:27] RoanKattouw_away: Can you abandon this one? https://gerrit.wikimedia.org/r/#/c/9962/ [00:52:31] Ryan_Lane: Could you get this one merged? https://gerrit.wikimedia.org/r/#/c/17610/ The change by someone else the other day got deployed in less than a day.. [00:52:51] no [00:52:54] it needs 2.5 [00:52:58] how so? [00:53:08] ask chad [00:53:13] gerrit.config doesn't work in 2.4.2? [00:53:22] We're already doing that, it is just set to the "wrong" color. [00:53:40] Also, "Remind me later to track down what the real class is here, so we can mark it @external for future releases." [00:53:45] It doesn't need 2.5 though I don't think [00:53:55] GJEA35ODNB a.gwt-InlineHyperlink ? [00:54:04] well for one, we already use those weird classes for wrapping the commit-msg. [00:54:10] ok... [00:54:24] Yeah, it shouldn't be blocked on the 2.5 upgrade [00:54:25] two, if we have to take that out, fine, I'll take it out. But we can still merge the rest of that change. the highlight color hurts my eyes. [00:54:38] But the class name should be put in 2.5 [00:54:49] screw it, chad +1'd it [00:55:00] orly? I didn't see that. [00:55:16] thx :D [00:57:08] ok. it's in [00:57:17] thx [00:57:20] yw [00:57:42] Krinkle: Abandoned; but could you do the resubmit-as-pull-request thing so the author doesn't have to worry about that himself? [00:58:35] RoanKattouw_away: I'll put it on my todo list for next Tuesday. That's gonna take some hurdling because this change (as mentioned in an earlier gerrit comment) this change request does a gazillion stuff at once, including 3 years of upstream changes. [00:58:58] Aha, ouch [00:59:06] and our fork has already diverged a little bit. [01:34:01] [[File:Krinkle_Global_SUL.js]] [01:34:04] ??? [01:34:37] https://commons.wikimedia.org/wiki/Special:GlobalUsage/Krinkle_Global_SUL.js [01:36:55] hack hack hack (smart though)... we should have better way to track stuff like that... [01:38:29] Danny_B|backup: we will. Preferences already provides this (though only via a toolserver query) [01:38:50] Danny_B|backup: See also: http://krinkle-tools.grizzdesign.nl/KrinkleSausage.php [01:39:17] 50 api requests [01:41:19] script on this page is too busy or stopped to response [01:41:38] Its an old server. just try again [01:43:05] not you, jquery.min.js ;-) [01:43:19] from ajax.googleapis [01:43:58] may i kindly suggest changing of per page to per site? [16:28:21] is this the correct place to ask for a new project on git ? [16:29:42] OrenBo: I believe there's a wiki page for requests, have you tried there? [16:29:56] nope [16:30:02] OrenBo: http://www.mediawiki.org/wiki/Git/New_repositories/Requests [16:30:03] I'll have a look [16:31:20] Also, the Dice extension just blew my mind [16:32:49] what is open push [16:33:47] OrenBo: It means people can just 'git push' changes in directly, bypassing review [16:34:08] Sorry, OrenBo, I should have linked you to http://www.mediawiki.org/wiki/Git/New_repositories [16:46:56] <^demon> marktraceur: You mean the fact that nothing's been done on it yet? [16:54:58] ^demon: Hm? What do you mean? [16:56:37] <^demon> Oh, I was talking about on-wiki. Some guy requested a new repo called Dice, but I couldn't grant him permissions and he never got back to me. [16:56:43] <^demon> Or are you talking about a different Dice? [16:57:46] Aaron|away: Hah, so if you declare constants in an interface, and then implement that interface in a class, the constants are inherited ?! [16:57:53] * RoanKattouw has never seen this before [16:57:57] yes [16:58:38] RoanKattouw: Java people often do it to get around single inheritence and thats done a lot just for a few constants it's sometimes called an "antipattern" [16:58:57] heh [16:59:06] * AaronSchulz reads the redis bagostuff code [16:59:27] ^demon: No, just the extension itself. Cool idea. [16:59:37] <^demon> AaronSchulz: public class MyClassImpl extends SomeUnrelatedClass implements MyClass, YourClass, OurClass, YourMomsClass [16:59:38] I was wanted to write one for a while, now Tim just did it :) [16:59:41] <^demon> I copied that from the gerrit source. [16:59:45] <^demon> ;-) [16:59:56] "your mamma's class"? [17:00:11] <^demon> Your momma's a class. [17:01:35] <^demon> Your momma's so classy she inherited all her properties from the abstract class GoldDigger. [17:01:54] <^demon> ;-) [20:58:00] Hm.. I just finished a simple/random rebase somewhere and suddenly git is doing some kind of auto-pack / garbage collection [20:58:15] That's the first time I see it do that since for ever for any repository [21:46:10] StevenW, is there going to be volunteer access available to the Phabricator trial? [21:47:24] I'm agnostic on the matter. [22:50:58] gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=39181 [22:54:38] yeah, we don't remember if an empty HTML tag had the trailing slash or not [23:44:20] Hmm. [23:45:00] I'm working on creating a maintenance script to convert Oversight entries to suppressed revisions [23:45:23] One last problem I've hit before I submit this file for review is that it assumes we're adding to the revision table. [23:45:57] Should it ever add to the archive table? If so, how to determine which entries need to go into the archive table and which into the revision table?