[12:07:58] <^demon> hashar: Good morning :) Krinkle made some more changes to the CSS, hopefully we can get them deployed today. [12:08:08] good afternoon :) [12:08:21] <^demon> http://gerrit-dev.wmflabs.org/r/ is what it looks like now. [12:08:27] ^demon: I talked with him a few hours ago, apparently he will get a poke at them again whenever he is back in the office [12:08:39] <^demon> I submitted it as https://gerrit.wikimedia.org/r/#/c/17497/ [12:09:13] still have some gray for text :( [12:09:15] #353535 [12:09:28] that is nicer indeed [13:03:07] ^demon: safe to assume that "Become" on http://gerrit-dev.wmflabs.org/r/#/q/status:open,n,z is just a glitch and not part of any change? [13:03:30] <^demon> No, it's a development mode I have the dev install turned to. [13:03:45] <^demon> It allows you to "become" any user to easily test things. [13:04:15] <^demon> So, not a glitch but not a change coming to production either :) [13:04:32] ah, okay :) [13:04:43] and the logo will be clickable? [13:05:18] <^demon> Yep. All the UI fixes (colors, header) will be coming to production. [13:05:29] <^demon> Just waiting for Krinkle to come online and give them one last glance. [13:05:58] ok [13:06:07] nice work1 [13:06:08] ! [13:06:08] ok, you just typed an exclamation mark with no meaning in the channel, good job. If you want to see a list of all keys, check !botbrain [13:06:13] heh [13:07:18] <^demon> :) Thanks. Timo has made a bunch of improvements, and Trevor whipped up that logo really quick for us. The original theme is based on OpenStack's gerrit. [13:07:23] <^demon> Yay for collaboration :) [13:07:58] nice surprise today :) [13:08:16] <^demon> Once the last fixes go out I'll send an e-mail to the list. [13:08:31] ok [16:25:39] j^: jeroen is the only one I know with that power, plus admins and the E3 team (apparently) [16:41:41] j^: Apparently the moral of the story is something like "Don't try to get things merged before 17:00, everyone's still offline" [16:42:52] Also, shockingly, I can see my review requests list now without scrolling down: https://gerrit.wikimedia.org/r/#/ [16:43:06] :o [16:43:15] 50 points to the reviewers! :) [17:26:15] Anyone know if there's already a class to get a paged list of database rows, like TablePager, from another wiki's database? [17:26:46] You could subclass TablePager and override getDB [17:26:59] Assuming that's factored out [17:27:28] I tried that, and it didn't seem to work... but it could be my fault :) [17:27:56] Anybody have any idea if we cache the p-personal links at the top of pages in any way? [17:39:06] JeroenDeDauw: ^ [17:53:18] marktraceur: j^: I don't feel qualified to review that, sorry [17:56:07] JeroenDeDauw: mdale reviewed both, and OKd them, I'm not sure there's anyone better [17:56:51] marktraceur: well sure, but then he should +2 it [17:57:02] marktraceur: I guess he can't, but then he should request access [17:57:11] Not my fault we're being so paranoid about the rights stuff [17:59:53] j^: marktraceur: I suggest you write to wikitech-l and make some noise :) [18:00:35] * marktraceur sighs [18:00:45] All right, I'll look into this [19:15:34] gwicke: I found another bug.

Foo

Bar
serializes to "Foo Bar" instead of "Foo\n Bar" [19:38:12] RoanKattouw: re the first 'disappearing newline' issue: that is by design to ensure round-tripping of headings preceded by a single newline [19:38:31] if there are none, then two preceding newlines are inserted by default as that is prettier [19:38:46] Aaah OK [19:39:02] I'm working on newline preservation using placeholders so this won't be an issue in practice