[02:15:10] ori-l: [02:27:53] ori-l-away: https://developer.apple.com/videos/wwdc/2012/ [02:27:56] ori-l: https://developer.apple.com/videos/wwdc/2012/ [02:51:12] Krinkle: https://gist.github.com/992295 [02:51:29] change 'find ~' to 'find ~/Development' [03:29:28] https://www.mediawiki.org/wiki/Requests_for_comment/Structured_data_push_notification_support_for_recent_changes [03:29:29] ori-l: [03:51:43] ori-l: irc://irc.wikimedia.org/#commons.wikimedia [05:20:27] Is there a certain amount of time before a change set is abandoned and removed from gerrit? [05:41:41] nullspoon: no [05:41:58] they can hang around forever if nobody clicks the abandon button [05:46:45] TimStarling: Thanks. [05:46:55] I've got a change set that's been in there for about two weeks without any work. [05:47:16] I'm working on it. Just don't wanna check in until I've finished the unit tests [05:55:56] oh hey, TimStarling [05:56:25] I've added a new variable to the LocalSettings.php file with my change set. Should I add that both to the configuration changes and to the new features in the release notes? [06:02:04] just new features [06:02:34] nobody really maintains it properly, but I think the configuration section should just be for things that break old configuration files [06:02:57] ah [06:03:00] okay. [06:03:11] I didn't know. I'm new to things here. [06:03:39] Okay. I'm off to bed. My commits are all ready to go for tomorrow when I'm not having troubles getting my eyes to open back up after blinks. [06:03:40] ;) [06:03:57] sounds good :) [13:10:16] [13:18:40] gah [13:18:45] that hurt [13:27:08] I noticed there is a requirement for LocalSettings.php to run unit tests. Is there a default LocalSettings file for this to ensure everyone is testing with the same thing? [13:28:40] Nope [13:28:49] hashar: ^ [13:29:36] nullspoon: not really [13:29:45] nullspoon: tests should be configuration agnostics :-D [13:29:46] (more or less) [13:29:51] but I guess most people have a default settings as set up by the installer [13:30:06] Jenkins use maintenance/installer.php to creates a clear/fresh LocalSettings.php [13:30:09] [13:30:21] overtime people tends to fix stuff that breaks for them because they have some non default global settings [13:30:36] (stuff like $wgShowIPinRC or some $wgExtraNamespaces [13:30:37] ah. okay [13:30:48] our test suite is really lame :-] [13:30:54] it like a beta version ;-) [13:31:03] ha [13:31:19] i'm learning to write for phpunit so my tests will barely compare no doubt. [13:31:20] ;) [13:31:21] some tests do save some globals, alter them, run assertions, restore globals [13:31:47] yep [13:31:49] mine will be doing that [13:32:24] nullspoon: let me know if you need anything [13:33:23] I'll definitely do that. heh [13:46:52] hashar: here goes my first ever unit test using phpunit...let's see how poorly this goes... [13:47:04] I feel obligated by my oklahoma heritage to say 'hey guys, watch this! [17:18:16] Hello chrismcmahon : Would you be kind enough to do a quick test of AFT5 on IE7 on prototype? If you like, we can divvy up the work, and have you test Windows 7 while I do Vista or XP ... [17:19:56] fabriceflorin: sure, looking now [17:20:49] chrismcmahon : Cool. I see IE& it is not supported by Windows 7. So maybe you do Vista and I do XP? http://prototype.wikimedia.org/release-en/Golden-crowned_Sparrow [17:21:27] good call, I have IE7/Vista on my personal VM, using that now [17:29:56] seeing some minor display glitches, random-ish dots by the feature/hide etc. area [17:30:17] daughter sleeping yeah!!! [17:30:52] chrismcmahon: the beta cluster is being rebuild :/ [17:31:16] chrismcmahon: we had some instances corrupted during a migration on labs (which brings more powerful hardware yeah!) [17:31:16] thanks hashar, and yay for puppet I guess :) [17:31:23] definitely [17:31:29] I am so happy to have used puppet from the start [17:31:42] at one point I considered abandoning it and only do local conf change [17:33:11] chrismcmahon: are you attending Wikimania ? (I am not) [17:34:05] fabriceflorin matthiasmullie afaict, AFT workflow is fine in IE7 and display is at least reasonable. the two glitches I see are quasi-random dots appearing by the feature/hide panel, and the smiley on the Golden-crown Sparrow feedback page is just slightly truncated at the top [17:34:15] matthiasmullie chrismcmahon : I just tested IE7 on XP and found a couple bugs, which are enough to prevent us from launching IE7 today, IMHO. The biggest issue is that there is no big blue button on either CTA1 or CTA5. Will send screeenshots by email and add to the Bugzilla ticket. [17:34:34] fabriceflorin: checking that on mine [17:40:14] fabriceflorin: thanks for the attachments [17:40:32] IE7 commit will nog be merged ;) [17:40:35] not* [17:42:58] I'm having a predicament. There is a function called several times in Title.php but it's not in there and the class doesn't extend anything. I did a search for this function (getPrefixedDBKey) and it's never defined. [17:43:09] I'm definitely missing something. [17:44:56] fabriceflorin: just btw, I worked pretty hard to try to re-created fluffernutter's issue without success. I am pretty convinced at this point that it is something to do with her local situation, details sent to Oliver [17:45:33] nullspoon: minor K : getPrefixedDBkey [17:45:45] nullspoon: ack --php -i getprefixeddbkey includes/ [17:46:01] nullspoon: PHP does not care about method/functions case type IIRC [17:46:02] lol [17:46:06] how did I miss that. [17:46:13] * nullspoon facepalms [17:46:17] too much java or some case sensitive language? [17:46:26] * hashar smiles [17:46:33] to be honest, I learned on C# [17:46:51] and never tried calling a function without taking case into account [17:46:56] in php that is [17:47:03] I learned on qBasic (the Microsoft BASIC interpreter shipped with DOS 5.0) [17:47:07] so, in a round about way of saying it, yes, too much java [17:47:10] :) [17:47:13] and had a 101 on a zx81 something that used basic too [17:47:52] anyway the kind of rule we have is to use CamelCase though acronyms (such as DB) remains uppercased [17:47:53] <3 qbasic \o/ [17:48:36] brion: ever played nibbles? I had it hacked to have 3 snakes :-D [17:48:45] since we have 3 brotherhood [17:48:50] yes! and the gorilla game where you threw bananas or something [17:49:01] the ancestor to Worms! [17:49:33] I did a hangman game too [17:49:36] ton of fun [17:50:42] matthiasmullie: Thanks for removing IE7 from today's deployment. Anything else you would like us to test now on prototype? I checked most of the Bugzilla tickets already, and they seemed to work fine for me. [17:50:55] sometimes i go back to my old dos games and port them to the web: http://leuksman.com/vaders/ [17:51:37] Has some of the styles for gerrit been changed? [17:51:39] brion: seen http://www.kickstarter.com/projects/ouya/ouya-a-new-kind-of-video-game-console ? [17:51:53] chrismcmahon: Thanks so much for checking fluffernutter's issues and letting Oliver okeyes know. Please Cc: me on this issue as well, so we're all on the same page ;o) Cheers ... [17:52:13] oooh [17:52:26] brion: I have seen that project. I am surprised you haven't already written a qBasic interpreter in JavaScript :-D [17:52:37] i've considered it :D [17:52:55] that would be an interesting side project :-))) [17:53:57] man, i'm out of hdmi ports on my tv. i dunno if i need another console ;) [17:54:15] * brion bookmarks for future reference though [17:56:28] Reedy: "Have at it: It's easy to root" [17:56:34] You mean it comes with root access already? [17:56:41] Not quite.. [17:56:43] * marktraceur is spoiled by GNU/Linux [17:56:48] They're doing a developer one that's pre-rooted [17:56:55] The others might be [17:57:07] But no warranty voiding by taking a screw driver and opening hte case [17:57:29] Meh. I've seen consoles before, what I need is a free one [17:58:17] backitbackitbackitbackitbackitbackitbackitbackitbackit [17:58:32] Reedy: This one doesn't appear to be terribly free [17:59:10] free as in? [17:59:57] Freedom, of course :) [18:00:13] I shouldn't need to do anything to have root access on my machines [18:00:36] Freedom isn't free [18:00:43] And my machines shouldn't advise me to use non-free software [18:01:08] I suspect if most people don't want it, they won't bother locking it down at all [18:01:29] Reedy: True, but $99 should buy me significantly more freedom than "You can use it, but no modification of the system internals!" [18:01:43] And of course there'll be no public outrage about it, there never is [18:01:53] You can modify it.. [18:02:07] Not without some arcane hand-waving to "root" it [18:02:50] it's only been announced for a few hours yet :p [18:03:00] I suppose [18:03:24] Though if they've started out seeking Minecraft, Team Fortress, et. al., they'll likely move away from the free software model, not towards it [18:03:57] I see DRM in its future, to be sure [18:04:39] >$500k [18:05:31] I don't get people wanting USB3 [18:05:37] I'm not sure the device could handle the bandwith [18:21:22] matthiasmullie: How are you coming along with today's AFT deployment? Are you pushing to testing yet? [18:21:44] I'm pushing to testing indeed [18:28:49] fabriceflorin: chrismcmahon: AFTv5 is on http://test.wikipedia.org/wiki/Golden-crowned_Sparrow [18:29:03] changes pushed today are: [18:29:06] - CTA5 missing header "thanks! your feedback has been posted here" [18:29:11] - CTA4 container collapsing [18:29:19] - Show the user's last post at the top of the page [18:29:26] - Article Feedback - My Contributions (updates to newbie view) [18:29:31] - Article Feedback - 'View Activity' does not appear in Editor's view (add in helpful/unhelpful actions & fix total counts) [18:29:36] - lower AFTv4 odds to display AFTv5 at 3% (inverse odds) [18:30:39] Thanks matthiasmullie : We're on it! [18:31:56] one of the pages that should now have AFTv5 on test, but did not have last week (3%) is http://test.wikipedia.org/wiki/Jailu%27s_test - which correctly seems to display it [18:34:31] once we push to production, these pages should be getting AFTv5 (but do not have it right now): [18:34:34] http://en.wikipedia.org/wiki/Aerobeacon (id 30008971) [18:34:36] http://en.wikipedia.org/wiki/Adwaita (id 4491976) [18:42:01] fabriceflorin: are you seeing the feature/hide/oversight panels on test? [18:43:04] * chrismcmahon sees only "Feature" in IE8 and nothing in FF [18:51:42] Hi matthiasmullie : I found one minor bug that may be related to the need to update messages on the servers. When I log in as a new auto-confirmed editor, and mark something as helpful, then view the activity log, I get this garbled message: AFT Editor <articlefeedbackv5-activity-helpful> 18:48, 10 July 2012 That's on this page: http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/156 [18:52:42] matthiasmullie: I also notice that this page says at the bottom Activity section that there has been 1 action but that "There has been no activity on this post." - minor bug, which should not prevent us from deploying, IMHO. [18:53:05] fabriceflorin: l10n cache is currently updating; we should know in a couple of minutes if it's fixed :) [18:53:32] hmm, I wonder if my account on test isn't correct [18:57:02] fabriceflorin: the script to rebuild l10n cache fails [19:00:03] matthiasmullie: What are the implications of the |10n failure? Does it only affect our ability to fix the garbled message on testing? Or are there deeper issues? If not, and if we think we can fix this garbled message on production, maybe we should ignore the small issue I reported above, and move to production -- assuming that Chris didn't find any nasty bugs on his end. [19:00:41] it only affects the message on testing [19:00:49] but we're unable to "test" it atm [19:01:33] chrismcmahon: Which account are you using on testing? You are welcome to use our editor account, if you like: userID = 'AFT Editor' - Pwd: same as for our other AFT accounts, such as aft5hide on production. [19:02:49] fabriceflorin: RoanKattouw is looking into it as we speak [19:05:29] fabriceflorin: RoanKattouw (again) helped us out; l10n cache rebuilding as we speak [19:06:02] Thanks, matthiasmullie and RoanKattouw : much appreciated! [19:13:45] fabriceflorin: I've added the "There has been no activity on this post" issue to bugzilla; will get it fixed by next week - ok? [19:13:50] Emw: https://en.wikipedia.org/wiki/User:ErfgoedBot [19:14:53] fabriceflorin: ready to push to production? [19:17:06] Hi matthiasmullie : Yes, I am ready to go to production. chrismcmahon OK with you too? [19:17:17] OK by me [19:17:58] Cool. Let's go to en-wiki, then! I was able to confirm that the garbled message has been fixed after the cache was rebuilt, thank you! http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow/156 [20:11:29] fabriceflorin: it's still pushing to production, but most servers have been hit already [20:11:39] so you're good to test [20:11:53] Thanks, matthiasmullie ! I will start testing now. [20:11:55] message cache is the last thing being refreshed, so if you see issues with that, that's normal so far [20:15:01] fabriceflorin: I'm a bit confused with timezones right now. What's the time window where you need me to port the article over to WordPress? [20:15:46] Hi Guillom, I was hoping to port the blog post to Wordpress in the next couple hours. Where are you now? Are you still in France or are you in DC? [20:16:27] fabriceflorin: I'm in DC, and I don't know yet what my plans are going to be for the evening, so I was asking you to make sure I ported it over before I went for dinner. [20:16:47] fabriceflorin: do you want me to do it now, and you'll make your edits directly in WordPress? [20:17:09] guillom: Correction. I was hoping to *publish" the blog post in the next couple hours. I am now working on the copy and hope to have it ready to be *ported* within the hour. [20:17:20] Ah! OK :) [20:18:08] fabriceflorin: ok, then send me an e-mail when you're done and I'll port it over. After that, will you need to make further changes, or should I post it immediately? [20:18:29] guillom: If I am holding you up, you could port it to Wordpress sooner, but I am in the middle of editing the doc on meta, so would prefer to have another half-hour or so to finish that editing -- once I am done with testing matthiasmullie 's new deploy on production, that is ;o) [20:19:32] fabriceflorin: no problem. I can port it over to WordPress if you send that e-mail in the next 60 minutes. After that I can't promise I'll be available. [20:19:45] Does this sound reasonable? [20:20:46] guillom: Yes, that sounds reasonable. I will get you the copy by email with a link to the final draft on meta in the next 60 minutes. Thanks for making time for this! [20:20:56] Sure :) [20:27:46] [20:28:02] waaaaaaaaaaaaaaaa? [20:28:13] Know anyone working with mwclient? [20:29:43] fabriceflorin: chrismcmahon: for me it's looking good so far (apart from the "There has been no activity on this post" error already reported by fabriceflorin) - how about you? [20:29:45] Nopes [20:30:21] [20:34:59] Hi chrismcmahon, we are now on production, not testing. I did not test in Windows there yet, but I can, if you think it would be helpful. [20:35:26] on a hiring call for 30 [20:36:16] matthiasmullie: It's looking good for me too, still checking a few final items. I got scared initially, because I got 2 AFT5 articles in my first 10 clicks on 'Random article' -- but it was just bad luck ;o) [20:36:44] chrismcmahon: OK, I will test IE8 an FF on Windows on production now. Which OS do you recommend? [20:40:02] matthiasmullie: FYI, I cannot see the AFT5 feedback form or page when testing IE8 on XP on the Golden-crowned sparrow page on en-wiki. Will now try another Windows OS, like Vista. [20:43:14] that's weird; I've got a virtual machine running IE8 where I can see it [20:43:49] could it be that assets are cached by your browsers, or is it the first visit? [20:45:08] I can see everything with IE8 on Win7, and it works as intended -- but not on XP. No assets are cached by the CrossBrowserTesting VMs, to my knowledge. Will try VISTA now. [20:53:41] matthiasmullie chrismcmahon : I think we are good to go with this deployment. I could not find any other issues at this time. Thank you all for a job well done! [20:54:04] yes, sounds good [20:54:33] i'll give IE8 on XP another shot to see what's going wrong [20:54:42] but won't be today ^^ [21:00:29] matthiasmullie : No worries, this is not a show-stopper. Nice work today, thanks again! Get some rest. Speak to you next Monday … [21:36:55] siebrand: Heb je een linkje voor de extensie? [21:37:29] multichill: git clone ssh://siebrand@gerrit.wikimedia.org:29418/mediawiki/extensions/ISO3166 [21:37:48] multichill: ehr, siebrand vervangen door je gebruikersnaam [21:41:37] Who owns the ISO639 extension? [21:45:32] Reedy, SPQRobin [21:45:37] https://gerrit.wikimedia.org/r/#/admin/groups/154,members [21:46:01] it's teh empty! [23:29:53] I'm trying to run my unit tests without a database backend but keep getting the error "DBConnectionError: DB connection error: No such file or directory (localhost)". Do I just need to mock up a database or is there already a mock object for that that i'm missing? [23:36:43] * AaronSchulz waves TimStarling [23:37:02] ah, hello AaronSchulz, I think I know what you want [23:37:33] heh, I'm copying stuff already...I'll just fix the acls retroactively [23:39:26] TimStarling: can't I just say hi, who says I always want stuff ;P [23:44:09] - $bytes = file_put_contents( "{$dir}/index.html", '' ); [23:44:10] - if ( !$bytes ) { [23:46:07] I hope it wasn't me who missed that originally [23:48:48] you can't catch everything all the time, no matter how stupid :) [23:49:35] TimStarling: huh, I wonder why it conflicted, it was rebased recently [23:50:54] heh, documentation conflict ;)