[08:17:06] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/14666 [08:17:33] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/14667 [12:48:57] I'll be branching 1.20wmf7 in a littlw hile [12:54:43] woo hoo [12:59:52] so, we need the js files around for last day of deployment + 28 days (squid cache length).. from memory [13:00:05] wmf1 is gone [13:00:24] wmf2 was fuly replaced by wmf3 on 23rd May [13:00:46] wmf3 was fully replaced by wmf4 on 6th june [13:01:13] wmf4 was fully replaced by wmf5 on 20th june [13:01:28] based on that, wmf2 and wmf3 shoud both be completely unused now [13:05:16] > var_dump( $wgSquidMaxage ); [13:05:16] int(2678400) [13:07:26] 2678400/3600 = 744 hours / 24 = 31 days [13:07:59] ah hah [13:08:25] so yeah, 2 and 3 are clear to go [13:08:30] * Reedy delets [13:19:36] yay [13:25:34] apergos: could you delete the remnants of /home/wikipedia/common/php-1.20wmf2 for me please? Getting permission denied on a few remnant git objects [13:25:43] lemme look at that [13:26:21] so you want extensions to be gone from there? [13:26:42] the whole folder can just go [13:26:46] it's otherwise empty [13:26:58] heh preilly tsk tsk [13:27:18] wmf3 is fine, so we must've sorted it later on ;) [13:27:33] *poof* gone [13:48:57] slow cloning is slow [14:08:28] it's the new "compiling" [14:19:49] can we distc it somehow? ;) [14:25:09] only if you write one :-P [14:25:32] heh [14:26:13] ls -al [14:26:15] bah [14:26:23] heh [14:26:42] not aliased to something clever in your irc client? [14:28:13] noope [14:28:27] Ok, so it won't let me set the "correct" permissions for the l10n cache dir [14:28:37] According to Roan it needs to be l10nupdate:wikidev [14:29:02] soooo [14:29:20] I don't see how you would do that unless we have a setting in sudo [14:29:35] maybe that needs to be an rt ticket [14:29:54] but sudo'ing to create the dir, or chown'ing it gives permission denied [14:29:55] reedy@fenari:/home/wikipedia/common/php-1.20wmf7/cache$ sudo -u l10nupdate echo hi [14:29:55] hi [14:29:56] ;) [14:30:10] meh seriously? [14:30:31] reedy@fenari:/home/wikipedia/common/php-1.20wmf7/cache$ sudo -u l10nupdate mkdir -m 0755 /home/wikipedia/common/php-1.20wmf7/cache/l10n [14:30:31] mkdir: cannot create directory `/home/wikipedia/common/php-1.20wmf7/cache/l10n': Permission denied [14:30:51] reedy@fenari:/home/wikipedia/common/php-1.20wmf7/cache$ chown l10nupdate:wikidev l10n/ [14:30:51] chown: changing ownership of `l10n/': Operation not permitted [14:31:25] I suppose the former is due to l10nupdate not being me or in the wikidev group [14:31:46] meh [14:31:50] BAH [14:32:23] yeah, if I chmod 777 the cache dir, I can create it.. [14:32:57] I don't see how you can chown anything if you're not a privileged user though [14:33:13] i.e. uid 0 [14:33:40] if you can create it as the right user then that's the way to go [14:34:32] chmod 777 on cache, then I can do sudo -u l10nupdate chgrp wikidev /home/wikipedia/common/php-1.20wmf7/cache/l10n [14:34:41] I can't change the group of the folder then [14:35:35] Rather pointless if I have to poke a root everytime I want to do a deployment [14:35:47] yep [14:36:22] it needs to be l10n / wikidev [14:36:26] yup [14:36:36] yeah that's not going to happen without root. or l10n in the wikidev group [14:36:38] I think peter fixed it for me last time [14:36:46] mmm [14:36:57] I wonder if there's any reason l10nupdate can't be in wikidev [14:37:05] dunno about that [14:37:12] guess you should ask around [14:37:20] in the meantime I can fix the perms for you for now [14:37:22] I guess that means Tim/Roan [14:37:25] Please [14:37:56] check please [14:38:09] you should be able to set perms, I only did the group ownership [14:39:27] That looks right [14:39:35] great [14:39:49] Roan said 755, but surely wikidev users need to be able to write to the dir... [14:40:47] I should check what scap runs the localisation stuff as [15:10:00] I have a amended commit with changes but gerrit won't take it [15:10:19] it says "no changes" [15:10:22] ideas? [15:11:21] usually means you haven't actually changed anything [15:11:32] I've done some silly things fixing merge conflicts and got that before [15:11:44] Reedy: I know that at least my commit message has changed [15:11:49] I can see that much [15:11:57] ah [15:12:59] hrm... I'll have to try making sure I change more and then see if that does it [15:19:06] https://www.mediawiki.org/wiki/MediaWiki_1.20/wmf7 [15:44:17] https://test2.wikipedia.org/wiki/Main_Page [15:44:20] test2 is on wmf7 [18:06:05] testwiki, test2wiki and mediawikiwiki are now on 1.20wmf7 [18:08:39] I upset CR [19:13:18] AaronSchulz: I am reviewing your LRU cache :-D [19:13:29] AaronSchulz: will send some failing tests as a new patchset [20:15:04] ^&*%&^*%*&^%% forgot my earbuds [20:15:18] now to buy new overpriced airport earbuds whee [20:15:34] gawd I've seen those [20:15:51] poor brion :( [20:17:54] yep [20:30:47] earbuds obtained [20:30:51] flight saved [22:07:01] tfinc: I just noticed you're still default CC on some of the FR related extensions. Want me to remove you? [22:10:14] Reedy: in re that same bug (38269) is this new? AFAIK we haven't made any recent changes to that code [22:10:28] No idea [22:10:34] Just saw the spammage [22:10:46] okay. well, I'm looking into it a bit [22:11:16] there's obviously something about that page range [22:11:40] i don't know enough about refreshLinks and page ranges to know where to start there [22:12:29] return efContributionReportingTotal( $fundraiser, $fudgeFactor ); [22:13:07] For $fundraiser to be set, it has to at least do one iteration of the loop, and also $key == 'fundraiser' [22:14:19] funny enough, i've never touched this code and didn't even have a clone of it … fixing that [22:14:53] heh [22:15:32] i do so enjoy how that variable is never initialized [22:15:48] oh, well, it is a little [22:16:02] yeah [22:16:11] Amusingly phpstorm knew that it's possible for it to not be ;) [22:16:20] While you're there, you can remove $start [22:17:00] I assume we are seeing the same inspections from phpSTorm [22:17:52] * pgehres is trying to figure out a sane default for $fundraiser [22:20:08] Reedy: I'm going to ask kaldari what he thinks the default should be since he wrote most of it, but he is AFK atm [22:20:24] It's not urgent [22:20:28] Just thought it was worth noting [22:20:43] no, but its annoying and there is no reason that we should let it ferment