[09:23:50] Krinkle: you can undo this http://www.mediawiki.org/w/index.php?title=Template%3AWikimediaDownload&diff=555738&oldid=555141? ExtensionDistributor not works with git, and link Download snapshot doesn't help the user and is only confusing [09:24:20] pastakhov__: 1.19 has been added now [09:24:55] svn branches, yes. But git-only extensions are not supported either way. Most extensions (even ones in gerrit now) were first in svn. [09:25:03] and most people will be wanting to download the stable 1.19 branches [09:25:13] and the master does go to git iirc [09:25:20] what was changed today [09:25:33] that* [09:26:19] I see the git-master is still being configured [09:26:48] but I disagree it is confusing this way. Not providing a download option at all is useless. Now they can download all stable versions between 1.19 - 1.12. [09:27:13] the "trunk" option will be wrong, but there is a "Git master" link next to it that does work, and its still better than having nothing at all [09:37:46] Krinkle: i make the link was not visible when the specified Gerrit, this bad idea? http://www.mediawiki.org/w/index.php?title=Template%3AWikimediaDownload&diff=553304&oldid=543757 [09:38:26] Yes [09:38:40] Like I said, whether svn or gerrit. All extensions (so far) originated from svn. [09:38:45] That's where the stable versions are [09:39:09] and old versions generally don't change so whether it loads from svn or git doesn't really matter [09:39:51] Right now it shows mediawiki versions up to 1.19 as options (downloads from svn branches) and a Git master link [09:40:07] that sounds good, right? Better than just having a git master link, which people that want to install the stable version for their MW 1.18 or 1.19 install will not need. [09:44:49] Krinkle: not good. if set server=gerrit, therefore SVN is missing and the link download snapshot confusing [09:45:34] pastakhov__: SVN is not missing. Extensions moved to Gerit have the SVN repositories in read-only [09:45:51] and even if someone removed it (which they shouldn't) then it still only applies to trunk, the branches are still there [09:48:49] Krinkle: SVN missing for new extensions [09:50:36] Well, no disrespect to those extensions, but I'd rather have the new extensions have an additional link that doesn't work, then 100+ extensions in popular use with no links at all. [09:50:53] pastakhov__: we can could create an option for gerrit-only [09:51:49] its all temporary anyway since we should be working on getting Git work in ExtensionDistributor. Mean while there is lots of complaints for people using 1.19 unable to download from mediawiki.org - those are now able to download again. [09:54:03] Krinkle: I'm talking about it, if server=gerrit in Template:WikimediaDownload, mean extension use gerrit only snapshot [09:54:59] Krinkle: and link to ExtensionDistributor not works... is not it? [09:55:51] pastakhov__: https://www.mediawiki.org/wiki/Extension:CharInsert [09:56:01] server=gerrit because it was imported in Git and development is in Git [09:56:12] but has many versions and people need to be able to download it [09:56:25] the 1.18 version and 1.19 version [09:56:48] and link for Git master as well [09:56:55] that's the most common scenario [09:57:06] I agree there are more scenarios, if you find a way to fix both, go ahead. [09:57:30] Krinkle: all, I give up :-) [09:58:03] pastakhov__: Sorry, I know the problem you mean. I just don't see a quick way to fix that without breaking the rest. [09:58:17] Ask on the talk page, maybe someone else knows :) [10:05:30] Krinkle: add param "server=gerritonly" in Template:WikimediaDownload? [10:13:05] Krinkle: i see, many extensions use server=gerrit, may be add new param "server=gerritonly" for new extensions, which are not in svn? [10:13:30] pastakhov__: sounds good [10:13:38] Krinkle: I try to do it yourself? [10:14:01] Sure, try it [10:14:04] I have to go know [10:14:06] bbl [10:15:15] Krinkle: :-) [12:34:21] Krinkle: готово :-) [15:08:51] What's our minimum PHP version? [15:10:21] 5.3.2 [15:10:34] if ( !function_exists( 'version_compare' ) || version_compare( phpversion(), '5.3.2' ) < 0 ) { [15:10:34] require( dirname( __FILE__ ) . '/includes/PHPVersionError.php' ); [15:11:35] Great [15:22:33] New patchset: Hashar; "document ant task git-files-changed" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/13168 [15:22:34] New patchset: Hashar; "ant: gitsqlhaschanged: whether HEAD has a .sql file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/13169 [15:22:54] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13169 [15:23:02] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13168 [15:23:04] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/13169 [15:23:05] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/13168 [16:23:00] ^demon: congrats on being able to push to Gerrit project! [16:24:24] <^demon> Old news, I just haven't told everyone :p [17:26:44] Hey AaronSchulz, have time for a sanity question? [17:28:55] * AaronSchulz wonders why a schema change on his testwiki is taking so long [17:55:44] binasher: why do mysql subqueries suck? :/ [17:55:57] * AaronSchulz uses a work-around [17:56:07] csteipp: ok, what's it about? [17:56:21] AaronSchulz: they won't in 5.6! or right now in mariadb 5.3 [17:56:30] binasher: http://bugs.mysql.com/bug.php?id=6980 [17:56:50] * AaronSchulz heard rumors that Maria is better for SSDs [17:57:30] in includes/Xml.php wrapClass says it escapes the $content, but am I missing something, because it doesn't look like it does..? [17:58:02] Sorry, I meant "$text", in wrapClass... line 262 [17:59:01] AaronSchulz: the mariadb improvements to innodb are all from percona [17:59:03] Or does Xml typically get extended by another class that does the escaping in its tags function? [17:59:34] nothing extends Xml class [18:00:30] csteipp: the comment is wrong [18:00:39] binasher: yep [18:00:52] Nikerabbit / AaronSchulz: thanks! Just wondering if I was missing something. [18:01:30] binasher: hopefully they can pick of the slack Oracle decides to kill mysql ;) [18:02:21] was added in 8097d1cb [18:02:39] and the method was added by me over 4 years ago [18:06:58] I'll be back in a few. I guess we're not in a rush to deploy [18:26:32] Reedy: ping me when you get back [18:30:26] robla: back now [18:30:33] ohai :) [18:30:40] see #wikimedia-tech [18:36:01] I need to log some relatively rarely (once per several minutes) encountered events on the cluster. is it allowable to log this in some NFS shared file, or WMF has some more complex logging infrastructure? [18:36:41] Use wgDebugLogGroups [18:38:41] Reedy, thanks - and how do I see them after they've been logged to UDP? [18:39:19] MaxSem: use wfDebugLog( 'tempDebug', "some text\n" ); [18:39:29] then look at /h/w/l/temp-debug.loh [18:39:32] *.log [18:40:02] /home/wikipedia/log [18:40:17] i tend to touch the log file first [18:43:20] don't we need to add an entry in $wgDebugLogGroups first ? [18:45:07] MaxSem: ^ I think you need an entry in $wgDebugLogGroups first, or message will end up in a blackhole (aka '') [18:48:10] Reedy & AaronSchulz, thanks [19:09:03] Hello [19:09:08] howdy, sir. [19:09:23] If one wants to link an external image per http://www.mediawiki.org/wiki/Help:Images#Files_at_other_websites [19:10:02] the image link will be matched against a prefedined regex, which is EXT_IMAGE_REGEX in /includes/parser/Parser.php. [19:10:35] This regex contains a fixed set of img extensions - gif|png|jpg|jpeg|bmp - so if one wants to link e.g. a bmp file, s/he can't do that. [19:10:52] 'bmp' is not included in that list by default. That is what spurred this. [19:10:59] Quesiton 1. Is that intentional? [19:11:27] Question 2. If not, then could you please add the bmp extension to the regex? [19:12:08] yes, all this arises from a problem which ascheel found during linking a bmp img. [19:12:15] Question 3. Would the wikimedia dev team entertain a patch to allow the extension list to be overridden via LocalSettings.php? [19:12:47] An option would be allowing to specify the regex in LocalSettings.php [19:13:00] Another option would be allowing to specify only the list of extensions [19:13:03] in an array [19:13:53] overriding the entire regex would be easier for the initial coding, but be unnecessary and easy for the end user to hose during configuration. [19:14:03] and have Parser.php either (1) generate the EXT_IMAGE_REGEX based on the array, or (2) replace EXT_IMAGE_REGEX with a function that iterates on the array each time a link has to be tested [19:15:23] whopps, I wrote "generate EXT_IMAGE_REGEX" instead of "initialise EXT_IMAGE_REGEX" [20:08:41] boy____: I think we don't want to link to bmp files [20:08:43] cause they are huge [20:08:56] instead pass through a thumbnail wich will happily compress it as png [20:08:58] cant remember [20:09:06] I think I am the one that added BMP support in mw [20:09:58] hashar: but wouldn't it be feasible to leave it up to the end-user as to whether to allow linking of them? They are huge, but there are a LOT of end-users that deploy it in a LAN scenario where size isn't an issue. [20:10:24] ascheel: well it still take network usage [20:11:13] hashar: aye, indeed it does but when you're on a LAN, it's irrelevant in many cases. I have one deployed on a gigabit network and while it's not too big of a deal to modify Parser.php, any time I upgrade mw, I'll have to redo that patch. [20:11:14] fc1a14e , hashar, Sun Apr 22 17:34:09 2007 +0000 [20:11:15] doh [20:11:17] that is old [20:11:28] haha, indeed it is [20:11:35] so hm [20:11:51] I am pretty sure I have tested in my localwiki using a bmp file [20:12:01] found out that it magically got through png [20:12:04] and thought it was fine [20:12:14] png is a variant of bitmap, that's why [20:12:24] * hashar loves git [20:12:27] I got the sha1ççç [20:12:30] just like renaming a .mp3 to .wav will oftentimes work. They are wav files, just compressed. [20:12:35] that is in a release notes: +* BMP images are now displayed as PNG [20:13:05] ascheel: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=d94ad6db951f75fb7c8f7932cf2d8cc4521e4cfd [20:13:28] from MediaWiki 1.14 apparently [20:13:32] so that is a feature!! [20:13:42] hahaha [20:14:06] one of the very few feature I have made :-D [20:14:22] so what you could do [20:14:26] Why would you never want to use .bmp in ? [20:14:57] is to extends BmpHandler class, override the mustRender() to return false, and override getThumbType to call BitmapHandler::getThumbType [20:15:11] then that new class could be set as a thumb handler for image/x-ms-bmp and image/x-bmp [20:15:25] annnnd that's 10 feet over my head. haha [20:15:26] which can be done using $wgMediaHandlers ; [20:19:16] ascheel: writing you a patch [20:19:33] You are a gentleman and a scholar! [20:23:13] ascheel: https://gerrit.wikimedia.org/r/13270 [20:23:54] ascheel: gitweb: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=172c9d51cdf6e655710d90f4b685f1203425209d [20:23:57] totally untested [20:24:24] there is a [patch] link on gitweb for you to download [20:24:26] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=patch;h=172c9d51cdf6e655710d90f4b685f1203425209d;hp=82b2660ee37c6a3e174cea72e66386fe758ff4aa [20:24:41] btw, that can be made an extension really easily [20:24:54] just ship that class, add it to the autoloader [20:25:00] then override $wgMediaHandler :-] [20:25:07] that would be a great exercice [20:26:05] boy____: I wrote a patch :-) see above [20:26:11] not going to be included in MEdiaWiki though [20:26:16] but that could be made an extension [20:26:26] I have created extensions, before! This won't be a big deal. [20:26:58] you will have to test that code though [20:27:16] hashar: yes but I'm lost, I can't see how this relates to linking images that are stored from another wiki [20:27:16] of course! [20:27:32] oh sorry [20:27:39] I must say that I also do not know the structures of the MW code and the function of the classes involved [20:27:56] well I was indeed on a different subject huhu [20:28:19] hashar: what does a media handler do? [20:28:44] that is used by mediawiki to interact with a media file such as .SVG or a .JPG [20:28:56] Handles media [20:29:10] so what we do is find out the mime type of a file [20:29:20] e.g. it generates thumbnail from media? [20:29:24] then we load the appropriate php class by looking at $wgMediaType [20:29:34] then create an object which is able to understand that file format [20:29:44] and does things differently from a format to another [20:29:55] ok [20:29:58] for example, the BMP file need to be compressed and we want to use PNG when compressing it [20:30:02] that is what BmpHandler class does [20:30:19] Why does it have to be compressed? after all it's supposedly stored on the wiki (I suppose) [20:30:45] to handle .gif files, we had to write our own class to read metadata [20:31:07] that let us count the number of frames in an animated gif [20:31:34] and we also have our own implementation of reading EXIF metadata \O/ [20:31:52] That's Bawolff's, right? [20:32:17] the exif stuff? [20:32:26] Ævar [20:32:44] hum. I know Bawolff had a gsoc on exif... [20:32:49] [20:34:07] [20:35:53] maybe to enhance our exif class [20:35:58] or something else [20:36:13] I don't track gsoc project :/ [20:37:50] bed time for now [20:37:54] see you later ! [21:03:56] I've done a patch [21:59:37] http://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=556027 [22:01:16] whopps, that has + and - inverted... this is the correct link [22:01:16] http://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=556028 [22:02:52] fixed again -.- this is more correct [22:02:53] http://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=556030