[04:50:27] Any devs here that could answer a code review question for me? [06:36:36] hi all, i need help. extension NumberFormat not found in page Special:ExtensionDistributor [06:38:59] do you have NumberFormat installed? maybe it's a dependency [06:41:02] Hi pastakhov [06:41:28] i commit in git repo extension/NumberFormat [06:42:29] but this not found in page Special:ExtensionDistributor [06:44:03] Maybe it's only linked to the SVN right now. [06:47:23] Dereckson: mmm.... make commin also in SVN? [06:49:46] it would be more constructive to request an ExtensionDistributor update [06:49:56] (and first we have to assert this is the cause) [06:50:59] http://wikitech.wikimedia.org/view/ExtensionDistributor <-- seems indeed linked to svn [06:58:48] Dereckson: thanks. "Git master" link work.... maybe need remove "Download snapshot" link from extension page? how to make download link? [07:09:03] pastakhov: probably patching ExtensionDistributor source code to check if the extension is in svn. [07:13:09] Dereckson: NumberFormat extension in git only [07:30:53] pastakhov: it's why we should patch the ExtensionDistributor source code to be able to deal with this situation [07:40:28] Dereckson: how to request an ExtensionDistributor update? [07:49:43] pastakhov: if you wish someone else to do it, fill a bug on Bugzilla, product: MediaWiki extensions [07:50:01] if you wish to do it, clone the git repo, patch, submit againt to gerrit review as you would do for your extension [07:51:03] Hi hashar [07:51:19] been on Undernet before ? :-D [07:52:48] Yep. I had a Windows chat & support channel there, #win. [07:53:23] It were created in 2001 to convert people to migrate from 9x to NT kernel [07:55:40] Dereckson: was it successful ? I myself migrated from 9x to Win around that time 2000 [07:55:46] huge stability gain [07:56:05] I have been on Undernet too, though by 2000 I was barely connecting anymore [08:02:17] hmmm ... some success metrics: 92 people who successfully passed the member process, 35 active members, a website recognized at Microsoft France partner community for Windows 2000, IRL organized in Belgium, Paris, Quebec and Montreal with 5 (the .qc ones) to 20 members (that were for Paris), a "democrative" process with an elected 500, collaboration with other help channels to improve our services [08:02:42] impressive [08:02:48] oh and the funny stuff is it were on our channel some people came to ask how to install linux because they were kicked from channels to ask too many stupid questions [08:03:24] (I don't know if it's us who were patient, or linux channels weren't, probablly both) [08:03:46] I spend all my teenagers years on IRC to manage this project :p [08:03:49] spent [08:04:17] un peu des deux très probablement [08:04:21] What were your favourite network in 2000s? [08:04:45] Freenode #mediawiki or something similar [08:04:52] well technically [08:04:58] Yes but between 2000 and 2003? [08:05:15] that was EverQuest, Karana, <#amethyst> [08:05:16] ;) [08:05:44] I have spent like 4 years of my life doing nothing but working and playing online games such as CounterStrike, StarCraft & EverQuest [08:05:49] (and working) [08:06:03] I wouldn't have imagined you as a former hardcore gamer [08:06:04] then woke up IRL, met my wife, leaved Paris :-] [08:06:35] coffee time, brb [08:06:49] I've to go to my Oxfam bookshop, ++ [08:06:53] have a good coffee [09:40:01] there is no more semantic/intuitive way to check if page is redirect than wgRedirectedFrom !== null ? [09:52:06] Dereckson: https://bugzilla.wikimedia.org/show_bug.cgi?id=37824 (RESOLVED INVALID) [09:53:02] Dereckson: maybe I'm not so written? [11:38:08] Change on 12mediawiki a page OAuth was modified, changed by Guillom link https://www.mediawiki.org/w/index.php?diff=553347 edit summary: link [11:38:22] Wat. [11:38:58] funny, petan spoils the fun on #mediawiki and adds bots here? :) [11:39:25] Change on 12mediawiki a page OAuth was modified, changed by Guillom link https://www.mediawiki.org/w/index.php?diff=553350 edit summary: group [11:39:47] Nemo_bis: this one is watching different pages [11:39:55] * guillom cringes. [11:39:58] petan, so? [11:40:09] Nemo_bis: so it has nothing to do with #mediawiki [11:40:24] petan, it has to do witht eh fact that it's useless [11:40:25] Nemo_bis: and it was here reporting these changes before it even was in other channels [11:40:32] Nemo_bis: what is useless [11:41:03] petan, the bot here, contrary to the bot on #mediawiki (IMHO) which is still hated by many [11:41:26] Nemo_bis: what is hated by many and why? [11:41:34] sigh [11:41:49] Nemo_bis: I don't know about any bot which is hated, just that #mediawiki was overloaded with various feeds [11:41:58] it still is [11:42:06] I hope it will always be [11:42:20] well, than I don't get the point of this whole discussion [11:42:22] * then [11:42:32] * Nemo_bis shrugs [11:42:39] you like the feed, I like the feed so what's wrong [11:42:48] I like it on #mediawiki and dislike it here [11:42:53] why [11:43:04] on #mediawiki it's reporting different stuff [11:43:08] because it serves no purpose [11:43:11] yeah [11:43:18] Nemo_bis: here? [11:43:19] why [11:43:19] I'll just use ignore, nevermind [11:43:24] ok [11:43:46] Nemo_bis: you mean it server no purpose to you, or others? I find it quite useful [11:43:52] serves [11:44:01] * ^ [11:44:31] not my duty to judge [11:45:44] tbh I don't think it's anyone's duty, but you are the first person who complained so far [11:46:08] so I am surprised you say "it's hated by so many" [11:50:35] @recentchanges-off [11:50:35] Feed disabled [11:51:23] @infpo [11:51:26] @info [11:51:26] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [11:51:41] @recentchanges-on [11:51:41] Feed is enabled [11:51:55] @RC- mediawiki OAuth [11:51:55] Deleted item from feed [13:00:00] I've got a question about a problem I seem to have gotten myself into with git. anyone got a sec? [13:05:48] nullspoon: sure [13:08:53] Oh, hey hashar [13:09:00] you've got perfect timing [13:09:09] well hmm [13:09:25] I am just there daily from 9:30am till 6pm :-D [13:09:30] before the git thing, I wanted to ask you about your review of my code to make sure I understood whatneeded to be done. [13:09:35] heh. Thanks [13:11:14] so, I checked your review and you said there was a problem with my change and then mentioned I needed to add an entry in RELEASE-NOTES under new features [13:11:34] Was the missing release notes entry the problemw ith my change or was there something more? [13:11:51] there's evidently a problem with my typing. heh [13:12:24] nullspoon: yea [13:12:37] nullspoon: your typing is missing a revision number or gerrit change number :) [13:13:02] nullspoon: whenever we add a feature / bug fix in MediaWiki, we also add an entry in the RELEASE-NOTES-1.20 file [13:13:04] oh, sorry. It's revision one. lemme do revision two... [13:13:05] ;) [13:13:09] nullspoon: kind of a ChangeLog file [13:13:15] right [13:13:20] so people can easily find out what changed form a version to another [13:13:39] so if your rev / change forgot that RELEASENOTE entry, we don't want to merge your change in :-D [13:13:53] Sorry about that. Didn't think about that. I keep my own on my personal projects but apparently didn't think to add mine to mediawiki. [13:13:56] just cause then people will complain at us because we are hiding new features from them :-] [13:14:03] Great. [13:14:11] Well I've added it to Release notes [13:14:15] that is really a minor sissue anyway [13:14:25] so what is your change number ? :-] [13:14:27] and so I have arrived at my problem with git. :) [13:14:35] ohh [13:14:36] I83f6a614874c3d289ff4bd8d015f1d9c92e500b6 [13:14:38] trouble adding the file? [13:14:41] well [13:14:42] not quit [13:14:44] quite* [13:14:48] quiet , [13:14:49] ? [13:14:55] or /quit ? [13:15:00] quite [13:15:06] <(OO)> [13:15:09] Rev. 2 [13:15:10] :) [13:15:24] I need to slow my typing down. [13:15:29] na it is fine [13:15:39] nobody read that channel beside you and me [13:15:55] and if you type to fast, you will just be automatically kicked by the server ;-D [13:16:02] ha [13:16:09] so that patchset2 does not have a RELEASENOTE file [13:16:12] Well that'd be an achievement. [13:16:19] "I can type so fast that chat servers kick me." [13:16:20] you need to download the patchset [13:16:30] edit the entry in the release note file [13:16:40] then stage that change ( git add RELEASE-NOTES-1.20 ) [13:16:54] verify what you have staged with: git status and git diff --cached [13:16:57] once happy [13:17:09] amend the commit to add those staged changes: [13:17:11] git commit --amend [13:17:16] Sorry about that. Broken pipe to my proxy server. [13:17:19] then review your commit using: git show [13:17:27] oh [13:17:29] let me copy/paste [13:17:32] thanks [13:17:33] you need to download the patchset [13:17:37] edit the entry in the release note file [13:17:40] then stage that change ( git add RELEASE-NOTES-1.20 ) [13:17:46] verify what you have staged with: git status and git diff --cached [13:17:55] once happy, amend the commit to add those staged changes by using: [13:17:58] git commit --amend [13:18:11] then review your commit using: git show [13:18:21] awwwright. so far I know all of those. I feel a bit less helpless now. :) [13:18:28] So I started doing that.... [13:18:31] if you are happy with it, send it to gerrit either with git-review or using git push origin master:refs/for/master [13:18:40] DONT CHANGE THE Change-Id: value in the commit message :-] [13:18:46] okay [13:18:59] well here's my predicament. I'm nto quite sure how to get out of it. [13:19:04] I had the patchset on my box [13:19:13] Change-Id is used to gerrit to find out that the new commit you are changing is intended to replace a patch set in your change ( https://gerrit.wikimedia.org/r/#/c/11137/ ) [13:19:56] made the change to release notes. I then did as the git workflow article said. I did git pull origin master then git rebase master... [13:20:14] everything went as it looked like it should. [13:20:42] however, I did git show and now all of the files updated from the git pull are showing up in my commit. [13:20:57] including their change id's, commit logs, etc. [13:21:23] i'm thinknig the best way to proceed is to start a new branch and remake my changes [13:21:25] or do a git fetch [13:21:28] mhm [13:21:30] and/or [13:21:40] my question for you is should I not have done a git rebase? [13:21:50] everything seemed fine when I did git pull origin master [13:22:01] I assume the rebase is what broke everything [13:22:24] might be [13:22:27] try out: git log --decorate --oneline --graph HEAD master [13:22:41] that will show you how your current repo compare to master [13:22:53] (assuming master is the same as the one in gerrit) [13:23:29] ahh [13:23:30] git pull [13:23:35] that probably merged master on your change [13:24:06] oh... [13:24:06] if you know the sha1 of your change containing the release note entry, you can try out something like: [13:24:20] git remote update; git checkout master2 origin/master [13:24:35] then: git cherry-pick [13:24:58] git log --graph --decorate --oneline will show you your commit on top of origin/master and with a new sha1 [13:25:00] then submit that [13:25:09] that is similar to doing a git rebase [13:25:14] but manually :-] (somehow ) [13:26:31] wow [13:26:37] git is truly amaznig [13:26:41] but man is it difficult to learn [13:26:52] yeah lot of man pages are REALLY confusing [13:26:56] I thought I was doing well by learning git show, branch, checkout, pull, clone, blah [13:28:31] if you have 12$ to spend [13:28:41] I HIGHLY recommend buying https://peepcode.com/products/git-internals-pdf [13:29:12] thanks for the suggestion. [13:29:17] or well hmm [13:29:18] http://git-scm.com/book [13:29:27] would recommend that free book first ;-D [13:29:32] heh [13:29:33] thanks [13:29:42] specially the branching chapter http://git-scm.com/book/en/Git-Branching [13:29:45] <^demon> pro git is a great book. [13:29:46] i'll do my reading [13:29:48] read that twice [13:29:57] :) [13:29:58] I'll do that. [13:30:00] then go meet friends, enjoy some fresh air [13:30:05] and come back hacking git :-] [13:30:14] so hmm [13:30:21] essentially, yeah git is awesome [13:30:58] I am pretty sure someone will come up with a GUI that would let one drag'n drop commits and branch. That would make merging/rebasing trivial to the newbies [13:31:02] meanwhile, please do ask ;) [13:31:12] good good. thanks. [13:31:16] i'm happy to learn the comand line way [13:31:24] in fact, even if they had a gui i'd learn the command line way [13:31:34] i much prefer that to a gui pretty much any time. [13:32:00] it may be more complicated to learn at first, but once you get it figured out you can be so efficient. [13:33:07] exactly [13:33:13] for a long term I preferred GUI [13:33:17] now I largely prefer CLI [13:33:27] specially when having bash completions :-D [13:33:32] no joke! [13:33:48] my left pinky is extra strong from the tab key. [13:33:52] haha [13:33:57] !!! [13:33:58] Stop using so many exclamation marks ! [13:35:01] haha [13:35:06] what software does wm-bot use? [13:40:10] no idea [13:40:15] petan: is wm-bot your bot? [13:40:22] kind of [13:40:29] petan: nullspoon is wondering which language its using [13:40:29] it's supposed to be a community bot :) [13:40:37] @help [13:40:37] Type @commands for list of commands. This bot is running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.8.2.4 source code licensed under GPL and located at https://github.com/benapetr/wikimedia-bot [13:40:41] hashar: there is source code [13:40:43] it's c# [13:40:58] anyone can participate as dev [13:41:01] * hashar instantly close his browser window [13:41:05] :D [13:41:23] why u all hate c# it's still much better than java :P [13:41:32] not that there wouldn't be better languages [13:42:52] heh. I used to do C# dev [13:42:58] for about a year and a half [13:43:11] C#is actually pretty cool, especially when you're coding with Visual Studio. [13:43:25] I used to be a Windows fanboy until I discovered linux. [13:43:27] :D [13:44:53] VS is still one of the best IDEs out there [13:45:28] definitely [13:45:35] if not, the best [13:45:43] Though, despite it's lacking functionality, I'm still a super huge fan of vim now [13:45:58] it doesn't really compare to VS though [13:47:41] indeed [13:48:41] I liked Borland Delphi IDE [13:48:48] back like hmm [13:48:50] long ago [13:49:07] I even used Eclipse for a while [13:49:15] nowadays, I just use vim [13:49:21] need to install a few plugins though [13:50:42] Man - when I discovered syntax highlighting in vim I was so excited [13:50:55] it's really impressive for a command line application [13:50:56] do you know about code folding ? :-D [13:51:01] heck yes!!! [13:51:04] haha [13:51:04] ;D [13:51:35] oh hey, on a serious note, hashar: do I add my new feature to the top or the bottom of the list? [13:51:37] the thing I am really missing is to get function parameters described in a tooltip when my cursor is between parentheses [13:51:51] nullspoon: bottom usually [13:51:59] okay. Thanks. [13:52:39] AHAHHH [13:52:48] split() is being deprecated in PHP :( [13:53:18] will explode string instead :( [13:54:33] lucky me. I started using explode first. :) [13:55:13] should I write in my log that I wrote this patch? [13:57:28] hm? [13:58:17] nullspoon: nop [13:58:25] nullspoon: git log will tell [13:58:30] hokay [13:58:33] nullspoon: you can add yourself to AUTHORS / CREDITS [13:58:41] can't remember name of file [13:58:58] yeah CREDITS [13:59:22] okay [13:59:49] cafee / air [13:59:52] will be bock [13:59:54] I just add my name to credits? [14:00:18] sounds good [14:02:37] http://php.net/manual/en/function.readline-completion-function.php [14:02:38] ahaha [14:02:45] going to be fun [14:04:10] lol [14:04:10] so yes on adding my name to credits? [14:04:22] I don't wanna overstep my bounds so I wanna make sure. [14:04:33] This is my first open source project to contribute to. [14:06:25] You can add yourself to patch contributors [14:06:32] hokay [14:06:34] Added [14:06:35] Adding it to developers on your first patch is maybe a little much ;P) [14:06:46] i agree completely [14:06:52] that's a lot of pressure for a newb like myself [14:06:53] ;) [14:09:46] woo [14:09:51] patch submitted [14:09:54] well we love newbies [14:09:56] if anyone wants to review it [14:09:57] ;) [14:09:58] the thing I love about newbies [14:10:17] is when they become a regular contributor [14:10:32] and then write a crazy extension that get deployed on live site :-D [14:10:48] I dunno... [14:10:50] lol [14:10:50] then have to handle bug report written by ganglier in Hebrew [14:11:07] haha [14:11:20] I started learning Hebrew a ways back. [14:11:37] never got much good at it. Didn't have enough time to devote to it between Hebrew, French, and Spanish. [14:11:49] Not to mention that Hebrew is incredibly difficult. [14:12:01] hashar: I want my extensions be deployed. now. [14:12:22] meh [14:14:18] nullspoon: if you wanted sources of bot, just type @help [14:14:27] feel free to submit any patch [14:14:40] but I warn you, that bot is not so simple as it looks :D [14:14:45] haha [14:14:52] i started reading up on irc bots once [14:14:56] especially the AI ones [14:15:01] what is it - alice? [14:15:05] geeze. That's beyond me. [14:16:35] alice is what [14:16:48] wm-bot: are you AI? :P [14:16:52] I don't think so [14:16:59] @configure respond-message=true [14:16:59] Value true was stored into respond-message to config [14:17:08] wm-bot: talk! [14:17:08] Hi petan, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [14:17:23] haha [14:17:25] that's great [14:17:33] i'll have to see if I can find it [14:17:49] there is some open source ai chatbot project that was going on [14:17:54] aha [14:18:00] it's supposed to be pretty ground breaking as far as ai goes or something [14:18:02] maybe we could replace some people with that :) [14:18:11] haha [14:18:11] like you go to vacation, you start the bot with ur nick [14:18:16] no one notice that [14:18:18] :D [14:18:20] sneaky [14:18:44] what was the name of that aol chat bot [14:18:49] smartypants was it? [14:18:49] lol [14:20:19] smarterchild? [14:20:28] that's the one [14:20:49] oh aol - how we don't miss you. [14:20:50] <^demon> lol aim. [14:21:14] a couple of my friends and I occasionally reminiss about web services long gone [14:21:18] for instance, lycos [14:21:28] they used to be THE search engine. [14:21:36] you weren't somebody unless you had an email @lycos.com [14:21:38] lol [14:23:52] well that's weird. patch 2 built last time, but patch 3 didn't yet I made no changes to in patch 3 other than release notes and credits [14:24:15] nullspoon: https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/2420/console [14:24:24] you have a conflict in the RELEASE-NOTES file :( [14:24:28] so you have to rebase your change [14:24:38] git-review -d 11137 [14:24:44] git remote update [14:24:48] git rebase gerrit/master [14:24:52] fix conflict :-] [14:24:53] git add [14:24:55] git commit --amend [14:24:58] git-review -f [14:24:59] ;) [14:25:03] wow [14:25:11] definitely need to learn more about git [14:25:14] Jenkins try to apply your change the very latest version of master [14:25:29] according to gerrit, I have a trailing whitespace at the end of one of my preg_matches in an if statement [14:25:34] git-review is a python script to help you interact with gerrit [14:25:48] yeah remove the trailing space too while you are at it [14:26:20] yep [14:26:47] what's git-review -d do? [14:26:51] I don't have git review [14:26:56] had do alias push-for-review [14:28:08] <^demon> nullspoon: -d lets you download the latest patch for a given change. [14:28:18] <^demon> And merge it to a fresh branch in your local copy [14:28:54] <^demon> So if you're in the puppet repo, and did `git review -d 12387`, it would download patch set 1 for https://gerrit.wikimedia.org/r/#/c/12387/ [14:29:29] ah, okay [14:34:14] so, question about merging... [14:35:05] nope. nevermind. I think I found an article to help me out [14:41:01] So I'm curious, what does everyone do for jobs here? [14:41:34] I'm curious as to what jobs let their people be on irc all day. [14:42:42] It's in the job description for some of us ;) [14:42:49] That's what I was wondering [14:42:57] nullspoon: http://wikimediafoundation.org/wiki/Job_openings [14:43:44] Thanks for reviewing ^demon. That was my bad. I did a commit instead of a commit --amend. [14:43:46] :( [14:44:00] <^demon> It's ok, no harm done :) [14:44:02] <^demon> And easily fixed. [14:44:51] i'll take care of it. Thanks! :) [14:46:13] mutante: oh to be that cool [14:46:16] lol [14:46:43] nullspoon: just answering your question which jobs let you be on IRC in an effective way :) [14:46:59] haha [14:47:06] that's still super cool. [14:47:35] We'd get little actually done without IRC [14:48:16] IRC is pretty amazing. [14:48:54] if I ever get the chance to give a company some input for an internal chat service, I typically suggest IRC or Jabber [14:49:12]