[03:40:05] hey RoanKattouw [03:43:49] Hey did you get my message? [03:44:16] Whenever you patch that, please send it back to security@wm.o and don't submit it into Gerrit [03:44:33] So we can keep it private and apply it to the live site before it goes into Gerrit publicly [03:44:56] okay, on it [03:45:09] Thanks [03:58:14] RoanKattouw: sent [03:59:24] Thanks [04:00:11] I think you can use mw.Title stuff for that [04:00:52] Wait sorry [04:00:54] It's mw.util.wikiGetlink() [04:01:08] That takes care of the article path logic [04:01:21] RoanKattouw: yeah, i figured that that couldn't possibly be the best way [04:01:26] RoanKattouw: but wanted to plug the hole [04:01:35] Riht [04:01:59] Could you try it with mw.util.wikiGetLink( mw.config.get( 'wgMainPageTitle' ) ); instead? [04:02:27] RoanKattouw: sure, sec. [04:07:50] RoanKattouw: sent [04:21:52] Sweet thanks [04:21:57] Let me deploy that real quick [17:11:59] New patchset: Hashar; "MediaWiki-Universal-Linter now use verbose ant" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12419 [17:12:18] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12419 [17:12:20] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12419 [18:09:21] Deployment time! [18:09:34] preilly: hey, how's your day going? [18:09:49] sumanah: it's fine [18:11:02] preilly: so what's on your 20% plate for today? [18:11:13] I have some suggestions [18:11:34] sumanah: I'm already working on stuff [18:12:31] When I try to commit something to gerrit, it says "You have more than one commit that you are about to submit." It lists two commits, but one has already been submitted to Gerrit: https://gerrit.wikimedia.org/r/#/c/12399/ [18:12:40] Do I need to git push this change before I can git review the next commit? [18:36:29] alolita: ping! would you be willing to trade interview slots with me today? [19:09:22] New patchset: Hashar; "enhance ant php-lint doc and output message" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12459 [19:09:22] New patchset: Hashar; "(bug 37788) php-lint does not detects errors" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12460 [19:09:41] New review: Hashar; "(no comment)" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12459 [19:09:43] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12459 [19:17:09] New review: Hashar; "Validated on production:" [integration/jenkins] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12460 [19:17:12] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/12460 [19:31:02] why can only sysops use visualeditor? [19:31:05] (on mw.org) [19:31:19] we'll get more feedback if not [19:31:56] That's not the case [19:32:03] Only sysops can use source editing in that namespace [19:32:10] why? [19:32:12] Non-sysops can use the visual editor only, not the regular editor [19:32:43] Because you can break the editor with certain kinds of syntax [19:32:58] oh [19:33:05] I guess no parser functions, etc. [19:39:28] Things like nested lists, templates, images [19:39:32] We can almost handle them but not quite [19:39:37] ugh [19:39:42] page protection doesn't seem to work yet [19:42:14] ? [19:43:19] Even if I apply protection to a page [19:43:27] someone still can edit it using visual editor [19:44:00] See VisualEditor:ProtectionTest [19:44:03] which I've since deleted [19:44:34] Ah, right, yes [19:44:48] But that's an artefact of the weird namespace semi-lockdown thing we've done [19:47:18] I think the ability to use the visual editor should require a "useve" permission [19:47:30] which we can then restrict using page protection as normal [19:48:15] blocks are still effective [19:48:26] but the editor chokes on it instead of providing a clean error [19:49:00] Right, that sounds like a good idea [19:49:14] Although, why would you want to protect pages in the VisualEditor: namespace? [19:52:52] RoanKattuow: vandals/spammers will like it [19:53:01] especially the FAQ page [19:53:11] that /shouldn't/ be edited [19:56:20] The FAQ page isn't in the VisualEditor namespace [19:56:45] For vandals/spammers it's enough to recognize blocked users [19:57:00] how dumb of me [19:57:21] it may be worth throwing a clean error instead of a browser error, though [19:57:33] (i.e. MediaWiki:Blockedtext) [19:59:37] Yeah [19:59:44] That's a valid bug [20:00:26] to Bugzilla? [20:01:26] Yes please :) [20:04:40] for the record http://www.1proxy.de/index.php?q=aHR0cDovL3d3dy5tZWRpYXdpa2kub3JnL3dpa2kvVmlzdWFsRWRpdG9yOlByb3RlY3Rpb25UZXN0 [20:08:50] filed [20:09:03] Thanks [20:10:01] np [20:50:01] Jasper_Deng: This appears to be an issue with proxy.de instea [20:50:12] It's trying to reach /w/api.php and www1.proxy.de/w/api.php doesn't exist [20:50:23] resolved in valid? [20:50:25] Generally, proxy.de throws tons of 404 errors because of this exact problem [20:50:35] I'll try with my own account [20:50:40] (blocking my alternate) [20:51:52] even worse however [20:51:55] blocking had no effect [20:52:08] Resolving as INVALID for now, feel free to reopen if something is broken if you don't use the proxy [20:52:14] Did it let you save? [20:52:17] yes [20:52:23] Aha [20:52:26] one problem replaced by another [20:52:26] That's a problem [20:52:36] Fixing [20:52:45] you can close my existing bug [20:54:30] Yeah I did that [20:54:40] I'll just quickly put in two lines of code that prevent saving by blocked users [20:54:52] But it should be handled better eventually [20:54:57] temp. fix [20:55:02] is fine for now [21:07:05] RoanKattuow: unfortunately your fix brought back my bug [21:07:07] with a similar browser error message [21:08:28] Yes, upon save hopefully though [21:08:37] yes [21:08:45] browser popup erro message now [21:10:10] Yeah [21:10:21] That's an expected consequence of my temp hack [21:10:36] eventually though it should display Blockedtext, right? [21:10:38] Yes [21:10:44] (brb, moving back to my desk from the conference room) [21:58:28] preilly: api.php?action=query&prop=revisions&titles=Foobar&rvlimit=25 gets you history w/ user metadata etc [21:59:04] RoanKattouw: okay sweet [22:25:01] Where does the edit source tab come from? [22:25:11] VisualEditor adds it [22:26:25] RoanKattouw: how do you plan to handle the use of "edit" tab on non-current revisions? Like the current editing does it? [22:26:33] We will but don't yet [22:26:39] That's a TODO item [22:28:20] * vvv also whines about VE simply hanging on templates instead of at least displaying a placeholder [22:29:39] They should just be uneditable [22:29:51] Although handling of is currently broken so you're probably hitting that; I've fixed it in master [22:30:05] Once Parsoid flags templates better we'll be able to let you edit pages with templates on them [22:30:14] when will you have section editing? [22:30:30] Right now they'll become uneditable (so-called alien nodes), but when you save, the template is expanded [22:30:43] Jasper_Deng: We have section editing, in the sense that if you click the section edit link the editor opens and jumps to that section [22:31:18] it won't load if I click a section edit link [22:31:43] Hah [22:31:55] That happened for James too, but it worked for me [22:31:58] Which page (URL)? [22:32:20] Also if you have a Gadget or user scripts that manipulates the section edit links in certain ways, that might break it [22:33:26] gimme a sec [22:33:32] http://www.mediawiki.org/wiki/VisualEditor:Test [22:33:48] RoanKattouw: you guys want to to put in a bug report for visual editor? [22:33:50] one thing to note is that it does not show ?section=3 or something [22:33:56] err [22:33:59] want me [22:34:05] heh [22:34:15] or are you getting bombarded already? [22:34:16] RoanKattouw: why did you decide to wrap double braces into nowiki instead of just HTML-entitying them? [22:34:17] Ryan_Lane: If you found a bug then yes please [22:34:51] vvv: Gabriel did .... something there. I think he was considering either nowiki or entities, but I didn't talk to him and he just hacked this together recently I think [22:35:02] https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions&component=VisualEditor [22:35:06] ( Ryan_Lane ) [22:37:26] I hope that bug makes sense [22:39:24] crap. in firefox it just sits there loading :( [22:39:49] same for me on FF [22:39:50] hm [22:39:54] it is now in chrome too [22:40:08] it's broken now, it seems [22:44:09] RoanKattuow: For now, semi/full-protection must be implemented using an abuse filter [22:44:12] I think [22:44:21] don't even know if an abuse filter would work [22:50:01] Alright apologies for the broken editor everyone [22:50:35] I just pushed out a fix, should propagate in the next 5-10 minutes [22:51:15] No chocolate for you! [22:53:02] Amgine: https://gerrit.wikimedia.org/r/12345 is my penance [22:53:10] (It says Trevor Parscal on there but I wrote that) [22:53:24] (Also notice the change number in the URL :) ) [22:55:48] Okay, we'll allow you to have the milk chocoloate. [22:56:34] * RoanKattouw demands dark chocolate instead [22:57:53] I'll bring you Denman Island chocolate for Wikimania. [22:57:53] editor is fixed [22:58:00] from its previous time-out problem [22:58:29] still broken for me... [22:58:51] and yes, I force refreshed [22:59:17] it's timing out still on Chrome [22:59:22] not on FF [22:59:23] and firefox [22:59:34] times out for me in FF [22:59:41] not my Firefox [22:59:57] It'll update at different times for different people, give it another 5 mins [23:00:05] ah. right [23:00:31] This'll be due to browser cache [23:00:44] A hard refresh should fix it, if Jasper_Deng is already being served the fixed code [23:01:33] I did a hard refresh [23:02:09] RoanKattouw: I want it to work noooooowwwwww [23:02:18] so I can bombard you guys with bug reports [23:02:59] It should totally work already [23:03:10] I pushed it at :49, that's like 15 mins ago [23:03:20] Are you still getting a JS error complaining about 'replace'? [23:07:33] Raawr robla showed me it was mw.util not being loaded, fixing that now [23:12:52] darn it, now I get the endless "loading" hang again [23:14:22] Sorry, I did actually break something [23:14:29] Now I've pushed something that should *really* fix it :S [23:14:50] hahaha [23:15:13] it's still broken for me [23:15:31] is it fixed now? [23:15:33] how about now? [23:15:34] now? [23:15:55] I hard-refreshed and it's working for me [23:16:05] works for me even w/o hard referesh [23:16:09] isn't for me [23:16:20] does in chrome [23:16:31] there we go [23:16:33] firefox too