[00:23:27] There seems to be something wrong with gerrit, it's giving me "Application error: server unavailble" [00:26:26] seems to be back to normal [00:31:53] kaldari: do you know if MediaWiki has any support for detecting browser language? [00:32:25] I don't believe it does [00:33:03] the best place to ask though would be #wikimedia-i18n [00:33:05] lame, i was led to believe it had a tool for everything [00:34:37] kaldari: we had another request for it, for FundraiserRedirector. do you think its worth the effort? i am tempted to say yes [00:35:27] sure, it should be easier enough to write if it doesn't exist somewhere already [00:35:55] yeah, it looks like PHP has some baked in support, but it requires generating a list of languages we support [00:36:02] that would be the hardest part [00:36:38] we already have functions for that [00:37:19] Language::getLanguageNames [00:37:19] yeah, but what are the odds that we used teh same standards ;-) [00:38:18] that function takes a parameter, BTW, so you can clarify what you mean by 'support' [00:38:35] MediaWiki actually has several levels of language support [00:38:48] of course [00:39:38] and you have to watch out for things like pt-pt, which we don't technically support, but it's the same thing as pt [00:40:57] okay, thanks, i'll make a card for this one [07:45:23] re [08:37:27] Reedy: around yet ? ;-) [08:38:05] Reedy: someone asked us to deploy the RSS extension on ua.wikimedia.org https://bugzilla.wikimedia.org/show_bug.cgi?id=27706 [08:38:46] though it is not enabled in InitialiseSettings.php ;-) [08:41:21] Was fixed by Jeremy Baron https://gerrit.wikimedia.org/r/10673 and deployed. [08:44:53] hashar: I did 23:31 logmsgbot_: reedy synchronized wmf-config/InitialiseSettings.php 'Bug 27706 - enable RSS extension on uawikimedia' last night.. [08:45:20] 'wmgUseRSSExtension' => array( [08:45:20] 'default' => false, [08:45:20] 'foundationwiki' => true, [08:45:20] 'mediawikiwiki' => true, [08:45:20] 'uawikimedia' => true, [08:45:22] ), [08:45:41] Yeah, it is [08:47:18] hashar: it is already :p [08:47:42] 23:31 logmsgbot_: reedy synchronized wmf-config/InitialiseSettings.php 'Bug 27706 - enable RSS extension on uawikimedia' [08:54:45] Reedy: I have closed the bug report :-D [08:54:46] thanks [08:55:30] heh [09:02:09] my Gerrit dashboard is too crowed [09:02:14] I am going to spam people wîth direct emails :-] [14:01:38] sumanah, my 20% report: I'm working on making the installer extendable by third-party packagers today. Since we have a deployment window later today, I'll work the remaining hours some other day [14:01:51] wow cool re the extensibility improvements [14:01:52] thanks MaxSem [15:11:47] chrismcmahon - you know about the GMail option to forward an entire conversational thread? [15:11:56] chrismcmahon: More Options dropdown has it [15:34:14] sumanah: I was looking for that :) is what I sent readable, or should I resend? [15:34:28] chrismcmahon: if you don't mind resending, that would be nice [15:34:34] omw [15:54:38] hi SPQRobin [15:55:11] hey sumanah [15:55:22] SPQRobin: so, how is your week going? [15:55:30] I think I haven't seen any blog posts from you in the past couple of weeks [15:56:25] sumanah: I know, I have continued coding but indeed, I was going to make a blog post but I haven't yet [15:56:37] ok! any questions? for Nikerabbit or anyone else? [15:58:50] not really.. though, I have a list of all language names, which is part of my project, but I'm not sure whether I should put it in an extension or in core [16:01:20] SPQRobin: that's a reasonable question [16:01:30] it's more something for an extension, but it could be useful to replace the existing list in Babel (for less duplication), in which case it could be better in core [16:01:48] SPQRobin: maybe the i18n mailing list could help you here? please do feel free to bring it up [16:02:00] My preference: core. [16:05:05] If you think core is fine, then I'll probably add it to core.. Because I'd assume people don't want core to be too "big". Anyway I'll maybe mail the i18n list. [16:07:46] SPQRobin: I advise you to mail that list to at least tell them you're gonna do that, yeah [16:12:09] SPQRobin: does cldr not provide this? [16:14:41] Reedy: CLDR is only limited, I'm adding a full list of all ISO 639 languages. It's already in Babel, but I'm making a script to update the list and will add it to core probably [16:14:56] Ah, cool :) [16:15:45] :) [16:16:50] I did think it weird that you might've been duplicating something we already have ;) [16:18:28] Reedy: duplication is something I don't like at all :) [16:33:44] what happens if I approve some change to operations/mediawiki-config - it will have to be deployed manually? does it make sense to approve it when there will be someone around to actually deploy it? [16:47:43] MaxSem, git pull doesn't magically run without someone making it do so. [16:48:52] Well, there's puppet. But my question was mostly regarding the approval procedure and when this stuff (random config changes) gets deployed [16:58:05] Hello mlitn RoanKattouw rsterbin_away chrismcmahon : Look forward to a successful deployment of AFT5 today. I will be tied up in a product group meeting for the first hour (10am PT), but will check this channel for any special requests. I will be available to test after 11am PT, up until deployment ends at 1pm PT. Otherwise, let's follow Matthias's email checklist for today's deployment. Thanks! [17:13:40] Hello mlitn RoanKattouw rsterbin chrismcmahon : Look forward to a successful deployment of AFT5 today. I am tied up in a product group meeting for the first hour (10am PT), but will check this channel for any special requests. I will be available to test after 11am PT, up until deployment ends at 1pm PT. Otherwise, let's follow Matthias's email checklist for today's deployment. Thanks! [17:14:03] I'm around [17:14:53] * sumanah looks for Roan, Trevor, Rob, Brion [17:16:39] i'm around as well :p [17:17:29] mlitn: what's your 20% day? https://www.mediawiki.org/wiki/Wikimedia_engineering_20%25_policy [17:18:58] mlitn: Good morning, sorry for being late [17:19:05] sumanah: oh - I was under the impression that didn't apply to contractors, am I mistaken? [17:19:10] RoanKattouw: no problem :) [17:19:30] mlitn: it depends on the kind of contractor; remind me, who do you report to? I can figure it out with them [17:19:35] terry [17:35:01] mlitn, afaik it applies to all full-time contractors [17:37:02] MaxSem: ok thanks, didn't know that; sumanah can you confirm just to make sure? [17:37:13] mlitn: writing the email to terry [17:43:00] AaronSchulz: hey aaron :) [17:43:15] AaronSchulz: I have added you as a reviewer to some change I made in operations/mediawiki-config [17:55:33] nm [17:55:38] looks like you are reviewing them already :-] [17:57:42] fabriceflorin: mlitn tells me we are now on testwiki [17:58:02] Thanks, RoanKattouw -- I will start testing now! [17:59:37] though I just spotted an error preventing the filters from being saved - don't panic if it doesn't work, will fix that right away ;) [18:02:05] So far, I'm getting what I expected for the new feedback form on this page: http://test.wikipedia.org/wiki/Golden-crowned_Sparrow?aftv5_form=6 Moving on to So far, I'm also getting what I expected for the new feedback form on this page: http://test.wikipedia.org/wiki/Golden-crowned_Sparrow?aftv5_form=1 [18:03:46] However, the feedback page doesn't seem to include some of Reha's latest formatting tweaks, such as the different 'Sort by' drop down menu, or removing the 'More filters' drop down for anonymous readers: http://test.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow [18:04:08] RoanKattouw: if you know off the top of your head, multiple calls to gerRevisionText should get new db slaves and open new connections each time, right? [18:04:19] it looked that way to me but there are a lot of layers in there [18:06:27] apergos: Are you talking about multiple calls to wfGetDB( DB_SLAVE )? Cause that function caches its connectoins [18:07:15] Hmm, wait [18:07:36] In practice, getRevisionText will always hit ExternalStore::fetchFromURL() on WMF [18:08:23] not seeing hide or abuse flags, only feature and mark-resolved options? [18:08:37] Which will instantiate a new ExternalStoreDB every time [18:08:51] sorry, abuse is there, forgot what the fourth one was, looking [18:10:07] I'm talking about getRevisionText, right. [18:10:37] and it looks like the array is indeed cached but the db retrieved from the array is not always the same [18:11:21] Hah OK that's strange [18:11:24] so if the one and only slave is remoed and a new one added by db.php going around, we will be screwed, but otherwise a retry would be likely to succeed [18:11:44] Yeah if db.php changes I guess you're generally screwed [18:11:49] well lbfactory::singleton caches the list of dbs per cluster or whatever right? [18:11:53] MaxSem|1612: thanks for you reviews on mediawiki-config ! [18:12:10] yeah, that's what I thought, and it can certainly happen over a dump job [18:12:13] Yeah it'll cache all the data from db.php [18:12:18] Yes, that's bad [18:12:30] It'll also cache the weights, and which DB it thinks is the master [18:12:31] mlitn: Any ideas why some of rsterbin's feedback page tweaks are not showing up on testing? (see my note above): http://test.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow&ref=cta [18:12:37] but as long as we can "likely" get a different db slave when we retry then it's not awesome but it will do [18:12:51] I wonder how many have only one slave :-P [18:13:04] fabriceflorin: I'm assuming cache, but I'm looking into it with Roan [18:13:05] Well if it's mostly ES you're worried about, I don't think we're gonna have complete turnover of all ES slaves over a dump run [18:13:08] In practice at least [18:13:15] yes, es would be the thing that gets us [18:13:31] and there are always multiple es slaves [18:14:09] k, I need to just add some retry code in activeabstracts then, since there is none :-/ [18:14:11] thanks! [18:14:49] mlitn: i don't see any of my tweaks. [18:26:56] mlitn, RoanKattouw, rsterbin: I also note that the Survey CTA3 is still present for Option 6 feedback form -- it should have been replaced by CTA5, the call to visit the feedback page. So this leads me to believe that the new code was not properly uploaded to testing. http://test.wikipedia.org/wiki/Golden-crowned_Sparrow?aftv5_form=6 [18:27:41] yes - code didn't come through; re-deploying :) [18:33:33] thanks, mlitn, keep us posted! [18:45:52] fabriceflorin RoanKattouw rsterbin chrismcmahon: code is (finally) up on test [18:46:06] thx [18:46:19] Thanks, guys! I'm on it. [18:47:06] mlitn: looks like the messages are cached -- can you clear them? [18:49:11] rsterbin: hang on, it's updating [18:49:22] thx [18:49:44] mlitn rsterbin : there appears to be an error in the central feedback page link at the bottom of the article feedback page: in logged-out mode, it says instead of 'See more feedback from other pages'. Note that this is only supposed to be shown to logged-in editors, and it should include the full label, not the code. [18:49:44] http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow?ref=talk [18:50:08] fabriceflorin: that's the message cache needing to be cleared [18:50:19] mlitn will tell us when it's done [18:50:53] and that's now [18:50:56] rsterbin: Cool, looks like mlitn cleared it, and it did the trick for me. [18:51:12] :) [18:56:32] mlitn, rsterbin, yoni_omniti, chrismcmahon, RoanKattouw: As far as I am concerned, the code seems ready to go to production. Did any of you encounter serious bugs that would prevent us from moving to production? [18:56:52] nothing that grabbed my eye, but not saying I didn't miss something [18:57:00] not yet, but i haven't tested everything [18:57:39] so far it looks good here [18:57:45] rsterbin: take your time :) [18:59:36] mlitn, rsterbin: I do see one problem, which is that the labels for hidden and oversighted posts are garbled: <articlefeedbackv5-hidden-marker> (should say 'HIDDEN') and <articlefeedbackv5-deleted-marker> (should say OVERSIGHTED). The icons show up fine, but the labels are wrong. [18:59:59] Alright, I have to head out for a team lunch [19:00:01] This is on the article feedback page, FYI: http://test.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow&ref=cta [19:00:15] they look fine to me. clear your cache? [19:00:17] mlitn: If you need me to approve stuff or help otherwise, hit me up on Google Chat [19:00:56] or send e-mail [19:01:06] okay [19:04:50] fabriceflorin: do you still got the issue after clearing cache? [19:06:16] rsterbin: Thanks! I recleared my cache and that solved the issue. Must have been a leftover from an hour ago, before we cleared the messages. Will mlitn or RoanKattouw have to clear messages on production as well to make sure this same issue doesn't happen there too? [19:07:52] rsterbin mlitn chrismcmahon : Any show-stoppers before we move to production? [19:07:57] fabriceflorin: that happens automatically on production [19:08:03] no showstoppers here [19:08:32] nope, looks good for me, too [19:09:35] mlitn: Cool. I see RoanKattouw_away is er, … away (probably went out to grab lunch). Matthias, do you feel comfortable deploying to production without any immediate supervision? Roan should be back at his desk shortly, I expect. [19:09:49] i'll go ahead [19:10:28] mlitn: Sounds good to me, if you think that works for RoanKattouw_away too. [19:11:23] Since production deployments take a while, I will go grab something to eat at my desk. Will be back in 10-15 mins. [19:26:20] mlitn: I'm back at my desk, and ready to test on production when you are fully deployed. Hope all is going well on your end ;o) [19:26:31] ok [19:26:34] all is going well so far [19:26:53] it's been deployed to most servers, so you might be able to see it on production already [19:26:59] or you might not :) [19:28:46] mlitn rsterbin chrismcmahon RoanKattouw_away : Glad to hear the new AFT5 code is now on production. Will test it there right away. [19:30:27] it's on all production servers; go ahead and test [19:31:42] i18n doesn't seem to be updated yet - hang on [19:32:35] mlitn: It appears that the messages were not cleared on production. I am still getting the same weird code messages () on the feedback page: http://en.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow&ref=cta# [19:32:50] indeed [19:33:29] mailing roan atm; although might get automatically fixed once the script finished (still running) [19:35:07] mlitn: Cool. This is not a show-stopper, but should be cleared today, if possible. Still testing the other pages. [19:42:16] rsterbin mlitn: A few more things I notice on the feedback page: 1) the counters seem to be off, I'm told there are 47 'All comments' on the Golden sparrow page, but I only see about a dozen 2) there is no 'See more post' bar at the bottom to see more. Should I file a bug for that? [19:44:34] mlitn rsterbin : Another thing I notice for the feedback form is that if you click on 'Learn more' for Option 6, it opens a new tab, but that tab remains blank (in Chrome incognito mode): http://en.wikipedia.org/wiki/Golden-crowned_Sparrow [19:45:03] mlitn: you should be able to run the filter counts script to fix them [19:49:18] I also think the code has not been fully deployed to all servers, because I am still seeing old versions on some of my browsers, which do not include Reha's latest formatting tweaks. [19:54:55] fabriceflorin: it's on all servers - browser cache maybe? [19:59:05] rsterbin: I'm waiting for Roan to tell me how to do that ;) [20:00:18] mlitn: even if I clear my caches, I don't see rsterbin's new tweaks. This is happening on Safari, Firefox and Chrome. And I'm still seeing the weird artifact at the bottom of the feedback page. Reha, or chrismcmahon , what are you seeing on your end? [20:00:59] fabriceflorin: i see the html changes, but not the message changes [20:01:18] fabriceflorin: indeed - waiting for Roan atm [20:02:14] fabriceflorin: I also see some localization missing? [20:03:06] RoanKattouw_away: Hey Roan, could you please give Matthias a hand on clearing the messages and running the filter counts script? rsterbin: Do you know the name of the filter counts script? [20:04:18] chrismcmahon: Thanks. We are all seeing that message as well. But I am glad that rsterbin is seeing the correct HTML on her end. Our servers here must be behind hers somehow ... [20:15:50] mlitn: Back now, do you still need hlep? [20:16:01] hi - yes [20:16:18] What's the SQL query you need to run (just read your e-mail) [20:19:12] RoanKattouw: ArticleFeedbackv5/sql/filter_count.sql [20:19:22] mlitn: there's a script for that now [20:19:30] in maintenance [20:22:34] OK [20:22:48] rebuildLocalisationCache.php was broken in wmf4 due to a filesystem permissions issue [20:22:52] Fixed the perms, now rerunning the script [20:26:10] RoanKattouw: Thanks for helping us with these issues. [20:27:02] l10ncache rebuilt, now pushing it out [20:31:27] fabriceflorin: messages are cleared [20:31:52]

is gone [20:32:31] Sorry about that folks [20:32:43] That was unexpected breakage because of bad filesystem perms [20:33:31] mlitn RoanKattouw : Thanks! I can see that the labels are working now. Nicely done! Roan, is this message clearing something that Matthias could do himself in the future? or do we need you to do that? [20:33:57] fabriceflorin: It should have Just Worked, except the fs perms on the cache directory were set wrong [20:35:02] RoanKattouw mlitn rsterbin : Got it, thanks. In other news, I am still getting weird discrepancies for the filter counts. Did you guys run the filter count script yet? [20:35:20] discussing this atm :p [20:37:02] I'm e-mailing Reedy (who's not on IRC due to a power outage, I hear) to make sure he has this in his script that automates setting up new versions [20:38:34] RoanKattouw: Cool, thanks. It would be great if we could run that filter count script today, because the counters are completely off now -- like by hundreds, not just 1 or 2 counts. [20:38:45] fabriceflorin: I just told Mathias how to run it [20:39:31] RoanKattouw: Very cool. mlitn, I hope you took good notes, as this is likely to be needed again ;o) [20:39:46] I did ;) [20:39:49] and it has run [20:39:53] so it should be correct now [20:40:31] RoanKattouw: By god, it IS fixed! How do you guys pull it off so fast? [20:41:00] fabriceflorin: years of naturally selecting the smartest people :-] [20:42:23] hashar: hehe, natural selection at work. Of course! [20:42:45] * RoanKattouw just saw Idiocracy three nights ago [20:45:25] worth a few chuckles, nothing super [20:45:49] RoanKattouw mlitn rsterbin : I hate to rain on our parade, but the filter counts are still off. If you check the China page in monitor mode, then click on 'More filters', you will see that it says that 646 posts were hidden (out of 644 total). http://en.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/China [20:46:28] fabriceflorin: so it appears everything is ok now, or does anyone still got a problem? [20:46:52] AaronSchulz: Just referring to hashar's comment about natural selection selecting smart people [20:47:18] It is quite possible that this China filter count issue is a bug on our end, as I remember that rsterbin wanted to refactor the filter counts. So I will file this as a bug. [20:47:22] I still need to watch idiocracy [20:47:27] lot of people told me about it [20:47:29] please do [20:47:34] hashar: Have you seen Bridesmaids? [20:48:07] RoanKattouw: 2011 film, so no :-D [20:48:54] Watch that before you watch Idiocracy. The same actress has a major role in each movie, but due to the nature of the roles it's more fun to watch them in that order [20:49:00] (Phrased to avoid spoilers) [20:49:14] Also Bridesmaids is funnier IMO [20:49:17] mlitn: Yes, I think we are good to go now. Thanks for all your excellent work today! And many thanks to rsterbin, RoanKattouw, chrismcmahon and other team members for this successful deployment! [20:49:59] mlitn: Time for you to go get dinner, maybe watch Idiocracy afterwards … or just get some well-deserved rest! ;o) [20:50:17] lol [20:50:21] dinner indeed ;) [20:50:30] ow I'm sorry, I missed you mentionning the filter count bug [20:50:54] fabriceflorin: will look into that [20:50:57] is it ok if I investigate this tomorrow? doesn't appear to be a showstopper [20:51:01] or reha :p [20:51:17] mlitn: i [20:51:22] 'm already refactoring [20:51:27] rsterbin: refreshFilterCounts.php has run already [20:51:31] okay [20:51:33] nice :) [20:51:36] yeah, i think this is a flagging bug [20:51:41] mlitn: No worries, it's not a show-stopper -- we'll fix that as part of Reha's code-refactoring. Thanks again for all your great work and get some rest. Speak to you both tomorrow! [20:51:47] ttyl [20:52:07] RoanKattouw: will try to remember about that movie. Thanks for not spoiling it :-] [20:52:11] Bye for now. Over and out. [20:52:20] bon appetit fabrice