[03:32:43] mm, missed sumanah [11:11:32] Reedy: Tim-away: I recall you knowing something about getting 1.19 into ExtensionDistributor, but if it is already in master, why is it not happening on the site? [11:11:36] Is this just wmf-config? [15:23:12] No, it needs checking out etc [15:23:19] same reason git isn't there either [15:25:49] hi everyone [15:25:55] could I just...wave this infront of your eyes [15:25:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=26215 [15:30:17] I'm about to suppress multiple revisions in a deleted page [15:30:36] the only way to do this is each revision one by one (tedious and unresourceful) [15:30:53] or to restore suppressible material right under the noses of new page patrollers (unacceptable) [15:43:45] * WilliamH_UK twiddles his thumbs [15:43:49] thoughts welcome [15:54:43] WilliamH_UK, you'd probably have more luck in a weekday [15:54:49] heh [15:55:07] I'll bear that in mind [15:55:16] but still, I want to pay attention to this [15:55:43] I filed a bug for the first time in 6 years' editing, and that is being dealt with in an extremely timely fashion yet is much less pressing [15:57:29] simple bugs will probably be solved faster [15:57:55] this could be resolved very easily [15:58:13] on the Delete/Undelete revisions page, there are already checkboxes to select individual revisions [15:58:25] and a "restore" button [15:58:49] surely it must be pretty straight forward to add a button "Suppress", viewable only to those in the oversight group [15:58:59] which then takes all those revisions to the standard Delete/undelete revisions page [16:01:08] oh, I had wrongly understood the bug to be about undeleted revisions [16:01:15] yes, that should be possible [16:01:42] :D [16:01:53] can you add a comment with that you just told here? [16:02:09] surely [16:02:29] well, I already did [16:02:41] can repeat it if it helps [16:02:54] didn't stress how easily this could be resolved [16:05:06] given that I didn't realise it until you told it could be done with a new suppress button... :) [16:06:09] sure, i'll add a comment [16:06:47] done [16:07:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=26215 [16:07:24] thanks [16:08:24] ^_^ [19:24:28] hey [19:24:42] Platonides thanks for your assistance earlier [19:39:29] no problem [19:40:17] bug 20189 still has to be fixed [19:41:01] which is that [19:41:20] ah i see it [19:48:06] Krenair, how is it a duplicate? [19:49:59] You want checkboxes to revdel/suppress instead of links from Special:RevisionDelete/Special:Undelete [19:50:41] no, there already are checkboxes [19:51:21] it is possible to select revisions by checking them and clicking "Restore" from Special:Undelete [19:51:35] however, it is not possible to suppress them like that [19:52:05] and that's what we want [19:52:43] does that make sense? [19:53:21] For example, an administrator has deleted a page and multiple revisions need to be suppressed [19:53:42] the only way to do that is to suppress each revision manually, which is extremely tedious and not very resourceful [19:54:20] No, none of this makes sense, but I'll take your word for it. [19:54:28] or, by creating the page [19:54:36] checking each revision [19:54:56] and clicking the "Del/undel selected revisions" button [19:55:05] this will then take all of the revisions to Special:RevisionDelete [19:55:25] where there are options for oversighters to apply to all the selected diffs [19:56:10] what we need in Special:Undelete is a button which is viewable only by or responds only to those in the oversight group [19:56:28] which takes all the checked revisions through to Special:RevisionDelete [19:56:33] does that make sense now? [19:59:19] So you want a form on Special:Undelete for suppressors which sends them to the revdel form for the selected revisions [19:59:41] precisely :) [20:00:07] anything which takes the selected revisions from Special:Undelete to the revdel page, from which oversighters normally do there work [20:00:19] So now you and Thehelpfulone have to explain to me how this is not bug 20189 [20:00:55] Since that very much clears up that it is indeed a duplicate of that [20:01:43] no it doesn't, because checkboxes are already enabled on Special:Undelete [20:02:12] I can select multiple revisions to restore them, but I cannot select multiple revisoins to suppress them [20:02:13] Krenair: that bug is to put checkboxes on there [20:03:37] oh my [20:03:43] Both bugs are to put checkboxes for revdel on Special:Undelete [20:04:04] that's really quite silly that they are links not checkboxes [20:04:06] Shown to people who can suppress [20:04:15] hmm WilliamH_UK it might be part of that bug actually [20:04:23] as suppression is just another feature inside revdel [20:04:27] Of course it's part of that bug [20:04:34] That's what I've been saying for the past 10 minutes [20:05:00] Krenair: https://gerrit.wikimedia.org/r/#/c/7699/ [20:05:06] there's a bit that needs fixing on that last patch [20:05:08] can you fix it? [20:05:22] ah right...and of course revdel will show the extra options for oversighters [20:05:30] I forgot that it does that [20:05:33] :P [20:05:33] splendid! [20:05:37] Thehelpfulone, someone else already did. Aaron Schulz I think [20:05:45] WilliamH_UK, ... [20:05:50] I don't think so [20:05:51] Yeah, I missed that. It should be 4, so it lies on its own bit. 3 means 1 | 2, which is broken. [20:05:54] "Yeah, I missed that. It should be 4, so it lies on its own bit. 3 means 1 | 2, which is broken." * [20:06:00] that's a comment no? [20:06:04] Yes, that's a comment. [20:06:07] Which has been fixed. [20:06:24] well you last uploaded a patchset on may 30 [20:06:29] that was said on june 5 [20:06:44] patch 3 was merged on may 31 [20:07:03] so it needs a patch 4 Krenair [20:07:04] sorry, obviously in my mind, revdel and suppression are obviously two different things and I'm associating them as their concepts that way, not for the fact that they appear on the same page [20:07:20] Thehelpfulone, I don't think that's possible. It's already merged. [20:07:32] Krenair: you can still upload a new patch to that surely? [20:07:36] Don't think so [20:07:40] Anyway it was fixed [20:07:47] https://gerrit.wikimedia.org/r/#/c/10288/ and https://gerrit.wikimedia.org/r/#/c/10289/ [20:08:18] so this will be out in 1.20 wmf5? [20:08:39] Krenair out of interest, when will this be resolved? no rush, i've just never filed a bug or done anything like that before [20:08:44] This is already in 1.20wmf4 and deployed, Thehelpfulone [20:08:55] Krenair: then it's not working [20:09:10] Yes it is [20:09:16] It's working 100% as intended. I checked [20:10:05] I don't think we are on the same page then -- I still see (show/hide) instead of rev delete [20:10:12] rev delete checkboxes [20:10:28] If there's no form for revdel, then there are no checkboxes. Correct? [20:12:48] where's the form for revdel? [20:12:53] Precisely. [20:13:19] There's a bug for the missing revdel forms. https://bugzilla.wikimedia.org/show_bug.cgi?id=20189 [20:13:26] bah :P [20:13:32] I thought you said it's deployed and working! [20:13:35] It is [20:13:44] This change to fix a partial fix to that bug [20:13:53] if the forms are missing, then it's *not* working* [20:13:57] Yes it is [20:14:06] That change was never supposed to fix all the missing forms [20:14:13] It was supposed to correct my work to add one missing form [20:14:29] so which changes will fix the missing form? do you have a gerrit link? [20:14:49] https://gerrit.wikimedia.org/r/#/c/6904/ [20:15:10] It partially fixes the bug [20:15:47] that has already been merged, but not deployed correct? [20:15:47] The one you linked (https://gerrit.wikimedia.org/r/#/c/9530/) is a follow-up to that because it was showing checkboxes in places it shouldn't've [20:16:00] All these have been submitted, reviewed, merged and deployed. [20:17:25] right, and how many more forms are missing? [20:17:45] Special:Contributions, Special:DeletedContributions, Special:Undelete. That's 3 [20:18:28] have they been made yet? [20:18:32] 26215 is a duplicate of 20189 because it also wants a revdel form and checkboxes on Special:Undelete. [20:18:44] Maybe, but definitely not by me. [20:20:44] Krenair - we're not fussy. I'm sure, e.g. a simple button which would take all the checked revisions to the RevDel page would be entirely adequate [20:21:11] That's exactly what 20189 is for, though it covers a couple more pages as well. [20:21:23] ok [20:23:51] Krenair: would you be able to make the form for Special:Undelete? Are there many changes between the form for Special:Log? [20:24:11] I'm not sure if I've looked into it. I'll have a go. [20:25:31] thanks [20:33:19] Krenair, is there really going to be a whole revdel form on Special:Undelete? [20:33:30] sounds like you might be making more work for yourselves than is necessary with that one [20:34:43] Isn't that what you want? [20:35:31] Checkbox for each revision, and a button to take you to the revdel form for the selected revisions [20:37:03] there already are checkboxes [20:37:17] just the button to take us to the revdel form which obviously already exists :) [20:38:30] That's what the button would do [20:38:47] The checkboxes would just allow you to select multiple revisions [20:41:03] yep, those checkboxes already exist - it's just that button [20:41:12] only saying this for fear that you needlessly make more work for yourselves :) [20:42:07] yourselves? I'm just me [20:42:31] oh - I see what you mean. Make the existing checkboxes multi-purpose [20:42:54] yeah, I guess so [20:43:04] they are effectively multipurpose on the history page of an article [20:44:27] checking those on a history page and clicking the "Del/undel selected" revisions page takes you to the RevDel form [20:45:14] on Special:Undelete though Krenair you already have checkboxes for revisions [20:45:27] as well as Del/undel selected revisions [20:46:01] sorry you don't have checkboxes [20:46:15] oh I give up [20:46:52] there are checkboxes [20:47:03] that's how you can select revisions you wish to restore [20:47:36] I have no idea if this is going to work or not [20:49:55] :) [20:50:07] well, it does in the history page of a live article [20:50:14] maybe coders can look to that for inspiration [20:52:44] I'm not sure about making checkboxes multi-purpose. It may break everything horribly [20:53:56] well, as I say, the same functionality already exists on history pages [20:54:37] I know [20:54:40] Wait, no it doesn't [20:54:57] History pages use their checkboxes for revdel only [20:55:13] They have radio buttons for comparison between revisions [20:55:29] is it the "checkbox" itself then, that is the multipurpose part, as opposed to the nature of the button? [20:56:48] yes [20:57:08] I see [20:57:10] interesting [20:57:18] The checkboxes on Special:Undelete are currently used for restoration [20:57:30] But we also want to make them used for suppression [20:57:30] perhaps a revdel form on the undelete page is the most realistic solution then :) [20:57:37] yep [20:57:54] Well I have to put one in anyway. But if I can I'll try to use the existing checkboxes [20:58:00] would be cool if you could pull it off then, if you say it's more challenging [21:00:59] Krenair, you just need to take the checkboxes names into account on the action [21:01:21] and switch between the two actions depending on the presence of the input name [21:01:28] button [21:06:32] So, apparently MediaWiki completely ignores me if I try to create a form element [21:06:37] I'm not even kidding [21:06:57] $out->addHTML(" "); works [21:07:04] $out->addHTML("