[07:47:26] Ryan_Lane: I just followed the howto [16:59:28] hi brion_ will you be continuing to make improvements in UploadWizard or are you done with that project for now? [17:11:17] chrismcmahon, yes i'll continue poking at it between other things [17:12:51] brion: I have some changes I would like to see in UW for accessibility, usability, and ease of automation, I'll put those in Bugzilla as enhancements for you if that's OK [17:14:00] chrismcmahon: I hereby say: put them in [17:14:09] chrismcmahon: even if Brion doesn't have plans to do 'em! [17:14:41] * chrismcmahon is trying to be a nice team player here :) [17:15:00] chrismcmahon: the team is the entire FLOSS community, right? [17:15:08] if you don't put your ideas in BZ, you're hoarding [17:15:47] it is accepted and expected for us to put lots of enhancement requests into BZ when we think of them without the expectation that someone can immediately make plans to follow up on them [17:15:54] there will always be more to do than there are people to do it [17:16:01] that is not an insult or obligation [17:16:03] right? [17:18:08] chrismcmahon, please do! feel free to CC me on them [17:18:55] thanks brion sumanah will do [17:19:59] Oh boy, that means I'll get emails soon :) [17:20:13] \o/ [17:20:31] marktraceur_: brion - do you agree with my reasoning? I might be wrong [17:20:48] sumanah, I less-than-three getting emails, so I'm all for it [17:20:58] Plus, always good to have something to do [17:21:05] :) [17:21:18] (don't see raindrift around, hmm) [17:21:38] +1 file them bugs, otherwise they turn invisible [17:22:43] chrismcmahon: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/UploadWizard+-owner:L10n-bot+status:merged,n,z -- looks like several folks will be interested in your UW suggestions! [17:56:29] Hi everyone. We're starting office hours about the new Wikipedia mobile site and related work in just a few minutes. It's #wikimedia-office if you want to join. [18:16:36] hi kaldari and drecodeam [18:16:47] hi kaldari [18:16:51] hi sumanah [18:29:41] hey sumanah, do you have gerrit repo creation powers? [18:29:54] hi ori-livneh -- no, Chad and Antoine do. [18:30:08] ori-livneh: https://www.mediawiki.org/wiki/Git/New_repositories and https://www.mediawiki.org/wiki/Git/Conversion/Extensions_queue [18:30:21] yeah, i have an entry in the latter [18:49:38] Deebki: I need to go, will be back in the next 70 min [18:57:57] what else is :en:Special:Statistics filtering out from enwiki.page to generate the "content page" count other than redirects and non ns0 pages? [19:00:53] DarTar: Not sure you know, but it is kind of reversed iirc. It selects only certain pages, not applying a filter. [19:01:05] in a way it is the same though [19:01:11] is uses wg content name spaces [19:01:19] can contain more namespaces [19:01:24] there's currently a 40K discrepancy from a query against page excluding the above [19:01:28] and it appears there is a certain content requirement [19:01:40] (must have at least 1 wiki link? Don't know exactly what the requirements are) [19:01:53] ic [19:02:09] I'd say, digg into the code and find out :D [19:02:29] yeah, later maybe – I was just curious about the diff from the data in the db [19:02:48] according to which we've passed the 4M milestone already [19:03:20] mediawiki is delaying the party [19:06:02] 4,001,590 articles with page_namespace = 0 and page_is_redirect = 0 [19:12:35] DarTar: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/SiteStats.php;h=10aed9cc9a66ac382f3ddd783164756adaa6891f;hb=HEAD#l496 [19:12:58] ignore the "article" part, that's just legacy that should be "content pages" [19:13:43] pagelinks indeed [19:13:45] thx [19:13:51] interesting [19:14:32] somewikis third-party wikis use blanking instead of action=delete (there are actions to make blank pages appear linked with red links etc.) - so for those wikis it is also possible to instead check for non-empty ness. [19:14:40] but for wmf "link" is used indeed afaik [19:14:56] so yeah, it needs to have at least 1 page link [19:16:33] DarTar: haha, interesting comment in there: [19:16:36] // Only do views if we don't want to not count them [19:16:56] brilliant [19:16:58] Reminds me of the quote: "A double negative isn't confusing unless it is misunderstood." [19:17:31] btw the link to wikirage from Special:Stats is kind of useless, that page has been broken for a while [19:18:02] wikirage ? [19:18:43] DarTar: That whole bottom section is en.wiki local stuff [19:18:54] external statistics from https://en.wikipedia.org/wiki/Special:Statistics [19:18:55] yeah [19:19:01] and it's broken [19:19:03] somewhere in the mediawiki namespace [20:06:14] Krinkle-meeting, Deebki: OK, so... Skype? Google Hangout? [20:06:43] RoanKattouw: I'm in the hangout [20:06:46] Deebki: I can hear you [20:06:59] What hangout? [20:07:20] Deebki 'll have to share the link with you in PM [20:07:52] Deebki: You can't hear me, can you? [20:08:02] I hear lots of random noises [20:08:17] I shared the link with RoanKattouw [20:09:45] RoanKattouw: I can hear you [20:12:03] RoanKattouw: You dissapeared [20:12:59] RoanKattouw: Now that Asher has approved https://gerrit.wikimedia.org/r/#/c/7970/, could you merge it? [20:48:58] Is bugzilla dying? [20:49:19] yes, I think so [20:49:25] * marktraceur_ sighs [20:49:26] people in #wikimedia-operations seem to know [21:09:16] * RoanKattouw glares at the wifi [21:12:35] RoanKattouw: you timing out again? [21:12:54] ping n/a [21:15:43] right. ^ Ping timeout: 260 seconds [21:15:55] !bs isValidBuiltInCode [21:15:56] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=isValidBuiltInCode [21:16:07] Deebki: hey, can I dial into the secure code runthrough in 15 min? If you're meeting in a WMF conference room then tell me and I will tell you how to use one of the Voice-over-IP-conference-rooms that WMF staffers can use [21:16:24] Deebki: I think you might want to do that rather than try to screenshare! [21:16:37] RoanKattouw: welcome back [21:17:26] Dude this wifi is terrible [21:17:30] Could you get on gchat? [21:17:32] That works on my phone in case my computer drops off the wifi again [21:17:33] My phone seems to have a bit more luck [21:17:36] csteipp: ping - do you know how to dial into one of our conference lines? Maybe you can help guide Deebki [21:18:08] sumanah -- I haven't not learned the ways of the conference lines... [21:18:08] Dial 2003 (or whatever the extension is) from any WMF phone [21:18:14] Is she in the office? Or calling in? [21:18:22] Or call the office number and then dial 2003 in the menu [21:18:22] csteipp: she is on the 3rd floor with you! [21:18:44] Deebki: Grab phone, punch in 4-digit conference number, done [21:18:51] RoanKattouw: We finished the call a few minutes ago, but I have time to catch up with you over some other protocol. [21:18:58] I don't know whether Deebki is paying attention to IRC right now :) [21:19:46] ori-livneh: rmoen1: kaldari: in 15 minutes there's a runthrough of the "how to code securely" workshop that Tim will be leading in Berlin next week. Talk to csteipp and to Danielle Benoit (both on the 3rd floor) to get in on that [21:20:36] ori-livneh: rmoen1: kaldari: AaronSchulz - you might also want to attend preilly's 4:30pm Git tutorial runthrough [21:20:59] Krinkle: OK, Google Talk? [21:21:07] RoanKattouw: text? [21:21:14] or what. [21:21:16] is that today? [21:21:34] are they happening on irc? [21:21:35] Krinkle: Google Chat [21:21:44] You have two accounts but neither of them is on line right now [21:21:44] sumanah: Is it today? [21:22:05] kaldari: ori-livneh - they will be live, at the Wikimedia Foundation offices [21:22:09] and yes, today [21:22:23] RoanKattouw: Logging in now [21:22:27] RoanKattouw: Text chat though, right ? [21:22:40] great, I probably can't make it, once again [21:22:52] kaldari: it got moved, a lot. I'm sorry. [21:22:58] Krinkle: Yes, it's text-based [21:23:11] * ori-livneh probably won't either :( [21:23:30] kaldari: ori-livneh - you cannot make *either* one? that's too bad .... can you send anyone from your teams? [21:24:02] I don't have time to do anything related to this with 2 hour notice [21:24:22] i'll try and make security but i may be a little bit late [21:24:27] I'm sorry about that. Yeah, these were rescheduled due to various conflicts, etc. [21:24:44] csteipp: ok, have you met ori-livneh? can you try to drag him along to your runthrough? :) [21:25:09] csteipp: also, I know it's Saturday where Tim is. Did you and Deebki OK with him that he'll be available for this runthrough? just curious [22:13:21] kaldari: there ? [22:13:29] howdy! [22:13:47] how's the UW stuff going? [22:21:29] kaldari: sorry got disconnected. UW stuff is going good [22:22:13] Ryan_Lane: I need to bootstrap gerrit reviewing for another extension. Last time you suggested that I delete and re-add the files, but Nikerabbit and siebrand didn't like this: https://gerrit.wikimedia.org/r/#/c/7999/ [22:22:18] I would be needing the branch on Gerrit to commit my code to. I guess I would be ready to commit by tomorrow [22:22:19] is there a better method? [22:22:50] how do your repos keep getting created this way? [22:22:56] who's setting them up? [22:22:58] none of them are mine [22:23:08] I just get tasked with reviewing the first versions [22:23:18] <^demon> What's wrong with this extension? [22:23:21] oh. these aren't new extensions? [22:23:28] ^demon: he needs to do an initial review [22:23:38] <^demon> So, you clone the repo and review all the files? [22:24:23] ?? [22:24:31] you're missing some steps there [22:24:36] <^demon> I'm confused what the problem is. [22:24:49] ^demon: he probably wants to be able to do inline comments and such [22:25:08] and actually use the review system ;) [22:25:09] How do I review this extension for example: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/LastModified,n,z [22:25:23] basically, he needs a change [22:25:33] <^demon> I think that's an awful way to do it and breaks history. [22:25:52] it would be nice to have a feature in gerrit that says "let me review the entire extension [22:25:54] " [22:26:01] I think this is actually one that was migrated from SVN, but I don't know that it was ever reviewed [22:26:28] <^demon> Ryan_Lane: Yeah, and I'd love 10 ponies. You're trying to use gerrit for something it's not intended to do here. [22:26:38] drecodeam: I'll see about getting a development branch set up for you in gerrit [22:26:43] heh [22:26:43] 10? isn't that a bit greedy? [22:26:45] <^demon> "Top to bottom review of something that already has history" is kind of outside their usecase. [22:26:49] kaldari: thanks [22:27:18] brion, re: the API patch to add in warnings despite ignorewarnings, was the only problem returning an empty array improperly? If I just didn't define the 'warnings' parameter it would be OK? [22:27:24] ^demon: how do the files ever get merged into trunk then? [22:27:47] do you have to do it manually? [22:28:12] <^demon> This extension was written in SVN, the history was moved to git, so it's all in master already. [22:28:18] <^demon> That's how *every* extension's been done. [22:28:46] OK, if it's already in master, I guess I won't worry about it [22:28:54] I'll just communicate my review by email [22:29:04] <^demon> That's how we've always done "new extension" reviews :) [22:29:55] seems a bit risky having unreviewed extensions in the master branch though [22:30:29] but I guess if that's the normal procedure [22:31:14] <^demon> All extensions that are being deployed for the first time should get a top-to-bottom review, full stop. [22:31:51] of course [22:32:04] he's basically saying do it without gerrit [22:32:13] :/ [22:32:19] yeah, thanks for clearing up my confusion [22:32:22] <^demon> Like we'd have done with SVN. Process is exactly the same as before, new tools. [22:32:30] makes sense [22:32:46] I'd like to take this opportunity to ensure that the full review of the new extension gets put somewhere public, kaldari [22:32:52] kaldari: maybe on a wiki page, if nothing else [22:32:56] of course, unless you are adding this to the wmf branch, why does it need to have a full review first? [22:33:08] I understand if it can't work in Gerrit, but something more public and linkable than a private email [22:33:26] it's an extension that will potentially be deployed in the wmf branch [22:33:31] ah. ok [22:33:35] by E3 [22:34:01] just ensure there's a full review before it's added to the branch [22:34:30] the change that adds it to the wmf branch should have a check in its review "did someone fully review the extension?" [22:34:34] then that person needs to sign off [22:35:46] Ryan_Lane: I have to say I prefer your method personally :) [22:36:08] since I've gotten addicted to doing in-line comments in code review [22:36:25] well, you still couldn't do that ;) [22:36:47] since you're just adding a submodule to the wmf branch [22:37:26] except I'd like to review it long before I put it in the wmf branch [22:37:32] yes [22:38:00] but you'd fix the problems in the extension's repo, which is now [22:38:02] err [22:38:05] which is nice [22:38:41] <^demon> Ryan_Lane: 2.4 went final this morning :) [22:39:35] sweet [22:55:19] hey ^demon, could i bug you for a gerrit repo? [22:55:50] ( the bottom one on http://www.mediawiki.org/wiki/Git/New_repositories/Requests/Entries ) [23:20:08] brion, I could use some guidance on that API patch whenever you get a chance [23:24:37] marktraceur__, link? [23:27:23] brion, your revert was https://gerrit.wikimedia.org/r/#/c/8692/ [23:27:55] I just needed to know whether removing the warnings array if it was empty would fix the problem you described [23:28:42] marktraceur__, i think i was seeing problems where warnings about stuff like filename being 'IMG_123423423' was stopping further upload steps [23:28:48] that'd be a non-empty array... hmm [23:28:53] or non-empty object [23:30:02] brion, so I'd need to patch the API and UW simultaneously? [23:30:24] i think so... or at least we'd want to land the UW update first maybe [23:30:52] OK [23:31:02] as long as it's going to know to ignore the warnings it should be fine [23:31:24] Right--well, ignore the warnings if the result is "Success" [23:31:32] right :) [23:31:38] If the result is "Warning", there actually was a problem, we should probably stop [23:32:23] yeah i think that makes sense [23:32:45] marktraceur__ brion in the not-too-distant future we'll have commons.wikimedia.beta.wmflabs.org available to test that sort of thing :) [23:32:50] \o/ [23:36:59] <^demon|brb> chrismcmahon: Real men test their code in production ;-) [23:37:04] <^demon|brb> aw :( [23:37:16] Anyone want to join the Git-Gerrit tutorial dry run? https://plus.google.com/hangouts/_/a68ac952f4ec7e4580aa1b978d73c39ebbbaab4c?authuser=0&hl=en-US# [23:37:18] http://bit.ly/Jsslc5