[16:03:22] hi drecodeam! [16:03:55] hi sumanah [16:03:58] how are you ? [16:04:14] OK! in a meeting :) [16:04:18] ready to talk in an hour [16:05:14] ok [17:02:08] RoanKattouw: im just wrapping up a deployment of a bugfix for MobileFrontend [17:02:20] i know you've got a deployment window now but i should be done in like 10 minutes [17:02:30] OK go ahead [17:02:36] thanks [17:09:45] Hi drecodeam [17:09:53] hi sumanah [17:10:11] drecodeam: How has your GSoC first week been going? [17:10:39] sumanah: have started working according to the plan, had asked kaldari for my branch [17:10:48] drecodeam: are you blocked on anything? [17:11:14] had exams in the past 3 days, so had not done much work but am back at full swing. [17:11:14] Hey RoanKattouw, rsterbin, yoni_omniti , mlitn, chrismcmahon : Hi guys, look forward to deploying the new version of AFT5 with you today! [17:11:57] sumanah: no I am not blocked at anything [17:12:01] drecodeam: understood! are you waiting for Kaldari & the branch in order to get started, or do you have other things to do? [17:12:02] good [17:12:24] RoanKattouw: I'm looking at the code review, and I can fix the small stuff, but I don't think refactoring the clicktracking functions into their own file is going to be possible in the deploy window. [17:12:51] sumanah: By the way, I got my Visa and welcome package. Feels Good. :D [17:13:14] rsterbin: That's OK, it's not a prerequisite for deployment, it can be done later [17:14:12] drecodeam: YAY, I am so glad that you got the visa! [17:14:56] sumanah: me too, got rejected the first time because of the travel insurance, had to get it done locally. Me and Ashish both got the visa [17:15:13] drecodeam: that travel insurance! Argh. [17:15:44] I wonder that this problem must be existent with everybody though [17:16:06] drecodeam: different consulates use different standards when judging re visas. [17:16:29] RoanKattouw: super sorry, done in a sec [17:16:39] we're waiting for one of our mobile testing services to stop sucking [17:16:41] No worries [17:16:44] RoanKattouw, rsterbin, yoni_omniti , mlitn, chrismcmahon : OK, so this is what we are deploying today for Article Feedback: [17:16:44] 36650 Metrics Stage 4 Test: Survey button, bucketing and/or click tracking [17:16:46] 37064 Article Feedback CTA 5 - View feedback [17:16:47] I'm still reviewing code here [17:16:47] 36945 Show warning message for unsupported platforms [17:16:49] 36366 Permalink New Design with Info and Activity Sections [17:16:51] 36909 Resolve Option 1 Bucketing Issue [17:16:52] cool [17:16:52] 36502 Add a 'View feedback' link to the Talk page (but hide it for now) [17:16:53] See all Bugzilla tickets here: [17:16:53] http://bit.ly/A0OAec [17:16:59] and just a suggestion, that in conferences to come in future, we should make sure that when sending the documents to India, we should send the travel insurance along with it [17:17:39] drecodeam: the problem was which insurance provider or lack of travel insurance? [17:17:53] YuviPanda: lack of travel insurance [17:17:58] ah, okay :) [17:18:08] RoanKattouw: Sounds good. mlitn says you just approved his latest Gerrit revision, which disables the talk page link for now -- until we figure out how to make it work only for the small article sample we are testing AFT5 on. [17:18:10] * YuviPanda has to go to the consulate tomorrow at 09:15 [17:18:25] YuviPanda: do you have the insurance ? [17:18:29] yup [17:18:45] YuviPanda: best of luck :D [17:18:57] thanks [17:19:55] hi 20% checkin people [17:20:22] AaronSchulz: preilly - how is your day going? [17:20:39] drecodeam: ah, thanks for the suggestion! adding to the checklist [17:21:08] drecodeam: https://www.mediawiki.org/wiki/Volunteer_coordination_and_outreach/Event_planning#Three_months_before [17:23:46] sumanah: that would solve the purpose :D [17:23:47] Hey chrismcmahon, do you have easy access to IE6, IE7 and/or IE8? If so, can you go to the AFT5 talk page on prototype and let us know if the feedback page is disabled with only a warning message? http://prototype.wikimedia.org/release-en/Talk:Golden-crowned_Sparrow [17:24:11] fabriceflorin: I have IE7 handy, will check [17:24:20] * AaronSchulz is ok [17:24:54] drecodeam: this year I used, basically, most of my volunteer development budget for the year on subsidizing volunteers' travel to the Berlin hackathon, plus other aspects of the hackathon. So we had not run into this issue as much before, with technical events [17:25:28] chrismcmahon: Thanks! This is for Bugzilla ticket 36945: https://bugzilla.wikimedia.org/show_bug.cgi?id=36945 [17:25:41] drecodeam: I am so glad that we will have substantial representation at this event from India, South America, the Philippines, and other places that haven't had representation at the Berlin hackathon before. [17:25:45] AaronSchulz: you have 20%-related plans for the day? [17:26:00] preilly: am I right in presuming that most of your time today will be spent on Git tutorial or V8 stuff? [17:26:55] fabriceflorin: IE7 won't get to see the warning message, as that one was commented out from unsupported browsers (didn't touch that) [17:27:11] fabriceflorin: not supported= msie 6, firefox/2, android, iphone, ipod, ipad [17:27:55] RoanKattouw: fixes are done for https://gerrit.wikimedia.org/r/#/c/8565/ [17:28:15] Thanks [17:28:17] np [17:28:21] I'm reviewing 8621 now [17:28:28] * AaronSchulz is doing generic CR, and there are lots of revs in core [17:28:47] AaronSchulz: got it. [17:28:49] sumanah: thats great [17:28:55] sumanah: do you have a country splitup of berlin participants? [17:28:57] like the GSoC one... [17:29:22] YuviPanda: Weirdly, Eventbrite does not make that very easy in its readymade reporting, but I can probably figure it out at some point [17:29:50] ok :) Would be nice to have (if you find the time and inclination) :) [17:29:52] YuviPanda: but there will be at least 5 people from India, I think! [17:30:08] hmm, I'm missing one then. Need to figure out who that is [17:30:13] RoanKattouw: all done [17:30:16] Thanks [17:30:20] fabriceflorin: http://prototype.wikimedia.org/release-en/Talk:Golden-crowned_Sparrow is not blocked for IE7 and shows no errors. http://prototype.wikimedia.org/release-en/Golden-crowned_Sparrow is not blocked for IE7 and throws an error on page load. [17:31:02] mlitn: is that expected behavior? ^^ [17:31:40] chrismcmahon: link should be http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/Golden-crowned_Sparrow [17:32:10] (though IE7 will not get the warning message for now - adding it to the list though; IE 6 should already get it disabled) [17:32:35] (and I know nothing about an error, definitely no expected behavior - what's the error?) [17:32:39] chrismcmahon_: the article should be blocked, so i think there is a bug [17:32:44] not the talk page though [17:33:00] http://prototype.wikimedia.org/release-en/Special:ArticleFeedbackv5/Golden-crowned_Sparrow is not blocked for IE7 and throws an error. (it looks bad, too, but not as bad as it did the last time I checked that page) [17:33:19] chrismcmahon_: Thanks for checking! Looks like this slipped through the cracks. mlitn1 is now working on a fix to remove IE7, which I believe looks really bad, based on what I saw on my home machine. Do you also have IE8? Does it look bad as well? http://prototype.wikimedia.org/rc-en/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow [17:34:13] mlitn: error is the classic "expected identifier, string or number [17:34:22] miltn: https://gerrit.wikimedia.org/r/#/c/8621/ is not in the omniti branch, but it's on gerrit. is that intentional? [17:35:04] fabriceflorin: I don't have IE8 handy, I do have a modern IE one reboot away, not sure if it's 9 or 10, I think it's 9. [17:35:17] preilly: ping [17:35:22] rsterbin: yes, fabriceflorin requested not to push it to prototype until after this deploy [17:35:39] rsterbin: is on it's own branch (omnitiworks/finalform) though [17:35:43] ok [17:36:08] does Roan know it's not supposed to be in this deploy? because he was just reviewing it. [17:36:45] rsterbin: miltn: https://gerrit.wikimedia.org/r/#/c/8621/ is not ready to be deployed until June 7. It's the Final Feedback Form (Option 5) - bug 36647. [17:37:03] RoanKattouw^^ [17:38:03] OK thanks for mentioning [17:38:27] It had issues anyway [17:38:30] But this should be annotated [17:38:43] so I don't accidentally merge it earlier [17:40:16] mlitn1: I usually don't send things up to gerrit until the previous week's deploy is done, for just that reason [17:40:38] okay, will keep that in mind [17:41:49] RoanKattouw: is Asher around to do the schema change review? [17:44:52] Sorry about that [17:45:21] rsterbin: I don't see Asher on IRC (his nick is binasher) [17:45:21] rsterbin RoanKattouw : Do we have any DB schema changes for Asher to review for this deployment? Or are you referring to DB changes for the June 7 deployment? [17:45:43] fabriceflorin: there's a schema change for the permalink [17:45:52] (the action count and last action notes) [17:46:27] I'm talking about https://gerrit.wikimedia.org/r/#/c/7970/ [17:48:50] rsterbin: Oooh. I wish we had asked Asher about this earlier, as he usually wants more lead time. Going forward, could developers on the AFT team email Asher about DB change requests (and Cc: Roan and me) a week prior to deployment (or at least several days before)? (That also includes you, mlitn1 ) [17:49:04] fabriceflorin: we DID ask asher about this earlier. [17:49:41] the change has been on gerrit since Friday, and Roan added Asher as a reviewer when he first reviewed it on Monday. [17:50:44] rsterbin: Great! I am glad we followed protocol. Now the question is: where is Asher? RoanKattouw: Do you feel comfortable deploying this without Asher's OK? Or do we need to remove that permalink fix from this deployment? [17:51:13] fabriceflorin: No, I am not deploying it without Asher's OK, I don't feel like getting in trouble with Rob [17:52:18] RoanKattouw: Should I go downstairs and see if I can find Asher? Or should we remove https://gerrit.wikimedia.org/r/#/c/7970/ for this deployment? It is not essential to have this for this deployment, and I do want to deploy everything else. [17:52:20] OK, so here's our status [17:52:33] We should probably drop 7970 for now [17:52:41] https://gerrit.wikimedia.org/r/#/c/8729/ is almost OK but not quite [17:53:32] RoanKattouw: No problem, we can drop 7970. rsterbin, do you need to do anything on your end to remove it? [17:53:40] The commits that were merged and that I will deploy now are the following (non-notable commits removed): [17:54:07] fabriceflorin: it can just hang out on gerrit for now [17:54:17] 0981daf3acdcd48233511efc742331b70708cd0e Metrics stage 4 / feedback page click tracking (bug 36650) [17:54:18] c48def52d23ac7767e42febea14ae8d363177d92 Remove link on talk page for now [17:54:20] ecab36bf0d3733643c34fe6908c475a0627c842e Changed the title of the central feedback page (bug 35862) [17:54:21] 740bd4fa7c1bc8857c89253db0550b6276d9b882 Enable links to feedback page [17:54:24] 0d4092cb2cdd94e2af899065b1091cb6b04b6b94 Update bucketing for forms to 100% option 1 [17:55:23] So I'll start deploying the commits I listed now [17:55:32] 8729 can be added with a trivial fix [17:58:45] Roan, this all sounds good to us, except that we have a warning message that we also want to deploy, which is Bugzilla 36945 Show warning message for unsupported platforms - Code on Gerrit: https://gerrit.wikimedia.org/r/#/c/8729/ mtlin is doing the fix now. [17:59:09] RoanKattouw: sent another one your way - https://gerrit.wikimedia.org/r/#/c/8805/ (disable AFTv5 on IE7&8) [17:59:15] fabriceflorin: Yeah, that's what I meant when I said I can add 8729. Will hold off until mlitn fixes it then [17:59:18] 8729 fix coming up soon [17:59:48] fabriceflorin, RoanKattouw: could 7970 to be merged as soon as asher can review it after this deploy? it's got some refactoring that would be nice to have around to build on, and i'd like to avoid chains of gerrit dependencies like we had last time. [18:00:06] rsterbin: Sure [18:00:31] thx [18:00:34] Once Asher approves it I'll merge it [18:02:49] 8805 merged [18:05:10] OK, sounds good. I just sent an email to Asher asking him to review 7970 ASAP. I Cc:d all of you guys. [18:06:24] RoanKattouw: 8729 updated [18:07:40] mlitn1: Okaaay! RoanKattouw: Are we good to go on your end? Next stop: testing? [18:14:03] I'm almost there [18:14:14] Dropped off again, sorry [18:17:00] RoanKattouw: No worries. Are you having issues with your connection? [18:18:02] No, my computer has fan issues, so it overheats easily [18:18:21] This was somewhat manageable back in SF but here in NL there's a heatwave going on [18:18:26] which doesn't help :S [18:18:32] I need to get that fan fixed [18:25:58] RoanKattouw: Good luck with your fan issue. Sorry to hear about the heat wave. :( [18:30:46] OK, let's see here [18:32:24] Rebuilding l10n cache now [18:33:35] fabriceflorin: OK we're on test now [18:36:54] RoanKattouw rsterbin yoni_omniti mlitn1 chrismcmahon : OK, let's all test the new CTA5 and feedback page on testing. URLs coming next. [18:38:51] I just tried this URL on testing, but I am NOT getting the CTA5: http://test.wikipedia.org/wiki/Golden-crowned_Sparrow Is this because we have not changed the bucketing on testing? [18:39:42] RoanKattouw: is config updated already ($wgArticleFeedbackv5SelectedCTA = 5; instead of = 1)? [18:39:58] Didn't you put that in Gerrit? [18:40:24] However, if I add a special parameter at the end of CTA5, it performs as expected: http://test.wikipedia.org/wiki/Golden-crowned_Sparrow?aftv5_cta=5 [18:40:29] Aha we have $wgArticleFeedbackv5SelectedCTA = 1; in our config [18:40:31] Will remove that [18:40:38] Cool. [18:40:38] yes, in extensions itself [18:40:40] ok cool [18:40:56] Done [18:42:01] great, works [18:42:50] chrismcmahon: Could you please test the feedback page on IE7 and let us know if it correctly blanks out the feedback page, and display a warning about your platform not being supported? http://test.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow [18:43:52] fabriceflorin: no sign of blocking IE7 at http://test.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow [18:44:20] Chris: Oh shucks. Can you test this URL on IE7 as well? test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow [18:45:11] IE7 not blocked at http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow either [18:47:15] Thanks, chrismcmahon_, sorry to hear we're not blocking the feedback page IE7 -- RoanKattouw, in the interest of time, I think we will go ahead and deploy without this warning, and troubleshoot this later today with mlitn1 and yoni_omniti. Everyone: are you seeing any serious bugs on testing at this time, besides this one? I am still testing, but haven't found anything else yet. [18:48:29] OK [18:48:51] correctly blocks for me [18:49:14] http://test.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow [18:49:40] gives me "Sorry, your browser is not supported by this prototype. To see this page, please use a different browser." [18:50:05] The good news is that the CTA5 is now working as intended for me. And the feedback page is properly displaying the Survey button at the top right corner (did you guys test this "What do you think of this page?" button?). [18:50:15] Alright I'm deploying to production now [18:50:38] yoni_omniti: Glad the IE7 block is working for you. Whew! So we are good to go on our end. [18:50:58] chrismcmahon_ could you try clearing cache? I get the message when spoofing my user-agent [18:51:13] this is interesting, the moodbar link "Editing wikipedia..." does not appear in IE7 [18:51:22] mlitn1: I'll try it [18:51:40] chrismcmahon_: were you using a virtual machine for IE7 or a real machine? I am trying to figure out why yoni_omniti got the warning message but not you. [18:51:48] Eloquence, new version of the SVG instance is up, print mode appears to work now [18:51:49] t tried by both spoofing my user-agent, and in real IE9 simulating IE7 [18:51:56] I have IE7 on a VM [18:53:28] both real machine IE7 & virtual machine IE7 should have same user-agent, which is what "detection" is based on, so that shouldn't be a cause for it not to work [18:53:54] RoanKattouw: Thanks for pushing this to production. Let us know when you are ready to test. [18:54:01] all I can think of would be cache, or spoofed useragent [19:06:15] fabriceflorin: OK looks like we're live now [19:08:08] i suspect the configuration values may still be wrong [19:08:16] i'm not getting AFTv5 at all [19:08:31] RoanKattouw: Great! We'll test it now. Here are the new URLs: http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow and http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow chrismcmahon and yoni_omniti are we blocking IE7 properly? [19:09:04] blocks for me [19:09:36] chrismcmahon_ you may have missed this one: [19:09:38] (12:08:31 PM) fabriceflorin: RoanKattouw: Great! We'll test it now. Here are the new URLs: http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow and http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Golden-crowned_Sparrow chrismcmahon and yoni_omniti are we blocking IE7 properly? [19:09:55] blocks for me when spoofing as IE [19:10:27] Sorry, I gave you the wrong URL: http://en.wikipedia.org/wiki/Golden-crowned_Sparrow [19:10:32] yoni_omniti: in firebug/console, do this -- mw.config.get( 'wgArticleFeedbackv5DisplayBuckets' ) [19:10:38] it should have version: 3 [19:11:08] yea [19:11:15] it was caching issues on my end [19:11:18] works for me now [19:12:21] not blocking IE7 for me with the useragent above [19:12:37] but that's not a show-stopper, even if it is mysterious [19:12:51] To be clear, after you post feedback, you should see a CTA5 with a big blue button saying 'View feedback' that takes you to the feedback page on all supported platforms: http://en.wikipedia.org/wiki/Golden-crowned_Sparrow [19:13:51] It's working for me on all my Mac platforms. [19:13:59] Is it working for you guys as well? [19:14:08] works for me [19:16:33] works fine on firefox & chrome here [19:16:36] yoni_omniti, rsterbin : is everything working for you as well? [19:16:50] opera it "works" fine, but the buttons look somewhat odd [19:17:06] it works fine for me (ff/ubuntu) [19:17:10] yup, work for me [19:17:41] fabriceflorin: who can check to see if clicktracking events are coming through? [19:17:46] DarTar: Could you please check that we are collecting the data we need for Metrics Test Stage 4? [19:18:32] fabriceflorin: I can do this later, I'm in the middle of the announcement of the petition right now [19:18:34] lol, i missed dario when i was looking for him in the room list. sorry! [19:19:47] OK, DarTar, please let us know ASAP. For now, we are releasing our developers, so they can go back to work. Reha, no worries, it was hard to miss Dario this time around, since he was so quiet ;o) [19:19:59] I have a discrepancy in what FF shows vs. what Chrome shows when hitting the browser Back button, nothing big. [19:20:15] guessing that's browser behavior and not us [19:20:20] For the record, here are the clicktracking requirements for metrics test 4: http://meta.wikimedia.org/wiki/Research:Article_feedback/Clicktracking#Stage_4_.28FeedbackPage_usage.29 [19:21:40] chrismcmahon: Thanks! I think we can dismiss these minor issues for now, and pick them up again once we freeze new feature development and enter the productization phase. In the meantime, thanks so much for helping us test this app today. Look forward to our big volunteer testing spree on June 9! [19:22:31] hmm, Incognito/Private mode Chrome/Safari does not show recent feedback [19:23:15] checking if it was sent at all... [19:23:20] yoni_omniti, rsterbin : Could you please assist mlitn1 in figuring out a way to make the Talk page link work only for the small article sample we are testing? If we can find a solution, we propose that mlitn1 and deploy that fix while he is in Berlin with RoanKattouw next week, so that Roan can coach him on deploying a minor fix while they are both in the same room. [19:23:57] we are working on it with mlitn in our irc channel [19:24:15] i dont think there is a "quick" fix [19:24:27] anyone want to double-check me on incognito/private mode? feedback is being submitted, but not viewable in Special:ArticleFeedbackv5/Golden-crowned_Sparrow page [19:24:46] which browser? [19:24:53] Safari and Chrome [19:26:13] private browsing works for me [19:26:37] did you change your user agent back to default? [19:27:04] yoni_omniti: I haven't changed any user agents, they're the browser defaults [19:27:19] RoanKattouw: I think we are done with today's deployment, thank you very much! Going forward, Terry Chay would like mlitn1 to do deployments under your direct supervision. So I would like to schedule some time with you the week of June 4 for the next deployment, after you return from Berlin, so we can all do this together. Which days are you free that week? (Thursday morning is the metrics presentation, so that would be an issue). How about [19:27:19] Wednesday morning, June 6th? (it has to be morning, because mlitn1 will be back in Belgium). [19:27:43] sorry, I'm in IRC twice, straightening that [19:27:52] Guest77118: I'm seeing it as well, on chrome private browsing [19:28:42] fabriceflorin: Can we do Tuesday [19:28:43] ? [19:29:07] better [19:29:15] mlitn1: +1 [19:29:21] RoanKattouw: Yes, I can clear Tuesday, June 5th for this. 10am PT? [19:29:26] Sure [19:30:13] Oh, hah [19:30:18] Tuesday 10am = NPT deployment :D [19:30:38] Looks like we've gone through this same negotiation before and got the same result [19:30:42] mlitn1: is the top feedback post for you "More audio and video would be great." in incognito? [19:30:52] No wait, that's 1pm [19:31:04] Sorry, my calendar is in a different timezone now [19:33:31] RoanKattouw: No worries, let's plan on Tue. 10am-1pm PT, then, if that works for you. I recommend we block out 3 hours, because mlitn1 will be driving and will inevitably take longer than if you were doing it. But we would be in the same room, with mlitn1 on Skype, so you can coach him faster. [19:34:13] fabriceflorin: That's 5 hours of straight deployments. I'm in if you provide me with lunch :) [19:37:06] RoanKattouw: I am more than happy to buy you lunch for this marathon ;o) Would you mind changing the engineering schedule on your end? I don't have permissions to do this here: http://wikitech.wikimedia.org/view/Software_deployments -- Also I see that internationalization has a window until 10:30am PT, so we may need to start then. [19:37:37] Ah yes [19:39:46] fabriceflorin: Who's gonna be driving for PageTriage? Did we get shell for any of your people yet? [19:54:02] RoanKattouw: Benny and Kaldari both got shell access and will be driving the New Pages triage. Terry Chay just scheduled our Tuesday 10:30am PT slot for AFT on the engineering calendar for now. I will personally go get you lunch of your choice that day. Sound good? [19:54:17] Sounds great, thanks [19:54:35] I put in a calendar slot a few minutes before Terry did, that's all straightened out now [19:54:40] I'll add Benny and Kaldari's names to the page too [19:55:27] Cool, thanks so much. I also propose that if you and Matthias can find some time in Berlin to do a small push of a single Gerrit revision while you are together, that would be a really good idea. [19:56:14] Yeah I'm not gonna deploy anything during a hackathon [19:56:43] At night I wanna be on the street eating döner kebab without worrying whether I broke the site [19:56:51] I hate my ISP [19:56:52] And I think ops probably feels the same way [19:56:56] RoanKattouw: well, then you can get beer [19:56:59] And deploy something [19:57:05] RoanKattouw: OK, no worries, I understand. But perhaps you can give him some personal tips while you are together. It's always easier to do this face to face. [19:57:18] vvv: Andrew once said something about opening a beer and typing sudo -s [19:57:59] I'm pretty sure ops will break the site will they're in berlin. ipv6 testing etc. :) [19:58:06] fabriceflorin: are the Feature/Hide/Oversight links to the right of each post supposed to be functional right now on https://en.wikipedia.org/w/index.php?title=Special:ArticleFeedbackv5/Golden-crowned_Sparrow&ref=cta ? [19:58:23] Eloquence: then we have to use this time. I mean, you can't double-break site [19:58:45] RoanKattouw: Thanks for all your help today! I'm sorry that so much of the workload falls on your shoulder, and I am glad that we are training other team members to pick up some of that burden from you. But I am also glad that you are staying on as a coach, so that they can aspire to your mastery over time ;o) [20:00:17] Yeah I'm happy to train people [20:00:27] It means less work for me in the long run [20:01:20] RoanKattouw: Yes, this will free you up in the long run. And you're great teacher too! ;o) [20:04:47] OK, guys. I am going to grab some lunch now. Will be back at my desk in 20 mins. Over and out. [20:05:13] fabriceflorin: still around? [20:10:37] christophermcmah: Yep, eating lunch at my desk. Regarding your question, the Feature/Hide/Oversight links are supposed to work. If you are auto-confirmed editor, you get Feature. If you are monitor (roll backer, reviewer, admin), you get Hide. [20:15:16] brion: why do we want the UW stuff deployed today? [20:17:21] from my pov, it's nice to have, not must have :). we've got a good deployable release shaping up, but it can wait til wednesday next week for the normal release cycle if it's inconvenient [20:19:54] AaronSchulz (or anyone with an opinion): I've got a command-line script to generate wikitext release notes, ala http://www.mediawiki.org/wiki/MediaWiki_1.20/wmf3 . Where do you think I should check in the script? [20:21:04] robla: sounds like a hashar question, I know there is an empty mythical mediawiki/tools repo [20:21:27] * robla looks for mythical repo [20:21:37] brion: do you want to deploy UW today? [20:21:53] AaronSchulz: i'm happy to deploy it today, or we can wait until the next general as Eloquence notes [20:22:08] this would be an update to master? [20:22:14] yep [20:22:43] it'd be nice to have the api one live since we need that for wiki loves monuments mobile app, and so i can do some more prep work on that once it's live [20:22:51] the others are bug fixes and nice-to-have improvements [20:26:48] RoanKattouw: there is an uncommitted config change in CommonSettings.php that i think might be yours [20:26:52] - $wgArticleFeedbackv5SelectedCTA = 1; [20:26:59] Oh sorry about that [20:27:01] Yeah that's mine [20:27:07] Shall I commit it? [20:27:13] brb [20:28:30] RoanKattouw i can do it as long as it's ok:) [20:28:46] im pushing out another config change in just a sec [20:29:01] I'll commit it right now [20:30:07] Done [20:30:22] * RoanKattouw <3 git add -p [20:31:10] :D [20:31:34] that is a pretty slick feature. [20:32:44] RoanKattouw: what does it do? [20:33:08] AaronSchulz: It allows you to select parts of the unstaged diff and choose which parts to stage [20:33:16] back [20:33:34] ooooooooooooh fancy [20:33:40] So just now, both Arthur and I had changed different parts of CommonSettings.php, so then git add -p allows you to stage (and then commit) one part of the change but not the other [20:33:58] This is easy if the changes are in different files so why shouldn't it be easy if they just happen to be in the same file? [20:34:09] aww RoanKattouw im trying to git push a change to CommonSettings but getting an error [20:34:11] remote: ERROR: In commit db1705811beb2afb701a00bfc806ef6b3a56ba2a [20:34:11] remote: ERROR: committer email address roan.kattouw@gmail.com [20:34:11] remote: ERROR: does not match your user account. [20:34:15] brion: https://gerrit.wikimedia.org/r/#/c/8856/ [20:34:22] Oh meh [20:34:25] Lemme push that one then [20:34:29] \o/ [20:34:30] k thnx [20:34:47] Although of course now it's complaining about yours lol [20:34:47] awjr: we may deploy some UW stuff at 2 if that's ok [20:34:52] OK let me push just mine first [20:35:12] AaronSchulz that should be ok - we're just about done with the fundraising deployment [20:35:18] brion: gah, it still doesn't have that one change though [20:35:31] assuming this config change doesn't cause any explosions... [20:35:41] d'oh [20:35:45] let's see if we can fix that [20:35:49] I think it is -1 [20:35:53] awjr: OK now you push yours [20:36:43] RoanKattouw seems to have worked [20:36:44] thnx [20:36:52] Platonides: poke [20:37:40] oh wait i think i can submit it still [20:37:47] yes? [20:38:01] Platonides: your note on https://gerrit.wikimedia.org/r/#/c/7832/ about campaign being an array [20:38:10] it is an array already? [20:38:39] AaronSchulz: ok i think it's merged now on master, try updating the merge [20:38:40] there's some magic there converting $params? [20:38:57] Platonides: yeah, it's a PARAM_ISMULTI param so the framework splits it to an array for us [20:39:01] I'm not too proficient i API speak [20:39:04] ah, fine [20:39:06] no worries :) [20:39:11] that's what I thought [20:39:14] go ahead [20:39:14] thanks for looking it over! more eyes shallow bugs [20:39:15] * AaronSchulz was just double checking [20:39:35] there's probably some really bad thing we all overlooked :) [20:39:39] haha [20:39:42] always seems to be ;) [20:40:57] brion: [20:40:58] # Disabling to test -- 2003-11-30 BV FIXME [20:40:58] ####Include /apache/conf/throttle.conf [20:41:08] in httpd.conf ;-))))))) [20:41:42] rofl [20:42:08] ah the good old days [20:42:16] when we had no version control on config files [20:42:21] or backups, probably [20:43:15] we had RCS [20:43:20] yeah, I uncommented that line [20:43:21] I think [20:43:26] (for labs) [20:43:30] then brion rejected saying the file doesn't exist [20:43:43] basic httpd.conf is https://gerrit.wikimedia.org/r/8863 [20:43:44] u can't throttle me [20:43:53] no more brion comment :-( [20:44:12] *hashar rejected [20:44:54] it's so nostalgic reading those things [20:45:31] or old threads where there's discussion "we're running with APC disabled, the load it's not a big issue" [20:46:07] remember load balancing with en2.wikipedia.org? [20:46:24] I think I came later [20:46:31] you missed out on some fun ;) [20:46:34] yep [20:46:38] I did [20:47:19] still, I have known wikimedia with just a few employees [20:47:28] we even had revert wars between tim and brion: [20:47:28] # turned off -- brion -2004-01-09 [20:47:29] # on for testing -- TS 2005-11-25 [20:47:30] # off again, squid doesn't understand the HTTP/1.1 keepalive protocol -- TS [20:47:36] :) [20:48:07] I saw it [20:48:25] I remember wondering about some brion statements in the archives [20:49:12] it was the all-knowing brion, saying the opposite of , which we consider commons sense now xD [20:51:42] versions like "MySQL: Ver 3.23.47-max-debug for Win95/Win98 on i32 [20:52:00] oh man i do NOT miss mysql 3 [20:52:25] or php 4 *shudder* [20:52:30] xD [20:52:33] btw, which were the first two servers? [20:52:43] I think wikipedia was initially on a couple of servers [20:52:54] originally we shared with some of bomis's servers [20:52:57] I think one of them might have been Pascal, but which was the other? [20:53:10] then we got our own, i forget the original ones' names [20:53:25] but yeah for a while we had… one DB server and two front-end boxes [20:53:32] then one of the front-end boxes died [20:53:36] then the DB server died [20:53:42] and we had the xmas 2003 fundraiser :) [20:54:08] downtimes are appropiate for collecting donations :) [20:54:22] i *think* the last of the '04 (original florida) batch are all retired now, we started with about… 8 or 9 i think [20:55:04] we were excited cause the database server was 64-bit!~ [20:55:16] 'finally! more than 4gb of ram' [20:55:55] the machines have… gotten bigger and more numerous since :) [20:56:14] <^demon> And we stopped naming them after encyclopedists ;-) [20:56:16] brion: you should write a book about your wiki adventures [20:56:18] as well as the project sizes and needed bandwidth [20:56:21] I am sure it will sell well [20:56:31] :) [20:56:33] and lot of readers will really enjoy your sense of humor this way ;))) [20:56:41] that would indeed sell well on a wikimania [20:56:48] or a hackaton [20:56:59] <^demon> Session for Wikimania: "Grandpa Brion's Wiki Stories" [20:57:05] ROFL [20:57:06] haha [20:57:08] <^demon> We'll get him a rocking chair :) [20:57:13] xD [20:57:15] AaronSchulz i think im gonna need a few more minutes [20:57:15] can i shake a cane at the n00bs [20:57:17] with an introduction by Tim & Mark [20:57:22] we're debugging one last issue [20:57:26] "see, we have this edit link at the bottom...." [20:57:36] * AaronSchulz sprinkles some fire ants in [20:58:07] I would definitely show up for "Grandpa Brion's Wiki Stories". [20:58:14] ^demon: while i've got you here -- i think yuvi sent you a note asking to import the Wiki Loves Monuments mobile app from github to gerrit. just want to check if there's any gotchas or delays we should be aware of :) [20:58:33] * brion catches mindspillage lurking in the dev channel :) [20:58:41] * mindspillage lurks all over. [20:58:44] WMF should hire a storyteller about the technology adventure [20:58:48] of the WMF [20:58:50] <^demon> brion: Just gotta make the repo and enable force pushing briefly before making it gated :) [20:58:55] that is knowledge ;-] [20:59:09] remember when we both lost our passports in berlin and had to go to the embassy for new ones on the morning of our flights out? [20:59:15] <^demon> brion: I'll be sorting through a *bunch* of new repos tomorrow, Yuvi's being one of them (I got his e-mail) [20:59:26] brion, lol [20:59:28] ^demon: awesome thanks [20:59:57] well bed time again :-( [21:00:01] see you tomorrow! [21:00:03] good night, hashar [21:00:06] night hashar [21:00:08] brion: indeed, not traumatic enough that I've suppressed it! [21:00:13] hehe [21:00:27] i think i took my replacement passport photos in a photo booth in the subway [21:01:02] brion: my eventually getting a replacement passport is how I found out I don't really have a middle name. [21:01:05] now that we're on Git, should we keep creating getVersion functions or are these deprecated? e.g. public function getVersion( return __CLASS__ . ': $Id$';javascript:void(0)} [21:01:17] oh my! [21:01:26] you've been living a lie mindspillage :) [21:01:34] (I have one letter: "M". My father's explanation: "your mother wa on a lot of drugs at the hospital".) [21:01:44] is there a reason why sync-dir would not sync to donatewiki or foundationwiki? [21:01:48] kaldari: for now you still need to create them, but don't use '$Id$' [21:01:57] awjr: No it should work fine [21:01:59] the parent class is abstract so you get errors if you don't fill it [21:02:00] I don't have a middle name either, which made it difficult to get a driver's license in Tennessee [21:02:02] hmm [21:02:09] awjr: Provided you have the right version (wmf2 or wmf3) [21:02:10] but if you leave '$Id$' it won't hurt, it'll just look silly [21:02:17] They ended up listing my middle name as 'XXX' [21:02:22] we don't usually have middle names in Spain [21:02:28] RoanKattouw yeah, should all be wmf3 right? [21:02:34] we simply inherit two surnames [21:02:36] awjr: Check wikiversions.dat to be sure [21:02:52] kaldari: how scandalous. [21:03:13] RoanKattouw wikiversions.dat says everything is wmf3 [21:03:17] i ended up with two scifi/fantasy names for my first and middle [21:03:35] Yeah, so my name according to my license was "Ryan XXX Kaldari" [21:03:49] 'Brion' from a character in the Deryni novels [21:03:54] 'Lucas' from Star Wars :) [21:04:02] so that was the L [21:04:08] :) [21:04:18] RoanKattouw: im trying to push out an update to ContributionTracking extension, which is at 50d89c841e6b181a18ff58139d3025ce2fdc073b in /h/w/c/php-1.20wmf3/extensions/ContributionTracking [21:04:24] they don't look that fantasy [21:04:31] imagine being named Aragorn [21:04:37] hehe [21:04:38] brion's destiny was clear from the start... [21:04:38] but after a sync-dir, the wikis it runs on show no change (eg https://donate.wikimedia.org/wiki/Special:Version) [21:05:12] Huh that should have updated [21:05:49] RoanKattouw i also updated a couple other fundraising extensions - LandingCheck should also have been updated on donatewiki to 2836d759a0ccec3be1bf8e9c0c49630d8e17e119 [21:05:52] but it did not. [21:05:56] That's weird [21:06:02] i wonder if i should try a scap? [21:06:14] Yeah you could try that [21:06:26] I don't understand what's going on but that's what I would've done [21:07:41] AaronSchulz: sorry dude this might take a bit [21:07:58] wee [21:30:58] awjr: done? [21:31:10] AaronSchulz one sec [21:31:19] pgehres: do things appear to be OK now? [21:31:52] awjr: i see no issues other than the value not making it to the db [21:32:01] but that is not a rollerbacker bug [21:32:04] details, details [21:32:13] ok AaronSchulz, it's all yours [21:48:16] AaronSchulz: ok we've got one more bugfix which i've just merged to master on UploadWizard [22:06:46] is Trevor in office? [22:14:39] petan|wk: I've asked him to get on IRC [22:14:49] ok [22:15:25] petan|wk: And there you go [22:15:32] hey TrevorParscal [22:16:02] hi petan|wk [22:16:12] how's it going, sorry I wasn't on IRC earlier [22:16:25] brion, it looks like the UploadWizard changes spilled a little on the way [22:16:27] regarding OSB? [22:16:35] marktraceur_: ooh what broke? [22:16:40] I am waiting for review still :) [22:16:52] Not broke, the i18n change for the categories patch didn't stick [22:17:05] ah. hmm [22:17:18] The link below category inputs says "save category", which no longer makes sense [22:17:29] not a deployment issue [22:17:34] local customization on commons, I'll fix it shortly [22:17:43] Eloquence, thankee [22:19:06] Well, the rest of it works brilliantly [22:19:15] excellent [22:20:31] stuck a note on the updates on commons VP as well: https://commons.wikimedia.org/wiki/Commons:Village_pump#UploadWizard_changes_live_today [22:20:36] feel free to edit that [22:21:47] marktraceur_, I'll run a user-test now, that'll give you some issues to work on ;) [22:21:56] Eloquence, of course it will [22:22:10] :DD [22:22:18] the big thing is that people still fail on step one not noticing that they have to press "Continue" because it's too far down the screen [22:22:36] Eloquence, there was some mention of that in the one UserTest you sent me [22:22:46] not sure how much that happens to real people vs. paid testers who want to move on ;) [22:22:51] OK, it was like 5 minutes of the commentary [22:22:57] but good UX dictates that we should make it a lot more obvious [22:23:19] this is https://bugzilla.wikimedia.org/show_bug.cgi?id=36832 fwiw [22:23:46] I'll also ask vibha (one of our designers) to take a stab at the drag/drop ux as that's still a bit wonky [22:24:54] !r 115428 [22:24:54] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115428 [22:25:01] do we have a labs instance spun up for that? [22:25:13] i think most of the technical bugs with that are fixed but wouldn't hurt to run it by ux yeah [22:25:17] also, Eloquence, pm incoming. [22:26:27] jorm, not yet .. Ryan_Lane mentioned andrew b could help us get a design-reviews.wmflabs.org set up, but right now ops is busy with hackathon prep [22:26:49] sure, sure. [22:28:19] Eloquence, I'm hurt, I thought my drag/drop implementation was pretty good :) [22:29:06] it's pretty good already [22:29:10] take a look at flickr's new uploader as well [22:29:38] the thing with drag/drop is that it's often hard to know for the user that it'll work without any affordances in the UI _before_ you initiate a drag action [22:30:01] Hmm, true [22:30:02] wordpress has a pretty neat drag/drop. [22:30:12] Could we maybe add in a background graphic to indicate that? [22:30:15] there's a big button that says "Drag photos here or click to select" [22:30:29] also, hi mark! I'm brandon. [22:30:32] flickr just adds a big "Drag files here
or
Click this big fat button" as their main entrypoint [22:30:59] * jorm detects invalid html [22:31:05] hee [22:31:13] don't parse me, bro [22:31:23] Eloquence: have you used Basecamp? they've got a nice attachment uploader in their comment boxes [22:31:23] jorm, Hi! I'm here helping Erik, clearly :) [22:31:26] i'll take a screenshot [22:31:59]
text
[22:32:21] * brion waves at marktraceur_  [22:32:23] no, haven't seen that .. definitely want to move towards integrating uploading into the view/edit experience though [22:32:33] i'll have to introduce myself in person next time we're both in :) [22:32:42] brion, you're on! [22:33:20] Eloquence, could it be as simple as moving the navigation button(s) to the top of the content area? [22:34:05] Usability test task 4: Did you complete the entire process successfully? Usability test task 5: OK, really. If you were stuck on the first screen, scroll down and press "Continue". (We know that part is still confusing!) Thanks! [22:34:49] Haha, awesome [22:35:07] http://leuksman.com/misc/basecamp-comment-upload.png <- basecamp's uploader in their attachment dialog [22:35:38] it specifically says you can drag and drop and has a fairly clear target, and lets you click the link to do classic browse [22:36:45] that's pretty straightforward [22:36:45] psht. who needs this shit to be usable? [22:37:00] if you can't figure out how to use wikipedia, you don't deserve to be an editor. [22:37:02] The dotted outline is pretty similar to our current implementation, we could just remove the bits that make it invisible [22:37:14] is mark working in the office? [22:37:16] *nod* [22:37:33] jorm, yeah .. across from CT [22:37:55] which is to say like right next to my desk ;) [22:38:02] ah. [22:38:13] wait. isn't that asher? [22:38:24] other side i think? [22:38:26] jeez. i get moved upstairs and everything falls apart. [22:38:29] lol [22:38:31] that would be ryan? [22:38:33] CT just moved, actually :) [22:38:39] aha! ok nevermind then [22:38:42] i'm not as blind as i thought ;)) [22:38:45] or…. am i ;) [22:39:11] i usually end up on irc even with ryan [22:39:17] Eloquence, is there a good way to reset the tutorial-skip preference? [22:39:37] you mean so that we don't show it again for literally every single person who uploads a file on commons? you think that might be a nice thing to do? [22:39:38] preferences dialog. [22:39:39] Never mind, intelligence prevailed [22:39:39] marktraceur_: it'll be under 'upload' tab on preferences [22:40:36] given that it was previously a cookie pref it'll just come up again once until people dismiss it [22:40:47] so, i've been thinking that looking at the preferences system might be a fun excercise for the design cabal. [22:41:15] once we're done with standards guidelines and the like. [22:41:24] yeah i've gotten so used to it popping back up in new browsers/computers that one last time won't bother me ;) [22:41:39] oh MAN prefs needs an overhaul [22:41:43] jorm, that's an infinite rathole but could definitely use a first round of cleanup [22:41:47] inorite [22:41:56] Eloquence, from Commons Special:Preferences, shouldn't the Upload File link be to Special:UploadWizard? It's to Special:Upload now [22:42:11] Er, Commons:Upload [22:42:21] the issue is that we can come up with designs all day but if no one implements them, well... [22:42:27] i suppose i could set up something with sumanah. [22:42:38] wtf [22:42:42] like, a whole "this is a box of stuff you can pick from if you're just looking for something to do" [22:42:43] does Special:Preferences suppress gadget loading? [22:43:11] that would explain it because commons uses a gadget to render the UW link for obscure reasons [22:43:39] if the team does a lot of stuff that gets built into mw, i'd like it if they could get lines in the CREDITS file, by the way. [22:44:29] jorm, for starters, I'll frankly be happy if you manage to stop Bad Things from going into the deployments because nobody applied any UX common sense in the review process [22:44:41] e.g. the "Associated namespace" thingy I showed you .. [22:44:48] yah. agreed. [22:44:58] we have a new bug wrangler coming, yes? [22:45:04] in theory [22:45:27] the problem is that we're going to need someone with a birds-eye view to call attention to stuff. [22:46:01] I think we have enough people who will cry loudly once we have a system for doing so. right now they are crying quietly. in their sleep. [22:48:44] Eloquence, there don't appear to be heinous problems with putting the next button at the top of the page [22:48:55] At least, no errors [22:49:12] mhh [22:54:13] "crying quietly in their sleep". You've just described marriage. [22:55:06] jorm, can I get you to take a side on that? :P [22:55:21] a side on marriage? [22:55:42] he said, causally looking around to see if his wife could see the computer screen. [22:58:02] marktraceur_, make some screenshots so jorm can give a qualified opinion :) [22:58:24] Eloquence, screenshots of the next button or a marriage? I have both [22:58:37] I'm not going to go there [22:59:55] AaronShculz you guys all done with your deployment? [23:01:12] Fair 'nuff, let me upload some [23:02:18] Deed page: http://i.imgur.com/5ICOJ.png [23:02:34] Details page (with error): http://i.imgur.com/0kuBo.png [23:02:47] Upload page: http://i.imgur.com/BUzEJ.png [23:02:58] Tutorial page: http://i.imgur.com/1fxfO.png [23:04:30] The patch is all queued up if you think it's worth the trouble [23:04:59] mh, needs more thought [23:05:09] sec. [23:05:48] mark? [23:05:52] jorm, aye? [23:05:56] are you in the office tomorrow? [23:06:00] I will be! [23:06:20] can you schedule a meeting for us? [23:06:30] say around 1:00? [23:06:49] myself (bharris@) and add vibha as optional (vbamba@) [23:06:54] About the usability of the next buttons? Sure, I'm free. I don't know how to go about scheduling, though [23:07:04] i'll do it. [23:07:09] what's your email? [23:07:15] mtraceur? [23:07:22] jorm, mtraceur@member.fsf.org [23:07:36] oh. yer not on the googles thing, then. [23:07:48] No, but I can still accept and reply to invitations sent by it [23:08:35] k. i've sent the invite. [23:09:22] See you then! [23:18:27] Sooo how does an extension get added to Bugzilla? [23:22:14] StevenW: ask somebody with admin perms on bugzilla to add it… or file a bug requesting it ;) [23:22:31] i think i can add for you if you need something [23:22:53] It's Extension:LastModified [23:23:24] ok [23:23:31] should there be default assignee or anything? [23:25:25] you can put me (swalling@wikimedia.org), Alolita, kgladstone@wikimedia.org, and olivneh@wikimedia.org on the default CC list [23:26:17] StevenW: what's the addr to use for alolita? [23:27:16] asharma [23:27:47] thx [23:28:07] StevenW: it's saying there's no match for olivneh -- needs a bugzilla account created? [23:28:20] yeah [23:28:30] do you want me to ask him to do that? [23:28:34] yes pls [23:28:36] k [23:28:46] in the meantime, alolita and karyn being on there is enough [23:29:10] ok :D [23:29:19] 'The component LastModified has been created. ' [23:29:22] go for it [23:29:53] thank you! [23:30:00] sure thing [23:39:36] Nikerabbit: poke poke [23:40:03] Nikerabbit: I'm not sure which change it was, but you screwed up .gitmodules in wmf/1.20wmf3 [23:40:25] Reedy: you did too [23:43:12] Ryan_Lane: we all broke the damn! [/SP reference]