[00:13:20] RoanKattouw: Our Wikimania talk was accepted, right? Did you hear this from someone or just based on the wiki edit? [00:13:33] Yes, it was [00:13:35] I got a notification [00:13:42] Okay, good. [00:13:43] I'm also responding to Danielle's e-mail BTW [00:13:55] Almost ready to send that, it'll include a list of when I'm where over the next 3 weeks [00:14:03] I'm responding to another mail to Alolita/Terry [00:14:27] oh you mean "Gadget Rehearsal" ? Haven't read that mail yet [00:14:39] OK [00:14:50] Which is the one you're responding to? Or was I not on it? [00:16:20] You weren't on it [00:16:32] RE: Visiting SF in 2012 [00:16:49] Oh OK [00:17:12] The "when" of that depended on Wikimania. [00:35:51] So is that decided yet? [11:30:46] @reload [11:30:46] Channel config was reloaded [11:30:50] @infobot-on [11:30:50] Infobot enabled [11:30:51] petan|wk: Invalid arguments [11:30:58] dbbot-wm: hi [11:31:08] !bug 2 [11:31:19] https://bugzilla.wikimedia.org/show_bug.cgi?id=2 [17:14:23] gwicke: Do you have time to talk about VE for a bit? [17:14:32] prepping for 20% checkin for today - brion, TrevorParscal, RoanKattouw, jdlrobson, rmoen [17:14:33] RoanKattouw: sure [17:15:10] hello [17:15:16] TrevorParscal: IIRC you're doing the OnlineStatusBar review continuing today? [17:15:16] hello [17:15:42] jdlrobson: can I ask you for some code review of volunteer patches/commits tomorrow? [17:15:42] gwicke: Let's wait for the 20% check-in to finish, but we should talk after [17:15:54] sure sumanah - anything in particular? [17:15:55] RoanKattouw: any particular plans for today? [17:16:20] jdlrobson, can you be bribed into making Extension:Cite popups not suck as part of 20%? [17:16:34] TrevorParscal: was wondering whether you are interested in SignupAPI code review -- Alolita pinged me about asking you about that for sometime soon, maybe next week once you are done with OSB? [17:16:42] hi sumanah, I plan on continuing project status helper today. [17:16:54] sumanah: Git office hour, mentoring a new hire, NP deployment, working on Berlin tutorials [17:16:55] sumanah: sounds good [17:16:58] rmoen: great! how's that going? need any input from guillom or Tomasz? [17:17:04] I will start taking a peek [17:17:12] TrevorParscal: great, thanks. Kaldari may have started on it [17:17:18] i will ping him [17:17:23] RoanKattouw: Sounds great! Thanks. [17:17:29] Hmm, I talked to Alolita about SignupAPI yesteray [17:17:42] jdlrobson: there's a shared search in Bugzilla marked "MW extensions with patches that need review" [17:17:49] jdlrobson: and another "MediaWiki patches that need review" [17:17:53] I recommended she ask robla to get Reedy to review it, but somehow it seems to still have ended up with Kaldari and Trevor? [17:18:03] sumanah, i'm still working through some of the reqs, should have it mostly done today.. I will ping tfinc when I have something close [17:18:26] which one? [17:18:29] rmoen: great. would you mind cc'ing me & guillom as well? it will cheer Guillaume :) [17:18:42] rmoen: thanks [17:18:44] sure thing ;) [17:18:49] sumanah: link? I can't seem to find it.. [17:19:10] in the sidebar [17:19:14] jdlrobson: https://bugzilla.wikimedia.org/userprefs.cgi and click the "saved searches" tab -- actually, direct link, [17:19:15] https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches [17:20:17] TrevorParscal: I'm curious re preliminary results from your OnlineStatusBar review but I can hold my curiosity till you comment on the bug [17:20:47] sumanah: is there a way to filter this to primarily javascript patches? I'd feel more comfortable reviewing code which isn't too PHP heavy [17:20:48] jdlrobson: once you see those saved searches, you can add what you want to the "footer" (the sidebar) [17:21:35] jdlrobson: a lossy proxy for that would be to edit your search to select only some components, like "visual editor" or other more frontend-y bits [17:21:42] sumanah: i provided an in-depth ui review and I'm talking to the author today to sort out some of the last code bits [17:22:16] TrevorParscal: oho! sweet, glad -- sounds like the answer is not "no way Jose", which is what I had mildly feared [17:22:24] lol [17:22:25] jdlrobson: I can also go through and pick a few for you [17:22:33] ok sumanah I'll have a think around that - I used certain filters last week to find more relevant patches [17:22:53] on that subject I reviewed this one last week - https://bugzilla.wikimedia.org/show_bug.cgi?id=24515 - what should I do when reviewed? [17:23:55] jdlrobson: looks like the outcome of the review is that you approve it? [17:24:38] well there were a few things I couldn't replicate and as a result I only felt part of the patch was needed - wasn't sure how to mark that apart from leave a comment on that subject [17:24:46] jdlrobson: if you approve the patch, then you can just go ahead and submit it as a new branch in Git... [17:24:47] subbu: I finally landed the second part of the token stream transform overhaul today [17:24:58] subbu: so some details have changed a bit [17:25:17] jdlrobson: hm, ok - it sounds like the issue is perhaps that the codebase has changed since the author originally submitted it? [17:25:23] subbu: the good news is that the core is now quite well commented [17:25:46] maybe - i'm still familiarising myself with the non-mobile code so will take a bit of time for me to become effective [17:26:20] gwicke, ok. i'll check with you as i have questions. [17:26:32] subbu: if you'd like to play with a small task, this might be an interesting one: http://www.mediawiki.org/wiki/Parsoid/Todo#Cache_transforms_per_token_type.2C_and_add_more_specific_.27any_tag.27_transform_category [17:26:33] jdlrobson: reasonable... btw another thing you can do is to answer questions on https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend [17:26:59] np can do that [17:27:53] jdlrobson: so regarding bug 24515 , here's what I would do -- change the keyword "patch-need-review" to "patch-reviewed", assign the bug to the patch author, and suggest in a comment that the author respond to the review and get developer access so s/he can use Git directly in the future [17:27:54] gwicke, alright. will take a look. [17:27:54] link to https://www.mediawiki.org/wiki/Developer_access [17:28:22] sumanah: ok that makes sense [17:28:23] subbu: do you already have a gerrit account? [17:28:28] great! thanks jdlrobson [17:28:39] nope [17:28:46] or at least i dont know if i already have one [17:29:05] subbu: http://www.mediawiki.org/wiki/Git/Workflow [17:29:06] also sumanah is there any chance we can do this a little earlier next week (maybe 30/45 minutes earlier)- I have to dash off at 6.15pm UK time [17:29:11] gwicke: want me to check? in ListUsers on labs? [17:29:29] jdlrobson: certainly! how about we set up a separate appointment earlier in our day Tuesday [17:29:32] sumanah: that would be great [17:29:38] jdlrobson: I'll just request it for you in Google Calendar [17:29:46] gwicke: checking https://labsconsole.wikimedia.org/wiki/Special:ListUsers now [17:29:57] although he might not yet be registered [17:30:03] I don't see a subbu there [17:30:17] sumanah: earlier would be much better - only needs to be till week starting 11th June though as my flight to SF is on 10th [17:30:31] sure! [17:30:43] thanks for the tip, jdlrobson - and happy packing :) [17:30:46] thanks for the checkin, everyone [17:30:55] subbu: https://www.mediawiki.org/wiki/Developer_access would be the place to request it [17:31:15] brion: if you want to chat that would be cool - I figure one thing you could do is work on the 3-months-later tools checkin [17:32:06] oh and jdlrobson the components within MediaWiki that would be good for you to look in (for the keywords patch & patch-need-review) are User Interface, JavaScript, & maybe Skin:Vector & General/Unknown [17:32:49] perfect [17:32:54] right see you tomorrow! [17:33:07] also subbu you should know about upcoming events we have - https://www.mediawiki.org/wiki/MediaWiki_developer_meetings Bangalore this Saturday, Washington DC in July..... [17:33:17] cheers, jdlrobson [17:33:33] gwicke, sumanah most of my wmf ids are ssastry .. so i suppose i should use that id for gerrit. [17:33:45] subbu: Your full name would also be reasonable [17:33:47] sumanah, thanks. i live in minneapolis, so a little far for me. [17:34:05] subbu: https://gerrit.wikimedia.org/r/#/q/status:open,n,z shows you some people's Git userIDs [17:34:27] subbu: oh another Twin Cities person! andrewbogott_ lives there too [17:34:54] sumanah: are there git office hours some time now? [17:35:02] ^demon: ^^ [17:35:29] <^demon> No, they were put on the calendar but I didn't send out an e-mail announcing them. [17:35:39] <^demon> We're rescheduling. I'll send out an e-mail when a new time is picked. [17:38:05] gwicke: So, visual editor [17:38:18] There's two things that we've been talking about recently that concern you in particular [17:38:39] One is that we need a Node HTTP frontend to the parser [17:39:08] Writing that should be easy, and I've created a labs VM where you can set this up and test it, then if you document what you've been doing I can puppetize it and give it to ops on a nice silver platte [17:39:09] r [17:39:12] Ori wanted to look into that last week [17:39:21] have to ping him on his progress [17:39:38] Oh, he did? [17:39:39] mark traceur started some work on the serializer [17:39:46] I have a meeting with Ori at 11:30 [17:39:52] Oh, has Mark been working on the serializer? [17:39:56] I'll take over from now [17:40:06] yes, he started on it [17:40:08] * RoanKattouw was hanging out with him on Sunday and didn't realize [17:40:45] am just chatting with him, he wants to check it in today or so, then I'll work on rt and serialization [17:40:56] the async refactor finally landed today [17:41:05] rt? [17:41:08] Round-tripping? [17:41:12] yep [17:41:16] OK, sweet [17:42:30] So yeah we have a todo list here https://www.mediawiki.org/wiki/Visual_editor/Todo_list [17:42:55] It has "Roan to ping Gabriel about: HTML5 DOM to wikitext, HTTP server for parser" [17:44:24] So let me give you access to this labs project I have [17:46:58] gwicke: You should now be able to 'ssh ve-nodejs' from the Labs bastion. I've installed nodejs there but nothing else yet. If you could install your HTTP parser service there and document how you set it up, I can take it from there [17:47:23] RoanKattouw: ok [17:47:47] The VM doesn't have a public IP, docs on how to access it are at https://labsconsole.wikimedia.org/wiki/Access#Accessing_web_services_using_a_SOCKS_proxy [17:48:00] Essentially you have to proxy through bastion.wmflabs.org in some way [17:48:03] RoanKattouw: I'll focus on round-tripping first and hope that Ori gets a basic server running [17:48:10] Oh you want Ori to work on this? [17:48:32] he made some noises that he wanted to look into it last week [17:48:40] heh [17:48:42] but he might have other stuff to do now [17:48:50] have to ping him [17:48:53] He just got here AFAIK, he's meeting me in 45 [17:49:05] then just ask him ;) [17:49:31] the idea is to use the cluster module for multi-core, logging etc [17:50:32] OK -- not familiar with any of that but you seem to know what you're doing :D [17:51:33] When is the MediaWiki 1.20/wmf3 deployment currently scheduled for? The wiki just says "May". [17:51:39] So re serialization, that's what you're focusing on now, right? Do you have any idea as to when that'll be in usable shape yet, or is it too early to tell? [17:51:52] kaldari: yesterday ;) [17:51:56] kaldari: Rolling out on various wikis over this week and next [17:51:56] well, that's when it started [17:52:31] RoanKattouw: usable shape for the release should't be far off, as it leaves out all the hard stuff [17:52:56] Sweet [17:53:09] I'll first make that work, but have some ideas for the harder bits [17:53:28] RoanKattouw: http://www.mediawiki.org/wiki/Parsoid/Todo#DOM_tree_builder [17:54:29] Reedy: thanks [17:56:39] RoanKattouw: will there already be information about modified bits in the returned DOM ? [17:57:25] (not important with everything normalized, just wondering) [17:57:39] I think Christian is going to work on a linmod -> DOM converter [17:58:01] I don't believe it plans to have change marking [18:00:10] ok [18:00:44] I can do some round-trip testing without the editor, so that is not too urgent [18:25:54] subbu|away: am also away for an hour or two, will likely come back later tonight [20:28:03] New patchset: Ottomata; "Adding ability to filter by http response status." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/7749 [21:00:07] New patchset: Ottomata; "Adding ability to filter by http response status." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/7749 [21:03:54] New review: Diederik; "Reviewed the code and didn't find any obvious problems." [analytics/udp-filters] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7749 [21:03:56] Change merged: Diederik; [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/7749 [21:42:12] Krinkle: Hey so about the Gadgets tutorial [21:42:54] Krinkle: Off the top of your head, are you aware of specific Gadgets that are not RL-compatible? [21:43:32] Cause the main setting of the Gadgets/RL tutorial as Sumana and I imagined is was gonna be helping people fix their Gadget so they don't break in RL [21:44:12] RoanKattouw: So far I have encountered 1 that was problematic [21:44:26] and I haven't checked it in a while [21:44:32] it is "Navigation popups" [21:44:36] * ToAruShiroiNeko kranks [21:44:40] o hai [21:44:45] OK [21:44:55] maintained on github, about 2 dozen js files. Lots of globals. They have a build script that minifies and concatenates it all and pastes it on the gadget js page [21:45:01] Ewwwwww [21:45:09] right [21:45:09] hmm? [21:45:45] I was going to suggest you try to find more broken ones, see who maintains them, so we can reach out to those people [21:45:45] we should probably start my importing that as a regular script into a gadget [21:45:57] yeah [21:46:05] Hopefully a few of them will show up in Berlin, or attendees will be willing to work on those gadgets, or people can participate remotely [21:46:24] The way I usually do this is by looking at Gadgest-definition and seeing if we can enable [ResourceLoader] for some of them [21:46:35] I've been adding that annotation sporadically all over the place. [21:46:37] Yeah that's pretty much what I meant [21:46:54] Hmm [21:46:57] Usually only one or two at a time. And watch for any complaints (of course starting my testing it myself in a few browsers) [21:47:08] by* [21:47:14] It shouldn't be hard to write a script that fetches Gadgets-definition from all wikis and identifies Gadgets that have RL switched off [21:47:22] nav-pops is the only one that broke, although it didn't break in Chrome [21:47:27] hah [21:47:43] only one that I "broke", that is. obvously [21:47:51] yeah, that should be fine. [21:48:02] I suppose most will have it switched off still, especially on the smaller wikis [21:50:27] RoanKattouw: We need a list of stuff that most commonly caused the breakage [21:50:45] That too I guess [21:51:14] And add it to mw:RL/MGU, where most stuff like this is already put [21:51:34] that is kinda the central place for gadget maintainers now, to look for [21:52:57] Yeah [21:53:25] we can take that page as base for the workshop. maybe a bit about resource loader in general before that. [21:53:33] Yeah [21:53:45] I was originally planning to do the RL2 presentation but maybe that's better [21:53:55] For Berlin? [21:54:01] Aye, Berlin workshop [21:54:15] Okay, I didn't get that. Either make sense [21:54:19] Sorry [21:54:26] I guess going through https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_%28users%29#Good_practices would make a lot of sense [21:55:05] but given how much stuff is still pre-1.17, we really need to get stuff up to date. not just for RL gadgets, but user scripts and extension maintainers as well. [21:55:15] * Nikerabbit gives RoanKattouw and Krinkle a cookie [21:55:21] introduce RL, then go through a few good practices most of which are required for RL, others are just good. [21:55:40] Yeah [21:55:49] So, we need material for this :) [21:56:10] If we're gonna tell people about RL, there should be like a list of points on a wiki page somewhere [21:56:23] If people are expected to do something beforehand, that should be on a wiki page too [21:56:47] touching RL2 sounds good too, but from Sumana I got the scenario that people wanted to get working with something they can do right now. Naturally this will contribute to the RL2 update. All RL-compatible gadgets from gadgets 1.0 should automatically work in 2.0 [21:57:34] Exactly [21:57:44] That's the ulterior motive behind this [21:57:54] muhaha ;-) [21:58:01] RL2 will drop pre-RL compat, so we need to get people to migrate early [21:59:27] RoanKattouw: We could do a short Tour as well. Whenever I "Tour" a wiki, there is a lot of interesting stuff coming by. Most of it is on RL/MGU already, but if we can't find any gadgets, we could tour a wiki on stage. That would give equally useful info. [21:59:44] Right [21:59:53] Have you done a tour? [22:00:18] I have never done one no [22:01:58] Maybe we can both do one tomorrow. And check if everything is up to date in the docs. [22:02:41] should take maybe 30 minutes per wiki. Since we'll probably be fixing docs, it guess it'll take an hour [22:02:58] Yeah [22:12:20] Reedy: for a config change to the cluster i just need to do a git commit, then "git push", right? [22:12:24] then sync-file? [22:12:32] Yup [22:33:24] I'm getting a lot of API errors on en.wiki from various tools... [22:33:43] they're all: Error: ERR_SOCKET_FAILURE, errno (98) Address already in use at Tue, 15 May 2012 22:14:05 GMT [22:33:49] or similar [22:38:39] kaldari: eh, sorry, after midnight over in Europe, but fyi and for now. we did dist-upgrade / reboot a lot of API squids [22:39:14] cool, I'll keep an eye on it and let you know if it doesn't improve [22:40:02] sure, or feel free to open RT , i'll check. had to kernel upgrade due to weird kernel bug with 211 days uptime crashing it [22:41:39] bbl, if its urgent please check in ops channel with others, Leslie would be perfect but she is also over here currently