[08:37:55] good morning [08:38:14] does anybody know how to setup wiki that admins have to unlock new article [12:51:56] hi. where does this need to be fixed? https://bugzilla.wikimedia.org/show_bug.cgi?id=36835 [12:52:26] trying to get job_queue monitoring back up, but unsure about those php1.18 directory fails [12:53:14] it is looking in CommonSettings.php, getting an 1.18 reply, and then fails to require stuff from the 1.18 path [17:28:23] Change on 12mediawiki a page OAuth was modified, changed by RobLa-WMF link https://www.mediawiki.org/w/index.php?diff=537588 edit summary: Adding activity page template [17:30:19] Change on 12mediawiki a page OAuth was modified, changed by RobLa-WMF link https://www.mediawiki.org/w/index.php?diff=537590 edit summary: trailing noinclude [17:32:04] Change on 12mediawiki a page OAuth was modified, changed by RobLa-WMF link https://www.mediawiki.org/w/index.php?diff=537591 edit summary: removing errant noinclude [17:35:26] hrm....this channel *was* blissfully bot free [17:36:12] (at least, in terms of unsolicited bot chatter) [17:38:11] yeah. no bots in here, please. [17:39:55] oh, man. [17:40:07] if that thing is going to spit out comments everytime someone edits on mw.org... [17:58:45] Git rage. [18:02:11] Reedy: going that well? [18:02:20] computers rule! [18:02:23] Nearly there ;) [18:03:02] someone here (don't remember who) is fond of saying "computers sucks", but they are wrong because computers are awesome. that is all [18:05:28] Usually me.. [18:07:27] Just copying onto nfs now [18:08:01] Now [18:08:09] Should I blow 1.20wmf1 away first... [18:08:42] After you fix the php symlink [18:08:52] I already have [18:08:56] did it sometime last week [18:09:06] Though, not exactly sure if it's sync'd [18:09:27] If I use sync-dir/sync-file doesn't it copy the whole tree, rather than just the symlink? [18:11:39] lrwxrwxrwx 1 mwdeploy mwdeploy 12 2012-05-09 21:54 php -> php-1.20wmf2 [18:11:41] Already done [18:12:14] cool [18:12:23] Yeah you can't sync-filei t [18:12:47] You could run ln -sf over dsh [18:13:28] yeah, that's what I was going to do, but isn't needed [18:13:37] should we add smarter symlink handling to sync-file? [18:13:54] Some of the scripts will copy symlinks fine [18:14:01] (yay, consistency) [18:14:28] if one runs sync-dir on a symlink, you might expect it to copy the directory [18:14:42] however, if you run sync-file, you almost certainly just want the symlink [18:17:35] yeah [18:18:59] Though, I'm not sure we've any reason to want it to copy all the files rather than just the symlink [18:22:05] If you sync-dir (or scap) the directory that contains the symlink, it'll also work [18:22:34] == Deployment Caveats == \n\n * Everything [18:25:34] RoanKattouw: fyi: currently we gotta manually copy wikiversions.* files on spence for check_job_queue to not break. it checks in a local path instead of /home (but that does not mean we want checks that rely on NFS either;) well, there are some details in BZ 368385 [18:25:51] Ah Ok [18:26:07] Is spence in the mediawiki-installation list? [18:26:09] also in SAL today [18:26:31] i don't think it is [18:27:23] Perhaps it should be [18:27:25] should be just the monitoring server [18:27:25] Although, well -- [18:27:37] That requires that deployers have shell access to that server, also not very nice [18:28:29] if there was some way for it to have up-to-date wikiversions.dat files automatically, while avoiding NFS , that would be great [18:28:47] reedy@fenari:/home/wikipedia/common$ scap Rebuilding localisation files for 1.20wmf3 [18:28:47] Checking syntax... [18:28:47] /usr/local/bin/lint: line 2: 26981 Segmentation fault php -n -dextension=parsekit.so `dirname $0`/lint.php "$@" [18:28:47] Found syntax errors in 1.20wmf3, cannot sync. [18:28:48] sync failed [18:28:49] maybe like the memcached check , fetchning it via http instead [18:28:52] How... useful? [18:29:16] lol [18:29:31] I'm not slacking, PHP is segfaulting [18:29:38] mutante: You mean fetch the config file over http? Is that what the memc check is doing? [18:30:01] RoanKattouw: yes, it does PHP file_get_contents() [18:30:34] it was PHP anyways..and we wanted to get rid of the link into /home [18:31:07] and the config was on noc .. so... [18:35:37] !bz 36835 | RoanKattouw [18:36:03] ok:) well, for now just fyi, gotta go [18:37:38] reedy@fenari:/home/wikipedia/common$ lint php-1.20wmf2 [18:37:38] reedy@fenari:/home/wikipedia/common$ lint php-1.20wmf3 [18:37:38] /usr/local/bin/lint: line 2: 27471 Segmentation fault php -n -dextension=parsekit.so `dirname $0`/lint.php "$@" [18:39:02] RoanKattouw: might this have anything to do with the pcre fix? [18:39:40] PageTriage passes fine [18:40:19] Reedy: oh....another possibility: memcache client implementatoin [18:40:34] Did that get merged already? [18:40:38] This should not be related to the PCRE fix [18:40:57] Because 1) it *lowers* the recursion limit, *preventing* segfaults and 2) we only changed the php.ini for Apache, not for the CLI [18:41:12] mmm [18:42:54] Reedy: could just try bisecting...it's only a couple weeks of code [18:49:54] I wonder what even has changed in this branch [18:51:46] linting before I did a submodule update worked just fine [18:55:06] php -n -dextension=parsekit.so `dirname $0`/lint.php "$@" [18:58:53] https://test2.wikipedia.org/ [18:58:57] I guess it is right then [18:59:20] Ah [18:59:20] 3 Parse error: syntax error, unexpected ')' in /usr/local/apache/common-local/php-1.20wmf3/LocalSettings.php on line 4 [19:02:18] PHP fatal error in /usr/local/apache/common-local/wmf-config/CommonSettings.php line 711: [19:02:18] require() [function.require]: Failed opening required '/usr/local/apache/common-local/php-1.20wmf3/extensions/Cite/Cite.php' (include_path='/usr/local/apache/common-local/php-1.20wmf3:/usr/local/apache/common-local/php-1.20wmf3/lib:/usr/local/lib/php:/usr/share/php') [19:03:14] God damn it [19:17:08] right [19:17:12] That should be test2wiki now [19:17:22] Need to rebuild the localisation files now [19:19:47] Reedy: http://test.wikipedia.org/wiki/Special:Version <- kaboom [19:20:15] PHP fatal error in /home/wikipedia/common/php-1.20wmf2/LocalSettings.php line 4: Call to undefined function dir_exists() [19:20:51] fixed [19:21:17] now just a matter of making it 1.20wmf3 :) [19:21:59] test2wiki is on 1.20wmf3 [19:22:23] yup, but we're doing test, test2, and mediawiki.org today [19:22:48] indeed [19:24:37] I suspect all of the symlinks won't be pushed out yet [19:25:07] uploadwizard failure on test2 [19:25:20] most likely missing js [19:25:33] "An unknown error occurred." on the last step of the upload [19:25:50] seems to be something with copying from the stash into the real place [19:27:31] hmm, there was a typo in my auto-connect list [19:27:40] '.' instead of '/' [19:27:41] AaronSchulz: UploadWizard fails on the final step of uploading [19:27:55] on test2 [19:28:55] I think everything on bits is 404'ing [19:29:18] I'll see if scap will run properly in a few minutes [19:29:35] then we know everything should be upto date, rather than chasing potential false alarms [19:29:58] oh wait...I was on test, not test2 [19:30:11] * robla tries test2 [19:30:12] I moved test over too [19:31:34] For PageTriage, should console.log( 'would insert toolbar on this page' ); still be in? [19:34:55] php-1.20wmf2 has a load of OOMS atm [19:56:45] Yay, scap hasn't even finished and it looks to have fixed the 404s [20:05:47] Scap done [20:12:56] Change on 12mediawiki a page OAuth was modified, changed by RobLa-WMF link https://www.mediawiki.org/w/index.php?diff=537646 edit summary: Some reorganization [20:14:02] weird, it's only oauth page changes that trigger the bot [20:28:37] can we still get rid of the bot? [20:30:13] Change on 12mediawiki a page OAuth was modified, changed by Jorm (WMF) link https://www.mediawiki.org/w/index.php?diff=537651 edit summary: spurious apostrophes. [20:45:52] PHP fatal error in /usr/local/apache/common-local/php-1.20wmf3/extensions/Translate/tag/TranslatablePage.php line 108: [20:45:52] Argument 1 passed to TranslatablePage::newFromTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.20wmf3/extensions/Translate/tag/PageTranslationHooks.php on line 414 and defined [20:45:59] seeing on mediawiki.org [20:46:20] Reedy are you guys still deploying? [20:46:35] oh not even in this channel ... [20:55:34] awjr: have any specific page? I just made an edit that worked. https://www.mediawiki.org/w/index.php?title=User%3ASiebrand&diff=537666&oldid=531580 [20:56:08] the mailing list server appears to be having problems, too. [20:57:49] siebrand yeah, lemme try again [20:58:02] still seeing the fatal [20:58:03] http://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend/Deployments/2012-05-14 [20:58:05] siebrand ^ [20:58:14] awjr: it's page creation, not editing [20:58:19] doh you're right [20:59:38] Can't reproduce on translatewiki.net. [21:00:30] Reliably reproducable on mediawiki.org, indeed. [21:00:54] * robla tries test2 [21:01:27] no luck there [21:01:29] robla: there it works. [21:01:34] Hmm. [21:01:43] PHP fatal error in /usr/local/apache/common-local/php-1.20wmf3/extensions/Translate/tag/TranslatablePage.php line 108: [21:01:43] Argument 1 passed to TranslatablePage::newFromTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.20wmf3/extensions/Translate/tag/PageTranslationHooks.php on line 414 and defined [21:01:52] http://www.mediawiki.org/w/index.php?title=MediaWiki_1.20wmf3&action=submit [21:02:47] yeah, obviously something's wrong for some reason… Thinking what that may be at mediawiki.org. [21:03:03] What's being deployed? master HEAD? [21:03:07] yeah [21:03:15] well, all but [21:03:20] same version is on test and test2 [21:03:42] that's what twn is running. [21:04:07] we're suffering from [14-May-2012 21:00:46] PHP Fatal error: Class 'StringParam' not found in /www/w/extensions/SemanticMediaWiki/includes/params/SMW_ParamFormat.php on line 15 [21:04:07] , but that's not related. [21:06:04] petan: ping [21:06:41] Reedy: I think safest is to return true in updateTranstagOnNullRevisions immediately for now. [21:07:01] sure [21:07:48] Reedy: that's a recent change to catch an edge case in page translation. Should make things worse compared to what is currently deployed, and then tomorrow Niklas can sort out what's going on. [21:08:07] Reedy: could you in some way get some more info from that event? [21:08:47] Could do [21:09:03] I don't suspect the revision object is going to be small though [21:09:54] The function is disabled for now.. [21:12:29] Reedy / robla : https://bugzilla.wikimedia.org/show_bug.cgi?id=36846 reported. Will be addressed tomorrow. [21:12:47] It's 00:15 in Finland, so Niklas is hopefully sleeping now. [21:13:27] awjr: should be working now [21:13:37] robla: it is, thanks! [21:14:20] Reedy, siebrand, et al thanks! [21:14:39] awjr: Thank YOU, Arthur. [21:14:56] I'll log a bug for that [21:32:46] New patchset: Ottomata; "Putting delimiter back at space for now." [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/7672 [21:51:00] Change abandoned: Ottomata; "Hmm, this merge was weird. Going to try again with --no-ff" [analytics/udp-filters] (master) - https://gerrit.wikimedia.org/r/7672 [22:01:35] what is this bold watchlist feature? is it $wgShowUpdatedMarker? [22:02:54] Yeah [22:03:19] it doesn't look bold to me on enwiki, maybe it was disabled in CSS already [22:03:43] It might have been changed a few times [22:04:10] there was a lot of drama about it on enwiki TimStarling [22:04:15] see VPT [22:04:17] yeah, I saw [22:06:48] yeah, it's there in common.css [22:07:36] https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=492257419&oldid=492123729 [22:08:01] that was a couple of days ago [22:12:12] I'm surprised nobody made it a preference [22:12:21] I mean, we have preferences for much lesser things [22:12:28] it's been in mediawiki since like 2004 [22:12:46] on by default [22:12:55] if it's so horrible, maybe someone should have complained sooner [22:13:43] Well, you never know whether peope on enwiki gonna like it [22:13:52] Even more so if they actually ask for the change [22:14:06] actually speaking of 2004, I may have some history here [22:14:31] you know how watched changes are bolded in recent changes? [22:14:55] Yeah [22:15:03] They'd noticed changing css in one place changes both [22:15:23] originally mediawiki had a bug/feature where all of the pages on the watchlist were bolded, because the code was shared and all pages on the watchlist were watched [22:15:37] I think I fixed it so that it wasn't bold [22:16:29] It's interesting how different changes get accepted or not [22:17:06] I remember when FlaggedRevs was enabled on ru, some people wanted to lynch me [22:17:36] I had an arbcom case demanding that I should be desysopped for filing a bugzilla request (an excellent, logical solution) [22:17:59] And right now most people think it's something natural and that it always was around [22:18:22] There's some great reactions on WP:VPT [22:19:23] What's interesting, while I have not met FlaggedRevs-hater for last three years, I know a lot of users who are still on monobook, even those who came after Vector became a default skin [22:22:10] I think people are more conservative about UI than about the actual mechanisms of how Wikipedia works [22:39:05] is there any interface in Gerrit for just browsing the code, like the old http://svn.wikimedia.org/viewvc/mediawiki/trunk/ ? [22:39:12] Yes, gitweb [22:39:17] where's that? [22:39:22] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git [22:39:56] oh nifty [22:40:37] We also have an OpenGrok setup in labs, but it had some issues recently as far as I am aware [22:53:51] There's also blame in the interface now! [22:56:14] With its fancy abberviations [23:40:50] Reedy: willing to review https://gerrit.wikimedia.org/r/#/c/7298/ ? :-D [23:41:19] I thought you went to bed? :p [23:43:55] Reedy: I did [23:44:16] Reedy: then woke up :-(