[00:07:17] the most significant question there is: can a post-upload processing task be distributed onto multiple CPUs? a close second: if so, does that imply it would be unnecessary to enqueue a job for that processing? [00:08:57] depends what you mean by post-upload [00:10:10] * AaronSchulz giggles whenever the topic of job queues comes up [00:22:02] by post-upload i mean as soon as is feasible after the upload of a file completes. the task is generating a ray-traced static image from a plain-text, which might be necessary for the user to see to verify their upload went properly [00:22:14] plain-text file* [00:23:29] RoanKattouw: maybe you can take a stab at getting mw-bot up and running ? I recall you fixing it once before [00:23:57] the phoenix service on toolserver is working fine, but the java executing is crashing with an exception right after it starts (doesn't even join irc) [00:24:01] something about the botclass [00:24:03] Krinkle: Its brain file is corrup [00:24:04] botbriainclass* [00:24:05] t [00:24:12] right [00:24:19] I don't know how to fix /that/ [00:31:54] Joan: Raaaaah [00:32:08] Joan: Did you see http://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Database_reports&diff=491904588&oldid=491897821 ? [00:32:15] That was my testing going through [00:32:21] But if I try to undo that edit, I hit the bug [00:32:37] 0:0:0:0:0:0:0:1 ?:/ [00:32:41] Hah [00:32:45] Someone else did manage to undo it [00:32:47] weird [00:33:14] Oooh right you said the edit goes through despite the error message [00:33:16] I forgot about that [00:33:41] It's gonna be hard to track down this particular segfault [00:59:17] RoanKattouw: I didn't have any issue getting edits to go through. ;-) [00:59:26] §ion=new will post over and over again. [00:59:32] Riiight [00:59:33] If you go back and click "save page" over and over. [00:59:38] That's what I should have used [00:59:47] That's not too hard to fake internally [00:59:53] Is this still occurring? [01:00:09] Yes. [01:00:22] OK [01:00:24] Null editing is the easiest and cleaniest triger, BTW. [01:00:25] Lemme try it now [01:00:28] Err, cleanest. [01:00:36] Just click edit and click "save page." [01:00:48] No, it's not easy to grab a 150 KB POST request and run it through to an Apache internally [01:00:53] It's easier to create a new section [01:00:58] (although it will clutter the history) [01:01:13] Oh, you're trying to do it internally? [01:01:52] I'd think you could just turn on (MediaWiki) debugging for that page. [01:06:15] [[Wikipedia talk:Database reports]]; SineBot; Signing comment by [[Special:Contributions/208.80.152.165|208.80.152.165]] - "/* Testing ERR_ZERO_SIZE_OBJECT bug */ new section"; https://en.wikipedia.org/w/index.php?diff=491910994&oldid=491910823 [01:06:19] Heh. [01:07:12] Well it's a segfault [01:07:34] I can't track it down without gdb [01:11:16] Grr this is hard [10:38:18] help [10:38:32] error: You have local changes to 'DeviceDetection.php'; cannot switch branches. [10:52:03] Nikerabbit: well... what does git diff say? [10:52:23] Daniel_WMDE_: I don't care peanuts, I just wanted to deploy my fixes [10:53:40] Nikerabbit: so, just revert DeviceDetection.php? [10:53:53] git checkout -- DeviceDetection.php [10:53:58] all local modifications are lost [10:54:01] Daniel_WMDE_: I'm not going to revert other peoples stuff [10:54:07] other people's? [10:54:12] Daniel_WMDE_: this is on the cluster [10:54:21] eek. [10:54:31] well... that sucks :) [10:54:35] you could just commit it. [10:54:54] git commit -a -m "stuff someone left lying around uncomitted" [10:55:16] which would cause problems next time someone tries to udpate it to master [10:56:58] well then, i have no idea [10:57:23] Krinkle: it's already PITA to deploy anything and you want to make it even more difficult? [10:57:28] well, you could make a patch, revert it, do your thing, and then re-apply the patch, leaving the repo as dirty as it was before... [10:58:32] Daniel_WMDE_: instead, I'm going to complain that third time in a row I'm not able to deploy and that documentation sucks [10:58:59] :P [16:34:53] hey rsterbin [16:34:59] what's up? [16:35:03] hi there [16:35:14] a quick sanity check on FeedbackPage [16:35:24] I'm generating some usage stats for Fabrice [16:35:32] and looking at Barack Obama [16:35:47] ok... [16:35:55] The global counter says "1230 feedback posts on this article" [16:36:26] I'm trying to figure out how you get this figure: [16:36:55] that's everything, even deleted comments [16:37:00] a count(*) in aft_article_feedback gives: 2356 [16:37:16] SELECT COUNT(*) FROM aft_article_feedback WHERE af_page_id = 534366 [16:37:19] if i log in, i get that as the count for the "All (Oversight)" filter [16:37:29] hm [16:37:36] that's odd [16:37:53] while SELECT COUNT(*) FROM aft_article_feedback WHERE af_page_id = 534366 AND af_has_comment; gives 956 [16:38:21] so I am wondering if FeedbackPage uses some filters I am not aware of [16:38:37] * DarTar looking up the code [16:38:40] i can take a look at the query [16:38:44] thanks [16:38:50] ...or you can, if you like ;) [16:38:58] it's in ArticleFeedbackv5.fetch.php [16:39:03] k hang on [16:39:25] i don't know if have time to debug it right this minute, but i can look into it and get back to you [16:39:40] actually, can you submit a bug? [16:40:05] if this turns out not to be simple, we'll want all our findings in one place [16:40:12] sounds good [16:40:19] thanks [16:42:47] ha, L216 [16:42:50] // Only show bucket 1 (per Fabrice on 1/25) [16:42:50] $where['af_form_id'] = 1; [16:42:57] aaaaah [16:43:05] :) [16:43:06] i had totally forgotten about that [16:43:22] do the counts match when you add that to your where clause? [16:43:27] does he still want to see Option1 only? [16:43:33] let me see [16:43:47] as far as i know that's still the requirement [16:45:07] yep: 1230 [16:45:15] great [16:45:26] i think we should still fix the count, though [16:45:34] it should be the total visible for the given user [16:45:55] right [16:46:17] ok, no matter what the UI is displaying I'll give Fabrice the actual usage stats from the DB [16:46:26] and check with him if he wants them filter for option1 only [16:51:20] resterbin – mailed Fabrice and cc'ed you [16:51:29] s/resterbin/rsterbin [16:51:51] thanks [17:15:58] OK, 20% checkin time for Friday, 11 May [17:16:27] I know preilly is working on the Git tutorial stuff with Danielle [17:17:18] hashar: Reedy: how are your plans faring? [17:18:41] kaldari: how was your last Friday? [17:18:47] kaldari: UploadWizard & GSoC stuff? [17:18:58] * sumanah doesn't see awjr, presumes he is working on the HTML forms stuff [17:27:08] hi awjr [17:27:21] sumanah: hello [17:27:55] awjr: Am I right in thinking that you are working on the HTML forms stuff? [17:30:40] Nikerabbit: PITA deploy something, can you elaborate? I missed it yesterday, I read it now in the ping logs [17:31:07] sumanah: im waiting for someone to review my htmlform changes from last week - i am now working on a script to automate posting of git changelogs to a wiki page [17:31:15] awjr: rock! [17:31:29] awjr: have you added any reviewers to request review via Gerrit? [17:31:39] sumanah no [17:31:44] i dont think i knew you could do that [17:31:59] awjr: scroll down on the changeset and look for something called "add reviewer" I think [17:32:20] oh yeah, fancy [17:32:28] cool [17:32:51] lemme look through the git blame for htmlform stuff to see who's worked on it in the past- i think werdna might be an obvious candidate [17:33:53] OK [17:38:08] <^demon> awjr: Yes, HTMLForm is werdna's fault^H^H^H^H^H invention ;-) [17:38:15] hahahaha [17:38:34] * awjr shakes fist at werdna [17:38:51] <^demon> He wrote it when he rewrote preferences like a year and a half ago. [17:39:05] <^demon> Or has it been like 2 years already? Dunno...time flies and all that shiz. [17:39:16] I think it's >2y yeah [17:39:39] Or 3? I think it had just been done when I joined WMF [17:39:47] <^demon> It all blurs together. Before you know it, we'll be like "I remember when Tim rewrote the preprocessor like it was yesterday" :p [17:40:23] * RoanKattouw reminisces about Special:ParserDiffTest [17:41:37] <^demon> Oooh, I remember that :) [17:42:03] <^demon> I also remember when all the e-mails went out when e-mail confirmation was added :) [17:42:16] hmm I don't remember that one [17:42:29] <^demon> ....late '04? [17:42:31] <^demon> I think [17:42:41] <^demon> Maybe early '05 [17:43:11] Oh, that's before my time then [17:55:24] good luck getting the codereview, awjr [18:07:34] so bsitu will fix bug 14901 today, awesome! :D [18:44:04] !log deployment-prep running puppet on dbdump in the hope of fixing log file rights [18:53:05] RoanKattouw_away: where are you? [19:02:05] hi [19:02:17] Preprocessor_HipHop.hphp is a wrong named file in current 1 19 rel? [19:06:20] Why? [19:06:48] What's wrong with it? [19:30:59] Reedy: i dont know .hphp extension. maybe a typo? .php instead? [19:31:08] No, it's purposely done [20:17:06] How do you search by owner in Gerrit? [20:17:36] if I put a username in the search field it just gives me an error [20:23:20] Reedy: is hphp a well known extension or selfmade? [20:28:24] kaldari, did you try real name? [20:28:52] yeah [20:29:23] https://gerrit.wikimedia.org/r/#/q/owner:kaldari,n,z ? [20:29:55] thanks [20:30:05] 'owner:whoever' seems to work [20:30:26] ah, yes, you need to learn all those prefixes... [20:32:28] what is this? a search engine for programmers? ;) [21:01:00] Reedy, TrevorParscal, robla: Sorry for being AWOL this morning. I was being interviewed by the culture study people, and they care a lot about anonymity so their interview aren't on the calendar etc and they won't share the list of who they're interviewing, that's why you couldn't find out where I was [21:03:55] nn8 [21:07:38] RoanKattouw: and of course you state that on a public channel ? :-D [21:07:50] hehe [21:08:09] I'm comfortable with people knowing they interviewed me [21:08:29] But they protect your anonymity by default, that's why it was set up the way it was [21:09:05] makes more sense no :) [21:09:07] now [21:37:37] http://commons.wikimedia.org/wiki/File:Iridescent_Glory_of_Nearby_Helix_Nebula.png [21:37:52] is this file corrupted or is it mediawiki unable to handle the large file [21:38:20] It's not MWs fault [21:38:37] Thumbnailing a 173MB image is gonna need a lot of memoru [21:39:47] more than the 300M we currently have I guess [22:11:36] RoanKattouw: no GPL 3 ok ? [22:11:38] :)D [22:24:36] Reedy: that mediawiki-config.git is scary :-D [22:24:50] Why? [22:25:08] ohh no forget me [22:25:16] I thought you added all the php-XXXX directories :-D [22:25:25] they are in .gitignore [22:26:08] haha